[okular] [Bug 375964] Okular crashed when I hit Escape

2017-02-03 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=375964

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #12 from Albert Astals Cid  ---
Sadly the backtrace is close to worthless.

Can you reproduce the crash every single time?

If you can reproduce the crash every single time, can you run okular with
valgrind (give it some time, it'll be slow), can you paste the trace here?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 375964] Okular crashed when I hit Escape

2017-02-03 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=375964

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #11 from Albert Astals Cid  ---
linearGradient4582 warnings are icons/SVG parsing warnings, totally not
relevant.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 129893: Implement continuous search

2017-02-03 Thread Albert Astals Cid


> On Feb. 2, 2017, 11:38 p.m., Albert Astals Cid wrote:
> > i'm not sure i agree with this change, but this doesn't seem the proper way 
> > to do it, if we're going to continue searching anyways, don't send a 
> > Okular::Document::EndOfDocumentReached, just continue searching.
> 
> Elvis Angelaccio wrote:
> Should we ask input from the usability team maybe? I find the messagebox 
> annoying because it usually gets in the way. If I trigger Next it's because I 
> have not yet found what I was looking for, so I *always* click the Continue 
> button in the messagebox.

You're reading a 20 page document, you've already read up to page 10, and then 
you decide to search for "very important thing", why would you want to wrap if 
you've already read the first 10 pages?

Anyhow sure try to get someone from usability, but comparing okular to kate is 
an apples to pineapples comparison imnsho.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/#review102350
---


On Feb. 1, 2017, 11:20 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129893/
> ---
> 
> (Updated Feb. 1, 2017, 11:20 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Show non-intrusive info messages whenever the search start over from the 
> beginning or the bottom of the document, instead of asking the user if s/he 
> wants to continue the search. This is consistent with search in KWrite/Kate 
> and with web browsers.
> 
> 
> Diffs
> -
> 
>   core/document.h 1fd86262 
>   core/document.cpp 41b9ddfe 
>   ui/searchlineedit.cpp baac8be0 
> 
> Diff: https://git.reviewboard.kde.org/r/129893/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>



[okular] [Bug 375964] Okular crashed when I hit Escape

2017-02-03 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=375964

--- Comment #10 from bastien.maub...@gmail.com ---
Yep sorry, since Thunderbird showed me your mail address as sender I 
thought that by hitting reply it would be sent just to you, and I didn't 
check.
Thanks for removing the pdf.

On 03/02/2017 20:46, Oliver Sander wrote:
> https://bugs.kde.org/show_bug.cgi?id=375964
>
> --- Comment #9 from Oliver Sander  ---
> In any case, I got the file, and pressing escape to close an open pop-up
> annotation didn't make my Okular crash.  Neither the one from Debian testing
> nor the self-compiled git master.
>
> I didn't see those warnings about 'linearGradient' either.
>

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 375964] Okular crashed when I hit Escape

2017-02-03 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=375964

--- Comment #9 from Oliver Sander  ---
In any case, I got the file, and pressing escape to close an open pop-up
annotation didn't make my Okular crash.  Neither the one from Debian testing
nor the self-compiled git master.

I didn't see those warnings about 'linearGradient' either.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 375964] Okular crashed when I hit Escape

2017-02-03 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=375964

--- Comment #8 from Oliver Sander  ---
Thanks, I didn't even know you can delete attachments.  Bastien, this is a
public bugtracker.  Anything you post here is visible to everyone.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 375964] Okular crashed when I hit Escape

2017-02-03 Thread Luigi Toscano
https://bugs.kde.org/show_bug.cgi?id=375964

Luigi Toscano  changed:

   What|Removed |Added

 CC||luigi.tosc...@tiscali.it

--- Comment #7 from Luigi Toscano  ---
Please use the email (possibly encrypted), not a public bugtracker for
confidential messages.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 375964] Okular crashed when I hit Escape

2017-02-03 Thread Nicolás Alvarez
https://bugs.kde.org/show_bug.cgi?id=375964

--- Comment #6 from Nicolás Alvarez  ---
The content of attachment 103796 has been deleted for the following reason:

PDF that shouldn't be published

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 375964] Okular crashed when I hit Escape

2017-02-03 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=375964

--- Comment #5 from bastien.maub...@gmail.com ---
Here it is.

Best,
Bastien

On 03/02/2017 20:32, Oliver Sander wrote:
> https://bugs.kde.org/show_bug.cgi?id=375964
>
> --- Comment #4 from Oliver Sander  ---
> I don't even know what LICS is.  But be aware that I am not a skilled okular
> hacker.  Therefore most likely I won't be able to do more than confirm (or 
> not)
> the bug.
>

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 375964] Okular crashed when I hit Escape

2017-02-03 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=375964

--- Comment #4 from Oliver Sander  ---
I don't even know what LICS is.  But be aware that I am not a skilled okular
hacker.  Therefore most likely I won't be able to do more than confirm (or not)
the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 375964] Okular crashed when I hit Escape

2017-02-03 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=375964

--- Comment #3 from bastien.maub...@gmail.com ---
Unfortunately it's a conference paper I'm reviewing, so I think I'm not really
supposed to circulate it... But I see you're in a different field so probably
it's not that bad :-) You don't know people that attend the LICS conference do
you?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 375964] Okular crashed when I hit Escape

2017-02-03 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=375964

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #2 from Oliver Sander  ---
I cannot reproducethis.  Can you post the file?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 375964] Okular crashed when I hit Escape

2017-02-03 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=375964

bastien.maub...@gmail.com changed:

   What|Removed |Added

 CC||bastien.maub...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 375964] Okular crashed when I hit Escape

2017-02-03 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=375964

--- Comment #1 from bastien.maub...@gmail.com ---
Now I know more precisely what causes the crash : every time I close a pop-up
note by hitting escape after I have finished writing it, it crashes. It does
not crash if I close with a click instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 375964] New: Okular crashed when I hit Escape

2017-02-03 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=375964

Bug ID: 375964
   Summary: Okular crashed when I hit Escape
   Product: okular
   Version: unspecified
  Platform: Mint (Ubuntu based)
OS: Linux
Status: UNCONFIRMED
  Keywords: drkonqi
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: bastien.maub...@gmail.com
  Target Milestone: ---

Application: okular (0.24.2)
KDE Platform Version: 4.14.16
Qt Version: 4.8.7
Operating System: Linux 4.4.0-59-generic x86_64
Distribution: Linux Mint 18.1 Serena

-- Information about the crash:
- What I was doing when the application crashed:
I was reading and annotating a pdf. I hit escape (or did I hit the mute key
instead?) and it crashed. It told me Segfault, and the terminal from which I
opened Okular shows me :

bastien@Arya ~/Documents/Boulot/bastien00sophie/Reviews/Confs/LICS/LICS17 $
KCrash: Application 'okular' crashing...
KCrash: Attempting to start /usr/lib/kde4/libexec/drkonqi from kdeinit
KCrash: Connect sock_file=/home/bastien/.kde/socket-Arya/kdeinit4__0
QDBusConnection: session D-Bus connection created before QCoreApplication.
Application may misbehave.
QDBusConnection: session D-Bus connection created before QCoreApplication.
Application may misbehave.
QDBusConnection: session D-Bus connection created before QCoreApplication.
Application may misbehave.
QDBusConnection: session D-Bus connection created before QCoreApplication.
Application may misbehave.
Could not resolve property : linearGradient4538
Could not resolve property : linearGradient4588
Could not resolve property : linearGradient4554
Could not resolve property : linearGradient4572
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566
Could not resolve property : linearGradient4548
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566
Could not resolve property : linearGradient4548
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566
Could not resolve property : linearGradient4548
Could not resolve property : linearGradient4538
Could not resolve property : linearGradient4588
Could not resolve property : linearGradient4554
Could not resolve property : linearGradient4572
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566
Could not resolve property : linearGradient4548
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566
Could not resolve property : linearGradient4548
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566
Could not resolve property : linearGradient4548
Could not resolve property : linearGradient4538
Could not resolve property : linearGradient4588
Could not resolve property : linearGradient4554
Could not resolve property : linearGradient4572
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566
Could not resolve property : linearGradient4548
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566
Could not resolve property : linearGradient4548
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566
Could not resolve property : linearGradient4548
Could not resolve property : linearGradient4538
Could not resolve property : linearGradient4588
Could not resolve property : linearGradient4554
Could not resolve property : linearGradient4572
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566
Could not resolve property : linearGradient4548
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566
Could not resolve property : linearGradient4548
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566
Could not resolve property : linearGradient4548
Could not resolve property : linearGradient4538
Could not resolve property : linearGradient4588
Could not resolve property : linearGradient4554
Could not resolve property : linearGradient4572
Could not resolve property : linearGradient4532
Could not resolve property : linearGradient4582
Could not resolve property : linearGradient4566

[okular] [Bug 375959] New: Save the path for printing a PDF

2017-02-03 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=375959

Bug ID: 375959
   Summary: Save the path for printing a PDF
   Product: okular
   Version: 0.24.0
  Platform: Ubuntu Packages
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: printing
  Assignee: okular-devel@kde.org
  Reporter: phi.repor...@walla.com
  Target Milestone: ---

Often I "print" PDF documents to a local directory, using Okular (it allows to
extract specific pages from a PDF).
Currently, the default directory is always the home ("~") directory.
Please have Okular to save the last directory to which the PDF documents are
"printed", so that I won't need to choose it everytime again & again..

Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 129893: Implement continuous search

2017-02-03 Thread Elvis Angelaccio


> On Feb. 2, 2017, 11:38 p.m., Albert Astals Cid wrote:
> > i'm not sure i agree with this change, but this doesn't seem the proper way 
> > to do it, if we're going to continue searching anyways, don't send a 
> > Okular::Document::EndOfDocumentReached, just continue searching.

Should we ask input from the usability team maybe? I find the messagebox 
annoying because it usually gets in the way. If I trigger Next it's because I 
have not yet found what I was looking for, so I *always* click the Continue 
button in the messagebox.


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/#review102350
---


On Feb. 1, 2017, 11:20 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129893/
> ---
> 
> (Updated Feb. 1, 2017, 11:20 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Show non-intrusive info messages whenever the search start over from the 
> beginning or the bottom of the document, instead of asking the user if s/he 
> wants to continue the search. This is consistent with search in KWrite/Kate 
> and with web browsers.
> 
> 
> Diffs
> -
> 
>   core/document.h 1fd86262 
>   core/document.cpp 41b9ddfe 
>   ui/searchlineedit.cpp baac8be0 
> 
> Diff: https://git.reviewboard.kde.org/r/129893/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>



Re: Review Request 129909: Fix reading comicbooks in zip format

2017-02-03 Thread Eugene Shalygin


> On Лют. 2, 2017, 9:33 після полудня, Albert Astals Cid wrote:
> > It's a bug in KArchive or a bug in Qt.
> > https://mail.kde.org/pipermail/kde-frameworks-devel/2017-February/042506.html

Thanks!


- Eugene


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129909/#review102349
---


On Лют. 1, 2017, 4:44 після полудня, Eugene Shalygin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129909/
> ---
> 
> (Updated Лют. 1, 2017, 4:44 після полудня)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Okular refuses to load .cbr files because a `QIODevice` object returned by 
> `KArchiveFile::createDevice()` reports its size to be 0 and because of that 
> `QImageReader` refuses to read. Proposed solution: if that device's 
> `QIODevice::size()` returns 0, copy its content into a temporary file and 
> load image from the file.
> 
> 
> Diffs
> -
> 
>   generators/comicbook/document.cpp 34c4cb5a 
> 
> Diff: https://git.reviewboard.kde.org/r/129909/diff/
> 
> 
> Testing
> ---
> 
> Well, it loads .cbr files now :)
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>