[okular] [Bug 392991] Does not support duplex printing

[Zakhar]

https://bugs.kde.org/show_bug.cgi?id=392991

--- Comment #1 from Zakhar  ---
same goes for every other kde app that edits text or views documents

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 392916] Crash on okular being open for several days

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=392916

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|FIXED   |WAITINGFORINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 392916] Crash on okular being open for several days

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=392916

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||aa...@kde.org
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #1 from Albert Astals Cid  ---
The backtrace is sadly useless and your verison is old, is there any chance you
can get a newer version?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10797: Add asterisk when an annotation is associated to non-empty popup

[Henrik Fehlauer]

rkflx added a comment.


  In D10797#241905 , @rkflx wrote:
  
  > There is a second way `arc diff` can recognize the revision […] (IIRC – if 
not, `arc which` will tell you the real reason).
  
  
  Hm, I guess that was wishful thinking from my side. Upon `arc diff` Arcanist 
will just add the "Differential Revision" line with the Revision ID obtained 
from Phab to the local commit message.
  
  This means that indeed somehow you must have been removing the commit 
containing that message from the commit range Arcanist looked at.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10797

To: simgunz, #okular, aacid
Cc: rkflx, aacid, ngraham, michaelweghorn

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

[Ahmad Osama]

ahmadosama added a comment.


  As far as I know rotating m_page->m_rects should rotate annotations on the 
page, the annotations seem to work well when rotating them.
  
  When rotating the highlights I tried to replace:
  (*hlIt)->transform( RotationJob::rotationMatrix( oldRotation, m_rotation ) );
  with
  (*hlIt)->transform( matrix );
  
  but highlights were rotated correctly only from the original orientation.
  
  I am thinking of creating another function to get the rotation matrix for the 
highlights, or modify the Okular::buildRotationMatrix
  as follows Okular::buildRotationMatrix(Rotation oldRotation = Rotation0, 
Rotation newRotation)
  
  I am still going through the code to find a better way to solve this bug.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11901

To: ahmadosama, #okular
Cc: aacid, ngraham, #okular, michaelweghorn

D12098: Resize content area to correct dimensions after zooming to Auto Fit

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: Okular, aacid.
Restricted Application added a project: Okular.
chinmoyr requested review of this revision.

REVISION SUMMARY
  After going from high zoom to "Auto Fit" a resize event is generated and the 
resize event handler
  tries to refresh the page view. Sometimes this can result in an infinite 
resize loop. Okular
  fixes this by resizing the content area to the new viewport size. As a 
consequence both horizontal
  and vertical scroll range become zero. Now if "Auto Fit" turns out to be "Fit 
Page" then it is fine
  but in case of "Fit Width" or "Fit Height", where one scroll range should be 
non-zero, both scroll
  bar disappear resulting in a view which appears to be frozen. So to fix this 
add scroll range
  to the dimension for which the scroll bar should be visible and then resize. 
Since the scroll range
  remains constant, an infinite resize loop won't occur.
  
  BUG: 341250

TEST PLAN
  Zoom in 400% and then select "Auto Fit".

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12098

AFFECTED FILES
  ui/pageview.cpp

To: chinmoyr, #okular, aacid
Cc: michaelweghorn, ngraham, aacid

D12067: [Okular Part] Add "Print" action

[Albert Astals Cid]

aacid added a comment.


  Doesn't this mean that when you open okular you end up with two print actions?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12067

To: broulik, #okular, aacid
Cc: michaelweghorn, ngraham, aacid

[okular] [Bug 392648] search:options:from current page doesn't work

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=392648

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

[Ahmad Osama]

ahmadosama added a comment.


  I have not tested it, I do not know what on the page should be rotated when 
rotating m_page->m_rects, I still trying to find out.
  What I did is that I replaced:
   (*hlIt)->transform( RotationJob::rotationMatrix( oldRotation, m_rotation ) );
  with:
  (*hlIt)->transform( matrix );
  but the highlights were rotated correctly only from the original position.
  
  But, I think that m_page->m_rects may not be rotated correctly because 
Okular::buildRotationMatrix(Rotation rotation), rotates only based on the new 
rotation and does not consider what the previous rotation was.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11901

To: ahmadosama, #okular
Cc: aacid, ngraham, #okular, michaelweghorn

[okular] [Bug 392648] search:options:from current page doesn't work

[davidblunkett]

https://bugs.kde.org/show_bug.cgi?id=392648

davidblunkett  changed:

   What|Removed |Added

 Resolution|INVALID |---
 Status|RESOLVED|UNCONFIRMED

--- Comment #2 from davidblunkett  ---
It would be  nicer if this did what it actually said and searched from
the current page in front of you!

If you're not going to change this then the option needs re-describing: "start
searching from the current page at the point when you entered the search term"!

As things stand it does not do what it says it is going to do

-- 
You are receiving this mail because:
You are the assignee for the bug.