[okular] [Bug 468152] New: Crash on exit after signing with a smart card

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=468152

Bug ID: 468152
   Summary: Crash on exit after signing with a smart card
Classification: Applications
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: PDF backend
  Assignee: okular-devel@kde.org
  Reporter: aleix...@kde.org
  Target Milestone: ---

Not super sure how it happened but I signed a document successfully and closed
the document+okular. I got such a crash but ignored it because I was closing it
anyway.

Opened another okular to sign a second one and I get the following error: "All
your signing certificates are either not valid yet or are past their validity
date.". And when I close okular I always get the following crash.

Application: Okular (okular), signal: Segmentation fault
Content of s_kcrashErrorMessage: std::unique_ptr = {get() = 0x0}
[KCrash Handler]
#5  0x7f09dd2a2c67 in pthread_mutex_trylock () at /usr/lib/libc.so.6
#6  0x7f09c91f1502 in NativeLockMutex(void*) () at
/usr/lib/libpkcs11-dnie.so
#7  0x7f09c91e75e7 in C_CloseAllSessions () at /usr/lib/libpkcs11-dnie.so
#8  0x7f09a6123b3f in PK11_FreeSlot () at /usr/lib/libnss3.so
#9  0x7f09a6126bfd in SECMOD_DestroyModule () at /usr/lib/libnss3.so
#10 0x7f09a60eb3c6 in  () at /usr/lib/libnss3.so
#11 0x7f09a60ec0e1 in NSS_Shutdown () at /usr/lib/libnss3.so
#12 0x7f09a6583ecd in shutdownNss() () at
/home/apol/devel/frameworks/poppler/poppler/SignatureHandler.cc:212
#13 0x7f09dd254445 in  () at /usr/lib/libc.so.6
#14 0x7f09dd2545b0 in  () at /usr/lib/libc.so.6
#15 0x7f09dd23c797 in  () at /usr/lib/libc.so.6
#16 0x7f09dd23c84a in __libc_start_main () at /usr/lib/libc.so.6
#17 0x563b43a3aca5 in _start ()
[Inferior 1 (process 687672) detached]

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 271815] I want a better icon in the browse mode

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=271815

Aleix Pol  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Aleix Pol  ---
Looks good to me, nowadays.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 437334] Okular crashes in CursorWrapHelper::getScreen() when wrapping cursor on wayland

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=437334

--- Comment #3 from Aleix Pol  ---
Here is some information. https://wayland-book.com/

In general terms, you need to understand that in Wayland you cannot move the
cursor. So in general this part should be just skipped on wayland.

The crash itself happens because it's unable to figure out the geometry of the
current display. This is something that won't just fly here and should be
avoided.

You might want to add a KWindowSystem::isPlatformWayland() that just does the
scrolling without moving the cursor.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 437334] New: Okular crashes when wrapping cursor on wayland

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=437334

Bug ID: 437334
   Summary: Okular crashes when wrapping cursor on wayland
   Product: okular
   Version: unspecified
  Platform: Compiled Sources
OS: Linux
Status: REPORTED
  Keywords: drkonqi
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: aleix...@kde.org
  Target Milestone: ---

Application: okular (21.07.70)
 (Compiled from sources)
Qt Version: 5.15.1
Frameworks Version: 5.83.0
Operating System: Linux 5.12.4-arch1-2 x86_64
Windowing System: Wayland
Drkonqi Version: 5.22.80
Distribution: Arch Linux

-- Information about the crash:
- What I was doing when the application crashed:
Okular crashes as soon as the cursor leaves the window as on Wayland we don't
have a global cursor position.

We won't be able to move the cursor either so the infinite scrolling can happen
but not to visibly move the cursor.

The crash can be reproduced every time.

-- Backtrace:
Application: Okular (okular), signal: Aborted
Content of s_kcrashErrorMessage: [Current thread is 1 (Thread 0x7f783f287100
(LWP 10536))]
[KCrash Handler]
#5  0x7f78428f1d22 in raise () from /usr/lib/libc.so.6
#6  0x7f78428db862 in abort () from /usr/lib/libc.so.6
#7  0x7f7842eb4c51 in qt_message_fatal (message=...,
context=...) at
/home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:1914
#8  QMessageLogger::fatal (this=this@entry=0x7ffc94456cf8,
msg=msg@entry=0x7f78431b2ec8 "ASSERT failure in %s: \"%s\", file %s, line %d")
at /home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:893
#9  0x7f7842eb40a6 in qt_assert_x (where=, what=, file=, line=) at
/home/apol/devel/frameworks/qt5/qtbase/src/corelib/global/qglobal.cpp:3366
#10 0x7f783c1ef3d2 in CursorWrapHelper::getScreen () at
/home/apol/devel/frameworks/okular/part/cursorwraphelper.cpp:101
#11 0x7f783c1eeb74 in CursorWrapHelper::wrapCursor (eventPosition=...,
edges=...) at /home/apol/devel/frameworks/okular/part/cursorwraphelper.cpp:23
#12 0x7f783c258b1b in PageView::mouseMoveEvent (this=0x560fa78e2670,
e=0x7ffc94457840) at /home/apol/devel/frameworks/okular/part/pageview.cpp:2220
#13 0x7f7843ca002e in QWidget::event (this=this@entry=0x560fa78e2670,
event=event@entry=0x7ffc94457840) at
/home/apol/devel/frameworks/qt5/qtbase/src/widgets/kernel/qwidget.cpp:9020
#14 0x7f7843d4846e in QFrame::event (this=0x560fa78e2670, e=0x7ffc94457840)
at /home/apol/devel/frameworks/qt5/qtbase/src/widgets/widgets/qframe.cpp:550
#15 0x7f783c261d9e in PageView::viewportEvent (this=0x560fa78e2670,
e=0x7ffc94457840) at /home/apol/devel/frameworks/okular/part/pageview.cpp:3245
#16 0x7f78430d1b63 in
QCoreApplicationPrivate::sendThroughObjectEventFilters (event=,
receiver=) at
/home/apol/devel/frameworks/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1190
#17 QCoreApplicationPrivate::sendThroughObjectEventFilters
(receiver=receiver@entry=0x560fa78c92e0, event=event@entry=0x7ffc94457840) at
/home/apol/devel/frameworks/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1179
#18 0x7f7843c6016e in QApplicationPrivate::notify_helper
(this=this@entry=0x560fa749f2e0, receiver=receiver@entry=0x560fa78c92e0,
e=e@entry=0x7ffc94457840) at
/home/apol/devel/frameworks/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3626
#19 0x7f7843c6706b in QApplication::notify (this=0x7ffc94457540,
receiver=0x560fa78c92e0, e=0x7ffc94457840) at
/home/apol/devel/frameworks/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3076
#20 0x7f78430d1dfa in QCoreApplication::notifyInternal2
(receiver=0x560fa78c92e0, event=0x7ffc94457840) at
/home/apol/devel/frameworks/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1064
#21 0x7f7843c66096 in QApplicationPrivate::sendMouseEvent
(receiver=receiver@entry=0x560fa78c92e0, event=event@entry=0x7ffc94457840,
alienWidget=0x0, alienWidget@entry=0x560fa75690b0, nativeWidget=0x560fa75690b0,
buttonDown=buttonDown@entry=0x7f78441879f0 ,
lastMouseReceiver=..., spontaneous=true, onlyDispatchEnterLeave=false) at
/home/apol/devel/frameworks/qt5/qtbase/src/widgets/kernel/qapplication.cpp:2614
#22 0x7f7843cb8071 in QWidgetWindow::handleMouseEvent (this=0x560fa7989f10,
event=0x7ffc94457b00) at
/home/apol/devel/frameworks/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp:683
#23 0x7f7843cbb39e in QWidgetWindow::event (this=0x560fa7989f10,
event=0x7ffc94457b00) at
/home/apol/devel/frameworks/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp:300
#24 0x7f7843c6017f in QApplicationPrivate::notify_helper (this=, receiver=0x560fa7989f10, e=0x7ffc94457b00) at
/home/apol/devel/frameworks/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3632
#25 0x7f78430d1dfa in QCoreApplication::notifyInternal2
(receiver=0x560fa7989f10, event=0x7ffc94457b00) at

Re:

[Aleix Pol]

On Sat, Dec 26, 2020 at 11:21 AM Bhumit Attarde
 wrote:
>
> Hey guys,
>
> I'm a second year engineering student interested in GSOC '21.
>
> I've gone through https://community.kde.org/GSoC/2021/Ideas and have zeroed 
> in on an app I like and know a little about (Okular). I plan to get myself 
> familiarized with it more over next few days and then try to get my hands 
> dirty after I'm comfortable.
>
> Do you guys have any suggestions over how I should proceed?

Including Okular as CC.

That said, have you tried contacting the mentor on the idea you're after?

Aleix

[okular] [Bug 421780] Most ways of navigating a document not working (Qt 5.15)

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=421780

Aleix Pol  changed:

   What|Removed |Added

 CC||aleix...@kde.org

--- Comment #1 from Aleix Pol  ---
Just tested as per Albert's request, can't reproduce.

Running all fresh master, Qt from:
commit 5f03b84e6542f00cf9eccd1d8820f423cee5e2b9 (HEAD -> 5.15, origin/5.15)
Author: Heikki Halmet 
Date:   Tue Apr 28 14:53:47 2020 +0300

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Idea: Failing the build unless you explicitely chose which Okular UI you want to build

[Aleix Pol]

Right, then go with your approach. I'd default to the desktop one
which is the one most people are after I guess. It's annoying when
projects don't build by default.

Aleix

On Mon, Jan 27, 2020 at 11:53 PM Albert Astals Cid  wrote:
>
> El dilluns, 27 de gener de 2020, a les 1:10:08 CET, Aleix Pol va escriure:
> > Hi Albert,
> > I'm unsure it's necessary to be this radical. IMHO, it's fine to just
> > not build okularkirigami if the dependencies don't match. And
> > viceversa.
>
> What if dependencies match both? Build both?
>
> That's exactly what I don't want, you end up with two .desktop files that 
> claim to be Okular.
>
> Cheers,
>   Albert
>
> >
> > Aleix
> >
> > On Sat, Jan 25, 2020 at 11:25 PM Albert Astals Cid  wrote:
> > >
> > > Right now we build by default both the Desktop UI and the Mobile UI.
> > >
> > > In my opinion, for the user, that doesn't make sense, you either want one 
> > > installed or the other installed, but not both.
> > >
> > > On the other hand, it makes lots of sense for CI and for developers, 
> > > because you don't want to break the build of one while working on the 
> > > other.
> > >
> > > My suggestion is to fail the build unless you specify which of the UI you 
> > > want.
> > >
> > > So cmake . would fail and tell you something like:
> > >
> > > Please specify -DOKULAR_UI=Desktop|Mobile|Both
> > >
> > > And then users/distros would only build the one they want, and we 
> > > devels/CI can still chose Both.
> > >
> > > What do you think?
> > >
> > > Cheers,
> > >   Albert
> > >
> > >
> >
>
>
>
>

Re: Idea: Failing the build unless you explicitely chose which Okular UI you want to build

[Aleix Pol]

Hi Albert,
I'm unsure it's necessary to be this radical. IMHO, it's fine to just
not build okularkirigami if the dependencies don't match. And
viceversa.

Aleix

On Sat, Jan 25, 2020 at 11:25 PM Albert Astals Cid  wrote:
>
> Right now we build by default both the Desktop UI and the Mobile UI.
>
> In my opinion, for the user, that doesn't make sense, you either want one 
> installed or the other installed, but not both.
>
> On the other hand, it makes lots of sense for CI and for developers, because 
> you don't want to break the build of one while working on the other.
>
> My suggestion is to fail the build unless you specify which of the UI you 
> want.
>
> So cmake . would fail and tell you something like:
>
> Please specify -DOKULAR_UI=Desktop|Mobile|Both
>
> And then users/distros would only build the one they want, and we devels/CI 
> can still chose Both.
>
> What do you think?
>
> Cheers,
>   Albert
>
>

D22903: Improve search field

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R223 Okular

BRANCH
  improve-searchfield

REVISION DETAIL
  https://phabricator.kde.org/D22903

To: jbbgameich, #okular, #plasma:_mobile, ngraham, apol
Cc: ognarb, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D12250: Install okularpart with the rest of kparts

[Aleix Pol Gonzalez]

apol abandoned this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12250

To: apol, #okular, aacid
Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18397: Fix crash on canceling the file open dialog

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18397

To: vkrause, apol
Cc: apol, nicolasfella, okular-devel, tfella, ngraham, darcyshen, aacid

D16544: Properly find the Purpose framework

[Aleix Pol Gonzalez]

apol added a comment.


  \o/

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D16544

To: apol, #okular, aacid
Cc: okular-devel, ngraham, darcyshen, aacid

D17196: Explicitly import Qt 5.7's QtQuick for Connections.enabled

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R223 Okular

BRANCH
  Applications/18.12

REVISION DETAIL
  https://phabricator.kde.org/D17196

To: heikobecker, #okular, apol
Cc: okular-devel, ngraham, darcyshen, aacid

D16544: Properly find the Purpose framework

[Aleix Pol Gonzalez]

apol abandoned this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D16544

To: apol, #okular, aacid
Cc: okular-devel, ngraham, aacid

D16544: Properly find the Purpose framework

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Okular, aacid.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
apol requested review of this revision.

REPOSITORY
  R223 Okular

BRANCH
  findkf5purpose

REVISION DETAIL
  https://phabricator.kde.org/D16544

AFFECTED FILES
  CMakeLists.txt

To: apol, #okular, aacid
Cc: okular-devel, ngraham, aacid

Poppler on Android builds

[Aleix Pol]

 Hey,
I guess you knew there are Okular Android builds:
https://binary-factory.kde.org/view/Android/job/Okular_android/

Build is broken now because the Android NDK doesn't have std::stoi.
https://binary-factory.kde.org/view/Android/job/Okular_android/146/console

I'll change it to build the poppler-0.68.0 tag for now.

Hope that makes sense to you, tell me otherwise.
Aleix

D14102: Add share action to selection context menu

[Aleix Pol Gonzalez]

apol added a comment.


  I'd say it would make sense to just make it possible to drag and drop this to 
the quick share plasmoid. Or just put it on the clipboard and paste it there.

INLINE COMMENTS

> pageview.cpp:60
>  #include 
> +#include 
> +#include 

Purpose is already used in other parts of Okular and it's ifdef'd there.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14102

To: nicolasfella, #okular, aacid, apol
Cc: ngraham, okular-devel, aacid

D12884: Remove the internal file navigation from the global drawer

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:600e72100b13: Remove the internal file navigation from 
the global drawer (authored by apol).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12884?vs=34335=34371

REVISION DETAIL
  https://phabricator.kde.org/D12884

AFFECTED FILES
  mobile/app/app.qrc
  mobile/app/package/contents/ui/Documents.qml
  mobile/app/package/contents/ui/Thumbnails.qml
  mobile/app/package/contents/ui/main.qml
  mobile/components/documentitem.cpp

To: apol, #okular, mart, aacid
Cc: okular-devel, ngraham, aacid

D12884: Remove the internal file navigation from the global drawer

[Aleix Pol Gonzalez]

apol updated this revision to Diff 34335.
apol added a comment.


  Remove hardcoded path

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12884?vs=34297=34335

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12884

AFFECTED FILES
  mobile/app/app.qrc
  mobile/app/package/contents/ui/Documents.qml
  mobile/app/package/contents/ui/Thumbnails.qml
  mobile/app/package/contents/ui/main.qml
  mobile/components/documentitem.cpp

To: apol, #okular, mart, aacid
Cc: okular-devel, ngraham, aacid

D12884: Remove the internal file navigation from the global drawer

[Aleix Pol Gonzalez]

apol marked an inline comment as done.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12884

To: apol, #okular, mart, aacid
Cc: okular-devel, ngraham, aacid

D12884: Remove the internal file navigation from the global drawer

[Aleix Pol Gonzalez]

apol updated this revision to Diff 34297.
apol added a comment.


  Don't add logic in core/ just in case

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12884?vs=34168=34297

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12884

AFFECTED FILES
  mobile/app/app.qrc
  mobile/app/package/contents/ui/Documents.qml
  mobile/app/package/contents/ui/Thumbnails.qml
  mobile/app/package/contents/ui/main.qml
  mobile/components/documentitem.cpp

To: apol, #okular, mart, aacid
Cc: okular-devel, ngraham, aacid

D12884: Remove the internal file navigation from the global drawer

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> aacid wrote in document.cpp:2362
> I don't think it's a good idea changing the behaviour, can't you fix the 
> mobile app to do the right thing?

Sure, I did it because it feels like broken API. It just complains and doesn't 
do anything when you openDocument twice.
Will move into the QtQuick side.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12884

To: apol, #okular, mart, aacid
Cc: okular-devel, ngraham, aacid

D12884: Remove the internal file navigation from the global drawer

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Okular, mart, aacid.
Restricted Application added a project: Okular.
Restricted Application added a subscriber: okular-devel.
apol requested review of this revision.

REVISION SUMMARY
  Instead include an "open" item.

TEST PLAN
  opened a file

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12884

AFFECTED FILES
  core/document.cpp
  mobile/app/app.qrc
  mobile/app/package/contents/ui/Documents.qml
  mobile/app/package/contents/ui/Thumbnails.qml
  mobile/app/package/contents/ui/main.qml

To: apol, #okular, mart, aacid
Cc: okular-devel, ngraham, aacid

D12770: Android: Make it possible to associate with files

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:cf4bb5e3b178: Android: Make it possible to associate with 
files (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D12770?vs=33858=33998#toc

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12770?vs=33858=33998

REVISION DETAIL
  https://phabricator.kde.org/D12770

AFFECTED FILES
  core/document.cpp
  mobile/android/AndroidManifest.xml
  mobile/android/src/OpenFileActivity.java
  mobile/app/main.cpp
  mobile/app/package/contents/ui/Documents.qml
  mobile/app/package/contents/ui/OkularDrawer.qml
  mobile/app/package/contents/ui/main.qml
  mobile/components/DocumentView.qml
  mobile/components/documentitem.cpp
  mobile/components/documentitem.h
  mobile/components/pageitem.cpp
  shell/shell.cpp

To: apol, #okular, aacid, mart
Cc: okular-devel, ngraham, aacid

D12770: Android: Make it possible to associate with files

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Okular, aacid, mart.
Restricted Application added a project: Okular.
apol requested review of this revision.

REVISION SUMMARY
  Put the file into a file descriptor and open this file descriptor.
  Just application/pdf for now.

TEST PLAN
  opened some documents on my phone

REPOSITORY
  R223 Okular

BRANCH
  filesAndroid

REVISION DETAIL
  https://phabricator.kde.org/D12770

AFFECTED FILES
  core/document.cpp
  mobile/android/AndroidManifest.xml
  mobile/android/src/OpenFileActivity.java
  mobile/app/main.cpp
  mobile/app/package/contents/ui/Documents.qml
  mobile/app/package/contents/ui/OkularDrawer.qml
  mobile/app/package/contents/ui/main.qml
  mobile/components/DocumentView.qml
  mobile/components/documentitem.cpp
  mobile/components/documentitem.h
  mobile/components/pageitem.cpp
  shell/shell.cpp

To: apol, #okular, aacid, mart
Cc: ngraham, aacid

D12672: Use a target in FindDiscount (modern cmake) rather than variables

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  It's actually fixing the build when discount is in its own prefix.
  
  Also I agree that it's better using targets.

REPOSITORY
  R223 Okular

BRANCH
  Applications/18.04

REVISION DETAIL
  https://phabricator.kde.org/D12672

To: svuorela, kde-buildsystem, apol
Cc: apol, aacid, #okular, ngraham

D12352: Make it possible to disable the build of okularkirigami

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:1fb77446a737: Make it possible to disable the build of 
okularkirigami (authored by apol).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12352?vs=32616=32842

REVISION DETAIL
  https://phabricator.kde.org/D12352

AFFECTED FILES
  CMakeLists.txt
  mobile/app/package/contents/ui/Documents.qml

To: apol, #okular, mart, aacid, lbeltrame
Cc: ngraham, aacid

[okular] [Bug 393119] No way to disable okularkirigami building

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=393119

Aleix Pol <aleix...@kde.org> changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/oku
   ||lar/1fb77446a7378368de5288c
   ||a9f57627ae2946d84
 Resolution|--- |FIXED

--- Comment #2 from Aleix Pol <aleix...@kde.org> ---
Git commit 1fb77446a7378368de5288ca9f57627ae2946d84 by Aleix Pol.
Committed on 22/04/2018 at 20:23.
Pushed by apol into branch 'master'.

Make it possible to disable the build of okularkirigami

Summary:
Some distros seem to have the option.

Test Plan: Still builds, can disable build

Reviewers: #okular, mart, aacid, lbeltrame

Tags: #okular

Differential Revision: https://phabricator.kde.org/D12352

M  +4-1CMakeLists.txt
M  +28   -7mobile/app/package/contents/ui/Documents.qml

https://commits.kde.org/okular/1fb77446a7378368de5288ca9f57627ae2946d84

-- 
You are receiving this mail because:
You are the assignee for the bug.

D12352: Make it possible to disable the build of okularkirigami

[Aleix Pol Gonzalez]

apol updated this revision to Diff 32616.
apol added a comment.


  Improve description

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12352?vs=32569=32616

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12352

AFFECTED FILES
  CMakeLists.txt
  mobile/app/package/contents/ui/Documents.qml

To: apol, #okular, mart, aacid, lbeltrame
Cc: ngraham, aacid

D12352: Make it possible to disable the build of okularkirigami

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Okular, mart, aacid, lbeltrame.
Restricted Application added a project: Okular.
apol requested review of this revision.

REVISION SUMMARY
  Some distros seem to have the option.
  
  BUG: 393119

TEST PLAN
  Still builds, can disable build

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12352

AFFECTED FILES
  CMakeLists.txt

To: apol, #okular, mart, aacid, lbeltrame
Cc: ngraham, aacid

[okular] [Bug 393119] No way to disable okularkirigami building

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=393119

Aleix Pol <aleix...@kde.org> changed:

   What|Removed |Added

 CC||aleix...@kde.org

--- Comment #1 from Aleix Pol <aleix...@kde.org> ---
https://phabricator.kde.org/D12352

-- 
You are receiving this mail because:
You are the assignee for the bug.

D12299: Android: include metadata for okular kirigami

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:77049d3b80c2: Android: include metadata for okular 
kirigami (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D12299?vs=32434=32523#toc

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12299?vs=32434=32523

REVISION DETAIL
  https://phabricator.kde.org/D12299

AFFECTED FILES
  CMakeLists.txt
  mobile/android/AndroidManifest.xml
  mobile/android/res/drawable/icon.png
  mobile/android/res/values/libs.xml
  mobile/android/res/values/strings.xml
  mobile/app/CMakeLists.txt
  mobile/app/main.cpp
  mobile/app/org.kde.okular.kirigami.appdata.xml

To: apol, #okular, mart, aacid
Cc: michaelweghorn, ngraham, aacid

D12299: Android: include metadata for okular kirigami

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Okular, mart, aacid.
Restricted Application added a project: Okular.
apol requested review of this revision.

REVISION SUMMARY
  Include an AndroidManifest.xml file so when it's installed it has a
  proper icon and name.
  Include appdata information so it can be listed

REPOSITORY
  R223 Okular

BRANCH
  okularkirigamiandroid

REVISION DETAIL
  https://phabricator.kde.org/D12299

AFFECTED FILES
  CMakeLists.txt
  mobile/android/AndroidManifest.xml
  mobile/android/res/drawable/icon.png
  mobile/android/res/values/libs.xml
  mobile/android/res/values/strings.xml
  mobile/app/CMakeLists.txt
  mobile/app/main.cpp
  mobile/app/org.kde.okular.kirigami.appdata.xml

To: apol, #okular, mart, aacid
Cc: michaelweghorn, ngraham, aacid

D12250: Install okularpart with the rest of kparts

[Aleix Pol Gonzalez]

apol updated this revision to Diff 32353.
apol added a comment.


  The shell needs to know where the plugin is

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12250?vs=32348=32353

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12250

AFFECTED FILES
  CMakeLists.txt
  generators/chm/okularChm.desktop
  generators/comicbook/okularComicbook.desktop
  generators/djvu/okularDjvu.desktop
  generators/dvi/okularDvi.desktop
  generators/epub/okularEPub.desktop
  generators/fax/okularFax.desktop
  generators/fictionbook/okularFb.desktop
  generators/kimgio/okularKimgio.desktop
  generators/markdown/okularMd.desktop
  generators/mobipocket/okularMobi.desktop
  generators/ooo/okularOoo.desktop
  generators/plucker/okularPlucker.desktop
  generators/poppler/okularPoppler.desktop
  generators/spectre/okularGhostview.desktop
  generators/tiff/okularTiff.desktop
  generators/txt/okularTxt.desktop
  generators/xps/okularXps.desktop
  okular_part.desktop
  shell/shell.cpp

To: apol, #okular, aacid
Cc: michaelweghorn, ngraham, aacid

D12250: Install okularpart with the rest of kparts

[Aleix Pol Gonzalez]

apol updated this revision to Diff 32348.
apol added a comment.


  And another

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12250?vs=32347=32348

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12250

AFFECTED FILES
  CMakeLists.txt
  generators/chm/okularChm.desktop
  generators/comicbook/okularComicbook.desktop
  generators/djvu/okularDjvu.desktop
  generators/dvi/okularDvi.desktop
  generators/epub/okularEPub.desktop
  generators/fax/okularFax.desktop
  generators/fictionbook/okularFb.desktop
  generators/kimgio/okularKimgio.desktop
  generators/markdown/okularMd.desktop
  generators/mobipocket/okularMobi.desktop
  generators/ooo/okularOoo.desktop
  generators/plucker/okularPlucker.desktop
  generators/poppler/okularPoppler.desktop
  generators/spectre/okularGhostview.desktop
  generators/tiff/okularTiff.desktop
  generators/txt/okularTxt.desktop
  generators/xps/okularXps.desktop
  okular_part.desktop

To: apol, #okular, aacid
Cc: michaelweghorn, ngraham, aacid

D12250: Install okularpart with the rest of kparts

[Aleix Pol Gonzalez]

apol updated this revision to Diff 32347.
apol added a comment.


  There's more desktop files pointing to okularpart

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12250?vs=32319=32347

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12250

AFFECTED FILES
  CMakeLists.txt
  generators/comicbook/okularComicbook.desktop
  generators/djvu/okularDjvu.desktop
  generators/dvi/okularDvi.desktop
  generators/epub/okularEPub.desktop
  generators/fax/okularFax.desktop
  generators/fictionbook/okularFb.desktop
  generators/kimgio/okularKimgio.desktop
  generators/markdown/okularMd.desktop
  generators/mobipocket/okularMobi.desktop
  generators/ooo/okularOoo.desktop
  generators/plucker/okularPlucker.desktop
  generators/poppler/okularPoppler.desktop
  generators/spectre/okularGhostview.desktop
  generators/tiff/okularTiff.desktop
  generators/txt/okularTxt.desktop
  generators/xps/okularXps.desktop
  okular_part.desktop

To: apol, #okular, aacid
Cc: michaelweghorn, ngraham, aacid

D12250: Install okularpart with the rest of kparts

[Aleix Pol Gonzalez]

apol updated this revision to Diff 32319.
apol added a comment.


  Unsure why it worked for me, point to the library like katepart does

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12250?vs=32300=32319

BRANCH
  installprefix

REVISION DETAIL
  https://phabricator.kde.org/D12250

AFFECTED FILES
  CMakeLists.txt
  okular_part.desktop

To: apol, #okular, aacid
Cc: michaelweghorn, ngraham, aacid

D12177: Make some frameworks optional so okular can be built on Android

[Aleix Pol Gonzalez]

apol updated this revision to Diff 32318.
apol added a comment.


  Oops

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12177?vs=32317=32318

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12177

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  core/generator.cpp
  core/scripter.cpp
  generators/ooo/CMakeLists.txt
  generators/ooo/generator_ooo.cpp
  part.cpp

To: apol, #okular, aacid
Cc: aacid, michaelweghorn, ngraham

D12177: Make some frameworks optional so okular can be built on Android

[Aleix Pol Gonzalez]

apol updated this revision to Diff 32317.
apol added a comment.


  Unsure why it works on my system, adopt the same way to point to the path 
katepart uses

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12177?vs=32303=32317

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12177

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  core/generator.cpp
  core/scripter.cpp
  generators/ooo/CMakeLists.txt
  generators/ooo/generator_ooo.cpp
  okular_part.desktop
  part.cpp

To: apol, #okular, aacid
Cc: aacid, michaelweghorn, ngraham

D12177: Make some frameworks optional so okular can be built on Android

[Aleix Pol Gonzalez]

apol updated this revision to Diff 32303.
apol added a comment.


  Shouldn't comment the include...

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12177?vs=32302=32303

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12177

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  core/generator.cpp
  core/scripter.cpp
  generators/ooo/CMakeLists.txt
  generators/ooo/generator_ooo.cpp
  part.cpp

To: apol, #okular, aacid
Cc: aacid, michaelweghorn, ngraham

D12177: Make some frameworks optional so okular can be built on Android

[Aleix Pol Gonzalez]

apol updated this revision to Diff 32302.
apol added a comment.


  Typo

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12177?vs=32296=32302

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12177

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  core/generator.cpp
  core/scripter.cpp
  generators/ooo/CMakeLists.txt
  generators/ooo/generator_ooo.cpp
  part.cpp

To: apol, #okular, aacid
Cc: aacid, michaelweghorn, ngraham

D12250: Install okularpart with the rest of kparts

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Okular, aacid.
Restricted Application added a project: Okular.
apol requested review of this revision.

REVISION SUMMARY
  We have a directory with all kparts, okular should integrate there

TEST PLAN
  Uninstalled, installed with the patch applied, okular still works

REPOSITORY
  R223 Okular

BRANCH
  installprefix

REVISION DETAIL
  https://phabricator.kde.org/D12250

AFFECTED FILES
  CMakeLists.txt

To: apol, #okular, aacid
Cc: michaelweghorn, ngraham, aacid

D12177: Make some frameworks optional so okular can be built on Android

[Aleix Pol Gonzalez]

apol updated this revision to Diff 32296.
apol added a comment.


  Address Albert's concern

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12177?vs=32072=32296

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12177

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  core/generator.cpp
  core/scripter.cpp
  generators/ooo/CMakeLists.txt
  generators/ooo/generator_ooo.cpp
  part.cpp

To: apol, #okular, aacid
Cc: aacid, michaelweghorn, ngraham

D12177: Make some frameworks optional so okular can be built on Android

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Okular.
Restricted Application added a project: Okular.
apol requested review of this revision.

REVISION SUMMARY
  Disables KWallet integration if there's no KWallet, KJS if there's no
  KJS and KDocTools.
  Here's a list of frameworks that don't work on Android:
  
https://cgit.kde.org/sysadmin/ci-tooling.git/tree/local-metadata/project-ignore-rules.yaml

TEST PLAN
  Still works locally, ran Okular and Okular Mobile on Android.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12177

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  core/generator.cpp
  core/scripter.cpp
  generators/ooo/CMakeLists.txt
  generators/ooo/generator_ooo.cpp
  part.cpp

To: apol, #okular
Cc: michaelweghorn, ngraham, aacid

D12176: Turn okularkirigami into an executable

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:5f8f84d53cf8: Turn okularkirigami into an executable 
(authored by apol).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12176?vs=32070=32071

REVISION DETAIL
  https://phabricator.kde.org/D12176

AFFECTED FILES
  mobile/app/CMakeLists.txt
  mobile/app/app.qrc
  mobile/app/main.cpp
  mobile/app/package/metadata.desktop

To: apol, #kirigami, #okular, mart
Cc: plasma-devel, michaelweghorn, ngraham, apol, aacid, davidedmundson, mart, 
hein

D10007: Fix Build with Purpose

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  Shouldn't be needed anymore.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10007

To: tcanabrava, #okular, apol
Cc: michaelweghorn, aacid, ltoscano, #okular, ngraham

D10022: Fix annoying warning

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: aacid.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.
apol requested review of this revision.

REVISION SUMMARY
  Warning for every plugin was:
  The file includes the moc file "generator_tiff.moc", but does not contain a 
Q_OBJECT, Q_GADGET, Q_NAMESPACE, K_PLUGIN_FACTORY_WITH_JSON, K_PLUGIN_FACTORY, 
K_PLUGIN_FACTORY_WITH_JSON or K_PLUGIN_FACTORY macro.

TEST PLAN
  Built

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10022

AFFECTED FILES
  CMakeLists.txt

To: apol, aacid
Cc: #okular, michaelweghorn, ngraham, aacid

D10007: Fix Build with Purpose

[Aleix Pol Gonzalez]

apol added a comment.


  I changed it so KDEExperimental still works with newer Purpose. I'd say let's 
keep the old one and when it's released again, then just change to just 
KF5::Purpose.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10007

To: tcanabrava, #okular, apol
Cc: michaelweghorn, aacid, ltoscano, #okular, gassaf, ngraham

[okular] [Bug 389224] Build failure with latest purpose changes

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=389224

Aleix Pol <aleix...@kde.org> changed:

   What|Removed |Added

 CC||aleix...@kde.org
 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Aleix Pol <aleix...@kde.org> ---
Fixed with this commit
https://commits.kde.org/purpose/20a304236100b29014403a894cbda2d93ab28e41

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 373855] Forward search/named_destination feature not working anymore

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=373855

Aleix Pol <aleix...@kde.org> changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
 CC||aleix...@kde.org

--- Comment #5 from Aleix Pol <aleix...@kde.org> ---
I looked through the issue, the problem is that there's a safe-guard so that
files containing a # in the name won't be misinterpreted.

Example. Something like:
"okular /.../my#document.pdf"
Shouldn't be opening the document "my" with a tag "document.pdf".

I don't know who or why it was done.

Now you are passing a tag with a dot in it, so the code thinks you're passing a
document named: "mypdf.pdf#page.3" with "3" as an extension.

Now if you ask me, the weird thing is that we're taking into account the
possibility of a file with a # in its filename, but then I barely have
experience in the area.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 374358] Okular Flatpak fails to launch on Fedora 25: libpcreposix.so.0 not found

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=374358

Aleix Pol <aleix...@kde.org> changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |UPSTREAM

--- Comment #4 from Aleix Pol <aleix...@kde.org> ---
Was fixed upstream:
https://github.com/flatpak/flatpak/issues/476

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 374358] Okular Flatpak fails to launch on Fedora 25: libpcreposix.so.0 not found

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=374358

--- Comment #3 from Aleix Pol <aleix...@kde.org> ---
Dependency coming from KJS.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 374358] Okular Flatpak fails to launch on Fedora 25: libpcreposix.so.0 not found

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=374358

--- Comment #2 from Aleix Pol <aleix...@kde.org> ---
I've investigated a bit, this library seems to be part of the sdk exclusively,
need to investigate how it happens and how to fix it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 374358] Okular Flatpak fails to launch on Fedora 25: libpcreposix.so.0 not found

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=374358

--- Comment #1 from Aleix Pol <aleix...@kde.org> ---
Note that Flatpak doesn't run the packages on your file system, you need to
check on the contained environment.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 374358] Okular Flatpak fails to launch on Fedora 25: libpcreposix.so.0 not found

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=374358

Aleix Pol <aleix...@kde.org> changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
 CC||aleix...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 129347: add metadata for kimgio, mobipocket, ooo, plucker, poppler, spectre, txt, xps

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129347/#review100739
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Nov. 6, 2016, 4:53 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129347/
> ---
> 
> (Updated Nov. 6, 2016, 4:53 p.m.)
> 
> 
> Review request for Okular and Matthias Klumpp.
> 
> 
> Bugs: 363842
> http://bugs.kde.org/show_bug.cgi?id=363842
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   generators/kimgio/CMakeLists.txt 9ac7aeb 
>   generators/kimgio/org.kde.okular-kimgio.metainfo.xml PRE-CREATION 
>   generators/mobipocket/CMakeLists.txt 059dd35 
>   generators/mobipocket/org.kde.okular-mobipocket.metainfo.xml PRE-CREATION 
>   generators/ooo/CMakeLists.txt 86726d1 
>   generators/ooo/org.kde.okular-ooo.metainfo.xml PRE-CREATION 
>   generators/plucker/CMakeLists.txt 708f0af 
>   generators/plucker/org.kde.okular-plucker.metainfo.xml PRE-CREATION 
>   generators/poppler/CMakeLists.txt b31c36b 
>   generators/poppler/org.kde.okular-poppler.metainfo.xml PRE-CREATION 
>   generators/spectre/CMakeLists.txt 47fc00f 
>   generators/spectre/org.kde.okular-spectre.metainfo.xml PRE-CREATION 
>   generators/tiff/CMakeLists.txt 31349ec 
>   generators/tiff/org.kde.okular-tiff.metainfo.xml PRE-CREATION 
>   generators/txt/CMakeLists.txt 202a3f9 
>   generators/txt/org.kde.okular-txt.metainfo.xml PRE-CREATION 
>   generators/xps/CMakeLists.txt 32e24d0 
>   generators/xps/org.kde.okular-xps.metainfo.xml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129347/diff/
> 
> 
> Testing
> ---
> 
> verified with appstreamcli validate
> builds + installs
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

[okular] [Bug 371828] New: Wrong aspect ratio when rendering tiff file

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=371828

Bug ID: 371828
   Summary: Wrong aspect ratio when rendering tiff file
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: TIFF backend
  Assignee: okular-devel@kde.org
  Reporter: aleix...@kde.org
  Target Milestone: ---

http://www.nightprogrammer.org/wp-uploads/2013/02/multipage_tif_example.tif

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 362856] [Frameworks] Wrong render resolution, possibly caused by Plasma 5 "Scale Display"

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=362856

Aleix Pol <aleix...@kde.org> changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||aleix...@kde.org
 Status|UNCONFIRMED |CONFIRMED

--- Comment #15 from Aleix Pol <aleix...@kde.org> ---
I can reproduce, launching with `QT_SCALE_FACTOR=2 okular` on a regular screen
reproduces.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: [Okular-devel] Taking a break and an Okular sprint in October

[Aleix Pol]

On Mon, Jul 25, 2016 at 12:40 AM, Albert Astals Cid  wrote:
> Hi guys, I have come to the obvious realization, at the moment I do not have
> enough stamina to review and take care of what needs to be done for Okular, i
> have 162 unread emails in the Okular mail folder, an order of magnitude more
> than the rest of my other folders combined.
>
> So I've decided to take a break, I've been the stalling factor for some
> reviews and that is bad. Okular currently has 31 open review requests in
> reviewboard, not all of them are waiting for me, but some are, sorry for that.
>
> Then there's the dont-use-docdata-for-annots-and-forms branch that Fabio
> [almost] finished years ago. This branch is *very* important since it fixes
> the long standing issue with annotations and form content being silently saved
> but only locally and not on the .pdf file itself. Someone with energy needs to
> go over it and see if it's good enough to be merged, my hunch is that it is.
>
> Two more branches that need attention are gsoc2015_linearization and
> gsoc2015_tag_feature, they looked good enough last year when i did the review
> for GSoC but never had time to properly merge them, i do think they needed
> some poppler patches too, i can help merging them if someone reviews the
> features and they work fine https://github.com/sahebpreet/poppler The notes i
> have are at http://paste.ubuntu.com/20799691/
>
> And then there's the obvious elephant in the room, I don't feel confident on
> merging the frameworks branch into master because I do not see myself having
> the stamina to make sure everything works well enough, but it seems there's
> people around that do, again I don't want to be the stopping factor,
>
> So I will be taking a step sideways and hope for someone to step up with all
> the important work that needs doing.
>
> Obviously I won't be going anywhere, but as I said I don't have much energy
> currently, so things on my side will be slow.
>
> To help with this (and see if I can regain some of my motivation) I'd like to
> have an Okular sprint here in Barcelona, tentative dates 8 to 12 of October,
> would anyone be able to attend?
>
> Cheers,
>   Albert

Hi Albert,
It's unfortunate to read, I'll be happy to join the sprint.

Aleix
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

[Aleix Pol Gonzalez]

> On July 14, 2016, 12:04 a.m., Aleix Pol Gonzalez wrote:
> > shell/shell.cpp, line 441
> > <https://git.reviewboard.kde.org/r/128435/diff/1/?file=471627#file471627line441>
> >
> > I think it would make sense to move that logic upstream.
> > 
> > It's not something specific about okular.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> move which logic to which upstream? QFileDialog?
> 
> Aleix Pol Gonzalez wrote:
> Whichever QPT that is underwhelming you and pushed you to make this RR. 
> Or QFileDialog, if it's general.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> Ah, it is the default implementation in QFileDialog itself.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> FWIW, I have a couple of implementations of it for upstream, but I don't 
> it makes a lot of sense as it changes behaviour a lot.
> 
> http://ix.io/15nr is the least invasive imho.

I don't see the review in Qt's gerrit. Do you have it at hand?


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128435/#review97361
---


On July 17, 2016, 8:09 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128435/
> -------
> 
> (Updated July 17, 2016, 8:09 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Aleix Pol Gonzalez.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Without the Plasma QPA now the file open dialog just lets you select a single 
> random filetype to view at the time. This tries to improve that, but I'm not 
> sure if that's something you/we want?
> 
> 
> Diffs
> -
> 
>   shell/shell.cpp bca7206 
> 
> Diff: https://git.reviewboard.kde.org/r/128435/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

[Aleix Pol Gonzalez]

> On July 14, 2016, 12:04 a.m., Aleix Pol Gonzalez wrote:
> > shell/shell.cpp, line 441
> > <https://git.reviewboard.kde.org/r/128435/diff/1/?file=471627#file471627line441>
> >
> > I think it would make sense to move that logic upstream.
> > 
> > It's not something specific about okular.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> move which logic to which upstream? QFileDialog?

Whichever QPT that is underwhelming you and pushed you to make this RR. Or 
QFileDialog, if it's general.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128435/#review97361
---


On July 13, 2016, 11:57 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128435/
> ---
> 
> (Updated July 13, 2016, 11:57 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Aleix Pol Gonzalez.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Without the Plasma QPA now the file open dialog just lets you select a single 
> random filetype to view at the time. This tries to improve that, but I'm not 
> sure if that's something you/we want?
> 
> 
> Diffs
> -
> 
>   shell/shell.cpp bca7206 
> 
> Diff: https://git.reviewboard.kde.org/r/128435/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128435/#review97361
---



It looks like a workaround to me. But workarounds are often required.


shell/shell.cpp (line 435)
<https://git.reviewboard.kde.org/r/128435/#comment65723>

Why? Shouldn't this depend on the standard in the platform? Why would we 
need to hide this?



shell/shell.cpp (line 440)
<https://git.reviewboard.kde.org/r/128435/#comment65724>

Use foreach or qAsConst.



shell/shell.cpp (line 441)
<https://git.reviewboard.kde.org/r/128435/#comment65725>

I think it would make sense to move that logic upstream.

It's not something specific about okular.


- Aleix Pol Gonzalez


On July 13, 2016, 11:57 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128435/
> ---
> 
> (Updated July 13, 2016, 11:57 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Aleix Pol Gonzalez.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Without the Plasma QPA now the file open dialog just lets you select a single 
> random filetype to view at the time. This tries to improve that, but I'm not 
> sure if that's something you/we want?
> 
> 
> Diffs
> -
> 
>   shell/shell.cpp bca7206 
> 
> Diff: https://git.reviewboard.kde.org/r/128435/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 363842] [frameworks] Okular appstream data doesn't provide all supported mimetypes

[Aleix Pol via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363842

--- Comment #6 from Aleix Pol <aleix...@kde.org> ---
They certainly claim they adhere to readmes and such. I guess splitting can
make sense in the cases where it adds dependencies. If you want to maintain
such freedom, then we can just add an appstream file for every plugin. Which is
what evince does, if I recall correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 363842] [frameworks] Okular appstream data doesn't provide all supported mimetypes

[Aleix Pol via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363842

Aleix Pol <aleix...@kde.org> changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |UNCONFIRMED

--- Comment #4 from Aleix Pol <aleix...@kde.org> ---
Nono, appstream can have addons. I guess we need to decide if we want to
advertise the plugins in general or have an appdata file for each plugin.

It also depends on whether we're going to allow packagers to split the package.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 363842] Okular appstream data doesn't provide all supported mimetypes

[Aleix Pol via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363842

Aleix Pol <aleix...@kde.org> changed:

   What|Removed |Added

Summary|Appstream doesn't provide   |Okular appstream data
   |all supported mimetypes |doesn't provide all
   ||supported mimetypes

--- Comment #1 from Aleix Pol <aleix...@kde.org> ---
Only  application/vnd.kde.okular-archive is offered, important others are
missing, such as application/pdf.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 363842] New: Appstream doesn't provide all supported mimetypes

[Aleix Pol via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363842

Bug ID: 363842
   Summary: Appstream doesn't provide all supported mimetypes
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: aleix...@kde.org

$ appstreamcli get okular.desktop --details
Identifier: okular.desktop [desktop]
Name: Okular
Summary: Universal document viewer
Package: kdegraphics-okular
Icon: kdegraphics-okular_okular.png
Description: Document Viewer
Sample Screenshot URL:
http://screenshots.debian.net/screenshot/kdegraphics-okular
Categories: Graphics, Office, Viewer, 
Provided Items: ↓
 Mimetypes: application/vnd.kde.okular-archive

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127021/
---

(Updated May 31, 2016, 12:13 a.m.)


Status
--

This change has been marked as submitted.


Review request for Okular.


Changes
---

Submitted with commit 32b62e919a6493cca9d5d2b272872b53f9b5e41d by Aleix Pol to 
branch frameworks.


Repository: okular


Description
---

Drops KDELibs4Support usage, mostly it wasn't actually used, except for that 
KFileDialog usage that I ported.


Diffs
-

  shell/shell.cpp c97054a 

Diff: https://git.reviewboard.kde.org/r/127021/diff/


Testing
---

Opening dialog seems to work fine, tests still pass except for parttest, but 
I'm unsure it's related: https://paste.kde.org/p37pdubgf


Thanks,

Aleix Pol Gonzalez

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127328: Fix build on Windows (MinGW)

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127328/#review93503
---




CMakeLists.txt (line 305)
<https://git.reviewboard.kde.org/r/127328/#comment63752>

Make it `add_library(okularpart MODULE ${okularpart_SRCS})` and you won't 
need to drop the prefix.



interfaces/viewerinterface.h (line 14)
<https://git.reviewboard.kde.org/r/127328/#comment63751>

Should use generate_export_header() and generate the export macros at 
configure time.


- Aleix Pol Gonzalez


On March 14, 2016, 1:17 a.m., Thomas Friedrichsmeier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127328/
> ---
> 
> (Updated March 14, 2016, 1:17 a.m.)
> 
> 
> Review request for Okular, Aleix Pol Gonzalez, Alex Richardson, and Gleb 
> Popov.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Three parts to this patch:
> 1) The plaform #ifdef in interfaces/viewerinterface.h is platform, not 
> compiler-specific.
> 2) When compiling okularplugin, the existing definition of okularpart_EXPORTS 
> on the generated settings.cpp does not work with MinGW, for reasons that I do 
> not understand. Setting the definition on the whole target, instead, works.
> 3) The okularpart lib will automatically be named libokularpart, and 
> subsequently not be found when trying to load it via KPluginLoader. Tell 
> cmake to drop the "lib"-prefix.
> 
> See also:
> - Discussion on list 
> https://mail.kde.org/pipermail/okular-devel/2016-March/022480.html
> - A previous review request addressed issue 2 for MSVC 
> https://git.reviewboard.kde.org/r/125742/
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e17bc25 
>   interfaces/viewerinterface.h e9e76a2 
>   mobile/components/CMakeLists.txt e09326a 
> 
> Diff: https://git.reviewboard.kde.org/r/127328/diff/
> 
> 
> Testing
> ---
> 
> Builds on Windows with MinGW. Starts, and loads okularpart, successfully.
> 
> 
> Thanks,
> 
> Thomas Friedrichsmeier
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359223] [framework] okular cannot open files with spaces in path or name (both from terminal and from dolphin)

[Aleix Pol via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359223

Aleix Pol <aleix...@kde.org> changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359223] [framework] okular cannot open files with spaces in path or name (both from terminal and from dolphin)

[Aleix Pol via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359223

Aleix Pol <aleix...@kde.org> changed:

   What|Removed |Added

 CC||aleix...@kde.org

--- Comment #7 from Aleix Pol <aleix...@kde.org> ---
Should be fixed as of:
http://commits.kde.org/okular/154c98fdaab2e593091fe644cfaeed96dd9fefaf

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127042: Fix QUrl string encoding

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127042/
---

(Updated Feb. 26, 2016, 4:11 p.m.)


Status
--

This change has been marked as submitted.


Review request for Okular and Alex Richardson.


Changes
---

Submitted with commit 154c98fdaab2e593091fe644cfaeed96dd9fefaf by Aleix Pol to 
branch frameworks.


Repository: okular


Description
---

This Url is converted in to a string to be parsed back using `QUrl( urlString, 
QUrl::StrictMode )`.
By default, it uses `PrettyDecoded`, which makes `QUrl::StrictMode` choke.

An alternative patch would be to overload openDocument to also take QUrl and 
skip the back-and-forth conversion.


Diffs
-

  shell/okular_main.cpp 9bdc1fe 
  shell/shell.h c7c155b 
  shell/shell.cpp c97054a 

Diff: https://git.reviewboard.kde.org/r/127042/diff/


Testing
---

Now I can open files with a space in it.


Thanks,

Aleix Pol Gonzalez

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127042: Fix QUrl string encoding

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127042/
---

(Updated Feb. 24, 2016, 6:21 p.m.)


Review request for Okular and Alex Richardson.


Changes
---

* Drops the strict parsing.
* Overloads openDocument so we don't need to go QUrl -> QString -> QUrl.


Repository: okular


Description
---

This Url is converted in to a string to be parsed back using `QUrl( urlString, 
QUrl::StrictMode )`.
By default, it uses `PrettyDecoded`, which makes `QUrl::StrictMode` choke.

An alternative patch would be to overload openDocument to also take QUrl and 
skip the back-and-forth conversion.


Diffs (updated)
-

  shell/okular_main.cpp 9bdc1fe 
  shell/shell.h c7c155b 
  shell/shell.cpp c97054a 

Diff: https://git.reviewboard.kde.org/r/127042/diff/


Testing
---

Now I can open files with a space in it.


Thanks,

Aleix Pol Gonzalez

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

[Aleix Pol Gonzalez]

> On Feb. 10, 2016, 12:23 a.m., Albert Astals Cid wrote:
> > The new dialog "file type" looks fugly and tehre's no "all file types" 
> > anymore.
> 
> Aleix Pol Gonzalez wrote:
> https://git.reviewboard.kde.org/r/127024/
> 
> :)
> 
> Albert Astals Cid wrote:
> that won't fix http://i.imgur.com/AwIzhqr.png right? That's the Qt dialog 
> i guess? Is it really supposed to be that ugly?
> 
> Aleix Pol Gonzalez wrote:
> You don't have it set up properly, you should be getting the normal 
> KFileWidget-based dialog.
> 
> Albert Astals Cid wrote:
> I know i don't have it setup to give me the "Plasma experience", it's 
> giving me the "Okular experience outside plasma", and it is a serious 
> regression to what we have by using KFileDialog, don't you think?
> 
> Aleix Pol Gonzalez wrote:
> As I see it, there's no non-_Plasma Experience_. In Gnome, it should use 
> the GTK thingie, in Plasma it should use the Plasma dialog, and on Windows or 
> Android, whatever they use there: so it's not a regression but a feature.
> 
> Albert Astals Cid wrote:
>     There's more things in Linux land than Plasma and Gnome, i'm worried 
> about such an ugly dialog for those people.
> 
> Aleix Pol Gonzalez wrote:
> Let's create a wiki for them to install the Plasma integration? This way 
> they'll be fixing all of it, not just this precise dialog.
> 
> Or I can discard this review and port it to use KFileWidget. Or 
> undeprecate KFileDialog?
> 
> Albert Astals Cid wrote:
> Any idea why i have 3 commic book entries and 2 PDF entries? 
> http://i.imgur.com/trqsguU.png

PDF is because there's 2 PDF mimetypes supported (?):
```
"application/x-pdf", "application/pdf"
```

There's 3 comic book entries because these 3 mimetypes have the same 
description (!):
```
"application/x-cbz" "comic book archive"
"application/x-cbr" "comic book archive"
"application/x-cbt" "comic book archive"
```

First one could probably be filtered in the okular side, but also should be 
fixed in KIO. In fact, `QMimeType` is smart enough to tell they're the same.

Second one, we can either include the suffix in the description or merge them. 
Opinions?


- Aleix


-------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127021/#review92202
---


On Feb. 10, 2016, 3:23 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127021/
> ---
> 
> (Updated Feb. 10, 2016, 3:23 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Drops KDELibs4Support usage, mostly it wasn't actually used, except for that 
> KFileDialog usage that I ported.
> 
> 
> Diffs
> -
> 
>   shell/shell.cpp c97054a 
> 
> Diff: https://git.reviewboard.kde.org/r/127021/diff/
> 
> 
> Testing
> ---
> 
> Opening dialog seems to work fine, tests still pass except for parttest, but 
> I'm unsure it's related: https://paste.kde.org/p37pdubgf
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

[Aleix Pol Gonzalez]

> On Feb. 10, 2016, 12:23 a.m., Albert Astals Cid wrote:
> > The new dialog "file type" looks fugly and tehre's no "all file types" 
> > anymore.
> 
> Aleix Pol Gonzalez wrote:
> https://git.reviewboard.kde.org/r/127024/
> 
> :)
> 
> Albert Astals Cid wrote:
> that won't fix http://i.imgur.com/AwIzhqr.png right? That's the Qt dialog 
> i guess? Is it really supposed to be that ugly?
> 
> Aleix Pol Gonzalez wrote:
> You don't have it set up properly, you should be getting the normal 
> KFileWidget-based dialog.
> 
> Albert Astals Cid wrote:
> I know i don't have it setup to give me the "Plasma experience", it's 
> giving me the "Okular experience outside plasma", and it is a serious 
> regression to what we have by using KFileDialog, don't you think?
> 
> Aleix Pol Gonzalez wrote:
> As I see it, there's no non-_Plasma Experience_. In Gnome, it should use 
> the GTK thingie, in Plasma it should use the Plasma dialog, and on Windows or 
> Android, whatever they use there: so it's not a regression but a feature.
> 
> Albert Astals Cid wrote:
> There's more things in Linux land than Plasma and Gnome, i'm worried 
> about such an ugly dialog for those people.

Let's create a wiki for them to install the Plasma integration? This way 
they'll be fixing all of it, not just this precise dialog.

Or I can discard this review and port it to use KFileWidget. Or undeprecate 
KFileDialog?


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127021/#review92202
---


On Feb. 10, 2016, 3:23 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127021/
> ---
> 
> (Updated Feb. 10, 2016, 3:23 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Drops KDELibs4Support usage, mostly it wasn't actually used, except for that 
> KFileDialog usage that I ported.
> 
> 
> Diffs
> -
> 
>   shell/shell.cpp c97054a 
> 
> Diff: https://git.reviewboard.kde.org/r/127021/diff/
> 
> 
> Testing
> ---
> 
> Opening dialog seems to work fine, tests still pass except for parttest, but 
> I'm unsure it's related: https://paste.kde.org/p37pdubgf
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

[Aleix Pol Gonzalez]

> On Feb. 10, 2016, 12:23 a.m., Albert Astals Cid wrote:
> > The new dialog "file type" looks fugly and tehre's no "all file types" 
> > anymore.
> 
> Aleix Pol Gonzalez wrote:
> https://git.reviewboard.kde.org/r/127024/
> 
> :)
> 
> Albert Astals Cid wrote:
> that won't fix http://i.imgur.com/AwIzhqr.png right? That's the Qt dialog 
> i guess? Is it really supposed to be that ugly?
> 
> Aleix Pol Gonzalez wrote:
> You don't have it set up properly, you should be getting the normal 
> KFileWidget-based dialog.
> 
> Albert Astals Cid wrote:
> I know i don't have it setup to give me the "Plasma experience", it's 
> giving me the "Okular experience outside plasma", and it is a serious 
> regression to what we have by using KFileDialog, don't you think?

As I see it, there's no non-_Plasma Experience_. In Gnome, it should use the 
GTK thingie, in Plasma it should use the Plasma dialog, and on Windows or 
Android, whatever they use there: so it's not a regression but a feature.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127021/#review92202
---


On Feb. 10, 2016, 3:23 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127021/
> ---
> 
> (Updated Feb. 10, 2016, 3:23 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Drops KDELibs4Support usage, mostly it wasn't actually used, except for that 
> KFileDialog usage that I ported.
> 
> 
> Diffs
> -
> 
>   shell/shell.cpp c97054a 
> 
> Diff: https://git.reviewboard.kde.org/r/127021/diff/
> 
> 
> Testing
> ---
> 
> Opening dialog seems to work fine, tests still pass except for parttest, but 
> I'm unsure it's related: https://paste.kde.org/p37pdubgf
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 127042: Fix QUrl string encoding

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127042/
---

Review request for Okular.


Repository: okular


Description
---

This Url is converted in to a string to be parsed back using `QUrl( urlString, 
QUrl::StrictMode )`.
By default, it uses `PrettyDecoded`, which makes `QUrl::StrictMode` choke.

An alternative patch would be to overload openDocument to also take QUrl and 
skip the back-and-forth conversion.


Diffs
-

  shell/okular_main.cpp 9bdc1fe 

Diff: https://git.reviewboard.kde.org/r/127042/diff/


Testing
---

Now I can open files with a space in it.


Thanks,

Aleix Pol Gonzalez

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127042: Fix QUrl string encoding

[Aleix Pol Gonzalez]

> On Feb. 12, 2016, 1:40 a.m., Alex Richardson wrote:
> > This will still fail when invoked via dbus right? maybe we should just 
> > remove the strict mode, I have no idea why I added that.

Well, it will work if the URL is strictly encoded.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127042/#review92284
---


On Feb. 11, 2016, 8:50 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127042/
> ---
> 
> (Updated Feb. 11, 2016, 8:50 p.m.)
> 
> 
> Review request for Okular and Alex Richardson.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This Url is converted in to a string to be parsed back using `QUrl( 
> urlString, QUrl::StrictMode )`.
> By default, it uses `PrettyDecoded`, which makes `QUrl::StrictMode` choke.
> 
> An alternative patch would be to overload openDocument to also take QUrl and 
> skip the back-and-forth conversion.
> 
> 
> Diffs
> -
> 
>   shell/okular_main.cpp 9bdc1fe 
> 
> Diff: https://git.reviewboard.kde.org/r/127042/diff/
> 
> 
> Testing
> ---
> 
> Now I can open files with a space in it.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127021/
---

Review request for Okular.


Repository: okular


Description
---

Drops KDELibs4Support usage, mostly it wasn't actually used, except for that 
KFileDialog usage that I ported.


Diffs
-

  autotests/CMakeLists.txt 4530c33 
  generators/mobipocket/CMakeLists.txt 87995e3 
  shell/CMakeLists.txt 7a6af74 
  shell/shell.cpp c97054a 

Diff: https://git.reviewboard.kde.org/r/127021/diff/


Testing
---

Opening dialog seems to work fine, tests still pass except for parttest, but 
I'm unsure it's related: https://paste.kde.org/p37pdubgf


Thanks,

Aleix Pol Gonzalez

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

[Aleix Pol Gonzalez]

> On Feb. 10, 2016, 12:23 a.m., Albert Astals Cid wrote:
> > The new dialog "file type" looks fugly and tehre's no "all file types" 
> > anymore.

https://git.reviewboard.kde.org/r/127024/

:)


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127021/#review92202
---


On Feb. 9, 2016, 3:51 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127021/
> ---
> 
> (Updated Feb. 9, 2016, 3:51 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Drops KDELibs4Support usage, mostly it wasn't actually used, except for that 
> KFileDialog usage that I ported.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 4530c33 
>   generators/mobipocket/CMakeLists.txt 87995e3 
>   shell/CMakeLists.txt 7a6af74 
>   shell/shell.cpp c97054a 
> 
> Diff: https://git.reviewboard.kde.org/r/127021/diff/
> 
> 
> Testing
> ---
> 
> Opening dialog seems to work fine, tests still pass except for parttest, but 
> I'm unsure it's related: https://paste.kde.org/p37pdubgf
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127021/
---

(Updated Feb. 10, 2016, 3:23 a.m.)


Review request for Okular.


Repository: okular


Description
---

Drops KDELibs4Support usage, mostly it wasn't actually used, except for that 
KFileDialog usage that I ported.


Diffs (updated)
-

  shell/shell.cpp c97054a 

Diff: https://git.reviewboard.kde.org/r/127021/diff/


Testing
---

Opening dialog seems to work fine, tests still pass except for parttest, but 
I'm unsure it's related: https://paste.kde.org/p37pdubgf


Thanks,

Aleix Pol Gonzalez

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 126375: Remove kdelibs4support from the generator plugins

[Aleix Pol Gonzalez]

> On Dec. 16, 2015, 5:42 p.m., Alex Richardson wrote:
> > ui/guiutils.cpp, line 207
> > 
> >
> > Not really related but it would be nice to handle remote URLs here as 
> > well, QFileDialog::getSaveFileUrl() and use KIO instead of QFile to save it?

Patches welcome? :D


> On Dec. 16, 2015, 5:42 p.m., Alex Richardson wrote:
> > generators/djvu/kdjvu.cpp, line 39
> > 
> >
> > Use qCDebug() together with ecm_qt_declare_logging_category() ?
> 
> Patrick Spendrin wrote:
> Yes, I only saw that after the review was opened, I'll adapt this to the 
> way the other generators handle it.

I'll fix it and commit the patch.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126375/#review89607
---


On Dec. 16, 2015, 1:41 a.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126375/
> ---
> 
> (Updated Dec. 16, 2015, 1:41 a.m.)
> 
> 
> Review request for kdewin and Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This removes kdelibs4support for all generators except the mobipocket one.
> The test executable for kimgio needs some windows fixes too, so I'll try
> to make a separate review for that.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 72ff3e8754a9005dd09cf49e83d67b0a4f9258db 
>   generators/comicbook/CMakeLists.txt 
> 684613b5bd756696eff79b52f0e184588f19f3d5 
>   generators/comicbook/unrar.cpp 6290919286ee7c2fa8d64599aae44915750a2606 
>   generators/djvu/CMakeLists.txt 34dc1a139eaae868464fb158a35408000ffc2ed7 
>   generators/djvu/generator_djvu.cpp 740e38c665b7f3a0d174b56c2fbe2bbc5fb5cfe0 
>   generators/djvu/kdjvu.cpp 3a5b29e6869222ff94c503d6bc46e736b24e7f60 
>   generators/dvi/CMakeLists.txt 38f321a1118f68027a2e1e365f79ee607f67bfe7 
>   generators/dvi/pageSize.cpp fefedd5a5de843c47abba15162b9835848119f38 
>   generators/epub/CMakeLists.txt 41ecd23a4d04997aef297f190da8f1b06e0732d8 
>   generators/kimgio/CMakeLists.txt 5d9011b02ae76daac6b98e390b13857837dd9bc4 
>   generators/kimgio/generator_kimgio.cpp 
> 84c155b5ad8da5057a28faaffa417ecb60a64ab3 
>   generators/ooo/CMakeLists.txt eb6f63ca00c898c437c40c68466795b2b8f70f64 
>   generators/ooo/styleparser.cpp 0547b84b13287591ea5248d47065dbf925524fb1 
>   generators/poppler/CMakeLists.txt a696ffbb8218abb8094afbc0db1b249bc2d9c3c8 
>   generators/poppler/generator_pdf.cpp 
> 90db80a41ecef76733ab79ebc41c162725cf30ed 
>   generators/spectre/CMakeLists.txt d7eb0e28d4d15072e0c118dd79b005d8ac9ea9c1 
>   generators/tiff/CMakeLists.txt 89603085fef5fdfd135f04e1d4f0026772a663b0 
>   generators/tiff/generator_tiff.cpp cf4f2762a506a07288bb6fb1169ddbceb5a5eccb 
>   ui/guiutils.cpp 379d1e625e7b77a870ed04258a3fe1de3aadeb91 
>   ui/pagepainter.cpp 0c8443cc93c0d81e0cf92a7f5bd9ac3c79a0fb3a 
> 
> Diff: https://git.reviewboard.kde.org/r/126375/diff/
> 
> 
> Testing
> ---
> 
> Windows.
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 126913: use QScreen unconditionally instead of libkscreen

[Aleix Pol Gonzalez]

> On Jan. 30, 2016, 4:15 p.m., Albert Astals Cid wrote:
> > Hold an A4 paper against your screen at 100% zoom, is the page of proper 
> > size?

I just tested it, looks good.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126913/#review91799
---


On Jan. 28, 2016, 4:07 a.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126913/
> ---
> 
> (Updated Jan. 28, 2016, 4:07 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This patch removes libkscreen usage and ports it to QScreen.
> 
> - Instead of retrieving and polishing the DPI from libkscreen, use
>   the widget's windowhandle to retrieve the current screen and return
>   that as the widget's DPI.
> 
> - Remove libkscreen from buildsystem
> 
> - Kill old libkscreen code. This wasn't built anyway, and wouldn't build
>   against new libkscreen anyway.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 492de00 
>   config-okular.h.cmake 4b4b2ee 
>   core/utils.cpp 2aa8f07 
> 
> Diff: https://git.reviewboard.kde.org/r/126913/diff/
> 
> 
> Testing
> ---
> 
> little, started okular on my laptop and viewed a pdf, nothing odd going on...
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 126375: Remove kdelibs4support from the generator plugins

[Aleix Pol Gonzalez]

> On Dec. 16, 2015, 5:42 p.m., Alex Richardson wrote:
> > generators/djvu/kdjvu.cpp, line 39
> > <https://git.reviewboard.kde.org/r/126375/diff/1/?file=422860#file422860line39>
> >
> > Use qCDebug() together with ecm_qt_declare_logging_category() ?
> 
> Patrick Spendrin wrote:
> Yes, I only saw that after the review was opened, I'll adapt this to the 
> way the other generators handle it.
> 
> Aleix Pol Gonzalez wrote:
> I'll fix it and commit the patch.

They're ifdef'd, not really required IMHO.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126375/#review89607
---


On Dec. 16, 2015, 1:41 a.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126375/
> ---
> 
> (Updated Dec. 16, 2015, 1:41 a.m.)
> 
> 
> Review request for kdewin and Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This removes kdelibs4support for all generators except the mobipocket one.
> The test executable for kimgio needs some windows fixes too, so I'll try
> to make a separate review for that.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 72ff3e8754a9005dd09cf49e83d67b0a4f9258db 
>   generators/comicbook/CMakeLists.txt 
> 684613b5bd756696eff79b52f0e184588f19f3d5 
>   generators/comicbook/unrar.cpp 6290919286ee7c2fa8d64599aae44915750a2606 
>   generators/djvu/CMakeLists.txt 34dc1a139eaae868464fb158a35408000ffc2ed7 
>   generators/djvu/generator_djvu.cpp 740e38c665b7f3a0d174b56c2fbe2bbc5fb5cfe0 
>   generators/djvu/kdjvu.cpp 3a5b29e6869222ff94c503d6bc46e736b24e7f60 
>   generators/dvi/CMakeLists.txt 38f321a1118f68027a2e1e365f79ee607f67bfe7 
>   generators/dvi/pageSize.cpp fefedd5a5de843c47abba15162b9835848119f38 
>   generators/epub/CMakeLists.txt 41ecd23a4d04997aef297f190da8f1b06e0732d8 
>   generators/kimgio/CMakeLists.txt 5d9011b02ae76daac6b98e390b13857837dd9bc4 
>   generators/kimgio/generator_kimgio.cpp 
> 84c155b5ad8da5057a28faaffa417ecb60a64ab3 
>   generators/ooo/CMakeLists.txt eb6f63ca00c898c437c40c68466795b2b8f70f64 
>   generators/ooo/styleparser.cpp 0547b84b13287591ea5248d47065dbf925524fb1 
>   generators/poppler/CMakeLists.txt a696ffbb8218abb8094afbc0db1b249bc2d9c3c8 
>   generators/poppler/generator_pdf.cpp 
> 90db80a41ecef76733ab79ebc41c162725cf30ed 
>   generators/spectre/CMakeLists.txt d7eb0e28d4d15072e0c118dd79b005d8ac9ea9c1 
>   generators/tiff/CMakeLists.txt 89603085fef5fdfd135f04e1d4f0026772a663b0 
>   generators/tiff/generator_tiff.cpp cf4f2762a506a07288bb6fb1169ddbceb5a5eccb 
>   ui/guiutils.cpp 379d1e625e7b77a870ed04258a3fe1de3aadeb91 
>   ui/pagepainter.cpp 0c8443cc93c0d81e0cf92a7f5bd9ac3c79a0fb3a 
> 
> Diff: https://git.reviewboard.kde.org/r/126375/diff/
> 
> 
> Testing
> ---
> 
> Windows.
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 126379: Windows string fixes

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126379/#review90208
---


+1

- Aleix Pol Gonzalez


On Dec. 27, 2015, 1:28 a.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126379/
> ---
> 
> (Updated Dec. 27, 2015, 1:28 a.m.)
> 
> 
> Review request for kdewin and Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This patch changes multiline QStringLiterals to QString::fromLatin1
> as QStringLiterals doesn't understand multiline strings on windows.
> Also, strncasecmp is replaced by the portable qstricmp function provided
> by QByteArray header.
> 
> 
> Diffs
> -
> 
>   generators/dvi/dviRenderer_prescan.cpp 
> 783c7273c6f7d1be03f5e970dc23e0a24a31197f 
>   generators/dvi/psgs.cpp b1eedc42864abf5a868a5bc6eebf258b1f7cf168 
>   generators/dvi/special.cpp 6a9fe69b2d44cfed95284b4d37f767c00c73721c 
>   generators/epub/converter.cpp 16a6b5beabe1803ea4cdacc4d571edca7ff9ec23 
>   ui/latexrenderer.cpp 8e42a9f88a8aa4ff73b544bf41642d59ca86474a 
>   ui/pageview.cpp 13727e4647781cd9222956cae2c9e3fbc1a42324 
> 
> Diff: https://git.reviewboard.kde.org/r/126379/diff/
> 
> 
> Testing
> ---
> 
> Windows.
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 324241] Files generated with QTextDocument can't be opened with okular

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=324241

--- Comment #1 from Aleix Pol aleix...@kde.org ---
Created attachment 82020
  -- https://bugs.kde.org/attachment.cgi?id=82020action=edit
here's a file to reproduce the problem

LibreOffice can open it

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 319491] New: Crash while closing Okular

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=319491

Bug ID: 319491
   Summary: Crash while closing Okular
Classification: Unclassified
   Product: okular
   Version: 0.16.60
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Keywords: drkonqi
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: aleix...@kde.org

Application: okular (0.16.60)
KDE Platform Version: 4.10.60 (Compiled from sources)
Qt Version: 4.8.4
Operating System: Linux 3.8.4-1-ARCH x86_64
Distribution: Arch Linux

-- Information about the crash:
- What I was doing when the application crashed:
Okular crashed when I closed a PDF file, using Ctrl+W.

I cannot reproduce anymore, I'm using master.

-- Backtrace:
Application: Okular (okular), signal: Segmentation fault
Using host libthread_db library /usr/lib/libthread_db.so.1.
[KCrash Handler]
#6  0x7fc033ff33b7 in Okular::Page::hasTilesManager (this=0x1e1cde0) at
/home/kde-devel/src/okular/core/page.cpp:991
#7  0x7fc034332250 in PageView::slotRequestVisiblePixmaps (this=0x1c61bb0,
newValue=1) at /home/kde-devel/src/okular/ui/pageview.cpp:4145
#8  0x7fc03432ffb6 in PageView::scrollTo (this=0x1c61bb0, x=0, y=-335) at
/home/kde-devel/src/okular/ui/pageview.cpp:3733
#9  0x7fc03432fed7 in PageView::center (this=0x1c61bb0, cx=498, cy=0) at
/home/kde-devel/src/okular/ui/pageview.cpp:3716
#10 0x7fc034331576 in PageView::slotRelayoutPages (this=0x1c61bb0) at
/home/kde-devel/src/okular/ui/pageview.cpp:4022
#11 0x7fc034334fa3 in PageView::qt_static_metacall (_o=0x1c61bb0,
_c=QMetaObject::InvokeMetaMethod, _id=15, _a=0x1b18e20) at ./pageview.moc:170
#12 0x7fc0424ec06e in QObject::event(QEvent*) () from
/usr/lib/libQtCore.so.4
#13 0x7fc04350f18a in QWidget::event(QEvent*) () from
/usr/lib/libQtGui.so.4
#14 0x7fc0438bad36 in QFrame::event(QEvent*) () from /usr/lib/libQtGui.so.4
#15 0x7fc04393aa9b in QAbstractScrollArea::event(QEvent*) () from
/usr/lib/libQtGui.so.4
#16 0x7fc0434c018c in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /usr/lib/libQtGui.so.4
#17 0x7fc0434c460a in QApplication::notify(QObject*, QEvent*) () from
/usr/lib/libQtGui.so.4
#18 0x7fc04421c25a in KApplication::notify (this=0x7fffb359cb30,
receiver=0x1c61bb0, event=0x1f513b0) at
/home/kde-devel/src/kdelibs/kdeui/kernel/kapplication.cpp:311
#19 0x7fc0424d76ae in QCoreApplication::notifyInternal(QObject*, QEvent*)
() from /usr/lib/libQtCore.so.4
#20 0x7fc0424db011 in QCoreApplicationPrivate::sendPostedEvents(QObject*,
int, QThreadData*) () from /usr/lib/libQtCore.so.4
#21 0x7fc0425059d3 in ?? () from /usr/lib/libQtCore.so.4
#22 0x7fc03d44ff06 in g_main_context_dispatch () from
/usr/lib/libglib-2.0.so.0
#23 0x7fc03d450258 in ?? () from /usr/lib/libglib-2.0.so.0
#24 0x7fc03d4502fc in g_main_context_iteration () from
/usr/lib/libglib-2.0.so.0
#25 0x7fc042505b66 in
QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) ()
from /usr/lib/libQtCore.so.4
#26 0x7fc04356069e in ?? () from /usr/lib/libQtGui.so.4
#27 0x7fc0424d63ff in
QEventLoop::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () from
/usr/lib/libQtCore.so.4
#28 0x7fc0424d6688 in
QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () from
/usr/lib/libQtCore.so.4
#29 0x7fc0424db328 in QCoreApplication::exec() () from
/usr/lib/libQtCore.so.4
#30 0x0040954d in main (argc=6, argv=0x7fffb359ce68) at
/home/kde-devel/src/okular/shell/main.cpp:100

Reported using DrKonqi

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 284406] New: Zoom combo box is broken

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=284406

   Summary: Zoom combo box is broken
   Product: okular
   Version: unspecified
  Platform: Unlisted Binaries
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: NOR
 Component: general
AssignedTo: okular-devel@kde.org
ReportedBy: aleix...@kde.org


Version:   unspecified (using Devel) 
OS:Linux

If I try to change the zoom using the combo box placed in the toolbar to a
numeric value, the value always jumps to 10%.

Reproducible: Always

Steps to Reproduce:
Change the zoom by using the combo to any numeric value (not Fit page/width).

Actual Results:  
10%

Expected Results:  
whatever I entered

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 284406] Zoom combo box is broken

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=284406





--- Comment #1 from Aleix Pol aleixpol kde org  2011-10-18 20:27:03 ---
BTW, I'm using KDE master, maybe that helps.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Remove TODO and make what it is asking to do

[Aleix Pol Gonzalez]

 On Aug. 5, 2011, 10:07 p.m., Albert Astals Cid wrote:
  I wonder if we can ever end up in this code, because
 
 Albert Astals Cid wrote:
 Wops, here comes the full comment D
 
 I wonder if we can ever end up in this code, because the else is for zip 
 files containing a fb2 file but the .desktop file of the plugin says it 
 supports application/x-fictionbook+xml so i can not see a way that the code 
 flow ends up in that else branch of the if, so we can either just push your 
 code because it is techinically correct or remove all the if altogether :D

You call, I'm fine with committing and I'm fine with you removing all together 
:). Maintainer!


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102220/#review5420
---


On Aug. 5, 2011, 7:52 a.m., Aleix Pol Gonzalez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/102220/
 ---
 
 (Updated Aug. 5, 2011, 7:52 a.m.)
 
 
 Review request for Okular.
 
 
 Summary
 ---
 
 While on the plane Albert and I, we decided to fix okular stuff.
 
 This was something to do, hope that helps.
 
 Deletes a resource that is never freed.
 
 
 Diffs
 -
 
   generators/fictionbook/document.cpp e943566 
 
 Diff: http://git.reviewboard.kde.org/r/102220/diff
 
 
 Testing
 ---
 
 None, didn't have any fictionbook to try.
 
 
 Thanks,
 
 Aleix
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Remove TODO and make what it is asking to do

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102220/
---

(Updated Aug. 5, 2011, 7:52 a.m.)


Review request for Okular.


Summary (updated)
---

While on the plane Albert and I, we decided to fix okular stuff.

This was something to do, hope that helps.

Deletes a resource that is never freed.


Diffs
-

  generators/fictionbook/document.cpp e943566 

Diff: http://git.reviewboard.kde.org/r/102220/diff


Testing
---

None, didn't have any fictionbook to try.


Thanks,

Aleix

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request: Change mouse cursor when changing the current tool.

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102221/
---

Review request for Okular.


Summary
---

Update the cursors when changing the current mode. Addresses the problems in 
the bug report.

- Use a opened/closed hand for browsing.
- Use cross for selection.


This addresses bug 271816.
http://bugs.kde.org/show_bug.cgi?id=271816


Diffs
-

  ui/pageview.cpp f103b2f 

Diff: http://git.reviewboard.kde.org/r/102221/diff


Testing
---

Play around with okular and see if it works as expected, which does apparently.


Thanks,

Aleix

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 271816] I want the cursor to change in browsing/selection mode

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=271816


Aleix Pol aleix...@kde.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Comment #2 from Aleix Pol aleixpol kde org  2011-08-05 21:49:18 ---
Git commit 390bf78eccf29e41a4c7915e256920ff2bf58b07 by Aleix Pol.
Committed on 05/08/2011 at 23:47.
Pushed by apol into branch 'master'.

Change mouse cursor when changing the current tool

Update the cursors when changing the current mode. Addresses the problems in
the bug report.

- Use a opened/closed hand for browsing.
- Use cross for selection.

BUG: 271816
REVIEW: 102221

M  +7-1ui/pageview.cpp

http://commits.kde.org/okular/390bf78eccf29e41a4c7915e256920ff2bf58b07

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 271301] New: There's not an option to disable the selection when in selection mode

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=271301

   Summary: There's not an option to disable the selection when in
selection mode
   Product: okular
   Version: 0.10.5
  Platform: Ubuntu Packages
OS/Version: Linux
Status: NEW
  Severity: wishlist
  Priority: NOR
 Component: general
AssignedTo: okular-devel@kde.org
ReportedBy: aleix...@kde.org


Version:   0.10.5 (using KDE 4.4.5) 
OS:Linux

After selecting it's too complicated to get back to the usual hand mode to
properly navigate inside the document.

Reproducible: Always

Steps to Reproduce:
- Select Selection tool
- Select anything, or not.
- Desire to see something different


Actual Results:  
You have to go back to the menu

Expected Results:  
A toolbar icon with a hand

I'd say this could be a JJ.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 267522] Crash when opening Okular with the following file

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=267522





--- Comment #2 from Aleix Pol aleixpol kde org  2011-03-03 21:28:06 ---
Created an attachment (id=57656)
 -- (http://bugs.kde.org/attachment.cgi?id=57656)
Crashy file

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel