[okular] [Bug 435075] Multiple instances of Okular mess up recently opened files

[Chinmoy Ranjan Pradhan]

https://bugs.kde.org/show_bug.cgi?id=435075

Chinmoy Ranjan Pradhan  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 CC||chinmoyr...@gmail.com
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

D13114: Add DocumentRevision to Okular

[Chinmoy Ranjan Pradhan]

chinmoyr abandoned this revision.
chinmoyr added a comment.


  @aacid Sorry for  late reply. This got lost in my inbox.
  
  This diff is not required. The relevant code for generating revision is 
already in poppler_generator.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13114

To: chinmoyr, aacid
Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D13484: Show signature validation summary as popup

[Chinmoy Ranjan Pradhan]

chinmoyr reopened this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13484

To: chinmoyr, aacid
Cc: ngraham, okular-devel, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

[Chinmoy Ranjan Pradhan]

chinmoyr reopened this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13366

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14748: Add signature properties dialog

[Chinmoy Ranjan Pradhan]

chinmoyr reopened this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14748

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14734: Add revision viewer

[Chinmoy Ranjan Pradhan]

chinmoyr reopened this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14734

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14696: Add certificate viewer

[Chinmoy Ranjan Pradhan]

chinmoyr reopened this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14696

To: chinmoyr, aacid, ngraham
Cc: okular-devel, ngraham, aacid

D14656: Add utitlity functions for use in digital signature verification

[Chinmoy Ranjan Pradhan]

chinmoyr reopened this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14656

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14655: Reimplement signature form field and related utility classes in poppler generator

[Chinmoy Ranjan Pradhan]

chinmoyr reopened this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14655

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D12901: Add unit test for SignatureFormField

[Chinmoy Ranjan Pradhan]

chinmoyr reopened this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12901

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14654: Add API for signature form field, and other helper classes

[Chinmoy Ranjan Pradhan]

chinmoyr reopened this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14654

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14816: Add signature panel

[Chinmoy Ranjan Pradhan]

chinmoyr reopened this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14816

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14654: Add API for signature form field, and other helper classes

[Chinmoy Ranjan Pradhan]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:0696f4cb55a7: Add API for signature form field, and other 
helper classes (authored by chinmoyr).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14654?vs=39207=39712

REVISION DETAIL
  https://phabricator.kde.org/D14654

AFFECTED FILES
  CMakeLists.txt
  core/form.cpp
  core/form.h
  core/signatureutils.cpp
  core/signatureutils.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14816: Add signature panel

[Chinmoy Ranjan Pradhan]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:bb1dbebb4f68: Add signature panel (authored by chinmoyr).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14816?vs=39656=39710

REVISION DETAIL
  https://phabricator.kde.org/D14816

AFFECTED FILES
  CMakeLists.txt
  part.cpp
  part.h
  ui/formwidgets.cpp
  ui/formwidgets.h
  ui/pageview.cpp
  ui/pageview.h
  ui/signaturemodel.cpp
  ui/signaturemodel.h
  ui/signaturepanel.cpp
  ui/signaturepanel.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14656: Add utitlity functions for use in digital signature verification

[Chinmoy Ranjan Pradhan]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:53e095439724: Add utitlity functions for use in digital 
signature verification (authored by chinmoyr).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14656?vs=39212=39706

REVISION DETAIL
  https://phabricator.kde.org/D14656

AFFECTED FILES
  CMakeLists.txt
  ui/signatureguiutils.cpp
  ui/signatureguiutils.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14696: Add certificate viewer

[Chinmoy Ranjan Pradhan]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:35965f914548: Add certificate viewer (authored by 
chinmoyr).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14696?vs=39319=39707

REVISION DETAIL
  https://phabricator.kde.org/D14696

AFFECTED FILES
  CMakeLists.txt
  ui/certificateviewer.cpp
  ui/certificateviewer.h

To: chinmoyr, aacid, ngraham
Cc: okular-devel, ngraham, aacid

D14734: Add revision viewer

[Chinmoy Ranjan Pradhan]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:b7a841e8eed1: Add revision viewer (authored by chinmoyr).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14734?vs=39420=39708

REVISION DETAIL
  https://phabricator.kde.org/D14734

AFFECTED FILES
  CMakeLists.txt
  core/document.cpp
  core/document.h
  core/generator.cpp
  core/generator.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/generator_pdf.h
  part.cpp
  ui/revisionviewer.cpp
  ui/revisionviewer.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D12901: Add unit test for SignatureFormField

[Chinmoy Ranjan Pradhan]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:29cea9796ca7: Add unit test for SignatureFormField 
(authored by chinmoyr).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12901?vs=34385=39705

REVISION DETAIL
  https://phabricator.kde.org/D12901

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/data/pdf_with_signature.pdf
  autotests/signatureformtest.cpp

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14655: Reimplement signature form field and related utility classes in poppler generator

[Chinmoy Ranjan Pradhan]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:d6e0577a0141: Reimplement signature form field and 
related utility classes in poppler… (authored by chinmoyr).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14655?vs=39208=39704

REVISION DETAIL
  https://phabricator.kde.org/D14655

AFFECTED FILES
  generators/poppler/CMakeLists.txt
  generators/poppler/formfields.cpp
  generators/poppler/formfields.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/pdfsignatureutils.cpp
  generators/poppler/pdfsignatureutils.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D12901: Add unit test for SignatureFormField

[Chinmoy Ranjan Pradhan]

chinmoyr edited dependencies, added: D14655: Reimplement signature form field 
and related utility classes in poppler generator; removed: D11723: Add 
FormFieldSignature to Okular namespace.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12901

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D11723: Add FormFieldSignature to Okular namespace

[Chinmoy Ranjan Pradhan]

chinmoyr removed a dependent revision: D12901: Add unit test for 
SignatureFormField.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11723

To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid

D14655: Reimplement signature form field and related utility classes in poppler generator

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D12901: Add unit test for 
SignatureFormField.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14655

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D13484: Show signature validation summary as popup

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 39701.
chinmoyr edited the summary of this revision.
chinmoyr added a dependency: D14816: Add signature panel.
chinmoyr added a comment.


  Went with @ngraham's suggestion of showing a separate message for signature. 
But the "Show Signature" button will 
  show the signature panel widget and not the forms.
  
  ss:
  F6193178: popup.jpeg 

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13484?vs=36015=39701

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13484

AFFECTED FILES
  part.cpp
  part.h
  ui/signaturepanel.cpp
  ui/signaturepanel.h

To: chinmoyr, aacid
Cc: ngraham, okular-devel, aacid

D13484: Show signature validation summary as popup

[Chinmoy Ranjan Pradhan]

chinmoyr removed a dependency: D13366: Add SignatureEdit widget for 
FormFieldSignature.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13484

To: chinmoyr, aacid
Cc: ngraham, okular-devel, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

[Chinmoy Ranjan Pradhan]

chinmoyr removed a dependent revision: D13484: Show signature validation 
summary as popup.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13366

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14748: Add signature properties dialog

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D13366: Add SignatureEdit widget for 
FormFieldSignature.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14748

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 39466.
chinmoyr edited the summary of this revision.
chinmoyr added a dependency: D14748: Add signature properties dialog.
chinmoyr added a comment.


  Added screenshot
  Rebased on master

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13366?vs=36014=39466

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13366

AFFECTED FILES
  ui/formwidgets.cpp
  ui/formwidgets.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14734: Add revision viewer

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D14748: Add signature properties dialog.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14734

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14748: Add signature properties dialog

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: aacid.
Restricted Application added a project: Okular.
Restricted Application added a subscriber: okular-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This dialog shows signature validation status, document modification summary, 
signer's name,
  signing time, reason and location.
  
  F6187326: signatureproperties1 
  
  F6187328: signatureproperties2 
  
  Depends on D14734 

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14748

AFFECTED FILES
  CMakeLists.txt
  ui/signatureguiutils.cpp
  ui/signaturepropertiesdialog.cpp
  ui/signaturepropertiesdialog.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14734: Add revision viewer

[Chinmoy Ranjan Pradhan]

chinmoyr edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14734

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14734: Add revision viewer

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 39420.
chinmoyr added a comment.


  Removed junk files

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14734?vs=39419=39420

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14734

AFFECTED FILES
  CMakeLists.txt
  core/document.cpp
  core/document.h
  core/generator.cpp
  core/generator.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/generator_pdf.h
  part.cpp
  ui/revisionviewer.cpp
  ui/revisionviewer.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14696: Add certificate viewer

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D14734: Add revision viewer.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14696

To: chinmoyr, aacid, ngraham
Cc: okular-devel, ngraham, aacid

D14734: Add revision viewer

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: aacid.
Restricted Application added a project: Okular.
Restricted Application added a subscriber: okular-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This makes use of print preview dialog to view signed version of the document.
  
  Depends on D14696 

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14734

AFFECTED FILES
  CMakeLists.txt
  core/document.cpp
  core/document.h
  core/generator.cpp
  core/generator.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/generator_pdf.h
  part.cpp
  ui/formwidgets.cpp
  ui/formwidgets.h
  ui/revisionviewer.cpp
  ui/revisionviewer.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14696: Add certificate viewer

[Chinmoy Ranjan Pradhan]

chinmoyr edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14696

To: chinmoyr, aacid, ngraham
Cc: okular-devel, ngraham, aacid

D14696: Add certificate viewer

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: aacid, ngraham.
Restricted Application added a project: Okular.
Restricted Application added a subscriber: okular-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This adds a dialog to view details of a digital certificate.
  
  Depends on D14656 

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14696

AFFECTED FILES
  CMakeLists.txt
  ui/certificateviewer.cpp
  ui/certificateviewer.h

To: chinmoyr, aacid, ngraham
Cc: okular-devel, ngraham, aacid

D14656: Add utitlity functions for use in digital signature verification

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D14696: Add certificate viewer.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14656

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14656: Add utitlity functions for use in digital signature verification

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 39212.
chinmoyr added a comment.


  Removed unnecessary files

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14656?vs=39211=39212

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14656

AFFECTED FILES
  CMakeLists.txt
  ui/signatureguiutils.cpp
  ui/signatureguiutils.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14656: Add utitlity functions for use in digital signature verification

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 39211.
chinmoyr retitled this revision from "#Add utitlity functions for use in gui 
components

#Summary: 

#Test Plan: 

#Reviewers: aacid

#Subscribers: 

Add utitlity functions for use in digital signature verification" to "Add 
utitlity functions for use in digital signature verification".
chinmoyr added a comment.


  Updated title

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14656?vs=39210=39211

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14656

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/data/pdf_with_signature.pdf
  autotests/signatureformtest.cpp
  core/form.cpp
  core/form.h
  core/signatureutils.cpp
  core/signatureutils.h
  generators/poppler/CMakeLists.txt
  generators/poppler/formfields.cpp
  generators/poppler/formfields.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/pdfsignatureutils.cpp
  generators/poppler/pdfsignatureutils.h
  ui/signatureguiutils.cpp
  ui/signatureguiutils.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14656: #Add utitlity functions for use in gui components#Summary: #Test Plan: #Reviewers: aacid#Subscribers: Add utitlity functions for use in digital signature verification

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: aacid.
Restricted Application added a project: Okular.
Restricted Application added a subscriber: okular-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Adds functions to get signature form fields and convert various enums related 
to 
  a digital signature into translatable string.
  
  Depends on D14655 

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14656

AFFECTED FILES
  CMakeLists.txt
  ui/signatureguiutils.cpp
  ui/signatureguiutils.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14655: Reimplement signature form field and related utility classes in poppler generator

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D14656: #Add utitlity functions for use in 
gui components

#Summary: 

#Test Plan: 

#Reviewers: aacid

#Subscribers: 

Add utitlity functions for use in digital signature verification.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14655

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14654: Add API for signature form field, and other helper classes

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D14655: Reimplement signature form field 
and related utility classes in poppler generator.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14654

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14655: Reimplement signature form field and related utility classes in poppler generator

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: aacid.
Restricted Application added a project: Okular.
Restricted Application added a subscriber: okular-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This adds class PopplerFormFieldSignature, PopplerSignatureInfo and 
PopplerCertificateInfo in poppler
  generator.
  
  Depends on D14654 

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14655

AFFECTED FILES
  generators/poppler/CMakeLists.txt
  generators/poppler/formfields.cpp
  generators/poppler/formfields.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/pdfsignatureutils.cpp
  generators/poppler/pdfsignatureutils.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D14654: Add API for signature form field, and other helper classes

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: aacid.
Restricted Application added a project: Okular.
Restricted Application added a subscriber: okular-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This adds class FormFieldSignature which will represent a digital signature,
  class SignatureInfo which will store signature validation information and
  class CertificateInfo which will store details of the signing certificate.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14654

AFFECTED FILES
  CMakeLists.txt
  core/form.cpp
  core/form.h
  core/signatureutils.cpp
  core/signatureutils.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog

[Chinmoy Ranjan Pradhan]

chinmoyr abandoned this revision.
chinmoyr added a comment.


  Outdated diff

INLINE COMMENTS

> aacid wrote in signaturewidgets.cpp:158
> Fixed size is usually not a good idea, why are you doing it?

Well it's the result of taking your advice of "do what adobe does" bit too far.
Just curious, why is it bad? Because you can only see elided text? Are there 
other reasons?

> aacid wrote in signaturewidgets.cpp:168
> Maybe activated makes more sense than clicked so it can be used with the 
> keyboard too?

For certificate viewer I will take that into  consideration.

> aacid wrote in signaturewidgets.cpp:171
> Why a readonly textedit instead of a label?

Because adobe reader has a read only textedit.

> aacid wrote in signaturewidgets.cpp:215
> I'm not sure but i think it's a bit drasting closing this dialog when asking 
> for "Signature Properties", what's the rationale behind it?

Even here I copied adobe.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13483

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D11723: Add FormFieldSignature to Okular namespace

[Chinmoy Ranjan Pradhan]

chinmoyr abandoned this revision.
chinmoyr added a comment.


  Outdated revision

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11723

To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid

D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D13366: Add SignatureEdit widget for 
FormFieldSignature.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13483

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D13484: Show signature validation summary as popup

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependency: D13366: Add SignatureEdit widget for 
FormFieldSignature.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13484

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D13484: Show signature validation summary 
as popup.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13366

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D11723: Add FormFieldSignature to Okular namespace

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D13483: Add SignatureSummaryDialog and 
SignaturePropertiesDialog.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11723

To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

[Chinmoy Ranjan Pradhan]

chinmoyr edited dependencies, added: D13483: Add SignatureSummaryDialog and 
SignaturePropertiesDialog; removed: D11723: Add FormFieldSignature to Okular 
namespace.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13366

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D11723: Add FormFieldSignature to Okular namespace

[Chinmoy Ranjan Pradhan]

chinmoyr removed a dependent revision: D13366: Add SignatureEdit widget for 
FormFieldSignature.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11723

To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid

D13484: Show signature validation summary as popup

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: aacid.
Restricted Application added a project: Okular.
Restricted Application added a subscriber: okular-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This patch adds support for validating all signatures present in the PDF at 
once
  and show the validation summary as popup in the page view.

TEST PLAN
  Open a signed PDF and click on "Validate All Signatures".

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13484

AFFECTED FILES
  part.cpp
  part.h
  ui/pageview.cpp
  ui/pageview.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 36014.
chinmoyr added a comment.


  Rebased on master
  Made use of SignatureSummaryDialog and SignaturePropertiesDialog

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13366?vs=35637=36014

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13366

AFFECTED FILES
  ui/formwidgets.cpp
  ui/formwidgets.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: aacid.
Restricted Application added a project: Okular.
Restricted Application added a subscriber: okular-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  SignatureSummaryDialog will display the signature validation summary and
  SignaturePropertiesDialog will display the signature validation information.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13483

AFFECTED FILES
  CMakeLists.txt
  ui/signaturewidgets.cpp
  ui/signaturewidgets.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D11723: Add FormFieldSignature to Okular namespace

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 35983.
chinmoyr added a comment.


  Revert to previous version. Now signatures will not be validated upfront.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11723?vs=35513=35983

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11723

AFFECTED FILES
  CMakeLists.txt
  core/form.cpp
  core/form.h
  core/signatureinfo.cpp
  core/signatureinfo.h
  generators/poppler/CMakeLists.txt
  generators/poppler/formfields.cpp
  generators/poppler/formfields.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/pdfsignatureinfo.cpp
  generators/poppler/pdfsignatureinfo.h

To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid

D11723: Add FormFieldSignature to Okular namespace

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D13366: Add SignatureEdit widget for 
FormFieldSignature.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11723

To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependency: D11723: Add FormFieldSignature to Okular namespace.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13366

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: aacid.
Restricted Application added a project: Okular.
Restricted Application added a subscriber: okular-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This patch adds SignatureEdit widget which subclasses QAbstractButton and is 
drawn
  when a signature form field is visible. This widget will be used for 
validating
  signatures and viewing their properties.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13366

AFFECTED FILES
  ui/formwidgets.cpp
  ui/formwidgets.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D11723: Add FormFieldSignature to Okular namespace

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 35513.
chinmoyr added a comment.


  Added validateSignatures() to validate signatures while loading a page.
  Added to document info whether or not a pdf is digitally signed.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11723?vs=35510=35513

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11723

AFFECTED FILES
  CMakeLists.txt
  core/form.cpp
  core/form.h
  core/signatureinfo.cpp
  core/signatureinfo.h
  generators/poppler/CMakeLists.txt
  generators/poppler/formfields.cpp
  generators/poppler/formfields.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/generator_pdf.h
  generators/poppler/pdfsignatureinfo.cpp
  generators/poppler/pdfsignatureinfo.h

To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid

D11725: [RFC] Show signature status as a popup

[Chinmoy Ranjan Pradhan]

chinmoyr removed a dependency: D11723: Add FormFieldSignature to Okular 
namespace.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11725

To: chinmoyr, #okular
Cc: okular-devel, aacid, sander, ngraham

D12901: Add unit test for SignatureFormField

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependency: D11723: Add FormFieldSignature to Okular namespace.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12901

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D11723: Add FormFieldSignature to Okular namespace

[Chinmoy Ranjan Pradhan]

chinmoyr edited dependent revision(s), added 1: D12901: Add unit test for 
SignatureFormField; removed 1: D11725: [RFC] Show signature status as a popup.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11723

To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid

D11723: Add FormFieldSignature to Okular namespace

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 35510.
chinmoyr added a comment.


  Removed the unnecessary static_cast
  Used QScopedPointer for d_ptr

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11723?vs=35040=35510

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11723

AFFECTED FILES
  CMakeLists.txt
  core/form.cpp
  core/form.h
  core/signatureinfo.cpp
  core/signatureinfo.h
  generators/poppler/CMakeLists.txt
  generators/poppler/formfields.cpp
  generators/poppler/formfields.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/pdfsignatureinfo.cpp
  generators/poppler/pdfsignatureinfo.h

To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid

D13114: Add DocumentRevision to Okular

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D13114#269280 , @aacid wrote:
  
  > Can you explain what's the use case for this?
  
  
  Adobe reader allows user to view different signed revisions of a PDF. This 
patch intends to implement
  that feature.
  
  > I thought we had agreed  that using qvariantmaps for passing structures was 
a bad idea. 
  >  If i have to implement this for my AwesomeGenerator, how do i know what 
comes in revData?
  
  My bad, I thought you were talking about returning a QVariantMap. I will 
correct it in next update.
  
  > Also the API is weird, you have
  > 
  >   QString generateDocumentRevision( int revNum );
  > 
  > but which revNums are you going to use.
  
  The revision number starts from 1 and goes till the total number of signature 
form fields. The idea here is to 
  include the total number of signature fields in generator's metadata which 
can then be used by okular gui 
  to request generation of a revision using the field number i.e. revNum. After 
generating a temporary PDF 
  from the byte range specified in signature the generator will return its path.
  
  > I would really appreciate if you could talk to me on IRC because I'm lost 
at what you're trying to accomplish.
  
  Sorry if that caused you inconvenience. This whole month I am keeping myself 
away from using internet
  except for like 15 minutes for replying to emails and phabricator reviews. I 
think this week will be no different.
  However, starting next week I will be active on IRC. I hope it is okay with 
you (?)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13114

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D13114: Add DocumentRevision to Okular

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: aacid.
Restricted Application added a project: Okular.
Restricted Application added a subscriber: okular-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This patch adds DocumentRevision class to Okular which stores information 
that can
  be made use by generators to create a revision of the document.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13114

AFFECTED FILES
  core/document.cpp
  core/document.h
  core/generator.cpp
  core/generator.h
  generators/poppler/CMakeLists.txt
  generators/poppler/generator_pdf.cpp
  generators/poppler/generator_pdf.h
  generators/poppler/pdfrevision.cpp
  generators/poppler/pdfrevision.h

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D11723: Add FormFieldSignature to Okular namespace

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> aacid wrote in form.cpp:284
> What's this used for?

For other formfields it can be used to set their default states. But for 
signature field I have no idea.

> aacid wrote in form.h:390
> What would be the usecase for this force?

I never thought of a possible use case before duplicating it here. For now I 
have removed  it from the patch. I will update this diff if I find any use case.

> aacid wrote in form.h:412
> As a viewer when would we need to have a different validation time than now?

Same here. Never actually thought of a use case and still can't find one.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11723

To: chinmoyr, aacid
Cc: ngraham, okular-devel, aacid

D11723: Add FormFieldSignature to Okular namespace

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 34717.
chinmoyr marked 2 inline comments as done.
chinmoyr added a comment.


  Updated API.
  Removed cases with no use cases.
  Removed redundant enums.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11723?vs=34307=34717

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11723

AFFECTED FILES
  CMakeLists.txt
  core/form.cpp
  core/form.h
  core/signatureinfo.cpp
  core/signatureinfo.h
  generators/poppler/CMakeLists.txt
  generators/poppler/formfields.cpp
  generators/poppler/formfields.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/pdfsignatureinfo.cpp
  generators/poppler/pdfsignatureinfo.h

To: chinmoyr, aacid
Cc: ngraham, okular-devel, aacid

D11725: [RFC] Show signature status as a popup

[Chinmoy Ranjan Pradhan]

chinmoyr abandoned this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11725

To: chinmoyr, #okular
Cc: okular-devel, aacid, sander, ngraham

D11725: [RFC] Show signature status as a popup

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D11725#264976 , @aacid wrote:
  
  > Sorry you lost me here, what's revision 30645 ?
  
  
  My bad, I was actually referring to 
https://phabricator.kde.org/D11723?id=30645

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11725

To: chinmoyr, #okular
Cc: okular-devel, aacid, sander, ngraham

D11725: [RFC] Show signature status as a popup

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D11725#264703 , @aacid wrote:
  
  > This doesn't work anymore right? signValidationInfoList doesn't exist in  
D11723 
  
  
  It requires revision 30645 to work.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11725

To: chinmoyr, #okular
Cc: okular-devel, aacid, sander, ngraham

D12901: Add unit test for SignatureFormField

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 34385.
chinmoyr edited the summary of this revision.
chinmoyr added a comment.


  Updated test PDF.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12901?vs=34212=34385

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12901

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/data/pdf_with_signature.pdf
  autotests/signatureformtest.cpp

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D11723: Add FormFieldSignature to Okular namespace

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 34307.
chinmoyr added a comment.


  Removed code unrelated to this revision.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11723?vs=30645=34307

REVISION DETAIL
  https://phabricator.kde.org/D11723

AFFECTED FILES
  core/form.cpp
  core/form.h
  generators/poppler/formfields.cpp
  generators/poppler/formfields.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/generator_pdf.h

To: chinmoyr, aacid
Cc: ngraham, okular-devel, aacid

D12901: Add unit test for SignatureFormField

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: aacid.
Restricted Application added a project: Okular.
Restricted Application added a subscriber: okular-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Test the type of form field and the type of signature.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12901

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/data/pdf_with_signature.pdf
  autotests/signatureformtest.cpp

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid

D11723: Add FormFieldSignature to Okular namespace

[Chinmoy Ranjan Pradhan]

chinmoyr retitled this revision from "[RFC] Add FormFieldSignature to Okular's 
namespace" to "Add FormFieldSignature to Okular namespace".
chinmoyr edited reviewers, added: aacid; removed: Okular.
Restricted Application added a subscriber: okular-devel.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11723

To: chinmoyr, aacid, #okular
Cc: okular-devel, ngraham, aacid

D12049: Obey umask rules when saving new file

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  ping

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12049

To: chinmoyr, #okular, aacid
Cc: michaelweghorn, ngraham, aacid

D12098: Resize content area to correct dimensions after zooming to Auto Fit

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  ping

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12098

To: chinmoyr, #okular, aacid
Cc: michaelweghorn, ngraham, aacid

D12098: Resize content area to correct dimensions after zooming to Auto Fit

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: Okular, aacid.
Restricted Application added a project: Okular.
chinmoyr requested review of this revision.

REVISION SUMMARY
  After going from high zoom to "Auto Fit" a resize event is generated and the 
resize event handler
  tries to refresh the page view. Sometimes this can result in an infinite 
resize loop. Okular
  fixes this by resizing the content area to the new viewport size. As a 
consequence both horizontal
  and vertical scroll range become zero. Now if "Auto Fit" turns out to be "Fit 
Page" then it is fine
  but in case of "Fit Width" or "Fit Height", where one scroll range should be 
non-zero, both scroll
  bar disappear resulting in a view which appears to be frozen. So to fix this 
add scroll range
  to the dimension for which the scroll bar should be visible and then resize. 
Since the scroll range
  remains constant, an infinite resize loop won't occur.
  
  BUG: 341250

TEST PLAN
  Zoom in 400% and then select "Auto Fit".

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12098

AFFECTED FILES
  ui/pageview.cpp

To: chinmoyr, #okular, aacid
Cc: michaelweghorn, ngraham, aacid

D12049: Obey umask rules when saving new file

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 31692.
chinmoyr added a comment.


  Fix coding style

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12049?vs=31691=31692

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12049

AFFECTED FILES
  part.cpp

To: chinmoyr, #okular, aacid
Cc: michaelweghorn, ngraham, aacid

D12049: Obey umask rules when saving new file

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: Okular, aacid.
Restricted Application added a project: Okular.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Okular saves a new file with permissions 0600 completely ignoring the umask 
value. This is because it
  makes use of QTemporaryFile which creates file with the said permissions and 
which then Okular copies
  to the new location.
  So to overcome this generate new file permissions using old mask value and 
change permissions of the
  new file.
  
  BUG: 392682

TEST PLAN
  Set umask to 0040
  Open a pdf file from the same shell and save it under a new name.
  Before patch:
  file permisions -> 0600
  After patch:
  file permisions -> 0606

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12049

AFFECTED FILES
  part.cpp

To: chinmoyr, #okular, aacid
Cc: michaelweghorn, ngraham, aacid

D11725: [RFC] Show signature status as a popup

[Chinmoy Ranjan Pradhan]

chinmoyr edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11725

To: chinmoyr, #okular
Cc: michaelweghorn, ngraham, aacid

D11723: [RFC] Add FormFieldSignature to Okular's namespace

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D11725: [RFC] Show signature status as a 
popup.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11723

To: chinmoyr, #okular
Cc: michaelweghorn, ngraham, aacid

D11725: [RFC] Show signature status as a popup

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependency: D11723: [RFC] Add FormFieldSignature to Okular's 
namespace.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11725

To: chinmoyr, #okular
Cc: michaelweghorn, ngraham, aacid

D11725: [RFC] Show signature status as a popup

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: Okular.
Restricted Application added a project: Okular.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This is a PoC that makes use of the signature validation information 
generated in D11723  to show a message 
about signature status
  on top of Okular's viewing area.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11725

AFFECTED FILES
  generators/poppler/generator_pdf.cpp
  part.cpp

To: chinmoyr, #okular
Cc: michaelweghorn, ngraham, aacid

D11723: [RFC] Add FormFieldSignature to Okular's namespace

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: Okular.
Restricted Application added a project: Okular.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This patch adds the abstract class FormFieldSignature, implements it in 
poppler generator and modifies poppler generator to recognize signature 
  form field.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11723

AFFECTED FILES
  core/form.cpp
  core/form.h
  generators/poppler/formfields.cpp
  generators/poppler/formfields.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/generator_pdf.h

To: chinmoyr, #okular
Cc: michaelweghorn, ngraham, aacid