[Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- Review request for Okular and Albert Astals Cid. Bugs: 351156 http://bugs.kde.org/show_bug.cgi?id=351156 Repository: okular Description --- Create View/Trim View submenu to hold Trim Margins and add Trim To Selection Diffs - ui/pageview.h e65b57500d12ae2d8c5286e6542504e17813668c part-viewermode.rc bccd4912fcc11d9f091cbab2b056f3fbf5bf5cf7 ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 conf/okular.kcfg 332eafb7da83f778501ef63c4a607f7568ed7713 Diff: https://git.reviewboard.kde.org/r/124716/diff/ Testing --- # Changes C1. Added submenu, moved Trim margins (TM mode) to it and added Trim To Selection (TS mode). C2. Activating Trim To selection enters a new mousemode, similar to RectSelect for defining a viewport. C3. Once a viewport has been defined, it serves as a viewport for all pages in the document. C4. Left/Right pages are not treated differently. # Manual Testing T1. Switching between modes enforces at most one active. T2. Can deactivate a mode by selecting it again from the menu. T3. When draggin bbox selection, clicking outside page does not crash. T4. When in Facing Pages mode, mouse release must be over any page (or is ignored). T5. Normalized bbox coords are computed relative to page indicated by point of mouse release. T6. Behave as expected when switching between any pair of No Trim/Trim Margins/Trim To Selection. T7. TM mode persisted across app restarts (existing behavior). T8. TS mode forgotten across app restarts (as desired). T9. Exiting and reselectin Trim To Selection prompts for new bbox. T10. Choosing a small Trim bbox enforces minimium dimensions size (As percentag of total), as it does in TM mode, because of the scale big and crop down implementation, to avoid huge pixmaps. TS mode minimum set at 20% (vs. TM mode's 50%). # Pending Issues P1. [HOWFIX] Placing Actions in a submenu makes them invisible in Configure Shortcuts for some reason. This is a regression for Trim Margins and desirable configurability for both modes. P2. [HARMLESS] When in TM mode and switching to TS mode, the view jumps out of TM mode for the bbox selection interaction. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- (Updated Aug. 12, 2015, 3:11 p.m.) Review request for Okular and Albert Astals Cid. Changes --- Update Bugs, mention primary ticket in title Bugs: 166642, 340690, 350073, and 351156 http://bugs.kde.org/show_bug.cgi?id=166642 http://bugs.kde.org/show_bug.cgi?id=340690 http://bugs.kde.org/show_bug.cgi?id=350073 http://bugs.kde.org/show_bug.cgi?id=351156 Repository: okular Description (updated) --- Create View/Trim View submenu to hold Trim Margins and add Trim To Selection (351156) Diffs - ui/pageview.h e65b57500d12ae2d8c5286e6542504e17813668c part-viewermode.rc bccd4912fcc11d9f091cbab2b056f3fbf5bf5cf7 ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 conf/okular.kcfg 332eafb7da83f778501ef63c4a607f7568ed7713 Diff: https://git.reviewboard.kde.org/r/124716/diff/ Testing --- # Changes C1. Added submenu, moved Trim margins (TM mode) to it and added Trim To Selection (TS mode). C2. Activating Trim To selection enters a new mousemode, similar to RectSelect for defining a viewport. C3. Once a viewport has been defined, it serves as a viewport for all pages in the document. C4. Left/Right pages are not treated differently. # Manual Testing T1. Switching between modes enforces at most one active. T2. Can deactivate a mode by selecting it again from the menu. T3. When draggin bbox selection, clicking outside page does not crash. T4. When in Facing Pages mode, mouse release must be over any page (or is ignored). T5. Normalized bbox coords are computed relative to page indicated by point of mouse release. T6. Behave as expected when switching between any pair of No Trim/Trim Margins/Trim To Selection. T7. TM mode persisted across app restarts (existing behavior). T8. TS mode forgotten across app restarts (as desired). T9. Exiting and reselectin Trim To Selection prompts for new bbox. T10. Choosing a small Trim bbox enforces minimium dimensions size (As percentag of total), as it does in TM mode, because of the scale big and crop down implementation, to avoid huge pixmaps. TS mode minimum set at 20% (vs. TM mode's 50%). # Pending Issues P1. [HOWFIX] Placing Actions in a submenu makes them invisible in Configure Shortcuts for some reason. This is a regression for Trim Margins and desirable configurability for both modes. P2. [HARMLESS] When in TM mode and switching to TS mode, the view jumps out of TM mode for the bbox selection interaction. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 124723: Interact with hyperlinks in TextSelect mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124723/ --- Review request for Okular and Albert Astals Cid. Bugs: 318078 http://bugs.kde.org/show_bug.cgi?id=318078 Repository: okular Description --- Interact with hyperlinks in TextSelect mode Diffs - ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 Diff: https://git.reviewboard.kde.org/r/124723/diff/ Testing --- - cursor switches to to Hand when hovering over link in TextSelect mode. - clicking on hyperlink jumps to destination in TextSelect mode. - text selection copy still works. - can text-select over and across hyperlink. - can select starting at text and ending selection in middle of hyperlink. - can jump to link while there's an active selection. - can jump to link while there's an active selection spanning same hyperlink. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 318078] PDF-links don't work as expected in text selection mode.
https://bugs.kde.org/show_bug.cgi?id=318078 Jake Linder jakelin...@mail.com changed: What|Removed |Added CC||jakelin...@mail.com --- Comment #4 from Jake Linder jakelin...@mail.com --- Setting aside the irate users demanding their rights, I'm emberassed to admit I've fallen for this before too, and it took me months until I realized what the cause is---by mistake. I think this would be a good change from a UX pov, though of course the choice might have been due to reasons I'm unaware of. Still, if all that's been stopping this from happening was paucity of patch... https://git.reviewboard.kde.org/r/124723/ -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124723: Interact with hyperlinks in TextSelect mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124723/ --- (Updated Aug. 13, 2015, 1:03 a.m.) Review request for Okular and Albert Astals Cid. Bugs: 318078 http://bugs.kde.org/show_bug.cgi?id=318078 Repository: okular Description --- Interact with hyperlinks in TextSelect mode Diffs - ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 Diff: https://git.reviewboard.kde.org/r/124723/diff/ Testing (updated) --- - cursor switches to to Hand when hovering over link in TextSelect mode. - clicking on hyperlink jumps to destination in TextSelect mode. - text selection copy still works. - can text-select over and across hyperlink. - can text-select starting at text and ending selection in middle of hyperlink. - can text-select starting from hyperlink with click and drag. - can jump to link while there's an active selection. - can jump to link while there's an active selection spanning same hyperlink. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124723: Interact with hyperlinks in TextSelect mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124723/ --- (Updated Aug. 19, 2015, 2:28 a.m.) Review request for Okular and Albert Astals Cid. Changes --- Experiencing infrequent crashing (possibly) because of this. WIP until I can reliably repro and resolve Bugs: 318078 http://bugs.kde.org/show_bug.cgi?id=318078 Repository: okular Description (updated) --- Interact with hyperlinks in TextSelect mode (WIP) Diffs - ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 Diff: https://git.reviewboard.kde.org/r/124723/diff/ Testing --- - cursor switches to to Hand when hovering over link in TextSelect mode. - clicking on hyperlink jumps to destination in TextSelect mode. - text selection copy still works. - can text-select over and across hyperlink. - can text-select starting at text and ending selection in middle of hyperlink. - can text-select starting from hyperlink with click and drag. - can jump to link while there's an active selection. - can jump to link while there's an active selection spanning same hyperlink. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 351156] Add Trim page to selection feature
https://bugs.kde.org/show_bug.cgi?id=351156 --- Comment #14 from Jake Linder jakelin...@mail.com --- ping -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- (Updated Aug. 23, 2015, 6:37 p.m.) Review request for Okular and Albert Astals Cid. Changes --- PageView::updateItemSize can (surprisingly) be called before PageView::setupViewerActions() when Print Preview issued. NPE-proof the code. Bugs: 166642, 340690, 350073, and 351156 http://bugs.kde.org/show_bug.cgi?id=166642 http://bugs.kde.org/show_bug.cgi?id=340690 http://bugs.kde.org/show_bug.cgi?id=350073 http://bugs.kde.org/show_bug.cgi?id=351156 Repository: okular Description --- Create View/Trim View submenu to hold Trim Margins and add Trim To Selection (351156) Diffs (updated) - conf/okular.kcfg 332eafb7da83f778501ef63c4a607f7568ed7713 part-viewermode.rc bccd4912fcc11d9f091cbab2b056f3fbf5bf5cf7 part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 ui/pageview.h e65b57500d12ae2d8c5286e6542504e17813668c ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 Diff: https://git.reviewboard.kde.org/r/124716/diff/ Testing --- # Changes C1. Added submenu, moved Trim margins (TM mode) to it and added Trim To Selection (TS mode). C2. Activating Trim To selection enters a new mousemode, similar to RectSelect for defining a viewport. C3. Once a viewport has been defined, it serves as a viewport for all pages in the document. C4. Left/Right pages are not treated differently. # Manual Testing T1. Switching between modes enforces at most one active. T2. Can deactivate a mode by selecting it again from the menu. T3. When draggin bbox selection, clicking outside page does not crash. T4. When in Facing Pages mode, mouse release must be over any page (or is ignored). T5. Normalized bbox coords are computed relative to page indicated by point of mouse release. T6. Behave as expected when switching between any pair of No Trim/Trim Margins/Trim To Selection. T7. TM mode persisted across app restarts (existing behavior). T8. TS mode forgotten across app restarts (as desired). T9. Exiting and reselectin Trim To Selection prompts for new bbox. T10. Choosing a small Trim bbox enforces minimium dimensions size (As percentag of total), as it does in TM mode, because of the scale big and crop down implementation, to avoid huge pixmaps. TS mode minimum set at 20% (vs. TM mode's 50%). # Pending Issues P2. [HARMLESS] When in TM mode and switching to TS mode, the view jumps out of TM mode for the bbox selection interaction. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- (Updated Aug. 21, 2015, 5:10 a.m.) Review request for Okular and Albert Astals Cid. Changes --- Handle toggle TrimSelection mode off during selection. Possible now that kb shortcuts work Bugs: 166642, 340690, 350073, and 351156 http://bugs.kde.org/show_bug.cgi?id=166642 http://bugs.kde.org/show_bug.cgi?id=340690 http://bugs.kde.org/show_bug.cgi?id=350073 http://bugs.kde.org/show_bug.cgi?id=351156 Repository: okular Description --- Create View/Trim View submenu to hold Trim Margins and add Trim To Selection (351156) Diffs (updated) - conf/okular.kcfg 332eafb7da83f778501ef63c4a607f7568ed7713 part-viewermode.rc bccd4912fcc11d9f091cbab2b056f3fbf5bf5cf7 part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 ui/pageview.h e65b57500d12ae2d8c5286e6542504e17813668c ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 Diff: https://git.reviewboard.kde.org/r/124716/diff/ Testing --- # Changes C1. Added submenu, moved Trim margins (TM mode) to it and added Trim To Selection (TS mode). C2. Activating Trim To selection enters a new mousemode, similar to RectSelect for defining a viewport. C3. Once a viewport has been defined, it serves as a viewport for all pages in the document. C4. Left/Right pages are not treated differently. # Manual Testing T1. Switching between modes enforces at most one active. T2. Can deactivate a mode by selecting it again from the menu. T3. When draggin bbox selection, clicking outside page does not crash. T4. When in Facing Pages mode, mouse release must be over any page (or is ignored). T5. Normalized bbox coords are computed relative to page indicated by point of mouse release. T6. Behave as expected when switching between any pair of No Trim/Trim Margins/Trim To Selection. T7. TM mode persisted across app restarts (existing behavior). T8. TS mode forgotten across app restarts (as desired). T9. Exiting and reselectin Trim To Selection prompts for new bbox. T10. Choosing a small Trim bbox enforces minimium dimensions size (As percentag of total), as it does in TM mode, because of the scale big and crop down implementation, to avoid huge pixmaps. TS mode minimum set at 20% (vs. TM mode's 50%). # Pending Issues P2. [HARMLESS] When in TM mode and switching to TS mode, the view jumps out of TM mode for the bbox selection interaction. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124723: Interact with hyperlinks in TextSelect mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124723/ --- (Updated Aug. 21, 2015, 12:44 a.m.) Review request for Okular and Albert Astals Cid. Changes --- Fix for crashes: switching away and back then clicking within the app window but off the page area resulted in NPE. Bugs: 318078 http://bugs.kde.org/show_bug.cgi?id=318078 Repository: okular Description (updated) --- Interact with hyperlinks in TextSelect mode Diffs (updated) - ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 Diff: https://git.reviewboard.kde.org/r/124723/diff/ Testing --- - cursor switches to to Hand when hovering over link in TextSelect mode. - clicking on hyperlink jumps to destination in TextSelect mode. - text selection copy still works. - can text-select over and across hyperlink. - can text-select starting at text and ending selection in middle of hyperlink. - can text-select starting from hyperlink with click and drag. - can jump to link while there's an active selection. - can jump to link while there's an active selection spanning same hyperlink. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- (Updated Aug. 21, 2015, 3:11 a.m.) Review request for Okular and Albert Astals Cid. Changes --- Fixed pending issue, can edit shortcuts for trim actions again Bugs: 166642, 340690, 350073, and 351156 http://bugs.kde.org/show_bug.cgi?id=166642 http://bugs.kde.org/show_bug.cgi?id=340690 http://bugs.kde.org/show_bug.cgi?id=350073 http://bugs.kde.org/show_bug.cgi?id=351156 Repository: okular Description --- Create View/Trim View submenu to hold Trim Margins and add Trim To Selection (351156) Diffs (updated) - ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 conf/okular.kcfg 332eafb7da83f778501ef63c4a607f7568ed7713 ui/pageview.h e65b57500d12ae2d8c5286e6542504e17813668c part-viewermode.rc bccd4912fcc11d9f091cbab2b056f3fbf5bf5cf7 Diff: https://git.reviewboard.kde.org/r/124716/diff/ Testing (updated) --- # Changes C1. Added submenu, moved Trim margins (TM mode) to it and added Trim To Selection (TS mode). C2. Activating Trim To selection enters a new mousemode, similar to RectSelect for defining a viewport. C3. Once a viewport has been defined, it serves as a viewport for all pages in the document. C4. Left/Right pages are not treated differently. # Manual Testing T1. Switching between modes enforces at most one active. T2. Can deactivate a mode by selecting it again from the menu. T3. When draggin bbox selection, clicking outside page does not crash. T4. When in Facing Pages mode, mouse release must be over any page (or is ignored). T5. Normalized bbox coords are computed relative to page indicated by point of mouse release. T6. Behave as expected when switching between any pair of No Trim/Trim Margins/Trim To Selection. T7. TM mode persisted across app restarts (existing behavior). T8. TS mode forgotten across app restarts (as desired). T9. Exiting and reselectin Trim To Selection prompts for new bbox. T10. Choosing a small Trim bbox enforces minimium dimensions size (As percentag of total), as it does in TM mode, because of the scale big and crop down implementation, to avoid huge pixmaps. TS mode minimum set at 20% (vs. TM mode's 50%). # Pending Issues P2. [HARMLESS] When in TM mode and switching to TS mode, the view jumps out of TM mode for the bbox selection interaction. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124723: Interact with hyperlinks in TextSelect mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124723/ --- (Updated Aug. 13, 2015, 11:36 p.m.) Review request for Okular and Albert Astals Cid. Changes --- Refactor click hyperlink logic out of main switch Bugs: 318078 http://bugs.kde.org/show_bug.cgi?id=318078 Repository: okular Description --- Interact with hyperlinks in TextSelect mode Diffs (updated) - ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 Diff: https://git.reviewboard.kde.org/r/124723/diff/ Testing --- - cursor switches to to Hand when hovering over link in TextSelect mode. - clicking on hyperlink jumps to destination in TextSelect mode. - text selection copy still works. - can text-select over and across hyperlink. - can text-select starting at text and ending selection in middle of hyperlink. - can text-select starting from hyperlink with click and drag. - can jump to link while there's an active selection. - can jump to link while there's an active selection spanning same hyperlink. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124723: Interact with hyperlinks in TextSelect mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124723/ --- (Updated Aug. 13, 2015, 11:08 p.m.) Review request for Okular and Albert Astals Cid. Changes --- Add right-click menu to match Browse mode. Significant code duplication here (change right menu in one place, other is not affected), unless cases are merged and code is sprinkled with multiple conditionals instead. Bugs: 318078 http://bugs.kde.org/show_bug.cgi?id=318078 Repository: okular Description --- Interact with hyperlinks in TextSelect mode Diffs (updated) - ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 Diff: https://git.reviewboard.kde.org/r/124723/diff/ Testing --- - cursor switches to to Hand when hovering over link in TextSelect mode. - clicking on hyperlink jumps to destination in TextSelect mode. - text selection copy still works. - can text-select over and across hyperlink. - can text-select starting at text and ending selection in middle of hyperlink. - can text-select starting from hyperlink with click and drag. - can jump to link while there's an active selection. - can jump to link while there's an active selection spanning same hyperlink. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- (Updated Aug. 13, 2015, 3:58 p.m.) Review request for Okular and Albert Astals Cid. Changes --- Use existing absToPageX/Y() for coord calculations Bugs: 166642, 340690, 350073, and 351156 http://bugs.kde.org/show_bug.cgi?id=166642 http://bugs.kde.org/show_bug.cgi?id=340690 http://bugs.kde.org/show_bug.cgi?id=350073 http://bugs.kde.org/show_bug.cgi?id=351156 Repository: okular Description --- Create View/Trim View submenu to hold Trim Margins and add Trim To Selection (351156) Diffs (updated) - conf/okular.kcfg 332eafb7da83f778501ef63c4a607f7568ed7713 part-viewermode.rc bccd4912fcc11d9f091cbab2b056f3fbf5bf5cf7 part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 ui/pageview.h e65b57500d12ae2d8c5286e6542504e17813668c ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 Diff: https://git.reviewboard.kde.org/r/124716/diff/ Testing --- # Changes C1. Added submenu, moved Trim margins (TM mode) to it and added Trim To Selection (TS mode). C2. Activating Trim To selection enters a new mousemode, similar to RectSelect for defining a viewport. C3. Once a viewport has been defined, it serves as a viewport for all pages in the document. C4. Left/Right pages are not treated differently. # Manual Testing T1. Switching between modes enforces at most one active. T2. Can deactivate a mode by selecting it again from the menu. T3. When draggin bbox selection, clicking outside page does not crash. T4. When in Facing Pages mode, mouse release must be over any page (or is ignored). T5. Normalized bbox coords are computed relative to page indicated by point of mouse release. T6. Behave as expected when switching between any pair of No Trim/Trim Margins/Trim To Selection. T7. TM mode persisted across app restarts (existing behavior). T8. TS mode forgotten across app restarts (as desired). T9. Exiting and reselectin Trim To Selection prompts for new bbox. T10. Choosing a small Trim bbox enforces minimium dimensions size (As percentag of total), as it does in TM mode, because of the scale big and crop down implementation, to avoid huge pixmaps. TS mode minimum set at 20% (vs. TM mode's 50%). # Pending Issues P1. [HOWFIX] Placing Actions in a submenu makes them invisible in Configure Shortcuts for some reason. This is a regression for Trim Margins and desirable configurability for both modes. P2. [HARMLESS] When in TM mode and switching to TS mode, the view jumps out of TM mode for the bbox selection interaction. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- (Updated Aug. 27, 2015, 8:10 p.m.) Status -- This change has been marked as submitted. Review request for Okular and Albert Astals Cid. Changes --- Submitted with commit 172d78c6b3f9d7894a1233fb12e5e292f13710ee by Albert Astals Cid on behalf of Jake Linder to branch master. Bugs: 166642, 340690, 350073, and 351156 http://bugs.kde.org/show_bug.cgi?id=166642 http://bugs.kde.org/show_bug.cgi?id=340690 http://bugs.kde.org/show_bug.cgi?id=350073 http://bugs.kde.org/show_bug.cgi?id=351156 Repository: okular Description --- Create View/Trim View submenu to hold Trim Margins and add Trim To Selection (351156) Diffs - conf/okular.kcfg 332eafb7da83f778501ef63c4a607f7568ed7713 part-viewermode.rc bccd4912fcc11d9f091cbab2b056f3fbf5bf5cf7 part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 ui/pageview.h e65b57500d12ae2d8c5286e6542504e17813668c ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 Diff: https://git.reviewboard.kde.org/r/124716/diff/ Testing --- # Changes C1. Added submenu, moved Trim margins (TM mode) to it and added Trim To Selection (TS mode). C2. Activating Trim To selection enters a new mousemode, similar to RectSelect for defining a viewport. C3. Once a viewport has been defined, it serves as a viewport for all pages in the document. C4. Left/Right pages are not treated differently. # Manual Testing T1. Switching between modes enforces at most one active. T2. Can deactivate a mode by selecting it again from the menu. T3. When draggin bbox selection, clicking outside page does not crash. T4. When in Facing Pages mode, mouse release must be over any page (or is ignored). T5. Normalized bbox coords are computed relative to page indicated by point of mouse release. T6. Behave as expected when switching between any pair of No Trim/Trim Margins/Trim To Selection. T7. TM mode persisted across app restarts (existing behavior). T8. TS mode forgotten across app restarts (as desired). T9. Exiting and reselectin Trim To Selection prompts for new bbox. T10. Choosing a small Trim bbox enforces minimium dimensions size (As percentag of total), as it does in TM mode, because of the scale big and crop down implementation, to avoid huge pixmaps. TS mode minimum set at 20% (vs. TM mode's 50%). # Pending Issues P2. [HARMLESS] When in TM mode and switching to TS mode, the view jumps out of TM mode for the bbox selection interaction. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 318078] PDF-links don't work as expected in text selection mode.
https://bugs.kde.org/show_bug.cgi?id=318078 --- Comment #7 from Jake Linder jakelin...@mail.com --- Rebased against master: https://git.reviewboard.kde.org/r/124961/ -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection
On Aug. 27, 2015, 8:10 p.m., Albert Astals Cid wrote: Ship It! \o/ - Jake --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/#review84488 --- On Aug. 27, 2015, 8:10 p.m., Jake Linder wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- (Updated Aug. 27, 2015, 8:10 p.m.) Review request for Okular and Albert Astals Cid. Bugs: 166642, 340690, 350073, and 351156 http://bugs.kde.org/show_bug.cgi?id=166642 http://bugs.kde.org/show_bug.cgi?id=340690 http://bugs.kde.org/show_bug.cgi?id=350073 http://bugs.kde.org/show_bug.cgi?id=351156 Repository: okular Description --- Create View/Trim View submenu to hold Trim Margins and add Trim To Selection (351156) Diffs - conf/okular.kcfg 332eafb7da83f778501ef63c4a607f7568ed7713 part-viewermode.rc bccd4912fcc11d9f091cbab2b056f3fbf5bf5cf7 part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 ui/pageview.h e65b57500d12ae2d8c5286e6542504e17813668c ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 Diff: https://git.reviewboard.kde.org/r/124716/diff/ Testing --- # Changes C1. Added submenu, moved Trim margins (TM mode) to it and added Trim To Selection (TS mode). C2. Activating Trim To selection enters a new mousemode, similar to RectSelect for defining a viewport. C3. Once a viewport has been defined, it serves as a viewport for all pages in the document. C4. Left/Right pages are not treated differently. # Manual Testing T1. Switching between modes enforces at most one active. T2. Can deactivate a mode by selecting it again from the menu. T3. When draggin bbox selection, clicking outside page does not crash. T4. When in Facing Pages mode, mouse release must be over any page (or is ignored). T5. Normalized bbox coords are computed relative to page indicated by point of mouse release. T6. Behave as expected when switching between any pair of No Trim/Trim Margins/Trim To Selection. T7. TM mode persisted across app restarts (existing behavior). T8. TS mode forgotten across app restarts (as desired). T9. Exiting and reselectin Trim To Selection prompts for new bbox. T10. Choosing a small Trim bbox enforces minimium dimensions size (As percentag of total), as it does in TM mode, because of the scale big and crop down implementation, to avoid huge pixmaps. TS mode minimum set at 20% (vs. TM mode's 50%). # Pending Issues P2. [HARMLESS] When in TM mode and switching to TS mode, the view jumps out of TM mode for the bbox selection interaction. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection
On Aug. 26, 2015, 9:50 p.m., Albert Astals Cid wrote: ui/pageview.cpp, line 494 https://git.reviewboard.kde.org/r/124716/diff/5/?file=397617#file397617line494 Why this? I think it's the default, no? Jake Linder wrote: Dev leftover. Added back. err, eliminated that is. - Jake --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/#review84427 --- On Aug. 27, 2015, 8:10 p.m., Jake Linder wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- (Updated Aug. 27, 2015, 8:10 p.m.) Review request for Okular and Albert Astals Cid. Bugs: 166642, 340690, 350073, and 351156 http://bugs.kde.org/show_bug.cgi?id=166642 http://bugs.kde.org/show_bug.cgi?id=340690 http://bugs.kde.org/show_bug.cgi?id=350073 http://bugs.kde.org/show_bug.cgi?id=351156 Repository: okular Description --- Create View/Trim View submenu to hold Trim Margins and add Trim To Selection (351156) Diffs - conf/okular.kcfg 332eafb7da83f778501ef63c4a607f7568ed7713 part-viewermode.rc bccd4912fcc11d9f091cbab2b056f3fbf5bf5cf7 part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 ui/pageview.h e65b57500d12ae2d8c5286e6542504e17813668c ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 Diff: https://git.reviewboard.kde.org/r/124716/diff/ Testing --- # Changes C1. Added submenu, moved Trim margins (TM mode) to it and added Trim To Selection (TS mode). C2. Activating Trim To selection enters a new mousemode, similar to RectSelect for defining a viewport. C3. Once a viewport has been defined, it serves as a viewport for all pages in the document. C4. Left/Right pages are not treated differently. # Manual Testing T1. Switching between modes enforces at most one active. T2. Can deactivate a mode by selecting it again from the menu. T3. When draggin bbox selection, clicking outside page does not crash. T4. When in Facing Pages mode, mouse release must be over any page (or is ignored). T5. Normalized bbox coords are computed relative to page indicated by point of mouse release. T6. Behave as expected when switching between any pair of No Trim/Trim Margins/Trim To Selection. T7. TM mode persisted across app restarts (existing behavior). T8. TS mode forgotten across app restarts (as desired). T9. Exiting and reselectin Trim To Selection prompts for new bbox. T10. Choosing a small Trim bbox enforces minimium dimensions size (As percentag of total), as it does in TM mode, because of the scale big and crop down implementation, to avoid huge pixmaps. TS mode minimum set at 20% (vs. TM mode's 50%). # Pending Issues P2. [HARMLESS] When in TM mode and switching to TS mode, the view jumps out of TM mode for the bbox selection interaction. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124723: Interact with hyperlinks in TextSelect mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124723/ --- (Updated Aug. 28, 2015, 6:54 a.m.) Status -- This change has been discarded. Review request for Okular and Albert Astals Cid. Bugs: 318078 http://bugs.kde.org/show_bug.cgi?id=318078 Repository: okular Description --- Interact with hyperlinks in TextSelect mode Diffs - ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 Diff: https://git.reviewboard.kde.org/r/124723/diff/ Testing --- - cursor switches to to Hand when hovering over link in TextSelect mode. - clicking on hyperlink jumps to destination in TextSelect mode. - text selection copy still works. - can text-select over and across hyperlink. - can text-select starting at text and ending selection in middle of hyperlink. - can text-select starting from hyperlink with click and drag. - can jump to link while there's an active selection. - can jump to link while there's an active selection spanning same hyperlink. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124961/ --- Review request for Okular and Albert Astals Cid. Bugs: 318078 http://bugs.kde.org/show_bug.cgi?id=318078 Repository: okular Description --- Supercedes https://git.reviewboard.kde.org/r/124723/: - Rebase to apply cleanly against just-merged 172d78c (Trim Selection Feature) - Drop the refactoring patch (seperate problem), sticking with the code duplication for now. - Added seperate patch (post changes) fixing whitespace issue in gargantuan switch statement. Take it or leave it. Diffs - ui/pageview.cpp dc9eab8301b05e57bfdd537d47b33da594759573 Diff: https://git.reviewboard.kde.org/r/124961/diff/ Testing --- - cursor switches to to Hand when hovering over link in TextSelect mode. - clicking on hyperlink jumps to destination in TextSelect mode. - text selection copy still works. - can text-select over and across hyperlink. - can text-select starting at text and ending selection in middle of hyperlink. - can text-select starting from hyperlink with click and drag. - can jump to link while there's an active selection. - can jump to link while there's an active selection spanning same hyperlink. - doesn't crash when switching away from window and back + clicking off page - when textselect overlaps a link, r-click on the link gives the follow this link content menu, r-click off link gives the Copy Text/etc' context menu - text selection works whe selecting left to right or right to left (begin/end selection work out no matter in what order user provides them) Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124965: Remove help message ref to missing 'Show Forms' menu item
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124965/ --- (Updated Aug. 28, 2015, 10:12 a.m.) Status -- This change has been discarded. Review request for Okular and Albert Astals Cid. Repository: okular Description --- Remove help message ref to missing 'Show Forms' menu item Diffs - part.cpp d461ebefe9533eefdcf918eb153826479e034476 Diff: https://git.reviewboard.kde.org/r/124965/diff/ Testing --- Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124965: Remove help message ref to missing 'Show Forms' menu item
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124965/ --- (Updated Aug. 28, 2015, 9:31 a.m.) Review request for Okular and Albert Astals Cid. Summary (updated) - Remove help message ref to missing 'Show Forms' menu item Repository: okular Description --- Remove help message ref to missing 'Show Forms' menu item Diffs - part.cpp d461ebefe9533eefdcf918eb153826479e034476 Diff: https://git.reviewboard.kde.org/r/124965/diff/ Testing --- Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 124965: Remove help message refto missing 'Show Forms' menu item
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124965/ --- Review request for Okular and Albert Astals Cid. Repository: okular Description --- Remove help message ref to missing 'Show Forms' menu item Diffs - part.cpp d461ebefe9533eefdcf918eb153826479e034476 Diff: https://git.reviewboard.kde.org/r/124965/diff/ Testing --- Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 124964: Ensure pixmap of proper resolution used when switching viewmode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124964/ --- Review request for Okular and Albert Astals Cid. Bugs: 351889 http://bugs.kde.org/show_bug.cgi?id=351889 Repository: okular Description --- Ensure pixmap of proper resolution used when switching viewmode Diffs - ui/pageview.cpp dc9eab8301b05e57bfdd537d47b33da594759573 Diff: https://git.reviewboard.kde.org/r/124964/diff/ Testing --- Steps to repro: 1) resize app window to be narrow enough so that in facing pages viewmode page dimensions are reduced. 2) switch to facing pages mode. 3) switch back to single page mode. Expected Result: Single page is shown at proper resolution Actual Result: Single page is displayed with proper dimensions but is actually a scaled-up version of a lower resolution pixmap. I've verified that this fixes the issue. Note that adding this line after slotRelayoutPages() is sprinkled all over pageview.cpp, always affixed with a we may not need to do this - Code Smell. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 351889] Switching to facing-pages and back to single-page viewmode results in low-res page render
https://bugs.kde.org/show_bug.cgi?id=351889 --- Comment #1 from Jake Linder jakelin...@mail.com --- https://git.reviewboard.kde.org/r/124964/ -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 351889] Switching to facing-pages and back to single-page viewmode results in low-res page render
https://bugs.kde.org/show_bug.cgi?id=351889 --- Comment #2 from Jake Linder jakelin...@mail.com --- Note Bucgtracker Doesn't allow specifying version 0.22.2 though git is at 0.23.60 -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 318078] PDF-links don't work as expected in text selection mode.
https://bugs.kde.org/show_bug.cgi?id=318078 --- Comment #9 from Jake Linder jakelin...@mail.com --- Well, how does review board handle history rewrites? I assumed it wouldn't like it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- (Updated Aug. 27, 2015, 6:13 a.m.) Review request for Okular and Albert Astals Cid. Changes --- Address comments and fix equality typo/bug Bugs: 166642, 340690, 350073, and 351156 http://bugs.kde.org/show_bug.cgi?id=166642 http://bugs.kde.org/show_bug.cgi?id=340690 http://bugs.kde.org/show_bug.cgi?id=350073 http://bugs.kde.org/show_bug.cgi?id=351156 Repository: okular Description --- Create View/Trim View submenu to hold Trim Margins and add Trim To Selection (351156) Diffs (updated) - conf/okular.kcfg 332eafb7da83f778501ef63c4a607f7568ed7713 part-viewermode.rc bccd4912fcc11d9f091cbab2b056f3fbf5bf5cf7 part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 ui/pageview.h e65b57500d12ae2d8c5286e6542504e17813668c ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 Diff: https://git.reviewboard.kde.org/r/124716/diff/ Testing --- # Changes C1. Added submenu, moved Trim margins (TM mode) to it and added Trim To Selection (TS mode). C2. Activating Trim To selection enters a new mousemode, similar to RectSelect for defining a viewport. C3. Once a viewport has been defined, it serves as a viewport for all pages in the document. C4. Left/Right pages are not treated differently. # Manual Testing T1. Switching between modes enforces at most one active. T2. Can deactivate a mode by selecting it again from the menu. T3. When draggin bbox selection, clicking outside page does not crash. T4. When in Facing Pages mode, mouse release must be over any page (or is ignored). T5. Normalized bbox coords are computed relative to page indicated by point of mouse release. T6. Behave as expected when switching between any pair of No Trim/Trim Margins/Trim To Selection. T7. TM mode persisted across app restarts (existing behavior). T8. TS mode forgotten across app restarts (as desired). T9. Exiting and reselectin Trim To Selection prompts for new bbox. T10. Choosing a small Trim bbox enforces minimium dimensions size (As percentag of total), as it does in TM mode, because of the scale big and crop down implementation, to avoid huge pixmaps. TS mode minimum set at 20% (vs. TM mode's 50%). # Pending Issues P2. [HARMLESS] When in TM mode and switching to TS mode, the view jumps out of TM mode for the bbox selection interaction. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection
On Aug. 26, 2015, 9:50 p.m., Albert Astals Cid wrote: Code Looks reasonable (haven't tried yet live) Good. I use it daily and fixed up a few issues I came across, but It's been fairly solid. Thanks for the review. On Aug. 26, 2015, 9:50 p.m., Albert Astals Cid wrote: part-viewermode.rc, line 37 https://git.reviewboard.kde.org/r/124716/diff/5/?file=397614#file397614line37 why remove the group? Lost during experimentation. Added back. On Aug. 26, 2015, 9:50 p.m., Albert Astals Cid wrote: ui/pageview.cpp, line 494 https://git.reviewboard.kde.org/r/124716/diff/5/?file=397617#file397617line494 Why this? I think it's the default, no? Dev leftover. Added back. - Jake --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/#review84427 --- On Aug. 27, 2015, 6:13 a.m., Jake Linder wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- (Updated Aug. 27, 2015, 6:13 a.m.) Review request for Okular and Albert Astals Cid. Bugs: 166642, 340690, 350073, and 351156 http://bugs.kde.org/show_bug.cgi?id=166642 http://bugs.kde.org/show_bug.cgi?id=340690 http://bugs.kde.org/show_bug.cgi?id=350073 http://bugs.kde.org/show_bug.cgi?id=351156 Repository: okular Description --- Create View/Trim View submenu to hold Trim Margins and add Trim To Selection (351156) Diffs - conf/okular.kcfg 332eafb7da83f778501ef63c4a607f7568ed7713 part-viewermode.rc bccd4912fcc11d9f091cbab2b056f3fbf5bf5cf7 part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 ui/pageview.h e65b57500d12ae2d8c5286e6542504e17813668c ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 Diff: https://git.reviewboard.kde.org/r/124716/diff/ Testing --- # Changes C1. Added submenu, moved Trim margins (TM mode) to it and added Trim To Selection (TS mode). C2. Activating Trim To selection enters a new mousemode, similar to RectSelect for defining a viewport. C3. Once a viewport has been defined, it serves as a viewport for all pages in the document. C4. Left/Right pages are not treated differently. # Manual Testing T1. Switching between modes enforces at most one active. T2. Can deactivate a mode by selecting it again from the menu. T3. When draggin bbox selection, clicking outside page does not crash. T4. When in Facing Pages mode, mouse release must be over any page (or is ignored). T5. Normalized bbox coords are computed relative to page indicated by point of mouse release. T6. Behave as expected when switching between any pair of No Trim/Trim Margins/Trim To Selection. T7. TM mode persisted across app restarts (existing behavior). T8. TS mode forgotten across app restarts (as desired). T9. Exiting and reselectin Trim To Selection prompts for new bbox. T10. Choosing a small Trim bbox enforces minimium dimensions size (As percentag of total), as it does in TM mode, because of the scale big and crop down implementation, to avoid huge pixmaps. TS mode minimum set at 20% (vs. TM mode's 50%). # Pending Issues P2. [HARMLESS] When in TM mode and switching to TS mode, the view jumps out of TM mode for the bbox selection interaction. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124964: Ensure pixmap of proper resolution used when switching viewmode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124964/ --- (Updated Sept. 1, 2015, 7:12 a.m.) Review request for Okular and Albert Astals Cid. Bugs: 351889 http://bugs.kde.org/show_bug.cgi?id=351889 Repository: okular Description (updated) --- Ensure pixmap of proper resolution used when switching viewmode / rotating view Diffs (updated) - CMakeLists.txt 27a88ddfec18d9259e669eb2ab7b60ef03e2af75 conf/okular.kcfg 332eafb7da83f778501ef63c4a607f7568ed7713 core/document.cpp 85fe007866e77bc99ac0746a6c53b5c92ab73f67 part-viewermode.rc bccd4912fcc11d9f091cbab2b056f3fbf5bf5cf7 part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 ui/pageview.h e65b57500d12ae2d8c5286e6542504e17813668c ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 Diff: https://git.reviewboard.kde.org/r/124964/diff/ Testing (updated) --- Steps to repro (viewmode): 1) resize app window to be narrow enough so that in facing pages viewmode page dimensions are reduced. 2) switch to facing pages mode. 3) switch back to single page mode. Steps to repro (rotation): 1) open a pdf with protrait mode paper dimensions. 2) rotate the view clockwise. 3) rotate the view back to original orientation. Expected Result: Single page is shown at proper resolution Actual Result: Single page is displayed with proper dimensions but is actually a scaled-up version of a lower resolution pixmap. I've verified that this fixes the issue. Note that adding this line after slotRelayoutPages() is sprinkled all over pageview.cpp, always affixed with a "we may not need to do this" - Code Smell. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124964: Ensure pixmap of proper resolution used when switching viewmode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124964/ --- (Updated Sept. 1, 2015, 7:07 a.m.) Review request for Okular and Albert Astals Cid. Changes --- Fix similar bug occuring after rotating view Bugs: 351889 http://bugs.kde.org/show_bug.cgi?id=351889 Repository: okular Description --- Ensure pixmap of proper resolution used when switching viewmode Diffs (updated) - CMakeLists.txt 27a88ddfec18d9259e669eb2ab7b60ef03e2af75 conf/okular.kcfg 332eafb7da83f778501ef63c4a607f7568ed7713 core/document.cpp 85fe007866e77bc99ac0746a6c53b5c92ab73f67 part-viewermode.rc bccd4912fcc11d9f091cbab2b056f3fbf5bf5cf7 part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 ui/pageview.h e65b57500d12ae2d8c5286e6542504e17813668c ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 Diff: https://git.reviewboard.kde.org/r/124964/diff/ Testing --- Steps to repro: 1) resize app window to be narrow enough so that in facing pages viewmode page dimensions are reduced. 2) switch to facing pages mode. 3) switch back to single page mode. Expected Result: Single page is shown at proper resolution Actual Result: Single page is displayed with proper dimensions but is actually a scaled-up version of a lower resolution pixmap. I've verified that this fixes the issue. Note that adding this line after slotRelayoutPages() is sprinkled all over pageview.cpp, always affixed with a "we may not need to do this" - Code Smell. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 351889] Switching viewmode/Rotating view can result in low-res page render
https://bugs.kde.org/show_bug.cgi?id=351889 Jake Linder <jakelin...@mail.com> changed: What|Removed |Added Summary|Switching to facing-pages |Switching viewmode/Rotating |and back to single-page |view can result in low-res |viewmode results in low-res |page render |page render | -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 351889] Switching viewmode/Rotating view can result in low-res page render
https://bugs.kde.org/show_bug.cgi?id=351889 --- Comment #3 from Jake Linder <jakelin...@mail.com> --- Updated title and review, same problem occurs when rotating view and rotating back -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 318078] PDF-links don't work as expected in text selection mode.
https://bugs.kde.org/show_bug.cgi?id=318078 --- Comment #5 from Jake Linder jakelin...@mail.com --- Albert, any thoughts about changing the behavior as suggested? If you're against, it'd be helpful to get your take on the merits of the current behavior because it's probably safe to say that it's confusing to many users (me included), while the patch fixes the problem without disrupting (afaict) usage for users who don't have a problem. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)
> On Sept. 14, 2015, 10:44 p.m., Albert Astals Cid wrote: > > This is cool, it touches a bit of a critical code so i'm giving it some > > more review, thanks for the patch :) That big switch is difficult to manage, so careful review is welcome. fwiw, I've been using it without issues since posted. - Jake --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124961/#review85406 --- On Aug. 28, 2015, 7:05 a.m., Jake Linder wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124961/ > --- > > (Updated Aug. 28, 2015, 7:05 a.m.) > > > Review request for Okular and Albert Astals Cid. > > > Bugs: 318078 > http://bugs.kde.org/show_bug.cgi?id=318078 > > > Repository: okular > > > Description > --- > > Supercedes https://git.reviewboard.kde.org/r/124723/: > > - Rebase to apply cleanly against just-merged 172d78c (Trim Selection Feature) > - Drop the refactoring patch (seperate problem), sticking with the code > duplication for now. > - Added seperate patch (post changes) fixing whitespace issue in gargantuan > switch statement. Take it or leave it. > > > Diffs > - > > ui/pageview.cpp dc9eab8301b05e57bfdd537d47b33da594759573 > > Diff: https://git.reviewboard.kde.org/r/124961/diff/ > > > Testing > --- > > - cursor switches to to Hand when hovering over link in TextSelect mode. > - clicking on hyperlink jumps to destination in TextSelect mode. > - text selection & copy still works. > - can text-select "over and across" hyperlink. > - can text-select starting at text and ending selection in middle of > hyperlink. > - can text-select starting from hyperlink with click and drag. > - can jump to link while there's an active selection. > - can jump to link while there's an active selection spanning same hyperlink. > - doesn't crash when switching away from window and back + clicking off page > - when textselect overlaps a link, r-click on the link gives the "follow this > link" content menu, r-click off link gives the "Copy Text"/etc' context menu > - text selection works whe selecting left to right or right to left > (begin/end selection work out no matter in what order user provides them) > > > Thanks, > > Jake Linder > > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124964: Ensure pixmap of proper resolution used when switching viewmode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124964/ --- (Updated Sept. 15, 2015, 5:31 a.m.) Review request for Okular and Albert Astals Cid. Changes --- Rebase Bugs: 351889 http://bugs.kde.org/show_bug.cgi?id=351889 Repository: okular Description --- Ensure pixmap of proper resolution used when switching viewmode / rotating view Diffs (updated) - ui/pageview.cpp dc9eab8301b05e57bfdd537d47b33da594759573 Diff: https://git.reviewboard.kde.org/r/124964/diff/ Testing --- Steps to repro (viewmode): 1) resize app window to be narrow enough so that in facing pages viewmode page dimensions are reduced. 2) switch to facing pages mode. 3) switch back to single page mode. Steps to repro (rotation): 1) open a pdf with protrait mode paper dimensions. 2) rotate the view clockwise. 3) rotate the view back to original orientation. Expected Result: Single page is shown at proper resolution Actual Result: Single page is displayed with proper dimensions but is actually a scaled-up version of a lower resolution pixmap. I've verified that this fixes the issue. Note that adding this line after slotRelayoutPages() is sprinkled all over pageview.cpp, always affixed with a "we may not need to do this" - Code Smell. Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124961/ --- (Updated Sept. 15, 2015, 5:41 a.m.) Review request for Okular and Albert Astals Cid. Changes --- typos Bugs: 318078 http://bugs.kde.org/show_bug.cgi?id=318078 Repository: okular Description --- Supercedes https://git.reviewboard.kde.org/r/124723/: - Rebase to apply cleanly against just-merged 172d78c (Trim Selection Feature) - Drop the refactoring patch (seperate problem), sticking with the code duplication for now. - Added seperate patch (post changes) fixing whitespace issue in gargantuan switch statement. Take it or leave it. Diffs - ui/pageview.cpp dc9eab8301b05e57bfdd537d47b33da594759573 Diff: https://git.reviewboard.kde.org/r/124961/diff/ Testing (updated) --- - cursor switches to Hand when hovering over link in TextSelect mode. - clicking on hyperlink jumps to destination in TextSelect mode. - text selection & copy still works. - can text-select "over and across" hyperlink. - can text-select starting at text and ending selection in middle of hyperlink. - can text-select starting from hyperlink with click and drag. - can jump to link while there's an active selection of text. - can jump to link while there's an active selection spanning a hyperlink. - doesn't crash when switching away from window and back + clicking off page - when textselect overlaps a link, r-click on the link gives the "follow this link" content menu, r-click off link gives the "Copy Text"/etc' context menu - text selection works when selecting left to right or right to left (begin/end selection works out no matter in what order user provides them) Thanks, Jake Linder ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 318078] PDF-links don't work as expected in text selection mode.
https://bugs.kde.org/show_bug.cgi?id=318078 --- Comment #10 from Jake Linder <jakelin...@mail.com> --- Gentle reminder, Albert. I've been using a patched version daily for over a month now with no issues. Of course, there may be bugs, but If so they're probably subtle and will surface only when more users switch to it. I'm not sure what the release sched is but since your reviewboard comments have been positive,can we make sure this makes it in to the next release? Users have been asking for this change for at least two years. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 186531] [JJ] Trim Margin doesn't work if paper color was set
https://bugs.kde.org/show_bug.cgi?id=186531 Jake Linder <jakelin...@mail.com> changed: What|Removed |Added CC||jakelin...@mail.com --- Comment #16 from Jake Linder <jakelin...@mail.com> --- That's strange, I was able to reproduce this about a month ago with git master. Did you test with a non-Image PDF (of white background)? Have you tried shocking purple? Fixing it would be trivial only the trim logic is all entangled with pixmap caching and you have to touch 4 layers of code or so to fix this, otherwise it would be have been long ago. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124961/ --- (Updated Oct. 11, 2017, 1:05 p.m.) Status -- This change has been discarded. Review request for Okular and Albert Astals Cid. Bugs: 318078 http://bugs.kde.org/show_bug.cgi?id=318078 Repository: okular Description --- Supercedes https://git.reviewboard.kde.org/r/124723/: - Rebase to apply cleanly against just-merged 172d78c (Trim Selection Feature) - Drop the refactoring patch (seperate problem), sticking with the code duplication for now. - Added seperate patch (post changes) fixing whitespace issue in gargantuan switch statement. Take it or leave it. Diffs - ui/pageview.cpp dc9eab8301b05e57bfdd537d47b33da594759573 Diff: https://git.reviewboard.kde.org/r/124961/diff/1/ Testing --- - cursor switches to Hand when hovering over link in TextSelect mode. - clicking on hyperlink jumps to destination in TextSelect mode. - text selection & copy still works. - can text-select "over and across" hyperlink. - can text-select starting at text and ending selection in middle of hyperlink. - can text-select starting from hyperlink with click and drag. - can jump to link while there's an active selection of text. - can jump to link while there's an active selection spanning a hyperlink. - doesn't crash when switching away from window and back + clicking off page - when textselect overlaps a link, r-click on the link gives the "follow this link" content menu, r-click off link gives the "Copy Text"/etc' context menu - text selection works when selecting left to right or right to left (begin/end selection works out no matter in what order user provides them) Thanks, Jake Linder
