[RELEASE] Bug 119024 Calc 3.4 crash constant when sorting a named areas where the columns being sorted contains empty cells

2012-03-08 Thread Lei Wang
Hi,

Issue 119024 - https://issues.apache.org/ooo/show_bug.cgi?id=119024 -
should be closed as it can not be reproduced in AOO3.4 rev 1296433 from my
point of view.  If anyone can reproduce this issue in the latest AOO3.4
build(rev 1296433), please add comments and give detail description about
the steps and configuration.

Best regards,

Wang Lei


[RELEASE] Bug 118537 When there are a large number of Charts in a spreadsheet a number of charts just display OLE

2012-03-09 Thread Lei Wang
Hi,

>From my point of view, Issue 118537,
https://issues.apache.org/ooo/show_bug.cgi?id=118537 is not a release
blocker. It is not a crash, regression, other serious issue.

Now I can not get the sample file because of the file can not be downloaded
in the specified URL. So I  can not investigate it.

Best regards,

Wang Lei


Re: Is any one here familiar with OpenOffice?

2012-03-13 Thread Lei Wang
Hello Rob

I am Spreadsheet team leader for Lotus Symphony Development. I participated
with several work related with OpenOffice from 2002.  I did performance
improvement for Symphony start up, document loading and saving. I fix
issues and add new features for Spreadsheet. I implemented a well known
feature, side bar and property panel for Symphony. I contributed several
issue fix to OpenOffice.

I have software performance knowledge and experience, such as performance
testing, profiling, analysis. I also have some knowledge about OpenOffice
in framework and Spreadsheet component.


On Tue, Mar 13, 2012 at 5:09 PM, Steve Yin  wrote:

> Hi Rob,
>
>
> I joined Symphony team four years ago.
>
> My focus areas are PDF export, drawing layer, MSO file format, MSO
> encryption, Accessibility, and shell mechanism.
>
> I've contributed "Encryption support for Microsoft Word 97/200/XP filter"
> feature for openoffice.org and put Symphony IA2 feature on one ongoing CWS
> named "ooo31ia2".
>
>
>
> Best Regards,
>
> Steve Yin
>
>
> 2012/3/12 Rob Weir 
>
> > I jest,of course.
> >
> > But seriously, there are some claiming that "all" of the
> > OpenOffice.org project went over to LibreOffice and that the Apache
> > has zero experience with this code base.  I know this sounds crazy,
> > but how can we best refute that statement?
> >
> > Here's my idea:  Respond to this note and tell me how many years
> > experience you have working with OpenOffice.  This could be in any
> > capacity, as a coder, tester, documentation, marketing, forum
> > volunteer, whatever.  Please count relevant work with related
> > projects, such as Symphony, BSD ports, OOo4Kids, ODF, etc. as well.
> > How many years were you doing this before the project came to Apache?
> >
> > If I get a good number of responses I'll put together an infographic on
> > this.
> >
> > Regards,
> >
> > -Rob
> >
>


Re: Ooo for Win XP, type ahead feature

2012-03-29 Thread Lei Wang
What is typing the words ahead? Do you means word completion?

On Wed, Mar 28, 2012 at 11:54 PM, Luciano  wrote:

> I have Ooo for Linux and Ooo for Win XP. I noticed that the Ooo for win xp
> doesn't type the words ahead like the one on Linux does. Is this feature
> going to be added some day to the Win XP version?
>
>
>
> I know this is a minor thing, given that Ooo is such a great application.
> I'm really happy with it.
>
>
>
> Luciano
>
>


Re: patch for issue 118863

2012-05-31 Thread Lei Wang
Hi Debin,

I have reviewed the codes for 118877
https://issues.apache.org/ooo/show_bug.cgi?id=11887
>
> It seems it still has some problems. I add comments in the issues. Please
check.



On Mon, May 21, 2012 at 3:09 PM, debin lei  wrote:

> I had a fix for issue 118863. Is there anyone can help to review it, thank
> a lot!
> More details and patch file can be found
> here
>
> https://issues.apache.org/ooo/show_bug.cgi?id=118863
>
> --
> Best regards
> Lei Debin
>


[Calc][DISCUSS] What is your expected behavior when doing paste with a whole column or a whole sheet.

2012-06-12 Thread Lei Wang
Hi,

When I review bug i118863 (
https://issues.apache.org/ooo/show_bug.cgi?id=118863), I find there are
some other related user cases which can get AOO crash or freeze.

Scenario 1
1)New a calc doc.
2)Input 1, 2, 3 in cell A1, A2, A3
3)Set background color for cell A1, A2, A3 as blue, green, red
4)Select A1:A3, and copy
5)Select a whole columnm, such as column E, and paste

AOO need more than 5 minutes to complete this work.
6)undo the paste
AOO also need a lot of time

Scenario 2
1)New a calc doc.
2)Input 1, 2, 3 in cell A1, A2, A3
3)Select A1:A3, and copy
4)Select another whole sheet, such as "sheet2", and paste

AOO will crash


Now Calc supoorts 1,048,576 rows * 1024 columns, which is 1,073,741,824
cells. Pasting with a whole column selected will fill the column. Pasting
with a whole sheet selected will fill the sheet, which always casue AOO
crash.

I have two suggestions

Solution 1
Disable auto repeat to fill cells when pasting with a whole column/sheet
selected. Considering user may not want to repeat to fill the cells when
pasting with a whole column/sheet selected, just paste the source data and
do not repeat to fill.

Excel has a strange behavior. It will not repeat to fill cells, if the cell
numbers in target range is not integer multiple of the source data.
For an example,
Copy A1:A2, Select B1:B10, Ctrl+V -> B1:B10 will be filled
Copy A1:A2, Select B1:B11, Ctrl+V -> Only B1:B2 will be filled
So when pasting with a whole column/sheet selected, sometimes Excel will
repeat to fill the whole column/sheet, sometimes it will not.


Solution 2
Set two thresholds, one is for warning user, one is for the limitation.
If number of cells in target range is bigger than warning threshold, Calc
will popup a warning message to warn user the potential bad performance. If
number of cells in target range is bigger than limitation, Calc will popup
a error message to info user the operation can not be completed.

The purpose of Solution 1/Solution 2 is to avoid making Calc crash for
careless operation(paste with a whole column/sheet selected).

 What is your opinion?


Re: [Call-for-Review][Calc][From Symphony]Formula GETPIVOTDATA returns #REF! value

2012-06-13 Thread Lei Wang
I will take care of this one.

On Wed, Jun 13, 2012 at 2:07 PM, 彭云全  wrote:

> Hi All,
>
>My name is pengyunquan. I am a developer working several years in
> Symphony team. My special areas are PivotTable / Graphic / VCL /
> Performance.
>
> I have a patch for review.
> https://issues.apache.org/ooo/show_bug.cgi?id=119972
>
> Root Cause : Within MS Excel, the user-defined field name( called
> "Layout Name" in AOO ) can be used in the Formula "GETPIVOTDATA", and
> MS Excel will check original field name & Layout Name. But in AOO,
> just orginal field name & an automatically generated data field name
> are checked. When outputting Pivot Table, the data field name is
> outputted as automatically generated data field name if the Layout
> name is invalid, while the data field name will be outputted as the
> Layout name if the Layout name is valid. For the users, they just see
> the outputted name, and the formula "GETPIVOTDATA" should check the
> outputted name. As a result, the formula "GETPIVOTDATA" should check
> the Layout name if the Layout name is valid, and check the
> automatically generated data field name if the Layout name is invalid.
>


Re: [Call-for-Review][Calc][From Symphony]Crash if undo redo creating data pilot from imported data

2012-06-13 Thread Lei Wang
I will take care of this one.

On Wed, Jun 13, 2012 at 2:04 PM, 彭云全  wrote:

> hI All,
>
>My name is pengyunquan. I am a developer working several years in
> Symphony team. My specail areas are PivotTable / Graphic / VCL /
> Performance.
>
> I have a patch for review.
> https://issues.apache.org/ooo/show_bug.cgi?id=119956
>
> Root Cause : A rule in calc is that inserting a sheet should enable
> DrawUndo first, because inserting a new sheet will cause a new
> ScDrawPage being inserted into SdrModel, and this action should be
> managed by DrawUndo. But on creation of PivotTable, this rule is not
> obeyed. When creating PivotTable on new sheet, a new sheet is inserted
> without enablement of DrawUndo. As a result, when undo the creation of
> PivotTable, the new sheet is removed but the SdrModel is not by
> synchronized because it's the DrawUndo's responsibility to do the
> synchronization but DrawUndo is not recorded. When inserting sheets
> from file for the 2nd time, the undo list is cleared and some
> ScDrawPage should be destroyed, but as stated above the ScDrawPage is
> not correctly maintained when undo the creation of PivotTable, so
> incorrect ScDrawPage is destroyed and cause dead object access later.
>
> Solution : Enable DrawUndo before inserting a new sheet on creation of
> PivotTable
>


Re: [Call-for-Review][Calc][From Symphony]Formula GETPIVOTDATA returns #REF! value

2012-06-13 Thread Lei Wang
Done. Thanks for your contribution

On Wed, Jun 13, 2012 at 9:02 PM, Lei Wang  wrote:

> I will take care of this one.
>
>
> On Wed, Jun 13, 2012 at 2:07 PM, 彭云全  wrote:
>
>> Hi All,
>>
>>My name is pengyunquan. I am a developer working several years in
>> Symphony team. My special areas are PivotTable / Graphic / VCL /
>> Performance.
>>
>> I have a patch for review.
>> https://issues.apache.org/ooo/show_bug.cgi?id=119972
>>
>> Root Cause : Within MS Excel, the user-defined field name( called
>> "Layout Name" in AOO ) can be used in the Formula "GETPIVOTDATA", and
>> MS Excel will check original field name & Layout Name. But in AOO,
>> just orginal field name & an automatically generated data field name
>> are checked. When outputting Pivot Table, the data field name is
>> outputted as automatically generated data field name if the Layout
>> name is invalid, while the data field name will be outputted as the
>> Layout name if the Layout name is valid. For the users, they just see
>> the outputted name, and the formula "GETPIVOTDATA" should check the
>> outputted name. As a result, the formula "GETPIVOTDATA" should check
>> the Layout name if the Layout name is valid, and check the
>> automatically generated data field name if the Layout name is invalid.
>>
>
>


Re: [Call-for-Review][Calc][From Symphony]Crash if undo redo creating data pilot from imported data

2012-06-13 Thread Lei Wang
Done. Thanks for your contribution

On Wed, Jun 13, 2012 at 9:03 PM, Lei Wang  wrote:

> I will take care of this one.
>
>
> On Wed, Jun 13, 2012 at 2:04 PM, 彭云全  wrote:
>
>> hI All,
>>
>>My name is pengyunquan. I am a developer working several years in
>> Symphony team. My specail areas are PivotTable / Graphic / VCL /
>> Performance.
>>
>> I have a patch for review.
>> https://issues.apache.org/ooo/show_bug.cgi?id=119956
>>
>> Root Cause : A rule in calc is that inserting a sheet should enable
>> DrawUndo first, because inserting a new sheet will cause a new
>> ScDrawPage being inserted into SdrModel, and this action should be
>> managed by DrawUndo. But on creation of PivotTable, this rule is not
>> obeyed. When creating PivotTable on new sheet, a new sheet is inserted
>> without enablement of DrawUndo. As a result, when undo the creation of
>> PivotTable, the new sheet is removed but the SdrModel is not by
>> synchronized because it's the DrawUndo's responsibility to do the
>> synchronization but DrawUndo is not recorded. When inserting sheets
>> from file for the 2nd time, the undo list is cleared and some
>> ScDrawPage should be destroyed, but as stated above the ScDrawPage is
>> not correctly maintained when undo the creation of PivotTable, so
>> incorrect ScDrawPage is destroyed and cause dead object access later.
>>
>> Solution : Enable DrawUndo before inserting a new sheet on creation of
>> PivotTable
>>
>
>


Re: [Discussion]Active Doc/Sheet protection password related blocks

2012-06-28 Thread Lei Wang
Hi Jian Yuan,

The file tabprotection.hxx is created by CWS scheetprotection02. I go
through the comments when this CWS integrated into the trunk. But I do not
find any useful information.

If Excel use another hash algorithm, AOO can not unprotect the sheet/doc
even user input the right password. To avoid this bad situation, I guess
the developer disable related function.

On Wed, Jun 27, 2012 at 3:12 PM, Oliver-Rainer Wittmann <
orwittm...@googlemail.com> wrote:

> Hi,
>
>
> On 26.06.2012 08:44, Jianyuan Li wrote:
>
>> Hi, all,
>>
>> In ../sc/inc/tabprotection.hxx, a macro is defined as below:
>> #define ENABLE_SHEET_PROTECTION 0
>>
>> So all blocks controlled by it will not be executed:
>> 1. Import/export Sheet/Doc protection password for a protected xls file.
>> 2. Import a protected xls file and show unpassword dlg to input password
>> when unprotect the sheet/doc.
>> 2. Import a ods/xls file and export it as a xls/ods file. Show password
>> retype dlg.
>> And there is an issue related to it:
>> https://issues.apache.org/ooo/**show_bug.cgi?id=119552.
>> I have added some
>> comments for it.
>> I had a simple test to set the macro as 1 and checked all above scenarios.
>> It works well. So here I want to set the macro as 1.
>>
>> Any comments? Or does anyone know the initial thought for the value "0"
>> of ENABLE_SHEET_PROTECTION?
>>
>>
> I do not know anything about this code.
>
> But may be a look in the hg repository - still available at [1] - would
> help. May be the one or the other commit log message by which this macro
> has been introduced would give some answers.
>
> [1] http://hg.services.openoffice.**org/
>
>
> Best regards, Oliver.
>


Re: colours in Calc

2012-07-01 Thread Lei Wang
Hi Pam,

>From your description, I do not really understand your problem. I guess you
have a Spreadsheet document(ods file). It worked fine in your old OOo (may
be OOo3.3). After you upgrade OOo to AOO3.4, it does not work now. You can
open/file a bug in https://issues.apache.org/ooo . Please attach your
problem file in the bug. Then we can have a look and help you find the
reason.

On Fri, Jun 29, 2012 at 9:09 PM, Pam Tuthill  wrote:

> I have recently installed the latest Open Office and it has totally ruined
> some of my documents!
>
> I had a calendar/planner using several colours which I had been able to
> devise for myself as well as lots from the palate provided.
>
> How on earth can I get my old document back as it took several hours work
> and I really do not want to have to spend hours and hours doing it all
> again.
>
> I have searched the pages on the web page, but I have given up trying to
> work my way through it all in the hope of a solution.
>
> I have used Open Office for years and have recommended it to everyone I
> know, but if this sort of thing happens with no warning .
> To quote the robot in Short Circuit - 'I am really pissed off' 
>
> Pam Tuthill


[Calc][Discuss]Interoperability with Excel for SUMIF, COUNTIF, COUNTBLANK, DCOUNT, DSUM, ... with empty cells and "" and ="" empty string criteria.

2012-07-02 Thread Lei Wang
Hi all,

There is an old bug i65221(
https://issues.apache.org/ooo/show_bug.cgi?id=65221). It is about
interoperability with Excel for SUMIF, COUNTIF, COUNTBLANK, DCOUNT, DSUM,
... with empty cells and "" and ="" empty string criteria.

There is some discussion about it, but no conclusion. Some people think
Excel does not do well, so simply mimicking Excel behavior might not be the
best idea. Some people think self-consistency in Calc is more important.
Some people think compatibility with Excel is a huge concern.

IMHO, compatible with Excel is very important. I suggest changing these
formulas behavior according to Excel. Following is my consideration
1)Most people use Excel, compatible with Excel is very important. Excel
does not show self-consistency in some scenarios, Calc doe not show
self-consistency either.
2)Some frequently used function, such as calculating empty cells, can not
be implemented by Calc, while Excel can.
3)Although Excel does not show self-consistency in some scenarios. These
scenarios are all related with pure empty cell. Excel use following rules
  When empty cell is criteria, only cells with value 0 meet it. This is
true for COUNTIF, SUMIF. But not true for DSUM/DCOUNT/IF.
  When an empty cell in a cell range, it can meet empty string criteria.
This is true for COUNTIF, SUMIF. But not true for DSUM/DCOUNT.


Re: [DISCUSS]Macros are lost after saving the xls file to ods, then save as to xls again

2012-07-03 Thread Lei Wang
Jian Hong,

Will AOO save VBA as Star Basic in ods file when saving a xls file with VBA
as ods file? If it is true, can user modify the Star Basic in the new ods
file? What happened if user change the Star Basic in the ods file then save
as a xls file?

On Tue, Jul 3, 2012 at 3:57 PM, chengjh  wrote:

> Hi Peng,
>
> Let me use a scenario to confirm your problem,solution and
> question..Anything misunderstood,please correct me.thanks.
>
> Problem:
> When AOO launches an excel document with VBA,saves to ods and then saves to
> excel again,the VBA info will be lost.
>
> Solution:
> a)The VBA streams of an excel document will be saved into the ods document
> with binary format when converting an excel document to an ods document in
> AOO Spreadsheet with certain controller.
> b)Once the ods document containing the binary VBA streams is launched into
> AOO or previous releases,with certain controller,the binary VBA steams will
> be loaded[still binary stream in memory] or rejected..There is no any
> impact on the application,the application can still work well.
> c)Based on b),if the ods document is saved to an excel document,the binary
> VBA streams will be exported, thus, the VBA info will not be lost.
>
> Question:
> You are not sure whether this solution is reasonable. So, you want to know
> the comments about your solution. If no comments, you will do so to
> implement it.
>
> On Mon, Jul 2, 2012 at 4:33 PM, Chen Peng  wrote:
>
> > Hi All,
> >   My name is Chen Peng, I am a developer from Symphony. My special
> > areas are VBA and sw.
> >   Now I found an issue about macros lost:
> >  I saved an excel file with VBA to spreadsheet, the VBA can work
> > well in spreadsheet, then I wanted to save this spreadsheet back to
> excel,
> > but all the macros are lost.
> >   I propose to save the binary data of excel VBA to spreadsheet, when
> > saving excel to spreadsheet, then we can get the binary data from
> > spreadsheet if need to save the spreadsheet to excel again.
> >   The binary data will not impact the open/save... of the ODF format
> > application, it will not be touched when we operate the ODF formant
> > applications. The binary data will be just used when we want to save the
> > spreadsheet to excel, it is just a data prestore about saving spreadsheet
> > macros to excel.
> >Can you give some advice about the solution?
> >Any feedback will be preciated, thanks.
> >
>
>
>
> --
>
> Best Regards,Jianhong Cheng
>


Re: [DISCUSS]Macros are lost after saving the xls file to ods, then save as to xls again

2012-07-03 Thread Lei Wang
As I know, VBA code can be related with specific sheet. When end user open
the ods file and remove this sheet, then save it as xls file.  According to
your solution, all VBA codes will be restored in xls file. Is this xls file
valid?

Another concern is does your solution conform to ODF1.2 standard?

On Tue, Jul 3, 2012 at 6:32 PM, chengjh  wrote:

> That doesn't matter that you think they are VBA or Star Basic when saving a
> xls with VBA as ods file..To some APIs with behavior difference,they will
> be distinguished with the line "Option VBASupport 1" at the beginning..End
> users can modify the Star Basic codes in AOO Spreadsheet,but all Star Basic
> contents including original and modified will be lost when exporting to xls
> file..Here,if the ods file is converted from a xls file based on Peng's
> solution,the behavior is still kept unchanged...The only difference is that
> the saved binary VBA streams within the ods file will be exported to the
> xls file at that time.Thus,when end users launch the xls file in MS
> Excel,the original VBA will be there.That's the expected result.thanks.
>
> On Tue, Jul 3, 2012 at 5:02 PM, Lei Wang  wrote:
>
> > Jian Hong,
> >
> > Will AOO save VBA as Star Basic in ods file when saving a xls file with
> VBA
> > as ods file? If it is true, can user modify the Star Basic in the new ods
> > file? What happened if user change the Star Basic in the ods file then
> save
> > as a xls file?
> >
> > On Tue, Jul 3, 2012 at 3:57 PM, chengjh  wrote:
> >
> > > Hi Peng,
> > >
> > > Let me use a scenario to confirm your problem,solution and
> > > question..Anything misunderstood,please correct me.thanks.
> > >
> > > Problem:
> > > When AOO launches an excel document with VBA,saves to ods and then
> saves
> > to
> > > excel again,the VBA info will be lost.
> > >
> > > Solution:
> > > a)The VBA streams of an excel document will be saved into the ods
> > document
> > > with binary format when converting an excel document to an ods document
> > in
> > > AOO Spreadsheet with certain controller.
> > > b)Once the ods document containing the binary VBA streams is launched
> > into
> > > AOO or previous releases,with certain controller,the binary VBA steams
> > will
> > > be loaded[still binary stream in memory] or rejected..There is no any
> > > impact on the application,the application can still work well.
> > > c)Based on b),if the ods document is saved to an excel document,the
> > binary
> > > VBA streams will be exported, thus, the VBA info will not be lost.
> > >
> > > Question:
> > > You are not sure whether this solution is reasonable. So, you want to
> > know
> > > the comments about your solution. If no comments, you will do so to
> > > implement it.
> > >
> > > On Mon, Jul 2, 2012 at 4:33 PM, Chen Peng 
> > wrote:
> > >
> > > > Hi All,
> > > >   My name is Chen Peng, I am a developer from Symphony. My
> special
> > > > areas are VBA and sw.
> > > >   Now I found an issue about macros lost:
> > > >  I saved an excel file with VBA to spreadsheet, the VBA can
> > work
> > > > well in spreadsheet, then I wanted to save this spreadsheet back to
> > > excel,
> > > > but all the macros are lost.
> > > >   I propose to save the binary data of excel VBA to spreadsheet,
> > when
> > > > saving excel to spreadsheet, then we can get the binary data from
> > > > spreadsheet if need to save the spreadsheet to excel again.
> > > >   The binary data will not impact the open/save... of the ODF
> > format
> > > > application, it will not be touched when we operate the ODF formant
> > > > applications. The binary data will be just used when we want to save
> > the
> > > > spreadsheet to excel, it is just a data prestore about saving
> > spreadsheet
> > > > macros to excel.
> > > >Can you give some advice about the solution?
> > > >Any feedback will be preciated, thanks.
> > > >
> > >
> > >
> > >
> > > --
> > >
> > > Best Regards,Jianhong Cheng
> > >
> >
>
>
>
> --
>
> Best Regards,Jianhong Cheng
>


Re: [Calc][Discuss]Interoperability with Excel for SUMIF, COUNTIF, COUNTBLANK, DCOUNT, DSUM, ... with empty cells and "" and ="" empty string criteria.

2012-07-04 Thread Lei Wang
@Dennis,

I agree that conforming to ODFF is first goal. I add comments and
attachment in https://issues.apache.org/ooo/show_bug.cgi?id=65221
>From my understanding of ODFF, I give ODFF expect result for some formula
related with empty cell in the attachment(xls). If there is any mistake,
please comments.

Open this file in AOO3.4/LO3.5, 16 cases fail.
There are:

Criterion in COUNTIF/SUMIF
   ODFF  AOO3.4/LO3.5
 criterion as "=" empty cellempty string cell
 criterion as "<>"not empty cellnot empty cell and not empty
string cell
 criterion as "<>0"any cell exceptany cell except 0, not
including empty cell
 value 0, including
  empty cell

Criterion in criteria for database formula, such as DSUM, DCOUNT
  ODFFAOO3.4/LO3.5
 criterion is emptyvalue 0all cells
 cell
 criterion is emptyempty stringall cells
 string
 criterion as "=" empty cellempty cell and empty string cell
 criterion as "<>"not empty cellnot empty cell and not empty
string cell

Also AOO3.4/LO3.5 has self-consistent problem.
The different result for same criterion between COUNTIF/SUMIF and database
formulu(DCOUNT/DSUM). These criterion includes:
criterion is empty cell, criterion is empty string, criterion is "=",
criterion is "<>0"

While, open this file in Excel 2003, 8 cases fail.
There are:

Criterion in COUNTIF/SUMIF
   ODFF  Excel 2003
 criterion is ""  empty string cellempty string cell and empty
cell
 criterion is emptyempty string cellempty string cell and empty cell
 string

Criterion in criteria for database formula, such as DSUM, DCOUNT
 ODFFAOO3.4/LO3.5
 criterion is emptyvalue 0all cells
 cell

Also Excel 2003 has self-consistent problem.
The different result for same criterion between COUNTIF/SUMIF and database
formulu(DCOUNT/DSUM). These criterion includes:
criterion is empty cell, criterion is empty string

It seems Excel has better conformance for these test cases.

Conform to ODFF is very important. Compatible with Excel is also very
important, especially for some common used Excel scenario, such as
COUNTIF(, "") to count all cells displayed as empty. Do we have
any chance to modify ODFF to solve this Excel user problem?


On Tue, Jul 3, 2012 at 1:14 AM, Dennis E. Hamilton
wrote:

> @Andrew,
>
> See latest comments on https://issues.apache.org/ooo/show_bug.cgi?id=65221
>
> I agree with orw that the first goal should be to align with OpenFormula,
> and that is specific about the use of Criteria in SUMIF, COUNTIF, etc., as
> you saw in section 4.11.8.
>
> In the case that there needs to be further clarification in OpenFormula,
> comments can be submitted to the ODF TC for Errata and/or improvements in
> the next edition, ODF 1.3.  OpenFormula was developed with cross-format
> interoperability in mind and Microsoft participation was helpful for that.
>
> User Guide documentation on these cases is probably also important.
>
>  - Dennis
>
> -Original Message-
> From: Andrew Pitonyak [mailto:and...@pitonyak.org]
> Sent: Monday, July 02, 2012 07:39
> To: ooo-dev@incubator.apache.org
> Subject: Re: [Calc][Discuss]Interoperability with Excel for SUMIF,
> COUNTIF, COUNTBLANK, DCOUNT, DSUM, ... with empty cells and "" and =""
> empty string criteria.
>
> On 02.07.2012 04:50, Lei Wang wrote:
> > Hi all,
> >
> > There is an old bug i65221(
> > https://issues.apache.org/ooo/show_bug.cgi?id=65221). It is about
> > interoperability with Excel for SUMIF, COUNTIF, COUNTBLANK, DCOUNT,
> > DSUM,
> > ... with empty cells and "" and ="" empty string criteria.
> >
> [ ... ]
>
> I am surprised that the ODF standard does not dictate how this should
> be handled. I was under the impression that function behaviour in an ODF
> document was well defined. I believe that Robert Weir is far more aware
> of ODF type issues than I (since I have seen him mentioned by name on
> similar topics) - not that I intend to unfairly pull him into this
> discussion.
>
> In Version 1.2 of the part-2 for OpenFormula, I don't see it obviously
> spelled out, but I don't really have time to extensively pursue it.
>
> [ ... ]
>
> 4.7 Empty Cell
> An empty cell is neither zero nor the empty string, and an empty cell
> can be distinguished from cells containing values (including zero and
> the empty string). An empty cell is not the same as an Error, in
> particular, it is distinguishable 

[Calc] Dose Calc support Excel similar function "Move but don't size with cell" for drawing object/picture

2012-07-05 Thread Lei Wang
Hi,

In Excel, user can set object positioning properties for a drawing
object/graphic. There are three options.  AOO does not have similar
properties. But it use anchor attribute to reflect these properties.
 Excel AOO
Move and size with cells  Anchor to cell
Move but don't size with cells   ?
Don't move or size with cellsAnchor to page

Does anyone know how to get the effect "Move but don't size with cell" for
drawing object in AOO.


Re: spreadsheet source

2012-07-07 Thread Lei Wang
Hi, Shawn

There are some documents about the implementation listed
http://wiki.services.openoffice.org/wiki/Calc/Implementation

On Fri, Jul 6, 2012 at 9:34 PM, Shawn Pringle wrote:

> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> I am a new subscriber and there are some bugs I am trying to resolve.
>
> Hello, can someone direct me to the spreadsheet code?  I am especially
> interested in the part that handles the tabs at the bottom of the
> screen.  Apart from the wiki, (I haven't looked yet), is there
> documentation on the OOO internals?
>
> Thanks in advance,
>
> Shawn Pringle
> - --
> PGP public key available at pool.sks-keyservers.net
>
> -BEGIN PGP SIGNATURE-
> Version: GnuPG v1.4.9 (MingW32)
>
> iQEcBAEBAgAGBQJP9ulOAAoJEHJVLFhKYbxVygAH/inVu8fezvHJ5Uj9QU8DUXki
> ylbo/hGvYQNJSWebVZr6up5+nOUX6F8KiNZFmwAvi0RDgcQnLuK05BlLwRh/TjoJ
> P+R3uhHjkAsC5Xi862UecWKwTEyqguksV8s8pDb2aceV9J140yyMB9S+HrsZnh+z
> VpuIwj9x0u9oC7bUYSDZVXd0hA85xnV2s0XvSEFR7dFll3fpgTQruLeo7/n98aCP
> fO2bviga9Zqgi0rgwnu/NUrRLQ9rhe6noDVJhmOpZPBRVUoDYgEjJi8V0+eQzvVW
> VbpEQAPcVq4hJA9wom4VG4kyEKYLKJqgFuJHLwNIelTgrJU4HJUq8U42xJ6/LbY=
> =AZV2
> -END PGP SIGNATURE-
>


Re: [RELEASE][3.5] Process thinking - defect&feature rules, iteration...

2012-07-19 Thread Lei Wang
I add some items for Calc application for 3.5 plan in 3.5 Release Planning
wiki<
https://cwiki.apache.org/confluence/display/OOOUSERS/AOO+3.5+Release+Planning
>

If there are anything which must be in 3.5 for Calc, please discuss it here
or put it in the list in the planning wiki.

On Fri, Jul 20, 2012 at 1:52 PM, Shenfeng Liu  wrote:

> Juergen,
>   Thanks for your comments!
>   My thoughts below...
>   And I updated the 3.5 Release Planning
> wiki<
> https://cwiki.apache.org/confluence/display/OOOUSERS/AOO+3.5+Release+Planning
> >with
> a draft of the defect/feature rule. Could you and QE team review and
> give comments?
>   Again, it is not only related to developers, but also testers and other
> contributors on how to collaborate in 3.5. So I'd like to hear more
> comments. e.g. from Yan Ji and other QE members...
>   And translation process is a very important part, but I'm not quite
> familiar...
>
> - Simon
>
>
> 2012/7/18 Jürgen Schmidt 
>
> > On 7/18/12 9:02 AM, Shenfeng Liu wrote:
> > > Hi, all,
> > >   I made some update on the AOO 3.5 Release Planning wiki Juergen
> > created:
> > >
> >
> https://cwiki.apache.org/confluence/display/OOOUSERS/AOO+3.5+Release+Planning
> > .
> > >
> > >   And besides proposing contents in the High Level Overview table, I
> > think
> > > we should also think about the release process. And below are what in
> my
> > > mind:
> > >
> > > 1. Defect/Enhancement rule
> > >
> > > In 3.5, there will be not only defects, but also some feature
> > enhancements
> > > that need relatively bigger development efforts. The 3.5 release circle
> > > will also be longer than 3.4.1. And more contributors will
> participate, I
> > > believe. So it is very important to build up a good traceability, so
> that
> > > we can query out the project status automatically, but not rely on
> > people's
> > > input in wiki.
> > > To make it happen, we need to define some rules in Bugzilla for:
> > >
> > > (1) Defect/Enhancement creating. e.g. against which Version, define of
> > the
> > > Severity/Priority, Keywords needed...
> > > (2) Defect triage. How do we decide if a fix or a feature should be in
> > 3.5
> > > or not? Where do we record our decision (e.g. in Target Milestone, or
> > > Flags)? It will become important when we close to GA, or deliver a
> > > milestone build.
> >
> > all fixes should be allowed to go into a release. And I think all
> > features as well if there are no valid concerns. After having the fixes
> > in a milestone build we can set the target of the issue to 3.5 for
> > example. This will make it clear that it goes into the 3.5, was already
> > part of a milestone build and will be part of further milestones.
> >
>
> Thanks for your comments! I drafted a defect/feature rule in the 3.5
> Release Planning wiki, please review.
>
>
> >
> > We should define the fix integration order. Currently we follow the
> > approach to fix on trunk and merge in the branch on demand. Or fix on
> > branch only if branch specific like branding for example.
> >
>
> For defects and small fixes, I think "fix on trunk and merge in the branch
> on demand" is good approach.
> For feature/enhancements, I prefer them to be completed an pass an
> acceptance testing in a branch firstly, then deliver to trunk.
> For branch specific fixes, as you said, should be only on the specific
> branch.
>
>
> >
> > > (3) Defect fix, patch, review.
> > > (4) Defect verify/close.
> > >
> > > For some rules (e.g. Severity/Priority), we may point to a place with
> > > general rules defined. For some rules specific to 3.5 (e.g. Version,
> > Target
> > > Milestone, Flags), we should write them down in the release planning
> > wiki.
> > > After we defined the rules, QE team can help to define some shared
> > queries
> > > for us to get the project status and todo list.
> >
> > to define and build a common understanding would definitely help all
> > involved parties to track issues and get a better understanding about
> > our releases and what goes in them.
> >
> >
> > >
> > > 2. Iteration and Milestone builds
> > >
> > > Since, as discussed, 3.5 release is likely to last for 6~9 months, I
> > think
> > > it will be good for us to try the iterative development mode, and
> deliver
> > > milestone builds regularly. The milestone builds are dev snapshot
> builds,
> > > not formal release, but contains new bug fixes and enhancements
> > implemented
> > > till the last iteration, and verified to be relatively stable in
> quality
> > by
> > > QE team with a small regression test suite. And the milestone builds
> can
> > be
> > > announced to external for people's try out the new enhancement works,
> > > provide feedback and report issues. And internally, it can help us to
> > > measure the quality regularly, and avoid big quality deviation.
> > > Since we are open community and many of us are volunteers working on
> AOO
> > > with their spare time, it is unlikely for us to apply strict agile
> > > discipline. So I think the p

Re: [UX]Why does AOO use semicolon and space as the default separators when open one csv?

2012-07-23 Thread Lei Wang
Liu Zhe

I agree with you.
+1 for me

On Mon, Jul 23, 2012 at 3:00 PM, Zhe Liu  wrote:

> Hi,
> I use Calc to open a csv. "Text Import" dialog pops up. Semicolon &
> Space are checked by default as separators. Most of csv  files in the
> world use comma as separator, right? I prefer comma.
> In addition, when I use AOO to save a csv, I found the default
> separator is comma. When I reopen the csv, I have to change separator
> to comma. IMHO, it's a bad experience.
>
> --
> Best Regards
> From aliu...@gmail.com
>


Re: [Call-for-​​Review][From Symphony] Function "Case sensitive" in "Special Filter" dialog can not work.

2012-07-26 Thread Lei Wang
I will take care of this

On Thu, Jul 26, 2012 at 4:09 PM, Clarence GUO wrote:

> HI~
> I have one fix waiting for review. Root cause and solution please goto the
> issue's comments.
> https://issues.apache.org/ooo/show_bug.cgi?id=119637
>
> Regrads
> Clarence
>


[DISCUSS][CALC] String content to numeric value

2012-07-26 Thread Lei Wang
In ODFF standard 6.3.5 Conversion to Number,
If the expected type is Number, then if value is of type:
● Text: The specific conversion is implementation-defined; an evaluator may
return 0, an Error value, or the results of its attempt to convert the Text
value to a Number (and fall back to 0 or Error if it fails to do so).
Evaluators may apply VALUE() or some other function to do this conversion,
should they choose to do so. Conversion depends on the actual locale the
application runs in, especially if group or decimal separators are involved.

It leave the implementation to decide whether to convert a text value to a
number, in which extent to convert a text value to a number. AOO now only
support convert string content to numeric, which is integer numbers
including exponent, and ISO 8601 dates and times in their extended formats
with separators. This cause issue 118942(
https://issues.apache.org/ooo/show_bug.cgi?id=118942).

In my point of view it is better to support more scenarioes to convert a
text value to a number, such as decimal. Though different locale has
different decimal separator, AOO can support decimal separator for current
locale and standard decimal separator, ".". It will be more complicated for
date format.

What's your suggestion?


Re: remove system font selection

2012-07-26 Thread Lei Wang
This must be done by core. You need build your owner AOO. You need change
the font selection UI control from toolbar and property dialog.

On Fri, Jul 27, 2012 at 1:04 PM, Wie Kiang  wrote:

> Hello,
>
> Any idea how to remove system font selection on open office UI
> (Writer, Calc and Impress)?
> i just only need 2 fonts like Arial and Times New Roman only.
>
> Any feedback will be appreciate.
>
>
> Regards,
> Wie
>


Re: remove system font selection

2012-07-26 Thread Lei Wang
Wie,

I means you need download AOO source code and build it.

http://wiki.services.openoffice.org/wiki/Documentation/Building_Guide_AOO

And it seems that your request is hard to integrated into AOO release
build. So you may maintain your own codes.

On Fri, Jul 27, 2012 at 1:52 PM, Wie Kiang  wrote:

> Lei,
>
> Thanks for your reply,
>
> Can you details what did you mean by "build your owner AOO"?
>
>
> Thanks,
> Wie
>
> On Fri, Jul 27, 2012 at 12:36 PM, Lei Wang  wrote:
> > This must be done by core. You need build your owner AOO. You need change
> > the font selection UI control from toolbar and property dialog.
> >
> > On Fri, Jul 27, 2012 at 1:04 PM, Wie Kiang  wrote:
> >
> >> Hello,
> >>
> >> Any idea how to remove system font selection on open office UI
> >> (Writer, Calc and Impress)?
> >> i just only need 2 fonts like Arial and Times New Roman only.
> >>
> >> Any feedback will be appreciate.
> >>
> >>
> >> Regards,
> >> Wie
> >>
>


Re: [Call-for-​​Review][Calc]Data validity works incorrectly with criteria "Allow text length" for numbers

2012-07-27 Thread Lei Wang
I am taking care of this

On Wed, Jul 25, 2012 at 1:11 PM, Zhang Lu  wrote:

> Hi~
>
> One fix for review.
>
> https://issues.apache.org/ooo/show_bug.cgi?id=93128
>
> Step:
>
> 1 Select the cells for which you want to define a new validity rule
> 2 Choose Data - Validity
> 3 On the Criteria tab page, enter the conditions for new values entered
> into
> cells
> 4 In the Allow field, select "Text length"
> 5 In the Data field, select such as "less than"
> 6 In the Value field, enter into "10"
>
> Result:
> If you enter "1" into the cells for which you want to define a new
> validity rule, there is a error message "Invalidate value".
>
> Expectation:
> we can enter anything into the cells
>
>
> Root cause: There is no flow to handle a real number when selecting string
> length operation
>
> Solution: if operation is string length type, to get the number's length,
> and consider it as a string.
>


Re: trunk build fails, likely in python

2012-08-01 Thread Lei Wang
With updating to revision 1367616, I can build python module successfully
in Windows XP. Thank you for your fixing.

On Tue, Jul 31, 2012 at 11:32 PM, Pedro Giffuni  wrote:

> Thank you Tsutomu!
>
> The other patches should also be used. I am not sure if dmake supports
> the += operator so I just went back to the old patching method on
> revision  1367616.
>
> This is hopefully the last change there. Sorry to take you guys
> as guinea pigs ;).
>
> Pedro.
>
>
>
> >
> > From: Tsutomu Uchino 
> >To: ooo-dev@incubator.apache.org
> >Sent: Tuesday, July 31, 2012 8:57 AM
> >Subject: Re: trunk build fails, likely in python
> >
> >Hi,
> >
> >2012/7/31 Regina Henschel :
> >> Hi Pedro,
> >>
> >> I still cannot build Python.
> >>
> >> Messages are:
> >> dmake:  Warning: -- Found file corresponding to virtual target
> >> [./wntmsci12/misc/build/Python-2.7.3/PC/pyconfig.h].
> >>
> >>
> >> Build started: Project: _ssl, Configuration: Release|Win32
> >> Performing Pre-Build Event...
> >> Can not find a suitable PERL:
> >>  the following perl interpreters were found:
> >>   C:\cygwin\bin\perl.exe
> >>  None of these versions appear suitable for building OpenSSL
> >>  Please install ActivePerl and ensure it appears on your path
> >> No Perl installation was found. Existing Makefiles are used.
> >> Could not find an SSL directory in '('..\\..',)'
> >> Project : error PRJ0019: A tool returned an error code from "Performing
> >> Pre-Build Event..."
> >>
> >> Project : warning PRJ0018 : The following environment variables were not
> >> found:
> >> $(UPDMINOREXT)
> >>
> >> Kind regards
> >> Regina
> >>
> >>
> >> Pedro Giffuni schrieb:
> >>
> >>> Committed as Revision 1367398 . Please test.
> >>>
> >>> Hopefully I learned from the error that Regina reported to
> >>> cleanup better the code.
> >>>
> >>> Pedro.
> >>>
> >>>
> >>>
>  
>  From: Pedro Giffuni 
>  To: "ooo-dev@incubator.apache.org" 
>  Sent: Monday, July 30, 2012 8:34 PM
>  Subject: Re: trunk build fails, likely in python
> 
>  Thank you.
> 
>  I will use this as an opportunity to do some further cleanup
> 
>  Pedro.
> 
> 
> 
> > 
> > From: Lin Yuan 
> > To: ooo-dev@incubator.apache.org
> > Sent: Monday, July 30, 2012 8:26 PM
> > Subject: Re: trunk build fails, likely in python
> >
> > I can reproduce this issue on my Win 7.
> > In Python-2.7.3\PCbuild\pcbuild.sln, there are two projects related
> to
> > sqlite3. One named "sqlite3". Another named "_sqlite3".  Both of them
> > need
> > to be remarked. But in python-2.7.3.patch, it only remark project
> > "sqlite3". Need also remark project "_sqlite3" in pcbuild.sln.
> >
> > 2012/7/31 Regina Henschel 
> >
> >> Hi Armin,
> >>
> >> I have rebased and deleted all the wbtmsci12*, then started a new
> >> build. I
> >> now get the same error as you.
> >>
> >> Kind regards
> >> Regina
> >>
> >> Armin Le Grand schrieb:
> >>
> >>Hi,
> >>>
> >>>
> >>> just checked out current version and build stopped in python
> (win7).
> >>> Message is as follows.
> >>>
> >>> Where does sqlite3.h come from? There is a folder
> >>>
> main\python\wntmsci12\misc\**build\Python-2.7.3\Doc\**includes\sqlite3
> >>> but
> >>> no sqlite3.h in there. Should it be there...?
> >>>
> >>> Can someone help please?
> >>>
> >>> --8<-
> >>>
> >>> c:\aoo\svn_trunk13\main\**python\wntmsci12\misc\build\**
> >>> python-2.7.3\modules\_sqlite\**connection.h(33)
> >>> : fatal error C1083: Cannot open include file: 'sqlite3.h': No such
> >>> file
> >>> or directory
> >>> statement.c
> >>> c:\aoo\svn_trunk13\main\**python\wntmsci12\misc\build\**
> >>> python-2.7.3\modules\_sqlite\**connection.h(33)
> >>> : fatal error C1083: Cannot open include file: 'sqlite3.h': No such
> >>> file
> >>> or directory
> >>> row.c
> >>> c:\aoo\svn_trunk13\main\**python\wntmsci12\misc\build\**
> >>> python-2.7.3\modules\_sqlite\**connection.h(33)
> >>> : fatal error C1083: Cannot open include file: 'sqlite3.h': No such
> >>> file
> >>> or directory
> >>> module.c
> >>> c:\aoo\svn_trunk13\main\**python\wntmsci12\misc\build\**
> >>> python-2.7.3\modules\_sqlite\**connection.h(33)
> >>> : fatal error C1083: Cannot open include file: 'sqlite3.h': No such
> >>> file
> >>> or directory
> >>> microprotocols.c
> >>> c:\aoo\svn_trunk13\main\**python\wntmsci12\misc\build\**
> >>> python-2.7.3\modules\_sqlite\**connection.h(33)
> >>> : fatal error C1083: Cannot open include file: 'sqlite3.h': No such
> >>> file
> >>> or directory
> >>> cursor.c
> >>> c:\aoo\svn_trunk13\main\**python\wntmsci12\misc\build\**
> >>> python-2.7.3\modules\_sqlite\**connection.h

Re: [Call-for-​​Review][Calc]Data validity works incorrectly with criteria "Allow text length" for numbers

2012-08-01 Thread Lei Wang
Herbert, thank you for applying the patch. I planed to do it. But after
merging this patch and updating to latest trunk code, I can not build trunk
successfully for several days.

On Wed, Aug 1, 2012 at 9:53 PM, Herbert Duerr  wrote:

> On 25.07.2012 07:11, Zhang Lu wrote:
>
>> One fix for review.
>>
>> https://issues.apache.org/ooo/**show_bug.cgi?id=93128
>> [...]
>>
>> Root cause: There is no flow to handle a real number when selecting string
>> length operation
>>
>> Solution: if operation is string length type, to get the number's length,
>> and consider it as a string.
>>
>
> Great! I reviewed, tested and applied your patch.
>
> Herbert
>


Re: request for enchancement of the define name function in calc

2012-08-08 Thread Lei Wang
Hi,

May be Shao Zhi do not clearly state his proposal. Let me try again.

Excel 2007 can define same name for different sheet. When AOO loading a
xlsx file which has duplicated defined name, AOO will only change the name.
But any other place which uses the defined name is not changed, which will
cause problems.

We want to do some enhancement. This enhancement will be completed in 2
steps.

In step 1, we want to just focus on the interoperability with sheet scoped
defined name in Excel.
When user open a Excel file which has range based defined name, the
duplicated range name will be kept. AOO will use sheet scoped name in prior
to workbook scoped name when do calculation. And some indicator is shown in
name define dialog.
In step 1 we will not modify the ODF file format. When save Excel xls/xlsx
file with sheet scoped defined name to ods file, AOO will rename sheet
scoped defined name as "sheet_name" plus "defined name", like
SheetName_DefinedName.

In step 2, we want to support create worksheet scope defined name from GUI.
At that time, we will modify ODF file format to save sheet scoped range
name in ods. We will refer the file format from LibreOffice if their
implementation is in ODF standard or ODF standard candidate.


On Wed, Aug 8, 2012 at 5:00 PM, Regina Henschel wrote:

> Hi shzh zhao,
>
> there is no need for modifying ODF, named-expressions with scope on one
> sheet are already specified and LibreOffice reads and writes such documents.
>
> I think the order should be the other way round. First make AOO read and
> write such named-expressions in ODF and then improve the import and export
> filter.
>
> Kind regards
> Regina
>
> shzh zhao schrieb:
>
>  hi,
>>
>> here is an interoperability issue in Aoo.
>> When loading VBA that contains defined name in Aoo, the names are changed
>> to a new one if the name is limited
>> in a worksheet in MS office.This will cause big problem.
>>
>> After my investigation,I found it is an limitation of Aoo. Because MS
>> Excel
>> 2003 can support worksheet scope defined name. but it can't be set in UI.
>> and Excel 2007 can define duplicate name for different sheet in its name
>> manager dialog.
>> When AOO loading a xlsx/xls file which has duplicated defined name, AOO
>> will only change the name to a unique one. But any other place which uses
>> the defined name is not changed, this is the root cause.
>>
>> this enchancement will be completed in 2 steps.
>> in Currently step, just focus on the interoperability of MS defined
>> name.,and not modify the ODF file format.
>>
>> if MS office defined range names with a sheet or a work book,import it in
>> Aoo,
>> make the name of work book in the original,but with a flag of global
>> name,for example,the name is "Name_1",it will be "Name_1" as before in
>> the define name dialog.
>> make the name of work sheet to the original,but with a flag of sheet
>> name,for
>> example,the name is "Name_1",it will be "Name_1 (sheet 1)" in the define
>> name
>> dialog if the name is defined in the sheet 1.
>>
>> here is the issue link:
>> https://issues.apache.org/ooo/**show_bug.cgi?id=120478
>>
>>
>


Re: request for enchancement of the define name function in calc

2012-08-08 Thread Lei Wang
Hi Regina

I saw your comments in https://issues.apache.org/ooo/show_bug.cgi?id=120478

It is glad to know that ODF1.2 support sheet scoped defined name. It is
very important to comply with ODF1.2. So our plan will be changed to
Step 1, support interoperability with sheet scoped defined name in Excel.
Because the solution is ready. it is our first priority.
Step 2, support loading and saving ods file for sheet scoped defined name.
We will put it in our AOO3.5 plan.
Step 3, support create sheet scoped defined name in GUI in AOO.

On Wed, Aug 8, 2012 at 5:00 PM, Regina Henschel wrote:

> Hi shzh zhao,
>
> there is no need for modifying ODF, named-expressions with scope on one
> sheet are already specified and LibreOffice reads and writes such documents.
>
> I think the order should be the other way round. First make AOO read and
> write such named-expressions in ODF and then improve the import and export
> filter.
>
> Kind regards
> Regina
>
> shzh zhao schrieb:
>
>  hi,
>>
>> here is an interoperability issue in Aoo.
>> When loading VBA that contains defined name in Aoo, the names are changed
>> to a new one if the name is limited
>> in a worksheet in MS office.This will cause big problem.
>>
>> After my investigation,I found it is an limitation of Aoo. Because MS
>> Excel
>> 2003 can support worksheet scope defined name. but it can't be set in UI.
>> and Excel 2007 can define duplicate name for different sheet in its name
>> manager dialog.
>> When AOO loading a xlsx/xls file which has duplicated defined name, AOO
>> will only change the name to a unique one. But any other place which uses
>> the defined name is not changed, this is the root cause.
>>
>> this enchancement will be completed in 2 steps.
>> in Currently step, just focus on the interoperability of MS defined
>> name.,and not modify the ODF file format.
>>
>> if MS office defined range names with a sheet or a work book,import it in
>> Aoo,
>> make the name of work book in the original,but with a flag of global
>> name,for example,the name is "Name_1",it will be "Name_1" as before in
>> the define name dialog.
>> make the name of work sheet to the original,but with a flag of sheet
>> name,for
>> example,the name is "Name_1",it will be "Name_1 (sheet 1)" in the define
>> name
>> dialog if the name is defined in the sheet 1.
>>
>> here is the issue link:
>> https://issues.apache.org/ooo/**show_bug.cgi?id=120478
>>
>>
>


Re: request for enchancement of the define name function in calc

2012-08-14 Thread Lei Wang
Yes, it is related with defined name. But it does not related with
worksheet scoped defined name. Anyway, we will take a look at bug 119565

On Tue, Aug 14, 2012 at 1:15 PM, Jianyuan Li wrote:

> If the defined name is correctly set, formula calculation result will be
> corrected. So it is a formula issue and also a defined name issue.
>
> 2012/8/13 shzh zhao 
>
> > I think it is a formula issue and not belong to name scope range.
> >
> > 2012/8/10 Jianyuan Li 
> >
> > > Hi, Wang Lei,
> > >
> > > Below is my clarification for issue
> > > https://issues.apache.org/ooo/show_bug.cgi?id=119565. Comment is also
> > > added
> > > in Bugzilla.
> > >
> > > In Excel 2003 define a defined name as
> > > "=Sheet1!$D$3:$D$5,Sheet1!$B$3:$B$5". In this defined name, a union
> > > operator(Excel uses "," and AOO uses "~") is used to form a union area.
> > > This defined name will be passed into a formula SUM. Import them in
> AOO,
> > by
> > > Excel 2003 filter the union operator will be translated into ";" which
> is
> > > an old union operator. And SUM will take it as a parameter separator.
> So
> > > the SUM result seems correct while it is not in AOO.
> > > Union operator should be set as "~" in defined name in AOO. But a fix
> in
> > > Excel 2003 filter is not reasonable because:
> > > 1. Defined name with union(OO uses ";") created in lower version
> > > OO(OOo2.4.3) still cannot be imported correctly even if a fix is
> patched
> > in
> > > Excel 2003 filter.
> > > 2. I have checked this formula "=SUM((B3:B5,D3:D5))"(union directly
> used)
> > > created in Excel 2003. It will be imported as "=SUM((B3:B5~D3:D5))"
> which
> > > is correct. While Excel 2003 filter still imports the union as ";". But
> > as
> > > last it is "~". Core function must does something which a hint to fix
> > union
> > > issue in defined name.
> > >
> > > So please take consideration for it in the enhancement.
> > >
> > >
> > > Regards,
> > > Jianyuan
> > >
> > > 2012/8/8 Lei Wang 
> > >
> > > > Hi Regina
> > > >
> > > > I saw your comments in
> > > > https://issues.apache.org/ooo/show_bug.cgi?id=120478
> > > >
> > > > It is glad to know that ODF1.2 support sheet scoped defined name. It
> is
> > > > very important to comply with ODF1.2. So our plan will be changed to
> > > > Step 1, support interoperability with sheet scoped defined name in
> > Excel.
> > > > Because the solution is ready. it is our first priority.
> > > > Step 2, support loading and saving ods file for sheet scoped defined
> > > name.
> > > > We will put it in our AOO3.5 plan.
> > > > Step 3, support create sheet scoped defined name in GUI in AOO.
> > > >
> > > > On Wed, Aug 8, 2012 at 5:00 PM, Regina Henschel <
> > rb.hensc...@t-online.de
> > > > >wrote:
> > > >
> > > > > Hi shzh zhao,
> > > > >
> > > > > there is no need for modifying ODF, named-expressions with scope on
> > one
> > > > > sheet are already specified and LibreOffice reads and writes such
> > > > documents.
> > > > >
> > > > > I think the order should be the other way round. First make AOO
> read
> > > and
> > > > > write such named-expressions in ODF and then improve the import and
> > > > export
> > > > > filter.
> > > > >
> > > > > Kind regards
> > > > > Regina
> > > > >
> > > > > shzh zhao schrieb:
> > > > >
> > > > >  hi,
> > > > >>
> > > > >> here is an interoperability issue in Aoo.
> > > > >> When loading VBA that contains defined name in Aoo, the names are
> > > > changed
> > > > >> to a new one if the name is limited
> > > > >> in a worksheet in MS office.This will cause big problem.
> > > > >>
> > > > >> After my investigation,I found it is an limitation of Aoo. Because
> > MS
> > > > >> Excel
> > > > >> 2003 can support worksheet scope defined name. but it can't be set
> > in
> > > > UI.
> > > > >> and Excel 2007 

Re: [VOTE] Apache OpenOffice Community Graduation Vote

2012-08-20 Thread Lei Wang
+1

On Sun, Aug 19, 2012 at 11:52 PM, Rob Weir  wrote:

> Per the IPMC's "Guide to Successful Graduation" [1] this is the
> optional, but recommended, community vote for us to express our
> willingness/readiness to govern ourselves.  If this vote passes then
> we continue by drafting a charter, submitting it for IPMC endorsement,
> and then to the ASF Board for final approval.   Details can be found
> in the "Guide to Successful Graduation".
>
> Everyone in the community is encouraged to vote.  Votes from PPMC
> members and Mentors are binding.  This vote will run 72-hours.
>
>
> [ ] +1  Apache OpenOffice community is ready to graduate from the
> Apache Incubator.
> [ ] +0 Don't care.
> [ ] -1  Apache OpenOffice community is not ready to graduate from the
> Apache Incubator because...
>
>
> Regards,
>
> -Rob
>
> [1] http://incubator.apache.org/guides/graduation.html#tlp-community-vote
>


Re: [DISCUSS]: I would like to propose a new conversion mode parameter

2012-08-20 Thread Lei Wang
On Tue, Aug 21, 2012 at 4:18 AM, Marcus (OOo)  wrote:

> Am 08/20/2012 04:54 PM, schrieb Jürgen Schmidt:
>
>  OpenOffice is not only used as desktop application but also as hidden
>> part of other software and often as a conversion engine in the backend.
>>
>> OpenOffice has very good filters for many file formats and the usage as
>> a conversion engine is straight forward. And the conversion from one
>> format into another can be improved and optimized by some special
>> handling of parts of the document.
>>
>> For example external linked parts can be ignored and don't have to be
>> loaded during conversion, embedded images can be simply copied etc.
>>
>> I would like to improve AOO for this kind of usage by introducing a new
>> parameter "-conversionmode". It's not comparable with the command line
>> parameter "-headless" or the "hidden" property for loadComponentFromUrl().
>>
>> The intention of this new global option is to have it available
>> everywhere in the underlying code to optimize the performance of the
>> conversion.
>>
>
> Sounds reasonable. However, especially with the previous paragraph I don't
> know if I understood right. Do you want to simply make the import/export of
> docs faster when AOO isn't running in graphical mode?
>
> Would be great if you can fill this with some more details.


For some enterprise user, AOO is used as a document conversion service in
backend. For an example, convert MS 2003 binary file format to ODF file
format. This conversion service does not need  GUI. And user can not
interrupt the process, which bring performance improvement opportunity
which Jurgen mentioned.

>
>
>  This should have no influence/impact on the normal workflow but will
>> help to make AOO potentially more attractive for backend usage. Means it
>> will help to grow the broader eco-system around AOO.
>>
>
> Thanks
>
> Marcus
>


Re: [Call for review][Calc]Featue enchancement- Name Scope enhancement for spreadsheet

2012-08-31 Thread Lei Wang
I have reviewed the codes. After communicated with shzh zhao, he did some
modification and provide a new patch.

The new patch looks good. I committed the patch in revision
1379349

Thanks Shao Zhi.

On Tue, Aug 21, 2012 at 11:09 AM, shzh zhao  wrote:

> hi,
>
> MS Excel can support worksheet/workbook scope defined name,but Aoo can not
> support such feature.
> https://issues.apache.org/ooo/show_bug.cgi?id=120478
> the specification is added here
>
> http://wiki.openoffice.org/wiki/Calc/Features/Calc_name_range_enchancement%28step1%29
>
> I have create patches for this issue.
> Now Aoo can import MS 2003/2007,ODF defined name ranges.
> and can export the correct content to MS 2003 and ODF file.
>
> Please help review it, thanks.
> --
> *
>
>
> mailto: *aoo.zhaos...@gmail.com 
>  
>


[Call for Test] Enhancement 120478 is done, support sheet scoped named ranges in Calc

2012-08-31 Thread Lei Wang
Hi,

The  enhancement 120478(https://issues.apache.org/ooo/show_bug.cgi?id=120478)
is done,  support sheet scoped named ranges in Calc.

Code is committed in revision
1379349The
build will be ready.

Please test it when build is ready. Any problem please open bugs or
send mail to discuss. Thanks



The description of this enhancement is

http://wiki.openoffice.org/wiki/Calc/Features/Calc_name_range_enchancement%28step1%29


Re: svn commit: r1379349 - in /incubator/ooo/trunk/main: offapi/com/sun/star/sheet/ offapi/type_reference/ oox/inc/oox/xls/ oox/source/xls/ sc/inc/ sc/source/core/data/ sc/source/core/tool/ sc/source/

2012-09-03 Thread Lei Wang
Hi Ariel

Thanks for your suggestion. I will work with Zhao Shao Zhi to add 2 new
interfaces instead of adding new member functions to the existed interface.

BTW,

Why there are duplicated codes in binfilter\inc\bf_sc and sc\inc?

On Mon, Sep 3, 2012 at 12:54 PM, Ariel Constenla-Haile
wrote:

> Hi
>
> On Fri, Aug 31, 2012 at 08:11:10AM -, l...@apache.org wrote:
> > Author: leiw
> > Date: Fri Aug 31 08:11:09 2012
> > New Revision: 1379349
> >
> > URL: http://svn.apache.org/viewvc?rev=1379349&view=rev
> > Log:
> > #i120478 Enhancement request: support sheet scoped named ranges in Calc
> >
> >   Patch by: zhaoshzh (Zhao Shao Zhi)
> >   Review by: Wang Lei
>
> This commit breaks the build in binfilter, its changes weren't applied
> to that module. See
> http://svn.apache.org/viewvc?view=revision&revision=1379914 I added
> a dummy implementation only to make it build.
>
>
> >
> > Modified:
> > incubator/ooo/trunk/main/offapi/com/sun/star/sheet/XNamedRange.idl
> > incubator/ooo/trunk/main/offapi/com/sun/star/sheet/XNamedRanges.idl
> > incubator/ooo/trunk/main/offapi/type_reference/types.rdb
>
> trunk is still in 3.*, IMO published API cannot be changed in an
> incompatible way until 4. You should add for now a XNamedRange2 and
> a XNamedRanges2. See attached patch.
>
> On the other hand, it would be nice to first discuss here API changes
> o new API design, with a proper thread taged [API].
>
>
> > Modified:
> incubator/ooo/trunk/main/offapi/com/sun/star/sheet/XNamedRanges.idl
> > URL:
> http://svn.apache.org/viewvc/incubator/ooo/trunk/main/offapi/com/sun/star/sheet/XNamedRanges.idl?rev=1379349&r1=1379348&r2=1379349&view=diff
> >
> ==
> > --- incubator/ooo/trunk/main/offapi/com/sun/star/sheet/XNamedRanges.idl
> (original)
> > +++ incubator/ooo/trunk/main/offapi/com/sun/star/sheet/XNamedRanges.idl
> Fri Aug 31 08:11:09 2012
> > @@ -44,6 +44,26 @@
> >
> >  module com {  module sun {  module star {  module sheet {
> >
>
> a) this is not published API, so don't tag it like that
> b) it should be in its own idl file
>
>
> > +published struct RangeScopeName
> > +{
> > +
>  //-
> > +
> > +/** is the OpCode of the token.
> > +
> > +@see com::sun::star::sheet::XFormulaOpCodeMapper
> > + */
> > +string ScopeName;
> > +
> > +
> //-
> > +
> > +/** is additional data in the token, depending on the OpCode.
> > +
> > +@see com::sun::star::sheet::NamedRange::TokenIndex
> > +@see com::sun::star::sheet::DatabaseRange::TokenIndex
> > + */
> > +string RangeName;
> > +};
>
> [...]
>
> > + void addNewByScopeName(
> > + [in] string aScopeName,
> > + [in] string aRangeName,
> > + [in] string aContent,
> > + [in] com::sun::star::table::CellAddress aPosition,
> > + [in] long nType );
> > +
> > + void removeByScopeName( [in] string aScopeName, [in] string
> aRangeName );
> > +
> > + boolean hasByScopeName( [in] string aScopeName, [in] string
> aRangeName );
> > +
> > + any getByScopeName( [in] string aScopeName, [in] string aRangeName
> )
> > + raises(
> com::sun::star::container::NoSuchElementException,
> > +
> com::sun::star::lang::WrappedTargetException );
>
>
> I don't get this, why two string parameters aScopeName and aRangeName,
> and not one RangeScopeName? I might be missing something.
>
>
> Regards
> --
> Ariel Constenla-Haile
> La Plata, Argentina
>


Re: Duplicate code in module binfilter [was: Re: svn commit: r1379349 - in /incubator/ooo/trunk/main: offapi/com/sun/star/sheet/ offapi/type_reference/ oox/inc/oox/xls/ oox/source/xls/ sc/inc/ sc/sour

2012-09-03 Thread Lei Wang
Hi,

So we have plan to remove import/export code from application
modules(sw,sc,sd...) and implement import/export function in binfilter. Is
there any document about this feature? What's the current status ?

On Mon, Sep 3, 2012 at 10:45 PM, Oliver-Rainer Wittmann <
orwittm...@googlemail.com> wrote:

> Hi,
>
> On 03.09.2012 12:35, Lei Wang wrote:
>
>> [snip]
>>
>> Why there are duplicated codes in binfilter\inc\bf_sc and sc\inc?
>>
>>
> The module binfilter is more or less a stripped version of the complete
> code in order to get rid of the import/export code for our former used
> native binary file format in the rest of the modules.
> Thus, it is quite natural that we have code duplications in this module.
>
> Best regards, Oliver.
>


Re: [Call-for-Review]Bug 119487 - [From Symphony]Images lose macro association when open Excel file in AOO

2012-09-07 Thread Lei Wang
I just review your code. I have one question. When loading a xls file with
a picture which does not have any related macro, will SetSimpleMacro(true)
bring side effect.

On Thu, Sep 6, 2012 at 2:46 PM, Chen Peng  wrote:

> Hi All,
>  I have fixed a bug about macro doesn't work on images, as shown in
> below:
>*Bug 119487*
>  - [From
> Symphony]Images lose macro association when open Excel file in AOO
>https://issues.apache.org/ooo/show_bug.cgi?id=119487
>
>Root Cause:
> Macro on picture is supported by VBA, should set the related
> flag to true.
>Resolution:
> Set the SimpleMacro flag to true to enable the macro on
> picture.
>
> Anyone help to review the fix will be appreciated, thanks!
>


Re: [Call for Review]121058 - [From Symphony]To open a sample file contains chart with large data source can lead to Symphony crash

2012-09-21 Thread Lei Wang
I have reviewed your patch. It looks good. I submitted it.

Thanks for your patch.

On Fri, Sep 21, 2012 at 2:46 PM, Clarence GUO wrote:

> HI~
> Have a code review request,
> https://issues.apache.org/ooo/show_bug.cgi?id=121058.
>
> Thanks & BRs,
> Clarence
>


Re: [Call for Review]120962 - [From Symphony]Chart data lost if the source data refers to a range name which is defined as a reference formula

2012-09-21 Thread Lei Wang
I have reviewed your patch. It looks good. I submitted it.

Thanks for your patch.

On Fri, Sep 21, 2012 at 2:29 PM, Clarence GUO wrote:

> HI~
> I have a code review request,
> https://issues.apache.org/ooo/show_bug.cgi?id=120962
> This defect is indeed a feature gap. Chart of AOO doesn't support range
> name which use a reference formula, not only in UI, but also in core
> function and filter.
> Although it needs a total solution to make the feature available, I still
> want this temporary solution at a bug fix level because it needs some time
> to implement the feature. The fix will translate a range name which use a
> reference formula to a actural range. So that means after saving, the range
> instead of the formula will be saved, the original formula in chart range
> will be lost.
>
> Thanks & BRs
> Clarence
>


Re: Application form for Conference

2012-10-08 Thread Lei Wang
Forwarded Oliver's mail


-- Forwarded message --
From: Oliver-Rainer Wittmann 
Date: Fri, Oct 5, 2012 at 3:27 PM
Subject: Re: ApacheCon EU 2012
To: ooo-dev@incubator.apache.org
Cc: gary_domke 


Hi Gary,

please help us and use the application form to apply for a travel expense
subsidy. Otherwise it would be quite hard to consider your application.

The application form is:

> You need to apply for the travel expense subsidy by sending an email to the
> public mailing list  until 2012-10-12, 12:00
> (Central European time, GMT+2).
> The subject of this email have to be "[ACEU 2012 - travel subsidy]
> ".
> In the content of the email please fill the following fields:
> - full name
> - email address
> - affiliation to the OpenOffice community (something like: "committer",
> "user", "contributing X", "translator", ...)
> - Apache ID (if available)
> - accepted or stand-by speaker at ACEU?
> - description why applying for the ticket discount and why support is
> needed
> - job or eduation status (something like: "student", "employee",
> "freeflancer", ...)
> - estimated travel expense
> - estimated needed accommodation - # of nights
> - other available funding (something like: "corporate", "ACEU - TAC", ...)
> - applying for 300,00 EUR or 600,00 EUR?
>


Best regards, Oliver.


On 04.10.2012 18:40, gary_domke wrote:

> Dear Olive,
>
>   My name is Gary E. Domke.  I've been an Open Office user since the
> inception of the community and program (incubator) and do truly love the
> concept, the product and the nature of the contributors.  I'm 66 years old,
> a "semi-retired" executive vice president of a stock brokerage and
> investment banking firm (somewhat dependent on my social security checks to
> put food on my table).  I'm slightly more technologically competent than
> most people my age, have built several computers starting with Heathkit and
> Commodore PET products back in the '70s.  I've written a couple of tiny and
> unsophisticated programs in Basic and C+ at various times that served my
> purpose.  I helped establish the original MIRC and was sysop for the
> #new2mirc training link visited by thousands of users as a first step to
> using Internet Relay Chat.Even with that very limited (self - taught)
> level of knowledge, I'm frequently asked to assist clients, family and
> friends with computer issues, problems or to provide guidance about
> purchases of hardware or selection of appropriate software.
>
>  I think a forum like ApacheCon EU might benefit from input at my level
> of expertise.  I could well be the "proto-typical" end user of Open Office.
> I'm a gifted public speaker, friendly, outgoing and reasonably personable.
>
>  Following a couple of unfortunate personal events, I no longer have
> the
> resources to pay for travel outside of the range of a couple of tanks of
> gasoline.
>
>  I'd love to attend and believe I could make a contribution.  Lacking
> any
> personal financial resources of significance and without any corporate or
> TAC funding,  I'd need the full subsidy, discount and 600,000EUR to be able
> to make the trip.  It'd be great if I could stay for several nights.
>
>  Every product development process should have input from typical
> end-users.  I'm about as typical as you'll find anywhere on the planet.
>
>  Gary
>
> gary_do...@sbcglobal.net
>
>
>

On Mon, Oct 8, 2012 at 12:05 PM, catriona  wrote:

> Would you please send me an application form for Travel to Germany
> to attend the conference.
> Yours Sincerely,
> Catriona
>


Re: [UX] - Design Exploration - Dockable Task Pane (Sidebar) - Tab User Interface Design

2012-11-01 Thread Lei Wang
I like beveled tab option.

One question, what kinds of content should be put into the sidebar? A
navigator window or a style list window should be put into sidebar as a tab
panel.

On Thu, Nov 1, 2012 at 4:59 PM, Kevin Grignon wrote:

> Hello All,
>
> I've been exploring design alternatives for adding navigation tabs to the
> docked task pane.
>
> See:
>
> http://wiki.openoffice.org/wiki/AOO_UX_Design_Exploration_-_Docked_Task_Pane_Container_-_Tab_User_Interface_Design
>
> Capture any thoughts or feedback in the discussion section of the wiki
> page.
>
> Thanks,
> Kevin
>


Re: AOO.Next IBM Priorities

2012-11-01 Thread Lei Wang
No, this is property panel in the sidebar, not the sidebar framework.

The sidebar framework looks like:
http://wiki.openoffice.org/wiki/AOO_UX_Design_Exploration_-_Docked_Task_Pane_Container_-_Tab_User_Interface_Design

On Fri, Nov 2, 2012 at 10:29 AM, Jorg Schmidt  wrote:

>
> > -- A major UI enhancement, a sidebar framework for the editors, ported
> > over from Symphony, and including an API.
>
>
> I hope I understand correctly that you mean the right side in the picture
> http://www.file-extensions.org/imgs/app-picture/4561/ibm-lotus-symphony.gif(OK,
> this picture is symphony but the same in AOO). In the picture namend "Text
> and
> CellProperties".
>
> In this case, my question is:
>
> Is there already a compiled test version for Windows?
>
> (I do not necessarily mean a formal trial rather a snapshot, my personal
> problem
> is only that I could not compile and therefore need a compiled version.)
>
>
> Greetings,
> Jorg
>
>