Sounds reasonable to me. As long as we are breaking backwards compatibility in
the next release might as well make the api more consistent.
-Dave
> On Jul 20, 2018, at 8:43 AM, Noel O'Boyle wrote:
>
> May I suggest that we replace Unset functions for flags (e.g.
> UnsetAromaticPerceived()), with a parameter to the Set functions (e.g.
> SetAromaticPerceived(false))? This is already the case for some of the Set
> functions. This would tidy the API a bit, and ensure that we actually have
> the ability to both set and unset flags (which wasn't the case for at least
> some flags). I think user impact will be minimal.
>
> If we wanted to go further, then we could replace the all of these functions
> with just two: SetFlag(bits) and UnsetFlag(bits), where we would provide an
> enum for the bits.
>
> Regards,
> - Noel
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org!
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsdm.link%2Fslashdotdata=01%7C01%7Cdkoes%40pitt.edu%7C986df2d81e3d4a03d40808d5ee3e650e%7C9ef9f489e0a04eeb87cc3a526112fd0d%7C1sdata=CJiZ0FwQCbTjPTXwxHqZt0XbUmWC6vzDAPqjj7JoOYk%3Dreserved=0
> ___
> OpenBabel-Devel mailing list
> OpenBabel-Devel@lists.sourceforge.net
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.sourceforge.net%2Flists%2Flistinfo%2Fopenbabel-develdata=01%7C01%7Cdkoes%40pitt.edu%7C986df2d81e3d4a03d40808d5ee3e650e%7C9ef9f489e0a04eeb87cc3a526112fd0d%7C1sdata=UGIXD0kK%2F3KJh5b4HjoG8VxdXxtapC3jRrgZctNhX28%3Dreserved=0
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
OpenBabel-Devel mailing list
OpenBabel-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbabel-devel
