Re: [Openchrome-devel] KMS branch
El 13/12/15 a las 08:07, Benno Schulenberg escribió: Okay. Good plan. Maybe post now and then the current state of your patch set on this list? That sounds about right. Currently I have a patchset that cleans up typedefs, but I'll rework it (probably next Thursday, because I have an exam on Wednesday and I should be studying) since it introduces longer than 80 columns lines and will be likely rejected because of that. Fixing the style issues would probably take no more than 2-3 weeks. I was planning on sending a patchset for each issue. Regards, Benno Regards, Mario. ___ Openchrome-devel mailing list Openchrome-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/openchrome-devel
Re: [Openchrome-devel] KMS branch
On Sat, Dec 12, 2015, at 20:48, Mario J. Rugiero wrote: > So my approach will be to cleanup the current driver for > checkpatch and sparse warnings, so I have something clean to base the > work on, and manually study James' changes to start porting them. > I'm aiming at doing things gradually and getting the driver merged step > by step, not as a single huge patchset, because that's unlikely to work. Okay. Good plan. Maybe post now and then the current state of your patch set on this list? Regards, Benno -- http://www.fastmail.com - Faster than the air-speed velocity of an unladen european swallow ___ Openchrome-devel mailing list Openchrome-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/openchrome-devel
Re: [Openchrome-devel] KMS branch
El 12/12/15 a las 09:13, Benno Schulenberg escribió: On Sat, Dec 12, 2015, at 05:11, Mario J. Rugiero wrote: http://lists.freedesktop.org/archives/dri-devel/2013-June/039594.html Oof. That's a long time ago. And since then there has not been another posting of this patch set? Not that I was able to find. Were you able to merge the current state of drm-next into drm-openchrome without much conflict? Actually not. Even the first patch, which is style cleanup, failed to apply. So my approach will be to cleanup the current driver for checkpatch and sparse warnings, so I have something clean to base the work on, and manually study James' changes to start porting them. I'm aiming at doing things gradually and getting the driver merged step by step, not as a single huge patchset, because that's unlikely to work. Benno Regards, Mario. ___ Openchrome-devel mailing list Openchrome-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/openchrome-devel
Re: [Openchrome-devel] KMS branch
On Sat, Dec 12, 2015, at 05:11, Mario J. Rugiero wrote: > http://lists.freedesktop.org/archives/dri-devel/2013-June/039594.html Oof. That's a long time ago. And since then there has not been another posting of this patch set? Were you able to merge the current state of drm-next into drm-openchrome without much conflict? Benno -- http://www.fastmail.com - Does exactly what it says on the tin ___ Openchrome-devel mailing list Openchrome-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/openchrome-devel
Re: [Openchrome-devel] KMS branch
El 11/12/15 a las 17:56, Benno Schulenberg escribió: Hello Mario, Hello, again. So you mean this one: http://cgit.freedesktop.org/openchrome/drm-openchrome/ Right? Indeed. URL of that thread? http://lists.freedesktop.org/archives/dri-devel/2013-June/039594.html Benno Regards, Mario. ___ Openchrome-devel mailing list Openchrome-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/openchrome-devel
Re: [Openchrome-devel] KMS branch
Hello Mario, On Thu, Dec 10, 2015, at 11:35, Mario J. Rugiero wrote: > El 10/12/15 a las 07:27, Benno Schulenberg escribió: > > Which changes are you referring to? Do you have a pointer > > into the archives? Or are you referring to kms_branch in git? > > > James Simmons' KMS branch in git. Not the xf86-video driver, but the > Linux kernel one. So you mean this one: http://cgit.freedesktop.org/openchrome/drm-openchrome/ Right? > but it was a huge set of changes and they asked for him to reorganize > them. URL of that thread? Benno -- http://www.fastmail.com - Or how I learned to stop worrying and love email again ___ Openchrome-devel mailing list Openchrome-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/openchrome-devel
Re: [Openchrome-devel] KMS branch
El 10/12/15 a las 07:27, Benno Schulenberg escribió: Hello Mario, Hello Benno Which changes are you referring to? Do you have a pointer into the archives? Or are you referring to kms_branch in git? James Simmons' KMS branch in git. Not the xf86-video driver, but the Linux kernel one. The one for xf86 is supposedly ready for (at least) wider testing. You can just try. Send a small set of style patches first, with a note that more things are coming, and see if they get accepted. OK, I wanted to avoid that because of the chance of annoying the kernel list with something that might be a public DON'T that I just didn't found out there. If James posted the patches with his signed-off line, they are GPL'ed and there is no problem with copyright. If you just make small changes in the ordering, you can keep his Signed-off-by line and add your own. If you make significant changes, you can put "Patch originally by James Simmons" and put only your own Signed-off-by line. Yes, the patches are public and he tried to get them upstreamed in its current form (so this implies at the very list he was OK with them being GPL, although I believe he might have dual licensed them to BSD too, since some of his commit messages mention compatibility with FreeBSD), but it was a huge set of changes and they asked for him to reorganize them. Apparently he didn't find the time to do so, so I'm willing to put my own. It would be a shame that after such hard work it went nowhere. I believe I'll signed them and add the originally-by line, since I'll be preparing the patches partly by hand and partly from his old branch, not directly from the patches he sent (which probably bit rot already). Regards, Benno Regards, Mario. ___ Openchrome-devel mailing list Openchrome-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/openchrome-devel
Re: [Openchrome-devel] KMS branch
Hello Mario, On Wed, Dec 9, 2015, at 07:25, Mario J. Rugiero wrote: > Hi. I noticed a lack of activity, and I'm assuming real life is taking > most of James' time. However, I'm a little bit more familiar with kernel > development and git usage now, and might make myself some time to put > his changes in shape for merging Which changes are you referring to? Do you have a pointer into the archives? Or are you referring to kms_branch in git? > First, I'd need a brief description of how is the recommended way to > submit patches to the DRM subsystem (for example, do they accept > standalone style fixes, so I could send those first?), You can just try. Send a small set of style patches first, with a note that more things are coming, and see if they get accepted. > and specifically > how to handle the copyright part, since the actual author of the code is > James, I'll just be restructuring how the patches are organized. If James posted the patches with his signed-off line, they are GPL'ed and there is no problem with copyright. If you just make small changes in the ordering, you can keep his Signed-off-by line and add your own. If you make significant changes, you can put "Patch originally by James Simmons" and put only your own Signed-off-by line. Regards, Benno -- http://www.fastmail.com - IMAP accessible web-mail ___ Openchrome-devel mailing list Openchrome-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/openchrome-devel
