[OE-core] [PATCH 1/2] enchant2: fix qa issue about staticdev

2020-01-13 Thread Chen Qi
staticdev package defaults to include ${libdir}/${BPN}/*.a, but
for enchant2, the file locates under ${libdir}/echant-2/. So fix
it to avoid the following QA issue.

  QA Issue: non -staticdev package contains static .a library: enchant2 path 
'/.../usr/lib/enchant-2/enchant_aspell.a'

Signed-off-by: Chen Qi 
---
 meta/recipes-support/enchant/enchant2_2.2.7.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-support/enchant/enchant2_2.2.7.bb 
b/meta/recipes-support/enchant/enchant2_2.2.7.bb
index bdfd738487..03db5c7fae 100644
--- a/meta/recipes-support/enchant/enchant2_2.2.7.bb
+++ b/meta/recipes-support/enchant/enchant2_2.2.7.bb
@@ -26,3 +26,4 @@ FILES_${PN} += " \
 ${datadir}/enchant-2 \
 ${libdir}/enchant-2 \
 "
+FILES_${PN}-staticdev += "${libdir}/enchant-2/*.a"
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH V4] u-boot-fw-utils: Add support for libubootenv

2020-01-13 Thread ChenQi

On 01/09/2020 05:31 PM, Stefano Babic wrote:

Hi Chen,

On 09/01/20 02:29, ChenQi wrote:

Resend as previous email forgets to add Stefano.

In case of multilib, the do_package fails with

ERROR: libubootenv-0.2-r0 do_package: QA Issue: libubootenv:
Files/directories were installed but not shipped in any package:
   /usr/lib/libubootenv.so
   /usr/lib/libubootenv.so.0.2


Thanks for reporting this - I will take care of the error in next days.

Regards,
Stefano


I've just sent out a patch to fix this problem.

Regards,
Chen Qi


Regards,
Chen Qi

On 01/03/2020 08:33 PM, Stefano Babic wrote:

libubootenv is a replacement for u-boot-fw-utils. It is
hardware-independent and provides fw_printenv and fw_setenv tools that
are full compatible with the ones provided by U-Boot. A library is
provided to access the environment from an own application.
License is LGPL-2.1 and this allow to link the library to proprietary
code. The user of the tools should install the configuration file
"fw_env.config", as he is already used to with u-boot-fw-utils. The
configuration file is compatible with u-boot-fw-utils.
A full discussion about issues on current u-boot-fw-utils can be read on
U-Boot's ML at:

http://u-boot.10912.n7.nabble.com/SWUpdate-U-Boot-environment-library-dependency-tt340530.html#none


Signed-off-by: Stefano Babic 
---
Changes since V3:
 - Update maintainers.inc (R. Purdie)
 - Add link to U-Boot's ML in commit message (R. Purdie)
Changes since V2:
 - drop .inc file (R. Burton)
Changes since V1:
 - drop PACKAGE_ARCH (M. Jansa)

   meta/conf/distro/include/maintainers.inc   |  1 +
   meta/recipes-bsp/u-boot/libubootenv_0.2.bb | 26 ++
   2 files changed, 27 insertions(+)
   create mode 100644 meta/recipes-bsp/u-boot/libubootenv_0.2.bb

diff --git a/meta/conf/distro/include/maintainers.inc
b/meta/conf/distro/include/maintainers.inc
index 39eee9475c..09453e7343 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -398,6 +398,7 @@ RECIPE_MAINTAINER_pn-libunwind = "Bruce Ashfield
"
   RECIPE_MAINTAINER_pn-liburcu = "Alexander Kanavin
"
   RECIPE_MAINTAINER_pn-liburi-perl = "Tim Orling
"
   RECIPE_MAINTAINER_pn-libusb1 = "Anuj Mittal "
+RECIPE_MAINTAINER_pn-libubootenv = "Stefano Babic "
   RECIPE_MAINTAINER_pn-libva = "Anuj Mittal "
   RECIPE_MAINTAINER_pn-libva-utils = "Anuj Mittal
"
   RECIPE_MAINTAINER_pn-libvorbis = "Tanu Kaskinen "
diff --git a/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
b/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
new file mode 100644
index 00..23230d132e
--- /dev/null
+++ b/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
@@ -0,0 +1,26 @@
+SUMMARY = "U-Boot libraries and tools to access environment"
+DEPENDS += "mtd-utils"
+
+DESCRIPTION = "This package contains tools and libraries to read \
+and modify U-Boot environment. \
+It provides a hardware-independent replacement for fw_printenv/setenv
utilities \
+provided by U-Boot"
+
+HOMEPAGE = "https://github.com/sbabic/libubootenv;
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM =
"file://Licenses/lgpl-2.1.txt;md5=4fbd65380cdd255951079008b364516c"
+SECTION = "libs"
+
+SRC_URI = "git://github.com/sbabic/libubootenv;protocol=https"
+SRCREV = "bf6ff631c0e38cede67268ceb8bf1383b5f8848e"
+
+S = "${WORKDIR}/git"
+
+inherit cmake
+
+EXTRA_OECMAKE = "-DCMAKE_BUILD_TYPE=Release"
+
+PROVIDES += "u-boot-fw-utils"
+RPROVIDES_${PN} += "u-boot-fw-utils"
+
+BBCLASSEXTEND = "native"






--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH 2/2] libubootenv: do not use hardcoded lib

2020-01-13 Thread Chen Qi
Avoid using hardcoded lib to fix the following error.

  ERROR: libubootenv-0.2-r0 do_package: QA Issue: libubootenv: 
Files/directories were installed but not shipped in any package:
/usr/lib/libubootenv.so
/usr/lib/libubootenv.so.0.2

Signed-off-by: Chen Qi 
---
 ...keLists.txt-do-not-use-hardcoded-lib.patch | 28 +++
 meta/recipes-bsp/u-boot/libubootenv_0.2.bb|  3 +-
 2 files changed, 30 insertions(+), 1 deletion(-)
 create mode 100644 
meta/recipes-bsp/u-boot/libubootenv/0001-CMakeLists.txt-do-not-use-hardcoded-lib.patch

diff --git 
a/meta/recipes-bsp/u-boot/libubootenv/0001-CMakeLists.txt-do-not-use-hardcoded-lib.patch
 
b/meta/recipes-bsp/u-boot/libubootenv/0001-CMakeLists.txt-do-not-use-hardcoded-lib.patch
new file mode 100644
index 00..6d68fd6add
--- /dev/null
+++ 
b/meta/recipes-bsp/u-boot/libubootenv/0001-CMakeLists.txt-do-not-use-hardcoded-lib.patch
@@ -0,0 +1,28 @@
+From e350e181b16c99c7d1c5a81c8255a315898c94dd Mon Sep 17 00:00:00 2001
+From: Chen Qi 
+Date: Mon, 13 Jan 2020 21:49:36 -0800
+Subject: [PATCH] CMakeLists.txt: do not use hardcoded lib
+
+Upstream-Status: Pending
+
+Signed-off-by: Chen Qi 
+---
+ src/CMakeLists.txt | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
+index 051732b..d4134b7 100644
+--- a/src/CMakeLists.txt
 b/src/CMakeLists.txt
+@@ -19,7 +19,7 @@ add_executable(fw_setenv fw_setenv.c)
+ target_link_libraries(fw_printenv ubootenv z)
+ target_link_libraries(fw_setenv ubootenv z)
+ 
+-install (TARGETS ubootenv DESTINATION lib)
++install (TARGETS ubootenv DESTINATION ${CMAKE_INSTALL_LIBDIR})
+ install (FILES libuboot.h DESTINATION include)
+ install (TARGETS fw_printenv DESTINATION bin)
+ install (TARGETS fw_setenv DESTINATION bin)
+-- 
+2.21.0
+
diff --git a/meta/recipes-bsp/u-boot/libubootenv_0.2.bb 
b/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
index 23230d132e..31bdaf3ded 100644
--- a/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
+++ b/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
@@ -11,7 +11,8 @@ LICENSE = "LGPL-2.1"
 LIC_FILES_CHKSUM = 
"file://Licenses/lgpl-2.1.txt;md5=4fbd65380cdd255951079008b364516c"
 SECTION = "libs"
 
-SRC_URI = "git://github.com/sbabic/libubootenv;protocol=https"
+SRC_URI = "git://github.com/sbabic/libubootenv;protocol=https \
+   file://0001-CMakeLists.txt-do-not-use-hardcoded-lib.patch"
 SRCREV = "bf6ff631c0e38cede67268ceb8bf1383b5f8848e"
 
 S = "${WORKDIR}/git"
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] ✗ patchtest: failure for gstreamer1.0: Enable debug in builds

2020-01-13 Thread Khem Raj

On 1/13/20 8:02 PM, Patchwork wrote:

== Series Details ==

Series: gstreamer1.0: Enable debug in builds
Revision: 1
URL   : https://patchwork.openembedded.org/series/21994/
State : failure



this applies on top of master-next, tool is confused a bit here.



== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue Series does not apply on top of target branch 
[test_series_merge_on_head]
   Suggested fixRebase your series on top of targeted branch
   Targeted branch  master (currently at b6d4150f9c)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines: 
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe



--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] ✗ patchtest: failure for gstreamer1.0: Enable debug in builds

2020-01-13 Thread Patchwork
== Series Details ==

Series: gstreamer1.0: Enable debug in builds
Revision: 1
URL   : https://patchwork.openembedded.org/series/21994/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue Series does not apply on top of target branch 
[test_series_merge_on_head] 
  Suggested fixRebase your series on top of targeted branch
  Targeted branch  master (currently at b6d4150f9c)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines: 
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH] gstreamer1.0: Enable debug in builds

2020-01-13 Thread Khem Raj
Packages like gst-shark needs this option to be on

Fixes

| checking whether the GStreamer debugging system is enabled... no
| configure: error: Tracers require GStreamer debug support. Rebuild GStreamer 
core with --enable-gst-debu
g.

Signed-off-by: Khem Raj 
Cc: Carlos Rafael Giani 
---
 meta/recipes-multimedia/gstreamer/gstreamer1.0_1.16.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.16.1.bb 
b/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.16.1.bb
index dc3e8ffafd..5ac97f1ec9 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.16.1.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.16.1.bb
@@ -26,7 +26,7 @@ SRC_URI[md5sum] = "c505fb818b36988daaa846e9e63eabe8"
 SRC_URI[sha256sum] = 
"02211c3447c4daa55919c5c0f43a82a6fbb51740d57fc3af0639d46f1cf4377d"
 
 PACKAGECONFIG ??= "${@bb.utils.contains('PTEST_ENABLED', '1', 'tests', '', d)} 
\
-   tools"
+   tools debug"
 
 PACKAGECONFIG[debug] = "-Dgst_debug=true,-Dgst_debug=false"
 PACKAGECONFIG[tracer-hooks] = "-Dtracer_hooks=true,-Dtracer_hooks=false"
-- 
2.24.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH] tcp-wrappers: Remove redundant forward declarations

2020-01-13 Thread Khem Raj
fgets is already in stdio.h, and it can confuse the compilers when using
fortified headers, therefore remove the declarations

Signed-off-by: Khem Raj 
---
 ...0001-Remove-fgets-extern-declaration.patch | 43 +++
 .../tcp-wrappers/tcp-wrappers_7.6.bb  |  1 +
 2 files changed, 44 insertions(+)
 create mode 100644 
meta/recipes-extended/tcp-wrappers/tcp-wrappers-7.6/0001-Remove-fgets-extern-declaration.patch

diff --git 
a/meta/recipes-extended/tcp-wrappers/tcp-wrappers-7.6/0001-Remove-fgets-extern-declaration.patch
 
b/meta/recipes-extended/tcp-wrappers/tcp-wrappers-7.6/0001-Remove-fgets-extern-declaration.patch
new file mode 100644
index 00..88c8d9cae7
--- /dev/null
+++ 
b/meta/recipes-extended/tcp-wrappers/tcp-wrappers-7.6/0001-Remove-fgets-extern-declaration.patch
@@ -0,0 +1,43 @@
+From 24d10919b4bc5e37a2d80b274d2cd2ee77b03549 Mon Sep 17 00:00:00 2001
+From: Khem Raj 
+Date: Mon, 13 Jan 2020 14:25:47 -0800
+Subject: [PATCH] Remove fgets() extern declaration
+
+These sources already include  which should bring the correct
+declaration
+
+Upstream-Status: Pending
+Signed-off-by: Khem Raj 
+---
+ hosts_access.c | 1 -
+ misc.c | 2 --
+ 2 files changed, 3 deletions(-)
+
+diff --git a/hosts_access.c b/hosts_access.c
+index 329b35e..0133e5e 100644
+--- a/hosts_access.c
 b/hosts_access.c
+@@ -44,7 +44,6 @@ static char sccsid[] = "@(#) hosts_access.c 1.21 97/02/12 
02:13:22";
+ #include 
+ #endif
+ 
+-extern char *fgets();
+ extern int errno;
+ 
+ #ifndef   INADDR_NONE
+diff --git a/misc.c b/misc.c
+index 74ca319..9a5e73a 100644
+--- a/misc.c
 b/misc.c
+@@ -18,8 +18,6 @@ static char sccsic[] = "@(#) misc.c 1.2 96/02/11 17:01:29";
+ 
+ #include "tcpd.h"
+ 
+-extern char *fgets();
+-
+ #ifndef   INADDR_NONE
+ #define   INADDR_NONE (-1)/* XXX should be 0x */
+ #endif
+-- 
+2.24.1
+
diff --git a/meta/recipes-extended/tcp-wrappers/tcp-wrappers_7.6.bb 
b/meta/recipes-extended/tcp-wrappers/tcp-wrappers_7.6.bb
index bd0c84c242..e903b9db14 100644
--- a/meta/recipes-extended/tcp-wrappers/tcp-wrappers_7.6.bb
+++ b/meta/recipes-extended/tcp-wrappers/tcp-wrappers_7.6.bb
@@ -49,6 +49,7 @@ SRC_URI = 
"http://ftp.porcupine.org/pub/security/tcp_wrappers_${PV}.tar.gz \
file://0001-Fix-build-with-clang.patch \
file://fix_warnings.patch \
file://fix_warnings2.patch \
+   file://0001-Remove-fgets-extern-declaration.patch \
"
 
 SRC_URI[md5sum] = "e6fa25f71226d090f34de3f6b122fb5a"
-- 
2.24.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] Yocto Project Newcomer & Unassigned Bugs - Help Needed

2020-01-13 Thread sjolley.yp.pm
All,

 

The triage team is starting to try and collect up and classify bugs which a
newcomer to the project would be able to work on in a way which means people
can find them. They're being listed on the triage page under the appropriate
heading:

 

https://wiki.yoctoproject.org/wiki/Bug_Triage#Newcomer_Bugs

 

The idea is these bugs should be straight forward for a person to help work
on who doesn't have deep experience with the project.  If anyone can help,
please take ownership of the bug and send patches!  If anyone needs
help/advice there are people on irc who can likely do so, or some of the
more experienced contributors will likely be happy to help too.

 

Also, the triage team meets weekly and does its best to handle the bugs
reported into the Bugzilla. The number of people attending that meeting has
fallen, as have the number of people available to help fix bugs. One of the
things we hear users report is they don't know how to help. We (the triage
team) are therefore going to start reporting out the currently 293
unassigned or newcomer bugs.

 

We're hoping people may be able to spare some time now and again to help out
with these.  Bugs are split into two types, "true bugs" where things don't
work as they should and "enhancements" which are features we'd want to add
to the system.  There are also roughly four different "priority" classes
right now, "3.1", "3.2, "3.99" and "Future", the more pressing/urgent issues
being in "3.1" and then "3.2".

 

Please review this link and if a bug is something you would be able to help
with either take ownership of the bug, or send me (sjolley.yp...@gmail.com
 ) an e-mail with the bug number you would
like and I will assign it to you (please make sure you have a Bugzilla
account).  The list is at:
https://wiki.yoctoproject.org/wiki/Bug_Triage#Unassigned_or_Newcomer_Bugs

 

Thanks,

 

Stephen K. Jolley

Yocto Project Project Manager

*Cell:(208) 244-4460

* Email:  sjolley.yp...@gmail.com
 

 

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH] kernel-fitimage: avoid duplicated items in KERNEL_IMAGETYPE_FOR_MAKE

2020-01-13 Thread liu . ming50
From: Ming Liu 

When replacementtype is already in KERNEL_IMAGETYPE_FOR_MAKE, we do not
have to replace fitImage with it again, that will lead to duplicated
items in KERNEL_IMAGETYPE_FOR_MAKE.

Signed-off-by: Ming Liu 
---
 meta/classes/kernel-fitimage.bbclass | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/meta/classes/kernel-fitimage.bbclass 
b/meta/classes/kernel-fitimage.bbclass
index ec18a3d..acdd679 100644
--- a/meta/classes/kernel-fitimage.bbclass
+++ b/meta/classes/kernel-fitimage.bbclass
@@ -25,8 +25,12 @@ python __anonymous () {
 # to kernel.bbclass . We have to override it, since we pack zImage
 # (at least for now) into the fitImage .
 typeformake = d.getVar("KERNEL_IMAGETYPE_FOR_MAKE") or ""
-if 'fitImage' in typeformake.split():
-d.setVar('KERNEL_IMAGETYPE_FOR_MAKE', 
typeformake.replace('fitImage', replacementtype))
+typeformakelist = typeformake.split()
+if 'fitImage' in typeformakelist:
+if replacementtype in typeformakelist:
+d.setVar('KERNEL_IMAGETYPE_FOR_MAKE', 
typeformake.replace('fitImage', ''))
+else:
+d.setVar('KERNEL_IMAGETYPE_FOR_MAKE', 
typeformake.replace('fitImage', replacementtype))
 
 image = d.getVar('INITRAMFS_IMAGE')
 if image:
-- 
2.7.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH] meta: gdk-pixbuf: add man packageconfig

2020-01-13 Thread Alexander Kanavin
The correct way to configure this is to inherit manpages class, and name
the option 'manpages' as well.

Alex

On Mon, 13 Jan 2020 at 22:10, Maxime Roussin-Bélanger <
maxime.roussinbelan...@gmail.com> wrote:

> The current default for the meson configuration is to build
> the man. It will only do it if it finds the xsltproc binary
> and man option (default: on).
>
> Adding the packageconfig make sure that xsltproc will be
> found in the correct path (recipe-sysroot-native) and that
> the docbook can be used.
>
> The docbook is needed because xsltproc is used with the
> --nonet option, which prevents the uses of the internet to
> fetch DFD's.
>
> This recipe has been working for probably everyone with the
> current configuration, however if for some reason xsltproc
> can be found inside PATH, meson will use it.
>
> Signed-off-by: Maxime Roussin-Bélanger 
> ---
>  meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb
> b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb
> index 699c4ecd0b..f6cc25cd8c 100644
> --- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb
> +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb
> @@ -53,6 +53,7 @@ PACKAGECONFIG[png] = "-Dpng=true,-Dpng=false,libpng"
>  PACKAGECONFIG[jpeg] = "-Djpeg=true,-Djpeg=false,jpeg"
>  PACKAGECONFIG[tiff] = "-Dtiff=true,-Dtiff=false,tiff"
>  PACKAGECONFIG[jpeg2000] = "-Djasper=true,-Djasper=false,jasper"
> +PACKAGECONFIG[man] = "-Dman=true,-Dman=false,libxslt-native
> docbook-xsl-stylesheets-native,"
>
>  PACKAGECONFIG[x11] = "-Dx11=true,-Dx11=false,virtual/libx11"
>
> --
> 2.20.1
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH] meta: gdk-pixbuf: add man packageconfig

2020-01-13 Thread Maxime Roussin-Bélanger
The current default for the meson configuration is to build
the man. It will only do it if it finds the xsltproc binary
and man option (default: on).

Adding the packageconfig make sure that xsltproc will be
found in the correct path (recipe-sysroot-native) and that
the docbook can be used.

The docbook is needed because xsltproc is used with the
--nonet option, which prevents the uses of the internet to
fetch DFD's.

This recipe has been working for probably everyone with the
current configuration, however if for some reason xsltproc
can be found inside PATH, meson will use it.

Signed-off-by: Maxime Roussin-Bélanger 
---
 meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb 
b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb
index 699c4ecd0b..f6cc25cd8c 100644
--- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb
+++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb
@@ -53,6 +53,7 @@ PACKAGECONFIG[png] = "-Dpng=true,-Dpng=false,libpng"
 PACKAGECONFIG[jpeg] = "-Djpeg=true,-Djpeg=false,jpeg"
 PACKAGECONFIG[tiff] = "-Dtiff=true,-Dtiff=false,tiff"
 PACKAGECONFIG[jpeg2000] = "-Djasper=true,-Djasper=false,jasper"
+PACKAGECONFIG[man] = "-Dman=true,-Dman=false,libxslt-native 
docbook-xsl-stylesheets-native,"
 
 PACKAGECONFIG[x11] = "-Dx11=true,-Dx11=false,virtual/libx11"
 
-- 
2.20.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [WIP][PATCH 01/12] gstreamer: Add common .inc files for meson based recipes

2020-01-13 Thread Khem Raj
there are some plugins in meta-multimedia which are erroring out

https://errors.yoctoproject.org/Errors/Build/96752/

On Wed, Jan 8, 2020 at 3:43 PM Carlos Rafael Giani  wrote:
>
> Sorry, I missed this message somehow. Will do that tomorrow.
>
>
> On 02.01.20 22:47, Alexander Kanavin wrote:
>
> So can you resend the patchset, without any special tags (wip/rfc etc) 
> please? To give it a run on the autobuilder.
>
> Alex
>
> On 19 Dec 2019, at 12.57, Carlos Rafael Giani  wrote:
>
> Well, alright, then let's merge this. You do have a point in that we are not 
> close to a release. Plenty of time left to fix these issues afterwards.
>
> On 19.12.19 12:54, Alexander Kanavin wrote:
>
> I read them through now, and none of them are actually a big deal that need 
> further discussion in my opinion. I’d rather get meson conversion done, and 
> handle any issues afterwards.
>
> Alex
>
> On 19 Dec 2019, at 12.46, Carlos Rafael Giani  wrote:
>
> First we should discuss the leftover TODOs I think. Since these may not be 
> trivial issues, it would be better to take a look at them and then decide on 
> a case-by-case basis whether to fix them now or later.
>
> For convenience, I copy-paste these bits from an older RFC email:
>
>
> 
>
> Noteworthy changes:
>
> - A lot of autotools/M4 related patches are just gone. Well, obviously But it 
> is surprising just how much fewer patches there are now.
>
> - gstreamer1.0-libav no longer builds its own FFmpeg copy. This was done in 
> the past because there were no stable versioned FFmpeg releases. They do 
> exist now, so in meson based builds, gst-libav just builds the actual plugin 
> code, meaning that the build time is much shorter, most of the recipe code 
> (and all of the patches) are gone (because they were FFmpeg specific), and 
> the libgstlibav.so binary in /usr/lib/gstreamer-1.0/ is much smaller. This 
> also means that FFmpeg specials do not have to be added both to the FFmpeg 
> and to the gstreamer1.0-libav recipe anymore.
>
> - gstreamer1.0-plugins.inc was replaced by gstreamer1.0-plugins-common.inc, 
> and gst-plugins-package.inc by gstreamer1.0-plugins-packaging.inc . These 
> names are clearer. gst-plugins-package.inc in particular was named that way 
> because it used to be shared between GStreamer 0.10 and 1.0 recipes. Since 
> the former are gone by now, there's no point in keeping that name.
>
> - gstreamer1.0 ptest is now done differently. Originally, make was installed 
> on the target and the Makefile was run by the run-ptest script. Now, 
> gstreamer is patched to allow for installable tests that are accompanied by 
> individual shell scripts that set up the necessary environment variables, 
> along with .test files so that the gnome-desktop-testing test runner can be 
> used in run-ptest to run the unit tests. This also makes it possible to 
> inherit from ptest-gnome in the gstreamer1.0 recipe. The patch against 
> gstreamer is necessary because by default, one runs the test by executing 
> "meson test". I don't think installing meson along with all of the necessary 
> meson.build scripts is a practical approach.
>
> - OpenGL packageconfigs now work quite differently in 
> gstreamer1.0-plugins-base, since the meson options distinguish between OpenGL 
> APIs, platforms, and windowing systems.
>
> - zlib in gstreamer1.0-plugins-base and -good is now required. I don't think 
> this is a big deal, since it is also a dependency of GLib itself, so zlib has 
> to be present on the rootfs anyway.
>
>
> There are some TODOs left that I want to bring up here for discussion:
>
> - The aforementioned PTest approach needs some review. Also, initially, I 
> thought I'd have to add PTest support to several GStreamer recipes, which is 
> why I isolated the ptest code in gstreamer1.0-ptest.inc . But it turned out 
> that only the gstreamer1.0 recipe needs it. I am unsure if I should just 
> merge that .inc into that recipe, since there's no reason why the tests from 
> other recipes shouldn't be "ptest-ified" in the future. And then that .inc 
> would be useful to have. (Tests from the plugin sets may be partially tough 
> to run, since some of them create X11 windows etc.)
>
> - The code in gstreamer1.0-ptest.inc sets up run-ptest in a rather uncommon 
> way, since that file has to be autogenerated.
>
> - gstreamer1.0_1.16.1.bb and gstreamer1.0-plugins-common.inc both contain a 
> "gettext_oemeson" function to set up meson NLS options. Ideally, this 
> functionality would be part of the gettext bbclass itself. However, my 
> bitbake/OE knowledge does not suffice to do that, since with meson, you want 
> to be able to configure what the enable/disable flags should be 
> ("enabled"/"disabled", "true"/"false" etc.); that's why for example the 
> gtk-doc bbclass defines GTKDOC_MESON_OPTION, GTKDOC_MESON_ENABLE_FLAG, 
> GTKDOC_MESON_DISABLE_FLAG. I am not sure how to combine such variables with 
> this kind of custom python code, and still allow for 

[OE-core] [PATCHv2] wic: add UEFI kernel as UEFI stub

2020-01-13 Thread Maxim Uvarov
Linux kernel can be compiled as UEFI stub and loaded directly
with UEFI firmware without grub or other UEFI shell.

Tested with wic file:
bootloader  --ptable gpt --timeout=0  --append="rootwait"
part /boot --source bootimg-efi --sourceparams="loader=uefi-kernel" \
 --ondisk sda  --fstype=vfat --label bootfs \
  --active --align 1024 --use-uuid
part / --source rootfs --fstype=ext4 --label rootfs \
  --align 1024 --exclude-path boot/ --use-label
The same wic file for armv7, armv8 and x86_64.

Signed-off-by: Maxim Uvarov 
---
 v2: - use loader=uefi-kernel.
 - remove missed from debug WicError().
 - correct error message.

 scripts/lib/wic/plugins/source/bootimg-efi.py | 25 +++
 1 file changed, 25 insertions(+)

diff --git a/scripts/lib/wic/plugins/source/bootimg-efi.py 
b/scripts/lib/wic/plugins/source/bootimg-efi.py
index 2cfdc10ecd..8d47ea55eb 100644
--- a/scripts/lib/wic/plugins/source/bootimg-efi.py
+++ b/scripts/lib/wic/plugins/source/bootimg-efi.py
@@ -13,6 +13,7 @@
 import logging
 import os
 import shutil
+import re
 
 from wic import WicError
 from wic.engine import get_custom_config
@@ -204,6 +205,8 @@ class BootimgEFIPlugin(SourcePlugin):
 cls.do_configure_grubefi(hdddir, creator, cr_workdir, 
source_params)
 elif source_params['loader'] == 'systemd-boot':
 cls.do_configure_systemdboot(hdddir, creator, cr_workdir, 
source_params)
+elif source_params['loader'] == 'uefi-kernel':
+return
 else:
 raise WicError("unrecognized bootimg-efi loader: %s" % 
source_params['loader'])
 except KeyError:
@@ -252,6 +255,28 @@ class BootimgEFIPlugin(SourcePlugin):
 for mod in [x for x in os.listdir(kernel_dir) if 
x.startswith("systemd-")]:
 cp_cmd = "cp %s/%s %s/EFI/BOOT/%s" % (kernel_dir, mod, 
hdddir, mod[8:])
 exec_cmd(cp_cmd, True)
+elif source_params['loader'] == 'uefi-kernel':
+kernel = get_bitbake_var("KERNEL_IMAGETYPE")
+if not kernel:
+raise WicError("Empty KERNEL_IMAGETYPE %s\n" % target)
+target = get_bitbake_var("TARGET_SYS")
+if not target:
+raise WicError("Unknown arch (TARGET_SYS) %s\n" % target)
+
+if re.match("x86_64", target):
+kernel_efi_image = "bootx64.efi"
+elif re.match('i.86', target):
+kernel_efi_image = "bootia32.efi"
+elif re.match('aarch64', target):
+kernel_efi_image = "bootaa64.efi"
+elif re.match('arm', target):
+kernel_efi_image = "bootarm.efi"
+else:
+raise WicError("UEFI stub kernel is incompatible with 
target %s" % target)
+
+for mod in [x for x in os.listdir(kernel_dir) if 
x.startswith(kernel)]:
+cp_cmd = "cp %s/%s %s/EFI/BOOT/%s" % (kernel_dir, mod, 
hdddir, kernel_efi_image)
+exec_cmd(cp_cmd, True)
 else:
 raise WicError("unrecognized bootimg-efi loader: %s" %
source_params['loader'])
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 01/12] gstreamer: Add common .inc files for meson based recipes

2020-01-13 Thread Khem Raj
On Mon, Jan 13, 2020 at 12:18:32PM +, Richard Purdie wrote:
> On Sun, 2020-01-12 at 14:59 +0100, Carlos Rafael Giani wrote:
> > * gstreamer1.0-plugins-common.inc
> >   The old gstreamer1.0-plugins.inc file, adapted for meson
> > * gstreamer1.0-plugins-packaging.inc
> >   The old gst-plugins-package.inc file, adapted for meson
> > * gstreamer1.0-ptest.inc
> >   Common code for meson based PTest support; autogenerates the run-ptest
> >   file and is designed to use the gnome-desktop-testing suite runner
> >   (which is why the .inc files inherits from ptest-gnome)
> > 
> > Signed-off-by: Carlos Rafael Giani 
> > ---
> >  .../gstreamer/gstreamer1.0-plugins-common.inc | 47 +
> >  .../gstreamer1.0-plugins-packaging.inc| 70 +++
> >  .../gstreamer/gstreamer1.0-ptest.inc  | 21 ++
> >  3 files changed, 138 insertions(+)
> >  create mode 100644 
> > meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-common.inc
> >  create mode 100644 
> > meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-packaging.inc
> >  create mode 100644 meta/recipes-multimedia/gstreamer/gstreamer1.0-ptest.inc
> 
> Thanks for this, I know its not an easy patch set to sort out!
> 
> I ran it on the autobuilder for testing since there was bandwidth
> available and there was one issue:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/47/builds/1455
> 
> which was in a plain OE-Core + bitbake build (no poky, so nodistro).
> 
> Any idea what is wrong there?

gcc: fatal error: cannot execute ‘cc1obj’: execvp: No such file or directory

seems it needs objC ?

> 
> Cheers,
> 
> Richard
> 
> -- 
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 04/12] gstreamer1.0-plugins-good: Transition to meson based builds

2020-01-13 Thread Khem Raj
On Mon, Jan 13, 2020 at 03:50:09PM +0100, Carlos Rafael Giani wrote:
> Actually, you have a point. I seem to have forgotten to fix this in this
> patch. With meson, it appears that the meta-qt5 bbappend is no longer
> necessary, since meson finds the Qt5 moc/rcc/uic tools on its own, so a
> packageconfig could be added right here. However, I'd like to investigate
> that moc/rcc/uic autodetection more to be sure it does not bring with it
> some "surprises" that could bite us in the behind when doing production
> builds.

I think that might be better

> 
> On 13.01.20 01:52, Khem Raj wrote:
> > On Sun, Jan 12, 2020 at 6:33 AM Carlos Rafael Giani  
> > wrote:
> > > * Removed autotools/M4 related patch
> > >0001-introspection.m4-prefix-pkgconfig-paths-with-PKG_CON.patch.
> > > 
> > > * gtk-doc support is handled here, not in gstreamer1.0-plugins-common.inc,
> > >  since unlike with autotools, only some plugin set packages use 
> > > gtk-doc.
> > > 
> > > * zlib is no longer optional, and glib anyway depends on zlib, therefore
> > >  it gets added to the DEPENDS list.
> > > 
> > > * gettext handling now part of gstreamer1.0-plugins-common.inc.
> > > 
> > > Signed-off-by: Carlos Rafael Giani 
> > > ---
> > >   .../gstreamer1.0-plugins-good_1.16.1.bb   | 79 +--
> > >   1 file changed, 38 insertions(+), 41 deletions(-)
> > > 
> > > diff --git 
> > > a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb 
> > > b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb
> > > index 0fa7b86ffe..a6eb9986dd 100644
> > > --- 
> > > a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb
> > > +++ 
> > > b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb
> > > @@ -1,8 +1,7 @@
> > > -require gstreamer1.0-plugins.inc
> > > +require gstreamer1.0-plugins-common.inc
> > > 
> > >   SRC_URI = " \
> > >   
> > > https://gstreamer.freedesktop.org/src/gst-plugins-good/gst-plugins-good-${PV}.tar.xz
> > >  \
> > > -
> > > file://0001-introspection.m4-prefix-pkgconfig-paths-with-PKG_CON.patch \
> > >   "
> > > 
> > >   SRC_URI[md5sum] = "515987ee763256840a11bd8ea098f2bf"
> > > @@ -15,42 +14,41 @@ LIC_FILES_CHKSUM = 
> > > "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \
> > >   
> > > file://common/coverage/coverage-report.pl;beginline=2;endline=17;md5=a4e1830fce078028c8f0974161272607
> > >  \
> > >   
> > > file://gst/replaygain/rganalysis.c;beginline=1;endline=23;md5=b60ebefd5b2f5a8e0cab6bfee391a5fe"
> > > 
> > > -DEPENDS += "gstreamer1.0-plugins-base libcap"
> > > +DEPENDS += "gstreamer1.0-plugins-base libcap zlib"
> > >   RPROVIDES_${PN}-pulseaudio += "${PN}-pulse"
> > >   RPROVIDES_${PN}-soup += "${PN}-souphttpsrc"
> > > 
> > > -inherit gettext
> > > -
> > >   PACKAGECONFIG ??= " \
> > >   ${GSTREAMER_ORC} \
> > >   ${@bb.utils.filter('DISTRO_FEATURES', 'pulseaudio x11', d)} \
> > > -bz2 cairo flac gdk-pixbuf gudev jpeg lame libpng mpg123 soup speex 
> > > taglib v4l2 zlib \
> > > +bz2 cairo flac gdk-pixbuf gudev jpeg lame libpng mpg123 soup speex 
> > > taglib v4l2 \
> > >   "
> > > 
> > >   X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes libxdamage"
> > > +X11ENABLEOPTS = "-Dximagesrc=enabled -Dximagesrc-xshm=enabled 
> > > -Dximagesrc-xfixes=enabled -Dximagesrc-xdamage=enabled"
> > > +X11DISABLEOPTS = "-Dximagesrc=disabled -Dximagesrc-xshm=disabled 
> > > -Dximagesrc-xfixes=disabled -Dximagesrc-xdamage=disabled"
> > > 
> > > -PACKAGECONFIG[bz2]= "--enable-bz2,--disable-bz2,bzip2"
> > > -PACKAGECONFIG[cairo]  = "--enable-cairo,--disable-cairo,cairo"
> > > -PACKAGECONFIG[dv1394] = 
> > > "--enable-dv1394,--disable-dv1394,libiec61883 libavc1394 libraw1394"
> > > -PACKAGECONFIG[flac]   = "--enable-flac,--disable-flac,flac"
> > > -PACKAGECONFIG[gdk-pixbuf] = 
> > > "--enable-gdk_pixbuf,--disable-gdk_pixbuf,gdk-pixbuf"
> > > -PACKAGECONFIG[gtk]= "--enable-gtk3,--disable-gtk3,gtk+3"
> > > -PACKAGECONFIG[gudev]  = "--with-gudev,--without-gudev,libgudev"
> > > -PACKAGECONFIG[jack]   = "--enable-jack,--disable-jack,jack"
> > > -PACKAGECONFIG[jpeg]   = "--enable-jpeg,--disable-jpeg,jpeg"
> > > -PACKAGECONFIG[lame]   = "--enable-lame,--disable-lame,lame"
> > > -PACKAGECONFIG[libpng] = "--enable-libpng,--disable-libpng,libpng"
> > > -PACKAGECONFIG[libv4l2]= "--with-libv4l2,--without-libv4l2,v4l-utils"
> > > -PACKAGECONFIG[mpg123] = "--enable-mpg123,--disable-mpg123,mpg123"
> > > -PACKAGECONFIG[pulseaudio] = "--enable-pulse,--disable-pulse,pulseaudio"
> > > -PACKAGECONFIG[soup]   = "--enable-soup,--disable-soup,libsoup-2.4"
> > > -PACKAGECONFIG[speex]  = "--enable-speex,--disable-speex,speex"
> > > -PACKAGECONFIG[taglib] = "--enable-taglib,--disable-taglib,taglib"
> > > -PACKAGECONFIG[v4l2]   = "--enable-gst_v4l2 
> > > --enable-v4l2-probe,--disable-gst_v4l2"
> > > 

Re: [OE-core] [PATCH 01/12] gstreamer: Add common .inc files for meson based recipes

2020-01-13 Thread Alexander Kanavin
I have reproduced this just now. You need to set up a special 'nodistro'
configuration like this:

bblayers.conf:
BBLAYERS ?= " \
  /home/alexander/development/poky/meta \
"
(and no other layers)

local.conf:

MACHINE ??= "qemuarm"
DISTRO ?= "nodistro"
INHERIT += 'uninative'
require conf/distro/include/yocto-uninative.inc
... (dl_dir, sstate etc)

and build gstreamer1.0-plugins-base.

Alex


On Mon, 13 Jan 2020 at 16:38, Carlos Rafael Giani 
wrote:

> Except that there is no such package. Also, even if I build GStreamer
> from scratch with all optional packageconfigs disabled, I do not get
> this error, nor do I get any warnings about potentially missing
> dependencies. So, I don't know what is going on here..
>
> On 13.01.20 13:59, Richard Purdie wrote:
> > On Mon, 2020-01-13 at 13:55 +0100, Carlos Rafael Giani wrote:
> >> Nope. This is an odd one. Are you sure there isn't a problem with
> >> the
> >> setup itself? In step2c, I see:
> >>
> >>   > ERROR: core-image-sato-1.0-r0 do_testsdk: The toolchain
> >> /home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-
> >> glibc/deploy/sdk/oecore-i686-armv7vet2hf-neon-toolchain-
> >> nodistro.0.sh
> >> is not built. Build it before running the tests: 'bitbake  -c
> >> populate_sdk' .
> > 2c fails as earlier stepd didn't build. I think the real issue is
> > step1b which says:
> >
> > | Compiler for C supports arguments -Wdeclaration-after-statement: YES
> > | Found pkg-config:
> /home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/armv7vet2hf-neon-oe-linux-gnueabi/gstreamer1.0-plugins-base/1.16.1-r0/recipe-sysroot-native/usr/bin/pkg-config
> (0.29.2)
> > | Run-time dependency x11 found: YES 1.6.9
> > | Run-time dependency glib-2.0 found: YES 2.62.4
> > | Run-time dependency gobject-2.0 found: YES 2.62.4
> > | Run-time dependency gio-2.0 found: YES 2.62.4
> > | Run-time dependency gio-unix-2.0 found: YES 2.62.4
> > | Run-time dependency gmodule-no-export-2.0 found: YES 2.62.4
> > | Dependency gdk-pixbuf-2.0 skipped: feature examples disabled
> > | Dependency gtk+-3.0 skipped: feature examples disabled
> > | Dependency gtk+-x11-3.0 skipped: feature examples disabled
> > | Run-time dependency gstreamer-1.0 found: YES 1.16.1
> > | Run-time dependency gstreamer-base-1.0 found: YES 1.16.1
> > | Run-time dependency gstreamer-net-1.0 found: YES 1.16.1
> > | Found CMake: NO
> > | Run-time dependency gstreamer-check-1.0 found: NO (tried pkgconfig and
> cmake)
> > | Looking for a fallback subproject for the dependency
> gstreamer-check-1.0
> > | Subproject directory not found and gstreamer.wrap file not found
> > | Subproject  subprojects/gstreamer is buildable: NO (disabling)
> > | Dependency gstreamer-check-1.0 from subproject subprojects/gstreamer
> found: NO
> > |
> > | meson.build:309:0: ERROR: Could not find dependency gst_controller_dep
> in subproject gstreamer
> > |
> > | A full log can be found at
> /home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/armv7vet2hf-neon-oe-linux-gnueabi/gstreamer1.0-plugins-base/1.16.1-r0/build/meson-logs/meson-log.txt
> > | WARNING:
> /home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/armv7vet2hf-neon-oe-linux-gnueabi/gstreamer1.0-plugins-base/1.16.1-r0/temp/run.do_configure.46093:1
> exit 1 from 'exit 1'
> > |
> > NOTE: recipe gstreamer1.0-plugins-base-1.16.1-r0: task do_configure:
> Failed
> >
> > | Compiler for C supports arguments -Wdeclaration-after-statement: YES
> > | Found pkg-config:
> /home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/armv7vet2hf-neon-oe-linux-gnueabi/gstreamer1.0-plugins-base/1.16.1-r0/recipe-sysroot-native/usr/bin/pkg-config
> (0.29.2)
> > | Run-time dependency x11 found: YES 1.6.9
> > | Run-time dependency glib-2.0 found: YES 2.62.4
> > | Run-time dependency gobject-2.0 found: YES 2.62.4
> > | Run-time dependency gio-2.0 found: YES 2.62.4
> > | Run-time dependency gio-unix-2.0 found: YES 2.62.4
> > | Run-time dependency gmodule-no-export-2.0 found: YES 2.62.4
> > | Dependency gdk-pixbuf-2.0 skipped: feature examples disabled
> > | Dependency gtk+-3.0 skipped: feature examples disabled
> > | Dependency gtk+-x11-3.0 skipped: feature examples disabled
> > | Run-time dependency gstreamer-1.0 found: YES 1.16.1
> > | Run-time dependency gstreamer-base-1.0 found: YES 1.16.1
> > | Run-time dependency gstreamer-net-1.0 found: YES 1.16.1
> > | Found CMake: NO
> > | Run-time dependency gstreamer-check-1.0 found: NO (tried pkgconfig and
> cmake)
> > | Looking for a fallback subproject for the dependency
> gstreamer-check-1.0
> > | Subproject directory not found and gstreamer.wrap file not found
> > | Subproject  subprojects/gstreamer is buildable: NO (disabling)
> > | Dependency gstreamer-check-1.0 from subproject subprojects/gstreamer
> found: NO
> > |
> > | meson.build:309:0: ERROR: Could not find dependency gst_controller_dep
> in subproject gstreamer
> > |
> > | A full log can be found at
> 

Re: [OE-core] [PATCH 01/12] gstreamer: Add common .inc files for meson based recipes

2020-01-13 Thread Alexander Kanavin
 ${GST_TEST_SUITE_NAME} is not actually defined anywhere? I believe this
has the undesired effect of running all installed test suites rather than
just gstreamer, including glib and others.


Alex

On Sun, 12 Jan 2020 at 15:31, Carlos Rafael Giani 
wrote:

> * gstreamer1.0-plugins-common.inc
>   The old gstreamer1.0-plugins.inc file, adapted for meson
> * gstreamer1.0-plugins-packaging.inc
>   The old gst-plugins-package.inc file, adapted for meson
> * gstreamer1.0-ptest.inc
>   Common code for meson based PTest support; autogenerates the run-ptest
>   file and is designed to use the gnome-desktop-testing suite runner
>   (which is why the .inc files inherits from ptest-gnome)
>
> Signed-off-by: Carlos Rafael Giani 
> ---
>  .../gstreamer/gstreamer1.0-plugins-common.inc | 47 +
>  .../gstreamer1.0-plugins-packaging.inc| 70 +++
>  .../gstreamer/gstreamer1.0-ptest.inc  | 21 ++
>  3 files changed, 138 insertions(+)
>  create mode 100644
> meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-common.inc
>  create mode 100644
> meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-packaging.inc
>  create mode 100644
> meta/recipes-multimedia/gstreamer/gstreamer1.0-ptest.inc
>
> diff --git
> a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-common.inc
> b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-common.inc
> new file mode 100644
> index 00..ccf55500a9
> --- /dev/null
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-common.inc
> @@ -0,0 +1,47 @@
> +# This .inc file contains the common setup for the gstreamer1.0-plugins-*
> +# plugin set recipes.
> +
> +# SUMMARY is set in the actual .bb recipes
> +HOMEPAGE = "https://gstreamer.freedesktop.org/;
> +BUGTRACKER = "https://bugzilla.gnome.org/enter_bug.cgi?product=Gstreamer;
> +SECTION = "multimedia"
> +
> +DEPENDS = "gstreamer1.0 glib-2.0-native"
> +
> +inherit gettext meson pkgconfig upstream-version-is-even
> +
> +require gstreamer1.0-plugins-packaging.inc
> +
> +# Orc enables runtime JIT compilation of data processing routines from Orc
> +# bytecode to SIMD instructions for various architectures (currently SSE,
> MMX,
> +# MIPS, Altivec and NEON are supported).
> +# This value is used in the PACKAGECONFIG values for each plugin set
> recipe.
> +# By modifying it, Orc can be enabled/disabled in all of these recipes at
> once.
> +GSTREAMER_ORC ?= "orc"
> +
> +PACKAGECONFIG[orc] = "-Dorc=enabled,-Dorc=disabled,orc orc-native"
> +
> +# TODO: put this in a gettext.bbclass patch (with variables to allow for
> +# configuring the option name and the enabled/disabled values).
> +def gettext_oemeson(d):
> +if d.getVar('USE_NLS') == 'no':
> +return '-Dnls=disabled'
> +# Remove the NLS bits if USE_NLS is no or INHIBIT_DEFAULT_DEPS is set
> +if d.getVar('INHIBIT_DEFAULT_DEPS') and not oe.utils.inherits(d,
> 'cross-canadian'):
> +return '-Dnls=disabled'
> +return '-Dnls=enabled'
> +
> +# Not all plugin sets contain examples, so the -Dexamples
> +# option needs to be added conditionally.
> +GST_PLUGIN_SET_HAS_EXAMPLES ?= "1"
> +
> +EXTRA_OEMESON += " \
> +${@bb.utils.contains('GST_PLUGIN_SET_HAS_EXAMPLES', '1',
> '-Dexamples=disabled', '', d)} \
> +${@gettext_oemeson(d)} \
> +"
> +
> +GIR_MESON_ENABLE_FLAG = "enabled"
> +GIR_MESON_DISABLE_FLAG = "disabled"
> +
> +# Dynamically generate packages for all enabled plugins
> +PACKAGES_DYNAMIC = "^${PN}-.*"
> diff --git
> a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-packaging.inc
> b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-packaging.inc
> new file mode 100644
> index 00..9a7a1b6afe
> --- /dev/null
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-packaging.inc
> @@ -0,0 +1,70 @@
> +# This .inc file contains functionality for automatically splitting
> +# built plugins into individual packages for each plugin. A -meta
> +# package is also set up that has no files of its own, but contains
> +# the names of all plugin packages in its RDEPENDS list.
> +#
> +# This is mainly used by the gstreamer1.0-plugins-* plugin set recipes,
> +# but can be used in any recipe that produces GStreamer plugins.
> +
> +PACKAGESPLITFUNCS_prepend = " split_gstreamer10_packages "
> +PACKAGESPLITFUNCS_append = " set_gstreamer10_metapkg_rdepends "
> +
> +python split_gstreamer10_packages () {
> +gst_libdir = d.expand('${libdir}/gstreamer-1.0')
> +postinst = d.getVar('plugin_postinst')
> +glibdir = d.getVar('libdir')
> +
> +# GStreamer libraries
> +do_split_packages(d, glibdir, r'^lib(.*)\.so\.*', 'lib%s', 'GStreamer
> 1.0 %s library', extra_depends='', allow_links=True)
> +# GStreamer plugin shared objects
> +do_split_packages(d, gst_libdir, r'libgst(.*)\.so$',
> d.expand('${PN}-%s'), 'GStreamer 1.0 plugin for %s', postinst=postinst,
> extra_depends='')
> +# GObject introspection files for GStreamer plugins
> +do_split_packages(d, 

Re: [OE-core] Looking for a way to build latest tagged releases in recipes

2020-01-13 Thread chris.laplante--- via Openembedded-core
Hi Richard,

> FWIW I do want to see the system used to do things like this. I've kind
> of envisaged you'd do it "up front" though. For example it should be
> trivial for a script to use tinfoil, iterate through and generate an
> include file of the revisions you want, using the fetcher calls.
> 
> Yes, its slightly more annoying to generate the config, then build it
> but if it stops the core becoming unmaintainable with corner cases,
> that could be the right decision.
> 
> If you do something like that it would be great to share it so others
> can see what you did and be able to build off it...

This is actually something I've been working on and thinking about a lot for 
the past year and a half. Our application layer has probably 30 or so recipes 
that use AUTOREV. For the purposes of reproducible builds, we need to generate 
similar output to what buildhistory-collect-srcrevs generates, e.g. 

SRCREV_pn-my_daemon = "githash" 

I've gone back and forth and re-implemented the code to do so a half dozen 
times. Chronologically, these are the fundamental strategies I've attempted:

1. Simply in terms of buildhistory-collect-srcrevs. 
Pros: dead simple
Cons: requires that you actually build stuff first; requires 
buildhistory to be enabled
2. As a bbclass, injecting a task between do_fetch and do_unpack 
("do_capture_srcrevs")
Pros: can be invoked without actually building stuff, e.g. bitbake 
my-image --runall=do_capture_srcrevs
Cons: adds yet another task to the recipe; a little ugly since you 
either need to INHERIT the class, or individually inherit it in recipes 
3. As a separate tinfoil script (as you suggest) which I run before the actual 
bitbake. 
Pros: decoupled from the actual build
Cons: since it's decoupled, it's slower - each recipe needs to be parsed
4. Hacking the srcrev cache (inside fetch2) to log all information necessary to 
generate the SRCREV overrides, paired with a script that reads the cache and 
does it
Pros: Equally suitable for the "config-then-build" workflow ("bitbake 
--parse-only && generate_overrides.py >> local.conf && bitbake image") or the 
"build-then-config" workflow ("bitbake image && generate_overrides.py > 
overrides.conf")
Cons: Invasive, required large changes to fetch2/__init__.py and some 
smaller changes to fetch2/git.py

In the current incarnation (#4), I also go a step further and, in cases where a 
SRC_URI has a parameterized branch, I generate BRANCH override lines as well. 
For example, if I see:

MY_BRANCH ??= "master"
SRC_URI = "git://git.oe.handhelds.org/git/vip.git;tag=version-1; 
branch=${MY_BRANCH}" 

I generate this line along with the corresponding SRCREV override:

MY_BRANCH_pn-recipe = "master"

The algorithm for detecting the branch variable in the SRC_URI entry is as a 
little complicated, and not super relevant at this moment, but I want to get it 
off my chest :). The code first tries to find a parameterized branch by using a 
regex to find stuff like "branch=${VAR}". If that fails, it could be because 
the branch is expressed as something more complicated like this:

BRANCH_RELEASE_NUMBER ??= "1.0"
SRC_URI = "git://git.oe.handhelds.org/git/vip.git;tag=version-1; 
branch=release-${BRANCH_RELEASE_NUMBER}"

In that case, I fall back on a breadth-first search on all the variables that 
SRC_URI references (recursively) to find the "deepest" one that controls the 
branch. I wrote this in terms of d.expandWithRefs, and can detail it further if 
people are interested. Basically, I didn't want to enforce a particular 
convention on the name of the branch variable. You'd think BRANCH would cover 
it, but the kernel recipes also have KMETA and stuff like that. 

I realize the branch stuff as currently implemented is maybe too opinionated 
(and a bit dangerous) for inclusion in bitbake. But I digress. 

I'm very interested in discussing the SRCREV (and perhaps BRANCH) stuff further 
with anyone interested. I would love to see some strategy for doing this make 
its way into bitbake or poky, so I can stop reimplementing it and second 
guessing myself :).

Thanks,
Chris
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 01/12] gstreamer: Add common .inc files for meson based recipes

2020-01-13 Thread Carlos Rafael Giani
Except that there is no such package. Also, even if I build GStreamer 
from scratch with all optional packageconfigs disabled, I do not get 
this error, nor do I get any warnings about potentially missing 
dependencies. So, I don't know what is going on here..


On 13.01.20 13:59, Richard Purdie wrote:

On Mon, 2020-01-13 at 13:55 +0100, Carlos Rafael Giani wrote:

Nope. This is an odd one. Are you sure there isn't a problem with
the
setup itself? In step2c, I see:

  > ERROR: core-image-sato-1.0-r0 do_testsdk: The toolchain
/home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-
glibc/deploy/sdk/oecore-i686-armv7vet2hf-neon-toolchain-
nodistro.0.sh
is not built. Build it before running the tests: 'bitbake  -c
populate_sdk' .

2c fails as earlier stepd didn't build. I think the real issue is
step1b which says:

| Compiler for C supports arguments -Wdeclaration-after-statement: YES
| Found pkg-config: 
/home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/armv7vet2hf-neon-oe-linux-gnueabi/gstreamer1.0-plugins-base/1.16.1-r0/recipe-sysroot-native/usr/bin/pkg-config
 (0.29.2)
| Run-time dependency x11 found: YES 1.6.9
| Run-time dependency glib-2.0 found: YES 2.62.4
| Run-time dependency gobject-2.0 found: YES 2.62.4
| Run-time dependency gio-2.0 found: YES 2.62.4
| Run-time dependency gio-unix-2.0 found: YES 2.62.4
| Run-time dependency gmodule-no-export-2.0 found: YES 2.62.4
| Dependency gdk-pixbuf-2.0 skipped: feature examples disabled
| Dependency gtk+-3.0 skipped: feature examples disabled
| Dependency gtk+-x11-3.0 skipped: feature examples disabled
| Run-time dependency gstreamer-1.0 found: YES 1.16.1
| Run-time dependency gstreamer-base-1.0 found: YES 1.16.1
| Run-time dependency gstreamer-net-1.0 found: YES 1.16.1
| Found CMake: NO
| Run-time dependency gstreamer-check-1.0 found: NO (tried pkgconfig and cmake)
| Looking for a fallback subproject for the dependency gstreamer-check-1.0
| Subproject directory not found and gstreamer.wrap file not found
| Subproject  subprojects/gstreamer is buildable: NO (disabling)
| Dependency gstreamer-check-1.0 from subproject subprojects/gstreamer found: NO
|
| meson.build:309:0: ERROR: Could not find dependency gst_controller_dep in 
subproject gstreamer
|
| A full log can be found at 
/home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/armv7vet2hf-neon-oe-linux-gnueabi/gstreamer1.0-plugins-base/1.16.1-r0/build/meson-logs/meson-log.txt
| WARNING: 
/home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/armv7vet2hf-neon-oe-linux-gnueabi/gstreamer1.0-plugins-base/1.16.1-r0/temp/run.do_configure.46093:1
 exit 1 from 'exit 1'
|
NOTE: recipe gstreamer1.0-plugins-base-1.16.1-r0: task do_configure: Failed

| Compiler for C supports arguments -Wdeclaration-after-statement: YES
| Found pkg-config: 
/home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/armv7vet2hf-neon-oe-linux-gnueabi/gstreamer1.0-plugins-base/1.16.1-r0/recipe-sysroot-native/usr/bin/pkg-config
 (0.29.2)
| Run-time dependency x11 found: YES 1.6.9
| Run-time dependency glib-2.0 found: YES 2.62.4
| Run-time dependency gobject-2.0 found: YES 2.62.4
| Run-time dependency gio-2.0 found: YES 2.62.4
| Run-time dependency gio-unix-2.0 found: YES 2.62.4
| Run-time dependency gmodule-no-export-2.0 found: YES 2.62.4
| Dependency gdk-pixbuf-2.0 skipped: feature examples disabled
| Dependency gtk+-3.0 skipped: feature examples disabled
| Dependency gtk+-x11-3.0 skipped: feature examples disabled
| Run-time dependency gstreamer-1.0 found: YES 1.16.1
| Run-time dependency gstreamer-base-1.0 found: YES 1.16.1
| Run-time dependency gstreamer-net-1.0 found: YES 1.16.1
| Found CMake: NO
| Run-time dependency gstreamer-check-1.0 found: NO (tried pkgconfig and cmake)
| Looking for a fallback subproject for the dependency gstreamer-check-1.0
| Subproject directory not found and gstreamer.wrap file not found
| Subproject  subprojects/gstreamer is buildable: NO (disabling)
| Dependency gstreamer-check-1.0 from subproject subprojects/gstreamer found: NO
|
| meson.build:309:0: ERROR: Could not find dependency gst_controller_dep in 
subproject gstreamer
|
| A full log can be found at 
/home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/armv7vet2hf-neon-oe-linux-gnueabi/gstreamer1.0-plugins-base/1.16.1-r0/build/meson-logs/meson-log.txt
| WARNING: 
/home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/armv7vet2hf-neon-oe-linux-gnueabi/gstreamer1.0-plugins-base/1.16.1-r0/temp/run.do_configure.46093:1
 exit 1 from 'exit 1'
|
NOTE: recipe gstreamer1.0-plugins-base-1.16.1-r0: task do_configure: Failed

missing a check dependency?

Cheers,

Richard



--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 26/28] sudo: correct SRC_URI

2020-01-13 Thread Armin Kuster
From: Alexander Kanavin 

The old URI returns 404, and has an invalid TLS certificate.

Signed-off-by: Alexander Kanavin 
Signed-off-by: Richard Purdie 
(cherry picked from commit 73ff6aba0a53ffc3ee0a5859a3ad4c8021be4de0)
Signed-off-by: Armin Kuster 
---
 meta/recipes-extended/sudo/sudo_1.8.27.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-extended/sudo/sudo_1.8.27.bb 
b/meta/recipes-extended/sudo/sudo_1.8.27.bb
index 7460a5bfed..bbca8395b9 100644
--- a/meta/recipes-extended/sudo/sudo_1.8.27.bb
+++ b/meta/recipes-extended/sudo/sudo_1.8.27.bb
@@ -1,6 +1,6 @@
 require sudo.inc
 
-SRC_URI = "http://ftp.sudo.ws/sudo/dist/sudo-${PV}.tar.gz \
+SRC_URI = "http://www.sudo.ws/sudo/dist/sudo-${PV}.tar.gz \
${@bb.utils.contains('DISTRO_FEATURES', 'pam', '${PAM_SRC_URI}', 
'', d)} \
file://0001-Include-sys-types.h-for-id_t-definition.patch \
file://CVE-2019-14287-1.patch \
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 27/28] sudo: Fix fetching sources

2020-01-13 Thread Armin Kuster
From: Ferry Toth 

It looks like https://www.sudo.ws/download.html changed certificate
and directory structure. This breaks fetching sources.

Signed-off-by: Ferry Toth 
Signed-off-by: Ross Burton 
Signed-off-by: Armin Kuster 
(cherry picked from commit f02e9f46ce54fed3c7ddfad7d1003a2fb7ba3a67)
Signed-off-by: Armin Kuster 
---
 meta/recipes-extended/sudo/sudo_1.8.27.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-extended/sudo/sudo_1.8.27.bb 
b/meta/recipes-extended/sudo/sudo_1.8.27.bb
index bbca8395b9..43c27bf37f 100644
--- a/meta/recipes-extended/sudo/sudo_1.8.27.bb
+++ b/meta/recipes-extended/sudo/sudo_1.8.27.bb
@@ -1,6 +1,6 @@
 require sudo.inc
 
-SRC_URI = "http://www.sudo.ws/sudo/dist/sudo-${PV}.tar.gz \
+SRC_URI = "https://www.sudo.ws/dist/sudo-${PV}.tar.gz \
${@bb.utils.contains('DISTRO_FEATURES', 'pam', '${PAM_SRC_URI}', 
'', d)} \
file://0001-Include-sys-types.h-for-id_t-definition.patch \
file://CVE-2019-14287-1.patch \
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 28/28] stress: update SRC_URI

2020-01-13 Thread Armin Kuster
Fixes:
WARNING: stress-1.0.4-r0 do_fetch: Failed to fetch URL 
http://people.seas.harvard.edu/~apw/stress/stress-1.0.4.tar.gz, attempting 
MIRRORS if available

Signed-off-by: Armin Kuster 
---
 meta/recipes-extended/stress/stress_1.0.4.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-extended/stress/stress_1.0.4.bb 
b/meta/recipes-extended/stress/stress_1.0.4.bb
index e9179d3e19..42046d5bf4 100644
--- a/meta/recipes-extended/stress/stress_1.0.4.bb
+++ b/meta/recipes-extended/stress/stress_1.0.4.bb
@@ -5,7 +5,7 @@ HOMEPAGE = "http://people.seas.harvard.edu/~apw/stress/;
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
-SRC_URI = "http://people.seas.harvard.edu/~apw/${BPN}/${BP}.tar.gz \
+SRC_URI = "https://fossies.org/linux/privat/${BP}.tar.gz \
file://texinfo.patch \
"
 
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 25/28] popt: fix SRC_URI

2020-01-13 Thread Armin Kuster
From: Oleksandr Kravchuk 

rpm5.org has been down for about a year now. Use linuxfromscratch.org
as an alternative reliable source instead.

Signed-off-by: Oleksandr Kravchuk 
Signed-off-by: Richard Purdie 
(cherry picked from commit d9224014da9a512b1b8837e4e7a736d465c97be3)
Signed-off-by: Armin Kuster 
---
 meta/recipes-support/popt/popt_1.16.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-support/popt/popt_1.16.bb 
b/meta/recipes-support/popt/popt_1.16.bb
index 478288f9bf..27e49c2ca2 100644
--- a/meta/recipes-support/popt/popt_1.16.bb
+++ b/meta/recipes-support/popt/popt_1.16.bb
@@ -8,7 +8,7 @@ PR = "r3"
 
 DEPENDS = "virtual/libiconv"
 
-SRC_URI = "http://rpm5.org/files/popt/popt-${PV}.tar.gz \
+SRC_URI = "http://anduin.linuxfromscratch.org/BLFS/popt/popt-${PV}.tar.gz \
file://pkgconfig_fix.patch \
file://popt_fix_for_automake-1.12.patch \
file://disable_tests.patch \
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 24/28] cve-check: Switch to NVD CVE JSON feed version 1.1

2020-01-13 Thread Armin Kuster
From: Niko Mauno 

Switch to recently released version 1.1 of NVD CVE JSON feed, as in
https://nvd.nist.gov/General/News/JSON-1-1-Vulnerability-Feed-Release
it is mentioned that

  Due to changes required to support CVSS v3.1 scoring, the JSON
  vulnerability feeds must be modified. This will require the consumers
  of this data to update their internal processes. We will be providing
  the JSON 1.1 schema on the data feeds page and the information below
  to prepare for this transition.
  ...
  The JSON 1.1 data feeds will be available on September 9th, 2019. At
  that time the current JSON 1.0 data feeds will no longer available.

This change was tested briefly by issuing 'bitbake core-image-minimal'
with 'cve-check.bbclass' inherited via local.conf, and then comparing
the content between the resulting two
'DEPLOY_DIR_IMAGE/core-image-minimal-qemux86.cve' files, which did not
seem to contain any other change, except total of 167 entries like

  CVSS v3 BASE SCORE: 0.0

were replaced with similar 'CVSS v3 BASE SCORE:' entries which had
scores that were greater than '0.0' (up to '9.8').

(From OE-Core rev: cc20e4d8ff2f3aa52a2658404af9a0ff358cc323)

Signed-off-by: Niko Mauno 
Signed-off-by: Richard Purdie 
Signed-off-by: Anuj Mittal 
Signed-off-by: Richard Purdie 
(cherry picked from commit c92b8804d6e59b2707332859957f0e6a46db0a73)
Signed-off-by: Armin Kuster 
---
 meta/classes/cve-check.bbclass | 2 +-
 meta/recipes-core/meta/cve-update-db-native.bb | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/cve-check.bbclass b/meta/classes/cve-check.bbclass
index 19ed5548b3..01b3637469 100644
--- a/meta/classes/cve-check.bbclass
+++ b/meta/classes/cve-check.bbclass
@@ -26,7 +26,7 @@ CVE_PRODUCT ??= "${BPN}"
 CVE_VERSION ??= "${PV}"
 
 CVE_CHECK_DB_DIR ?= "${DL_DIR}/CVE_CHECK"
-CVE_CHECK_DB_FILE ?= "${CVE_CHECK_DB_DIR}/nvdcve_1.0.db"
+CVE_CHECK_DB_FILE ?= "${CVE_CHECK_DB_DIR}/nvdcve_1.1.db"
 
 CVE_CHECK_LOG ?= "${T}/cve.log"
 CVE_CHECK_TMP_FILE ?= "${TMPDIR}/cve_check"
diff --git a/meta/recipes-core/meta/cve-update-db-native.bb 
b/meta/recipes-core/meta/cve-update-db-native.bb
index db1d69a28e..575254af40 100644
--- a/meta/recipes-core/meta/cve-update-db-native.bb
+++ b/meta/recipes-core/meta/cve-update-db-native.bb
@@ -27,7 +27,7 @@ python do_populate_cve_db() {
 
 bb.utils.export_proxies(d)
 
-BASE_URL = "https://nvd.nist.gov/feeds/json/cve/1.0/nvdcve-1.0-;
+BASE_URL = "https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-;
 YEAR_START = 2002
 
 db_file = d.getVar("CVE_CHECK_DB_FILE")
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 23/28] cve-check: fetch CVE data once at a time instead of in a single call

2020-01-13 Thread Armin Kuster
From: Ross Burton 

This code used to construct a single SQL statement that fetched the NVD data for
every CVE requested.  For recipes such as the kernel where there are over 2000
CVEs to report this can hit the variable count limit and the query fails with
"sqlite3.OperationalError: too many SQL variables".  The default limit is 999
variables, but some distributions such as Debian set the default to 25.

As the NVD table has an index on the ID column, whilst requesting the data
CVE-by-CVE is five times slower when working with 2000 CVEs the absolute time
different is insignificant: 0.05s verses 0.01s on my machine.

(From OE-Core rev: 53d0cc1e9b7190fa66d7ff1c59518f91b0128d99)

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie 
Signed-off-by: Armin Kuster 
---
 meta/classes/cve-check.bbclass | 20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/meta/classes/cve-check.bbclass b/meta/classes/cve-check.bbclass
index e95716d9de..19ed5548b3 100644
--- a/meta/classes/cve-check.bbclass
+++ b/meta/classes/cve-check.bbclass
@@ -267,17 +267,17 @@ def get_cve_info(d, cves):
 
 cve_data = {}
 conn = sqlite3.connect(d.getVar("CVE_CHECK_DB_FILE"))
-placeholders = ",".join("?" * len(cves))
-query = "SELECT * FROM NVD WHERE id IN (%s)" % placeholders
-for row in conn.execute(query, tuple(cves)):
-cve_data[row[0]] = {}
-cve_data[row[0]]["summary"] = row[1]
-cve_data[row[0]]["scorev2"] = row[2]
-cve_data[row[0]]["scorev3"] = row[3]
-cve_data[row[0]]["modified"] = row[4]
-cve_data[row[0]]["vector"] = row[5]
-conn.close()
 
+for cve in cves:
+for row in conn.execute("SELECT * FROM NVD WHERE ID IS ?", (cve,)):
+cve_data[row[0]] = {}
+cve_data[row[0]]["summary"] = row[1]
+cve_data[row[0]]["scorev2"] = row[2]
+cve_data[row[0]]["scorev3"] = row[3]
+cve_data[row[0]]["modified"] = row[4]
+cve_data[row[0]]["vector"] = row[5]
+
+conn.close()
 return cve_data
 
 def cve_write_data(d, patched, unpatched, cve_data):
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 21/28] cve-check: rewrite look to fix false negatives

2020-01-13 Thread Armin Kuster
From: Ross Burton 

A previous optimisation was premature and resulted in false-negatives in the 
report.

Rewrite the checking algorithm to first get the list of potential CVEs by
vendor:product, then iterate through every matching CPE for that CVE to
determine if the bounds match or not.  By doing this in two stages we can know
if we've checked every CPE, instead of accidentally breaking out of the scan too
early.

(From OE-Core rev: d61aff9e22704ad69df1f7ab0f8784f4e7cc0c69)

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie 
Signed-off-by: Armin Kuster 
---
 meta/classes/cve-check.bbclass | 63 ++
 1 file changed, 34 insertions(+), 29 deletions(-)

diff --git a/meta/classes/cve-check.bbclass b/meta/classes/cve-check.bbclass
index 3326944d79..c1cbdbde7b 100644
--- a/meta/classes/cve-check.bbclass
+++ b/meta/classes/cve-check.bbclass
@@ -165,7 +165,6 @@ def check_cves(d, patched_cves):
 """
 Connect to the NVD database and find unpatched cves.
 """
-import ast, csv, tempfile, subprocess, io
 from distutils.version import LooseVersion
 
 cves_unpatched = []
@@ -187,68 +186,74 @@ def check_cves(d, patched_cves):
 cve_whitelist = d.getVar("CVE_CHECK_WHITELIST").split()
 
 import sqlite3
-db_file = d.getVar("CVE_CHECK_DB_FILE")
-conn = sqlite3.connect(db_file)
+db_file = d.expand("file:${CVE_CHECK_DB_FILE}?mode=ro")
+conn = sqlite3.connect(db_file, uri=True)
 
+# For each of the known product names (e.g. curl has CPEs using curl and 
libcurl)...
 for product in products:
-c = conn.cursor()
 if ":" in product:
 vendor, product = product.split(":", 1)
-c.execute("SELECT * FROM PRODUCTS WHERE PRODUCT IS ? AND VENDOR IS 
?", (product, vendor))
 else:
-c.execute("SELECT * FROM PRODUCTS WHERE PRODUCT IS ?", (product,))
+vendor = "%"
 
-for row in c:
-cve = row[0]
-version_start = row[3]
-operator_start = row[4]
-version_end = row[5]
-operator_end = row[6]
+# Find all relevant CVE IDs.
+for cverow in conn.execute("SELECT DISTINCT ID FROM PRODUCTS WHERE 
PRODUCT IS ? AND VENDOR LIKE ?", (product, vendor)):
+cve = cverow[0]
 
 if cve in cve_whitelist:
 bb.note("%s-%s has been whitelisted for %s" % (product, pv, 
cve))
 # TODO: this should be in the report as 'whitelisted'
 patched_cves.add(cve)
+continue
 elif cve in patched_cves:
 bb.note("%s has been patched" % (cve))
-else:
-to_append = False
+continue
+
+vulnerable = False
+for row in conn.execute("SELECT * FROM PRODUCTS WHERE ID IS ? AND 
PRODUCT IS ? AND VENDOR LIKE ?", (cve, product, vendor)):
+(_, _, _, version_start, operator_start, version_end, 
operator_end) = row
+#bb.debug(2, "Evaluating row " + str(row))
+
 if (operator_start == '=' and pv == version_start):
-to_append = True
+vulnerable = True
 else:
 if operator_start:
 try:
-to_append_start =  (operator_start == '>=' and 
LooseVersion(pv) >= LooseVersion(version_start))
-to_append_start |= (operator_start == '>' and 
LooseVersion(pv) > LooseVersion(version_start))
+vulnerable_start =  (operator_start == '>=' and 
LooseVersion(pv) >= LooseVersion(version_start))
+vulnerable_start |= (operator_start == '>' and 
LooseVersion(pv) > LooseVersion(version_start))
 except:
 bb.warn("%s: Failed to compare %s %s %s for %s" %
 (product, pv, operator_start, 
version_start, cve))
-to_append_start = False
+vulnerable_start = False
 else:
-to_append_start = False
+vulnerable_start = False
 
 if operator_end:
 try:
-to_append_end  = (operator_end == '<=' and 
LooseVersion(pv) <= LooseVersion(version_end))
-to_append_end |= (operator_end == '<' and 
LooseVersion(pv) < LooseVersion(version_end))
+vulnerable_end  = (operator_end == '<=' and 
LooseVersion(pv) <= LooseVersion(version_end))
+vulnerable_end |= (operator_end == '<' and 
LooseVersion(pv) < LooseVersion(version_end))
 except:
 bb.warn("%s: Failed to compare %s %s %s for %s" %
 (product, pv, operator_end, version_end, 
cve))
-  

[OE-core] [warrior 20/28] cve-update-db-native: clean up proxy handling

2020-01-13 Thread Armin Kuster
From: Ross Burton 

urllib handles adding proxy handlers if the proxies are set in the environment,
so call bb.utils.export_proxies() to do that and remove the manual setup.

(From OE-Core rev: 6b73004668b3b71c9c38814b79fbb58c893ed434)

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie 
Signed-off-by: Armin Kuster 
---
 .../recipes-core/meta/cve-update-db-native.bb | 31 +++
 1 file changed, 5 insertions(+), 26 deletions(-)

diff --git a/meta/recipes-core/meta/cve-update-db-native.bb 
b/meta/recipes-core/meta/cve-update-db-native.bb
index 08b18f064f..db1d69a28e 100644
--- a/meta/recipes-core/meta/cve-update-db-native.bb
+++ b/meta/recipes-core/meta/cve-update-db-native.bb
@@ -21,10 +21,12 @@ python do_populate_cve_db() {
 """
 Update NVD database with json data feed
 """
-
+import bb.utils
 import sqlite3, urllib, urllib.parse, shutil, gzip
 from datetime import date
 
+bb.utils.export_proxies(d)
+
 BASE_URL = "https://nvd.nist.gov/feeds/json/cve/1.0/nvdcve-1.0-;
 YEAR_START = 2002
 
@@ -40,16 +42,6 @@ python do_populate_cve_db() {
 except OSError:
 pass
 
-proxy = d.getVar("https_proxy")
-if proxy:
-# instantiate an opener but do not install it as the global
-# opener unless if we're really sure it's applicable for all
-# urllib requests
-proxy_handler = urllib.request.ProxyHandler({'https': proxy})
-proxy_opener = urllib.request.build_opener(proxy_handler)
-else:
-proxy_opener = None
-
 cve_f = open(os.path.join(d.getVar("TMPDIR"), 'cve_check'), 'a')
 
 if not os.path.isdir(db_dir):
@@ -67,15 +59,7 @@ python do_populate_cve_db() {
 json_url = year_url + ".json.gz"
 
 # Retrieve meta last modified date
-
-response = None
-
-if proxy_opener:
-response = proxy_opener.open(meta_url)
-else:
-req = urllib.request.Request(meta_url)
-response = urllib.request.urlopen(req)
-
+response = urllib.request.urlopen(meta_url)
 if response:
 for l in response.read().decode("utf-8").splitlines():
 key, value = l.split(":", 1)
@@ -95,12 +79,7 @@ python do_populate_cve_db() {
 
 # Update db with current year json file
 try:
-if proxy_opener:
-response = proxy_opener.open(json_url)
-else:
-req = urllib.request.Request(json_url)
-response = urllib.request.urlopen(req)
-
+response = urllib.request.urlopen(json_url)
 if response:
 update_db(c, 
gzip.decompress(response.read()).decode('utf-8'))
 c.execute("insert or replace into META values (?, ?)", [year, 
last_modified])
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 22/28] cve-check: neaten get_cve_info

2020-01-13 Thread Armin Kuster
From: Ross Burton 

Remove obsolete Python 2 code, and use convenience methods for neatness.

(From OE-Core rev: f19253cc9e70c974a8e21a142086c13d7cde04ff)

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie 
Signed-off-by: Armin Kuster 
---
 meta/classes/cve-check.bbclass | 18 +-
 1 file changed, 5 insertions(+), 13 deletions(-)

diff --git a/meta/classes/cve-check.bbclass b/meta/classes/cve-check.bbclass
index c1cbdbde7b..e95716d9de 100644
--- a/meta/classes/cve-check.bbclass
+++ b/meta/classes/cve-check.bbclass
@@ -261,23 +261,15 @@ def check_cves(d, patched_cves):
 def get_cve_info(d, cves):
 """
 Get CVE information from the database.
-
-Unfortunately the only way to get CVE info is set the output to
-html (hard to parse) or query directly the database.
 """
 
-try:
-import sqlite3
-except ImportError:
-from pysqlite2 import dbapi2 as sqlite3
+import sqlite3
 
 cve_data = {}
-db_file = d.getVar("CVE_CHECK_DB_FILE")
-placeholder = ",".join("?" * len(cves))
-query = "SELECT * FROM NVD WHERE id IN (%s)" % placeholder
-conn = sqlite3.connect(db_file)
-cur = conn.cursor()
-for row in cur.execute(query, tuple(cves)):
+conn = sqlite3.connect(d.getVar("CVE_CHECK_DB_FILE"))
+placeholders = ",".join("?" * len(cves))
+query = "SELECT * FROM NVD WHERE id IN (%s)" % placeholders
+for row in conn.execute(query, tuple(cves)):
 cve_data[row[0]] = {}
 cve_data[row[0]]["summary"] = row[1]
 cve_data[row[0]]["scorev2"] = row[2]
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 19/28] cve-update-db-native: add an index on the CVE ID column

2020-01-13 Thread Armin Kuster
From: Ross Burton 

Create an index on the PRODUCTS table which contains a row for each CPE,
drastically increasing the performance of lookups for a specific CVE.

(From OE-Core rev: b4048b05b3a00d85c40d09961f846eadcebd812e)

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie 
Signed-off-by: Armin Kuster 
---
 meta/recipes-core/meta/cve-update-db-native.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-core/meta/cve-update-db-native.bb 
b/meta/recipes-core/meta/cve-update-db-native.bb
index c15534de08..08b18f064f 100644
--- a/meta/recipes-core/meta/cve-update-db-native.bb
+++ b/meta/recipes-core/meta/cve-update-db-native.bb
@@ -120,11 +120,14 @@ python do_populate_cve_db() {
 
 def initialize_db(c):
 c.execute("CREATE TABLE IF NOT EXISTS META (YEAR INTEGER UNIQUE, DATE 
TEXT)")
+
 c.execute("CREATE TABLE IF NOT EXISTS NVD (ID TEXT UNIQUE, SUMMARY TEXT, \
 SCOREV2 TEXT, SCOREV3 TEXT, MODIFIED INTEGER, VECTOR TEXT)")
+
 c.execute("CREATE TABLE IF NOT EXISTS PRODUCTS (ID TEXT, \
 VENDOR TEXT, PRODUCT TEXT, VERSION_START TEXT, OPERATOR_START TEXT, \
 VERSION_END TEXT, OPERATOR_END TEXT)")
+c.execute("CREATE INDEX IF NOT EXISTS PRODUCT_ID_IDX on PRODUCTS(ID);")
 
 def parse_node_and_insert(c, node, cveId):
 # Parse children node if needed
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 16/28] cve-check: we don't actually need to unpack to check

2020-01-13 Thread Armin Kuster
From: Ross Burton 

The patch scanner works with patch files in the layer, not in the workdir, so it
doesn't need to unpack.

(From OE-Core rev: 2cba6ada970deb5156e1ba0182f4f372851e3c17)

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie 
Signed-off-by: Armin Kuster 
---
 meta/classes/cve-check.bbclass | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/meta/classes/cve-check.bbclass b/meta/classes/cve-check.bbclass
index 1c8b2223a2..3326944d79 100644
--- a/meta/classes/cve-check.bbclass
+++ b/meta/classes/cve-check.bbclass
@@ -62,7 +62,7 @@ python do_cve_check () {
 
 }
 
-addtask cve_check after do_unpack before do_build
+addtask cve_check before do_build
 do_cve_check[depends] = "cve-update-db-native:do_populate_cve_db"
 do_cve_check[nostamp] = "1"
 
@@ -70,7 +70,6 @@ python cve_check_cleanup () {
 """
 Delete the file used to gather all the CVE information.
 """
-
 bb.utils.remove(e.data.getVar("CVE_CHECK_TMP_FILE"))
 }
 
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 18/28] cve-update-db-native: don't hardcode the database name

2020-01-13 Thread Armin Kuster
From: Ross Burton 

Don't hardcode the database filename, there's a variable for this in
cve-check.bbclass.

(From OE-Core rev: 0d188a9dc4ae64c64cd661e9d9c3841e86f226ab)

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie 
Signed-off-by: Armin Kuster 
---
 meta/recipes-core/meta/cve-update-db-native.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-core/meta/cve-update-db-native.bb 
b/meta/recipes-core/meta/cve-update-db-native.bb
index 19875a49b1..c15534de08 100644
--- a/meta/recipes-core/meta/cve-update-db-native.bb
+++ b/meta/recipes-core/meta/cve-update-db-native.bb
@@ -28,8 +28,8 @@ python do_populate_cve_db() {
 BASE_URL = "https://nvd.nist.gov/feeds/json/cve/1.0/nvdcve-1.0-;
 YEAR_START = 2002
 
-db_dir = os.path.join(d.getVar("DL_DIR"), 'CVE_CHECK')
-db_file = os.path.join(db_dir, 'nvdcve_1.0.db')
+db_file = d.getVar("CVE_CHECK_DB_FILE")
+db_dir = os.path.dirname(db_file)
 json_tmpfile = os.path.join(db_dir, 'nvd.json.gz')
 
 # Don't refresh the database more than once an hour
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 17/28] cve-update-db-native: don't refresh more than once an hour

2020-01-13 Thread Armin Kuster
From: Ross Burton 

We already fetch the yearly CVE metadata and check that for updates before
downloading the full data, but we can speed up CVE checking further by only
checking the CVE metadata once an hour.

(From OE-Core rev: 50d898fd360c58fe85460517d965f62b7654771a)

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie 
Signed-off-by: Armin Kuster 
---
 meta/recipes-core/meta/cve-update-db-native.bb | 10 +-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-core/meta/cve-update-db-native.bb 
b/meta/recipes-core/meta/cve-update-db-native.bb
index 2c427a5884..19875a49b1 100644
--- a/meta/recipes-core/meta/cve-update-db-native.bb
+++ b/meta/recipes-core/meta/cve-update-db-native.bb
@@ -31,8 +31,16 @@ python do_populate_cve_db() {
 db_dir = os.path.join(d.getVar("DL_DIR"), 'CVE_CHECK')
 db_file = os.path.join(db_dir, 'nvdcve_1.0.db')
 json_tmpfile = os.path.join(db_dir, 'nvd.json.gz')
-proxy = d.getVar("https_proxy")
 
+# Don't refresh the database more than once an hour
+try:
+import time
+if time.time() - os.path.getmtime(db_file) < (60*60):
+return
+except OSError:
+pass
+
+proxy = d.getVar("https_proxy")
 if proxy:
 # instantiate an opener but do not install it as the global
 # opener unless if we're really sure it's applicable for all
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 13/28] sdk: Install nativesdk locales for all TCLIBC variants

2020-01-13 Thread Armin Kuster
From: Khem Raj 

install_locales() here is actually operating on nativesdk and only glibc
is the default library for nativesdk, since thats what most of
desktop/server distros use, therefore bailing out based on TCLIBC is not
needed here, since nativesdk-glibc would be required for all non-glibc
targetting SDKs as well.

Fixes SDK install time error

ERROR:  OE-core's config sanity checker detected a potential misconfiguration.
Either fix the cause of this error or at your own risk disable the checker (see 
sanity.conf).
Following is the list of potential problems / advisories:
Your system needs to support the en_US.UTF-8 locale.
ERROR: SDK preparation failed

Signed-off-by: Khem Raj 
Signed-off-by: Richard Purdie 
Signed-off-by: Armin Kuster 
---
 meta/lib/oe/sdk.py | 4 
 1 file changed, 4 deletions(-)

diff --git a/meta/lib/oe/sdk.py b/meta/lib/oe/sdk.py
index b4fbdb799e..d02a274812 100644
--- a/meta/lib/oe/sdk.py
+++ b/meta/lib/oe/sdk.py
@@ -88,10 +88,6 @@ class Sdk(object, metaclass=ABCMeta):
 bb.warn("cannot remove SDK dir: %s" % path)
 
 def install_locales(self, pm):
-# This is only relevant for glibc
-if self.d.getVar("TCLIBC") != "glibc":
-return
-
 linguas = self.d.getVar("SDKIMAGE_LINGUAS")
 if linguas:
 import fnmatch
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 15/28] cve-check: failure to parse versions should be more visible

2020-01-13 Thread Armin Kuster
From: Ross Burton 

Signed-off-by: Richard Purdie 
Signed-off-by: Armin Kuster 
---
 meta/classes/cve-check.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/cve-check.bbclass b/meta/classes/cve-check.bbclass
index f87bcc9dc6..1c8b2223a2 100644
--- a/meta/classes/cve-check.bbclass
+++ b/meta/classes/cve-check.bbclass
@@ -222,7 +222,7 @@ def check_cves(d, patched_cves):
 to_append_start =  (operator_start == '>=' and 
LooseVersion(pv) >= LooseVersion(version_start))
 to_append_start |= (operator_start == '>' and 
LooseVersion(pv) > LooseVersion(version_start))
 except:
-bb.note("%s: Failed to compare %s %s %s for %s" %
+bb.warn("%s: Failed to compare %s %s %s for %s" %
 (product, pv, operator_start, 
version_start, cve))
 to_append_start = False
 else:
@@ -233,7 +233,7 @@ def check_cves(d, patched_cves):
 to_append_end  = (operator_end == '<=' and 
LooseVersion(pv) <= LooseVersion(version_end))
 to_append_end |= (operator_end == '<' and 
LooseVersion(pv) < LooseVersion(version_end))
 except:
-bb.note("%s: Failed to compare %s %s %s for %s" %
+bb.warn("%s: Failed to compare %s %s %s for %s" %
 (product, pv, operator_end, version_end, 
cve))
 to_append_end = False
 else:
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 14/28] cve-check: ensure all known CVEs are in the report

2020-01-13 Thread Armin Kuster
From: Ross Burton 

CVEs that are whitelisted or were not vulnerable when there are version
comparisons were not included in the report, so alter the logic to ensure that
all relevant CVEs are in the report for completeness.

(From OE-Core rev: 98256ff05fcfe9d5ccad360582c36eafb577c264)

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie 
Signed-off-by: Armin Kuster 
---
 meta/classes/cve-check.bbclass | 9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/meta/classes/cve-check.bbclass b/meta/classes/cve-check.bbclass
index c00d2910be..f87bcc9dc6 100644
--- a/meta/classes/cve-check.bbclass
+++ b/meta/classes/cve-check.bbclass
@@ -208,12 +208,14 @@ def check_cves(d, patched_cves):
 
 if cve in cve_whitelist:
 bb.note("%s-%s has been whitelisted for %s" % (product, pv, 
cve))
+# TODO: this should be in the report as 'whitelisted'
+patched_cves.add(cve)
 elif cve in patched_cves:
 bb.note("%s has been patched" % (cve))
 else:
 to_append = False
 if (operator_start == '=' and pv == version_start):
-cves_unpatched.append(cve)
+to_append = True
 else:
 if operator_start:
 try:
@@ -243,8 +245,11 @@ def check_cves(d, patched_cves):
 to_append = to_append_start or to_append_end
 
 if to_append:
+bb.note("%s-%s is vulnerable to %s" % (product, pv, cve))
 cves_unpatched.append(cve)
-bb.debug(2, "%s-%s is not patched for %s" % (product, pv, cve))
+else:
+bb.note("%s-%s is not vulnerable to %s" % (product, pv, 
cve))
+patched_cves.add(cve)
 conn.close()
 
 return (list(patched_cves), cves_unpatched)
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 11/28] procps: whitelist CVE-2018-1121

2020-01-13 Thread Armin Kuster
From: Ross Burton 

This CVE is about race conditions in 'ps' which make it unsuitable for security
audits.  As these race conditions are unavoidable ps shouldn't be used for
security auditing, so this isn't a valid CVE.

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie 
Signed-off-by: Adrian Bunk 
Signed-off-by: Armin Kuster 
---
 meta/recipes-extended/procps/procps_3.3.15.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-extended/procps/procps_3.3.15.bb 
b/meta/recipes-extended/procps/procps_3.3.15.bb
index 9756db0e7b..a20917b223 100644
--- a/meta/recipes-extended/procps/procps_3.3.15.bb
+++ b/meta/recipes-extended/procps/procps_3.3.15.bb
@@ -64,3 +64,6 @@ python __anonymous() {
 d.setVarFlag('ALTERNATIVE_LINK_NAME', prog, '%s/%s' % 
(d.getVar('base_sbindir'), prog))
 }
 
+# 'ps' isn't suitable for use as a security tool so whitelist this CVE.
+# https://bugzilla.redhat.com/show_bug.cgi?id=1575473#c3
+CVE_CHECK_WHITELIST += "CVE-2018-1121"
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 12/28] libpcap: upgrade 1.9.0 -> 1.9.1

2020-01-13 Thread Armin Kuster
From: Zang Ruochen 

-libpcap/0001-pcap-usb-linux.c-add-missing-limits.h-for-musl-syste.patch
 Removed since this is included in 1.9.1.

Signed-off-by: Zang Ruochen 
Signed-off-by: Richard Purdie 
[CVE-2018-16301 CVE-2019-15161 CVE-2019-15162 CVE-2019-15163 CVE-2019-15164 
CVE-2019-15165]
Signed-off-by: Adrian Bunk 
Signed-off-by: Armin Kuster 
---
 ...-add-missing-limits.h-for-musl-syste.patch | 29 ---
 .../{libpcap_1.9.0.bb => libpcap_1.9.1.bb}|  5 ++--
 2 files changed, 2 insertions(+), 32 deletions(-)
 delete mode 100644 
meta/recipes-connectivity/libpcap/libpcap/0001-pcap-usb-linux.c-add-missing-limits.h-for-musl-syste.patch
 rename meta/recipes-connectivity/libpcap/{libpcap_1.9.0.bb => 
libpcap_1.9.1.bb} (88%)

diff --git 
a/meta/recipes-connectivity/libpcap/libpcap/0001-pcap-usb-linux.c-add-missing-limits.h-for-musl-syste.patch
 
b/meta/recipes-connectivity/libpcap/libpcap/0001-pcap-usb-linux.c-add-missing-limits.h-for-musl-syste.patch
deleted file mode 100644
index 01773834c7..00
--- 
a/meta/recipes-connectivity/libpcap/libpcap/0001-pcap-usb-linux.c-add-missing-limits.h-for-musl-syste.patch
+++ /dev/null
@@ -1,29 +0,0 @@
-From aafa3512b7b742f5e66a5543e41974cc5e7eebfa Mon Sep 17 00:00:00 2001
-From: maxice8 
-Date: Sun, 22 Jul 2018 18:54:17 -0300
-Subject: [PATCH] pcap-usb-linux.c: add missing limits.h for musl systems.
-
-fix compilation on musl libc systems like Void Linux and Alpine.
-
-Upstream-Status: Backport 
[https://github.com/the-tcpdump-group/libpcap/commit/d557c98a16dc254aaff03762b694fe624e180bea]
-
-Signed-off-by: Anuj Mittal 

- pcap-usb-linux.c | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/pcap-usb-linux.c b/pcap-usb-linux.c
-index 6f8adf65..b92c05ea 100644
 a/pcap-usb-linux.c
-+++ b/pcap-usb-linux.c
-@@ -50,6 +50,7 @@
- #include 
- #include 
- #include 
-+#include 
- #include 
- #include 
- #include 
--- 
-2.17.1
-
diff --git a/meta/recipes-connectivity/libpcap/libpcap_1.9.0.bb 
b/meta/recipes-connectivity/libpcap/libpcap_1.9.1.bb
similarity index 88%
rename from meta/recipes-connectivity/libpcap/libpcap_1.9.0.bb
rename to meta/recipes-connectivity/libpcap/libpcap_1.9.1.bb
index 78361561e6..a0f66ac0fa 100644
--- a/meta/recipes-connectivity/libpcap/libpcap_1.9.0.bb
+++ b/meta/recipes-connectivity/libpcap/libpcap_1.9.1.bb
@@ -11,10 +11,9 @@ LIC_FILES_CHKSUM = 
"file://LICENSE;md5=5eb289217c160e2920d2e35bddc36453 \
 DEPENDS = "flex-native bison-native"
 
 SRC_URI = "https://www.tcpdump.org/release/${BP}.tar.gz \
-   
file://0001-pcap-usb-linux.c-add-missing-limits.h-for-musl-syste.patch \
"
-SRC_URI[md5sum] = "dffd65cb14406ab9841f421732eb0f33"
-SRC_URI[sha256sum] = 
"2edb88808e5913fdaa8e9c1fcaf272e19b2485338742b5074b9fe44d68f37019"
+SRC_URI[md5sum] = "21af603d9a591c7d96a6457021d84e6c"
+SRC_URI[sha256sum] = 
"635237637c5b619bcceba91900666b64d56ecb7be63f298f601ec786ce087094"
 
 inherit autotools binconfig-disabled pkgconfig bluetooth
 
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 08/28] libxfont2: set CVE_PRODUCT

2020-01-13 Thread Armin Kuster
From: Chen Qi 

Signed-off-by: Chen Qi 
Signed-off-by: Richard Purdie 
Signed-off-by: Adrian Bunk 
Signed-off-by: Armin Kuster 
---
 meta/recipes-graphics/xorg-lib/libxfont2_2.0.3.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-graphics/xorg-lib/libxfont2_2.0.3.bb 
b/meta/recipes-graphics/xorg-lib/libxfont2_2.0.3.bb
index 2b72d6750c..6994d79e89 100644
--- a/meta/recipes-graphics/xorg-lib/libxfont2_2.0.3.bb
+++ b/meta/recipes-graphics/xorg-lib/libxfont2_2.0.3.bb
@@ -20,3 +20,5 @@ SRC_URI[sha256sum] = 
"0e8ab7fd737ccdfe87e1f02b55f221f0bd4503a1c5f28be4ed6a54586b
 
 PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}"
 PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6,"
+
+CVE_PRODUCT = "libxfont libxfont2"
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 10/28] webkitgtk: set CVE_PRODUCT

2020-01-13 Thread Armin Kuster
From: Chen Qi 

Signed-off-by: Chen Qi 
Signed-off-by: Richard Purdie 
Signed-off-by: Adrian Bunk 
Signed-off-by: Armin Kuster 
---
 meta/recipes-sato/webkit/webkitgtk_2.22.7.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.22.7.bb 
b/meta/recipes-sato/webkit/webkitgtk_2.22.7.bb
index 301bf10cea..26e673cbcb 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.22.7.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.22.7.bb
@@ -30,6 +30,8 @@ inherit cmake pkgconfig gobject-introspection perlnative 
distro_features_check u
 
 REQUIRED_DISTRO_FEATURES = "x11 opengl"
 
+CVE_PRODUCT = "webkitgtk webkitgtk\+"
+
 DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native 
gperf-native sqlite3 \
   pango icu bison-native gawk intltool-native libwebp \
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 09/28] libsndfile1: whitelist CVE-2018-13419

2020-01-13 Thread Armin Kuster
From: Ross Burton 

This is a memory leak that nobody else can replicate and has been rejected by
upstream.

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie 
Signed-off-by: Adrian Bunk 
Signed-off-by: Armin Kuster 
---
 meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb 
b/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb
index 77393db847..6044bf09c7 100644
--- a/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb
+++ b/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb
@@ -38,3 +38,6 @@ do_configure_prepend_arm() {
export ac_cv_sys_file_offset_bits=64
 }
 
+# This can't be replicated and is just a memory leak.
+# https://github.com/erikd/libsndfile/issues/398
+CVE_CHECK_WHITELIST += "CVE-2018-13419"
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 01/28] openssl: set CVE vendor to openssl

2020-01-13 Thread Armin Kuster
From: Anuj Mittal 

Differentiate it from openssl gem for Ruby.

Signed-off-by: Anuj Mittal 
Signed-off-by: Richard Purdie 
Signed-off-by: Adrian Bunk 
Signed-off-by: Armin Kuster 
---
 meta/recipes-connectivity/openssl/openssl_1.1.1b.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.1b.bb 
b/meta/recipes-connectivity/openssl/openssl_1.1.1b.bb
index 9e36df807c..13e6ad4db7 100644
--- a/meta/recipes-connectivity/openssl/openssl_1.1.1b.bb
+++ b/meta/recipes-connectivity/openssl/openssl_1.1.1b.bb
@@ -204,3 +204,5 @@ RREPLACES_openssl-conf = "openssl10-conf"
 RCONFLICTS_openssl-conf = "openssl10-conf"
 
 BBCLASSEXTEND = "native nativesdk"
+
+CVE_PRODUCT = "openssl:openssl"
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 03/28] git: set CVE vendor to git-scm

2020-01-13 Thread Armin Kuster
From: Ross Burton 

There's a Jenkins plugin for Git.

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie 
Signed-off-by: Adrian Bunk 
Signed-off-by: Armin Kuster 
---
 meta/recipes-devtools/git/git.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-devtools/git/git.inc 
b/meta/recipes-devtools/git/git.inc
index 26a22ac1e8..6e137432f0 100644
--- a/meta/recipes-devtools/git/git.inc
+++ b/meta/recipes-devtools/git/git.inc
@@ -13,6 +13,8 @@ S = "${WORKDIR}/git-${PV}"
 
 LIC_FILES_CHKSUM = "file://COPYING;md5=7c0d7ef03a7eb04ce795b0f60e68e7e1"
 
+CVE_PRODUCT = "git-scm:git"
+
 PACKAGECONFIG ??= ""
 PACKAGECONFIG[cvsserver] = ""
 PACKAGECONFIG[svn] = ""
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 06/28] boost: set CVE vendor to Boost

2020-01-13 Thread Armin Kuster
From: Ross Burton 

There's a Boost module for Drupal.

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie 
Signed-off-by: Adrian Bunk 
Signed-off-by: Armin Kuster 
---
 meta/recipes-support/boost/boost.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-support/boost/boost.inc 
b/meta/recipes-support/boost/boost.inc
index c2e2cbb352..f385541653 100644
--- a/meta/recipes-support/boost/boost.inc
+++ b/meta/recipes-support/boost/boost.inc
@@ -2,6 +2,8 @@ SUMMARY = "Free peer-reviewed portable C++ source libraries"
 SECTION = "libs"
 DEPENDS = "bjam-native zlib bzip2"
 
+CVE_PRODUCT = "boost:boost"
+
 ARM_INSTRUCTION_SET_armv4 = "arm"
 ARM_INSTRUCTION_SET_armv5 = "arm"
 
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 04/28] subversion: set CVE vendor to Apache

2020-01-13 Thread Armin Kuster
From: Ross Burton 

There's a Jenkins plugin for Subversion.

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie 
Signed-off-by: Adrian Bunk 
Signed-off-by: Armin Kuster 
---
 meta/recipes-devtools/subversion/subversion_1.11.1.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-devtools/subversion/subversion_1.11.1.bb 
b/meta/recipes-devtools/subversion/subversion_1.11.1.bb
index 8abac7408e..9909461bf7 100644
--- a/meta/recipes-devtools/subversion/subversion_1.11.1.bb
+++ b/meta/recipes-devtools/subversion/subversion_1.11.1.bb
@@ -18,6 +18,8 @@ SRC_URI[sha256sum] = 
"9efd2750ca4d72ec903431a24b9c732b6cbb84aad9b7563f59dd96dea5
 
 inherit autotools pkgconfig gettext
 
+CVE_PRODUCT = "apache:subversion"
+
 PACKAGECONFIG ?= ""
 
 PACKAGECONFIG[sasl] = "--with-sasl,--without-sasl,cyrus-sasl"
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 00/28] Patch review

2020-01-13 Thread Armin Kuster
Please have review comments back by Wednesday

The following changes since commit 7009d823a0799ce7132bd77329b273a476718c8c:

  python: update to 2.7.17 (2019-11-23 21:01:39 -0800)

are available in the Git repository at:

  git://git.openembedded.org/openembedded-core-contrib stable/warrior-nut
  http://cgit.openembedded.org//log/?h=stable/warrior-nut

Alexander Kanavin (1):
  sudo: correct SRC_URI

Anuj Mittal (1):
  openssl: set CVE vendor to openssl

Armin Kuster (1):
  stress: update SRC_URI

Chen Qi (2):
  libxfont2: set CVE_PRODUCT
  webkitgtk: set CVE_PRODUCT

Ferry Toth (1):
  sudo: Fix fetching sources

Khem Raj (1):
  sdk: Install nativesdk locales for all TCLIBC variants

Niko Mauno (1):
  cve-check: Switch to NVD CVE JSON feed version 1.1

Oleksandr Kravchuk (1):
  popt: fix SRC_URI

Ross Burton (18):
  flex: set CVE_PRODUCT to include vendor
  git: set CVE vendor to git-scm
  subversion: set CVE vendor to Apache
  ed: set CVE vendor to avoid false positives
  boost: set CVE vendor to Boost
  libpam: set CVE_PRODUCT
  libsndfile1: whitelist CVE-2018-13419
  procps: whitelist CVE-2018-1121
  cve-check: ensure all known CVEs are in the report
  cve-check: failure to parse versions should be more visible
  cve-check: we don't actually need to unpack to check
  cve-update-db-native: don't refresh more than once an hour
  cve-update-db-native: don't hardcode the database name
  cve-update-db-native: add an index on the CVE ID column
  cve-update-db-native: clean up proxy handling
  cve-check: rewrite look to fix false negatives
  cve-check: neaten get_cve_info
  cve-check: fetch CVE data once at a time instead of in a single call

Zang Ruochen (1):
  libpcap: upgrade 1.9.0 -> 1.9.1

 meta/classes/cve-check.bbclass| 105 +-
 meta/lib/oe/sdk.py|   4 -
 ...-add-missing-limits.h-for-musl-syste.patch |  29 -
 .../{libpcap_1.9.0.bb => libpcap_1.9.1.bb}|   5 +-
 .../openssl/openssl_1.1.1b.bb |   2 +
 .../recipes-core/meta/cve-update-db-native.bb |  46 +++-
 meta/recipes-devtools/flex/flex_2.6.0.bb  |   3 +
 meta/recipes-devtools/git/git.inc |   2 +
 .../subversion/subversion_1.11.1.bb   |   2 +
 meta/recipes-extended/ed/ed_1.15.bb   |   2 +
 meta/recipes-extended/pam/libpam_1.3.0.bb |   2 +
 meta/recipes-extended/procps/procps_3.3.15.bb |   3 +
 meta/recipes-extended/stress/stress_1.0.4.bb  |   2 +-
 meta/recipes-extended/sudo/sudo_1.8.27.bb |   2 +-
 .../xorg-lib/libxfont2_2.0.3.bb   |   2 +
 .../libsndfile/libsndfile1_1.0.28.bb  |   3 +
 meta/recipes-sato/webkit/webkitgtk_2.22.7.bb  |   2 +
 meta/recipes-support/boost/boost.inc  |   2 +
 meta/recipes-support/popt/popt_1.16.bb|   2 +-
 19 files changed, 101 insertions(+), 119 deletions(-)
 delete mode 100644 
meta/recipes-connectivity/libpcap/libpcap/0001-pcap-usb-linux.c-add-missing-limits.h-for-musl-syste.patch
 rename meta/recipes-connectivity/libpcap/{libpcap_1.9.0.bb => 
libpcap_1.9.1.bb} (88%)

-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 07/28] libpam: set CVE_PRODUCT

2020-01-13 Thread Armin Kuster
From: Ross Burton 

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie 
Signed-off-by: Adrian Bunk 
Signed-off-by: Armin Kuster 
---
 meta/recipes-extended/pam/libpam_1.3.0.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-extended/pam/libpam_1.3.0.bb 
b/meta/recipes-extended/pam/libpam_1.3.0.bb
index c124e3bb02..ad6ac4b701 100644
--- a/meta/recipes-extended/pam/libpam_1.3.0.bb
+++ b/meta/recipes-extended/pam/libpam_1.3.0.bb
@@ -164,3 +164,5 @@ CONFFILES_${PN}-runtime += 
"${sysconfdir}/pam.d/common-password"
 CONFFILES_${PN}-runtime += "${sysconfdir}/pam.d/common-session-noninteractive"
 CONFFILES_${PN}-runtime += "${sysconfdir}/pam.d/common-account"
 CONFFILES_${PN}-runtime += "${sysconfdir}/security/limits.conf"
+
+CVE_PRODUCT = "linux-pam"
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 02/28] flex: set CVE_PRODUCT to include vendor

2020-01-13 Thread Armin Kuster
From: Ross Burton 

There are many projects called Flex and they have CVEs, so also set the vendor
to remove these false positives.

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie 
Signed-off-by: Adrian Bunk 
Signed-off-by: Armin Kuster 
---
 meta/recipes-devtools/flex/flex_2.6.0.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-devtools/flex/flex_2.6.0.bb 
b/meta/recipes-devtools/flex/flex_2.6.0.bb
index b477cd8c7f..12ce0cb461 100644
--- a/meta/recipes-devtools/flex/flex_2.6.0.bb
+++ b/meta/recipes-devtools/flex/flex_2.6.0.bb
@@ -68,3 +68,6 @@ do_install_ptest() {
-e 's/^builddir = \(.*\)/builddir = ./' -e 's/^top_builddir = 
\(.*\)/top_builddir = ./' \
-i ${D}${PTEST_PATH}/Makefile
 }
+
+# Not Apache Flex, or Adobe Flex, or IBM Flex.
+CVE_PRODUCT = "flex_project:flex"
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [warrior 05/28] ed: set CVE vendor to avoid false positives

2020-01-13 Thread Armin Kuster
From: Ross Burton 

Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie 
Signed-off-by: Adrian Bunk 
Signed-off-by: Armin Kuster 
---
 meta/recipes-extended/ed/ed_1.15.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-extended/ed/ed_1.15.bb 
b/meta/recipes-extended/ed/ed_1.15.bb
index c79310325f..886c3ddcab 100644
--- a/meta/recipes-extended/ed/ed_1.15.bb
+++ b/meta/recipes-extended/ed/ed_1.15.bb
@@ -9,6 +9,8 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=0c7051aef9219dc7237f206c5c4179a7 \
 
 SECTION = "base"
 
+CVE_PRODUCT = "gnu:ed"
+
 # LSB states that ed should be in /bin/
 bindir = "${base_bindir}"
 
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH] wic: add UEFI kernel as UEFI stub

2020-01-13 Thread Maxim Uvarov
On Mon, 13 Jan 2020 at 16:57, Paul Barker  wrote:
>
> On Sat, 4 Jan 2020, at 20:07, Maxim Uvarov wrote:
> > Linux kernel can be compiled as UEFI stub and loaded directly
> > with UEFI firmware without grub or other UEFI shell.
> >
> > Tested with wic file:
> > bootloader  --ptable gpt --timeout=0  --append="rootwait"
> > part /boot --source bootimg-efi --sourceparams="loader=kernel" \
> >  --ondisk sda  --fstype=vfat --label bootfs \
> >   --active --align 1024 --use-uuid
> > part / --source rootfs --fstype=ext4 --label rootfs \
> >   --align 1024 --exclude-path boot/ --use-label
> > The same wic file for armv7, armv8 and x86_64.
> >
> > Signed-off-by: Maxim Uvarov 
> > ---
> >  scripts/lib/wic/plugins/source/bootimg-efi.py | 27 +++
> >  1 file changed, 27 insertions(+)
> >
> > diff --git a/scripts/lib/wic/plugins/source/bootimg-efi.py
> > b/scripts/lib/wic/plugins/source/bootimg-efi.py
> > index 2cfdc10ecd..a39d852f6a 100644
> > --- a/scripts/lib/wic/plugins/source/bootimg-efi.py
> > +++ b/scripts/lib/wic/plugins/source/bootimg-efi.py
> > @@ -13,6 +13,7 @@
> >  import logging
> >  import os
> >  import shutil
> > +import re
> >
> >  from wic import WicError
> >  from wic.engine import get_custom_config
> > @@ -204,6 +205,8 @@ class BootimgEFIPlugin(SourcePlugin):
> >  cls.do_configure_grubefi(hdddir, creator, cr_workdir,
> > source_params)
> >  elif source_params['loader'] == 'systemd-boot':
> >  cls.do_configure_systemdboot(hdddir, creator,
> > cr_workdir, source_params)
> > +elif source_params['loader'] == 'kernel':
> > +return
> >  else:
> >  raise WicError("unrecognized bootimg-efi loader: %s" %
> > source_params['loader'])
> >  except KeyError:
> > @@ -243,6 +246,7 @@ class BootimgEFIPlugin(SourcePlugin):
> >  if source_params['loader'] == 'grub-efi':
> >  shutil.copyfile("%s/hdd/boot/EFI/BOOT/grub.cfg" %
> > cr_workdir,
> >  "%s/grub.cfg" % cr_workdir)
> > +
> >  for mod in [x for x in os.listdir(kernel_dir) if
> > x.startswith("grub-efi-")]:
> >  cp_cmd = "cp %s/%s %s/EFI/BOOT/%s" % (kernel_dir,
> > mod, hdddir, mod[9:])
> >  exec_cmd(cp_cmd, True)
> > @@ -252,6 +256,29 @@ class BootimgEFIPlugin(SourcePlugin):
> >  for mod in [x for x in os.listdir(kernel_dir) if
> > x.startswith("systemd-")]:
> >  cp_cmd = "cp %s/%s %s/EFI/BOOT/%s" % (kernel_dir,
> > mod, hdddir, mod[8:])
> >  exec_cmd(cp_cmd, True)
> > +elif source_params['loader'] == 'kernel':
>
> How about "uefi-stub" instead of just "kernel" here so it's more explicit?
>

It's the same file were other uefi stubs are defined (grub and
systemd), so I named kernel uefi stub as kernel.

> > +kernel = get_bitbake_var("KERNEL_IMAGETYPE")
> > +if not kernel:
> > +raise WicError("Empty KERNEL_IMAGETYPE %s\n" %
> > target)
> > +target = get_bitbake_var("TARGET_SYS")
> > +if not target:
> > +raise WicError("Unknown arch (TARGET_SYS) %s\n" %
> > target)
> > +
> > +if re.match("x86_64", target):
> > +kernel_efi_image = "bootx64.efi"
> > +elif re.match('i.86', target):
> > +kernel_efi_image = "bootia32.efi"
> > +elif re.match('aarch64', target):
> > +kernel_efi_image = "bootaa64.efi"
> > +elif re.match('arm', target):
> > +kernel_efi_image = "bootarm.efi"
> > +else:
> > +raise WicError("kernel efi is incompatible with
> > target %s" % target)
>
> Perhaps call this "UEFI stub kernel" instead of just "kernel efi" to make 
> things clearer.
>

Ok.

> > +
> > +for mod in [x for x in os.listdir(kernel_dir) if
> > x.startswith(kernel)]:
> > +cp_cmd = "cp %s/%s %s/EFI/BOOT/%s" % (kernel_dir,
> > mod, hdddir, kernel_efi_image)
> > +WicError("cp_cmd = %s" % cp_cmd);
>
> What's this WicError created here for?
>

Good catch. Debug print. Will send v2.

> > +exec_cmd(cp_cmd, True)
>
> Wouldn't this result in the destination file being overwritten each time 
> through this loop? I guess you're just copying from the grub-efi 
> implementation above though.
>

It's expected that there are no other uefi stubs and I just copy
kernel to /EFI/BOOT/bootxxx.efi.

Maxim.

> >  else:
> >  raise WicError("unrecognized bootimg-efi loader: %s" %
> > source_params['loader'])
> > --
> > 2.17.1
>
> --
> Paul Barker
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org

Re: [OE-core] busybox: udhcpc: fix IPv6 support when using udhcpc

2020-01-13 Thread Quentin Schulz
Hi all,

On Mon, May 14, 2018 at 04:44:15PM +0200, Stefan Agner wrote:
> From: Stefan Agner 
> 
> The udhcpc script calls ip addr flush .. which flushes addresses
> of any address family, including IPv6. However, busybox udhcpc is
> IPv4 only and should not influence IPv6 addressing. Hence use ip
> addr flush with family constrait.
> 
> The script particularly broke IPv6 SLAAC: Typically when udhcpc
> calls the script the kernel already assigned the IPv6 link-local
> address. The flush removes the link-local IPv6 address again and
> prohibits proper IPv6 operation such as SLAAC since neighbor
> discovery protocol relies on IPv6 link-local addressing.
> 
> Signed-off-by: Stefan Agner 
> ---
>  meta/recipes-core/busybox/files/simple.script | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/busybox/files/simple.script 
> b/meta/recipes-core/busybox/files/simple.script
> index 6ed0293525..8b5eb53633 100644
> --- a/meta/recipes-core/busybox/files/simple.script
> +++ b/meta/recipes-core/busybox/files/simple.script
> @@ -28,7 +28,7 @@ case "$1" in
>   fi
>   if ! root_is_nfs ; then
>  if [ $have_bin_ip -eq 1 ]; then
> -/SBIN_DIR/ip addr flush dev $interface
> +/SBIN_DIR/ip -4 addr flush dev $interface
>  /SBIN_DIR/ip link set dev $interface up
>  else
>  /SBIN_DIR/ifconfig $interface 0.0.0.0

Kindly pinging, happened to us as well many times.

OT: Didn't have the original mail, so hopefully getting the mbox file
and answering to it didn't trigger anything weird somewhere :)

Thanks,
Quentin
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 04/12] gstreamer1.0-plugins-good: Transition to meson based builds

2020-01-13 Thread Carlos Rafael Giani
Actually, you have a point. I seem to have forgotten to fix this in this 
patch. With meson, it appears that the meta-qt5 bbappend is no longer 
necessary, since meson finds the Qt5 moc/rcc/uic tools on its own, so a 
packageconfig could be added right here. However, I'd like to 
investigate that moc/rcc/uic autodetection more to be sure it does not 
bring with it some "surprises" that could bite us in the behind when 
doing production builds.


On 13.01.20 01:52, Khem Raj wrote:

On Sun, Jan 12, 2020 at 6:33 AM Carlos Rafael Giani  wrote:

* Removed autotools/M4 related patch
   0001-introspection.m4-prefix-pkgconfig-paths-with-PKG_CON.patch.

* gtk-doc support is handled here, not in gstreamer1.0-plugins-common.inc,
 since unlike with autotools, only some plugin set packages use gtk-doc.

* zlib is no longer optional, and glib anyway depends on zlib, therefore
 it gets added to the DEPENDS list.

* gettext handling now part of gstreamer1.0-plugins-common.inc.

Signed-off-by: Carlos Rafael Giani 
---
  .../gstreamer1.0-plugins-good_1.16.1.bb   | 79 +--
  1 file changed, 38 insertions(+), 41 deletions(-)

diff --git 
a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb 
b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb
index 0fa7b86ffe..a6eb9986dd 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb
@@ -1,8 +1,7 @@
-require gstreamer1.0-plugins.inc
+require gstreamer1.0-plugins-common.inc

  SRC_URI = " \
  
https://gstreamer.freedesktop.org/src/gst-plugins-good/gst-plugins-good-${PV}.tar.xz
 \
-
file://0001-introspection.m4-prefix-pkgconfig-paths-with-PKG_CON.patch \
  "

  SRC_URI[md5sum] = "515987ee763256840a11bd8ea098f2bf"
@@ -15,42 +14,41 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \
  
file://common/coverage/coverage-report.pl;beginline=2;endline=17;md5=a4e1830fce078028c8f0974161272607
 \
  
file://gst/replaygain/rganalysis.c;beginline=1;endline=23;md5=b60ebefd5b2f5a8e0cab6bfee391a5fe"

-DEPENDS += "gstreamer1.0-plugins-base libcap"
+DEPENDS += "gstreamer1.0-plugins-base libcap zlib"
  RPROVIDES_${PN}-pulseaudio += "${PN}-pulse"
  RPROVIDES_${PN}-soup += "${PN}-souphttpsrc"

-inherit gettext
-
  PACKAGECONFIG ??= " \
  ${GSTREAMER_ORC} \
  ${@bb.utils.filter('DISTRO_FEATURES', 'pulseaudio x11', d)} \
-bz2 cairo flac gdk-pixbuf gudev jpeg lame libpng mpg123 soup speex taglib 
v4l2 zlib \
+bz2 cairo flac gdk-pixbuf gudev jpeg lame libpng mpg123 soup speex taglib 
v4l2 \
  "

  X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes libxdamage"
+X11ENABLEOPTS = "-Dximagesrc=enabled -Dximagesrc-xshm=enabled 
-Dximagesrc-xfixes=enabled -Dximagesrc-xdamage=enabled"
+X11DISABLEOPTS = "-Dximagesrc=disabled -Dximagesrc-xshm=disabled 
-Dximagesrc-xfixes=disabled -Dximagesrc-xdamage=disabled"

-PACKAGECONFIG[bz2]= "--enable-bz2,--disable-bz2,bzip2"
-PACKAGECONFIG[cairo]  = "--enable-cairo,--disable-cairo,cairo"
-PACKAGECONFIG[dv1394] = "--enable-dv1394,--disable-dv1394,libiec61883 
libavc1394 libraw1394"
-PACKAGECONFIG[flac]   = "--enable-flac,--disable-flac,flac"
-PACKAGECONFIG[gdk-pixbuf] = 
"--enable-gdk_pixbuf,--disable-gdk_pixbuf,gdk-pixbuf"
-PACKAGECONFIG[gtk]= "--enable-gtk3,--disable-gtk3,gtk+3"
-PACKAGECONFIG[gudev]  = "--with-gudev,--without-gudev,libgudev"
-PACKAGECONFIG[jack]   = "--enable-jack,--disable-jack,jack"
-PACKAGECONFIG[jpeg]   = "--enable-jpeg,--disable-jpeg,jpeg"
-PACKAGECONFIG[lame]   = "--enable-lame,--disable-lame,lame"
-PACKAGECONFIG[libpng] = "--enable-libpng,--disable-libpng,libpng"
-PACKAGECONFIG[libv4l2]= "--with-libv4l2,--without-libv4l2,v4l-utils"
-PACKAGECONFIG[mpg123] = "--enable-mpg123,--disable-mpg123,mpg123"
-PACKAGECONFIG[pulseaudio] = "--enable-pulse,--disable-pulse,pulseaudio"
-PACKAGECONFIG[soup]   = "--enable-soup,--disable-soup,libsoup-2.4"
-PACKAGECONFIG[speex]  = "--enable-speex,--disable-speex,speex"
-PACKAGECONFIG[taglib] = "--enable-taglib,--disable-taglib,taglib"
-PACKAGECONFIG[v4l2]   = "--enable-gst_v4l2 
--enable-v4l2-probe,--disable-gst_v4l2"
-PACKAGECONFIG[vpx]= "--enable-vpx,--disable-vpx,libvpx"
-PACKAGECONFIG[wavpack]= "--enable-wavpack,--disable-wavpack,wavpack"
-PACKAGECONFIG[x11]= "--enable-x,--disable-x,${X11DEPENDS}"
-PACKAGECONFIG[zlib]   = "--enable-zlib,--disable-zlib,zlib"
+PACKAGECONFIG[bz2]= "-Dbz2=enabled,-Dbz2=disabled,bzip2"
+PACKAGECONFIG[cairo]  = "-Dcairo=enabled,-Dcairo=disabled,cairo"
+PACKAGECONFIG[dv1394] = "-Ddv1394=enabled,-Ddv1394=disabled,libiec61883 
libavc1394 libraw1394"
+PACKAGECONFIG[flac]   = "-Dflac=enabled,-Dflac=disabled,flac"
+PACKAGECONFIG[gdk-pixbuf] = 
"-Dgdk-pixbuf=enabled,-Dgdk-pixbuf=disabled,gdk-pixbuf"

Re: [OE-core] [PATCH 05/28] python3: update to 3.8.1

2020-01-13 Thread Alexander Kanavin
On Thu, 9 Jan 2020 at 23:14, Richard Purdie <
richard.pur...@linuxfoundation.org> wrote:

> On Thu, 2020-01-09 at 20:49 +0100, Alexander Kanavin wrote:
> > The problem is, I couldn't reproduce this locally at all. Random
> > glitch?
>
> No, its happened on multiple workers and there should be a pattern, we
> just don't understand it yet :(. I don't have ideas right now although
> the build user is 1000 on many machines, 6000 is a minority.
>

I guess we'll have to save the build folder on next failure and inspect
that.

Alex
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCHv2] wic: fix images build in parallel

2020-01-13 Thread Maxim Uvarov
On Mon, 13 Jan 2020 at 17:00, Paul Barker  wrote:
>
> On Mon, 13 Jan 2020 at 13:57, Maxim Uvarov  wrote:
> >
> > On Mon, 13 Jan 2020 at 16:31, Paul Barker  wrote:
> > >
> > > On Mon, 13 Jan 2020 at 13:08, Maxim Uvarov  
> > > wrote:
> > > >
> > > > OE wic plugins create temporary file with the index of the line
> > > > tmp file name. This causes race in case several builds run in time.
> > > > Add more entropy as timestamp to remove this race.
> > >
> > > How would two wic images to be built in parallel with the same work
> > > directory? To my understanding an image recipe only supports building
> > > a single wic image.
> > >
> > > Thanks,
> > > Paul
> >
> > bitbake image1 image2 image3
> > all images build .wics and use about the same files, like firmware.
> > Issue is similar to that:
> > https://www.yoctoproject.org/pipermail/yocto/2018-June/041373.html
>
> Each image has its own work directory though.
>
> I'll take a look in more detail later today or tomorrow, if wic is
> writing temporary files outside of the work directory then that's a
> bug and should be fixed.

Thanks. I saw bug in rawcopy plugin. All other places were patched due
to the same code.  I guess then for rawcopy temp files are in
DEST_IMAGE_DIR (which is common) instead of WORKDIR.

Maxim.
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 04/12] gstreamer1.0-plugins-good: Transition to meson based builds

2020-01-13 Thread Adrian Bunk
On Sun, Jan 12, 2020 at 04:52:24PM -0800, Khem Raj wrote:
> On Sun, Jan 12, 2020 at 6:33 AM Carlos Rafael Giani  
> wrote:
>...
> >  # qt5 support is disabled, because it is not present in OE core, and 
> > requires more work than
> >  # just adding a packageconfig (it requires access to moc, uic, rcc, and 
> > qmake paths).
>...
> > ---disable-qt \
> 
> Dont disable it explicitly, meta-qt5 will has a packageconfig for it.
>...

You are commenting on the previous removed code,
qt5 support unconditionally disabled is invariant here.

cu
Adrian
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH] wic: add UEFI kernel as UEFI stub

2020-01-13 Thread Paul Barker
On Sat, 4 Jan 2020, at 20:07, Maxim Uvarov wrote:
> Linux kernel can be compiled as UEFI stub and loaded directly
> with UEFI firmware without grub or other UEFI shell.
> 
> Tested with wic file:
> bootloader  --ptable gpt --timeout=0  --append="rootwait"
> part /boot --source bootimg-efi --sourceparams="loader=kernel" \
>  --ondisk sda  --fstype=vfat --label bootfs \
>   --active --align 1024 --use-uuid
> part / --source rootfs --fstype=ext4 --label rootfs \
>   --align 1024 --exclude-path boot/ --use-label
> The same wic file for armv7, armv8 and x86_64.
> 
> Signed-off-by: Maxim Uvarov 
> ---
>  scripts/lib/wic/plugins/source/bootimg-efi.py | 27 +++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/scripts/lib/wic/plugins/source/bootimg-efi.py 
> b/scripts/lib/wic/plugins/source/bootimg-efi.py
> index 2cfdc10ecd..a39d852f6a 100644
> --- a/scripts/lib/wic/plugins/source/bootimg-efi.py
> +++ b/scripts/lib/wic/plugins/source/bootimg-efi.py
> @@ -13,6 +13,7 @@
>  import logging
>  import os
>  import shutil
> +import re
>  
>  from wic import WicError
>  from wic.engine import get_custom_config
> @@ -204,6 +205,8 @@ class BootimgEFIPlugin(SourcePlugin):
>  cls.do_configure_grubefi(hdddir, creator, cr_workdir, 
> source_params)
>  elif source_params['loader'] == 'systemd-boot':
>  cls.do_configure_systemdboot(hdddir, creator, 
> cr_workdir, source_params)
> +elif source_params['loader'] == 'kernel':
> +return
>  else:
>  raise WicError("unrecognized bootimg-efi loader: %s" % 
> source_params['loader'])
>  except KeyError:
> @@ -243,6 +246,7 @@ class BootimgEFIPlugin(SourcePlugin):
>  if source_params['loader'] == 'grub-efi':
>  shutil.copyfile("%s/hdd/boot/EFI/BOOT/grub.cfg" % 
> cr_workdir,
>  "%s/grub.cfg" % cr_workdir)
> +
>  for mod in [x for x in os.listdir(kernel_dir) if 
> x.startswith("grub-efi-")]:
>  cp_cmd = "cp %s/%s %s/EFI/BOOT/%s" % (kernel_dir, 
> mod, hdddir, mod[9:])
>  exec_cmd(cp_cmd, True)
> @@ -252,6 +256,29 @@ class BootimgEFIPlugin(SourcePlugin):
>  for mod in [x for x in os.listdir(kernel_dir) if 
> x.startswith("systemd-")]:
>  cp_cmd = "cp %s/%s %s/EFI/BOOT/%s" % (kernel_dir, 
> mod, hdddir, mod[8:])
>  exec_cmd(cp_cmd, True)
> +elif source_params['loader'] == 'kernel':

How about "uefi-stub" instead of just "kernel" here so it's more explicit?

> +kernel = get_bitbake_var("KERNEL_IMAGETYPE")
> +if not kernel:
> +raise WicError("Empty KERNEL_IMAGETYPE %s\n" % 
> target)
> +target = get_bitbake_var("TARGET_SYS")
> +if not target:
> +raise WicError("Unknown arch (TARGET_SYS) %s\n" % 
> target)
> +
> +if re.match("x86_64", target):
> +kernel_efi_image = "bootx64.efi"
> +elif re.match('i.86', target):
> +kernel_efi_image = "bootia32.efi"
> +elif re.match('aarch64', target):
> +kernel_efi_image = "bootaa64.efi"
> +elif re.match('arm', target):
> +kernel_efi_image = "bootarm.efi"
> +else:
> +raise WicError("kernel efi is incompatible with 
> target %s" % target)

Perhaps call this "UEFI stub kernel" instead of just "kernel efi" to make 
things clearer.

> +
> +for mod in [x for x in os.listdir(kernel_dir) if 
> x.startswith(kernel)]:
> +cp_cmd = "cp %s/%s %s/EFI/BOOT/%s" % (kernel_dir, 
> mod, hdddir, kernel_efi_image)
> +WicError("cp_cmd = %s" % cp_cmd);

What's this WicError created here for?

> +exec_cmd(cp_cmd, True)

Wouldn't this result in the destination file being overwritten each time 
through this loop? I guess you're just copying from the grub-efi implementation 
above though.

>  else:
>  raise WicError("unrecognized bootimg-efi loader: %s" %
> source_params['loader'])
> -- 
> 2.17.1

-- 
Paul Barker
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCHv2] wic: fix images build in parallel

2020-01-13 Thread Paul Barker
On Mon, 13 Jan 2020 at 13:57, Maxim Uvarov  wrote:
>
> On Mon, 13 Jan 2020 at 16:31, Paul Barker  wrote:
> >
> > On Mon, 13 Jan 2020 at 13:08, Maxim Uvarov  wrote:
> > >
> > > OE wic plugins create temporary file with the index of the line
> > > tmp file name. This causes race in case several builds run in time.
> > > Add more entropy as timestamp to remove this race.
> >
> > How would two wic images to be built in parallel with the same work
> > directory? To my understanding an image recipe only supports building
> > a single wic image.
> >
> > Thanks,
> > Paul
>
> bitbake image1 image2 image3
> all images build .wics and use about the same files, like firmware.
> Issue is similar to that:
> https://www.yoctoproject.org/pipermail/yocto/2018-June/041373.html

Each image has its own work directory though.

I'll take a look in more detail later today or tomorrow, if wic is
writing temporary files outside of the work directory then that's a
bug and should be fixed.
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCHv2] wic: fix images build in parallel

2020-01-13 Thread Maxim Uvarov
On Mon, 13 Jan 2020 at 16:31, Paul Barker  wrote:
>
> On Mon, 13 Jan 2020 at 13:08, Maxim Uvarov  wrote:
> >
> > OE wic plugins create temporary file with the index of the line
> > tmp file name. This causes race in case several builds run in time.
> > Add more entropy as timestamp to remove this race.
>
> How would two wic images to be built in parallel with the same work
> directory? To my understanding an image recipe only supports building
> a single wic image.
>
> Thanks,
> Paul

bitbake image1 image2 image3
all images build .wics and use about the same files, like firmware.
Issue is similar to that:
https://www.yoctoproject.org/pipermail/yocto/2018-June/041373.html

Maxim.
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCHv2] wic: fix images build in parallel

2020-01-13 Thread Paul Barker
On Mon, 13 Jan 2020 at 13:08, Maxim Uvarov  wrote:
>
> OE wic plugins create temporary file with the index of the line
> tmp file name. This causes race in case several builds run in time.
> Add more entropy as timestamp to remove this race.

How would two wic images to be built in parallel with the same work
directory? To my understanding an image recipe only supports building
a single wic image.

Thanks,
Paul
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH] wic: add UEFI kernel as UEFI stub

2020-01-13 Thread Maxim Uvarov
Can this patch be applied without embedded test?

On Thu, 9 Jan 2020 at 14:47, Maxim Uvarov  wrote:
>
> On Sun, 5 Jan 2020 at 17:52, Richard Purdie
>  wrote:
> >
> > On Sat, 2020-01-04 at 23:07 +0300, Maxim Uvarov wrote:
> > > Linux kernel can be compiled as UEFI stub and loaded directly
> > > with UEFI firmware without grub or other UEFI shell.
> > >
> > > Tested with wic file:
> > > bootloader  --ptable gpt --timeout=0  --append="rootwait"
> > > part /boot --source bootimg-efi --sourceparams="loader=kernel" \
> > >  --ondisk sda  --fstype=vfat --label bootfs \
> > >   --active --align 1024 --use-uuid
> > > part / --source rootfs --fstype=ext4 --label rootfs \
> > >   --align 1024 --exclude-path boot/ --use-label
> > > The same wic file for armv7, armv8 and x86_64.
> > >
> > > Signed-off-by: Maxim Uvarov 
> > > ---
> > >  scripts/lib/wic/plugins/source/bootimg-efi.py | 27
> > > +++
> > >  1 file changed, 27 insertions(+)
> >
> > wic has fairly complete tests, do we need to add a test for the new
> > functionality?
> >
> > ("oe-selftest -r wic")
> >
> > Cheers,
> >
> > Richard
> >
> I'm currently looking to zeus branch and it looks like test uses this file:
> openembedded-core/meta-selftest/./recipes-test/images/wic-image-minimal.wks
>
> I think it will be good to add test for --source bootimg-efi
> --sourceparams="loader=kernel".
> Do you want to change wic-image-minimal.wks? Or just put this file to
> openembedded-core/meta-selftest/wic/
> directory and somehow it will be tested?
>
> Maxim.
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCHv2] wic: fix images build in parallel

2020-01-13 Thread Maxim Uvarov
OE wic plugins create temporary file with the index of the line
tmp file name. This causes race in case several builds run in time.
Add more entropy as timestamp to remove this race.

Suggested-by: Ilias Apalodimas 
Signed-off-by: Maxim Uvarov 
---
 v2: shortlog change to match template.

 scripts/lib/wic/plugins/source/bootimg-partition.py | 5 +++--
 scripts/lib/wic/plugins/source/bootimg-pcbios.py| 3 ++-
 scripts/lib/wic/plugins/source/rawcopy.py   | 3 ++-
 scripts/lib/wic/plugins/source/rootfs.py| 3 ++-
 4 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/scripts/lib/wic/plugins/source/bootimg-partition.py 
b/scripts/lib/wic/plugins/source/bootimg-partition.py
index 138986a71e..b6cea1096a 100644
--- a/scripts/lib/wic/plugins/source/bootimg-partition.py
+++ b/scripts/lib/wic/plugins/source/bootimg-partition.py
@@ -13,6 +13,7 @@
 import logging
 import os
 import re
+import time
 
 from glob import glob
 
@@ -38,7 +39,7 @@ class BootimgPartitionPlugin(SourcePlugin):
 """
 Called before do_prepare_partition(), create u-boot specific boot 
config
 """
-hdddir = "%s/boot.%d" % (cr_workdir, part.lineno)
+hdddir = "%s/boot.%d" % (cr_workdir, part.lineno, time.time())
 install_cmd = "install -d %s" % hdddir
 exec_cmd(install_cmd)
 
@@ -171,7 +172,7 @@ class BootimgPartitionPlugin(SourcePlugin):
 - sets up a vfat partition
 - copies all files listed in IMAGE_BOOT_FILES variable
 """
-hdddir = "%s/boot.%d" % (cr_workdir, part.lineno)
+hdddir = "%s/boot.%d_%s" % (cr_workdir, part.lineno, time.time())
 
 if not kernel_dir:
 kernel_dir = get_bitbake_var("DEPLOY_DIR_IMAGE")
diff --git a/scripts/lib/wic/plugins/source/bootimg-pcbios.py 
b/scripts/lib/wic/plugins/source/bootimg-pcbios.py
index f2639e7004..8ac73c2067 100644
--- a/scripts/lib/wic/plugins/source/bootimg-pcbios.py
+++ b/scripts/lib/wic/plugins/source/bootimg-pcbios.py
@@ -13,6 +13,7 @@
 import logging
 import os
 import re
+import time
 
 from wic import WicError
 from wic.engine import get_custom_config
@@ -184,7 +185,7 @@ class BootimgPcbiosPlugin(SourcePlugin):
  extra_blocks, part.mountpoint, blocks)
 
 # dosfs image, created by mkdosfs
-bootimg = "%s/boot%s.img" % (cr_workdir, part.lineno)
+bootimg = "%s/boot%s_%s.img" % (cr_workdir, part.lineno, time.time())
 
 dosfs_cmd = "mkdosfs -n boot -i %s -S 512 -C %s %d" % \
 (part.fsuuid, bootimg, blocks)
diff --git a/scripts/lib/wic/plugins/source/rawcopy.py 
b/scripts/lib/wic/plugins/source/rawcopy.py
index 82970ce51b..9ada3d39c9 100644
--- a/scripts/lib/wic/plugins/source/rawcopy.py
+++ b/scripts/lib/wic/plugins/source/rawcopy.py
@@ -4,6 +4,7 @@
 
 import logging
 import os
+import time
 
 from wic import WicError
 from wic.pluginbase import SourcePlugin
@@ -57,7 +58,7 @@ class RawCopyPlugin(SourcePlugin):
 raise WicError("No file specified")
 
 src = os.path.join(kernel_dir, source_params['file'])
-dst = os.path.join(cr_workdir, "%s.%s" % (source_params['file'], 
part.lineno))
+dst = os.path.join(cr_workdir, "%s.%s_%s" % (source_params['file'], 
part.lineno, time.time()))
 
 if not os.path.exists(os.path.dirname(dst)):
 os.makedirs(os.path.dirname(dst))
diff --git a/scripts/lib/wic/plugins/source/rootfs.py 
b/scripts/lib/wic/plugins/source/rootfs.py
index 705aeb5563..37ebee89ea 100644
--- a/scripts/lib/wic/plugins/source/rootfs.py
+++ b/scripts/lib/wic/plugins/source/rootfs.py
@@ -15,6 +15,7 @@ import logging
 import os
 import shutil
 import sys
+import time
 
 from oe.path import copyhardlinktree
 
@@ -74,7 +75,7 @@ class RootfsPlugin(SourcePlugin):
 if part.exclude_path or part.include_path:
 # We need a new rootfs directory we can delete files from. Copy to
 # workdir.
-new_rootfs = os.path.realpath(os.path.join(cr_workdir, "rootfs%d" 
% part.lineno))
+new_rootfs = os.path.realpath(os.path.join(cr_workdir, 
"rootfs%d_%s" % (part.lineno, time.time(
 
 if os.path.lexists(new_rootfs):
 shutil.rmtree(os.path.join(new_rootfs))
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] ✗ patchtest: failure for fix wic images build in parallel

2020-01-13 Thread Patchwork
== Series Details ==

Series: fix wic images build in parallel
Revision: 1
URL   : https://patchwork.openembedded.org/series/21983/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Patchfix wic images build in parallel
 Issue Shortlog does not follow expected format 
[test_shortlog_format] 
  Suggested fixCommit shortlog (first line of commit message) should follow 
the format ": "



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines: 
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 01/12] gstreamer: Add common .inc files for meson based recipes

2020-01-13 Thread Richard Purdie
On Mon, 2020-01-13 at 13:55 +0100, Carlos Rafael Giani wrote:
> Nope. This is an odd one. Are you sure there isn't a problem with
> the 
> setup itself? In step2c, I see:
> 
>  > ERROR: core-image-sato-1.0-r0 do_testsdk: The toolchain 
> /home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-
> glibc/deploy/sdk/oecore-i686-armv7vet2hf-neon-toolchain-
> nodistro.0.sh 
> is not built. Build it before running the tests: 'bitbake  -c 
> populate_sdk' .

2c fails as earlier stepd didn't build. I think the real issue is
step1b which says:

| Compiler for C supports arguments -Wdeclaration-after-statement: YES
| Found pkg-config: 
/home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/armv7vet2hf-neon-oe-linux-gnueabi/gstreamer1.0-plugins-base/1.16.1-r0/recipe-sysroot-native/usr/bin/pkg-config
 (0.29.2)
| Run-time dependency x11 found: YES 1.6.9
| Run-time dependency glib-2.0 found: YES 2.62.4
| Run-time dependency gobject-2.0 found: YES 2.62.4
| Run-time dependency gio-2.0 found: YES 2.62.4
| Run-time dependency gio-unix-2.0 found: YES 2.62.4
| Run-time dependency gmodule-no-export-2.0 found: YES 2.62.4
| Dependency gdk-pixbuf-2.0 skipped: feature examples disabled
| Dependency gtk+-3.0 skipped: feature examples disabled
| Dependency gtk+-x11-3.0 skipped: feature examples disabled
| Run-time dependency gstreamer-1.0 found: YES 1.16.1
| Run-time dependency gstreamer-base-1.0 found: YES 1.16.1
| Run-time dependency gstreamer-net-1.0 found: YES 1.16.1
| Found CMake: NO
| Run-time dependency gstreamer-check-1.0 found: NO (tried pkgconfig and cmake)
| Looking for a fallback subproject for the dependency gstreamer-check-1.0
| Subproject directory not found and gstreamer.wrap file not found
| Subproject  subprojects/gstreamer is buildable: NO (disabling)
| Dependency gstreamer-check-1.0 from subproject subprojects/gstreamer found: NO
| 
| meson.build:309:0: ERROR: Could not find dependency gst_controller_dep in 
subproject gstreamer
| 
| A full log can be found at 
/home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/armv7vet2hf-neon-oe-linux-gnueabi/gstreamer1.0-plugins-base/1.16.1-r0/build/meson-logs/meson-log.txt
| WARNING: 
/home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/armv7vet2hf-neon-oe-linux-gnueabi/gstreamer1.0-plugins-base/1.16.1-r0/temp/run.do_configure.46093:1
 exit 1 from 'exit 1'
| 
NOTE: recipe gstreamer1.0-plugins-base-1.16.1-r0: task do_configure: Failed

| Compiler for C supports arguments -Wdeclaration-after-statement: YES
| Found pkg-config: 
/home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/armv7vet2hf-neon-oe-linux-gnueabi/gstreamer1.0-plugins-base/1.16.1-r0/recipe-sysroot-native/usr/bin/pkg-config
 (0.29.2)
| Run-time dependency x11 found: YES 1.6.9
| Run-time dependency glib-2.0 found: YES 2.62.4
| Run-time dependency gobject-2.0 found: YES 2.62.4
| Run-time dependency gio-2.0 found: YES 2.62.4
| Run-time dependency gio-unix-2.0 found: YES 2.62.4
| Run-time dependency gmodule-no-export-2.0 found: YES 2.62.4
| Dependency gdk-pixbuf-2.0 skipped: feature examples disabled
| Dependency gtk+-3.0 skipped: feature examples disabled
| Dependency gtk+-x11-3.0 skipped: feature examples disabled
| Run-time dependency gstreamer-1.0 found: YES 1.16.1
| Run-time dependency gstreamer-base-1.0 found: YES 1.16.1
| Run-time dependency gstreamer-net-1.0 found: YES 1.16.1
| Found CMake: NO
| Run-time dependency gstreamer-check-1.0 found: NO (tried pkgconfig and cmake)
| Looking for a fallback subproject for the dependency gstreamer-check-1.0
| Subproject directory not found and gstreamer.wrap file not found
| Subproject  subprojects/gstreamer is buildable: NO (disabling)
| Dependency gstreamer-check-1.0 from subproject subprojects/gstreamer found: NO
| 
| meson.build:309:0: ERROR: Could not find dependency gst_controller_dep in 
subproject gstreamer
| 
| A full log can be found at 
/home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/armv7vet2hf-neon-oe-linux-gnueabi/gstreamer1.0-plugins-base/1.16.1-r0/build/meson-logs/meson-log.txt
| WARNING: 
/home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/work/armv7vet2hf-neon-oe-linux-gnueabi/gstreamer1.0-plugins-base/1.16.1-r0/temp/run.do_configure.46093:1
 exit 1 from 'exit 1'
| 
NOTE: recipe gstreamer1.0-plugins-base-1.16.1-r0: task do_configure: Failed

missing a check dependency?

Cheers,

Richard


-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 01/12] gstreamer: Add common .inc files for meson based recipes

2020-01-13 Thread Carlos Rafael Giani
Nope. This is an odd one. Are you sure there isn't a problem with the 
setup itself? In step2c, I see:


> ERROR: core-image-sato-1.0-r0 do_testsdk: The toolchain 
/home/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp-glibc/deploy/sdk/oecore-i686-armv7vet2hf-neon-toolchain-nodistro.0.sh 
is not built. Build it before running the tests: 'bitbake  -c 
populate_sdk' .


On 13.01.20 13:18, Richard Purdie wrote:

On Sun, 2020-01-12 at 14:59 +0100, Carlos Rafael Giani wrote:

* gstreamer1.0-plugins-common.inc
   The old gstreamer1.0-plugins.inc file, adapted for meson
* gstreamer1.0-plugins-packaging.inc
   The old gst-plugins-package.inc file, adapted for meson
* gstreamer1.0-ptest.inc
   Common code for meson based PTest support; autogenerates the run-ptest
   file and is designed to use the gnome-desktop-testing suite runner
   (which is why the .inc files inherits from ptest-gnome)

Signed-off-by: Carlos Rafael Giani 
---
  .../gstreamer/gstreamer1.0-plugins-common.inc | 47 +
  .../gstreamer1.0-plugins-packaging.inc| 70 +++
  .../gstreamer/gstreamer1.0-ptest.inc  | 21 ++
  3 files changed, 138 insertions(+)
  create mode 100644 
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-common.inc
  create mode 100644 
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-packaging.inc
  create mode 100644 meta/recipes-multimedia/gstreamer/gstreamer1.0-ptest.inc

Thanks for this, I know its not an easy patch set to sort out!

I ran it on the autobuilder for testing since there was bandwidth
available and there was one issue:

https://autobuilder.yoctoproject.org/typhoon/#/builders/47/builds/1455

which was in a plain OE-Core + bitbake build (no poky, so nodistro).

Any idea what is wrong there?

Cheers,

Richard


--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH 1/2] systemd: add missing Upstream-Status

2020-01-13 Thread Ross Burton
Signed-off-by: Ross Burton 
---
 ...22-Use-INT_MAX-instead-of-TIME_T_MAX-for-timerfd_settim.patch | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/meta/recipes-core/systemd/systemd/0022-Use-INT_MAX-instead-of-TIME_T_MAX-for-timerfd_settim.patch
 
b/meta/recipes-core/systemd/systemd/0022-Use-INT_MAX-instead-of-TIME_T_MAX-for-timerfd_settim.patch
index 76a1c7364d4..8d97374cb75 100644
--- 
a/meta/recipes-core/systemd/systemd/0022-Use-INT_MAX-instead-of-TIME_T_MAX-for-timerfd_settim.patch
+++ 
b/meta/recipes-core/systemd/systemd/0022-Use-INT_MAX-instead-of-TIME_T_MAX-for-timerfd_settim.patch
@@ -9,6 +9,7 @@ event after 68 years of uptime, should be good for all practical
 purposes
 
 Signed-off-by: Khem Raj 
+Upstream-Status: Pending
 ---
  src/basic/time-util.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
-- 
2.20.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH 2/2] gettext: fix typo in Upstream-Status

2020-01-13 Thread Ross Burton
Signed-off-by: Ross Burton 
---
 .../gettext-0.20.1/0001-tests-autopoint-3-unset-MAKEFLAGS.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/meta/recipes-core/gettext/gettext-0.20.1/0001-tests-autopoint-3-unset-MAKEFLAGS.patch
 
b/meta/recipes-core/gettext/gettext-0.20.1/0001-tests-autopoint-3-unset-MAKEFLAGS.patch
index 96e5bf380fa..b0bc6b97a63 100644
--- 
a/meta/recipes-core/gettext/gettext-0.20.1/0001-tests-autopoint-3-unset-MAKEFLAGS.patch
+++ 
b/meta/recipes-core/gettext/gettext-0.20.1/0001-tests-autopoint-3-unset-MAKEFLAGS.patch
@@ -6,7 +6,7 @@ Subject: [PATCH] tests/autopoint-3: unset MAKEFLAGS
 This is needed when running ptests, as the MAKEFLAGS value (set up by 
run-ptest)
 is messing up the test.
 
-Upstream-Status: Inapppropriate [oe-core specific]
+Upstream-Status: Inappropriate [oe-core specific]
 Signed-off-by: Alexander Kanavin 
 ---
  gettext-tools/tests/autopoint-3 | 1 +
-- 
2.20.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH] fix wic images build in parallel

2020-01-13 Thread Maxim Uvarov
OE wic plugins create temporary file with the index of the line
tmp file name. This causes race in case several builds run in time.
Add more entropy as timestamp to remove this race.

Suggested-by: Ilias Apalodimas 
Signed-off-by: Maxim Uvarov 
---
 scripts/lib/wic/plugins/source/bootimg-partition.py | 5 +++--
 scripts/lib/wic/plugins/source/bootimg-pcbios.py| 3 ++-
 scripts/lib/wic/plugins/source/rawcopy.py   | 3 ++-
 scripts/lib/wic/plugins/source/rootfs.py| 3 ++-
 4 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/scripts/lib/wic/plugins/source/bootimg-partition.py 
b/scripts/lib/wic/plugins/source/bootimg-partition.py
index 138986a71e..b6cea1096a 100644
--- a/scripts/lib/wic/plugins/source/bootimg-partition.py
+++ b/scripts/lib/wic/plugins/source/bootimg-partition.py
@@ -13,6 +13,7 @@
 import logging
 import os
 import re
+import time
 
 from glob import glob
 
@@ -38,7 +39,7 @@ class BootimgPartitionPlugin(SourcePlugin):
 """
 Called before do_prepare_partition(), create u-boot specific boot 
config
 """
-hdddir = "%s/boot.%d" % (cr_workdir, part.lineno)
+hdddir = "%s/boot.%d" % (cr_workdir, part.lineno, time.time())
 install_cmd = "install -d %s" % hdddir
 exec_cmd(install_cmd)
 
@@ -171,7 +172,7 @@ class BootimgPartitionPlugin(SourcePlugin):
 - sets up a vfat partition
 - copies all files listed in IMAGE_BOOT_FILES variable
 """
-hdddir = "%s/boot.%d" % (cr_workdir, part.lineno)
+hdddir = "%s/boot.%d_%s" % (cr_workdir, part.lineno, time.time())
 
 if not kernel_dir:
 kernel_dir = get_bitbake_var("DEPLOY_DIR_IMAGE")
diff --git a/scripts/lib/wic/plugins/source/bootimg-pcbios.py 
b/scripts/lib/wic/plugins/source/bootimg-pcbios.py
index f2639e7004..8ac73c2067 100644
--- a/scripts/lib/wic/plugins/source/bootimg-pcbios.py
+++ b/scripts/lib/wic/plugins/source/bootimg-pcbios.py
@@ -13,6 +13,7 @@
 import logging
 import os
 import re
+import time
 
 from wic import WicError
 from wic.engine import get_custom_config
@@ -184,7 +185,7 @@ class BootimgPcbiosPlugin(SourcePlugin):
  extra_blocks, part.mountpoint, blocks)
 
 # dosfs image, created by mkdosfs
-bootimg = "%s/boot%s.img" % (cr_workdir, part.lineno)
+bootimg = "%s/boot%s_%s.img" % (cr_workdir, part.lineno, time.time())
 
 dosfs_cmd = "mkdosfs -n boot -i %s -S 512 -C %s %d" % \
 (part.fsuuid, bootimg, blocks)
diff --git a/scripts/lib/wic/plugins/source/rawcopy.py 
b/scripts/lib/wic/plugins/source/rawcopy.py
index 82970ce51b..9ada3d39c9 100644
--- a/scripts/lib/wic/plugins/source/rawcopy.py
+++ b/scripts/lib/wic/plugins/source/rawcopy.py
@@ -4,6 +4,7 @@
 
 import logging
 import os
+import time
 
 from wic import WicError
 from wic.pluginbase import SourcePlugin
@@ -57,7 +58,7 @@ class RawCopyPlugin(SourcePlugin):
 raise WicError("No file specified")
 
 src = os.path.join(kernel_dir, source_params['file'])
-dst = os.path.join(cr_workdir, "%s.%s" % (source_params['file'], 
part.lineno))
+dst = os.path.join(cr_workdir, "%s.%s_%s" % (source_params['file'], 
part.lineno, time.time()))
 
 if not os.path.exists(os.path.dirname(dst)):
 os.makedirs(os.path.dirname(dst))
diff --git a/scripts/lib/wic/plugins/source/rootfs.py 
b/scripts/lib/wic/plugins/source/rootfs.py
index 705aeb5563..37ebee89ea 100644
--- a/scripts/lib/wic/plugins/source/rootfs.py
+++ b/scripts/lib/wic/plugins/source/rootfs.py
@@ -15,6 +15,7 @@ import logging
 import os
 import shutil
 import sys
+import time
 
 from oe.path import copyhardlinktree
 
@@ -74,7 +75,7 @@ class RootfsPlugin(SourcePlugin):
 if part.exclude_path or part.include_path:
 # We need a new rootfs directory we can delete files from. Copy to
 # workdir.
-new_rootfs = os.path.realpath(os.path.join(cr_workdir, "rootfs%d" 
% part.lineno))
+new_rootfs = os.path.realpath(os.path.join(cr_workdir, 
"rootfs%d_%s" % (part.lineno, time.time(
 
 if os.path.lexists(new_rootfs):
 shutil.rmtree(os.path.join(new_rootfs))
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 01/12] gstreamer: Add common .inc files for meson based recipes

2020-01-13 Thread Richard Purdie
On Sun, 2020-01-12 at 14:59 +0100, Carlos Rafael Giani wrote:
> * gstreamer1.0-plugins-common.inc
>   The old gstreamer1.0-plugins.inc file, adapted for meson
> * gstreamer1.0-plugins-packaging.inc
>   The old gst-plugins-package.inc file, adapted for meson
> * gstreamer1.0-ptest.inc
>   Common code for meson based PTest support; autogenerates the run-ptest
>   file and is designed to use the gnome-desktop-testing suite runner
>   (which is why the .inc files inherits from ptest-gnome)
> 
> Signed-off-by: Carlos Rafael Giani 
> ---
>  .../gstreamer/gstreamer1.0-plugins-common.inc | 47 +
>  .../gstreamer1.0-plugins-packaging.inc| 70 +++
>  .../gstreamer/gstreamer1.0-ptest.inc  | 21 ++
>  3 files changed, 138 insertions(+)
>  create mode 100644 
> meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-common.inc
>  create mode 100644 
> meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-packaging.inc
>  create mode 100644 meta/recipes-multimedia/gstreamer/gstreamer1.0-ptest.inc

Thanks for this, I know its not an easy patch set to sort out!

I ran it on the autobuilder for testing since there was bandwidth
available and there was one issue:

https://autobuilder.yoctoproject.org/typhoon/#/builders/47/builds/1455

which was in a plain OE-Core + bitbake build (no poky, so nodistro).

Any idea what is wrong there?

Cheers,

Richard

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core