[OE-core][zeus][PATCH v2] sqlite: backport CVE fix

2020-07-09 Thread Adrian Bunk
From: Sakib Sajal 

Fixes CVE-2020-11655

(From OE-Core rev: 3b06a6c73f4e49c6d00f758423c2e8865ec2de00)

Signed-off-by: Sakib Sajal 
Signed-off-by: Richard Purdie 
[ without the CVE-2020-11656 fix that did not apply cleanly ]
Signed-off-by: Adrian Bunk 
---
v2: Upstream Status -> Upstream-Status
---
 .../sqlite/files/CVE-2020-11655.patch | 32 +++
 meta/recipes-support/sqlite/sqlite3_3.29.0.bb |  1 +
 2 files changed, 33 insertions(+)
 create mode 100644 meta/recipes-support/sqlite/files/CVE-2020-11655.patch

diff --git a/meta/recipes-support/sqlite/files/CVE-2020-11655.patch 
b/meta/recipes-support/sqlite/files/CVE-2020-11655.patch
new file mode 100644
index 00..c2360cb867
--- /dev/null
+++ b/meta/recipes-support/sqlite/files/CVE-2020-11655.patch
@@ -0,0 +1,32 @@
+From a4601326d61bf1a11151ac6b78b50804bfd03b4d Mon Sep 17 00:00:00 2001
+From: Sakib Sajal 
+Date: Thu, 30 Apr 2020 10:46:16 -0700
+Subject: [PATCH 2/2] In the event of a semantic error in an aggregate query,
+ early-out the resetAccumulator() function to prevent problems due to
+ incomplete or incorrect initialization of the AggInfo object. Fix for ticket
+ [af4556bb5c285c08].
+
+FossilOrigin-Name: 
4a302b42c7bf5e11ddb5522ca999f74aba397d3a7eb91b1844bb02852f772441
+Upstream-Status: Backport [c415d91007e1680e4eb17def583b202c3c83c718]
+
+CVE: CVE-2020-11655
+Signed-off-by: Sakib Sajal 
+---
+ sqlite3.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/sqlite3.c b/sqlite3.c
+index 1df6633..726adf7 100644
+--- a/sqlite3.c
 b/sqlite3.c
+@@ -133242,6 +133242,7 @@ static void resetAccumulator(Parse *pParse, AggInfo 
*pAggInfo){
+   struct AggInfo_func *pFunc;
+   int nReg = pAggInfo->nFunc + pAggInfo->nColumn;
+   if( nReg==0 ) return;
++  if( pParse->nErr ) return;
+ #ifdef SQLITE_DEBUG
+   /* Verify that all AggInfo registers are within the range specified by
+   ** AggInfo.mnReg..AggInfo.mxReg */
+-- 
+2.17.1
+
diff --git a/meta/recipes-support/sqlite/sqlite3_3.29.0.bb 
b/meta/recipes-support/sqlite/sqlite3_3.29.0.bb
index cf3b179845..95e1174b07 100644
--- a/meta/recipes-support/sqlite/sqlite3_3.29.0.bb
+++ b/meta/recipes-support/sqlite/sqlite3_3.29.0.bb
@@ -12,6 +12,7 @@ SRC_URI = 
"http://www.sqlite.org/2019/sqlite-autoconf-${SQLITE_PV}.tar.gz \
file://CVE-2019-19926.patch \
file://CVE-2019-19959.patch \
file://CVE-2019-20218.patch \
+   file://CVE-2020-11655.patch \
 "
 SRC_URI[md5sum] = "8f3dfe83387e62ecb91c7c5c09c688dc"
 SRC_URI[sha256sum] = 
"8e7c1e2950b5b04c5944a981cb31fffbf9d2ddda939d536838ebc854481afd5b"
-- 
2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140506): 
https://lists.openembedded.org/g/openembedded-core/message/140506
Mute This Topic: https://lists.openembedded.org/mt/75413945/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[OE-core] mv: cannot stat './.builtin-script.o.tmp': No such file or directory

2020-07-09 Thread Pankaj Vinadrao Joshi
Hi,
i have built minimal-image for RPI4 image with perf enabled in it but i am 
getting following error when i am running some script after booting up the 
image  is this is an issue because i am missing something that i should add 
while building ,can anyone suggest me ??

cc1: all warnings being treated as errors
mv: cannot stat './.builtin-script.o.tmp': No such file or directory
make[3]: *** 
[/home/root/lkp/lkp-tests/tmp-pkg/perf/src/linux/tools/build/Makefile.build:96: 
builtin-script.o] Error 1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140505): 
https://lists.openembedded.org/g/openembedded-core/message/140505
Mute This Topic: https://lists.openembedded.org/mt/75413874/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[OE-core] [PATCH] nativesdk: clear MACHINE_FEATURES

2020-07-09 Thread Douglas via lists.openembedded.org
Further to 96c20c9df7:
Try to avoid nativesdk recipes accidentally being dependent on MACHINE_FEATURES.

Signed-off-by: Douglas Royds 
---
 meta/classes/nativesdk.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes/nativesdk.bbclass b/meta/classes/nativesdk.bbclass
index 7b75710726..cd389c9c77 100644
--- a/meta/classes/nativesdk.bbclass
+++ b/meta/classes/nativesdk.bbclass
@@ -9,6 +9,7 @@ NATIVESDKLIBC ?= "libc-glibc"
 LIBCOVERRIDE = ":${NATIVESDKLIBC}"
 CLASSOVERRIDE = "class-nativesdk"
 MACHINEOVERRIDES = ""
+MACHINE_FEATURES = ""
 
 MULTILIBS = ""
 
-- 
2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140504): 
https://lists.openembedded.org/g/openembedded-core/message/140504
Mute This Topic: https://lists.openembedded.org/mt/75413827/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core] [PATCH V3] dpkg: change SRC_URI to take dpkg from git

2020-07-09 Thread Richard Purdie
On Fri, 2020-07-10 at 10:08 +0800, Changqing Li wrote:
> From: Changqing Li 
> 
> tar.xz on original URL have been removed, switch to use git
> 
> Signed-off-by: Changqing Li 
> ---
>  meta/recipes-devtools/dpkg/dpkg.inc   |  9 -
>  meta/recipes-devtools/dpkg/dpkg_1.20.0.bb | 10 +++---
>  2 files changed, 15 insertions(+), 4 deletions(-)

The autobuilder didn't like this change :(

https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/1143

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140503): 
https://lists.openembedded.org/g/openembedded-core/message/140503
Mute This Topic: https://lists.openembedded.org/mt/75411398/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[OE-core] [PATCH] nativesdk: Set the CXXFLAGS to the BUILDSDK_CXXFLAGS

2020-07-09 Thread Douglas via lists.openembedded.org
... which default to the BUILDSDK_CFLAGS in any case.

Signed-off-by: Douglas Royds 
---
 meta/classes/nativesdk.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/nativesdk.bbclass b/meta/classes/nativesdk.bbclass
index 7b75710726..171ae72be0 100644
--- a/meta/classes/nativesdk.bbclass
+++ b/meta/classes/nativesdk.bbclass
@@ -57,7 +57,7 @@ EXTRA_OECONF_GCC_FLOAT = ""
 
 CPPFLAGS = "${BUILDSDK_CPPFLAGS}"
 CFLAGS = "${BUILDSDK_CFLAGS}"
-CXXFLAGS = "${BUILDSDK_CFLAGS}"
+CXXFLAGS = "${BUILDSDK_CXXFLAGS}"
 LDFLAGS = "${BUILDSDK_LDFLAGS}"
 
 # Change to place files in SDKPATH
-- 
2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140502): 
https://lists.openembedded.org/g/openembedded-core/message/140502
Mute This Topic: https://lists.openembedded.org/mt/75413542/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[OE-core] [PATCH V3] dpkg: change SRC_URI to take dpkg from git

2020-07-09 Thread Changqing Li
From: Changqing Li 

tar.xz on original URL have been removed, switch to use git

Signed-off-by: Changqing Li 
---
 meta/recipes-devtools/dpkg/dpkg.inc   |  9 -
 meta/recipes-devtools/dpkg/dpkg_1.20.0.bb | 10 +++---
 2 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-devtools/dpkg/dpkg.inc 
b/meta/recipes-devtools/dpkg/dpkg.inc
index 1c3c585d79..a309613259 100644
--- a/meta/recipes-devtools/dpkg/dpkg.inc
+++ b/meta/recipes-devtools/dpkg/dpkg.inc
@@ -7,7 +7,7 @@ DEPENDS_class-native = "bzip2-replacement-native zlib-native 
virtual/update-alte
 RDEPENDS_${PN} = "${VIRTUAL-RUNTIME_update-alternatives} perl"
 RDEPENDS_${PN}_class-native = ""
 
-UPSTREAM_CHECK_URI = "${DEBIAN_MIRROR}/main/d/dpkg/"
+UPSTREAM_CHECK_GITTAGREGEX = "(?P(\d+(\.\d+)+))"
 
 inherit autotools gettext perlnative pkgconfig perl-version update-alternatives
 
@@ -30,6 +30,13 @@ EXTRA_OECONF_append_class-target = " 
--disable-update-alternatives DEB_HOST_ARCH
 PACKAGECONFIG = "liblzma"
 PACKAGECONFIG[liblzma] = "--with-liblzma,--without-liblzma, xz"
 
+do_configure_prepend () {
+# autotools_do_configure updates po/Makefile.in.in, we also need
+# update dselect/po and scripts/po
+cp -f ${STAGING_DATADIR_NATIVE}/gettext/po/Makefile.in.in 
${S}/dselect/po/
+cp -f ${STAGING_DATADIR_NATIVE}/gettext/po/Makefile.in.in 
${S}/scripts/po/
+}
+
 do_install_append () {
if [ "${PN}" = "dpkg-native" ]; then
# update-alternatives doesn't have an offline mode
diff --git a/meta/recipes-devtools/dpkg/dpkg_1.20.0.bb 
b/meta/recipes-devtools/dpkg/dpkg_1.20.0.bb
index c98a9e58e2..935dcac918 100644
--- a/meta/recipes-devtools/dpkg/dpkg_1.20.0.bb
+++ b/meta/recipes-devtools/dpkg/dpkg_1.20.0.bb
@@ -1,7 +1,7 @@
 require dpkg.inc
 LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
 
-SRC_URI = "${DEBIAN_MIRROR}/main/d/${BPN}/${BPN}_${PV}.tar.xz \
+SRC_URI = "git://salsa.debian.org/dpkg-team/dpkg.git;protocol=https \
file://noman.patch \
file://remove-tar-no-timestamp.patch \
file://arch_pm.patch \
@@ -18,5 +18,9 @@ SRC_URI = "${DEBIAN_MIRROR}/main/d/${BPN}/${BPN}_${PV}.tar.xz 
\
 
 SRC_URI_append_class-native = " 
file://0001-build.c-ignore-return-of-1-from-tar-cf.patch"
 
-SRC_URI[md5sum] = "f88f077236a3ff3decae3b25c989893d"
-SRC_URI[sha256sum] = 
"b633cc2b0e030efb61e11029d8a3fb1123f719864c9992da2e52b471c96d0900"
+SRCREV = "314ac02663c5bd1a82b34745150bf13a39a549a3"
+
+S = "${WORKDIR}/git"
+
+#autotools.bbclass default AUTOTOOLS_AUXDIR is ${S}, we need to under 
${S}/build-aux
+AUTOTOOLS_AUXDIR = "${S}/build-aux"
-- 
2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140501): 
https://lists.openembedded.org/g/openembedded-core/message/140501
Mute This Topic: https://lists.openembedded.org/mt/75411398/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core] [PATCH v2] go: Disbale CGO for riscv64

2020-07-09 Thread Khem Raj
Please consider it for dunfell as well once in master

On 7/9/20 12:57 PM, Khem Raj wrote:
> cgo is still not available in go for riscv64, we will re-evaluate it
> once we upgrade to 1.15
> 
> Fixes
> | /usr/src/debug/go-runtime/1.14.4-r0/go/src/runtime/cgo/gcc_util.c:23: 
> undefined reference to `_cgo_sys_thread_start'
> 
> [YOCTO #13966]
> 
> Signed-off-by: Khem Raj 
> ---
> v2: Fix go as well along with go-runtime
> 
>  meta/recipes-devtools/go/go-runtime_1.14.bb | 1 +
>  meta/recipes-devtools/go/go_1.14.bb | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/go/go-runtime_1.14.bb 
> b/meta/recipes-devtools/go/go-runtime_1.14.bb
> index 43b68b4e46..465e0c 100644
> --- a/meta/recipes-devtools/go/go-runtime_1.14.bb
> +++ b/meta/recipes-devtools/go/go-runtime_1.14.bb
> @@ -1,2 +1,3 @@
> +export CGO_ENABLED_riscv64 = ""
>  require go-${PV}.inc
>  require go-runtime.inc
> diff --git a/meta/recipes-devtools/go/go_1.14.bb 
> b/meta/recipes-devtools/go/go_1.14.bb
> index 5d40cf9d04..bc90a1329e 100644
> --- a/meta/recipes-devtools/go/go_1.14.bb
> +++ b/meta/recipes-devtools/go/go_1.14.bb
> @@ -2,7 +2,7 @@ require go-${PV}.inc
>  require go-target.inc
>  
>  export GOBUILDMODE=""
> -
> +export CGO_ENABLED_riscv64 = ""
>  # Add pie to GOBUILDMODE to satisfy "textrel" QA checking, but mips/riscv
>  # doesn't support -buildmode=pie, so skip the QA checking for mips/riscv and 
> its
>  # variants.
> 
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140499): 
https://lists.openembedded.org/g/openembedded-core/message/140499
Mute This Topic: https://lists.openembedded.org/mt/75405494/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core] [PATCH v2] rootfs-post: remove trailing blanks from tasks

2020-07-09 Thread Konrad Weihmann
I narrowed it down to be in the PLY state machine of 
bitbake/lib/bb/pysh/pyshyacc.py.
I'm not really familiar with PLY but to me it seems that the transition 
from "empty > separator_op" or "separator_op separator_op" isn't 
designed in.
Still I hope this helps and somebody could fix that, as I consider the 
rest of the code to be safe in terms of executing the resulting script.


On 09.07.20 14:33, Konrad Weihmann wrote:
Yep, I suspect the resulting empty shell statement to cause problems - 
if I'll find some time later, I can take a deeper look into it


On 09.07.20 13:57, Alex Kiernan wrote:
On Thu, Jul 9, 2020 at 8:19 AM Konrad Weihmann  
wrote:


remove the trailing blanks before the ;-delimiter, so one could use
"_remove" to avoid running tasks like 'rootfs_update_timestamp',
which are currently hardcoded and not bound to any
configurable feature flag

Signed-off-by: Konrad Weihmann 
---


I think this duplicates a change I submitted:

https://patchwork.openembedded.org/patch/168931/

Comment from @Richard Purdie at the time was "This does sound like
you're working around a bug in shlex :/", which I started to dig into,
but failed to figure it out.






  meta/classes/rootfs-postcommands.bbclass | 6 +++---
  meta/classes/rootfsdebugfiles.bbclass    | 2 +-
  2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta/classes/rootfs-postcommands.bbclass 
b/meta/classes/rootfs-postcommands.bbclass

index c43b9a9823..984730ebe8 100644
--- a/meta/classes/rootfs-postcommands.bbclass
+++ b/meta/classes/rootfs-postcommands.bbclass
@@ -1,6 +1,6 @@

  # Zap the root password if debug-tweaks feature is not enabled
-ROOTFS_POSTPROCESS_COMMAND += 
'${@bb.utils.contains_any("IMAGE_FEATURES", [ 'debug-tweaks', 
'empty-root-password' ], "", "zap_empty_root_password ; ",d)}'
+ROOTFS_POSTPROCESS_COMMAND += 
'${@bb.utils.contains_any("IMAGE_FEATURES", [ 'debug-tweaks', 
'empty-root-password' ], "", "zap_empty_root_password; ",d)}'


  # Allow dropbear/openssh to accept logins from accounts with an 
empty password string if debug-tweaks or allow-empty-password is enabled
  ROOTFS_POSTPROCESS_COMMAND += 
'${@bb.utils.contains_any("IMAGE_FEATURES", [ 'debug-tweaks', 
'allow-empty-password' ], "ssh_allow_empty_password; ", "",d)}'
@@ -12,7 +12,7 @@ ROOTFS_POSTPROCESS_COMMAND += 
'${@bb.utils.contains_any("IMAGE_FEATURES", [ 'deb
  ROOTFS_POSTPROCESS_COMMAND += 
'${@bb.utils.contains_any("IMAGE_FEATURES", [ 'debug-tweaks', 
'post-install-logging' ], "postinst_enable_logging; ", "",d)}'


  # Create /etc/timestamp during image construction to give a 
reasonably sane default time setting

-ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp ; "
+ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp; "

  # Tweak the mount options for rootfs in /etc/fstab if 
read-only-rootfs is enabled
  ROOTFS_POSTPROCESS_COMMAND += 
'${@bb.utils.contains("IMAGE_FEATURES", "read-only-rootfs", 
"read_only_rootfs_hook; ", "",d)}'
@@ -26,7 +26,7 @@ ROOTFS_POSTPROCESS_COMMAND += 
'${@bb.utils.contains("IMAGE_FEATURES", "read-only
  APPEND_append = '${@bb.utils.contains("IMAGE_FEATURES", 
"read-only-rootfs", " ro", "", d)}'


  # Generates test data file with data store variables expanded in 
json format

-ROOTFS_POSTPROCESS_COMMAND += "write_image_test_data ; "
+ROOTFS_POSTPROCESS_COMMAND += "write_image_test_data; "

  # Write manifest
  IMAGE_MANIFEST = 
"${IMGDEPLOYDIR}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.manifest"
diff --git a/meta/classes/rootfsdebugfiles.bbclass 
b/meta/classes/rootfsdebugfiles.bbclass

index e2ba4e3647..85c7ec7434 100644
--- a/meta/classes/rootfsdebugfiles.bbclass
+++ b/meta/classes/rootfsdebugfiles.bbclass
@@ -28,7 +28,7 @@
  ROOTFS_DEBUG_FILES ?= ""
  ROOTFS_DEBUG_FILES[doc] = "Lists additional files or directories to 
be installed with 'cp -a' in the format 'source1 target1;source2 
target2;...'"


-ROOTFS_POSTPROCESS_COMMAND += "rootfs_debug_files ;"
+ROOTFS_POSTPROCESS_COMMAND += "rootfs_debug_files;"
  rootfs_debug_files () {
 #!/bin/sh -e
 echo "${ROOTFS_DEBUG_FILES}" | sed -e 's/;/\n/g' | while read 
source target mode; do

--
2.20.1






--
Alex Kiernan





-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140497): 
https://lists.openembedded.org/g/openembedded-core/message/140497
Mute This Topic: https://lists.openembedded.org/mt/75393087/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core] [PATCH][dunfell] u-boot: fix bug to allow use of *.cfg

2020-07-09 Thread Steve Sakoman
Hi Charlie,

This same code (and bug) is present in the master branch, so you would
need to submit your patch there first before I can take it for
dunfell.  We have a strict "master first" policy so that we don't fix
things in stable branches that haven't been fixed in master first.

Steve


On Thu, Jul 9, 2020 at 9:22 AM Charlie Davies
 wrote:
>
> Fixed a bug in u-boot.inc where logic to apply *.cfg
> files never runs.
>
> U-boot should allow *.cfg files to be specified in recipe's
> SRC_URI.
>
> Charlie Davies (1):
>   u-boot: fix condition to allow use of *.cfg
>
>  meta/recipes-bsp/u-boot/u-boot.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.27.0
>
> 
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140496): 
https://lists.openembedded.org/g/openembedded-core/message/140496
Mute This Topic: https://lists.openembedded.org/mt/75404797/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[OE-core] ✗ patchtest: failure for move find_cfgs() helper to cml1.bbclass

2020-07-09 Thread Patchwork
== Series Details ==

Series: move find_cfgs() helper to cml1.bbclass
Revision: 1
URL   : https://patchwork.openembedded.org/series/25079/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Patchmove find_cfgs() helper to cml1.bbclass
 Issue Shortlog does not follow expected format 
[test_shortlog_format] 
  Suggested fixCommit shortlog (first line of commit message) should follow 
the format ": "



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines: 
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140495): 
https://lists.openembedded.org/g/openembedded-core/message/140495
Mute This Topic: https://lists.openembedded.org/mt/75406110/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[OE-core] [PATCH] move find_cfgs() helper to cml1.bbclass

2020-07-09 Thread Rasmus Villemoes
u-boot.inc and busybox.inc contain identical copies of this little
helper. They both inherit the cml1 class and use cml1_do_configure
right after having used this helper, and other recipes that want to
write similar logic for doing Kconfig via fragments will also need it
or something equivalent.

Signed-off-by: Rasmus Villemoes 
---
Those other recipes can certainly also just copy-paste find_cfgs(),
but I think it's nice to avoid even small pieces of code duplication
(it all adds up).

What does cml1 stand for? I can't find anything in git history or
comments, and "basic support for the Linux kernel style build
configuration system" doesn't provide much of a clue either.

 meta/classes/cml1.bbclass | 10 ++
 meta/recipes-bsp/u-boot/u-boot.inc| 10 --
 meta/recipes-core/busybox/busybox.inc | 10 --
 3 files changed, 10 insertions(+), 20 deletions(-)

diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
index c7f6723cb3..8ab240589a 100644
--- a/meta/classes/cml1.bbclass
+++ b/meta/classes/cml1.bbclass
@@ -1,3 +1,13 @@
+# returns all the elements from the src uri that are .cfg files
+def find_cfgs(d):
+sources=src_patches(d, True)
+sources_list=[]
+for s in sources:
+if s.endswith('.cfg'):
+sources_list.append(s)
+
+return sources_list
+
 cml1_do_configure() {
set -e
unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
diff --git a/meta/recipes-bsp/u-boot/u-boot.inc 
b/meta/recipes-bsp/u-boot/u-boot.inc
index c91da02959..5ec3d90764 100644
--- a/meta/recipes-bsp/u-boot/u-boot.inc
+++ b/meta/recipes-bsp/u-boot/u-boot.inc
@@ -70,16 +70,6 @@ UBOOT_EXTLINUX_INSTALL_DIR ?= "/boot/extlinux"
 UBOOT_EXTLINUX_CONF_NAME ?= "extlinux.conf"
 UBOOT_EXTLINUX_SYMLINK ?= "${UBOOT_EXTLINUX_CONF_NAME}-${MACHINE}-${PR}"
 
-# returns all the elements from the src uri that are .cfg files
-def find_cfgs(d):
-sources=src_patches(d, True)
-sources_list=[]
-for s in sources:
-if s.endswith('.cfg'):
-sources_list.append(s)
-
-return sources_list
-
 do_configure () {
 if [ -n "${UBOOT_CONFIG}" ]; then
 unset i j
diff --git a/meta/recipes-core/busybox/busybox.inc 
b/meta/recipes-core/busybox/busybox.inc
index 6cfdcd7344..45aaa2b41c 100644
--- a/meta/recipes-core/busybox/busybox.inc
+++ b/meta/recipes-core/busybox/busybox.inc
@@ -133,16 +133,6 @@ do_prepare_config () {
fi
 }
 
-# returns all the elements from the src uri that are .cfg files
-def find_cfgs(d):
-sources=src_patches(d, True)
-sources_list=[]
-for s in sources:
-if s.endswith('.cfg'):
-sources_list.append(s)
-
-return sources_list
-
 do_configure () {
set -x
do_prepare_config
-- 
2.23.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140493): 
https://lists.openembedded.org/g/openembedded-core/message/140493
Mute This Topic: https://lists.openembedded.org/mt/75405917/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[OE-core] [PATCH v2] go: Disbale CGO for riscv64

2020-07-09 Thread Khem Raj
cgo is still not available in go for riscv64, we will re-evaluate it
once we upgrade to 1.15

Fixes
| /usr/src/debug/go-runtime/1.14.4-r0/go/src/runtime/cgo/gcc_util.c:23: 
undefined reference to `_cgo_sys_thread_start'

[YOCTO #13966]

Signed-off-by: Khem Raj 
---
v2: Fix go as well along with go-runtime

 meta/recipes-devtools/go/go-runtime_1.14.bb | 1 +
 meta/recipes-devtools/go/go_1.14.bb | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/go/go-runtime_1.14.bb 
b/meta/recipes-devtools/go/go-runtime_1.14.bb
index 43b68b4e46..465e0c 100644
--- a/meta/recipes-devtools/go/go-runtime_1.14.bb
+++ b/meta/recipes-devtools/go/go-runtime_1.14.bb
@@ -1,2 +1,3 @@
+export CGO_ENABLED_riscv64 = ""
 require go-${PV}.inc
 require go-runtime.inc
diff --git a/meta/recipes-devtools/go/go_1.14.bb 
b/meta/recipes-devtools/go/go_1.14.bb
index 5d40cf9d04..bc90a1329e 100644
--- a/meta/recipes-devtools/go/go_1.14.bb
+++ b/meta/recipes-devtools/go/go_1.14.bb
@@ -2,7 +2,7 @@ require go-${PV}.inc
 require go-target.inc
 
 export GOBUILDMODE=""
-
+export CGO_ENABLED_riscv64 = ""
 # Add pie to GOBUILDMODE to satisfy "textrel" QA checking, but mips/riscv
 # doesn't support -buildmode=pie, so skip the QA checking for mips/riscv and 
its
 # variants.
-- 
2.27.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140492): 
https://lists.openembedded.org/g/openembedded-core/message/140492
Mute This Topic: https://lists.openembedded.org/mt/75405494/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[OE-core] [PATCH] go-runtime: Disbale CGO for riscv64

2020-07-09 Thread Khem Raj
cgo is still not available in go for riscv64, we will re-evaluate it
once we upgrade to 1.15

Fixes
| /usr/src/debug/go-runtime/1.14.4-r0/go/src/runtime/cgo/gcc_util.c:23: 
undefined reference to `_cgo_sys_thread_start'

[YOCTO #13966]

Signed-off-by: Khem Raj 
---
 meta/recipes-devtools/go/go-runtime_1.14.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/go/go-runtime_1.14.bb 
b/meta/recipes-devtools/go/go-runtime_1.14.bb
index 43b68b4e46..465e0c 100644
--- a/meta/recipes-devtools/go/go-runtime_1.14.bb
+++ b/meta/recipes-devtools/go/go-runtime_1.14.bb
@@ -1,2 +1,3 @@
+export CGO_ENABLED_riscv64 = ""
 require go-${PV}.inc
 require go-runtime.inc
-- 
2.27.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140491): 
https://lists.openembedded.org/g/openembedded-core/message/140491
Mute This Topic: https://lists.openembedded.org/mt/75405310/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core] file checksums versus SRC_URI globs

2020-07-09 Thread Rasmus Villemoes
On 02/07/2020 08.42, Rasmus Villemoes via lists.openembedded.org wrote:
> On 01/07/2020 16.03, Quentin Schulz wrote:
>> Hi Rasmus,
>>
>> On Wed, Jul 01, 2020 at 03:51:19PM +0200, Rasmus Villemoes wrote:
>>> Hi,
>>>
>>> We have a recipe that uses
>>>
>>>   SRC_URI += "file://somedir/*"
>>>
>>
>> Glob aren't supported. Use "file://somedir/" instead.
> 
> Thanks, that actually works for one of the cases we have (there are
> others that use globs which cannot be solved quite that simply, but for
> now I'm just listing files explicitly instead).
> 
> However, I'm not sure that "globs aren't supported". The commit I
> referenced clearly tried to make that work (better), it also "works" in
> the sense of unpacking the expected things when building from scratch -
> there's even
> 
> def test_local_wildcard(self):
> tree = self.fetchUnpack(['file://a', 'file://dir/*'])
> self.assertEqual(tree, ['a',  'dir/c', 'dir/d', 'dir/subdir/e'])
> 
> in bitbake/lib/bb/tests/fetch.py. And the two upstream recipes
> connman-gnome_0.7.bb and matchbox-desktop_2.2.bb both use that exact
> pattern.
> 
> So either
> 
> - this is a plain bug in the signature computation,

I'm guessing the culprit is

commit 6c0706a28d72c591f1b75b6e3f3b645859387c7e
Author: Richard Purdie 
Date:   Mon Dec 8 21:25:23 2014 +

cache/fetch2/siggen: Ensure we track include history for file checksums

which was the one that introduced the ":True: or ":False" suffixing via

+filelist.append(f + ":" + str(os.path.exists(f)))

and then also did

@@ -981,6 +980,10 @@ def get_file_checksums(filelist, pn):

 checksums = []
 for pth in filelist.split():
+exist = pth.split(":")[1]
+if exist == "False":
+continue
+pth = pth.split(":")[0]
 if '*' in pth:
 # Handle globs
 for f in glob.glob(pth):

which practically guaranteed that the "if '*' in pth" would be dead code.

Richard, do you agree that this is a bug in the signature computation?

As I wrote previously, there's no warning anywhere that using globs in
SRC_URI will fail to take the contents of the referenced file into
account in hashes, but there's obviously still a some code that makes
file://*.c work wrt. unpacking (and a test case for that).

Rasmus
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140490): 
https://lists.openembedded.org/g/openembedded-core/message/140490
Mute This Topic: https://lists.openembedded.org/mt/75235594/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core] [RFC PATCH 1/1] classes: add workdir_save class

2020-07-09 Thread Paul Eggleton

On 10/07/2020 5:02 am, Peter Kjellerstedt wrote:
>Richard Purdie wrote:

Seems like a useful idea. I think the name may need "failed" in the
name to make it clearer what it does. We also need a section for the
classes chapter in the manual.

As another data point, OEQA is using OEQA_DEBUGGING_SAVED_OUTPUT to
trigger saving information for reproducible builds...


How about "save_workdir_on_failure.bbclass"?


I'd like to keep the name short if possible, it'll end up in the 
variable names as well. Thinking ahead we might want to save other 
information in future beyond the workdir, so we could possibly drop that 
from the name. What about "failure_save" or "failure_saver"? Also, with 
underscores or without?


Paul

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140487): 
https://lists.openembedded.org/g/openembedded-core/message/140487
Mute This Topic: https://lists.openembedded.org/mt/75382316/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core] [RFC PATCH 1/1] classes: add workdir_save class

2020-07-09 Thread Peter Kjellerstedt
> -Original Message-
> From: openembedded-core@lists.openembedded.org  c...@lists.openembedded.org> On Behalf Of Richard Purdie
> Sent: den 8 juli 2020 20:12
> To: Paul Eggleton ; openembedded-
> c...@lists.openembedded.org
> Subject: Re: [OE-core] [RFC PATCH 1/1] classes: add workdir_save class
> 
> On Wed, 2020-07-08 at 11:02 -0700, Paul Eggleton wrote:
> > If you are running your builds inside an environment where you don't
> > have access to the build tree (e.g. an autobuilder where you can only
> > download final artifacts such as images), then debugging build
> > failures
> > can be difficult - you can't examine log files, the source tree or
> > output
> > files. When enabled, this class triggers on task failure and saves a
> > tarball of the work directory for the task's recipe and puts it in a
> > configurable location, where it can be picked up by a separate
> > process
> > and made available as a downloadable artifact.
> >
> > Signed-off-by: Paul Eggleton 
> 
> Seems like a useful idea. I think the name may need "failed" in the
> name to make it clearer what it does. We also need a section for the
> classes chapter in the manual.
> 
> As another data point, OEQA is using OEQA_DEBUGGING_SAVED_OUTPUT to
> trigger saving information for reproducible builds...
> 
> Cheers,
> 
> Richard

How about "save_workdir_on_failure.bbclass"?

//Peter

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140486): 
https://lists.openembedded.org/g/openembedded-core/message/140486
Mute This Topic: https://lists.openembedded.org/mt/75382316/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core] [PATCH v4 01/12] Move rpm manifest to its own subdir

2020-07-09 Thread Paul Barker
On Thu, 9 Jul 2020 at 11:42, Fredrik Gustafsson
 wrote:
>
> Hi,
> is there something I can do to make this series move forward?
>

I guess it's waiting for at least one person to review it in detail.
It's in my backlog, I should get to it on Monday.

-- 
Paul Barker
Konsulko Group
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140485): 
https://lists.openembedded.org/g/openembedded-core/message/140485
Mute This Topic: https://lists.openembedded.org/mt/75277396/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core] How to install individual -lic packages

2020-07-09 Thread Christopher Larson
COMPLEMENTARY_GLOB[lic-pkgs] = '*-lic'
IMAGE_FEATURES += "lic-pkgs"

This is how the dbg-pkgs, dev-pkgs, doc-pkgs, src-pkgs, ptest-pkgs,
staticdev-pkgs are done.

On Thu, Jul 9, 2020 at 3:58 AM Christian Eggers  wrote:

> I have set LICENSE_CREATE_PACKAGE to "1" in order to create additional -lic
> packages per recipe. As NO_RECOMMENDATIONS is set to "1" in my image
> recipe,
> the -lic packages are not installed automatically.
>
> How can I install specific -lic packages "manually". My idea was to create
> a
> new recipe which rdepends on all -lic packages which I would like to
> install.
>
> # myrecipe.bb:
> RDEPENDS_${PN} += "curl-lic"
>
> After that I get the following error message:
> ERROR: Nothing RPROVIDES 'curl-lic' (but ... RDEPENDS on or otherwise
> requires
> it)
>
> The same happened when I tried to add the -lic packages to IMAGE_INSTALL
> in my
> image recipe.
>
> I also tried adding one line in image.bbclass, but this changed nothing:
>
> def add_package_and_files(d):
> ...
> d.setVar('PACKAGES', "%s %s" % (pn_lic, packages))
> d.setVar('FILES_' + pn_lic, files)
> +   d.setVar('RPROVIDES_' + pn_lic, pn_lic)
>
>
> How can I install -lic packages in my rootfs without setting
> NO_RECOMMENDATIONS to 0?
>
> regards
> Christian
>
>
>
>
> 
>  [
> http://assets.arri.com/media/sign/2020-04-03-E-mail-signature-Stellar2_V1.jpg]
> 
>
> Get all the latest information from www.arri.com,
> Facebook, Twitter<
> https://twitter.com/ARRIChannel>, Instagram
> and YouTube.
>
> Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
> Sitz: München - Registergericht: Amtsgericht München -
> Handelsregisternummer: HRA 57918
> Persönlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
> Sitz: München - Registergericht: Amtsgericht München -
> Handelsregisternummer: HRB 54477
> Geschäftsführer: Dr. Michael Neuhäuser; Stephan Schenk; Walter Trauninger;
> Markus Zeiler
> 
>


-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140484): 
https://lists.openembedded.org/g/openembedded-core/message/140484
Mute This Topic: https://lists.openembedded.org/mt/75394824/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core] [PATCH] libgcc: Set LICENSE for -lic package

2020-07-09 Thread Christian Eggers
Hi Quentin,

Am Donnerstag, 9. Juli 2020, 15:25:00 CEST schrieb Quentin Schulz:
> Not really directing the question to you but... does this actually makes
> sense? Is the license licensed? Can't we just empty LICENSE_${PN}-lic or
> not check the license for this package? That might be something that can
> be done in the license.bbclass for example.

I already asked myself what license the -lic package should have. Is this a
license of it's own (or none)?

>From the GPLv2:

"Copyright (C) 1989, 1991 Free Software Foundation, Inc.
51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA

Everyone is permitted to copy and distribute verbatim copies
of this license document, but changing it is not allowed."

Other licenses like MIT have no such restrictions, so that they
are often forked. But setting an individual license for each -lic paket may
also complicate things.

The patch I sent, "works for me". But I'll be also happy with another
solution...

regards
Christian




 
[http://assets.arri.com/media/sign/2020-04-03-E-mail-signature-Stellar2_V1.jpg] 


Get all the latest information from www.arri.com, 
Facebook, 
Twitter, Instagram 
and YouTube.

Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: München - Registergericht: Amtsgericht München - Handelsregisternummer: 
HRA 57918
Persönlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: München - Registergericht: Amtsgericht München - Handelsregisternummer: 
HRB 54477
Geschäftsführer: Dr. Michael Neuhäuser; Stephan Schenk; Walter Trauninger; 
Markus Zeiler
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140483): 
https://lists.openembedded.org/g/openembedded-core/message/140483
Mute This Topic: https://lists.openembedded.org/mt/75396771/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core] [PATCH] libgcc: Set LICENSE for -lic package

2020-07-09 Thread Quentin Schulz
Hi Christian,

On Thu, Jul 09, 2020 at 03:17:34PM +0200, Christian Eggers wrote:
> The default license (GPL-3.0-with-GCC-exception & GPLv3) is not suitable
> for installing libgcc-lic on an image where INCOMPATIBLE_LICENSE is set
> to "GPL-3.0".
> 
> Signed-off-by: Christian Eggers 
> ---
>  meta/recipes-devtools/gcc/libgcc.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-devtools/gcc/libgcc.inc 
> b/meta/recipes-devtools/gcc/libgcc.inc
> index 6d48ec9809..372da46459 100644
> --- a/meta/recipes-devtools/gcc/libgcc.inc
> +++ b/meta/recipes-devtools/gcc/libgcc.inc
> @@ -35,6 +35,7 @@ PACKAGES = "\
>  LICENSE_${PN} = "GPL-3.0-with-GCC-exception"
>  LICENSE_${PN}-dev = "GPL-3.0-with-GCC-exception"
>  LICENSE_${PN}-dbg = "GPL-3.0-with-GCC-exception"
> +LICENSE_${PN}-lic = "GPL-3.0-with-GCC-exception"
>  

Not really directing the question to you but... does this actually makes
sense? Is the license licensed? Can't we just empty LICENSE_${PN}-lic or
not check the license for this package? That might be something that can
be done in the license.bbclass for example.

Nothing else to say though on that particular patch :)

Quentin
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140482): 
https://lists.openembedded.org/g/openembedded-core/message/140482
Mute This Topic: https://lists.openembedded.org/mt/75396771/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[OE-core] [PATCH] libgcc: Set LICENSE for -lic package

2020-07-09 Thread Christian Eggers
The default license (GPL-3.0-with-GCC-exception & GPLv3) is not suitable
for installing libgcc-lic on an image where INCOMPATIBLE_LICENSE is set
to "GPL-3.0".

Signed-off-by: Christian Eggers 
---
 meta/recipes-devtools/gcc/libgcc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/gcc/libgcc.inc 
b/meta/recipes-devtools/gcc/libgcc.inc
index 6d48ec9809..372da46459 100644
--- a/meta/recipes-devtools/gcc/libgcc.inc
+++ b/meta/recipes-devtools/gcc/libgcc.inc
@@ -35,6 +35,7 @@ PACKAGES = "\
 LICENSE_${PN} = "GPL-3.0-with-GCC-exception"
 LICENSE_${PN}-dev = "GPL-3.0-with-GCC-exception"
 LICENSE_${PN}-dbg = "GPL-3.0-with-GCC-exception"
+LICENSE_${PN}-lic = "GPL-3.0-with-GCC-exception"
 
 
 FILES_${PN}-dev = "\
-- 
Christian Eggers
Embedded software developer

Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: 
HRA 57918
Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: 
HRB 54477
Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; 
Markus Zeiler

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140481): 
https://lists.openembedded.org/g/openembedded-core/message/140481
Mute This Topic: https://lists.openembedded.org/mt/75396771/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core][PATCH] toolchain-scripts.bbclass: also recognize ${SDK_SYS} env setups

2020-07-09 Thread Jens Rehsack


> Am 09.07.2020 um 13:52 schrieb Otavio Salvador 
> :
> 
> Hello Jens,
> 
> I've added Richard on Cc.

/o\

> Em qui., 9 de jul. de 2020 às 01:13, Jens Rehsack  
> escreveu:
>>> Am 08.07.2020 um 23:20 schrieb Otavio Salvador 
>>> :
>>> 
>>> Em qua., 8 de jul. de 2020 às 16:58, Jens Rehsack  
>>> escreveu:
 
 Instead of recognizing only environment-setup scripts in
 ${STAGING_DIR_TARGET} or ${STAGING_DIR_NATIVE}, respectively - lurk also 
 into
 ${SDKPATH}/buildtools/sysroots/${SDK_SYS} where nativesdk-openssl installs
 setup files.
 
 Remove overwriting of OPENSSL_CONF from buildtools-tarball.bb to clarify
 whether nativesdk-openssl installs wrong content or buildtools-tarball:
   (nativesdk-openssl) tmp/sysroots/x86_64/usr/lib/ssl-1.1/openssl.cnf
   (buildtools-tarball) 
 buildtools/sysroots/x86_64-pokysdk-linux/etc/ssl/openssl.cnf
 
 Signed-off-by: Jens Rehsack 
>>> 
>>> I did not understand the openssl related change. Is it possible to
>>> rework the commit log so it is more detailed?
>> 
>> For sure, but maybe I'm completely wrong. Let me try explaining it first...
>> 
>> If - and only if - one creates an SDK which included openssl (and not 
>> libressl, mbedssl, ...),
>> nativesdk-openssl packages an ${SDKPATHNATIVE}/environment-setup.d/openssl.sh
>> 
>> OTOH - meta/recipes-core/meta/buildtools-tarball.bb creates a script which 
>> is sourced
>> at the very end of SDK environment setup and writes what's included in
>> {SDKPATHNATIVE}/environment-setup.d/openssl.sh on it's own - with maybe 
>> slightly
>> different location - what guides me to add:
>> ... to clarify whether nativesdk-openssl installs wrong content or 
>> buildtools-tarball:
>>   (nativesdk-openssl) tmp/sysroots/x86_64/usr/lib/ssl-1.1/openssl.cnf
>>   (buildtools-tarball) 
>> buildtools/sysroots/x86_64-pokysdk-linux/etc/ssl/openssl.cnf
>> 
>> Maybe they way how nativesdk-cmake is doing it is the right way. Then, maybe
>> nativesdk-openssl should be reworked. This is for clarification.
>> 
>> Does it explain something better?
> 
> Yes and generating it directly might indeed be not the best option.
> Ideally, it'd generate a new source script which would run later and
> do any need adjustment. Do you agree?

I have at least no idea. I just wondered and thought asking this way
is an option.

> Either way, this commit seems to be mixing two changes and I'd prefer
> if you split it. This allow for nicer review as well as better commit
> messages of individual changes.

Of course I can (and will) split both changes and discuss them separately.
But I rated it highly possible that I get the feedback: both are wrong.
It's intended and should be X and Y and please send an update for 
nativesdk-openssl :)

Cheers
--
Jens Rehsack - rehs...@gmail.com



signature.asc
Description: Message signed with OpenPGP
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140480): 
https://lists.openembedded.org/g/openembedded-core/message/140480
Mute This Topic: https://lists.openembedded.org/mt/75384624/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core] [PATCH v2] rootfs-post: remove trailing blanks from tasks

2020-07-09 Thread Konrad Weihmann
Yep, I suspect the resulting empty shell statement to cause problems - 
if I'll find some time later, I can take a deeper look into it


On 09.07.20 13:57, Alex Kiernan wrote:

On Thu, Jul 9, 2020 at 8:19 AM Konrad Weihmann  wrote:


remove the trailing blanks before the ;-delimiter, so one could use
"_remove" to avoid running tasks like 'rootfs_update_timestamp',
which are currently hardcoded and not bound to any
configurable feature flag

Signed-off-by: Konrad Weihmann 
---


I think this duplicates a change I submitted:

https://patchwork.openembedded.org/patch/168931/

Comment from @Richard Purdie at the time was "This does sound like
you're working around a bug in shlex :/", which I started to dig into,
but failed to figure it out.






  meta/classes/rootfs-postcommands.bbclass | 6 +++---
  meta/classes/rootfsdebugfiles.bbclass| 2 +-
  2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta/classes/rootfs-postcommands.bbclass 
b/meta/classes/rootfs-postcommands.bbclass
index c43b9a9823..984730ebe8 100644
--- a/meta/classes/rootfs-postcommands.bbclass
+++ b/meta/classes/rootfs-postcommands.bbclass
@@ -1,6 +1,6 @@

  # Zap the root password if debug-tweaks feature is not enabled
-ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 'debug-tweaks', 
'empty-root-password' ], "", "zap_empty_root_password ; ",d)}'
+ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 'debug-tweaks', 
'empty-root-password' ], "", "zap_empty_root_password; ",d)}'

  # Allow dropbear/openssh to accept logins from accounts with an empty 
password string if debug-tweaks or allow-empty-password is enabled
  ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 'debug-tweaks', 
'allow-empty-password' ], "ssh_allow_empty_password; ", "",d)}'
@@ -12,7 +12,7 @@ ROOTFS_POSTPROCESS_COMMAND += 
'${@bb.utils.contains_any("IMAGE_FEATURES", [ 'deb
  ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 'debug-tweaks', 
'post-install-logging' ], "postinst_enable_logging; ", "",d)}'

  # Create /etc/timestamp during image construction to give a reasonably sane 
default time setting
-ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp ; "
+ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp; "

  # Tweak the mount options for rootfs in /etc/fstab if read-only-rootfs is 
enabled
  ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains("IMAGE_FEATURES", "read-only-rootfs", 
"read_only_rootfs_hook; ", "",d)}'
@@ -26,7 +26,7 @@ ROOTFS_POSTPROCESS_COMMAND += 
'${@bb.utils.contains("IMAGE_FEATURES", "read-only
  APPEND_append = '${@bb.utils.contains("IMAGE_FEATURES", "read-only-rootfs", " ro", 
"", d)}'

  # Generates test data file with data store variables expanded in json format
-ROOTFS_POSTPROCESS_COMMAND += "write_image_test_data ; "
+ROOTFS_POSTPROCESS_COMMAND += "write_image_test_data; "

  # Write manifest
  IMAGE_MANIFEST = "${IMGDEPLOYDIR}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.manifest"
diff --git a/meta/classes/rootfsdebugfiles.bbclass 
b/meta/classes/rootfsdebugfiles.bbclass
index e2ba4e3647..85c7ec7434 100644
--- a/meta/classes/rootfsdebugfiles.bbclass
+++ b/meta/classes/rootfsdebugfiles.bbclass
@@ -28,7 +28,7 @@
  ROOTFS_DEBUG_FILES ?= ""
  ROOTFS_DEBUG_FILES[doc] = "Lists additional files or directories to be installed 
with 'cp -a' in the format 'source1 target1;source2 target2;...'"

-ROOTFS_POSTPROCESS_COMMAND += "rootfs_debug_files ;"
+ROOTFS_POSTPROCESS_COMMAND += "rootfs_debug_files;"
  rootfs_debug_files () {
 #!/bin/sh -e
 echo "${ROOTFS_DEBUG_FILES}" | sed -e 's/;/\n/g' | while read source 
target mode; do
--
2.20.1






--
Alex Kiernan

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140479): 
https://lists.openembedded.org/g/openembedded-core/message/140479
Mute This Topic: https://lists.openembedded.org/mt/75393087/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core] [PATCH v2] rootfs-post: remove trailing blanks from tasks

2020-07-09 Thread Alex Kiernan
On Thu, Jul 9, 2020 at 8:19 AM Konrad Weihmann  wrote:
>
> remove the trailing blanks before the ;-delimiter, so one could use
> "_remove" to avoid running tasks like 'rootfs_update_timestamp',
> which are currently hardcoded and not bound to any
> configurable feature flag
>
> Signed-off-by: Konrad Weihmann 
> ---

I think this duplicates a change I submitted:

https://patchwork.openembedded.org/patch/168931/

Comment from @Richard Purdie at the time was "This does sound like
you're working around a bug in shlex :/", which I started to dig into,
but failed to figure it out.





>  meta/classes/rootfs-postcommands.bbclass | 6 +++---
>  meta/classes/rootfsdebugfiles.bbclass| 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/meta/classes/rootfs-postcommands.bbclass 
> b/meta/classes/rootfs-postcommands.bbclass
> index c43b9a9823..984730ebe8 100644
> --- a/meta/classes/rootfs-postcommands.bbclass
> +++ b/meta/classes/rootfs-postcommands.bbclass
> @@ -1,6 +1,6 @@
>
>  # Zap the root password if debug-tweaks feature is not enabled
> -ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 
> 'debug-tweaks', 'empty-root-password' ], "", "zap_empty_root_password ; ",d)}'
> +ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 
> 'debug-tweaks', 'empty-root-password' ], "", "zap_empty_root_password; ",d)}'
>
>  # Allow dropbear/openssh to accept logins from accounts with an empty 
> password string if debug-tweaks or allow-empty-password is enabled
>  ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 
> 'debug-tweaks', 'allow-empty-password' ], "ssh_allow_empty_password; ", 
> "",d)}'
> @@ -12,7 +12,7 @@ ROOTFS_POSTPROCESS_COMMAND += 
> '${@bb.utils.contains_any("IMAGE_FEATURES", [ 'deb
>  ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 
> 'debug-tweaks', 'post-install-logging' ], "postinst_enable_logging; ", "",d)}'
>
>  # Create /etc/timestamp during image construction to give a reasonably sane 
> default time setting
> -ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp ; "
> +ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp; "
>
>  # Tweak the mount options for rootfs in /etc/fstab if read-only-rootfs is 
> enabled
>  ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains("IMAGE_FEATURES", 
> "read-only-rootfs", "read_only_rootfs_hook; ", "",d)}'
> @@ -26,7 +26,7 @@ ROOTFS_POSTPROCESS_COMMAND += 
> '${@bb.utils.contains("IMAGE_FEATURES", "read-only
>  APPEND_append = '${@bb.utils.contains("IMAGE_FEATURES", "read-only-rootfs", 
> " ro", "", d)}'
>
>  # Generates test data file with data store variables expanded in json format
> -ROOTFS_POSTPROCESS_COMMAND += "write_image_test_data ; "
> +ROOTFS_POSTPROCESS_COMMAND += "write_image_test_data; "
>
>  # Write manifest
>  IMAGE_MANIFEST = "${IMGDEPLOYDIR}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.manifest"
> diff --git a/meta/classes/rootfsdebugfiles.bbclass 
> b/meta/classes/rootfsdebugfiles.bbclass
> index e2ba4e3647..85c7ec7434 100644
> --- a/meta/classes/rootfsdebugfiles.bbclass
> +++ b/meta/classes/rootfsdebugfiles.bbclass
> @@ -28,7 +28,7 @@
>  ROOTFS_DEBUG_FILES ?= ""
>  ROOTFS_DEBUG_FILES[doc] = "Lists additional files or directories to be 
> installed with 'cp -a' in the format 'source1 target1;source2 target2;...'"
>
> -ROOTFS_POSTPROCESS_COMMAND += "rootfs_debug_files ;"
> +ROOTFS_POSTPROCESS_COMMAND += "rootfs_debug_files;"
>  rootfs_debug_files () {
> #!/bin/sh -e
> echo "${ROOTFS_DEBUG_FILES}" | sed -e 's/;/\n/g' | while read source 
> target mode; do
> --
> 2.20.1
>
> 



--
Alex Kiernan
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140478): 
https://lists.openembedded.org/g/openembedded-core/message/140478
Mute This Topic: https://lists.openembedded.org/mt/75393087/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core][PATCH] toolchain-scripts.bbclass: also recognize ${SDK_SYS} env setups

2020-07-09 Thread Otavio Salvador
Hello Jens,

I've added Richard on Cc.

Em qui., 9 de jul. de 2020 às 01:13, Jens Rehsack  escreveu:
> > Am 08.07.2020 um 23:20 schrieb Otavio Salvador 
> > :
> >
> > Em qua., 8 de jul. de 2020 às 16:58, Jens Rehsack  
> > escreveu:
> >>
> >> Instead of recognizing only environment-setup scripts in
> >> ${STAGING_DIR_TARGET} or ${STAGING_DIR_NATIVE}, respectively - lurk also 
> >> into
> >> ${SDKPATH}/buildtools/sysroots/${SDK_SYS} where nativesdk-openssl installs
> >> setup files.
> >>
> >> Remove overwriting of OPENSSL_CONF from buildtools-tarball.bb to clarify
> >> whether nativesdk-openssl installs wrong content or buildtools-tarball:
> >>(nativesdk-openssl) tmp/sysroots/x86_64/usr/lib/ssl-1.1/openssl.cnf
> >>(buildtools-tarball) 
> >> buildtools/sysroots/x86_64-pokysdk-linux/etc/ssl/openssl.cnf
> >>
> >> Signed-off-by: Jens Rehsack 
> >
> > I did not understand the openssl related change. Is it possible to
> > rework the commit log so it is more detailed?
>
> For sure, but maybe I'm completely wrong. Let me try explaining it first...
>
> If - and only if - one creates an SDK which included openssl (and not 
> libressl, mbedssl, ...),
> nativesdk-openssl packages an ${SDKPATHNATIVE}/environment-setup.d/openssl.sh
>
> OTOH - meta/recipes-core/meta/buildtools-tarball.bb creates a script which is 
> sourced
> at the very end of SDK environment setup and writes what's included in
> {SDKPATHNATIVE}/environment-setup.d/openssl.sh on it's own - with maybe 
> slightly
> different location - what guides me to add:
> ... to clarify whether nativesdk-openssl installs wrong content or 
> buildtools-tarball:
>(nativesdk-openssl) tmp/sysroots/x86_64/usr/lib/ssl-1.1/openssl.cnf
>(buildtools-tarball) 
> buildtools/sysroots/x86_64-pokysdk-linux/etc/ssl/openssl.cnf
>
> Maybe they way how nativesdk-cmake is doing it is the right way. Then, maybe
> nativesdk-openssl should be reworked. This is for clarification.
>
> Does it explain something better?

Yes and generating it directly might indeed be not the best option.
Ideally, it'd generate a new source script which would run later and
do any need adjustment. Do you agree?

Either way, this commit seems to be mixing two changes and I'd prefer
if you split it. This allow for nicer review as well as better commit
messages of individual changes.

-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854  Mobile: +1 (347) 903-9750
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140477): 
https://lists.openembedded.org/g/openembedded-core/message/140477
Mute This Topic: https://lists.openembedded.org/mt/75384624/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[OE-core] How to install individual -lic packages

2020-07-09 Thread Christian Eggers
I have set LICENSE_CREATE_PACKAGE to "1" in order to create additional -lic
packages per recipe. As NO_RECOMMENDATIONS is set to "1" in my image recipe,
the -lic packages are not installed automatically.

How can I install specific -lic packages "manually". My idea was to create a
new recipe which rdepends on all -lic packages which I would like to install.

# myrecipe.bb:
RDEPENDS_${PN} += "curl-lic"

After that I get the following error message:
ERROR: Nothing RPROVIDES 'curl-lic' (but ... RDEPENDS on or otherwise requires
it)

The same happened when I tried to add the -lic packages to IMAGE_INSTALL in my
image recipe.

I also tried adding one line in image.bbclass, but this changed nothing:

def add_package_and_files(d):
...
d.setVar('PACKAGES', "%s %s" % (pn_lic, packages))
d.setVar('FILES_' + pn_lic, files)
+   d.setVar('RPROVIDES_' + pn_lic, pn_lic)


How can I install -lic packages in my rootfs without setting
NO_RECOMMENDATIONS to 0?

regards
Christian





 
[http://assets.arri.com/media/sign/2020-04-03-E-mail-signature-Stellar2_V1.jpg] 


Get all the latest information from www.arri.com, 
Facebook, 
Twitter, Instagram 
and YouTube.

Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: München - Registergericht: Amtsgericht München - Handelsregisternummer: 
HRA 57918
Persönlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: München - Registergericht: Amtsgericht München - Handelsregisternummer: 
HRB 54477
Geschäftsführer: Dr. Michael Neuhäuser; Stephan Schenk; Walter Trauninger; 
Markus Zeiler
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140476): 
https://lists.openembedded.org/g/openembedded-core/message/140476
Mute This Topic: https://lists.openembedded.org/mt/75394824/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core] [PATCH v4 01/12] Move rpm manifest to its own subdir

2020-07-09 Thread Fredrik Gustafsson
Hi,
is there something I can do to make this series move forward?

/Fredrik

From: Fredrik Gustafsson
Sent: Friday, July 3, 2020 1:43 PM
To: openembedded-core@lists.openembedded.org
Cc: tools-cfpbuild-internal; Fredrik Gustafsson
Subject: [PATCH v4 01/12] Move rpm manifest to its own subdir

This is a part of a refactor that will split the package manager
code so that it's possible to use other package managers in other
layers.

Signed-off-by: Fredrik Gustafsson 
---
 meta/lib/oe/manifest.py  | 51 +-
 meta/lib/oe/package_managers/rpm/__init__.py |  3 ++
 meta/lib/oe/package_managers/rpm/manifest.py | 56 
 meta/lib/oe/rootfs.py|  2 +
 4 files changed, 62 insertions(+), 50 deletions(-)
 create mode 100644 meta/lib/oe/package_managers/rpm/__init__.py
 create mode 100644 meta/lib/oe/package_managers/rpm/manifest.py

diff --git a/meta/lib/oe/manifest.py b/meta/lib/oe/manifest.py
index f7c88f9a09..cf2cbe22eb 100644
--- a/meta/lib/oe/manifest.py
+++ b/meta/lib/oe/manifest.py
@@ -189,56 +189,6 @@ class Manifest(object, metaclass=ABCMeta):
 return installed_pkgs


-class RpmManifest(Manifest):
-"""
-Returns a dictionary object with mip and mlp packages.
-"""
-def _split_multilib(self, pkg_list):
-pkgs = dict()
-
-for pkg in pkg_list.split():
-pkg_type = self.PKG_TYPE_MUST_INSTALL
-
-ml_variants = self.d.getVar('MULTILIB_VARIANTS').split()
-
-for ml_variant in ml_variants:
-if pkg.startswith(ml_variant + '-'):
-pkg_type = self.PKG_TYPE_MULTILIB
-
-if not pkg_type in pkgs:
-pkgs[pkg_type] = pkg
-else:
-pkgs[pkg_type] += " " + pkg
-
-return pkgs
-
-def create_initial(self):
-pkgs = dict()
-
-with open(self.initial_manifest, "w+") as manifest:
-manifest.write(self.initial_manifest_file_header)
-
-for var in self.var_maps[self.manifest_type]:
-if var in self.vars_to_split:
-split_pkgs = self._split_multilib(self.d.getVar(var))
-if split_pkgs is not None:
-pkgs = dict(list(pkgs.items()) + 
list(split_pkgs.items()))
-else:
-pkg_list = self.d.getVar(var)
-if pkg_list is not None:
-pkgs[self.var_maps[self.manifest_type][var]] = 
self.d.getVar(var)
-
-for pkg_type in pkgs:
-for pkg in pkgs[pkg_type].split():
-manifest.write("%s,%s\n" % (pkg_type, pkg))
-
-def create_final(self):
-pass
-
-def create_full(self, pm):
-pass
-
-
 class OpkgManifest(Manifest):
 """
 Returns a dictionary object with mip and mlp packages.
@@ -332,6 +282,7 @@ class DpkgManifest(Manifest):

 def create_manifest(d, final_manifest=False, manifest_dir=None,
 manifest_type=Manifest.MANIFEST_TYPE_IMAGE):
+from oe.package_managers.rpm.manifest import RpmManifest
 manifest_map = {'rpm': RpmManifest,
 'ipk': OpkgManifest,
 'deb': DpkgManifest}
diff --git a/meta/lib/oe/package_managers/rpm/__init__.py 
b/meta/lib/oe/package_managers/rpm/__init__.py
new file mode 100644
index 00..a2094304c9
--- /dev/null
+++ b/meta/lib/oe/package_managers/rpm/__init__.py
@@ -0,0 +1,3 @@
+#
+# SPDX-License-Identifier: GPL-2.0-only
+#
diff --git a/meta/lib/oe/package_managers/rpm/manifest.py 
b/meta/lib/oe/package_managers/rpm/manifest.py
new file mode 100644
index 00..9047462951
--- /dev/null
+++ b/meta/lib/oe/package_managers/rpm/manifest.py
@@ -0,0 +1,56 @@
+#
+# SPDX-License-Identifier: GPL-2.0-only
+#
+
+from oe.manifest import Manifest
+
+class RpmManifest(Manifest):
+"""
+Returns a dictionary object with mip and mlp packages.
+"""
+def _split_multilib(self, pkg_list):
+pkgs = dict()
+
+for pkg in pkg_list.split():
+pkg_type = self.PKG_TYPE_MUST_INSTALL
+
+ml_variants = self.d.getVar('MULTILIB_VARIANTS').split()
+
+for ml_variant in ml_variants:
+if pkg.startswith(ml_variant + '-'):
+pkg_type = self.PKG_TYPE_MULTILIB
+
+if not pkg_type in pkgs:
+pkgs[pkg_type] = pkg
+else:
+pkgs[pkg_type] += " " + pkg
+
+return pkgs
+
+def create_initial(self):
+pkgs = dict()
+
+with open(self.initial_manifest, "w+") as manifest:
+manifest.write(self.initial_manifest_file_header)
+
+for var in self.var_maps[self.manifest_type]:
+if var in self.vars_to_split:
+split_pkgs = self._split_multilib(self.d.getVar(var))
+if split_pkgs is not None:
+pkgs = dict(

Re: [OE-core] [PATCH v3] nopackages.bbclass: Get tasks from variable

2020-07-09 Thread Fredrik Gustafsson
Hi Richard,
is there something I can do to make this move forward?

/Fredrik

From: Fredrik Gustafsson
Sent: Wednesday, July 1, 2020 10:46 AM
To: openembedded-core@lists.openembedded.org
Cc: tools-cfpbuild-internal; Fredrik Gustafsson
Subject: [PATCH v3] nopackages.bbclass: Get tasks from variable

Get tasks from a variable instead of having them hardcoded. This will
enable other layers to add tasks that should be deleted when nopackages
is used.

Signed-off-by: Fredrik Gustafsson 
---
 meta/classes/nopackages.bbclass | 19 +++
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/meta/classes/nopackages.bbclass b/meta/classes/nopackages.bbclass
index 559f5078bd..4c9fe510c5 100644
--- a/meta/classes/nopackages.bbclass
+++ b/meta/classes/nopackages.bbclass
@@ -1,12 +1,7 @@
-deltask do_package
-deltask do_package_write_rpm
-deltask do_package_write_ipk
-deltask do_package_write_deb
-deltask do_package_qa
-deltask do_packagedata
-deltask do_package_setscene
-deltask do_package_write_rpm_setscene
-deltask do_package_write_ipk_setscene
-deltask do_package_write_deb_setscene
-deltask do_package_qa_setscene
-deltask do_packagedata_setscene
+NO_PACKAGES_DELTASKS += "do_package do_package_write_rpm do_package_write_ipk 
do_package_write_deb do_package_qa do_packagedata do_package_setscene 
do_package_write_rpm_setscene do_package_write_ipk_setscene 
do_package_write_deb_setscene do_package_qa_setscene do_packagedata_setscene"
+
+python () {
+list = d.getVar("NO_PACKAGES_DELTASKS").split()
+for task in list:
+bb.build.deltask(task, d)
+}
--
2.20.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140474): 
https://lists.openembedded.org/g/openembedded-core/message/140474
Mute This Topic: https://lists.openembedded.org/mt/75231136/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core] license.manifest misses header-only libraries

2020-07-09 Thread Christian Eggers
Am Mittwoch, 8. Juli 2020, 18:19:24 CEST schrieb Richard Purdie:
> On Wed, 2020-07-08 at 17:48 +0200, Christian Eggers wrote:
> > [...]
> > Is there a reliable way to get the header-only/static libraries into
> > the manifest file?
>
> The image manifest is a list of the things actually shipping in the
> image and their corresponding licenses. Most images don't ship
> development headers so they'll not be included there.
I'm more focusing on the (empty) main packages, not the -dev
packages with the header files.

> You can certainly get a list of everything used during the build
> instead. I'm not sure how you'd decide that a set of headers were used
> or not, compared to say the cross toolchain binaries or a native tool
> though so anything in between these two is harder.
I suppose that the "archiver" class already tracks everything which has been
used for building. But I'm only looking for licenses which are distributed
with my binary embedded software

> There is some work I did a while back which traces all SPDX identifiers
> referenced by debug symbols in the code to better audit license
> information but the lack of SPDX headers in much of the code we use
> makes that less useful right now.
>
> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rpurdie/license-exp
> eriments-osls (and a presentation/slides at OSLS 2019)
Thanks for this hint. But I think that this is not exactly what I'm locking
for. For now I'll stay at manually rdepending on the empty main packages
of header only libraries for getting them into the license manifest.
For the case of the boost library, I'll probably "invent" some additional
empty sub packages for tracking the license of the boost components
I use.

At the end I'll anyway publish everything collected by the archiver class on
our download site. But for the printed documentation of our product I would
like to focus on licenses which apply for the "binary distribution".

regards
Christian




 
[http://assets.arri.com/media/sign/2020-04-03-E-mail-signature-Stellar2_V1.jpg] 


Get all the latest information from www.arri.com, 
Facebook, 
Twitter, Instagram 
and YouTube.

Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: München - Registergericht: Amtsgericht München - Handelsregisternummer: 
HRA 57918
Persönlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: München - Registergericht: Amtsgericht München - Handelsregisternummer: 
HRB 54477
Geschäftsführer: Dr. Michael Neuhäuser; Stephan Schenk; Walter Trauninger; 
Markus Zeiler
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140473): 
https://lists.openembedded.org/g/openembedded-core/message/140473
Mute This Topic: https://lists.openembedded.org/mt/75379155/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[OE-core] ✗ patchtest: failure for dpkg: update SRC_URI (rev2)

2020-07-09 Thread Patchwork
== Series Details ==

Series: dpkg: update SRC_URI (rev2)
Revision: 2
URL   : https://patchwork.openembedded.org/series/25025/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue Series does not apply on top of target branch 
[test_series_merge_on_head] 
  Suggested fixRebase your series on top of targeted branch
  Targeted branch  master (currently at b3c96103a5)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines: 
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140472): 
https://lists.openembedded.org/g/openembedded-core/message/140472
Mute This Topic: https://lists.openembedded.org/mt/75393824/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[OE-core] [PATCH] dpkg: change SRC_URI to take dpkg from git

2020-07-09 Thread Changqing Li
From: Changqing Li 

tar.xz on original URL have been removed, switch to use git

Signed-off-by: Changqing Li 
---
 meta/recipes-devtools/dpkg/dpkg.inc   |  9 -
 meta/recipes-devtools/dpkg/dpkg_1.20.0.bb | 10 +++---
 2 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-devtools/dpkg/dpkg.inc 
b/meta/recipes-devtools/dpkg/dpkg.inc
index 1c3c585d79..a309613259 100644
--- a/meta/recipes-devtools/dpkg/dpkg.inc
+++ b/meta/recipes-devtools/dpkg/dpkg.inc
@@ -7,7 +7,7 @@ DEPENDS_class-native = "bzip2-replacement-native zlib-native 
virtual/update-alte
 RDEPENDS_${PN} = "${VIRTUAL-RUNTIME_update-alternatives} perl"
 RDEPENDS_${PN}_class-native = ""
 
-UPSTREAM_CHECK_URI = "${DEBIAN_MIRROR}/main/d/dpkg/"
+UPSTREAM_CHECK_GITTAGREGEX = "(?P(\d+(\.\d+)+))"
 
 inherit autotools gettext perlnative pkgconfig perl-version update-alternatives
 
@@ -30,6 +30,13 @@ EXTRA_OECONF_append_class-target = " 
--disable-update-alternatives DEB_HOST_ARCH
 PACKAGECONFIG = "liblzma"
 PACKAGECONFIG[liblzma] = "--with-liblzma,--without-liblzma, xz"
 
+do_configure_prepend () {
+# autotools_do_configure updates po/Makefile.in.in, we also need
+# update dselect/po and scripts/po
+cp -f ${STAGING_DATADIR_NATIVE}/gettext/po/Makefile.in.in 
${S}/dselect/po/
+cp -f ${STAGING_DATADIR_NATIVE}/gettext/po/Makefile.in.in 
${S}/scripts/po/
+}
+
 do_install_append () {
if [ "${PN}" = "dpkg-native" ]; then
# update-alternatives doesn't have an offline mode
diff --git a/meta/recipes-devtools/dpkg/dpkg_1.20.0.bb 
b/meta/recipes-devtools/dpkg/dpkg_1.20.0.bb
index 089caeffb5..935dcac918 100644
--- a/meta/recipes-devtools/dpkg/dpkg_1.20.0.bb
+++ b/meta/recipes-devtools/dpkg/dpkg_1.20.0.bb
@@ -1,7 +1,7 @@
 require dpkg.inc
 LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
 
-SRC_URI = 
"http://snapshot.debian.org/archive/debian-debug/20200308T085219Z/pool/main/d/dpkg/${BPN}_${PV}.tar.xz
 \
+SRC_URI = "git://salsa.debian.org/dpkg-team/dpkg.git;protocol=https \
file://noman.patch \
file://remove-tar-no-timestamp.patch \
file://arch_pm.patch \
@@ -18,5 +18,9 @@ SRC_URI = 
"http://snapshot.debian.org/archive/debian-debug/20200308T085219Z/pool
 
 SRC_URI_append_class-native = " 
file://0001-build.c-ignore-return-of-1-from-tar-cf.patch"
 
-SRC_URI[md5sum] = "f88f077236a3ff3decae3b25c989893d"
-SRC_URI[sha256sum] = 
"b633cc2b0e030efb61e11029d8a3fb1123f719864c9992da2e52b471c96d0900"
+SRCREV = "314ac02663c5bd1a82b34745150bf13a39a549a3"
+
+S = "${WORKDIR}/git"
+
+#autotools.bbclass default AUTOTOOLS_AUXDIR is ${S}, we need to under 
${S}/build-aux
+AUTOTOOLS_AUXDIR = "${S}/build-aux"
-- 
2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140471): 
https://lists.openembedded.org/g/openembedded-core/message/140471
Mute This Topic: https://lists.openembedded.org/mt/75393788/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[OE-core] [PATCH] python3: define a profile directory path

2020-07-09 Thread Yu, Mingli
From: Mingli Yu 

After ccache upgrade to 3.7.10, there comes below error when
enable ccache to build python3 and check [1] and [2] for more
details.
 | Python-3.8.3/Modules/_contextvarsmodule.c:43:1: error: source locations for 
function 'PyInit__contextvars' have changed, the profile data may be out of 
date [-Werror=coverage-mismatch]

That's because the logic for profile directory changes a little in
[3] after ccache upgrades to 3.7.10.

So define a profile directory path accordingly to fix the above error.

[1] https://github.com/ccache/ccache/issues/615
[2] https://lists.openembedded.org/g/openembedded-core/topic/75170448#140065
[3] 
https://github.com/ccache/ccache/commit/91a2954eb47b4a106e2be6cf611917b895108e35

Signed-off-by: Mingli Yu 
---
 ...re.ac-define-a-path-for-profile-data.patch | 42 +++
 meta/recipes-devtools/python/python3_3.8.3.bb |  1 +
 2 files changed, 43 insertions(+)
 create mode 100644 
meta/recipes-devtools/python/python3/0001-configure.ac-define-a-path-for-profile-data.patch

diff --git 
a/meta/recipes-devtools/python/python3/0001-configure.ac-define-a-path-for-profile-data.patch
 
b/meta/recipes-devtools/python/python3/0001-configure.ac-define-a-path-for-profile-data.patch
new file mode 100644
index 00..ee3d645521
--- /dev/null
+++ 
b/meta/recipes-devtools/python/python3/0001-configure.ac-define-a-path-for-profile-data.patch
@@ -0,0 +1,42 @@
+From 5e94e315119117898ce1a2798641848f61d796b1 Mon Sep 17 00:00:00 2001
+From: Mingli Yu 
+Date: Thu, 9 Jul 2020 07:58:44 +
+Subject: [PATCH] configure.ac: define a path for profile data
+
+There comes below error when use ccache 3.7.10 to compile python3
+and check [1] for more details.
+ | Python-3.8.3/Modules/_contextvarsmodule.c:43:1: error: source locations for 
function 'PyInit__contextvars' have changed, the profile data may be out of 
date [-Werror=coverage-mismatch]
+
+That's because the logic for profile directory changes a little in
+[2] after ccache upgrades to 3.7.10.
+
+So define a profile directory path accordingly to fix the above error.
+
+[1] https://github.com/ccache/ccache/issues/615
+[2] 
https://github.com/ccache/ccache/commit/91a2954eb47b4a106e2be6cf611917b895108e35
+
+Upstream-Status: Submitted [https://github.com/python/cpython/pull/21408]
+
+Signed-off-by: Mingli Yu 
+---
+ configure.ac | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index 08fe397..bb15bda 100644
+--- a/configure.ac
 b/configure.ac
+@@ -1332,8 +1332,8 @@ case $cc_basename in
+ fi
+ ;;
+   *)
+-PGO_PROF_GEN_FLAG="-fprofile-generate"
+-PGO_PROF_USE_FLAG="-fprofile-use -fprofile-correction"
++PGO_PROF_GEN_FLAG="-fprofile-generate=$(pwd)"
++PGO_PROF_USE_FLAG="-fprofile-use=$(pwd) -fprofile-correction"
+ LLVM_PROF_MERGER="true"
+ LLVM_PROF_FILE=""
+ ;;
+-- 
+2.26.2
+
diff --git a/meta/recipes-devtools/python/python3_3.8.3.bb 
b/meta/recipes-devtools/python/python3_3.8.3.bb
index a7cfbad5cd..7e0f35ce41 100644
--- a/meta/recipes-devtools/python/python3_3.8.3.bb
+++ b/meta/recipes-devtools/python/python3_3.8.3.bb
@@ -32,6 +32,7 @@ SRC_URI = 
"http://www.python.org/ftp/python/${PV}/Python-${PV}.tar.xz \
file://0001-configure.ac-fix-LIBPL.patch \
file://0001-python3-Do-not-hardcode-lib-for-distutils.patch \

file://0020-configure.ac-setup.py-do-not-add-a-curses-include-pa.patch \
+   file://0001-configure.ac-define-a-path-for-profile-data.patch \
"
 
 SRC_URI_append_class-native = " \
-- 
2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140470): 
https://lists.openembedded.org/g/openembedded-core/message/140470
Mute This Topic: https://lists.openembedded.org/mt/75393747/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [oe-core][PATCH] linux-firmware: fix iwlwifi-misc to include all iwlwifi firmware

2020-07-09 Thread Richard Purdie
On Thu, 2020-07-09 at 13:50 +0800, Jun Miao wrote:
> Signed-off-by: Jun Miao 
> ---
>  meta/recipes-kernel/linux-firmware/linux-firmware_20200619.bb | 3 +-
> -
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-kernel/linux-firmware/linux-
> firmware_20200619.bb b/meta/recipes-kernel/linux-firmware/linux-
> firmware_20200619.bb
> index 79acccddc7..321d808884 100644
> --- a/meta/recipes-kernel/linux-firmware/linux-firmware_20200619.bb
> +++ b/meta/recipes-kernel/linux-firmware/linux-firmware_20200619.bb
> @@ -265,7 +265,7 @@ PACKAGES =+ "${PN}-ralink-license ${PN}-ralink \
>   \
>   ${PN}-imx-sdma-license ${PN}-imx-sdma-imx6q ${PN}-imx-
> sdma-imx7d \
>   \
> - ${PN}-iwlwifi-license ${PN}-iwlwifi \
> + ${PN}-iwlwifi-license ${PN}-iwlwifi ${PN}-iwlwifi-misc
> \
>   ${PN}-iwlwifi-135-6 \
>   ${PN}-iwlwifi-3160-7 ${PN}-iwlwifi-3160-8 ${PN}-
> iwlwifi-3160-9 \
>   ${PN}-iwlwifi-3160-10 ${PN}-iwlwifi-3160-12 ${PN}-
> iwlwifi-3160-13 \
> @@ -277,7 +277,6 @@ PACKAGES =+ "${PN}-ralink-license ${PN}-ralink \
>   ${PN}-iwlwifi-7265 \
>   ${PN}-iwlwifi-7265d ${PN}-iwlwifi-8000c ${PN}-iwlwifi-
> 8265 \
>   ${PN}-iwlwifi-9000 \
> - ${PN}-iwlwifi-misc \
>   ${PN}-ibt-license ${PN}-ibt ${PN}-ibt-misc \
>   ${PN}-ibt-11-5 ${PN}-ibt-12-16 ${PN}-ibt-hw-37-7 ${PN}-
> ibt-hw-37-8 \
>   ${PN}-ibt-17 \

Why? Does this make the individual iwlwifi packages empty?

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140469): 
https://lists.openembedded.org/g/openembedded-core/message/140469
Mute This Topic: https://lists.openembedded.org/mt/75392421/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core] [PATCH 1/2] rootfs-post: remove traling blanks from tasks

2020-07-09 Thread Konrad Weihmann

Thanks - missed that -> sent a v2

On 09.07.20 07:30, Jens Rehsack wrote:




Am 08.07.2020 um 13:09 schrieb Konrad Weihmann :

remove the traling blanks before the ;-delimiter, so one could use

^
here & subject: do you mean "trailing"?


"_remove" to avoid running tasks like 'rootfs_update_timestamp',
which are currently hardcoded and not bound to any
configurable feature flag

Signed-off-by: Konrad Weihmann 
---
meta/classes/rootfs-postcommands.bbclass | 6 +++---
meta/classes/rootfsdebugfiles.bbclass| 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta/classes/rootfs-postcommands.bbclass 
b/meta/classes/rootfs-postcommands.bbclass
index c43b9a9823..984730ebe8 100644
--- a/meta/classes/rootfs-postcommands.bbclass
+++ b/meta/classes/rootfs-postcommands.bbclass
@@ -1,6 +1,6 @@

# Zap the root password if debug-tweaks feature is not enabled
-ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 'debug-tweaks', 
'empty-root-password' ], "", "zap_empty_root_password ; ",d)}'
+ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 'debug-tweaks', 
'empty-root-password' ], "", "zap_empty_root_password; ",d)}'

# Allow dropbear/openssh to accept logins from accounts with an empty password 
string if debug-tweaks or allow-empty-password is enabled
ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 'debug-tweaks', 
'allow-empty-password' ], "ssh_allow_empty_password; ", "",d)}'
@@ -12,7 +12,7 @@ ROOTFS_POSTPROCESS_COMMAND += 
'${@bb.utils.contains_any("IMAGE_FEATURES", [ 'deb
ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 'debug-tweaks', 
'post-install-logging' ], "postinst_enable_logging; ", "",d)}'

# Create /etc/timestamp during image construction to give a reasonably sane 
default time setting
-ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp ; "
+ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp; "


How about
+ROOTFS_POSTPROCESS_COMMAND += " rootfs_update_timestamp;"

Reading a list is much easier when words are separated by whitespaces.


# Tweak the mount options for rootfs in /etc/fstab if read-only-rootfs is 
enabled
ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains("IMAGE_FEATURES", "read-only-rootfs", 
"read_only_rootfs_hook; ", "",d)}'
@@ -26,7 +26,7 @@ ROOTFS_POSTPROCESS_COMMAND += 
'${@bb.utils.contains("IMAGE_FEATURES", "read-only
APPEND_append = '${@bb.utils.contains("IMAGE_FEATURES", "read-only-rootfs", " ro", 
"", d)}'

# Generates test data file with data store variables expanded in json format
-ROOTFS_POSTPROCESS_COMMAND += "write_image_test_data ; "
+ROOTFS_POSTPROCESS_COMMAND += "write_image_test_data; "

# Write manifest
IMAGE_MANIFEST = "${IMGDEPLOYDIR}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.manifest"
diff --git a/meta/classes/rootfsdebugfiles.bbclass 
b/meta/classes/rootfsdebugfiles.bbclass
index e2ba4e3647..85c7ec7434 100644
--- a/meta/classes/rootfsdebugfiles.bbclass
+++ b/meta/classes/rootfsdebugfiles.bbclass
@@ -28,7 +28,7 @@
ROOTFS_DEBUG_FILES ?= ""
ROOTFS_DEBUG_FILES[doc] = "Lists additional files or directories to be installed 
with 'cp -a' in the format 'source1 target1;source2 target2;...'"

-ROOTFS_POSTPROCESS_COMMAND += "rootfs_debug_files ;"
+ROOTFS_POSTPROCESS_COMMAND += "rootfs_debug_files;"
rootfs_debug_files () {
#!/bin/sh -e
echo "${ROOTFS_DEBUG_FILES}" | sed -e 's/;/\n/g' | while read source target 
mode; do
--
2.20.1




--
Jens Rehsack - rehs...@gmail.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140468): 
https://lists.openembedded.org/g/openembedded-core/message/140468
Mute This Topic: https://lists.openembedded.org/mt/75374080/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[OE-core] [PATCH v2] rootfs-post: remove trailing blanks from tasks

2020-07-09 Thread Konrad Weihmann
remove the trailing blanks before the ;-delimiter, so one could use
"_remove" to avoid running tasks like 'rootfs_update_timestamp',
which are currently hardcoded and not bound to any
configurable feature flag

Signed-off-by: Konrad Weihmann 
---
 meta/classes/rootfs-postcommands.bbclass | 6 +++---
 meta/classes/rootfsdebugfiles.bbclass| 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta/classes/rootfs-postcommands.bbclass 
b/meta/classes/rootfs-postcommands.bbclass
index c43b9a9823..984730ebe8 100644
--- a/meta/classes/rootfs-postcommands.bbclass
+++ b/meta/classes/rootfs-postcommands.bbclass
@@ -1,6 +1,6 @@
 
 # Zap the root password if debug-tweaks feature is not enabled
-ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 
'debug-tweaks', 'empty-root-password' ], "", "zap_empty_root_password ; ",d)}'
+ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 
'debug-tweaks', 'empty-root-password' ], "", "zap_empty_root_password; ",d)}'
 
 # Allow dropbear/openssh to accept logins from accounts with an empty password 
string if debug-tweaks or allow-empty-password is enabled
 ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 
'debug-tweaks', 'allow-empty-password' ], "ssh_allow_empty_password; ", "",d)}'
@@ -12,7 +12,7 @@ ROOTFS_POSTPROCESS_COMMAND += 
'${@bb.utils.contains_any("IMAGE_FEATURES", [ 'deb
 ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 
'debug-tweaks', 'post-install-logging' ], "postinst_enable_logging; ", "",d)}'
 
 # Create /etc/timestamp during image construction to give a reasonably sane 
default time setting
-ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp ; "
+ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp; "
 
 # Tweak the mount options for rootfs in /etc/fstab if read-only-rootfs is 
enabled
 ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains("IMAGE_FEATURES", 
"read-only-rootfs", "read_only_rootfs_hook; ", "",d)}'
@@ -26,7 +26,7 @@ ROOTFS_POSTPROCESS_COMMAND += 
'${@bb.utils.contains("IMAGE_FEATURES", "read-only
 APPEND_append = '${@bb.utils.contains("IMAGE_FEATURES", "read-only-rootfs", " 
ro", "", d)}'
 
 # Generates test data file with data store variables expanded in json format
-ROOTFS_POSTPROCESS_COMMAND += "write_image_test_data ; "
+ROOTFS_POSTPROCESS_COMMAND += "write_image_test_data; "
 
 # Write manifest
 IMAGE_MANIFEST = "${IMGDEPLOYDIR}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.manifest"
diff --git a/meta/classes/rootfsdebugfiles.bbclass 
b/meta/classes/rootfsdebugfiles.bbclass
index e2ba4e3647..85c7ec7434 100644
--- a/meta/classes/rootfsdebugfiles.bbclass
+++ b/meta/classes/rootfsdebugfiles.bbclass
@@ -28,7 +28,7 @@
 ROOTFS_DEBUG_FILES ?= ""
 ROOTFS_DEBUG_FILES[doc] = "Lists additional files or directories to be 
installed with 'cp -a' in the format 'source1 target1;source2 target2;...'"
 
-ROOTFS_POSTPROCESS_COMMAND += "rootfs_debug_files ;"
+ROOTFS_POSTPROCESS_COMMAND += "rootfs_debug_files;"
 rootfs_debug_files () {
#!/bin/sh -e
echo "${ROOTFS_DEBUG_FILES}" | sed -e 's/;/\n/g' | while read source target 
mode; do
-- 
2.20.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140467): 
https://lists.openembedded.org/g/openembedded-core/message/140467
Mute This Topic: https://lists.openembedded.org/mt/75393087/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [OE-core] [PATCH 1/2] rootfs-post: remove traling blanks from tasks

2020-07-09 Thread Jens Rehsack


> Am 09.07.2020 um 07:37 schrieb Jacob Kroon :
> 
> On 7/9/20 7:30 AM, Jens Rehsack wrote:
>>> Am 08.07.2020 um 13:09 schrieb Konrad Weihmann :
>>> 
>>> remove the traling blanks before the ;-delimiter, so one could use
>>^
>>here & subject: do you mean "trailing"?
>>> "_remove" to avoid running tasks like 'rootfs_update_timestamp',
>>> which are currently hardcoded and not bound to any
>>> configurable feature flag
>>> 
>>> Signed-off-by: Konrad Weihmann 
>>> ---
>>> meta/classes/rootfs-postcommands.bbclass | 6 +++---
>>> meta/classes/rootfsdebugfiles.bbclass| 2 +-
>>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>> 
>>> diff --git a/meta/classes/rootfs-postcommands.bbclass 
>>> b/meta/classes/rootfs-postcommands.bbclass
>>> index c43b9a9823..984730ebe8 100644
>>> --- a/meta/classes/rootfs-postcommands.bbclass
>>> +++ b/meta/classes/rootfs-postcommands.bbclass
>>> @@ -1,6 +1,6 @@
>>> 
>>> # Zap the root password if debug-tweaks feature is not enabled
>>> -ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", 
>>> [ 'debug-tweaks', 'empty-root-password' ], "", "zap_empty_root_password ; 
>>> ",d)}'
>>> +ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", 
>>> [ 'debug-tweaks', 'empty-root-password' ], "", "zap_empty_root_password; 
>>> ",d)}'
>>> 
>>> # Allow dropbear/openssh to accept logins from accounts with an empty 
>>> password string if debug-tweaks or allow-empty-password is enabled
>>> ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 
>>> 'debug-tweaks', 'allow-empty-password' ], "ssh_allow_empty_password; ", 
>>> "",d)}'
>>> @@ -12,7 +12,7 @@ ROOTFS_POSTPROCESS_COMMAND += 
>>> '${@bb.utils.contains_any("IMAGE_FEATURES", [ 'deb
>>> ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", [ 
>>> 'debug-tweaks', 'post-install-logging' ], "postinst_enable_logging; ", 
>>> "",d)}'
>>> 
>>> # Create /etc/timestamp during image construction to give a reasonably sane 
>>> default time setting
>>> -ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp ; "
>>> +ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp; "
>> How about
>> +ROOTFS_POSTPROCESS_COMMAND += " rootfs_update_timestamp;"
>> Reading a list is much easier when words are separated by whitespaces.
> 
> The += and =+ operators already insert a space between the concatenations.
> 
> https://www.yoctoproject.org/docs/latest/bitbake-user-manual/bitbake-user-manual.html#appending-and-prepending
> 
> Jacob

I always become confused since often I have to use _append etc. (to avoid 
hitting ?=) - thanks for pointing that out.

Cheers
--
Jens Rehsack - rehs...@gmail.com



signature.asc
Description: Message signed with OpenPGP
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140466): 
https://lists.openembedded.org/g/openembedded-core/message/140466
Mute This Topic: https://lists.openembedded.org/mt/75374080/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[OE-core] [PATCH] [dunfell] coreutils: don't split stdbuf to own package with single-binary

2020-07-09 Thread Rasmus Villemoes
Commit 992cec44 (coreutils: Move stdbuf into an own package
coreutils-stdbuf) breaks package-qa when the single-binary
PACKAGECONFIG is used:

ERROR: coreutils-8.32-r0 do_package_qa: QA Issue: /usr/bin/stdbuf contained in 
package coreutils-stdbuf requires /usr/bin/coreutils, but no providers found in 
RDEPENDS_coreutils-stdbuf? [file-rdeps]
ERROR: coreutils-8.32-r0 do_package_qa: QA run found fatal errors. Please 
consider fixing them.

With that PACKAGECONFIG, /usr/bin/stdbuf is just a simple "script"
containing the single line

  #!/usr/bin/coreutils --coreutils-prog-shebang=stdbuf

Since there's no point splitting stdbuf to its own package when all
the functionality is in the single big coreutils binary anyway, fix
this by not creating the separate stdbuf package for the single-binary
case. But also make sure that the coreutils-stdbuf item always exists
so recipes can always RDEPEND on coreutils-stdbuf.

Signed-off-by: Rasmus Villemoes 
Signed-off-by: Richard Purdie 
(cherry picked from commit 74d24b5b895198898944260136d05e991a203c11)
---
 meta/recipes-core/coreutils/coreutils_8.31.bb | 15 +--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-core/coreutils/coreutils_8.31.bb 
b/meta/recipes-core/coreutils/coreutils_8.31.bb
index 2b196b7512..0c8452da98 100644
--- a/meta/recipes-core/coreutils/coreutils_8.31.bb
+++ b/meta/recipes-core/coreutils/coreutils_8.31.bb
@@ -59,9 +59,20 @@ base_bindir_progs = "cat chgrp chmod chown cp date dd echo 
false hostname kill l
 
 sbindir_progs= "chroot"
 
-PACKAGE_BEFORE_PN_class-target += "coreutils-stdbuf"
+# Split stdbuf into its own package, so one can include
+# coreutils-stdbuf without getting the rest of coreutils, but make
+# coreutils itself pull in stdbuf, so IMAGE_INSTALL += "coreutils"
+# always provides all coreutils
+PACKAGE_BEFORE_PN_class-target += "${@bb.utils.contains('PACKAGECONFIG', 
'single-binary', '', 'coreutils-stdbuf', d)}"
 FILES_coreutils-stdbuf = "${bindir}/stdbuf ${libdir}/coreutils/libstdbuf.so"
-RDEPENDS_coreutils_class-target += "coreutils-stdbuf"
+RDEPENDS_coreutils_class-target += "${@bb.utils.contains('PACKAGECONFIG', 
'single-binary', '', 'coreutils-stdbuf', d)}"
+
+# However, when the single-binary PACKAGECONFIG is used, stdbuf
+# functionality is built into the single coreutils binary, so there's
+# no point splitting /usr/bin/stdbuf to its own package. Instead, add
+# an RPROVIDE so that rdepending on coreutils-stdbuf will work
+# regardless of whether single-binary is in effect.
+RPROVIDES_coreutils += "${@bb.utils.contains('PACKAGECONFIG', 'single-binary', 
'coreutils-stdbuf', '', d)}"
 
 # Let aclocal use the relative path for the m4 file rather than the
 # absolute since coreutils has a lot of m4 files, otherwise there might
-- 
2.23.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140465): 
https://lists.openembedded.org/g/openembedded-core/message/140465
Mute This Topic: https://lists.openembedded.org/mt/75392946/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-