from:"Carlos Alberto Lopez Perez"

[OE-core] [PATCH v3] icu: Backport patch to fix build issues with long paths (>512 chars)

2024-07-31 Thread Carlos Alberto Lopez Perez

There is a bug libicu that causes libicu to be installed incorrectly when
the build system uses long paths (more than 512 chars).

This condition is not very difficult to trigger on a OE build system
due to the long paths an the deep of the directories that are usually
generated by default.
Also the bug is very subtle and won't be detected by the QA post-install
processes because what this bug causes is that a different version of
libicudata.so.X.Y (one without data) is installed instead of the one
containing the data, but there won't be any file missed on the installation
(just that it installed the wrong one).

See: https://unicode-org.atlassian.net/browse/ICU-22813

This patch backports the fix from upstream/main

Signed-off-by: Carlos Alberto Lopez Perez 
---
 ...813_rise_buffer_sizes_pkgdata_PR3058.patch | 72 +++
 meta/recipes-support/icu/icu_75-1.bb  |  1 +
 2 files changed, 73 insertions(+)
 create mode 100644 
meta/recipes-support/icu/icu/ICU-22813_rise_buffer_sizes_pkgdata_PR3058.patch

diff --git 
a/meta/recipes-support/icu/icu/ICU-22813_rise_buffer_sizes_pkgdata_PR3058.patch 
b/meta/recipes-support/icu/icu/ICU-22813_rise_buffer_sizes_pkgdata_PR3058.patch
new file mode 100644
index 00..5b97350e6f
--- /dev/null
+++ 
b/meta/recipes-support/icu/icu/ICU-22813_rise_buffer_sizes_pkgdata_PR3058.patch
@@ -0,0 +1,72 @@
+From db70adaddcfa8050db6a69cdfef080a7f1423ad7 Mon Sep 17 00:00:00 2001
+From: Carlos Alberto Lopez Perez 
+Date: Mon, 1 Jul 2024 22:15:18 +0100
+Subject: [PATCH] ICU-22813 Rise the size of the buffers used for the command
+ strings at pkgdata
+
+The tool pkgdata uses snprintf() to build the strings of the commands that
+will execute later during the install process. But the maximum size of this
+buffers is not enough when there is a long path.
+
+This has caused issues on some CI systems that use very long paths, causing
+the install process to produce a wrong result.
+
+The maximum path on Linux is 4096 (defined as PATH_MAX at )
+So the size of SMALL_BUFFER_MAX_SIZE should be 4096 to avoid errors related
+to truncated paths.
+
+Upstream-Status: Backport [https://github.com/unicode-org/icu/pull/3058]
+
+Signed-off-by: Carlos Alberto Lopez Perez 
+---
+ tools/pkgdata/pkgdata.cpp | 6 +++---
+ tools/toolutil/pkg_genc.h | 5 ++---
+ 2 files changed, 5 insertions(+), 6 deletions(-)
+
+diff --git a/tools/pkgdata/pkgdata.cpp b/tools/pkgdata/pkgdata.cpp
+index c2ac112..8d08c85 100644
+--- a/tools/pkgdata/pkgdata.cpp
 b/tools/pkgdata/pkgdata.cpp
+@@ -1134,7 +1134,7 @@ static int32_t pkg_createSymLinks(const char *targetDir, 
UBool specialHandling)
+ 
+ static int32_t pkg_installLibrary(const char *installDir, const char 
*targetDir, UBool noVersion) {
+ int32_t result = 0;
+-char cmd[SMALL_BUFFER_MAX_SIZE];
++char cmd[LARGE_BUFFER_MAX_SIZE];
+ 
+ auto ret = snprintf(cmd,
+ sizeof(cmd),
+@@ -1205,7 +1205,7 @@ static int32_t pkg_installLibrary(const char 
*installDir, const char *targetDir,
+ 
+ static int32_t pkg_installCommonMode(const char *installDir, const char 
*fileName) {
+ int32_t result = 0;
+-char cmd[SMALL_BUFFER_MAX_SIZE] = "";
++char cmd[LARGE_BUFFER_MAX_SIZE] = "";
+ 
+ if (!T_FileStream_file_exists(installDir)) {
+ UErrorCode status = U_ZERO_ERROR;
+@@ -1237,7 +1237,7 @@ static int32_t pkg_installCommonMode(const char 
*installDir, const char *fileNam
+ #endif
+ static int32_t pkg_installFileMode(const char *installDir, const char 
*srcDir, const char *fileListName) {
+ int32_t result = 0;
+-char cmd[SMALL_BUFFER_MAX_SIZE] = "";
++char cmd[LARGE_BUFFER_MAX_SIZE] = "";
+ 
+ if (!T_FileStream_file_exists(installDir)) {
+ UErrorCode status = U_ZERO_ERROR;
+diff --git a/tools/toolutil/pkg_genc.h b/tools/toolutil/pkg_genc.h
+index 2dd1b45..f811fe5 100644
+--- a/tools/toolutil/pkg_genc.h
 b/tools/toolutil/pkg_genc.h
+@@ -59,9 +59,8 @@
+ #define PKGDATA_FILE_SEP_STRING U_FILE_SEP_STRING
+ #endif
+ 
+-#define LARGE_BUFFER_MAX_SIZE 2048
+-#define SMALL_BUFFER_MAX_SIZE 512
+-#define SMALL_BUFFER_FLAG_NAMES 32
++#define LARGE_BUFFER_MAX_SIZE 16384
++#define SMALL_BUFFER_MAX_SIZE 4096
+ #define BUFFER_PADDING_SIZE 20
+ 
+ /** End platform defines **/
diff --git a/meta/recipes-support/icu/icu_75-1.bb 
b/meta/recipes-support/icu/icu_75-1.bb
index 88103e4eca..8f7f5e6cc7 100644
--- a/meta/recipes-support/icu/icu_75-1.bb
+++ b/meta/recipes-support/icu/icu_75-1.bb
@@ -120,6 +120,7 @@ SRC_URI = "${BASE_SRC_URI};name=code \
file://filter.json \
file://fix-install-manx.patch \
file://0001-icu-Added-armeb-support.patch \
+   file://ICU-22813_rise_buffer_sizes_pkgdata_PR3058.patch \
"
 
 SRC_URI:append:class-target = "\
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#202693): 
https://lists.openembedded.org/g/

[OE-core] [PATCH v2] icu: Backport patch to fix build issues with long paths (>512 chars)

2024-07-30 Thread Carlos Alberto Lopez Perez

Signed-off-by: Carlos Alberto Lopez Perez 
---
 ...813_rise_buffer_sizes_pkgdata_PR3058.patch | 72 +++
 meta/recipes-support/icu/icu_75-1.bb  |  1 +
 2 files changed, 73 insertions(+)
 create mode 100644 
meta/recipes-support/icu/icu/ICU-22813_rise_buffer_sizes_pkgdata_PR3058.patch

diff --git 
a/meta/recipes-support/icu/icu/ICU-22813_rise_buffer_sizes_pkgdata_PR3058.patch 
b/meta/recipes-support/icu/icu/ICU-22813_rise_buffer_sizes_pkgdata_PR3058.patch
new file mode 100644
index 00..5b97350e6f
--- /dev/null
+++ 
b/meta/recipes-support/icu/icu/ICU-22813_rise_buffer_sizes_pkgdata_PR3058.patch
@@ -0,0 +1,72 @@
+From db70adaddcfa8050db6a69cdfef080a7f1423ad7 Mon Sep 17 00:00:00 2001
+From: Carlos Alberto Lopez Perez 
+Date: Mon, 1 Jul 2024 22:15:18 +0100
+Subject: [PATCH] ICU-22813 Rise the size of the buffers used for the command
+ strings at pkgdata
+
+The tool pkgdata uses snprintf() to build the strings of the commands that
+will execute later during the install process. But the maximum size of this
+buffers is not enough when there is a long path.
+
+This has caused issues on some CI systems that use very long paths, causing
+the install process to produce a wrong result.
+
+The maximum path on Linux is 4096 (defined as PATH_MAX at )
+So the size of SMALL_BUFFER_MAX_SIZE should be 4096 to avoid errors related
+to truncated paths.
+
+Upstream-Status: Backport [https://github.com/unicode-org/icu/pull/3058]
+
+Signed-off-by: Carlos Alberto Lopez Perez 
+---
+ tools/pkgdata/pkgdata.cpp | 6 +++---
+ tools/toolutil/pkg_genc.h | 5 ++---
+ 2 files changed, 5 insertions(+), 6 deletions(-)
+
+diff --git a/tools/pkgdata/pkgdata.cpp b/tools/pkgdata/pkgdata.cpp
+index c2ac112..8d08c85 100644
+--- a/tools/pkgdata/pkgdata.cpp
 b/tools/pkgdata/pkgdata.cpp
+@@ -1134,7 +1134,7 @@ static int32_t pkg_createSymLinks(const char *targetDir, 
UBool specialHandling)
+ 
+ static int32_t pkg_installLibrary(const char *installDir, const char 
*targetDir, UBool noVersion) {
+ int32_t result = 0;
+-char cmd[SMALL_BUFFER_MAX_SIZE];
++char cmd[LARGE_BUFFER_MAX_SIZE];
+ 
+ auto ret = snprintf(cmd,
+ sizeof(cmd),
+@@ -1205,7 +1205,7 @@ static int32_t pkg_installLibrary(const char 
*installDir, const char *targetDir,
+ 
+ static int32_t pkg_installCommonMode(const char *installDir, const char 
*fileName) {
+ int32_t result = 0;
+-char cmd[SMALL_BUFFER_MAX_SIZE] = "";
++char cmd[LARGE_BUFFER_MAX_SIZE] = "";
+ 
+ if (!T_FileStream_file_exists(installDir)) {
+ UErrorCode status = U_ZERO_ERROR;
+@@ -1237,7 +1237,7 @@ static int32_t pkg_installCommonMode(const char 
*installDir, const char *fileNam
+ #endif
+ static int32_t pkg_installFileMode(const char *installDir, const char 
*srcDir, const char *fileListName) {
+ int32_t result = 0;
+-char cmd[SMALL_BUFFER_MAX_SIZE] = "";
++char cmd[LARGE_BUFFER_MAX_SIZE] = "";
+ 
+ if (!T_FileStream_file_exists(installDir)) {
+ UErrorCode status = U_ZERO_ERROR;
+diff --git a/tools/toolutil/pkg_genc.h b/tools/toolutil/pkg_genc.h
+index 2dd1b45..f811fe5 100644
+--- a/tools/toolutil/pkg_genc.h
 b/tools/toolutil/pkg_genc.h
+@@ -59,9 +59,8 @@
+ #define PKGDATA_FILE_SEP_STRING U_FILE_SEP_STRING
+ #endif
+ 
+-#define LARGE_BUFFER_MAX_SIZE 2048
+-#define SMALL_BUFFER_MAX_SIZE 512
+-#define SMALL_BUFFER_FLAG_NAMES 32
++#define LARGE_BUFFER_MAX_SIZE 16384
++#define SMALL_BUFFER_MAX_SIZE 4096
+ #define BUFFER_PADDING_SIZE 20
+ 
+ /** End platform defines **/
diff --git a/meta/recipes-support/icu/icu_75-1.bb 
b/meta/recipes-support/icu/icu_75-1.bb
index 88103e4eca..8f7f5e6cc7 100644
--- a/meta/recipes-support/icu/icu_75-1.bb
+++ b/meta/recipes-support/icu/icu_75-1.bb
@@ -120,6 +120,7 @@ SRC_URI = "${BASE_SRC_URI};name=code \
file://filter.json \
file://fix-install-manx.patch \
file://0001-icu-Added-armeb-support.patch \
+   file://ICU-22813_rise_buffer_sizes_pkgdata_PR3058.patch \
"
 
 SRC_URI:append:class-target = "\
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#202686): 
https://lists.openembedded.org/g/openembedded-core/message/202686
Mute This Topic: https://lists.openembedded.org/mt/107639107/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH] icu: Backport patch to fix build issues with long paths (>512 chars)

2024-07-29 Thread Carlos Alberto Lopez Perez

Signed-off-by: Carlos Alberto Lopez Perez 
---
 ...813_rise_buffer_sizes_pkgdata_PR3058.patch | 70 +++
 meta/recipes-support/icu/icu_75-1.bb  |  1 +
 2 files changed, 71 insertions(+)
 create mode 100644 
meta/recipes-support/icu/icu/ICU-22813_rise_buffer_sizes_pkgdata_PR3058.patch

diff --git 
a/meta/recipes-support/icu/icu/ICU-22813_rise_buffer_sizes_pkgdata_PR3058.patch 
b/meta/recipes-support/icu/icu/ICU-22813_rise_buffer_sizes_pkgdata_PR3058.patch
new file mode 100644
index 00..367ac75502
--- /dev/null
+++ 
b/meta/recipes-support/icu/icu/ICU-22813_rise_buffer_sizes_pkgdata_PR3058.patch
@@ -0,0 +1,70 @@
+From db70adaddcfa8050db6a69cdfef080a7f1423ad7 Mon Sep 17 00:00:00 2001
+From: Carlos Alberto Lopez Perez 
+Date: Mon, 1 Jul 2024 22:15:18 +0100
+Subject: [PATCH] ICU-22813 Rise the size of the buffers used for the command
+ strings at pkgdata
+
+The tool pkgdata uses snprintf() to build the strings of the commands that
+will execute later during the install process. But the maximum size of this
+buffers is not enough when there is a long path.
+
+This has caused issues on some CI systems that use very long paths, causing
+the install process to produce a wrong result.
+
+The maximum path on Linux is 4096 (defined as PATH_MAX at )
+So the size of SMALL_BUFFER_MAX_SIZE should be 4096 to avoid errors related
+to truncated paths.
+
+Upstream-Status: Backport [https://github.com/unicode-org/icu/pull/3058]
+---
+ tools/pkgdata/pkgdata.cpp | 6 +++---
+ tools/toolutil/pkg_genc.h | 5 ++---
+ 2 files changed, 5 insertions(+), 6 deletions(-)
+
+diff --git a/tools/pkgdata/pkgdata.cpp b/tools/pkgdata/pkgdata.cpp
+index c2ac112..8d08c85 100644
+--- a/tools/pkgdata/pkgdata.cpp
 b/tools/pkgdata/pkgdata.cpp
+@@ -1134,7 +1134,7 @@ static int32_t pkg_createSymLinks(const char *targetDir, 
UBool specialHandling)
+ 
+ static int32_t pkg_installLibrary(const char *installDir, const char 
*targetDir, UBool noVersion) {
+ int32_t result = 0;
+-char cmd[SMALL_BUFFER_MAX_SIZE];
++char cmd[LARGE_BUFFER_MAX_SIZE];
+ 
+ auto ret = snprintf(cmd,
+ sizeof(cmd),
+@@ -1205,7 +1205,7 @@ static int32_t pkg_installLibrary(const char 
*installDir, const char *targetDir,
+ 
+ static int32_t pkg_installCommonMode(const char *installDir, const char 
*fileName) {
+ int32_t result = 0;
+-char cmd[SMALL_BUFFER_MAX_SIZE] = "";
++char cmd[LARGE_BUFFER_MAX_SIZE] = "";
+ 
+ if (!T_FileStream_file_exists(installDir)) {
+ UErrorCode status = U_ZERO_ERROR;
+@@ -1237,7 +1237,7 @@ static int32_t pkg_installCommonMode(const char 
*installDir, const char *fileNam
+ #endif
+ static int32_t pkg_installFileMode(const char *installDir, const char 
*srcDir, const char *fileListName) {
+ int32_t result = 0;
+-char cmd[SMALL_BUFFER_MAX_SIZE] = "";
++char cmd[LARGE_BUFFER_MAX_SIZE] = "";
+ 
+ if (!T_FileStream_file_exists(installDir)) {
+ UErrorCode status = U_ZERO_ERROR;
+diff --git a/tools/toolutil/pkg_genc.h b/tools/toolutil/pkg_genc.h
+index 2dd1b45..f811fe5 100644
+--- a/tools/toolutil/pkg_genc.h
 b/tools/toolutil/pkg_genc.h
+@@ -59,9 +59,8 @@
+ #define PKGDATA_FILE_SEP_STRING U_FILE_SEP_STRING
+ #endif
+ 
+-#define LARGE_BUFFER_MAX_SIZE 2048
+-#define SMALL_BUFFER_MAX_SIZE 512
+-#define SMALL_BUFFER_FLAG_NAMES 32
++#define LARGE_BUFFER_MAX_SIZE 16384
++#define SMALL_BUFFER_MAX_SIZE 4096
+ #define BUFFER_PADDING_SIZE 20
+ 
+ /** End platform defines **/
diff --git a/meta/recipes-support/icu/icu_75-1.bb 
b/meta/recipes-support/icu/icu_75-1.bb
index 88103e4eca..8f7f5e6cc7 100644
--- a/meta/recipes-support/icu/icu_75-1.bb
+++ b/meta/recipes-support/icu/icu_75-1.bb
@@ -120,6 +120,7 @@ SRC_URI = "${BASE_SRC_URI};name=code \
file://filter.json \
file://fix-install-manx.patch \
file://0001-icu-Added-armeb-support.patch \
+   file://ICU-22813_rise_buffer_sizes_pkgdata_PR3058.patch \
"
 
 SRC_URI:append:class-target = "\
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#202663): 
https://lists.openembedded.org/g/openembedded-core/message/202663
Mute This Topic: https://lists.openembedded.org/mt/107619409/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH] mesa-demos: packageconfig weston should have a dependency on wayland-protocols

2023-03-02 Thread Carlos Alberto Lopez Perez

wayland-protocols is a required depency of mesa-demos when the 'wayland'
packageconfig option is enabled. Usually this doesn't lead to a build
failure because mesa itself depends on wayland-protocols, but when using
other graphics drivers this can cause the following build falure:

| ../mesa-demos-8.5.0/meson.build:69:2: ERROR: Dependency "wayland-protocols" 
not found, tried pkgconfig
| ERROR: meson failed

Signed-off-by: Carlos Alberto Lopez Perez 
---
 meta/recipes-graphics/mesa/mesa-demos_8.5.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/mesa/mesa-demos_8.5.0.bb 
b/meta/recipes-graphics/mesa/mesa-demos_8.5.0.bb
index 6e9b95e1e2..12f41d75a5 100644
--- a/meta/recipes-graphics/mesa/mesa-demos_8.5.0.bb
+++ b/meta/recipes-graphics/mesa/mesa-demos_8.5.0.bb
@@ -30,7 +30,7 @@ PACKAGECONFIG[gles1] = 
"-Dgles1=enabled,-Dgles1=disabled,virtual/libgles1"
 PACKAGECONFIG[gles2] = "-Dgles2=enabled,-Dgles2=disabled,virtual/libgles2"
 PACKAGECONFIG[glut] = "-Dwith-glut=${STAGING_EXECPREFIXDIR},,freeglut"
 PACKAGECONFIG[osmesa] = "-Dosmesa=enabled,-Dosmesa=disabled,"
-PACKAGECONFIG[wayland] = "-Dwayland=enabled,-Dwayland=disabled,virtual/libgl 
wayland wayland-native"
+PACKAGECONFIG[wayland] = "-Dwayland=enabled,-Dwayland=disabled,virtual/libgl 
wayland wayland-native wayland-protocols"
 PACKAGECONFIG[x11] = "-Dx11=enabled,-Dx11=disabled,virtual/libx11 libglu"
 
 do_install:append() {
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#177973): 
https://lists.openembedded.org/g/openembedded-core/message/177973
Mute This Topic: https://lists.openembedded.org/mt/97354089/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [oe-core][PATCHv5] graphene: add a PACKAGECONFIG for arm_neon

2023-02-13 Thread Carlos Alberto Lopez Perez

On 13/02/2023 19:03, Markus Volk wrote:
> Not all arm platforms support neon and runtime detection for this feature is
> currently not reliable.
> Disable neon support by default on ARM-32 platforms because of the
> following upstream bug: https://github.com/ebassi/graphene/issues/215
> 
> Enable neon for aarch64 by default
> 
> Signed-off-by: Markus Volk 
> ---
>  meta/recipes-graphics/graphene/graphene_1.10.8.bb | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-graphics/graphene/graphene_1.10.8.bb 
> b/meta/recipes-graphics/graphene/graphene_1.10.8.bb
> index 813ff74adf..199c460feb 100644
> --- a/meta/recipes-graphics/graphene/graphene_1.10.8.bb
> +++ b/meta/recipes-graphics/graphene/graphene_1.10.8.bb
> @@ -10,8 +10,10 @@ inherit gnomebase gobject-introspection gtk-doc
>  SRC_URI[archive.sha256sum] = 
> "a37bb0e78a419dcbeaa9c7027bcff52f5ec2367c25ec859da31dfde2928f279a"
>  
>  # gtk4 & mutter 41.0 requires graphene build with introspection
> -PACKAGECONFIG ?= "introspection"
> +PACKAGECONFIG ?= "introspection ${@bb.utils.contains('TUNE_FEATURES', 
> 'aarch64', 'neon', '', d)}"
> +
>  PACKAGECONFIG[introspection] = 
> "-Dintrospection=enabled,-Dintrospection=disabled,"
> +PACKAGECONFIG[neon] = "-Darm_neon=true,-Darm_neon=false,"
>  
>  GTKDOC_MESON_OPTION = "gtk_doc"
>  
> 
> 
> 
> 
> 

I think the comment with the link to the upstream bug and the reason for
disabling Neon support should be on the .bb file itself (and not only
the git log).

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#177115): 
https://lists.openembedded.org/g/openembedded-core/message/177115
Mute This Topic: https://lists.openembedded.org/mt/96941870/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [oe-core][PATCHv4] graphene: add a PACKAGECONFIG for arm_neon

2023-02-13 Thread Carlos Alberto Lopez Perez


On 13/02/2023 13:04, Markus Volk wrote:
> Not all arm platforms support neon and runtime detection for this feature is
> currently not reliable. Add a PACKAGECONFIG that disables neon support for arm
> but can be manually enabled.
> 
> Enable neon for aarch64 by default
> 
> Signed-off-by: Markus Volk 
> ---
>  meta/recipes-graphics/graphene/graphene_1.10.8.bb | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-graphics/graphene/graphene_1.10.8.bb 
> b/meta/recipes-graphics/graphene/graphene_1.10.8.bb
> index 813ff74adf..199c460feb 100644
> --- a/meta/recipes-graphics/graphene/graphene_1.10.8.bb
> +++ b/meta/recipes-graphics/graphene/graphene_1.10.8.bb
> @@ -10,8 +10,10 @@ inherit gnomebase gobject-introspection gtk-doc
>  SRC_URI[archive.sha256sum] = 
> "a37bb0e78a419dcbeaa9c7027bcff52f5ec2367c25ec859da31dfde2928f279a"
>  
>  # gtk4 & mutter 41.0 requires graphene build with introspection
> -PACKAGECONFIG ?= "introspection"
> +PACKAGECONFIG ?= "introspection ${@bb.utils.contains('TUNE_FEATURES', 
> 'aarch64', 'neon', '', d)}"
> +
>  PACKAGECONFIG[introspection] = 
> "-Dintrospection=enabled,-Dintrospection=disabled,"
> +PACKAGECONFIG[neon] = "-Darm_neon=true,-Darm_neon=false,"
>  
>  GTKDOC_MESON_OPTION = "gtk_doc"
>  
> 
> 

Can you please add a comment in the .bb file with a note saying that
Neon support gets disabled by default on ARM-32 platforms because of the
following upstream bug: https://github.com/ebassi/graphene/issues/215

?

That way anyone can known in the future why that was disabled for ARM-32
and check if the upstream issue got fixed in order to enable it back by
default.

There is a related discussion at:
https://github.com/Igalia/meta-webkit/pull/448

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#177103): 
https://lists.openembedded.org/g/openembedded-core/message/177103
Mute This Topic: https://lists.openembedded.org/mt/96933955/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH] mesa-gl: gallium is required when enabling x11

2022-12-27 Thread Carlos Alberto Lopez Perez

Otherwise Meson will fail wit this error:
  - meson.build:555:6: ERROR: Problem encountered: xlib based GLX requires at 
least one gallium driver

Related: https://github.com/agherzan/meta-raspberrypi/pull/1119
---
 meta/recipes-graphics/mesa/mesa-gl_22.2.3.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-graphics/mesa/mesa-gl_22.2.3.bb 
b/meta/recipes-graphics/mesa/mesa-gl_22.2.3.bb
index f2bc8f6b5b..c7c7aa7ac3 100644
--- a/meta/recipes-graphics/mesa/mesa-gl_22.2.3.bb
+++ b/meta/recipes-graphics/mesa/mesa-gl_22.2.3.bb
@@ -8,6 +8,6 @@ S = "${WORKDIR}/mesa-${PV}"
 
 # At least one DRI rendering engine is required to build mesa.
 # When no X11 is available, use osmesa for the rendering engine.
-PACKAGECONFIG ??= "opengl ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 
'x11', 'osmesa gallium', d)}"
-PACKAGECONFIG:class-target = "opengl ${@bb.utils.contains('DISTRO_FEATURES', 
'x11', 'x11', 'osmesa gallium', d)}"
+PACKAGECONFIG ??= "opengl gallium ${@bb.utils.contains('DISTRO_FEATURES', 
'x11', 'x11', 'osmesa', d)}"
+PACKAGECONFIG:class-target = "opengl gallium 
${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', 'osmesa', d)}"
 
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#175039): 
https://lists.openembedded.org/g/openembedded-core/message/175039
Mute This Topic: https://lists.openembedded.org/mt/95915958/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH v2] Enable nativesdk for gperf, unifdef, gi-docgen and its dependencies

2022-12-19 Thread Carlos Alberto Lopez Perez

I'm building a SDK (bitbake task: populate_sdk) for WPE/WebKit
development [1] and I need the tools below to be extended with the class
nativesdk. They work fine on the SDK after this change.

The needs are because:

1) gperf and unifdef are required by the WebKit build system at build
   time.

2) gi-docgen is required by the WebKit build system when CMake option
   'ENABLE_DOCUMENTATION' is enabled, and gi-docgen itself depends on
   the following python modules that also need to enable nativesdk:
   python3-markdown, python3-smartypants and python3-typogrify

[1]
See:
 - https://github.com/Igalia/meta-webkit/pull/436
 - https://bugs.webkit.org/show_bug.cgi?id=249604

Signed-off-by: Carlos Alberto Lopez Perez 
---
 meta/recipes-devtools/python/python3-markdown_3.4.1.bb| 2 +-
 meta/recipes-devtools/python/python3-smartypants_2.0.0.bb | 2 +-
 meta/recipes-devtools/python/python3-typogrify_2.0.7.bb   | 2 +-
 meta/recipes-devtools/ruby/ruby_3.1.3.bb  | 3 ++-
 meta/recipes-devtools/unifdef/unifdef_2.12.bb | 2 +-
 meta/recipes-extended/gperf/gperf_3.1.bb  | 2 +-
 meta/recipes-gnome/gi-docgen/gi-docgen_git.bb | 2 +-
 7 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/meta/recipes-devtools/python/python3-markdown_3.4.1.bb 
b/meta/recipes-devtools/python/python3-markdown_3.4.1.bb
index e99c3310ac..b398cd8bc4 100644
--- a/meta/recipes-devtools/python/python3-markdown_3.4.1.bb
+++ b/meta/recipes-devtools/python/python3-markdown_3.4.1.bb
@@ -8,6 +8,6 @@ inherit pypi python_setuptools_build_meta
 PYPI_PACKAGE = "Markdown"
 SRC_URI[sha256sum] = 
"3b809086bb6efad416156e00a0da66fe47618a5d6918dd688f53f40c8e4cfeff"
 
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
 
 RDEPENDS:${PN} += "${PYTHON_PN}-logging ${PYTHON_PN}-setuptools"
diff --git a/meta/recipes-devtools/python/python3-smartypants_2.0.0.bb 
b/meta/recipes-devtools/python/python3-smartypants_2.0.0.bb
index 05c94c390f..d089a89b95 100644
--- a/meta/recipes-devtools/python/python3-smartypants_2.0.0.bb
+++ b/meta/recipes-devtools/python/python3-smartypants_2.0.0.bb
@@ -9,6 +9,6 @@ PYPI_PACKAGE = "smartypants"
 SRC_URI += "file://0001-Change-hash-bang-to-python3.patch"
 SRC_URI[sha256sum] = 
"7812353a32022699a1aa8cd5626e01c94a946dcaeedaee2d0b382bae4c4cbf36"
 
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
 
 UPSTREAM_CHECK_REGEX = "/${PYPI_PACKAGE}/(?P(?!2\.0\.1)(\d+[\.\-_]*)+)/"
diff --git a/meta/recipes-devtools/python/python3-typogrify_2.0.7.bb 
b/meta/recipes-devtools/python/python3-typogrify_2.0.7.bb
index 83e9b5eadb..826f126ad9 100644
--- a/meta/recipes-devtools/python/python3-typogrify_2.0.7.bb
+++ b/meta/recipes-devtools/python/python3-typogrify_2.0.7.bb
@@ -8,7 +8,7 @@ inherit pypi setuptools3
 PYPI_PACKAGE = "typogrify"
 SRC_URI[sha256sum] = 
"8be4668cda434163ce229d87ca273a11922cb1614cb359970b7dc96eed13cb38"
 
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
 
 RDEPENDS:${PN} += "${PYTHON_PN}-smartypants"
 
diff --git a/meta/recipes-devtools/ruby/ruby_3.1.3.bb 
b/meta/recipes-devtools/ruby/ruby_3.1.3.bb
index c8454da3a9..85d6184a04 100644
--- a/meta/recipes-devtools/ruby/ruby_3.1.3.bb
+++ b/meta/recipes-devtools/ruby/ruby_3.1.3.bb
@@ -15,6 +15,7 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=5b8c87559868796979806100db3f3805 \
 
 DEPENDS = "zlib openssl libyaml gdbm readline libffi"
 DEPENDS:append:class-target = " ruby-native"
+DEPENDS:append:class-nativesdk = " ruby-native"
 
 SHRT_VER = "${@oe.utils.trim_version("${PV}", 2)}"
 SRC_URI = "http://cache.ruby-lang.org/pub/ruby/${SHRT_VER}/ruby-${PV}.tar.gz \
@@ -139,4 +140,4 @@ FILES:${PN}-ptest:append:class-target = "\
 ${libdir}/ruby/${SHRT_VER}.0/*/-test- \
 "
 
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
diff --git a/meta/recipes-devtools/unifdef/unifdef_2.12.bb 
b/meta/recipes-devtools/unifdef/unifdef_2.12.bb
index b42051b8b6..3e08b3a0a4 100644
--- a/meta/recipes-devtools/unifdef/unifdef_2.12.bb
+++ b/meta/recipes-devtools/unifdef/unifdef_2.12.bb
@@ -18,4 +18,4 @@ do_install() {
oe_runmake install DESTDIR=${D} prefix=${prefix}
 }
 
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
diff --git a/meta/recipes-extended/gperf/gperf_3.1.bb 
b/meta/recipes-extended/gperf/gperf_3.1.bb
index c9f09c7931..4c32a5dc83 100644
--- a/meta/recipes-extended/gperf/gperf_3.1.bb
+++ b/meta/recipes-extended/gperf/gperf_3.1.bb
@@ -17,4 +17,4 @@ inherit autotools
 # it where to look explicitly (mirroring the behaviour of upstream's 
Makefile.devel).
 EXTRA_AUTORECONF += " -I ${S} --exclude=aclocal"
 
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
diff --git a/me

[OE-core] [PATCH] xwayland: libxshmfence is needed when dri3 is enabled

2022-12-01 Thread Carlos Alberto Lopez Perez

* The build error happens already at configure time:

| meson.build: ERROR: Problem encountered: DRI3 requested, but xshmfence not 
found

Signed-off-by: Carlos Alberto Lopez Perez 
---
 meta/recipes-graphics/xwayland/xwayland_22.1.5.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/xwayland/xwayland_22.1.5.bb 
b/meta/recipes-graphics/xwayland/xwayland_22.1.5.bb
index c1c5407dee..51d847a093 100644
--- a/meta/recipes-graphics/xwayland/xwayland_22.1.5.bb
+++ b/meta/recipes-graphics/xwayland/xwayland_22.1.5.bb
@@ -23,7 +23,7 @@ OPENGL_PKGCONFIGS = "glx glamor dri3"
 PACKAGECONFIG ??= "${XORG_CRYPTO} \
${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 
'${OPENGL_PKGCONFIGS}', '', d)} \
 "
-PACKAGECONFIG[dri3] = "-Ddri3=true,-Ddri3=false"
+PACKAGECONFIG[dri3] = "-Ddri3=true,-Ddri3=false,libxshmfence"
 PACKAGECONFIG[glx] = "-Dglx=true,-Dglx=false,virtual/libgl virtual/libx11"
 PACKAGECONFIG[glamor] = "-Dglamor=true,-Dglamor=false,libepoxy 
virtual/libgbm,libegl"
 PACKAGECONFIG[unwind] = "-Dlibunwind=true,-Dlibunwind=false,libunwind"
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#174212): 
https://lists.openembedded.org/g/openembedded-core/message/174212
Mute This Topic: https://lists.openembedded.org/mt/95392840/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH] Enable nativesdk for gperf, gi-docgen, unifdef, ruby and 3 python recipes

2022-11-30 Thread Carlos Alberto Lopez Perez

I'm building a SDK (bitbake task: populate_sdk) for WPE/WebKit
development and I need the tools below to be extended with the class
nativesdk. They work fine on the SDK after this change.

Signed-off-by: Carlos Alberto Lopez Perez 
---
 meta/recipes-devtools/python/python3-markdown_3.4.1.bb| 2 +-
 meta/recipes-devtools/python/python3-smartypants_2.0.0.bb | 2 +-
 meta/recipes-devtools/python/python3-typogrify_2.0.7.bb   | 2 +-
 meta/recipes-devtools/ruby/ruby.inc   | 1 +
 meta/recipes-devtools/ruby/ruby_3.1.2.bb  | 2 +-
 meta/recipes-devtools/unifdef/unifdef_2.12.bb | 2 +-
 meta/recipes-extended/gperf/gperf_3.1.bb  | 2 +-
 meta/recipes-gnome/gi-docgen/gi-docgen_git.bb | 2 +-
 8 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/meta/recipes-devtools/python/python3-markdown_3.4.1.bb 
b/meta/recipes-devtools/python/python3-markdown_3.4.1.bb
index e99c3310ac..b398cd8bc4 100644
--- a/meta/recipes-devtools/python/python3-markdown_3.4.1.bb
+++ b/meta/recipes-devtools/python/python3-markdown_3.4.1.bb
@@ -8,6 +8,6 @@ inherit pypi python_setuptools_build_meta
 PYPI_PACKAGE = "Markdown"
 SRC_URI[sha256sum] = 
"3b809086bb6efad416156e00a0da66fe47618a5d6918dd688f53f40c8e4cfeff"
 
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
 
 RDEPENDS:${PN} += "${PYTHON_PN}-logging ${PYTHON_PN}-setuptools"
diff --git a/meta/recipes-devtools/python/python3-smartypants_2.0.0.bb 
b/meta/recipes-devtools/python/python3-smartypants_2.0.0.bb
index 05c94c390f..d089a89b95 100644
--- a/meta/recipes-devtools/python/python3-smartypants_2.0.0.bb
+++ b/meta/recipes-devtools/python/python3-smartypants_2.0.0.bb
@@ -9,6 +9,6 @@ PYPI_PACKAGE = "smartypants"
 SRC_URI += "file://0001-Change-hash-bang-to-python3.patch"
 SRC_URI[sha256sum] = 
"7812353a32022699a1aa8cd5626e01c94a946dcaeedaee2d0b382bae4c4cbf36"
 
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
 
 UPSTREAM_CHECK_REGEX = "/${PYPI_PACKAGE}/(?P(?!2\.0\.1)(\d+[\.\-_]*)+)/"
diff --git a/meta/recipes-devtools/python/python3-typogrify_2.0.7.bb 
b/meta/recipes-devtools/python/python3-typogrify_2.0.7.bb
index 83e9b5eadb..826f126ad9 100644
--- a/meta/recipes-devtools/python/python3-typogrify_2.0.7.bb
+++ b/meta/recipes-devtools/python/python3-typogrify_2.0.7.bb
@@ -8,7 +8,7 @@ inherit pypi setuptools3
 PYPI_PACKAGE = "typogrify"
 SRC_URI[sha256sum] = 
"8be4668cda434163ce229d87ca273a11922cb1614cb359970b7dc96eed13cb38"
 
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
 
 RDEPENDS:${PN} += "${PYTHON_PN}-smartypants"
 
diff --git a/meta/recipes-devtools/ruby/ruby.inc 
b/meta/recipes-devtools/ruby/ruby.inc
index ebff5efd1f..efa40331e0 100644
--- a/meta/recipes-devtools/ruby/ruby.inc
+++ b/meta/recipes-devtools/ruby/ruby.inc
@@ -15,6 +15,7 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=5b8c87559868796979806100db3f3805 \
 
 DEPENDS = "zlib openssl libyaml gdbm readline libffi"
 DEPENDS:append:class-target = " ruby-native"
+DEPENDS:append:class-nativesdk = " ruby-native"
 
 SHRT_VER = "${@oe.utils.trim_version("${PV}", 2)}"
 SRC_URI = "http://cache.ruby-lang.org/pub/ruby/${SHRT_VER}/ruby-${PV}.tar.gz \
diff --git a/meta/recipes-devtools/ruby/ruby_3.1.2.bb 
b/meta/recipes-devtools/ruby/ruby_3.1.2.bb
index 387bfa9b44..80b4c2cd8a 100644
--- a/meta/recipes-devtools/ruby/ruby_3.1.2.bb
+++ b/meta/recipes-devtools/ruby/ruby_3.1.2.bb
@@ -105,4 +105,4 @@ FILES:${PN}-ptest:append:class-target = "\
 ${libdir}/ruby/${SHRT_VER}.0/*/-test- \
 "
 
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
diff --git a/meta/recipes-devtools/unifdef/unifdef_2.12.bb 
b/meta/recipes-devtools/unifdef/unifdef_2.12.bb
index b42051b8b6..3e08b3a0a4 100644
--- a/meta/recipes-devtools/unifdef/unifdef_2.12.bb
+++ b/meta/recipes-devtools/unifdef/unifdef_2.12.bb
@@ -18,4 +18,4 @@ do_install() {
oe_runmake install DESTDIR=${D} prefix=${prefix}
 }
 
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
diff --git a/meta/recipes-extended/gperf/gperf_3.1.bb 
b/meta/recipes-extended/gperf/gperf_3.1.bb
index c9f09c7931..4c32a5dc83 100644
--- a/meta/recipes-extended/gperf/gperf_3.1.bb
+++ b/meta/recipes-extended/gperf/gperf_3.1.bb
@@ -17,4 +17,4 @@ inherit autotools
 # it where to look explicitly (mirroring the behaviour of upstream's 
Makefile.devel).
 EXTRA_AUTORECONF += " -I ${S} --exclude=aclocal"
 
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
diff --git a/meta/recipes-gnome/gi-docgen/gi-docgen_git.bb 
b/meta/recipes-gnome/gi-docgen/gi-docgen_git.bb
index 9e5adca3df..fa41f2ccd2 100644
--- a/meta/recipes-gnome/gi-docgen/gi-docgen_git.bb
+++ b/meta/recipes-gnome/gi-docgen/gi-docg

Re: [OE-core] [wpe-webkit] [PATCH 08/10] webkitgtk: unbreak wayland build

2020-02-27 Thread Carlos Alberto Lopez Perez

On 23/02/2020 15:33, Joshua Watt wrote:
> On Sun, Feb 16, 2020 at 2:52 PM Alexander Kanavin
>  wrote:
>>
>> On Sun, 16 Feb 2020 at 21:15, Khem Raj  wrote:
>>>
>>> On Sun, Feb 16, 2020 at 7:52 AM Alexander Kanavin
>>>  wrote:

 webkit nowadays requires a couple of supplementary libraries for this,
 so bring them in (courtesy of meta-browser, which will hopefully
 adjust without a lot of trouble).
>>>
>>> its not meta-browser, I guess you should credit meta-wpe here [1]
>>> and perhaps Cc the meta-wpe maintainer as a courtesy.
>>
>>
>> Actually, it's copied from meta-webkit
>> https://github.com/Igalia/meta-webkit/
>> which does not say in the readme who the maintainer is, so I am not sure 
>> whom to CC.
>> I can adjust the commit msg though.
> 
> I've CC'd the WPE mailing list.
> 
> OE-core now has libwpe and wpebackend-fdo recipes. They should
> possibly be removed from meta-webkit to prevent duplication.
> 

Thanks for the notification. Its great that those recipes are shipped
now on the oe-core layer.

But I don't want to remove those recipes from meta-webkit, even if they
are shipped now there.

That recipes are an essential part of meta-webkit, so I want to be able
to raise the version or change them without depending on oe-core.
For example: sometimes we need to use older versions of yocto, but we
still want to use the last stable version of wpe/libwpe/wpebackend-fdo.
So I find pretty useful to have all the core WPE related recipes on the
meta-webkit layer and not depend on whatever oe-core ships.

There should be no conflict between the recipes as long as the name used
for them its the same, bitbake should simply pick the last version by
default.

Regards.

signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] Sumo webkitgtk fails to compile

2018-06-27 Thread Carlos Alberto Lopez Perez

On 27/06/18 19:27, Michael Gloff wrote:
> # GL/GLES header clash: both define the same thing, differently, on 32 bit
> x86
> EXTRA_OECMAKE_append_x86 = " -DUSE_GSTREAMER_GL=OFF "
> EXTRA_OECMAKE_append_x86-x32 = " -DUSE_GSTREAMER_GL=OFF "
> 
> I think the best thing to do it to turn off USE_GSTREAMER_GL for all
> architectures. Would a patch doing so be acceptable? I've verified that it
> will build with the _armv5 case.

USE_GSTREAMER_GL is a feature of WebKitGTK+ that allows it to leverage
hardware-accelerated video decoding (for example: on i.MX6).

I think is acceptable to disable this for ARMv5 (because, AFAIK, there
isn't any ARMv5 hardware that can leverage this in any case), but this
should remain enabled for other architectures.

signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH v2] tune-i686: Add new tune for better support of 686-class CPUs.

2018-01-15 Thread Carlos Alberto Lopez Perez

There isn't currently any tune available for i686 x86 optimizations.
The tune for i586 doesn't enable i686 specific optimizations, and the
one for core2 enables things that won't work on a i686 CPU (like SSE3).

Make the tune for core2 inherits from this one and move there the
setting of X86ARCH32.

Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
---
 meta/conf/machine/include/tune-core2.inc |  7 ++-
 meta/conf/machine/include/tune-i686.inc  | 27 +++
 2 files changed, 29 insertions(+), 5 deletions(-)
 create mode 100644 meta/conf/machine/include/tune-i686.inc

diff --git a/meta/conf/machine/include/tune-core2.inc 
b/meta/conf/machine/include/tune-core2.inc
index f4ba43fbfd..6a03466650 100644
--- a/meta/conf/machine/include/tune-core2.inc
+++ b/meta/conf/machine/include/tune-core2.inc
@@ -8,11 +8,8 @@
 #
 DEFAULTTUNE ?= "core2-32"
 
-# Set x86 target arch to i686, so that glibc enables SSE optimised memcpy, etc.
-X86ARCH32 ?= "i686"
-
 # Include the previous tune to pull in PACKAGE_EXTRA_ARCHS
-require conf/machine/include/tune-i586.inc
+require conf/machine/include/tune-i686.inc
 
 # Extra tune features
 TUNEVALID[core2] = "Enable core2 specific processor optimizations"
@@ -23,7 +20,7 @@ AVAILTUNES += "core2-32"
 TUNE_FEATURES_tune-core2-32 = "${TUNE_FEATURES_tune-x86} core2"
 BASE_LIB_tune-core2-32 = "lib"
 TUNE_PKGARCH_tune-core2-32 = "core2-32"
-PACKAGE_EXTRA_ARCHS_tune-core2-32 = "${PACKAGE_EXTRA_ARCHS_tune-i586} core2-32"
+PACKAGE_EXTRA_ARCHS_tune-core2-32 = "${PACKAGE_EXTRA_ARCHS_tune-i686} core2-32"
 
 AVAILTUNES += "core2-64"
 TUNE_FEATURES_tune-core2-64 = "${TUNE_FEATURES_tune-x86-64} core2"
diff --git a/meta/conf/machine/include/tune-i686.inc 
b/meta/conf/machine/include/tune-i686.inc
new file mode 100644
index 00..bdb4799209
--- /dev/null
+++ b/meta/conf/machine/include/tune-i686.inc
@@ -0,0 +1,27 @@
+#
+# The i686 CPU family was introduced with the Intel Pentium Pro in 1995.
+# It has as required feature flags: fpu tsc cx8 cmov.
+#
+# It is the minimum CPU required by the Debian i386 port.
+# https://lists.debian.org/debian-devel-announce/2016/05/msg1.html
+#
+#
+
+DEFAULTTUNE ?= "i686"
+
+# Set x86 target arch to i686, so that glibc enables SSE optimised memcpy, etc.
+X86ARCH32 ?= "i686"
+
+# Include the previous tune to pull in PACKAGE_EXTRA_ARCHS
+require conf/machine/include/tune-i586.inc
+
+# Extra tune features
+TUNEVALID[i686] = "Enable i686 specific processor optimizations"
+TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'i686', ' -march=i686', 
'', d)}"
+
+# Extra tune selections
+AVAILTUNES += "i686"
+TUNE_FEATURES_tune-i686 = "${TUNE_FEATURES_tune-x86} i686"
+BASE_LIB_tune-i686 = "lib"
+TUNE_PKGARCH_tune-i686 = "i686"
+PACKAGE_EXTRA_ARCHS_tune-i686 = "${PACKAGE_EXTRA_ARCHS_tune-i586} i686"
-- 
2.11.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] tune-i686: Add new tune for better support of 686-class CPUs.

2018-01-11 Thread Carlos Alberto Lopez Perez

On 11/01/18 11:29, Richard Purdie wrote:
> On Thu, 2018-01-11 at 05:08 +0100, Carlos Alberto Lopez Perez wrote:
>> There isn't currently any tune available for i686 x86 optimizations.
>> The tune for i586 doesn't enable i686 specific optimizations, and the
>> one for core2 enables things that won't work on a i686 CPU (like
>> SSE3).
>>
>> This patch also changes the default tune for the qemux86 machine from
>> i586 to i686. This should cause no issue, as "runqemu qemux86"
>> already
>> defaults to run with "-cpu pentium2".
>>
>> The tune for core2 now inherits from this one, which allows to remove
>> the override on the X86ARCH32 definition.
>>
>> Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
>> ---
>>  meta/conf/machine/include/tune-core2.inc |  7 ++-
>>  meta/conf/machine/include/tune-i686.inc  | 25
>> +
>>  meta/conf/machine/qemux86.conf   |  2 +-
>>  3 files changed, 28 insertions(+), 6 deletions(-)
>>  create mode 100644 meta/conf/machine/include/tune-i686.inc
> 
> Please don't do multiple things in a single commit like this.
> 
> The qemux86 default tune change isn't as simple as it might first
> appear as it changes the output artefacts which may or may not mean
> changes to the testing infrastructure (I'd hope not but I also know the
> reality).
> 
> Adding the tune itself should be more straightforward.
> > We do need to keep track of the comment "Set x86 target arch to i686,
> so that glibc enables SSE optimised memcpy, etc." as i586 verses i686
> does make a significant difference to the glibc config.
> 

Sure, I will keep track of the comment. I'll follow-up with a new patch.

Due to this significant difference in performance for glibc, it seems to
me it is worth to try the change on the default tune on qemux68 machine.
Hopefully it will speed-up a bit the testing times both on the testing
architecture and the developer machines.
Will splitting the patch in two will help with this?



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] tune-i686: Add new tune for better support of 686-class CPUs.

2018-01-10 Thread Carlos Alberto Lopez Perez

There isn't currently any tune available for i686 x86 optimizations.
The tune for i586 doesn't enable i686 specific optimizations, and the
one for core2 enables things that won't work on a i686 CPU (like SSE3).

This patch also changes the default tune for the qemux86 machine from
i586 to i686. This should cause no issue, as "runqemu qemux86" already
defaults to run with "-cpu pentium2".

The tune for core2 now inherits from this one, which allows to remove
the override on the X86ARCH32 definition.

Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
---
 meta/conf/machine/include/tune-core2.inc |  7 ++-
 meta/conf/machine/include/tune-i686.inc  | 25 +
 meta/conf/machine/qemux86.conf   |  2 +-
 3 files changed, 28 insertions(+), 6 deletions(-)
 create mode 100644 meta/conf/machine/include/tune-i686.inc

diff --git a/meta/conf/machine/include/tune-core2.inc 
b/meta/conf/machine/include/tune-core2.inc
index f4ba43fbfd..6a03466650 100644
--- a/meta/conf/machine/include/tune-core2.inc
+++ b/meta/conf/machine/include/tune-core2.inc
@@ -8,11 +8,8 @@
 #
 DEFAULTTUNE ?= "core2-32"
 
-# Set x86 target arch to i686, so that glibc enables SSE optimised memcpy, etc.
-X86ARCH32 ?= "i686"
-
 # Include the previous tune to pull in PACKAGE_EXTRA_ARCHS
-require conf/machine/include/tune-i586.inc
+require conf/machine/include/tune-i686.inc
 
 # Extra tune features
 TUNEVALID[core2] = "Enable core2 specific processor optimizations"
@@ -23,7 +20,7 @@ AVAILTUNES += "core2-32"
 TUNE_FEATURES_tune-core2-32 = "${TUNE_FEATURES_tune-x86} core2"
 BASE_LIB_tune-core2-32 = "lib"
 TUNE_PKGARCH_tune-core2-32 = "core2-32"
-PACKAGE_EXTRA_ARCHS_tune-core2-32 = "${PACKAGE_EXTRA_ARCHS_tune-i586} core2-32"
+PACKAGE_EXTRA_ARCHS_tune-core2-32 = "${PACKAGE_EXTRA_ARCHS_tune-i686} core2-32"
 
 AVAILTUNES += "core2-64"
 TUNE_FEATURES_tune-core2-64 = "${TUNE_FEATURES_tune-x86-64} core2"
diff --git a/meta/conf/machine/include/tune-i686.inc 
b/meta/conf/machine/include/tune-i686.inc
new file mode 100644
index 00..c2bb534874
--- /dev/null
+++ b/meta/conf/machine/include/tune-i686.inc
@@ -0,0 +1,25 @@
+#
+# The i686 CPU family was introduced with the Intel Pentium Pro in 1995.
+# It has as required feature flags: fpu tsc cx8 cmov.
+#
+# It is the minimum CPU required by the Debian i386 port.
+# https://lists.debian.org/debian-devel-announce/2016/05/msg1.html
+#
+#
+
+DEFAULTTUNE ?= "i686"
+X86ARCH32 ?= "i686"
+
+# Include the previous tune to pull in PACKAGE_EXTRA_ARCHS
+require conf/machine/include/tune-i586.inc
+
+# Extra tune features
+TUNEVALID[i686] = "Enable i686 specific processor optimizations"
+TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'i686', ' -march=i686', 
'', d)}"
+
+# Extra tune selections
+AVAILTUNES += "i686"
+TUNE_FEATURES_tune-i686 = "${TUNE_FEATURES_tune-x86} i686"
+BASE_LIB_tune-i686 = "lib"
+TUNE_PKGARCH_tune-i686 = "i686"
+PACKAGE_EXTRA_ARCHS_tune-i686 = "${PACKAGE_EXTRA_ARCHS_tune-i586} i686"
diff --git a/meta/conf/machine/qemux86.conf b/meta/conf/machine/qemux86.conf
index c53f7a92ce..f01cbeeb35 100644
--- a/meta/conf/machine/qemux86.conf
+++ b/meta/conf/machine/qemux86.conf
@@ -8,7 +8,7 @@ PREFERRED_PROVIDER_virtual/libgles1 ?= "mesa"
 PREFERRED_PROVIDER_virtual/libgles2 ?= "mesa"
 
 require conf/machine/include/qemu.inc
-require conf/machine/include/tune-i586.inc
+require conf/machine/include/tune-i686.inc
 require conf/machine/include/qemuboot-x86.inc
 
 KERNEL_IMAGETYPE = "bzImage"
-- 
2.11.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [oe] Use of github /archive/ tarballs in SRC_URI

2017-09-19 Thread Carlos Alberto Lopez Perez

On 19/09/17 10:09, Burton, Ross wrote:
> Then the tarball for one of Erlang's repositories changed, and was noticed
> by the checksum in the recipe (thanks Gunnar Andersson for reporting
> this).  The extracted contents are identical, but the tarball itself has
> changed.  I'm presuming this is due to the old tarball expiring in their
> cache, and a newly generated tarball using a later version of tar.

I don't think tar is the one to blame, but gzip.
I have just tested GNU tar (versions 1.29 and 1.26) and BSD tar (from
OpenBSD 5.8) and the 3 have produced identical archives (same md5sum)
when invoked like git archive does.

However, the .tar.gz file generated was different in the case of BSD.
It even had a different file size.

I bet that if you uncompress both files, the .tar will have the same
checksum in both cases.

I guess that a different version (or implementation) of gzip, or even
different local settings like forcing a more or less aggressive
compression can be the explanation here.

Maybe an idea is that OE could gain a feature to optionally do a
checksum of the .tar file once uncompressed that could be used as a
fallback second check if the first one fails?
If the first one fails but the second one passes a non-fatal WARN could
be issued.

signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] initramfs-live-boot: disable systemd-update-done.service on live images

2017-08-31 Thread Carlos Alberto Lopez Perez

On 31/08/17 19:26, Otavio Salvador wrote:
> On Thu, Aug 31, 2017 at 9:23 AM, Carlos Alberto Lopez Perez
> <clo...@igalia.com> wrote:
>> When systemd is used, it will invoke a service on first boot that triggers
>> a rebuild of ldconfig caches (rebuild dynamic linker cache).
>>
>> This is fine on the first boot of a system that has been installed, but it
>> makes no sense on a live system. The worst part is that rebuilding this
>> caches is slow and it causes the live system to take longer to boot.
>> (I measured this in 30 seconds longer on a standard PC system booting
>> core-image-sato live from an USB memory).
>>
>> Disable this by touching /etc/.updated and /var/.updated on the live 
>> initramfs.
>>
>> For more details see https://bugzilla.redhat.com/show_bug.cgi?id=1201725 and
>> https://www.freedesktop.org/software/systemd/man/systemd-update-done.service.html
>>
>> Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
> 
> This should be done to the live boot module of initramfs-framework as well.
> 
> 

I'm not really familiar with the modules there.

What is the use case of doing this there as well?
live systems without an initramfs? is that possible?

Where should this exactly be done there?
I don't see the boot_live_root() equivalent.



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] initramfs-live-boot: disable systemd-update-done.service on live images

2017-08-31 Thread Carlos Alberto Lopez Perez

On 31/08/17 17:48, Burton, Ross wrote:
> On 31 August 2017 at 16:38, Carlos Alberto Lopez Perez <clo...@igalia.com>
> wrote:
> 
>> On 31/08/17 15:46, Burton, Ross wrote:
>>> Presumably/hopefully systemd isn't hardcoding /etc and /var but
>> respecting
>>> sysconfdir and localstatedir, so the touch should also use those
>> variables
>>> (by sedding the script).
>>
>> https://github.com/systemd/systemd/blob/master/units/
>> systemd-update-done.service.in#L15
>> https://github.com/systemd/systemd/blob/master/src/
>> update-done/update-done.c#L72
>>
>> // losing the hope
> 
> 
> Sigh.
> 
> If you promise to file a bug against systemd moaning about that, I'll queue
> your patch. ;)
> 

Better done than promised! :)
https://github.com/systemd/systemd/issues/6716

Best regards.



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] initramfs-live-boot: disable systemd-update-done.service on live images

2017-08-31 Thread Carlos Alberto Lopez Perez

On 31/08/17 15:46, Burton, Ross wrote:
> Presumably/hopefully systemd isn't hardcoding /etc and /var but respecting
> sysconfdir and localstatedir, so the touch should also use those variables
> (by sedding the script).

https://github.com/systemd/systemd/blob/master/units/systemd-update-done.service.in#L15
https://github.com/systemd/systemd/blob/master/src/update-done/update-done.c#L72

// losing the hope



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] initramfs-live-boot: disable systemd-update-done.service on live images

2017-08-31 Thread Carlos Alberto Lopez Perez

When systemd is used, it will invoke a service on first boot that triggers
a rebuild of ldconfig caches (rebuild dynamic linker cache).

This is fine on the first boot of a system that has been installed, but it
makes no sense on a live system. The worst part is that rebuilding this
caches is slow and it causes the live system to take longer to boot.
(I measured this in 30 seconds longer on a standard PC system booting
core-image-sato live from an USB memory).

Disable this by touching /etc/.updated and /var/.updated on the live initramfs.

For more details see https://bugzilla.redhat.com/show_bug.cgi?id=1201725 and
https://www.freedesktop.org/software/systemd/man/systemd-update-done.service.html

Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
---
 meta/recipes-core/initrdscripts/files/init-live.sh | 4 
 1 file changed, 4 insertions(+)

diff --git a/meta/recipes-core/initrdscripts/files/init-live.sh 
b/meta/recipes-core/initrdscripts/files/init-live.sh
index 441b41c9d6..46cab6cc77 100644
--- a/meta/recipes-core/initrdscripts/files/init-live.sh
+++ b/meta/recipes-core/initrdscripts/files/init-live.sh
@@ -84,6 +84,10 @@ boot_live_root() {
 # device node creation events were handled, to avoid unexpected behavior
 killall -9 "${_UDEV_DAEMON##*/}" 2>/dev/null
 
+# Don't run systemd-update-done on systemd-based live systems
+# because it triggers a slow rebuild of ldconfig caches.
+touch ${ROOT_MOUNT}/etc/.updated ${ROOT_MOUNT}/var/.updated
+
 # Allow for identification of the real root even after boot
 mkdir -p  ${ROOT_MOUNT}/media/realroot
 mount -n --move "/run/media/${ROOT_DISK}" ${ROOT_MOUNT}/media/realroot
-- 
2.11.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] systemd: don't symlink /etc/resolv.conf if resolved is disabled

2017-08-24 Thread Carlos Alberto Lopez Perez

On 22/08/17 02:43, Carlos Alberto Lopez Perez wrote:
> On 21/08/17 21:05, Carlos Alberto Lopez Perez wrote:
>>  * symlinking /etc/resolv.conf to /run/systemd/resolve/resolv.conf
>>when resolved is not enabled is wrong, as this prevents network
>>manager from handling the resolv.conf file itself and breaking
>>DNS resolution.
>>
>>See: NetworkManager.conf manpage or https://git.io/v5UJQ
>>
>> Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
>> ---
>>  meta/recipes-core/systemd/systemd_234.bb | 7 +--
>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/meta/recipes-core/systemd/systemd_234.bb 
>> b/meta/recipes-core/systemd/systemd_234.bb
>> index 4560cf4175..dddad62941 100644
>> --- a/meta/recipes-core/systemd/systemd_234.bb
>> +++ b/meta/recipes-core/systemd/systemd_234.bb
>> @@ -235,12 +235,7 @@ do_install() {
>>  if [ -s ${D}${exec_prefix}/lib/tmpfiles.d/systemd.conf ]; then
>>  ${@bb.utils.contains('PACKAGECONFIG', 'networkd', ':', 'sed -i 
>> -e "\$ad /run/systemd/netif/links 0755 root root -" 
>> ${D}${exec_prefix}/lib/tmpfiles.d/systemd.conf', d)}
>>  fi
>> -if ! ${@bb.utils.contains('PACKAGECONFIG', 'resolved', 'true', 'false', 
>> d)}; then
>> -echo 'L! ${sysconfdir}/resolv.conf - - - - 
>> ../run/systemd/resolve/resolv.conf' 
>> >>${D}${exec_prefix}/lib/tmpfiles.d/etc.conf
>> -echo 'd /run/systemd/resolve 0755 root root -' 
>> >>${D}${exec_prefix}/lib/tmpfiles.d/systemd.conf
>> -echo 'f /run/systemd/resolve/resolv.conf 0644 root root' 
>> >>${D}${exec_prefix}/lib/tmpfiles.d/systemd.conf
>> -ln -s ../run/systemd/resolve/resolv.conf 
>> ${D}${sysconfdir}/resolv-conf.systemd
>> -else
>> +if ${@bb.utils.contains('PACKAGECONFIG', 'resolved', 'true', 'false', 
>> d)}; then
>>  sed -i -e "s%^L! /etc/resolv.conf.*$%L! /etc/resolv.conf - - - 
>> - ../run/systemd/resolve/resolv.conf%g" 
>> ${D}${exec_prefix}/lib/tmpfiles.d/etc.conf
>>  ln -s ../run/systemd/resolve/resolv.conf 
>> ${D}${sysconfdir}/resolv-conf.systemd
>>  fi
>>
> 
> Looking at the previous history it seems symlinking /etc/resolv.conf
> when not enabling resolved was done originally to allow updating
> resolv.conf on read-only-rootfs filesystems ( commit 7f087f161e ).
> 
> So the above patch is not right, as it will break that.
> 
> An idea is to symlink /etc/resolv.conf to a different filename in /run
> when resolved is not enabled.
> 
> 
> 

FTR; I reported this issue at:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=11969



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] systemd: don't symlink /etc/resolv.conf if resolved is disabled

2017-08-21 Thread Carlos Alberto Lopez Perez

On 21/08/17 21:05, Carlos Alberto Lopez Perez wrote:
>  * symlinking /etc/resolv.conf to /run/systemd/resolve/resolv.conf
>when resolved is not enabled is wrong, as this prevents network
>manager from handling the resolv.conf file itself and breaking
>DNS resolution.
> 
>See: NetworkManager.conf manpage or https://git.io/v5UJQ
> 
> Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
> ---
>  meta/recipes-core/systemd/systemd_234.bb | 7 +--
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/meta/recipes-core/systemd/systemd_234.bb 
> b/meta/recipes-core/systemd/systemd_234.bb
> index 4560cf4175..dddad62941 100644
> --- a/meta/recipes-core/systemd/systemd_234.bb
> +++ b/meta/recipes-core/systemd/systemd_234.bb
> @@ -235,12 +235,7 @@ do_install() {
>   if [ -s ${D}${exec_prefix}/lib/tmpfiles.d/systemd.conf ]; then
>   ${@bb.utils.contains('PACKAGECONFIG', 'networkd', ':', 'sed -i 
> -e "\$ad /run/systemd/netif/links 0755 root root -" 
> ${D}${exec_prefix}/lib/tmpfiles.d/systemd.conf', d)}
>   fi
> - if ! ${@bb.utils.contains('PACKAGECONFIG', 'resolved', 'true', 'false', 
> d)}; then
> - echo 'L! ${sysconfdir}/resolv.conf - - - - 
> ../run/systemd/resolve/resolv.conf' 
> >>${D}${exec_prefix}/lib/tmpfiles.d/etc.conf
> - echo 'd /run/systemd/resolve 0755 root root -' 
> >>${D}${exec_prefix}/lib/tmpfiles.d/systemd.conf
> - echo 'f /run/systemd/resolve/resolv.conf 0644 root root' 
> >>${D}${exec_prefix}/lib/tmpfiles.d/systemd.conf
> - ln -s ../run/systemd/resolve/resolv.conf 
> ${D}${sysconfdir}/resolv-conf.systemd
> - else
> + if ${@bb.utils.contains('PACKAGECONFIG', 'resolved', 'true', 'false', 
> d)}; then
>   sed -i -e "s%^L! /etc/resolv.conf.*$%L! /etc/resolv.conf - - - 
> - ../run/systemd/resolve/resolv.conf%g" 
> ${D}${exec_prefix}/lib/tmpfiles.d/etc.conf
>   ln -s ../run/systemd/resolve/resolv.conf 
> ${D}${sysconfdir}/resolv-conf.systemd
>   fi
> 

Looking at the previous history it seems symlinking /etc/resolv.conf
when not enabling resolved was done originally to allow updating
resolv.conf on read-only-rootfs filesystems ( commit 7f087f161e ).

So the above patch is not right, as it will break that.

An idea is to symlink /etc/resolv.conf to a different filename in /run
when resolved is not enabled.



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] systemd: don't symlink /etc/resolv.conf if resolved is disabled

2017-08-21 Thread Carlos Alberto Lopez Perez

 * symlinking /etc/resolv.conf to /run/systemd/resolve/resolv.conf
   when resolved is not enabled is wrong, as this prevents network
   manager from handling the resolv.conf file itself and breaking
   DNS resolution.

   See: NetworkManager.conf manpage or https://git.io/v5UJQ

Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
---
 meta/recipes-core/systemd/systemd_234.bb | 7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/meta/recipes-core/systemd/systemd_234.bb 
b/meta/recipes-core/systemd/systemd_234.bb
index 4560cf4175..dddad62941 100644
--- a/meta/recipes-core/systemd/systemd_234.bb
+++ b/meta/recipes-core/systemd/systemd_234.bb
@@ -235,12 +235,7 @@ do_install() {
if [ -s ${D}${exec_prefix}/lib/tmpfiles.d/systemd.conf ]; then
${@bb.utils.contains('PACKAGECONFIG', 'networkd', ':', 'sed -i 
-e "\$ad /run/systemd/netif/links 0755 root root -" 
${D}${exec_prefix}/lib/tmpfiles.d/systemd.conf', d)}
fi
-   if ! ${@bb.utils.contains('PACKAGECONFIG', 'resolved', 'true', 'false', 
d)}; then
-   echo 'L! ${sysconfdir}/resolv.conf - - - - 
../run/systemd/resolve/resolv.conf' >>${D}${exec_prefix}/lib/tmpfiles.d/etc.conf
-   echo 'd /run/systemd/resolve 0755 root root -' 
>>${D}${exec_prefix}/lib/tmpfiles.d/systemd.conf
-   echo 'f /run/systemd/resolve/resolv.conf 0644 root root' 
>>${D}${exec_prefix}/lib/tmpfiles.d/systemd.conf
-   ln -s ../run/systemd/resolve/resolv.conf 
${D}${sysconfdir}/resolv-conf.systemd
-   else
+   if ${@bb.utils.contains('PACKAGECONFIG', 'resolved', 'true', 'false', 
d)}; then
sed -i -e "s%^L! /etc/resolv.conf.*$%L! /etc/resolv.conf - - - 
- ../run/systemd/resolve/resolv.conf%g" 
${D}${exec_prefix}/lib/tmpfiles.d/etc.conf
ln -s ../run/systemd/resolve/resolv.conf 
${D}${sysconfdir}/resolv-conf.systemd
fi
-- 
2.11.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] webkitgtk: Add a recommends on shared-mime-info.

2017-08-18 Thread Carlos Alberto Lopez Perez

On 18/08/17 08:38, Jussi Kukkonen wrote:
> There's also https://bugzilla.yoctoproject.org/show_bug.cgi?id=11792 about
> whether glib should bring in shared-mime-info so GIO file sniffing wouldn't
> be broken (the database is 3.6MB which is not a big number in a webkit
> context but can be for others).

This looks to me the best option.






signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] webkitgtk: Add a recommends on shared-mime-info.

2017-08-17 Thread Carlos Alberto Lopez Perez

 * without this package installed any WebKitGTK+ based browser
   will fail to correctly open html files (and other files)
   from disk (file:// URIs). It will open them as plain txt files.

Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.16.6.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.16.6.bb 
b/meta/recipes-sato/webkit/webkitgtk_2.16.6.bb
index 387965970e..df355d29ba 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.16.6.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.16.6.bb
@@ -98,7 +98,7 @@ SECURITY_CFLAGS_append_aarch64 = " -fPIE"
 
 FILES_${PN} += 
"${libdir}/webkit2gtk-4.0/injected-bundle/libwebkit2gtkinjectedbundle.so"
 
-RRECOMMENDS_${PN} += "ca-certificates"
+RRECOMMENDS_${PN} += "ca-certificates shared-mime-info"
 
 # http://errors.yoctoproject.org/Errors/Details/20370/
 ARM_INSTRUCTION_SET_armv4 = "arm"
-- 
2.11.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] webkitgtk: Upgrade to 2.16.5

2017-07-13 Thread Carlos Alberto Lopez Perez

Adjust some dependencies: libgcrypt is now required (instead of gnutls)
and the following build deps where missing: gettext-native, glib-2.0
and glib-2.0-native.

Also the CMake argument ENABLE_CREDENTIAL_STORAGE has been renamed to
USE_LIBSECRET.

This new upstream release (2.16.4 actually) includes security fixes for
CVE: CVE-2017-2538

Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
---
 .../webkit/{webkitgtk_2.16.3.bb => webkitgtk_2.16.5.bb}| 10 ++
 1 file changed, 6 insertions(+), 4 deletions(-)
 rename meta/recipes-sato/webkit/{webkitgtk_2.16.3.bb => webkitgtk_2.16.5.bb} 
(94%)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.16.3.bb 
b/meta/recipes-sato/webkit/webkitgtk_2.16.5.bb
similarity index 94%
rename from meta/recipes-sato/webkit/webkitgtk_2.16.3.bb
rename to meta/recipes-sato/webkit/webkitgtk_2.16.5.bb
index 5feca17be3..dcaf8a6ed7 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.16.3.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.16.5.bb
@@ -22,19 +22,21 @@ SRC_URI = 
"http://www.webkitgtk.org/releases/${BPN}-${PV}.tar.xz \
file://gcc7.patch \
file://detect-atomics-during-configure.patch \
"
-SRC_URI[md5sum] = "34dbbcad8a87a929519d93c67edd6d87"
-SRC_URI[sha256sum] = 
"204e9131da0101b9bc8765716e70a897121af04b964d9827cd9f20816a77b512"
+
+SRC_URI[md5sum] = "fce72dc89cd310a663d9eb97133861fe"
+SRC_URI[sha256sum] = 
"8e0396f3428e757898c5856e642eed4fcd5a20ae03d96d3eaa03b76634be7dd4"
 
 inherit cmake pkgconfig gobject-introspection perlnative distro_features_check 
upstream-version-is-even gtk-doc
 
 # depends on libxt
 REQUIRED_DISTRO_FEATURES = "x11"
 
-DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn gnutls \
+DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native 
gperf-native sqlite3 \
   pango icu bison-native gawk intltool-native libwebp \
   atk udev harfbuzz jpeg libpng pulseaudio librsvg libtheora libvorbis 
libxcomposite libxtst \
   ruby-native libnotify gstreamer1.0-plugins-bad \
+  gettext-native glib-2.0 glib-2.0-native \
   "
 
 PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', 
'wayland' ,d)} \
@@ -51,7 +53,7 @@ PACKAGECONFIG[gtk2] = 
"-DENABLE_PLUGIN_PROCESS_GTK2=ON,-DENABLE_PLUGIN_PROCESS_G
 PACKAGECONFIG[gles2] = "-DENABLE_GLES2=ON,-DENABLE_GLES2=OFF,virtual/libgles2"
 PACKAGECONFIG[webgl] = "-DENABLE_WEBGL=ON,-DENABLE_WEBGL=OFF,virtual/libgl"
 PACKAGECONFIG[opengl] = "-DENABLE_OPENGL=ON,-DENABLE_OPENGL=OFF,virtual/libgl"
-PACKAGECONFIG[libsecret] = 
"-DENABLE_CREDENTIAL_STORAGE=ON,-DENABLE_CREDENTIAL_STORAGE=OFF,libsecret"
+PACKAGECONFIG[libsecret] = "-DUSE_LIBSECRET=ON,-DUSE_LIBSECRET=OFF,libsecret"
 PACKAGECONFIG[libhyphen] = "-DUSE_LIBHYPHEN=ON,-DUSE_LIBHYPHEN=OFF,libhyphen"
 
 EXTRA_OECMAKE = " \
-- 
2.11.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] Revert "webkitgtk: drop patch 0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch"

2016-12-07 Thread Carlos Alberto Lopez Perez

This reverts commit 812c52f654c1bccca033163100055e3a8b8cda6e.

Upstream fixed the issue with GCC. But the build still fails with Clang.
Therefore reintroduce this patch until a better solution is found.
Upstream bug: https://bugs.webkit.org/show_bug.cgi?id=161697

Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
---
 ...bKitMacros-Append-to-I-and-not-to-isystem.patch | 185 +
 meta/recipes-sato/webkit/webkitgtk_2.14.2.bb   |   1 +
 2 files changed, 186 insertions(+)
 create mode 100644 
meta/recipes-sato/webkit/files/0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch

diff --git 
a/meta/recipes-sato/webkit/files/0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch
 
b/meta/recipes-sato/webkit/files/0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch
new file mode 100644
index 000..a4face2
--- /dev/null
+++ 
b/meta/recipes-sato/webkit/files/0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch
@@ -0,0 +1,185 @@
+From 20ee11dd188e1538f8cdd17a289dc6f9c63a011e Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.k...@gmail.com>
+Date: Sun, 17 Apr 2016 12:35:41 -0700
+Subject: [PATCH] WebKitMacros: Append to -I and not to -isystem
+
+gcc-6 has now introduced stdlib.h in libstdc++ for better
+compliance and its including the C library stdlib.h using
+include_next which is sensitive to order of system header
+include paths. Its infact better to not tinker with the
+system header include paths at all. Since adding /usr/include
+to -system is redundant and compiler knows about it moreover
+now with gcc6 it interferes with compiler's functioning
+and ends up with compile errors e.g.
+
+/usr/include/c++/6.0.0/cstdlib:75:25: fatal error: stdlib.h: No such file or 
directory
+
+This is also an issue with clang (when using libstdc++ >= 6)
+
+Upstream bug: https://bugs.webkit.org/show_bug.cgi?id=161697
+
+Signed-off-by: Khem Raj <raj.k...@gmail.com>
+Upstream-Status: Pending
+---
+ Source/JavaScriptCore/shell/CMakeLists.txt | 2 +-
+ Source/WebCore/PlatformGTK.cmake   | 6 +++---
+ Source/WebKit2/PlatformGTK.cmake   | 2 +-
+ Source/cmake/WebKitMacros.cmake| 2 +-
+ Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt | 2 +-
+ Tools/ImageDiff/CMakeLists.txt | 2 +-
+ Tools/MiniBrowser/gtk/CMakeLists.txt   | 2 +-
+ Tools/TestWebKitAPI/PlatformGTK.cmake  | 2 +-
+ Tools/TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt| 2 +-
+ Tools/WebKitTestRunner/CMakeLists.txt  | 2 +-
+ 10 files changed, 12 insertions(+), 12 deletions(-)
+
+diff --git a/Source/JavaScriptCore/shell/CMakeLists.txt 
b/Source/JavaScriptCore/shell/CMakeLists.txt
+index 155c797..80fe22b 100644
+--- a/Source/JavaScriptCore/shell/CMakeLists.txt
 b/Source/JavaScriptCore/shell/CMakeLists.txt
+@@ -20,7 +20,7 @@ WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()
+ 
+ WEBKIT_WRAP_SOURCELIST(${JSC_SOURCES})
+ include_directories(./ ${JavaScriptCore_INCLUDE_DIRECTORIES})
+-include_directories(SYSTEM ${JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES})
++include_directories(${JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES})
+ add_executable(jsc ${JSC_SOURCES})
+ target_link_libraries(jsc ${JSC_LIBRARIES})
+ 
+diff --git a/Source/WebCore/PlatformGTK.cmake 
b/Source/WebCore/PlatformGTK.cmake
+index 567bd79..1fabea8 100644
+--- a/Source/WebCore/PlatformGTK.cmake
 b/Source/WebCore/PlatformGTK.cmake
+@@ -340,7 +340,7 @@ if (ENABLE_PLUGIN_PROCESS_GTK2)
+ ${GTK2_INCLUDE_DIRS}
+ ${GDK2_INCLUDE_DIRS}
+ )
+-target_include_directories(WebCorePlatformGTK2 SYSTEM PRIVATE
++target_include_directories(WebCorePlatformGTK2 PRIVATE
+ ${WebCore_SYSTEM_INCLUDE_DIRECTORIES}
+ )
+ target_link_libraries(WebCorePlatformGTK2
+@@ -365,7 +365,7 @@ WEBKIT_SET_EXTRA_COMPILER_FLAGS(WebCorePlatformGTK)
+ target_include_directories(WebCorePlatformGTK PRIVATE
+ ${WebCore_INCLUDE_DIRECTORIES}
+ )
+-target_include_directories(WebCorePlatformGTK SYSTEM PRIVATE
++target_include_directories(WebCorePlatformGTK PRIVATE
+ ${WebCore_SYSTEM_INCLUDE_DIRECTORIES}
+ ${GTK_INCLUDE_DIRS}
+ ${GDK_INCLUDE_DIRS}
+@@ -383,7 +383,7 @@ include_directories(
+ "${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}"
+ )
+ 
+-include_directories(SYSTEM
++include_directories(
+ ${WebCore_SYSTEM_INCLUDE_DIRECTORIES}
+ )
+ 
+diff --git a/Source/WebKit2/PlatformGTK.cmake 
b/Source/WebKit2/PlatformGTK.cmake
+index e4805a4..c57df5d 100644
+--- a/Source/WebKit2/PlatformGTK.cmake
 b/Source/WebKit2/PlatformGTK.cmake
+@@ -822,7 +822,7 @@ if (ENABLE_PLUGIN_PROCESS_GTK2)
+ target_include_directories(WebKitPluginProcess2 PRIVATE
+ ${WebKit2CommonIncludeDirectories}
+ )
+-target_include_directories(WebKitPluginProcess2 SYSTEM PRIVATE
++target_include_directories(WebKitPluginProcess2 PRIVATE
+  ${WebKit2CommonSystemIncludeDirectories}

Re: [OE-core] [oe-core][PATCH] webkitgtk: drop patch 0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch

2016-12-07 Thread Carlos Alberto Lopez Perez

On 05/12/16 23:56, Khem Raj wrote:
> Carlos
> 
> webkitgtk fails now e.g. see
> 
> http://errors.yoctoproject.org/Errors/Details/111221/ 
> 
> 
> fatal error: 'stdlib.h' file not found
> #include_next 
> 
> This is when building with clang, I think its too early to drop this patch. 

Hi,

I thought this was an issue only with GCC ...

Some questions:
 * Which version of clang is used ?
 * The clang toolchain used is the one from the
https://github.com/kraj/meta-clang layer ?

I don't have a fix for it at this moment, and investigating it would
require time. So I think is fine to reintroduce the patch
0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch (If possible,
please change the commit message on the patch to tell that this an issue
now only when building with clang).

Thanks

signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] webkitgtk: update to 2.14.2

2016-11-23 Thread Carlos Alberto Lopez Perez

Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
---
 meta/recipes-sato/webkit/{webkitgtk_2.14.1.bb => webkitgtk_2.14.2.bb} | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
 rename meta/recipes-sato/webkit/{webkitgtk_2.14.1.bb => webkitgtk_2.14.2.bb} 
(97%)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.14.1.bb 
b/meta/recipes-sato/webkit/webkitgtk_2.14.2.bb
similarity index 97%
rename from meta/recipes-sato/webkit/webkitgtk_2.14.1.bb
rename to meta/recipes-sato/webkit/webkitgtk_2.14.2.bb
index 1f2166c..373df17 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.14.1.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.14.2.bb
@@ -20,8 +20,8 @@ SRC_URI = 
"http://www.webkitgtk.org/releases/${BPN}-${PV}.tar.xz \

file://0001-Tweak-gtkdoc-settings-so-that-gtkdoc-generation-work.patch \
"
 
-SRC_URI[md5sum] = "8d6c60dc41604d3bbd43165a674c07e5"
-SRC_URI[sha256sum] = 
"2e2d76c328de65bed6e0e4f096b2720a366654b27fc1af0830ece90bc4b7ceb5"
+SRC_URI[md5sum] = "2fe3cadbc546d93ca68a13756c2be015"
+SRC_URI[sha256sum] = 
"2edbcbd5105046aea55af9671c4de8deedb5b0e3567c618034d440a760675556"
 
 inherit cmake pkgconfig gobject-introspection perlnative distro_features_check 
upstream-version-is-even gtk-doc
 
-- 
2.1.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] Move the recommends on ca-certificates from epiphany to webkitgtk.

2016-11-09 Thread Carlos Alberto Lopez Perez

 * The webkitgtk package should recommend the ca-certificates one,
   because any program usign webkit (and not only epiphany) would
   expect that the CAs certificates are available and that https
   validation works as expected.

 * For example, webkitgtk includes a MiniBrowser program that would
   fail to proper verify https sites if the ca-certificate package
   is not installed

 * Instead of making each one of the webkitgtk consumers care about
   the certificate package, do this in webkit itself.

Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
---
 meta/recipes-gnome/epiphany/epiphany_3.22.1.bb | 3 +--
 meta/recipes-sato/webkit/webkitgtk_2.14.1.bb   | 2 ++
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-gnome/epiphany/epiphany_3.22.1.bb 
b/meta/recipes-gnome/epiphany/epiphany_3.22.1.bb
index 3c63d33..2a9d200 100644
--- a/meta/recipes-gnome/epiphany/epiphany_3.22.1.bb
+++ b/meta/recipes-gnome/epiphany/epiphany_3.22.1.bb
@@ -2,7 +2,7 @@ SUMMARY = "WebKit based web browser for GNOME"
 LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
 
-DEPENDS = "libsoup-2.4 webkitgtk gtk+3 iso-codes ca-certificates avahi 
libnotify gcr \
+DEPENDS = "libsoup-2.4 webkitgtk gtk+3 iso-codes avahi libnotify gcr \
   gsettings-desktop-schemas gnome-desktop3 libxml2-native 
intltool-native"
 
 inherit gnomebase gsettings distro_features_check upstream-version-is-even
@@ -20,4 +20,3 @@ do_configure_prepend() {
 
 FILES_${PN} += "${datadir}/appdata ${datadir}/dbus-1 
${datadir}/gnome-shell/search-providers"
 RDEPENDS_${PN} = "iso-codes adwaita-icon-theme"
-RRECOMMENDS_${PN} = "ca-certificates"
diff --git a/meta/recipes-sato/webkit/webkitgtk_2.14.1.bb 
b/meta/recipes-sato/webkit/webkitgtk_2.14.1.bb
index d6d9c14..39197bc 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.14.1.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.14.1.bb
@@ -90,6 +90,8 @@ SECURITY_CFLAGS_append_aarch64 = " -fPIE"
 
 FILES_${PN} += 
"${libdir}/webkit2gtk-4.0/injected-bundle/libwebkit2gtkinjectedbundle.so"
 
+RRECOMMENDS_${PN} += "ca-certificates"
+
 # http://errors.yoctoproject.org/Errors/Details/20370/
 ARM_INSTRUCTION_SET_armv4 = "arm"
 ARM_INSTRUCTION_SET_armv5 = "arm"
-- 
2.1.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] webkitgtk: Add an option to disable opengl support

2016-11-09 Thread Carlos Alberto Lopez Perez

Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.14.1.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.14.1.bb 
b/meta/recipes-sato/webkit/webkitgtk_2.14.1.bb
index 69c9f11..d6d9c14 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.14.1.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.14.1.bb
@@ -41,7 +41,7 @@ DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt 
libidn gnutls \
   "
 
 PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', 
'wayland' ,d)} \
-   ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'webgl', 
'' ,d)} \
+   ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'webgl 
opengl', '' ,d)} \
enchant \
libsecret \
   "
@@ -53,6 +53,7 @@ PACKAGECONFIG[enchant] = 
"-DENABLE_SPELLCHECK=ON,-DENABLE_SPELLCHECK=OFF,enchant
 PACKAGECONFIG[gtk2] = 
"-DENABLE_PLUGIN_PROCESS_GTK2=ON,-DENABLE_PLUGIN_PROCESS_GTK2=OFF,gtk+"
 PACKAGECONFIG[gles2] = "-DENABLE_GLES2=ON,-DENABLE_GLES2=OFF,virtual/libgles2"
 PACKAGECONFIG[webgl] = "-DENABLE_WEBGL=ON,-DENABLE_WEBGL=OFF,virtual/libgl"
+PACKAGECONFIG[opengl] = "-DENABLE_OPENGL=ON,-DENABLE_OPENGL=OFF,virtual/libgl"
 PACKAGECONFIG[libsecret] = 
"-DENABLE_CREDENTIAL_STORAGE=ON,-DENABLE_CREDENTIAL_STORAGE=OFF,libsecret"
 PACKAGECONFIG[libhyphen] = "-DUSE_LIBHYPHEN=ON,-DUSE_LIBHYPHEN=OFF,libhyphen"
 
-- 
2.1.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [oe-core][PATCH] webkitgtk: drop patch 0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch

2016-11-08 Thread Carlos Alberto Lopez Perez

 * This patch is not longer needed. Upstream has fixed this issue in:
   https://trac.webkit.org/changeset/205672 which is already included
   in WebKitGTK+ >= 2.14.0

Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
---
 ...bKitMacros-Append-to-I-and-not-to-isystem.patch | 181 -
 meta/recipes-sato/webkit/webkitgtk_2.14.1.bb   |   1 -
 2 files changed, 182 deletions(-)
 delete mode 100644 
meta/recipes-sato/webkit/files/0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch

diff --git 
a/meta/recipes-sato/webkit/files/0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch
 
b/meta/recipes-sato/webkit/files/0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch
deleted file mode 100644
index ef209c8..000
--- 
a/meta/recipes-sato/webkit/files/0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch
+++ /dev/null
@@ -1,181 +0,0 @@
-From 20ee11dd188e1538f8cdd17a289dc6f9c63a011e Mon Sep 17 00:00:00 2001
-From: Khem Raj <raj.k...@gmail.com>
-Date: Sun, 17 Apr 2016 12:35:41 -0700
-Subject: [PATCH] WebKitMacros: Append to -I and not to -isystem
-
-gcc-6 has now introduced stdlib.h in libstdc++ for better
-compliance and its including the C library stdlib.h using
-include_next which is sensitive to order of system header
-include paths. Its infact better to not tinker with the
-system header include paths at all. Since adding /usr/include
-to -system is redundant and compiler knows about it moreover
-now with gcc6 it interferes with compiler's functioning
-and ends up with compile errors e.g.
-
-/usr/include/c++/6.0.0/cstdlib:75:25: fatal error: stdlib.h: No such file or 
directory
-
-Signed-off-by: Khem Raj <raj.k...@gmail.com>
-Upstream-Status: Pending

- Source/JavaScriptCore/shell/CMakeLists.txt | 2 +-
- Source/WebCore/PlatformGTK.cmake   | 6 +++---
- Source/WebKit2/PlatformGTK.cmake   | 2 +-
- Source/cmake/WebKitMacros.cmake| 2 +-
- Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt | 2 +-
- Tools/ImageDiff/CMakeLists.txt | 2 +-
- Tools/MiniBrowser/gtk/CMakeLists.txt   | 2 +-
- Tools/TestWebKitAPI/PlatformGTK.cmake  | 2 +-
- Tools/TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt| 2 +-
- Tools/WebKitTestRunner/CMakeLists.txt  | 2 +-
- 10 files changed, 12 insertions(+), 12 deletions(-)
-
-diff --git a/Source/JavaScriptCore/shell/CMakeLists.txt 
b/Source/JavaScriptCore/shell/CMakeLists.txt
-index 155c797..80fe22b 100644
 a/Source/JavaScriptCore/shell/CMakeLists.txt
-+++ b/Source/JavaScriptCore/shell/CMakeLists.txt
-@@ -20,7 +20,7 @@ WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()
- 
- WEBKIT_WRAP_SOURCELIST(${JSC_SOURCES})
- include_directories(./ ${JavaScriptCore_INCLUDE_DIRECTORIES})
--include_directories(SYSTEM ${JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES})
-+include_directories(${JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES})
- add_executable(jsc ${JSC_SOURCES})
- target_link_libraries(jsc ${JSC_LIBRARIES})
- 
-diff --git a/Source/WebCore/PlatformGTK.cmake 
b/Source/WebCore/PlatformGTK.cmake
-index 567bd79..1fabea8 100644
 a/Source/WebCore/PlatformGTK.cmake
-+++ b/Source/WebCore/PlatformGTK.cmake
-@@ -340,7 +340,7 @@ if (ENABLE_PLUGIN_PROCESS_GTK2)
- ${GTK2_INCLUDE_DIRS}
- ${GDK2_INCLUDE_DIRS}
- )
--target_include_directories(WebCorePlatformGTK2 SYSTEM PRIVATE
-+target_include_directories(WebCorePlatformGTK2 PRIVATE
- ${WebCore_SYSTEM_INCLUDE_DIRECTORIES}
- )
- target_link_libraries(WebCorePlatformGTK2
-@@ -365,7 +365,7 @@ WEBKIT_SET_EXTRA_COMPILER_FLAGS(WebCorePlatformGTK)
- target_include_directories(WebCorePlatformGTK PRIVATE
- ${WebCore_INCLUDE_DIRECTORIES}
- )
--target_include_directories(WebCorePlatformGTK SYSTEM PRIVATE
-+target_include_directories(WebCorePlatformGTK PRIVATE
- ${WebCore_SYSTEM_INCLUDE_DIRECTORIES}
- ${GTK_INCLUDE_DIRS}
- ${GDK_INCLUDE_DIRS}
-@@ -383,7 +383,7 @@ include_directories(
- "${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}"
- )
- 
--include_directories(SYSTEM
-+include_directories(
- ${WebCore_SYSTEM_INCLUDE_DIRECTORIES}
- )
- 
-diff --git a/Source/WebKit2/PlatformGTK.cmake 
b/Source/WebKit2/PlatformGTK.cmake
-index e4805a4..c57df5d 100644
 a/Source/WebKit2/PlatformGTK.cmake
-+++ b/Source/WebKit2/PlatformGTK.cmake
-@@ -822,7 +822,7 @@ if (ENABLE_PLUGIN_PROCESS_GTK2)
- target_include_directories(WebKitPluginProcess2 PRIVATE
- ${WebKit2CommonIncludeDirectories}
- )
--target_include_directories(WebKitPluginProcess2 SYSTEM PRIVATE
-+target_include_directories(WebKitPluginProcess2 PRIVATE
-  ${WebKit2CommonSystemIncludeDirectories}
-  ${GTK2_INCLUDE_DIRS}
-  ${GDK2_INCLUDE_DIRS}
-diff --git a/Source/cmake/WebKitMacros.cmake b/Source/cmake/WebKitMacros.cmake
-index 043e78e..8b3b642 100644
 a/Source/cmake/WebKitMacros.cmake
-+++ b/Source/cmak

Re: [OE-core] [PATCH] webkitgtk: Switch the ARMv7 build to Thumb2 and enable back the JSC JIT.

2016-07-19 Thread Carlos Alberto Lopez Perez

On 19/07/16 21:26, Khem Raj wrote:
> On Mon, Jul 18, 2016 at 2:19 PM, Carlos Alberto Lopez Perez
> <clo...@igalia.com> wrote:
>> > * The JSC JIT is broken on ARMv7 without Thumb2.
>> >
>> > [YOCTO #9474]
>> >
>> > Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
>> > ---
>> >  meta/recipes-sato/webkit/webkitgtk_2.12.3.bb | 17 -
>> >  1 file changed, 12 insertions(+), 5 deletions(-)
>> >
>> > diff --git a/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb 
>> > b/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
>> > index c5e5432..536fa23 100644
>> > --- a/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
>> > +++ b/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
>> > @@ -71,10 +71,6 @@ EXTRA_OECMAKE_append_armv5 = " -DENABLE_JIT=OFF "
>> >  EXTRA_OECMAKE_append_armv6 = " -DENABLE_JIT=OFF "
>> >  EXTRA_OECMAKE_append_armv4 = " -DENABLE_JIT=OFF "
>> >
>> > -# ARM JIT can build on armv7a, but doesnt' work on runtime, cause
>> > -# displaying problems or ephiphany hang.
>> > -EXTRA_OECMAKE_append_armv7a = " -DENABLE_JIT=OFF "
>> > -
>> >  # binutils 2.25.1 has a bug on aarch64:
>> >  # https://sourceware.org/bugzilla/show_bug.cgi?id=18430
>> >  EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "
>> > @@ -89,7 +85,18 @@ SECURITY_CFLAGS_append_aarch64 = " -fPIE"
>> >  FILES_${PN} += 
>> > "${libdir}/webkit2gtk-4.0/injected-bundle/libwebkit2gtkinjectedbundle.so"
>> >
>> >  # http://errors.yoctoproject.org/Errors/Details/20370/
>> > -ARM_INSTRUCTION_SET = "arm"
>> > +ARM_INSTRUCTION_SET_armv4 = "arm"
>> > +ARM_INSTRUCTION_SET_armv5 = "arm"
>> > +ARM_INSTRUCTION_SET_armv6 = "arm"
>> > +
>> > +# https://bugzilla.yoctoproject.org/show_bug.cgi?id=9474
>> > +# https://bugs.webkit.org/show_bug.cgi?id=159880
>> > +# JSC JIT can build on ARMv7 with -marm, but doesn't work on runtime.
>> > +# Upstream only tests regularly the JSC JIT on ARMv7 with Thumb2 
>> > (-mthumb).
>> > +ARM_INSTRUCTION_SET_armv7a = "thumb"
>> > +ARM_INSTRUCTION_SET_armv7r = "thumb"
>> > +ARM_INSTRUCTION_SET_armv7m = "thumb"
>> > +ARM_INSTRUCTION_SET_armv7ve = "thumb"
> This should be ok. Do we need to specify 'm' ?
> they should be thumb only anyway
> 

Right, good catch..

So I guess is not needed to specify anything for armv7m.

Do you want me to send the patch again without the armv7m line?

Regards.



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] webkitgtk: Switch the ARMv7 build to Thumb2 and enable back the JSC JIT.

2016-07-18 Thread Carlos Alberto Lopez Perez

* The JSC JIT is broken on ARMv7 without Thumb2.

[YOCTO #9474]

Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.12.3.bb | 17 -
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb 
b/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
index c5e5432..536fa23 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
@@ -71,10 +71,6 @@ EXTRA_OECMAKE_append_armv5 = " -DENABLE_JIT=OFF "
 EXTRA_OECMAKE_append_armv6 = " -DENABLE_JIT=OFF "
 EXTRA_OECMAKE_append_armv4 = " -DENABLE_JIT=OFF "
 
-# ARM JIT can build on armv7a, but doesnt' work on runtime, cause
-# displaying problems or ephiphany hang.
-EXTRA_OECMAKE_append_armv7a = " -DENABLE_JIT=OFF "
-
 # binutils 2.25.1 has a bug on aarch64:
 # https://sourceware.org/bugzilla/show_bug.cgi?id=18430
 EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "
@@ -89,7 +85,18 @@ SECURITY_CFLAGS_append_aarch64 = " -fPIE"
 FILES_${PN} += 
"${libdir}/webkit2gtk-4.0/injected-bundle/libwebkit2gtkinjectedbundle.so"
 
 # http://errors.yoctoproject.org/Errors/Details/20370/
-ARM_INSTRUCTION_SET = "arm"
+ARM_INSTRUCTION_SET_armv4 = "arm"
+ARM_INSTRUCTION_SET_armv5 = "arm"
+ARM_INSTRUCTION_SET_armv6 = "arm"
+
+# https://bugzilla.yoctoproject.org/show_bug.cgi?id=9474
+# https://bugs.webkit.org/show_bug.cgi?id=159880
+# JSC JIT can build on ARMv7 with -marm, but doesn't work on runtime.
+# Upstream only tests regularly the JSC JIT on ARMv7 with Thumb2 (-mthumb).
+ARM_INSTRUCTION_SET_armv7a = "thumb"
+ARM_INSTRUCTION_SET_armv7r = "thumb"
+ARM_INSTRUCTION_SET_armv7m = "thumb"
+ARM_INSTRUCTION_SET_armv7ve = "thumb"
 
 # Invalid data memory access: 0x
 # ...
-- 
2.1.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] webkitgtk, gcr, libsecret: force ARM mode

2015-10-12 Thread Carlos Alberto Lopez Perez

On 12/10/15 13:17, Alexander Kanavin wrote:
> On 10/11/2015 12:45 AM, Carlos Alberto Lopez Perez wrote:
> 
>> So, could we set ARM_INSTRUCTION_SET=arm only for armv6 or older
>> machines in this 3 recipes?
> 
> Indeed. Webkit has other issues on armv6 or older (JIT fails to build if
> you try to), so I believe the upstream developers test the builds only
> on v7 onwards nowadays, and don't actually support anything older.
> 
> 
> Alex
> 

Yes, that's true.

The buildbots we have continuously testing [1] only do it on i686,
AMD64, ARMv7+ (traditional/arm and thumb2) and ARM64 (Aarch64)
architectures.

Regards
---
[1] https://build.webkit.org/builders



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] webkitgtk, gcr, libsecret: force ARM mode

2015-10-10 Thread Carlos Alberto Lopez Perez

On 10/10/15 17:32, Martin Jansa wrote:
> Did you enable thumb in that build? It's not enabled by default.
> 
> ARM_INSTRUCTION_SET is for recipes to use arm when distro selects thumb by
> default.

I assumed it was enabled by default if it was listed on the list printed
on TUNE_FEATURES when starting bitbake. Seems not.

I manually enabled it on the recipe of webkitgtk+ by setting
'ARM_INSTRUCTION_SET = "thumb"' and I was able to reproduce the build
failure.

However, later I tried doing the same for a standard armv7a machine and
it built fine.

qemuarm is arvm6 with thumb1, and any armv7 or newer machine will prefer
thumb2 instead. The compiler would automatically use thumb2 when
enabling -mthumb on a armv7 or newer march.

So, it built fine with -march=armv7-a -mthumb

Given that most people building webkitgtk+ will use armv7 or newer, I
don't think disabling the possibility of building webkitgtk+ with thumb
(thumb2) unconditionally is a good idea.

I also tested to build gcr and libsecret. Both build also fine with
-mthumb on armv7.

So, could we set ARM_INSTRUCTION_SET=arm only for armv6 or older
machines in this 3 recipes?

signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] webkitgtk, gcr, libsecret: force ARM mode

2015-10-10 Thread Carlos Alberto Lopez Perez

On 09/10/15 17:11, Martin Jansa wrote:
> * gcr, libsecret are new since switch to gcc 5.2
> * webkitgtk is old but it was removed while migrating from
>   webkit-gtk to webkitgtl (like REQUIRED_DISTRO_FEATURES were) :/
> 
> Signed-off-by: Martin Jansa 
> ---

> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb 
> b/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
> index f14c868..e29666a 100644
> --- a/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
> +++ b/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
> @@ -70,3 +70,5 @@ FILES_${PN} += 
> "${libdir}/webkit2gtk-4.0/injected-bundle/libwebkit2gtkinjectedbu
>  FILES_${PN}-dbg += 
> "${libdir}/webkit2gtk-4.0/injected-bundle/.debug/libwebkit2gtkinjectedbundle.so"
>  FILES_${PN}-dbg += "${libdir}/webkitgtk/webkit2gtk-4.0/.debug/*"
>  
> +# http://errors.yoctoproject.org/Errors/Details/20370/
> +ARM_INSTRUCTION_SET = "arm"
> 

I tried to build webkitgtk using current master of poky for machine
qemuarm and it built fine:

Build Configuration:
BB_VERSION= "1.28.0"
BUILD_SYS = "x86_64-linux"
NATIVELSBSTRING   = "Debian-8.1"
TARGET_SYS= "arm-poky-linux-gnueabi"
MACHINE   = "qemuarm"
DISTRO= "poky"
DISTRO_VERSION= "2.0"
TUNE_FEATURES = "arm armv5 thumb dsp"
TARGET_FPU= "soft"
meta
meta-yocto
meta-yocto-bsp= "master:ceeb52a2544045fe8432e36307a321f6e934de49"




Can you tell me how to reproduce this failure?
Also, what the ARM_INSTRUCTION_SET = "arm" line does?
Thanks.



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [oe-core][PATCH] machine/qemu: Fix OpenGL/GLX support with xserver-xorg.

2015-10-06 Thread Carlos Alberto Lopez Perez

  * The Xorg server needs to load the GLX extension in order to
enable proper OpenGL support.

  * Before this patch, glxinfo aborted with:

  root@qemux86:~# glxinfo
  name of display: :0.0
  Error: couldn't find RGB GLX visual or fbconfig

  * After this patch, it works as expected:

  root@qemux86:~# glxinfo | grep " render"
  direct rendering: Yes
  OpenGL renderer string: Software Rasterizer

Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
---
 meta/conf/machine/include/qemu.inc | 2 +-
 meta/conf/machine/qemux86-64.conf  | 2 +-
 meta/conf/machine/qemux86.conf | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/conf/machine/include/qemu.inc 
b/meta/conf/machine/include/qemu.inc
index d5c0b37..16e9469 100644
--- a/meta/conf/machine/include/qemu.inc
+++ b/meta/conf/machine/include/qemu.inc
@@ -5,7 +5,7 @@ PREFERRED_PROVIDER_virtual/libgles1 ?= "mesa"
 PREFERRED_PROVIDER_virtual/libgles2 ?= "mesa"
 
 XSERVER ?= "xserver-xorg \
-${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 
'mesa-driver-swrast', '', d)} \
+${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 
'mesa-driver-swrast xserver-xorg-extension-glx', '', d)} \
 xf86-input-evdev \
 xf86-input-mouse \
 xf86-video-fbdev \
diff --git a/meta/conf/machine/qemux86-64.conf 
b/meta/conf/machine/qemux86-64.conf
index a4fd43c..489194a 100644
--- a/meta/conf/machine/qemux86-64.conf
+++ b/meta/conf/machine/qemux86-64.conf
@@ -16,7 +16,7 @@ KERNEL_IMAGETYPE = "bzImage"
 SERIAL_CONSOLES = "115200;ttyS0 115200;ttyS1"
 
 XSERVER = "xserver-xorg \
-   ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 
'mesa-driver-swrast', '', d)} \
+   ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 
'mesa-driver-swrast xserver-xorg-extension-glx', '', d)} \
xf86-input-vmmouse \
xf86-input-keyboard \
xf86-input-evdev \
diff --git a/meta/conf/machine/qemux86.conf b/meta/conf/machine/qemux86.conf
index 96cea66..3cc8091 100644
--- a/meta/conf/machine/qemux86.conf
+++ b/meta/conf/machine/qemux86.conf
@@ -15,7 +15,7 @@ KERNEL_IMAGETYPE = "bzImage"
 SERIAL_CONSOLES = "115200;ttyS0 115200;ttyS1"
 
 XSERVER = "xserver-xorg \
-   ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 
'mesa-driver-swrast', '', d)} \
+   ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 
'mesa-driver-swrast xserver-xorg-extension-glx', '', d)} \
xf86-input-vmmouse \
xf86-input-keyboard \
xf86-input-evdev \
-- 
2.1.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [oe-core][PATCH] machine/qemu: Fix OpenGL/GLX support with xserver-xorg.

2015-10-06 Thread Carlos Alberto Lopez Perez

On 06/10/15 18:12, Burton, Ross wrote:
> On 6 October 2015 at 16:00, Carlos Alberto Lopez Perez <clo...@igalia.com>
> wrote:
> 
>>   root@qemux86:~# glxinfo | grep " render"
>>   direct rendering: Yes
>>   OpenGL renderer string: Software Rasterizer
>>
> 
> "Works" being a relative term for the old non-LLVM software renderer ;)
> 
> Ross
> 

Indeed, that is something that I also would like to fix.

In any case, now I'm able to execute GL apps within qemu using the
runqemu script, so is quite an improvement from the previous status-quo.



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] Branched for release

2015-10-01 Thread Carlos Alberto Lopez Perez

On 01/10/15 16:28, Khem Raj wrote:
> I would also suggest to not use codenames in branches
> but rather the numbered release. If we want to use codenames for
> branches then lets drop the numbered release names.
> 

I suggest using both (codename+release_number).

Ex: jethro-2.0 or 2.0-jethro

(probably the later one is better as it can be sorted by release number
easily)

That way everyone has clear which release number and which codename is,
without having to fire a browser to
https://wiki.yoctoproject.org/wiki/Releases




signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [oe-core][PATCH 0/2] webkitgtk: Add some packageconfig options.

2015-10-01 Thread Carlos Alberto Lopez Perez

  * This adds some useful packageconfig options to the webkitgtk recipe.
  * It switches also the CMake switches to ON/OFF (cosmetic)

Carlos Alberto Lopez Perez (2):
  webkitgtk: Use ON/OFF for cmake switches.
  webkitgtk: Add some PACKAGECONFIG options.

 meta/recipes-sato/webkit/webkitgtk_2.8.5.bb | 33 +++--
 1 file changed, 22 insertions(+), 11 deletions(-)

-- 
2.1.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [oe-core][PATCH 2/2] webkitgtk: Add some PACKAGECONFIG options.

2015-10-01 Thread Carlos Alberto Lopez Perez

 * Also default to enable X11/Wayland support or WebGL according
   to enabled DISTRO_FEATURES.

Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.8.5.bb | 15 +--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb 
b/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
index e92c6b1..f14c868 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
@@ -29,14 +29,25 @@ DEPENDS = "zlib enchant libsoup-2.4 curl libxml2 cairo 
libxslt libxt libidn gnut
   atk udev harfbuzz jpeg libpng pulseaudio librsvg libtheora libvorbis 
libxcomposite libxtst \
   ruby-native libsecret libnotify gstreamer1.0-plugins-bad \
   "
-DEPENDS += " ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 
'virtual/libgl', '', d)}"
+
+PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'x11', 'x11', 'wayland' 
,d)} \
+   ${@base_contains('DISTRO_FEATURES', 'opengl', 'webgl', '' 
,d)}"
+
+PACKAGECONFIG[wayland] = 
"-DENABLE_WAYLAND_TARGET=ON,-DENABLE_WAYLAND_TARGET=OFF,wayland"
+PACKAGECONFIG[x11] = 
"-DENABLE_X11_TARGET=ON,-DENABLE_X11_TARGET=OFF,virtual/libx11"
+PACKAGECONFIG[geoclue] = 
"-DENABLE_GEOLOCATION=ON,-DENABLE_GEOLOCATION=OFF,geoclue"
+PACKAGECONFIG[enchant] = 
"-DENABLE_SPELLCHECK=ON,-DENABLE_SPELLCHECK=OFF,enchant"
+PACKAGECONFIG[gtk2] = 
"-DENABLE_PLUGIN_PROCESS_GTK2=ON,-DENABLE_PLUGIN_PROCESS_GTK2=OFF,gtk+"
+PACKAGECONFIG[gles2] = "-DENABLE_GLES2=ON,-DENABLE_GLES2=OFF,virtual/libgles2"
+PACKAGECONFIG[webgl] = "-DENABLE_WEBGL=ON,-DENABLE_WEBGL=OFF,virtual/libgl"
+PACKAGECONFIG[libsecret] = 
"-DENABLE_CREDENTIAL_STORAGE=ON,-DENABLE_CREDENTIAL_STORAGE=OFF,libsecret"
 
 EXTRA_OECMAKE = " \
-DPORT=GTK \
-DCMAKE_BUILD_TYPE=Release \
-DENABLE_INTROSPECTION=OFF \
+   -DENABLE_GTKDOC=OFF \
-DENABLE_MINIBROWSER=ON \
-   ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 
'-DENABLE_WEBGL=ON', '-DENABLE_WEBGL=OFF', d)} \
"
 
 # Javascript JIT is not supported on powerpc
-- 
2.1.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [oe-core][PATCH 1/2] webkitgtk: Use ON/OFF for cmake switches.

2015-10-01 Thread Carlos Alberto Lopez Perez

  * This is a cosmetic patch.

  * Using ON/OFF instead of True/False is exactly the same for cmake
(is case insensitive).

  * But WebKitGTK+ preffers (and uses) the first option. So when you
check which values were enabled for the build (at log.do_configure)
you will see that every option that was not modified will print either
OFF or ON, meanwhile the options modified by this recipe will print
True or False. For example:

 [...]
 --  ENABLE_THREADED_COMPOSITOROFF
 --  ENABLE_PLUGIN_PROCESS_GTK2 .. ON
 --  ENABLE_MINIBROWSERTrue
 [...]

Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.8.5.bb | 20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb 
b/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
index 859d0cb..e92c6b1 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
@@ -34,26 +34,26 @@ DEPENDS += " ${@bb.utils.contains('DISTRO_FEATURES', 
'opengl', 'virtual/libgl',
 EXTRA_OECMAKE = " \
-DPORT=GTK \
-DCMAKE_BUILD_TYPE=Release \
-   -DENABLE_INTROSPECTION=False \
-   -DENABLE_MINIBROWSER=True \
-   ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 
'-DENABLE_WEBGL=True', '-DENABLE_WEBGL=False', d)} \
+   -DENABLE_INTROSPECTION=OFF \
+   -DENABLE_MINIBROWSER=ON \
+   ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 
'-DENABLE_WEBGL=ON', '-DENABLE_WEBGL=OFF', d)} \
"
 
 # Javascript JIT is not supported on powerpc
-EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=False "
-EXTRA_OECMAKE_append_powerpc64 = " -DENABLE_JIT=False "
+EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
+EXTRA_OECMAKE_append_powerpc64 = " -DENABLE_JIT=OFF "
 
 # ARM JIT code does not build on ARMv5/6 anymore, apparently they test only on 
v7 onwards
-EXTRA_OECMAKE_append_armv5 = " -DENABLE_JIT=False "
-EXTRA_OECMAKE_append_armv6 = " -DENABLE_JIT=False "
+EXTRA_OECMAKE_append_armv5 = " -DENABLE_JIT=OFF "
+EXTRA_OECMAKE_append_armv6 = " -DENABLE_JIT=OFF "
 
 # binutils 2.25.1 has a bug on aarch64:
 # https://sourceware.org/bugzilla/show_bug.cgi?id=18430
-EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=False "
+EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "
 
 # JIT not supported on MIPS either
-EXTRA_OECMAKE_append_mips = " -DENABLE_JIT=False "
-EXTRA_OECMAKE_append_mips64 = " -DENABLE_JIT=False "
+EXTRA_OECMAKE_append_mips = " -DENABLE_JIT=OFF "
+EXTRA_OECMAKE_append_mips64 = " -DENABLE_JIT=OFF "
 
 FILES_${PN} += 
"${libdir}/webkit2gtk-4.0/injected-bundle/libwebkit2gtkinjectedbundle.so"
 FILES_${PN}-dbg += 
"${libdir}/webkit2gtk-4.0/injected-bundle/.debug/libwebkit2gtkinjectedbundle.so"
-- 
2.1.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] Re: [PATCH] matchbox-keyboard: Fix build failure with ld-is-gold

2015-09-14 Thread Carlos Alberto Lopez Perez

On 14/09/15 09:24, Khem Raj wrote:
> 
>> On Sep 11, 2015, at 7:51 AM, Phil Blundell <p...@pbcl.net> wrote:
>>
>> On Fri, 2015-09-11 at 14:49 +0200, Carlos Alberto Lopez Perez wrote:
>>>  * When ld-is-gold is enabled in DISTRO_FEATURES, matchbox-keyboard
>>>will fail to build with this error:
>>>
>>>ld: error: matchbox-keyboard-image.o: requires unsupported dynamic
>>>   reloc R_ARM_MOVW_ABS_NC; recompile with -fPIC
>>
>> This is only an issue for ARM (and only for Thumb2 at that).  I don't
>> think it's necessarily appropriate to force -fPIC on all targets.
>>
>> Also, before adding this sort of hack it would be worth verifying
>> whether this is in fact a toolchain bug and, if it is, fixing it there.
>>
> 
> This may not be a toolchain bug if there is a MOVW_ABS relocation being 
> emitted
> into an object that is eventually linked into shared library. Using -fPIC 
> seems to be right fix
> I know bfd linker silently ignored these relocations and generated bad .so 
> files but that was fixed
> several years ago. So I think what needs to be looked at is why does same .o 
> links ok with bfd linker
> is it some linker trampoline code thats in question here which may be 
> different between gold and ld
> 
> Carlos
> 
> Can you check the linker cmdline of failing link step and see if its 
> generating a shared object there ?
> if thats the case and I assume gcc is generating this relocation into both
> 

It looks is generating an executable (matchbox-keyboard).

Full log: http://sprunge.us/VPIN



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] Re: [PATCH] matchbox-keyboard: Fix build failure with ld-is-gold

2015-09-11 Thread Carlos Alberto Lopez Perez

On 11/09/15 16:51, Phil Blundell wrote:
> On Fri, 2015-09-11 at 14:49 +0200, Carlos Alberto Lopez Perez wrote:
>>   * When ld-is-gold is enabled in DISTRO_FEATURES, matchbox-keyboard
>> will fail to build with this error:
>>
>> ld: error: matchbox-keyboard-image.o: requires unsupported dynamic
>>reloc R_ARM_MOVW_ABS_NC; recompile with -fPIC
> 
> This is only an issue for ARM (and only for Thumb2 at that).  I don't
> think it's necessarily appropriate to force -fPIC on all targets.
> 
> Also, before adding this sort of hack it would be worth verifying
> whether this is in fact a toolchain bug and, if it is, fixing it there.
> 
> p.
> 
> 
> 

If you (or somebody else) want to investigate whether this is a bug on
the toolchain or not, I can give you more data:

* I forced GCC 4.9 (GCC 5.X was failing to build the kernel, and I don't
bothered with it).

$ grep GCCVERSION conf/local.conf
GCCVERSION = "4.9%"

* The target machine is a Freescale imx6qsabresd board, so I also used
the meta-freescale layer (master)

If you need more details, let me know.

I'm not bothering more with this, as the above patch is good enough for
me. Feel free to take it or not, or to contribute a better one if you wish.

Regards.



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] matchbox-keyboard: Fix build failure with ld-is-gold

2015-09-11 Thread Carlos Alberto Lopez Perez

  * When ld-is-gold is enabled in DISTRO_FEATURES, matchbox-keyboard
will fail to build with this error:

ld: error: matchbox-keyboard-image.o: requires unsupported dynamic
   reloc R_ARM_MOVW_ABS_NC; recompile with -fPIC

Signed-off-by: Carlos Alberto Lopez Perez <clo...@igalia.com>
---
 meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb 
b/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb
index 0d321d3..cde1c49 100644
--- a/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb
+++ b/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb
@@ -25,6 +25,8 @@ inherit autotools pkgconfig gettext gtk-immodules-cache 
distro_features_check
 # The libxft, libfakekey and matchbox-panel-2 requires x11 in DISTRO_FEATURES
 REQUIRED_DISTRO_FEATURES = "x11"
 
+CFLAGS_append = "${@base_contains('DISTRO_FEATURES', 'ld-is-gold', ' -fPIC ', 
'', d)}"
+
 EXTRA_OECONF = "--disable-cairo --enable-gtk-im --enable-applet"
 
 PACKAGES += "${PN}-im ${PN}-applet"
-- 
2.1.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

46 matches

Mail list logo