Re: [OE-core] [PATCH 3/4] mtd-utils: upgrade 2.0.1 -> 2.0.2
I'm sorry, it's one of those days where "mtd-utils" and "mdadm" look exactly the same to me - yeah both are in oe-core, both start with m and are related to block devices. And the build failure with mdadm is reproducible with DEBUG_BUILD, -O2 and above work fine thanks to -ftree-vrp (similarly like systemd gcc8 issue fixed in http://git.openembedded.org/openembedded-core/commit/?id=b0fdaedc6e9c233f357022b0fb706cb19757f5c4 ) On Thu, Jun 21, 2018 at 1:30 PM Martin Jansa wrote: > It might be DEBUG_BUILD enabled in my builds, let me check. > > On Thu, Jun 21, 2018 at 1:20 PM Burton, Ross > wrote: > >> Master builds fine for me, but interestingly I don't see that in my >> mtd-utils unpack. Do you have patches? >> >> Ross >> >> On 21 June 2018 at 12:10, Martin Jansa wrote: >> > Does this upgrade fix the build failure with gcc8? >> > >> > With current master I'm seeing: >> > super0.c:238:32: error: 'snprintf' output may be truncated before the >> last >> > format character [-Werror=format-truncation=] >> > >> > On Thu, Jun 21, 2018 at 12:33 PM Burton, Ross >> wrote: >> >> >> >> Sorry, no it doesn't. I've just picked this in ross/mut but a >> >> follow-up patch to remove that mystery patch (can't see it being used >> >> in image generation anywhere) would be good. >> >> >> >> Ross >> >> >> >> On 20 June 2018 at 00:53, Denys Dmytriyenko wrote: >> >> > On Tue, May 22, 2018 at 01:16:34PM +0100, Burton, Ross wrote: >> >> >> On 22 May 2018 at 08:49, Andrea Adami >> wrote: >> >> >> > I am just wondering about this patch:we carry it since 2009 [1] >> and >> >> >> > is still marked as pending. >> >> >> > Why was it necessary to ignore part of the filesystem? Can you >> >> >> > remember? >> >> >> >> >> >> Make that at least 2004. This commit in oe-classic touches it: >> >> >> >> >> >> commit c70605ebdca81412a93b4d867de7931543193f26 >> >> >> Author: Chris Larson >> >> >> Date: Thu Dec 23 21:24:57 2004 + >> >> >> >> >> >> Update mtd to a current snapshot, change the mkfs.jffs2 -i >> cmdline >> >> >> option to >> >> >> -I, and rename mtd and mtd-native to mtd-utils and >> >> >> mtd-utils-native, >> >> >> respectively. >> >> >> >> >> >> Prior history is lost to the git/bk migration unless anyone has a >> >> >> BitKeeper clone to mine... >> >> > >> >> > So, does this prevent the version upgrade from being merged? >> >> > >> >> > -- >> >> > Denys >> >> -- >> >> ___ >> >> Openembedded-core mailing list >> >> Openembedded-core@lists.openembedded.org >> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> > -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 3/4] mtd-utils: upgrade 2.0.1 -> 2.0.2
It might be DEBUG_BUILD enabled in my builds, let me check. On Thu, Jun 21, 2018 at 1:20 PM Burton, Ross wrote: > Master builds fine for me, but interestingly I don't see that in my > mtd-utils unpack. Do you have patches? > > Ross > > On 21 June 2018 at 12:10, Martin Jansa wrote: > > Does this upgrade fix the build failure with gcc8? > > > > With current master I'm seeing: > > super0.c:238:32: error: 'snprintf' output may be truncated before the > last > > format character [-Werror=format-truncation=] > > > > On Thu, Jun 21, 2018 at 12:33 PM Burton, Ross > wrote: > >> > >> Sorry, no it doesn't. I've just picked this in ross/mut but a > >> follow-up patch to remove that mystery patch (can't see it being used > >> in image generation anywhere) would be good. > >> > >> Ross > >> > >> On 20 June 2018 at 00:53, Denys Dmytriyenko wrote: > >> > On Tue, May 22, 2018 at 01:16:34PM +0100, Burton, Ross wrote: > >> >> On 22 May 2018 at 08:49, Andrea Adami > wrote: > >> >> > I am just wondering about this patch:we carry it since 2009 [1] > and > >> >> > is still marked as pending. > >> >> > Why was it necessary to ignore part of the filesystem? Can you > >> >> > remember? > >> >> > >> >> Make that at least 2004. This commit in oe-classic touches it: > >> >> > >> >> commit c70605ebdca81412a93b4d867de7931543193f26 > >> >> Author: Chris Larson > >> >> Date: Thu Dec 23 21:24:57 2004 + > >> >> > >> >> Update mtd to a current snapshot, change the mkfs.jffs2 -i > cmdline > >> >> option to > >> >> -I, and rename mtd and mtd-native to mtd-utils and > >> >> mtd-utils-native, > >> >> respectively. > >> >> > >> >> Prior history is lost to the git/bk migration unless anyone has a > >> >> BitKeeper clone to mine... > >> > > >> > So, does this prevent the version upgrade from being merged? > >> > > >> > -- > >> > Denys > >> -- > >> ___ > >> Openembedded-core mailing list > >> Openembedded-core@lists.openembedded.org > >> http://lists.openembedded.org/mailman/listinfo/openembedded-core > -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 3/4] mtd-utils: upgrade 2.0.1 -> 2.0.2
Master builds fine for me, but interestingly I don't see that in my mtd-utils unpack. Do you have patches? Ross On 21 June 2018 at 12:10, Martin Jansa wrote: > Does this upgrade fix the build failure with gcc8? > > With current master I'm seeing: > super0.c:238:32: error: 'snprintf' output may be truncated before the last > format character [-Werror=format-truncation=] > > On Thu, Jun 21, 2018 at 12:33 PM Burton, Ross wrote: >> >> Sorry, no it doesn't. I've just picked this in ross/mut but a >> follow-up patch to remove that mystery patch (can't see it being used >> in image generation anywhere) would be good. >> >> Ross >> >> On 20 June 2018 at 00:53, Denys Dmytriyenko wrote: >> > On Tue, May 22, 2018 at 01:16:34PM +0100, Burton, Ross wrote: >> >> On 22 May 2018 at 08:49, Andrea Adami wrote: >> >> > I am just wondering about this patch:we carry it since 2009 [1] and >> >> > is still marked as pending. >> >> > Why was it necessary to ignore part of the filesystem? Can you >> >> > remember? >> >> >> >> Make that at least 2004. This commit in oe-classic touches it: >> >> >> >> commit c70605ebdca81412a93b4d867de7931543193f26 >> >> Author: Chris Larson >> >> Date: Thu Dec 23 21:24:57 2004 + >> >> >> >> Update mtd to a current snapshot, change the mkfs.jffs2 -i cmdline >> >> option to >> >> -I, and rename mtd and mtd-native to mtd-utils and >> >> mtd-utils-native, >> >> respectively. >> >> >> >> Prior history is lost to the git/bk migration unless anyone has a >> >> BitKeeper clone to mine... >> > >> > So, does this prevent the version upgrade from being merged? >> > >> > -- >> > Denys >> -- >> ___ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 3/4] mtd-utils: upgrade 2.0.1 -> 2.0.2
Does this upgrade fix the build failure with gcc8? With current master I'm seeing: super0.c:238:32: error: 'snprintf' output may be truncated before the last format character [-Werror=format-truncation=] On Thu, Jun 21, 2018 at 12:33 PM Burton, Ross wrote: > Sorry, no it doesn't. I've just picked this in ross/mut but a > follow-up patch to remove that mystery patch (can't see it being used > in image generation anywhere) would be good. > > Ross > > On 20 June 2018 at 00:53, Denys Dmytriyenko wrote: > > On Tue, May 22, 2018 at 01:16:34PM +0100, Burton, Ross wrote: > >> On 22 May 2018 at 08:49, Andrea Adami wrote: > >> > I am just wondering about this patch:we carry it since 2009 [1] and > >> > is still marked as pending. > >> > Why was it necessary to ignore part of the filesystem? Can you > remember? > >> > >> Make that at least 2004. This commit in oe-classic touches it: > >> > >> commit c70605ebdca81412a93b4d867de7931543193f26 > >> Author: Chris Larson > >> Date: Thu Dec 23 21:24:57 2004 + > >> > >> Update mtd to a current snapshot, change the mkfs.jffs2 -i cmdline > option to > >> -I, and rename mtd and mtd-native to mtd-utils and mtd-utils-native, > >> respectively. > >> > >> Prior history is lost to the git/bk migration unless anyone has a > >> BitKeeper clone to mine... > > > > So, does this prevent the version upgrade from being merged? > > > > -- > > Denys > -- > ___ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 3/4] mtd-utils: upgrade 2.0.1 -> 2.0.2
Sorry, no it doesn't. I've just picked this in ross/mut but a follow-up patch to remove that mystery patch (can't see it being used in image generation anywhere) would be good. Ross On 20 June 2018 at 00:53, Denys Dmytriyenko wrote: > On Tue, May 22, 2018 at 01:16:34PM +0100, Burton, Ross wrote: >> On 22 May 2018 at 08:49, Andrea Adami wrote: >> > I am just wondering about this patch:we carry it since 2009 [1] and >> > is still marked as pending. >> > Why was it necessary to ignore part of the filesystem? Can you remember? >> >> Make that at least 2004. This commit in oe-classic touches it: >> >> commit c70605ebdca81412a93b4d867de7931543193f26 >> Author: Chris Larson >> Date: Thu Dec 23 21:24:57 2004 + >> >> Update mtd to a current snapshot, change the mkfs.jffs2 -i cmdline >> option to >> -I, and rename mtd and mtd-native to mtd-utils and mtd-utils-native, >> respectively. >> >> Prior history is lost to the git/bk migration unless anyone has a >> BitKeeper clone to mine... > > So, does this prevent the version upgrade from being merged? > > -- > Denys -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 3/4] mtd-utils: upgrade 2.0.1 -> 2.0.2
On Tue, May 22, 2018 at 01:16:34PM +0100, Burton, Ross wrote: > On 22 May 2018 at 08:49, Andrea Adami wrote: > > I am just wondering about this patch:we carry it since 2009 [1] and > > is still marked as pending. > > Why was it necessary to ignore part of the filesystem? Can you remember? > > Make that at least 2004. This commit in oe-classic touches it: > > commit c70605ebdca81412a93b4d867de7931543193f26 > Author: Chris Larson > Date: Thu Dec 23 21:24:57 2004 + > > Update mtd to a current snapshot, change the mkfs.jffs2 -i cmdline option > to > -I, and rename mtd and mtd-native to mtd-utils and mtd-utils-native, > respectively. > > Prior history is lost to the git/bk migration unless anyone has a > BitKeeper clone to mine... So, does this prevent the version upgrade from being merged? -- Denys -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 3/4] mtd-utils: upgrade 2.0.1 -> 2.0.2
On 22 May 2018 at 08:49, Andrea Adamiwrote: > I am just wondering about this patch:we carry it since 2009 [1] and > is still marked as pending. > Why was it necessary to ignore part of the filesystem? Can you remember? Make that at least 2004. This commit in oe-classic touches it: commit c70605ebdca81412a93b4d867de7931543193f26 Author: Chris Larson Date: Thu Dec 23 21:24:57 2004 + Update mtd to a current snapshot, change the mkfs.jffs2 -i cmdline option to -I, and rename mtd and mtd-native to mtd-utils and mtd-utils-native, respectively. Prior history is lost to the git/bk migration unless anyone has a BitKeeper clone to mine... Ross -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 3/4] mtd-utils: upgrade 2.0.1 -> 2.0.2
On Tue, May 22, 2018 at 1:17 AM, Denys Dmytriyenkowrote: > From: Denys Dmytriyenko > > Signed-off-by: Denys Dmytriyenko > --- > meta/recipes-devtools/mtd/mtd-utils_git.bb | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-devtools/mtd/mtd-utils_git.bb > b/meta/recipes-devtools/mtd/mtd-utils_git.bb > index a0e1cf7..97a3e0c 100644 > --- a/meta/recipes-devtools/mtd/mtd-utils_git.bb > +++ b/meta/recipes-devtools/mtd/mtd-utils_git.bb > @@ -10,9 +10,9 @@ inherit autotools pkgconfig update-alternatives > DEPENDS = "zlib lzo e2fsprogs util-linux" > RDEPENDS_mtd-utils-tests += "bash" > > -PV = "2.0.1+${SRCPV}" > +PV = "2.0.2+${SRCPV}" > > -SRCREV = "9c6173559f95e939e66efb2ec3193d6f3618cf69" > +SRCREV = "bc63d36e39f389c8c17f6a8e9db47f2acc884659" > SRC_URI = "git://git.infradead.org/mtd-utils.git \ > file://add-exclusion-to-mkfs-jffs2-git-2.patch \ Hi Denys, I am just wondering about this patch:we carry it since 2009 [1] and is still marked as pending. Why was it necessary to ignore part of the filesystem? Can you remember? Just curious... Cheers Andrea [1] Denys Dmytriyenko 2009-03-17 http://cgit.openembedded.org/openembedded/log/recipes/mtd/mtd-utils/add-exclusion-to-mkfs-jffs2-git-2.patch > " > -- > 2.7.4 > > -- > ___ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH 3/4] mtd-utils: upgrade 2.0.1 -> 2.0.2
From: Denys DmytriyenkoSigned-off-by: Denys Dmytriyenko --- meta/recipes-devtools/mtd/mtd-utils_git.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/recipes-devtools/mtd/mtd-utils_git.bb b/meta/recipes-devtools/mtd/mtd-utils_git.bb index a0e1cf7..97a3e0c 100644 --- a/meta/recipes-devtools/mtd/mtd-utils_git.bb +++ b/meta/recipes-devtools/mtd/mtd-utils_git.bb @@ -10,9 +10,9 @@ inherit autotools pkgconfig update-alternatives DEPENDS = "zlib lzo e2fsprogs util-linux" RDEPENDS_mtd-utils-tests += "bash" -PV = "2.0.1+${SRCPV}" +PV = "2.0.2+${SRCPV}" -SRCREV = "9c6173559f95e939e66efb2ec3193d6f3618cf69" +SRCREV = "bc63d36e39f389c8c17f6a8e9db47f2acc884659" SRC_URI = "git://git.infradead.org/mtd-utils.git \ file://add-exclusion-to-mkfs-jffs2-git-2.patch \ " -- 2.7.4 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core