Re: [OE-core] [PATCH v8 06/13] go-dep: Move bash dependency to -dev package

2017-09-13 Thread Otavio Salvador 
On Wed, Sep 13, 2017 at 8:09 AM, Matt Madison  wrote:
> On Tue, Sep 12, 2017 at 12:21 PM, Khem Raj  wrote:
>> On Tue, Sep 12, 2017 at 12:20 PM, Otavio Salvador
>>  wrote:
>>> On Tue, Sep 12, 2017 at 3:58 PM, Martin Jansa  
>>> wrote:
 Seems like this version was already picked to master-next, so probably
 better to leave as standalone change now.

 The version currently in master fails to build for arm with thumb enabled:
 http://errors.yoctoproject.org/Errors/Details/155765/

 Is it fixed somewhere in this new patchset?

 # github.com/golang/dep/cmd/dep
 TOPDIR/tmp-glibc/work/armv5te-oe-linux-gnueabi/go-dep/0.3.0-r0/recipe-sysroot-native/usr/lib/arm-oe-linux-gnueabi/go/pkg/tool/linux_amd64/link:
 R_ARM_THM_CALL, are you using -marm?
 WARNING: exit code 2 from a shell command.
 ERROR: Function failed: do_compile (log file is located at
 TOPDIR/tmp-glibc/work/armv5te-oe-linux-gnueabi/go-dep/0.3.0-r0/temp/log.do_compile.13531)
>>>
>>> No, it is not.
>>>
>>> It seems that Go, when using CGO, does not play nice with Thumb. Matt,
>>> do you know if there is a known fix for it?
>>
>> Disable CGO for thumb, we have a variable to select cgo
>
> Yeah, I don't think Go handles Thumb at all. Maybe we should set
> ARM_INSTRUCTION_SET to "arm" in goarch.bbclass?

I think we have a problem with dependencies. It is possibly a solution
but not sure it will work.

-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH v8 06/13] go-dep: Move bash dependency to -dev package

2017-09-13 Thread Matt Madison 
On Tue, Sep 12, 2017 at 12:21 PM, Khem Raj  wrote:
> On Tue, Sep 12, 2017 at 12:20 PM, Otavio Salvador
>  wrote:
>> On Tue, Sep 12, 2017 at 3:58 PM, Martin Jansa  wrote:
>>> Seems like this version was already picked to master-next, so probably
>>> better to leave as standalone change now.
>>>
>>> The version currently in master fails to build for arm with thumb enabled:
>>> http://errors.yoctoproject.org/Errors/Details/155765/
>>>
>>> Is it fixed somewhere in this new patchset?
>>>
>>> # github.com/golang/dep/cmd/dep
>>> TOPDIR/tmp-glibc/work/armv5te-oe-linux-gnueabi/go-dep/0.3.0-r0/recipe-sysroot-native/usr/lib/arm-oe-linux-gnueabi/go/pkg/tool/linux_amd64/link:
>>> R_ARM_THM_CALL, are you using -marm?
>>> WARNING: exit code 2 from a shell command.
>>> ERROR: Function failed: do_compile (log file is located at
>>> TOPDIR/tmp-glibc/work/armv5te-oe-linux-gnueabi/go-dep/0.3.0-r0/temp/log.do_compile.13531)
>>
>> No, it is not.
>>
>> It seems that Go, when using CGO, does not play nice with Thumb. Matt,
>> do you know if there is a known fix for it?
>
> Disable CGO for thumb, we have a variable to select cgo

Yeah, I don't think Go handles Thumb at all. Maybe we should set
ARM_INSTRUCTION_SET to "arm" in goarch.bbclass?

-Matt
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH v8 06/13] go-dep: Move bash dependency to -dev package

2017-09-12 Thread Khem Raj 
On Tue, Sep 12, 2017 at 12:20 PM, Otavio Salvador
 wrote:
> On Tue, Sep 12, 2017 at 3:58 PM, Martin Jansa  wrote:
>> Seems like this version was already picked to master-next, so probably
>> better to leave as standalone change now.
>>
>> The version currently in master fails to build for arm with thumb enabled:
>> http://errors.yoctoproject.org/Errors/Details/155765/
>>
>> Is it fixed somewhere in this new patchset?
>>
>> # github.com/golang/dep/cmd/dep
>> TOPDIR/tmp-glibc/work/armv5te-oe-linux-gnueabi/go-dep/0.3.0-r0/recipe-sysroot-native/usr/lib/arm-oe-linux-gnueabi/go/pkg/tool/linux_amd64/link:
>> R_ARM_THM_CALL, are you using -marm?
>> WARNING: exit code 2 from a shell command.
>> ERROR: Function failed: do_compile (log file is located at
>> TOPDIR/tmp-glibc/work/armv5te-oe-linux-gnueabi/go-dep/0.3.0-r0/temp/log.do_compile.13531)
>
> No, it is not.
>
> It seems that Go, when using CGO, does not play nice with Thumb. Matt,
> do you know if there is a known fix for it?

Disable CGO for thumb, we have a variable to select cgo
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH v8 06/13] go-dep: Move bash dependency to -dev package

2017-09-12 Thread Otavio Salvador 
On Tue, Sep 12, 2017 at 3:58 PM, Martin Jansa  wrote:
> Seems like this version was already picked to master-next, so probably
> better to leave as standalone change now.
>
> The version currently in master fails to build for arm with thumb enabled:
> http://errors.yoctoproject.org/Errors/Details/155765/
>
> Is it fixed somewhere in this new patchset?
>
> # github.com/golang/dep/cmd/dep
> TOPDIR/tmp-glibc/work/armv5te-oe-linux-gnueabi/go-dep/0.3.0-r0/recipe-sysroot-native/usr/lib/arm-oe-linux-gnueabi/go/pkg/tool/linux_amd64/link:
> R_ARM_THM_CALL, are you using -marm?
> WARNING: exit code 2 from a shell command.
> ERROR: Function failed: do_compile (log file is located at
> TOPDIR/tmp-glibc/work/armv5te-oe-linux-gnueabi/go-dep/0.3.0-r0/temp/log.do_compile.13531)

No, it is not.

It seems that Go, when using CGO, does not play nice with Thumb. Matt,
do you know if there is a known fix for it?

-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH v8 06/13] go-dep: Move bash dependency to -dev package

2017-09-12 Thread Martin Jansa 
Seems like this version was already picked to master-next, so probably
better to leave as standalone change now.

The version currently in master fails to build for arm with thumb enabled:
http://errors.yoctoproject.org/Errors/Details/155765/

Is it fixed somewhere in this new patchset?

# github.com/golang/dep/cmd/dep
TOPDIR/tmp-glibc/work/armv5te-oe-linux-gnueabi/go-dep/0.3.0-r0/recipe-sysroot-native/usr/lib/arm-oe-linux-gnueabi/go/pkg/tool/linux_amd64/link:
R_ARM_THM_CALL, are you using -marm?
WARNING: exit code 2 from a shell command.
ERROR: Function failed: do_compile (log file is located at
TOPDIR/tmp-glibc/work/armv5te-oe-linux-gnueabi/go-dep/0.3.0-r0/temp/log.do_compile.13531)


On Tue, Sep 12, 2017 at 3:32 PM, Otavio Salvador <
otavio.salva...@ossystems.com.br> wrote:

> On Tue, Sep 12, 2017 at 10:15 AM, Martin Jansa 
> wrote:
> > Doesn't this belong into:
> > [OE-core] [PATCH v8 03/13] go: split out go-runtime into separate recipe
> > where it packaging change was probably introduced?
>
> I can squash it; in fact the change was introduced on "[v8,05/13]
> go.bbclass: remove some xxx_FINAL variables". Not sure if it is better
> or worse in this case. What do you think?
>
> > Also just RFC question, would it make sense to use:
> >
> > VIRTUAL-RUNTIME_bash ?= "bash"
> > RDEPENDS_${PN}-dev += "${VIRTUAL-RUNTIME_bash}"
> >
> > instead of the bash dependency directly? If it's acceptable for oe-core
> I'll
> > create change to do it for all recipe (I don't mind waiting after 2.4 is
> > released).
> >
> > Because right now for reasons described in
> > https://bugzilla.yoctoproject.org/show_bug.cgi?id=9217 I need to do the
> > above +
> > RDEPENDS_${PN}-dev_remove = "bash"
> > for many recipes with many bbappends, for our distro where we RPROVIDE
> bash
> > by busybox, which is good enough for package manager, but QA error is
> still
> > shown in cases where the real bash is built before the component
> rdpenending
> > on it.
>
> I'd be fine with this. It does make sense to allow the replacement of bash.
>
> --
> Otavio Salvador O.S. Systems
> http://www.ossystems.com.brhttp://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH v8 06/13] go-dep: Move bash dependency to -dev package

2017-09-12 Thread Otavio Salvador 
On Tue, Sep 12, 2017 at 10:15 AM, Martin Jansa  wrote:
> Doesn't this belong into:
> [OE-core] [PATCH v8 03/13] go: split out go-runtime into separate recipe
> where it packaging change was probably introduced?

I can squash it; in fact the change was introduced on "[v8,05/13]
go.bbclass: remove some xxx_FINAL variables". Not sure if it is better
or worse in this case. What do you think?

> Also just RFC question, would it make sense to use:
>
> VIRTUAL-RUNTIME_bash ?= "bash"
> RDEPENDS_${PN}-dev += "${VIRTUAL-RUNTIME_bash}"
>
> instead of the bash dependency directly? If it's acceptable for oe-core I'll
> create change to do it for all recipe (I don't mind waiting after 2.4 is
> released).
>
> Because right now for reasons described in
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=9217 I need to do the
> above +
> RDEPENDS_${PN}-dev_remove = "bash"
> for many recipes with many bbappends, for our distro where we RPROVIDE bash
> by busybox, which is good enough for package manager, but QA error is still
> shown in cases where the real bash is built before the component rdpenending
> on it.

I'd be fine with this. It does make sense to allow the replacement of bash.

-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH v8 06/13] go-dep: Move bash dependency to -dev package

2017-09-12 Thread Martin Jansa 
Doesn't this belong into:
[OE-core] [PATCH v8 03/13] go: split out go-runtime into separate recipe
where it packaging change was probably introduced?

Also just RFC question, would it make sense to use:

VIRTUAL-RUNTIME_bash ?= "bash"
RDEPENDS_${PN}-dev += "${VIRTUAL-RUNTIME_bash}"

instead of the bash dependency directly? If it's acceptable for oe-core
I'll create change to do it for all recipe (I don't mind waiting after 2.4
is released).

Because right now for reasons described in
https://bugzilla.yoctoproject.org/show_bug.cgi?id=9217 I need to do the
above +
RDEPENDS_${PN}-dev_remove = "bash"
for many recipes with many bbappends, for our distro where we RPROVIDE bash
by busybox, which is good enough for package manager, but QA error is still
shown in cases where the real bash is built before the component
rdpenending on it.

Regards,


On Tue, Sep 12, 2017 at 2:50 PM, Otavio Salvador 
wrote:

> The src content has been moved to -dev package, so does the test
> routines. Fix the runtime dependency accordingly.
>
> Signed-off-by: Otavio Salvador 
> ---
>
> Changes in v8:
> - new patch
>
> Changes in v7: None
> Changes in v6: None
>
>  meta/recipes-devtools/go/go-dep_0.3.0.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/go/go-dep_0.3.0.bb
> b/meta/recipes-devtools/go/go-dep_0.3.0.bb
> index c65b4f7cb5..5e4544a104 100644
> --- a/meta/recipes-devtools/go/go-dep_0.3.0.bb
> +++ b/meta/recipes-devtools/go/go-dep_0.3.0.bb
> @@ -15,4 +15,4 @@ GO_INSTALL = "${GO_IMPORT}/cmd/dep"
>
>  INSANE_SKIP_${PN} += "ldflags"
>
> -RDEPENDS_${PN}-staticdev += "bash"
> +RDEPENDS_${PN}-dev += "bash"
> --
> 2.14.1
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH v8 06/13] go-dep: Move bash dependency to -dev package

2017-09-12 Thread Otavio Salvador 
The src content has been moved to -dev package, so does the test
routines. Fix the runtime dependency accordingly.

Signed-off-by: Otavio Salvador 
---

Changes in v8:
- new patch

Changes in v7: None
Changes in v6: None

 meta/recipes-devtools/go/go-dep_0.3.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/go/go-dep_0.3.0.bb 
b/meta/recipes-devtools/go/go-dep_0.3.0.bb
index c65b4f7cb5..5e4544a104 100644
--- a/meta/recipes-devtools/go/go-dep_0.3.0.bb
+++ b/meta/recipes-devtools/go/go-dep_0.3.0.bb
@@ -15,4 +15,4 @@ GO_INSTALL = "${GO_IMPORT}/cmd/dep"
 
 INSANE_SKIP_${PN} += "ldflags"
 
-RDEPENDS_${PN}-staticdev += "bash"
+RDEPENDS_${PN}-dev += "bash"
-- 
2.14.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core