Re: [OE-core][PATCH] dropbear: Enable x11 forwarding
On Mon, 25 Jul 2022 at 10:49, Ross Burton wrote: > > On 25 Jul 2022, at 04:11, Matt Johnston wrote: > > The upstream method for Dropbear configuration is #define entries in a > > localoptions.h file. default_options.h should be left untouched. Adding it > > to CFLAGS for configure would also work, as > > > > ./configure CFLAGS="-Os -Wall -DDROPBEAR_X11FWD=1” > > Perfect, thanks Matt! I've just sent a new version [1] using CFLAGS but I think I should have used localoptions.h instead as that will match the upstream configuration method. What do you think? Shall I change to localoptions.h instead? I think that should be a more elegant solution. [1] https://lore.kernel.org/all/20220927102904.722281-1-dan...@qtec.com/ > > Ross > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#171095): https://lists.openembedded.org/g/openembedded-core/message/171095 Mute This Topic: https://lists.openembedded.org/mt/92512561/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][PATCH] dropbear: Enable x11 forwarding
On 25 Jul 2022, at 04:11, Matt Johnston wrote: > The upstream method for Dropbear configuration is #define entries in a > localoptions.h file. default_options.h should be left untouched. Adding it > to CFLAGS for configure would also work, as > > ./configure CFLAGS="-Os -Wall -DDROPBEAR_X11FWD=1” Perfect, thanks Matt! Ross -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#168473): https://lists.openembedded.org/g/openembedded-core/message/168473 Mute This Topic: https://lists.openembedded.org/mt/92512561/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][PATCH] dropbear: Enable x11 forwarding
On Thu, 2022-07-21 at 09:12 +, Ross Burton wrote: > > On 20 Jul 2022, at 20:44, Daniel Gomez via lists.openembedded.org > > wrote: > > + > > file://0008-default_options-Enable-x11-forwarding.patch', '', d)}” > > This should be a PACKAGECONFIG instead of a forced on/off based on > DISTRO_FEATURES. > > Upstreaming a configure option to expose this as —enable-x-forwarding would > be great, but for now you can easily sed this file as needed based on the > value of PACKAGECONFIG. The upstream method for Dropbear configuration is #define entries in a localoptions.h file. default_options.h should be left untouched. Adding it to CFLAGS for configure would also work, as ./configure CFLAGS="-Os -Wall -DDROPBEAR_X11FWD=1" Cheers, Matt (Dropbear upstream) -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#168466): https://lists.openembedded.org/g/openembedded-core/message/168466 Mute This Topic: https://lists.openembedded.org/mt/92512561/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][PATCH] dropbear: Enable x11 forwarding
On Thu, 21 Jul 2022 at 11:13, Ross Burton wrote:
>
>
> > On 20 Jul 2022, at 20:44, Daniel Gomez via lists.openembedded.org
> > wrote:
> > + ${@bb.utils.contains('DISTRO_FEATURES', 'x11', ' \
> > +
> > file://0007-Fix-X11-build-failure-use-DROPBEAR_PRIO_LOWDELAY.patch \
>
> This patch should be always applied, as it doesn’t cause any breakage when
> applied if not used. Patches which are conditional tend to cause breakage
> when they’re not always applied.
>
> > +file://0008-default_options-Enable-x11-forwarding.patch',
> > '', d)}”
>
> This should be a PACKAGECONFIG instead of a forced on/off based on
> DISTRO_FEATURES.
>
> Upstreaming a configure option to expose this as —enable-x-forwarding would
> be great, but for now you can easily sed this file as needed based on the
> value of PACKAGECONFIG.
Thanks Ross for the review. I'll send a v2 with the changes and look
into the upstream option.
>
> Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#168383):
https://lists.openembedded.org/g/openembedded-core/message/168383
Mute This Topic: https://lists.openembedded.org/mt/92512561/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][PATCH] dropbear: Enable x11 forwarding
> On 20 Jul 2022, at 20:44, Daniel Gomez via lists.openembedded.org
> wrote:
> + ${@bb.utils.contains('DISTRO_FEATURES', 'x11', ' \
> +
> file://0007-Fix-X11-build-failure-use-DROPBEAR_PRIO_LOWDELAY.patch \
This patch should be always applied, as it doesn’t cause any breakage when
applied if not used. Patches which are conditional tend to cause breakage when
they’re not always applied.
> +file://0008-default_options-Enable-x11-forwarding.patch',
> '', d)}”
This should be a PACKAGECONFIG instead of a forced on/off based on
DISTRO_FEATURES.
Upstreaming a configure option to expose this as —enable-x-forwarding would be
great, but for now you can easily sed this file as needed based on the value of
PACKAGECONFIG.
Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#168382):
https://lists.openembedded.org/g/openembedded-core/message/168382
Mute This Topic: https://lists.openembedded.org/mt/92512561/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
