Re: [OE-core] [PATCH 0/6] RFC Distro config changes
2011/5/10 Richard Purdie > From: Richard Purdie > > As discussed, we want to make OE-Core usable with no distro set. This patch > series > makes some big steps towards that goal. I'd be interested in feedback on > whether it > does the right things and would be usable by others. > > The key is the inclusion of a distro/defaultsetup.conf file by bitbake.conf > and > in turn this pulls in a variety of other common include files which can > likely be > shared. Any point of this cycle can be overridden by another layer so its > totally > customisable. I'd encourage users to use the pieces they can where possible > so we > all share best practises but obviously people have choice. > > I did dump a load of "default" variables into default-distrovars.inc, I'm > not > calling that file finished, I just had to draw the line somewhere and start > a > discussion about this :) > > Also, I'm aware there are still a few poky-* files in > meta/conf/distro/include. > Some of these can just be deleted, others renamed tcmode-* and I'll take > care > of that. I'll also delete the poky.conf file since it no longer contains > anything > required to make OE-Core build as far as I know (wider testing needed). > > Pull URL: git://git.openembedded.org/openembedded-core-contrib > Branch: rpurdie/distro > Browse: > http://git.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rpurdie/distro > THere is something wrong with git. If I browse to the 2nd url I get: Bad object id: rpurdie/distro going to git and navigating to the branch gives the same result. Anyway, although I am not able to review the changes on git, a thumbs up for the initiative. Frans ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/6] RFC Distro config changes
On Tue, 2011-05-10 at 16:05 +0200, Frans Meulenbroeks wrote: > > Pull URL: git://git.openembedded.org/openembedded-core-contrib > > Branch: rpurdie/distro > > Browse: > > http://git.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rpurdie/distro > > > > THere is something wrong with git. > If I browse to the 2nd url I get: > Bad object id: rpurdie/distro > going to git and navigating to the branch gives the same result. > > Anyway, although I am not able to review the changes on git, a thumbs up > for the initiative. I've noticed this happening with branches on that repository for the past couple of days, its not just this branch. Khem/Cliff/Tom: Who might be able to look into and help fix this? Frans: You can still checkout the branch and look, its just the web interface that has issues. Cheers, Richard ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/6] RFC Distro config changes
Op 10 mei 2011, om 16:00 heeft Richard Purdie het volgende geschreven: > From: Richard Purdie > > As discussed, we want to make OE-Core usable with no distro set. This patch > series > makes some big steps towards that goal. I'd be interested in feedback on > whether it > does the right things and would be usable by others. > > The key is the inclusion of a distro/defaultsetup.conf file by bitbake.conf > and > in turn this pulls in a variety of other common include files which can > likely be > shared. Any point of this cycle can be overridden by another layer so its > totally > customisable. I'd encourage users to use the pieces they can where possible > so we > all share best practises but obviously people have choice. > > I did dump a load of "default" variables into default-distrovars.inc, I'm not > calling that file finished, I just had to draw the line somewhere and start a > discussion about this :) For angstrom we had to change a few things, have a look at http://git.angstrom-distribution.org/cgi-bin/cgit.cgi/meta-angstrom/tree/conf/distro/include/angstrom-core-tweaks.inc , specifically lines 12-18 and 53-54 regards, Koen ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/6] RFC Distro config changes
On Tue, 2011-05-10 at 17:58 +0200, Koen Kooi wrote: > Op 10 mei 2011, om 16:00 heeft Richard Purdie het volgende geschreven: > > > From: Richard Purdie > > > > As discussed, we want to make OE-Core usable with no distro set. This patch > > series > > makes some big steps towards that goal. I'd be interested in feedback on > > whether it > > does the right things and would be usable by others. > > > > The key is the inclusion of a distro/defaultsetup.conf file by bitbake.conf > > and > > in turn this pulls in a variety of other common include files which can > > likely be > > shared. Any point of this cycle can be overridden by another layer so its > > totally > > customisable. I'd encourage users to use the pieces they can where possible > > so we > > all share best practises but obviously people have choice. > > > > I did dump a load of "default" variables into default-distrovars.inc, I'm > > not > > calling that file finished, I just had to draw the line somewhere and start > > a > > discussion about this :) > > For angstrom we had to change a few things, have a look at > http://git.angstrom-distribution.org/cgi-bin/cgit.cgi/meta-angstrom/tree/conf/distro/include/angstrom-core-tweaks.inc > , specifically lines 12-18 and 53-54 I don't understand what TOOLCHAIN_PATH and TOOLCHAIN_SYSPATH do, I can't find any reference to them in OECore. For the uclibc bits, I'm proposing to add: +DEPLOY_DIR_append = "-uclibc" +STAGING_DIR_TARGET_append = "-uclibc" +STAGING_DIR_HOST_append = "-uclibc" +SSTATE_MANIFESTS_append = "-uclibc" to tclibc-uclibc.inc. For the SDK/TOOLCHAIN bits, I need to have a close look at the SDK and figure out what the implications are there as I want to ensure that they can all be parallel installed as well as being in separate tarballs but its something we need to look at. Cheers, Richard ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/6] RFC Distro config changes
Op 11 mei 2011, om 11:45 heeft Richard Purdie het volgende geschreven:
> On Tue, 2011-05-10 at 17:58 +0200, Koen Kooi wrote:
>> Op 10 mei 2011, om 16:00 heeft Richard Purdie het volgende geschreven:
>>
>>> From: Richard Purdie
>>>
>>> As discussed, we want to make OE-Core usable with no distro set. This patch
>>> series
>>> makes some big steps towards that goal. I'd be interested in feedback on
>>> whether it
>>> does the right things and would be usable by others.
>>>
>>> The key is the inclusion of a distro/defaultsetup.conf file by bitbake.conf
>>> and
>>> in turn this pulls in a variety of other common include files which can
>>> likely be
>>> shared. Any point of this cycle can be overridden by another layer so its
>>> totally
>>> customisable. I'd encourage users to use the pieces they can where possible
>>> so we
>>> all share best practises but obviously people have choice.
>>>
>>> I did dump a load of "default" variables into default-distrovars.inc, I'm
>>> not
>>> calling that file finished, I just had to draw the line somewhere and start
>>> a
>>> discussion about this :)
>>
>> For angstrom we had to change a few things, have a look at
>> http://git.angstrom-distribution.org/cgi-bin/cgit.cgi/meta-angstrom/tree/conf/distro/include/angstrom-core-tweaks.inc
>> , specifically lines 12-18 and 53-54
>
> I don't understand what TOOLCHAIN_PATH and TOOLCHAIN_SYSPATH do, I can't
> find any reference to them in OECore.
They are for torublesome recipes combined with external toolchains. Denys,
could you enlighten us a bit more on those?
> For the uclibc bits, I'm proposing
> to add:
>
> +DEPLOY_DIR_append = "-uclibc"
> +STAGING_DIR_TARGET_append = "-uclibc"
> +STAGING_DIR_HOST_append = "-uclibc"
> +SSTATE_MANIFESTS_append = "-uclibc"
>
> to tclibc-uclibc.inc.
Can we use _append_libc-uclibc = "uclibc" or even plain ${TCLIBC} in a generic
include file? That would be a lot more readable and fix glibc vs eglibc.
> For the SDK/TOOLCHAIN bits, I need to have a close look at the SDK and
> figure out what the implications are there as I want to ensure that they
> can all be parallel installed as well as being in separate tarballs but
> its something we need to look at.
I needed 'armv5te' and 'armv7a' in the tarball name, so that's how this is
derived. It matched the OE names, but Khem found some bugs and changed it a
little.
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/6] RFC Distro config changes
On Wed, 2011-05-11 at 12:13 +0200, Koen Kooi wrote:
> Op 11 mei 2011, om 11:45 heeft Richard Purdie het volgende geschreven:
> > For the uclibc bits, I'm proposing
> > to add:
> >
> > +DEPLOY_DIR_append = "-uclibc"
> > +STAGING_DIR_TARGET_append = "-uclibc"
> > +STAGING_DIR_HOST_append = "-uclibc"
> > +SSTATE_MANIFESTS_append = "-uclibc"
> >
> > to tclibc-uclibc.inc.
>
> Can we use _append_libc-uclibc = "uclibc" or even plain ${TCLIBC} in a
> generic include file? That would be a lot more readable and fix glibc
> vs eglibc.
Changing uclibc around is ok as its not something that has worked well
in with OE-Core for a while. What I'm trying to avoid is having to bump
all the versions of the sstate files, the sysroot layout and associated
version numbers which is what would have to happen if we change the
eglibc layout :(.
Obviously, if angstrom switches layout its pain for you though so I
suspect someone loses with this either way :/.
> > For the SDK/TOOLCHAIN bits, I need to have a close look at the SDK and
> > figure out what the implications are there as I want to ensure that they
> > can all be parallel installed as well as being in separate tarballs but
> > its something we need to look at.
>
> I needed 'armv5te' and 'armv7a' in the tarball name, so that's how
> this is derived. It matched the OE names, but Khem found some bugs and
> changed it a little.
Makes sense and I see the need, I just want to ensure the tarballs we
have can be parallel installed.
Cheers,
Richard
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/6] RFC Distro config changes
Op 11 mei 2011, om 12:54 heeft Richard Purdie het volgende geschreven:
> On Wed, 2011-05-11 at 12:13 +0200, Koen Kooi wrote:
>> Op 11 mei 2011, om 11:45 heeft Richard Purdie het volgende geschreven:
>>> For the uclibc bits, I'm proposing
>>> to add:
>>>
>>> +DEPLOY_DIR_append = "-uclibc"
>>> +STAGING_DIR_TARGET_append = "-uclibc"
>>> +STAGING_DIR_HOST_append = "-uclibc"
>>> +SSTATE_MANIFESTS_append = "-uclibc"
>>>
>>> to tclibc-uclibc.inc.
>>
>> Can we use _append_libc-uclibc = "uclibc" or even plain ${TCLIBC} in a
>> generic include file? That would be a lot more readable and fix glibc
>> vs eglibc.
>
> Changing uclibc around is ok as its not something that has worked well
> in with OE-Core for a while. What I'm trying to avoid is having to bump
> all the versions of the sstate files, the sysroot layout and associated
> version numbers which is what would have to happen if we change the
> eglibc layout :(.
>
> Obviously, if angstrom switches layout its pain for you though so I
> suspect someone loses with this either way :/.
I would think consistency is best, so either set always append TCLIBC or never.
This isn't a lot more pain than the '-' to '_' change in machine names a while
ago. And that even had runtime pains!
regards,
Koen
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/6] RFC Distro config changes
On Tue, 2011-05-10 at 15:00 +0100, Richard Purdie wrote: > From: Richard Purdie > > As discussed, we want to make OE-Core usable with no distro set. This patch > series > makes some big steps towards that goal. I'd be interested in feedback on > whether it > does the right things and would be usable by others. > > The key is the inclusion of a distro/defaultsetup.conf file by bitbake.conf > and > in turn this pulls in a variety of other common include files which can > likely be > shared. Any point of this cycle can be overridden by another layer so its > totally > customisable. I'd encourage users to use the pieces they can where possible > so we > all share best practises but obviously people have choice. > > I did dump a load of "default" variables into default-distrovars.inc, I'm not > calling that file finished, I just had to draw the line somewhere and start a > discussion about this :) > > Also, I'm aware there are still a few poky-* files in > meta/conf/distro/include. > Some of these can just be deleted, others renamed tcmode-* and I'll take care > of that. I'll also delete the poky.conf file since it no longer contains > anything > required to make OE-Core build as far as I know (wider testing needed). > > Pull URL: git://git.openembedded.org/openembedded-core-contrib > Branch: rpurdie/distro > Browse: > http://git.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rpurdie/distro > > Richard Purdie (6): > Drop poky-floating-revisions.inc, poky-bleeding.conf and > poky-lsb.conf > bitbake.conf: Include the new default-providers.inc and > default-versions.inc files > distro: Add defaultsetup.conf, a set of default configuration > providing sane overrridable default for commonly used options > machine/qemu: Add qemu-config as an essential machine speicfic > dependency and drop specific distro config > conf/distro/include/default-distrovars.inc: Create set of default > 'distro' variable values > preferred-xorg-versions.inc: Drop this, it makes no sense given we > only have one version of these recipes I've taken feedback on board, tweaked the series and then merged it. My reasoning is that whilst this might not be 100% perfect in every way, it moves us a lot closer to where we want to be. We were going to start seeing patch conflicts if it was out of tree for too long and that didn't seem worthwhile. Cheers, Richard ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/6] RFC Distro config changes
On Wed, May 11, 2011 at 2:45 AM, Richard Purdie wrote: > On Tue, 2011-05-10 at 17:58 +0200, Koen Kooi wrote: >> Op 10 mei 2011, om 16:00 heeft Richard Purdie het volgende geschreven: >> >> > From: Richard Purdie >> > >> > As discussed, we want to make OE-Core usable with no distro set. This >> > patch series >> > makes some big steps towards that goal. I'd be interested in feedback on >> > whether it >> > does the right things and would be usable by others. >> > >> > The key is the inclusion of a distro/defaultsetup.conf file by >> > bitbake.conf and >> > in turn this pulls in a variety of other common include files which can >> > likely be >> > shared. Any point of this cycle can be overridden by another layer so its >> > totally >> > customisable. I'd encourage users to use the pieces they can where >> > possible so we >> > all share best practises but obviously people have choice. >> > >> > I did dump a load of "default" variables into default-distrovars.inc, I'm >> > not >> > calling that file finished, I just had to draw the line somewhere and >> > start a >> > discussion about this :) >> >> For angstrom we had to change a few things, have a look at >> http://git.angstrom-distribution.org/cgi-bin/cgit.cgi/meta-angstrom/tree/conf/distro/include/angstrom-core-tweaks.inc >> , specifically lines 12-18 and 53-54 > > I don't understand what TOOLCHAIN_PATH and TOOLCHAIN_SYSPATH do, I can't > find any reference to them in OECore. For the uclibc bits, I'm proposing > to add: > > +DEPLOY_DIR_append = "-uclibc" > +STAGING_DIR_TARGET_append = "-uclibc" > +STAGING_DIR_HOST_append = "-uclibc" > +SSTATE_MANIFESTS_append = "-uclibc" > this wont work. Since virtclasses empty out some of these vars e.g. native resets STAGING_DIR_HOST but this will still append -uclibc to it since append happens at the end > to tclibc-uclibc.inc. > > For the SDK/TOOLCHAIN bits, I need to have a close look at the SDK and > figure out what the implications are there as I want to ensure that they > can all be parallel installed as well as being in separate tarballs but > its something we need to look at. > > Cheers, > > Richard > > > > ___ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/6] RFC Distro config changes
On Wed, May 11, 2011 at 10:30, Richard Purdie wrote: > I've taken feedback on board, tweaked the series and then merged it. My > reasoning is that whilst this might not be 100% perfect in every way, it > moves us a lot closer to where we want to be. We were going to start > seeing patch conflicts if it was out of tree for too long and that > didn't seem worthwhile. I have expected at least another review cycle since this is a huge change and potential to change a lot of stuff for users... -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/6] RFC Distro config changes
On (11/05/11 13:45), Koen Kooi wrote:
>
> Op 11 mei 2011, om 12:54 heeft Richard Purdie het volgende geschreven:
>
> > On Wed, 2011-05-11 at 12:13 +0200, Koen Kooi wrote:
> >> Op 11 mei 2011, om 11:45 heeft Richard Purdie het volgende geschreven:
> >>> For the uclibc bits, I'm proposing
> >>> to add:
> >>>
> >>> +DEPLOY_DIR_append = "-uclibc"
> >>> +STAGING_DIR_TARGET_append = "-uclibc"
> >>> +STAGING_DIR_HOST_append = "-uclibc"
> >>> +SSTATE_MANIFESTS_append = "-uclibc"
> >>>
> >>> to tclibc-uclibc.inc.
> >>
> >> Can we use _append_libc-uclibc = "uclibc" or even plain ${TCLIBC} in a
> >> generic include file? That would be a lot more readable and fix glibc
> >> vs eglibc.
> >
> > Changing uclibc around is ok as its not something that has worked well
> > in with OE-Core for a while. What I'm trying to avoid is having to bump
> > all the versions of the sstate files, the sysroot layout and associated
> > version numbers which is what would have to happen if we change the
> > eglibc layout :(.
> >
> > Obviously, if angstrom switches layout its pain for you though so I
> > suspect someone loses with this either way :/.
>
> I would think consistency is best, so either set always append TCLIBC or
> never. This isn't a lot more pain than the '-' to '_' change in machine names
> a while ago. And that even had runtime pains!
>
I would agree we should always append TCLIBC
> regards,
>
> Koen
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
--
-Khem
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/6] RFC Distro config changes
On (15/05/11 13:22), Khem Raj wrote:
> On Wed, May 11, 2011 at 2:45 AM, Richard Purdie
> wrote:
> > On Tue, 2011-05-10 at 17:58 +0200, Koen Kooi wrote:
> > +DEPLOY_DIR_append = "-uclibc"
> > +STAGING_DIR_TARGET_append = "-uclibc"
> > +STAGING_DIR_HOST_append = "-uclibc"
> > +SSTATE_MANIFESTS_append = "-uclibc"
> >
>
> this wont work. Since virtclasses empty out some of these vars e.g. native
> resets STAGING_DIR_HOST but this will still append -uclibc to it since append
> happens at the end
Something like below can serve us better
--- a/meta/conf/distro/include/tclibc-uclibc.inc
+++ b/meta/conf/distro/include/tclibc-uclibc.inc
@@ -21,10 +21,10 @@ CXXFLAGS += "-fvisibility-inlines-hidden"
IMAGE_LINGUAS = ""
DEPLOY_DIR_IMAGE = "${TMPDIR}/deploy/images"
-DEPLOY_DIR_append = "-uclibc"
-STAGING_DIR_TARGET_append = "-uclibc"
-STAGING_DIR_HOST_append = "-uclibc"
-SSTATE_MANIFESTS_append = "-uclibc"
+DEPLOY_DIR_append = "${@["-uclibc", ""][oe.utils.inherits(d, 'native',
'nativesdk')]}"
+STAGING_DIR_TARGET_append = "${@["-uclibc", ""][oe.utils.inherits(d, 'native',
'nativesdk')]}"
+STAGING_DIR_HOST_append = "${@["-uclibc", ""][oe.utils.inherits(d, 'native',
'nativesdk')]}"
+SSTATE_MANIFESTS_append = "${@["-uclibc", ""][oe.utils.inherits(d, 'native',
'nativesdk')]}"
LIBC_DEPENDENCIES = "\
uclibc \
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/6] RFC Distro config changes
On Sun, 2011-05-15 at 17:27 -0300, Otavio Salvador wrote: > On Wed, May 11, 2011 at 10:30, Richard Purdie > wrote: > > I've taken feedback on board, tweaked the series and then merged it. My > > reasoning is that whilst this might not be 100% perfect in every way, it > > moves us a lot closer to where we want to be. We were going to start > > seeing patch conflicts if it was out of tree for too long and that > > didn't seem worthwhile. > > I have expected at least another review cycle since this is a huge > change and potential to change a lot of stuff for users... Its a process of iterative improvement. I'm not calling what is there now 100% complete, just a lot better than what preceded it. If there are further changes needed, lets discuss them! :) Cheers, Richard ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
