Re: [OE-core] [RFC PATCH 1/1] classes: add workdir_save class
On 10/07/2020 5:02 am, Peter Kjellerstedt wrote: >Richard Purdie wrote: Seems like a useful idea. I think the name may need "failed" in the name to make it clearer what it does. We also need a section for the classes chapter in the manual. As another data point, OEQA is using OEQA_DEBUGGING_SAVED_OUTPUT to trigger saving information for reproducible builds... How about "save_workdir_on_failure.bbclass"? I'd like to keep the name short if possible, it'll end up in the variable names as well. Thinking ahead we might want to save other information in future beyond the workdir, so we could possibly drop that from the name. What about "failure_save" or "failure_saver"? Also, with underscores or without? Paul -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#140487): https://lists.openembedded.org/g/openembedded-core/message/140487 Mute This Topic: https://lists.openembedded.org/mt/75382316/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [RFC PATCH 1/1] classes: add workdir_save class
> -Original Message- > From: openembedded-core@lists.openembedded.org c...@lists.openembedded.org> On Behalf Of Richard Purdie > Sent: den 8 juli 2020 20:12 > To: Paul Eggleton ; openembedded- > c...@lists.openembedded.org > Subject: Re: [OE-core] [RFC PATCH 1/1] classes: add workdir_save class > > On Wed, 2020-07-08 at 11:02 -0700, Paul Eggleton wrote: > > If you are running your builds inside an environment where you don't > > have access to the build tree (e.g. an autobuilder where you can only > > download final artifacts such as images), then debugging build > > failures > > can be difficult - you can't examine log files, the source tree or > > output > > files. When enabled, this class triggers on task failure and saves a > > tarball of the work directory for the task's recipe and puts it in a > > configurable location, where it can be picked up by a separate > > process > > and made available as a downloadable artifact. > > > > Signed-off-by: Paul Eggleton > > Seems like a useful idea. I think the name may need "failed" in the > name to make it clearer what it does. We also need a section for the > classes chapter in the manual. > > As another data point, OEQA is using OEQA_DEBUGGING_SAVED_OUTPUT to > trigger saving information for reproducible builds... > > Cheers, > > Richard How about "save_workdir_on_failure.bbclass"? //Peter -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#140486): https://lists.openembedded.org/g/openembedded-core/message/140486 Mute This Topic: https://lists.openembedded.org/mt/75382316/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [RFC PATCH 1/1] classes: add workdir_save class
On Wed, 2020-07-08 at 11:02 -0700, Paul Eggleton wrote: > If you are running your builds inside an environment where you don't > have access to the build tree (e.g. an autobuilder where you can only > download final artifacts such as images), then debugging build > failures > can be difficult - you can't examine log files, the source tree or > output > files. When enabled, this class triggers on task failure and saves a > tarball of the work directory for the task's recipe and puts it in a > configurable location, where it can be picked up by a separate > process > and made available as a downloadable artifact. > > Signed-off-by: Paul Eggleton Seems like a useful idea. I think the name may need "failed" in the name to make it clearer what it does. We also need a section for the classes chapter in the manual. As another data point, OEQA is using OEQA_DEBUGGING_SAVED_OUTPUT to trigger saving information for reproducible builds... Cheers, Richard -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#140429): https://lists.openembedded.org/g/openembedded-core/message/140429 Mute This Topic: https://lists.openembedded.org/mt/75382316/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
