[oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
This reduces amount of tasks for bootstrap-image from around 3400 to
around 1600 for jlime.
Signed-off-by: Filip Zyzniewski
---
recipes/tasks/task-base.bb |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/recipes/tasks/task-base.bb b/recipes/tasks/task-base.bb
index 32d871d..c8d6df7 100644
--- a/recipes/tasks/task-base.bb
+++ b/recipes/tasks/task-base.bb
@@ -1,5 +1,5 @@
DESCRIPTION = "Merge machine and distro options to create a basic machine
task/package"
-PR = "r92"
+PR = "r93"
inherit task
@@ -31,8 +31,8 @@ PACKAGES = ' \
${@base_contains("MACHINE_FEATURES", "redboot",
"task-base-redboot", "",d)} \
${@base_contains("MACHINE_FEATURES", "apex", "task-base-apex",
"",d)} \
\
-task-base-bluetooth \
-task-base-wifi \
+${@base_contains("MACHINE_FEATURES", "bluetooth",
"task-base-bluetooth", "",d)} \
+${@base_contains("MACHINE_FEATURES", "wifi", "task-base-wifi",
"",d)} \
\
${@base_contains("DISTRO_FEATURES", "cramfs", "task-base-cramfs",
"", d)} \
${@base_contains("DISTRO_FEATURES", "ipsec", "task-base-ipsec",
"", d)} \
--
1.7.1
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
On 02/07/2011 03:13 PM, Filip Zyzniewski wrote:
This reduces amount of tasks for bootstrap-image from around 3400 to
around 1600 for jlime.
Signed-off-by: Filip Zyzniewski
Can some of the other distro folks chime in here?
---
recipes/tasks/task-base.bb |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/recipes/tasks/task-base.bb b/recipes/tasks/task-base.bb
index 32d871d..c8d6df7 100644
--- a/recipes/tasks/task-base.bb
+++ b/recipes/tasks/task-base.bb
@@ -1,5 +1,5 @@
DESCRIPTION = "Merge machine and distro options to create a basic machine
task/package"
-PR = "r92"
+PR = "r93"
inherit task
@@ -31,8 +31,8 @@ PACKAGES = ' \
${@base_contains("MACHINE_FEATURES", "redboot", "task-base-redboot",
"",d)} \
${@base_contains("MACHINE_FEATURES", "apex", "task-base-apex",
"",d)} \
\
-task-base-bluetooth \
-task-base-wifi \
+${@base_contains("MACHINE_FEATURES", "bluetooth", "task-base-bluetooth",
"",d)} \
+${@base_contains("MACHINE_FEATURES", "wifi", "task-base-wifi",
"",d)} \
\
${@base_contains("DISTRO_FEATURES", "cramfs", "task-base-cramfs",
"", d)} \
${@base_contains("DISTRO_FEATURES", "ipsec", "task-base-ipsec",
"", d)} \
--
Tom Rini
Mentor Graphics Corporation
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
On 2/8/2011 11:29 AM, Tom Rini wrote:
> On 02/07/2011 03:13 PM, Filip Zyzniewski wrote:
>> This reduces amount of tasks for bootstrap-image from around 3400 to
>> around 1600 for jlime.
>>
>> Signed-off-by: Filip Zyzniewski
>
> Can some of the other distro folks chime in here?
Er, yes. The commit message lacks information on how this affects other
distros.
I'm just guessing, but I expect that this commit will require that
distros expecting bluetooth and wifi support will need to ensure that
the correct set of features are defined. Is that a correct assumption?
-Mike (mwester)
>> ---
>> recipes/tasks/task-base.bb |6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/recipes/tasks/task-base.bb b/recipes/tasks/task-base.bb
>> index 32d871d..c8d6df7 100644
>> --- a/recipes/tasks/task-base.bb
>> +++ b/recipes/tasks/task-base.bb
>> @@ -1,5 +1,5 @@
>> DESCRIPTION = "Merge machine and distro options to create a basic
>> machine task/package"
>> -PR = "r92"
>> +PR = "r93"
>>
>> inherit task
>>
>> @@ -31,8 +31,8 @@ PACKAGES = ' \
>> ${@base_contains("MACHINE_FEATURES", "redboot",
>> "task-base-redboot", "",d)} \
>> ${@base_contains("MACHINE_FEATURES", "apex",
>> "task-base-apex", "",d)} \
>> \
>> -task-base-bluetooth \
>> -task-base-wifi \
>> +${@base_contains("MACHINE_FEATURES", "bluetooth",
>> "task-base-bluetooth", "",d)} \
>> +${@base_contains("MACHINE_FEATURES", "wifi",
>> "task-base-wifi", "",d)} \
>> \
>> ${@base_contains("DISTRO_FEATURES", "cramfs",
>> "task-base-cramfs", "", d)} \
>> ${@base_contains("DISTRO_FEATURES", "ipsec",
>> "task-base-ipsec", "", d)} \
>
>
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 08-02-11 18:29, Tom Rini wrote:
> On 02/07/2011 03:13 PM, Filip Zyzniewski wrote:
>> This reduces amount of tasks for bootstrap-image from around 3400 to
>> around 1600 for jlime.
>>
>> Signed-off-by: Filip Zyzniewski
>
> Can some of the other distro folks chime in here?
Yeah, this patch is wrong, since task-base is supposed to drag in bt and
wifi when it's available which includes usb, pci, serial, etc.
>
>> ---
>> recipes/tasks/task-base.bb |6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/recipes/tasks/task-base.bb b/recipes/tasks/task-base.bb
>> index 32d871d..c8d6df7 100644
>> --- a/recipes/tasks/task-base.bb
>> +++ b/recipes/tasks/task-base.bb
>> @@ -1,5 +1,5 @@
>> DESCRIPTION = "Merge machine and distro options to create a basic
>> machine task/package"
>> -PR = "r92"
>> +PR = "r93"
>>
>> inherit task
>>
>> @@ -31,8 +31,8 @@ PACKAGES = ' \
>> ${@base_contains("MACHINE_FEATURES", "redboot",
>> "task-base-redboot", "",d)} \
>> ${@base_contains("MACHINE_FEATURES", "apex",
>> "task-base-apex", "",d)} \
>> \
>> -task-base-bluetooth \
>> -task-base-wifi \
>> +${@base_contains("MACHINE_FEATURES", "bluetooth",
>> "task-base-bluetooth", "",d)} \
>> +${@base_contains("MACHINE_FEATURES", "wifi",
>> "task-base-wifi", "",d)} \
>> \
>> ${@base_contains("DISTRO_FEATURES", "cramfs",
>> "task-base-cramfs", "", d)} \
>> ${@base_contains("DISTRO_FEATURES", "ipsec",
>> "task-base-ipsec", "", d)} \
>
>
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFNUYoQMkyGM64RGpERAuFAAJ9Y5jiml8NdBJpg5XmD7b8BlwjjFQCfXL8H
xuKrNII4OscMLUu/S2dAejQ=
=j2V5
-END PGP SIGNATURE-
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
> On 08-02-11 18:29, Tom Rini wrote: > Yeah, this patch is wrong, since task-base is supposed to drag in bt and > wifi when it's available which includes usb, pci, serial, etc. Shouldn't these optional devices be handled by packages from feed rather than the bootstrap image? bye, Filip Zyzniewski ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08-02-11 21:39, Filip Zyzniewski wrote: >> On 08-02-11 18:29, Tom Rini wrote: >> Yeah, this patch is wrong, since task-base is supposed to drag in bt and >> wifi when it's available which includes usb, pci, serial, etc. > > Shouldn't these optional devices be handled by packages from feed > rather than the bootstrap image? Kinda hard to get to the feeds without networking -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (Darwin) iD8DBQFNUa/aMkyGM64RGpERAqYsAJ44XiL+R96DWkjusw3v9T/t4kY3VwCdGm5v a+5CUIz9C/LyfQxRo24eCHs= =eFc0 -END PGP SIGNATURE- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
Hi Koen, On 08/02/2011 19:23, Koen Kooi wrote: On 08-02-11 18:29, Tom Rini wrote: On 02/07/2011 03:13 PM, Filip Zyzniewski wrote: This reduces amount of tasks for bootstrap-image from around 3400 to around 1600 for jlime. Signed-off-by: Filip Zyzniewski Can some of the other distro folks chime in here? Yeah, this patch is wrong, since task-base is supposed to drag in bt and wifi when it's available which includes usb, pci, serial, etc. what would be the correct way to disable inclusion of bt & wifi in the image ? Thanks, Eric ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
On 2/8/11, Koen Kooi wrote: > Kinda hard to get to the feeds without networking True, but couldn't we let the distro maintainers decide about this? For example we at jlime know that feeds will be fetched via wifi and we do not need bluetooth in the bootstrap image. bye, Filip Zyzniewski ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
On 02/08/2011 02:04 PM, Koen Kooi wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08-02-11 21:39, Filip Zyzniewski wrote: On 08-02-11 18:29, Tom Rini wrote: Yeah, this patch is wrong, since task-base is supposed to drag in bt and wifi when it's available which includes usb, pci, serial, etc. Shouldn't these optional devices be handled by packages from feed rather than the bootstrap image? Kinda hard to get to the feeds without networking So if I follow what you're saying, since BT/WiFi can be USB dongles (or PCI cards or otherwise plug-in IO) they need to exist all the time. Maybe we just need to also add in a line or two for usbhost (and pci) saying "Make common USB I/O also work" ? -- Tom Rini Mentor Graphics Corporation ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
On 02/08/2011 02:25 PM, Tom Rini wrote: On 02/08/2011 02:04 PM, Koen Kooi wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08-02-11 21:39, Filip Zyzniewski wrote: On 08-02-11 18:29, Tom Rini wrote: Yeah, this patch is wrong, since task-base is supposed to drag in bt and wifi when it's available which includes usb, pci, serial, etc. Shouldn't these optional devices be handled by packages from feed rather than the bootstrap image? Kinda hard to get to the feeds without networking So if I follow what you're saying, since BT/WiFi can be USB dongles (or PCI cards or otherwise plug-in IO) they need to exist all the time. Maybe we just need to also add in a line or two for usbhost (and pci) saying "Make common USB I/O also work" ? ... along with a distro feature that means "Make common $bus I/O also work" ? -- Tom Rini Mentor Graphics Corporation ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08-02-11 22:08, Eric Bénard wrote: > Hi Koen, > > On 08/02/2011 19:23, Koen Kooi wrote: >> On 08-02-11 18:29, Tom Rini wrote: >>> On 02/07/2011 03:13 PM, Filip Zyzniewski wrote: This reduces amount of tasks for bootstrap-image from around 3400 to around 1600 for jlime. Signed-off-by: Filip Zyzniewski >>> >>> Can some of the other distro folks chime in here? >> >> Yeah, this patch is wrong, since task-base is supposed to drag in bt and >> wifi when it's available which includes usb, pci, serial, etc. >> > what would be the correct way to disable inclusion of bt & wifi in the > image ? Use a different task, nobody is forcing you to use task-base -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (Darwin) iD8DBQFNUcCiMkyGM64RGpERAir3AJ9N99dAXyxCwyVf3DIItmNJtONBQQCfUMJe /h0lUuBPIALDkdQRjCE/+uU= =dvaK -END PGP SIGNATURE- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
On 08/02/2011 23:16, Koen Kooi wrote: On 08-02-11 22:08, Eric Bénard wrote: what would be the correct way to disable inclusion of bt& wifi in the image ? Use a different task, nobody is forcing you to use task-base ok that's indeed a solution ;-) Eric ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
On 09/02/11 07:23, Koen Kooi wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 08-02-11 18:29, Tom Rini wrote:
On 02/07/2011 03:13 PM, Filip Zyzniewski wrote:
This reduces amount of tasks for bootstrap-image from around 3400 to
around 1600 for jlime.
Signed-off-by: Filip Zyzniewski
Can some of the other distro folks chime in here?
Yeah, this patch is wrong, since task-base is supposed to drag in bt and
wifi when it's available which includes usb, pci, serial, etc.
I believe Filip's patch is correct, in removing them from the PACKAGES
list when these features are not set.
task-base already checks the MACHINE_FEATURES and DISTRO_FEATURES for
bluetooth and wifi:
RDEPENDS_task-base = "\
...
${@base_contains('COMBINED_FEATURES', 'bluetooth',
'task-base-bluetooth', '',d)} \
${@base_contains('COMBINED_FEATURES', 'wifi', 'task-base-wifi',
'',d)} \
...
The dependency on usb, pci, etc. is implemented in a python __anonymous
function lower down in the file.
---
recipes/tasks/task-base.bb |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/recipes/tasks/task-base.bb b/recipes/tasks/task-base.bb
index 32d871d..c8d6df7 100644
--- a/recipes/tasks/task-base.bb
+++ b/recipes/tasks/task-base.bb
@@ -1,5 +1,5 @@
DESCRIPTION = "Merge machine and distro options to create a basic
machine task/package"
-PR = "r92"
+PR = "r93"
inherit task
@@ -31,8 +31,8 @@ PACKAGES = ' \
${@base_contains("MACHINE_FEATURES", "redboot",
"task-base-redboot", "",d)} \
${@base_contains("MACHINE_FEATURES", "apex",
"task-base-apex", "",d)} \
\
-task-base-bluetooth \
-task-base-wifi \
+${@base_contains("MACHINE_FEATURES", "bluetooth",
"task-base-bluetooth", "",d)} \
+${@base_contains("MACHINE_FEATURES", "wifi",
"task-base-wifi", "",d)} \
\
${@base_contains("DISTRO_FEATURES", "cramfs",
"task-base-cramfs", "", d)} \
${@base_contains("DISTRO_FEATURES", "ipsec",
"task-base-ipsec", "", d)} \
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFNUYoQMkyGM64RGpERAuFAAJ9Y5jiml8NdBJpg5XmD7b8BlwjjFQCfXL8H
xuKrNII4OscMLUu/S2dAejQ=
=j2V5
-END PGP SIGNATURE-
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
===
This email, including any attachments, is only for the intended
addressee. It is subject to copyright, is confidential and may be
the subject of legal or other privilege, none of which is waived or
lost by reason of this transmission.
If the receiver is not the intended addressee, please accept our
apologies, notify us by return, delete all copies and perform no
other act on the email.
Unfortunately, we cannot warrant that the email has not been
altered or corrupted during transmission.
===
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
On 2/8/11, Koen Kooi wrote: > Use a different task, nobody is forcing you to use task-base But bootstrap-image is hardwired to use task-base. Should we have our own version of bootstrap-image then? I assume that bootstrap-image is: "a minimal set of software needed to be able to install packages from the internet". bye, Filip Zyzniewski ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
On 2/8/11, Koen Kooi wrote: > Kinda hard to get to the feeds without networking The bootstrap image does not contain pppd, which is far more frequently used when accessing the Internet than bluetooth (and bluetooth scenario usually involves ppp). So either the recipe is wrong in forcing bluetooth, or in not including pppd. bye, Filip Zyzniewski ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
Dnia poniedziałek, 7 lutego 2011 o 23:13:42 Filip Zyzniewski napisał(a):
> This reduces amount of tasks for bootstrap-image from around 3400 to
> around 1600 for jlime.
>
> Signed-off-by: Filip Zyzniewski
> ---
> recipes/tasks/task-base.bb |6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/recipes/tasks/task-base.bb b/recipes/tasks/task-base.bb
> index 32d871d..c8d6df7 100644
> --- a/recipes/tasks/task-base.bb
> +++ b/recipes/tasks/task-base.bb
> @@ -1,5 +1,5 @@
> DESCRIPTION = "Merge machine and distro options to create a basic machine
> task/package" -PR = "r92"
> +PR = "r93"
>
> inherit task
>
> @@ -31,8 +31,8 @@ PACKAGES = ' \
> ${@base_contains("MACHINE_FEATURES", "redboot",
> "task-base-redboot", "",d)} \ ${@base_contains("MACHINE_FEATURES", "apex",
> "task-base-apex", "",d)} \ \
> -task-base-bluetooth \
> -task-base-wifi \
> +${@base_contains("MACHINE_FEATURES", "bluetooth",
> "task-base-bluetooth", "",d)} \ +
> ${@base_contains("MACHINE_FEATURES", "wifi", "task-base-wifi", "",d)} \ \
> ${@base_contains("DISTRO_FEATURES", "cramfs",
> "task-base-cramfs", "", d)} \ ${@base_contains("DISTRO_FEATURES", "ipsec",
> "task-base-ipsec", "", d)} \
This change is bogus. You just remove building of BT/Wifi support for "bitbake
bootstrap-image" for your machine not distro. Use DISTRO_FEATURES instead and
then remove "bluetooth wifi" from DISTRO_FEATURES in your distribution config
file.
Other way is to create own copy of task-base and boostrap-image recipes.
Easiest way would to have jlime overlay with recipes/task-base-jlime.bb which
would "require task-base.bb" + "PROVIDES = task-base" + define own PACKAGES
variable - this will give you everything from task-base defined + your change
above. You only need to select it in your distro config as preferred provider
of task-base.
task-base was created several years ago as attempt to get something better
then task-bootstrap which we used before. BT/Wifi part was done to have
support for cf/usb/pci connected dongles/cards. And it worked fine but was not
perfect.
Regards,
--
JID: h...@jabber.org
Website: http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
On 2/9/11, Marcin Juszkiewicz wrote: > This change is bogus. You just remove building of BT/Wifi support for > "bitbake > bootstrap-image" for your machine not distro. Use DISTRO_FEATURES instead > and > then remove "bluetooth wifi" from DISTRO_FEATURES in your distribution > config > file. The whole point of this patch is to make task-base honour features. Without this change bluez (and in consequence avahi, gstreamer, gtk, x libs) gets built regardless of features setting. > task-base was created several years ago as attempt to get something better > then task-bootstrap which we used before. BT/Wifi part was done to have > support for cf/usb/pci connected dongles/cards. And it worked fine but was > not > perfect. Sure, but why not build it only when the distro/machine has bluetooth in features? bye, Filip Zyzniewski ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09-02-11 13:59, Filip Zyzniewski wrote: > On 2/9/11, Marcin Juszkiewicz wrote: > >> This change is bogus. You just remove building of BT/Wifi support for >> "bitbake >> bootstrap-image" for your machine not distro. Use DISTRO_FEATURES instead >> and >> then remove "bluetooth wifi" from DISTRO_FEATURES in your distribution >> config >> file. > > The whole point of this patch is to make task-base honour features. > Without this change bluez (and in consequence avahi, gstreamer, gtk, x > libs) gets built regardless of features setting. That's the whole point of task-base, to get things built. You can then use machine_features to install them by default or not. Again, noone is forcing you to use task-base, so no need to break it for everyone else like your patch is doing. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (Darwin) iD8DBQFNUpaKMkyGM64RGpERAh8jAJ4koJrmIpHfs5Eklx/gPg7xE/gMAACfTfTo kfLoxrXxxbVx4DU/u5P4TU4= =fOfI -END PGP SIGNATURE- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
On 2/9/11, Koen Kooi wrote: > That's the whole point of task-base, to get things built. You can then > use machine_features to install them by default or not. > > Again, noone is forcing you to use task-base, so no need to break it for > everyone else like your patch is doing. Ok, thanks for the discussion. I still do not agree with the outcome, but it is not a big problem - I think we will just keep building the bigger set to avoid messing stuff up. Should I mark the patch on patchwork as rejected? bye, Filip Zyzniewski ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
On 02/09/2011 06:28 AM, Koen Kooi wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09-02-11 13:59, Filip Zyzniewski wrote:
On 2/9/11, Marcin Juszkiewicz wrote:
This change is bogus. You just remove building of BT/Wifi support for
"bitbake
bootstrap-image" for your machine not distro. Use DISTRO_FEATURES instead
and
then remove "bluetooth wifi" from DISTRO_FEATURES in your distribution
config
file.
The whole point of this patch is to make task-base honour features.
Without this change bluez (and in consequence avahi, gstreamer, gtk, x
libs) gets built regardless of features setting.
That's the whole point of task-base, to get things built. You can then
use machine_features to install them by default or not.
Again, noone is forcing you to use task-base, so no need to break it for
everyone else like your patch is doing.
But it's also kinda annoying when you opt out of task-base.
So let me put on the apparently stupid hat today. Looking at task-base
today. PACKAGES always has task-base-{wifi,bluetooth}. task-base will
RDEPEND on it iff DISTRO and MACHINE set the appropriate feature. Then
in task-base-extended RDEPENDS we have logic to do the common $bus I/O
thing I was talking about.
So... wouldn't making the patch be DISTRO_FEATURES rather than
MACHINE_FEATURES be what people want?
--
Tom Rini
Mentor Graphics Corporation
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
On Wed, 2011-02-09 at 08:01 -0700, Tom Rini wrote: > So... wouldn't making the patch be DISTRO_FEATURES rather than > MACHINE_FEATURES be what people want? I think that's still not quite right. As far as I can tell there are three interesting scenarios that need to be distinguished: 1. DISTRO doesn't want bluetooth at all: bluez shouldn't be built, nothing should depend on it, and bluetooth should be disabled in all packages where it's an option. If nothing is using bluez then clearly it isn't going to be wanted in the bootstrap images. 2. DISTRO does want bluetooth as an option in the feeds but it isn't needed for bootstrapping (on distros where that's a meaningful concept). Bluez should be built, packages where it's an option should depend on it, but task-base/task-bootstrap should not make any special effort to haul bluez into the installation images. 3. DISTRO wants bluetooth and it is required for bootstrapping. In this case, evidently something in task-base/task-bootstrap needs to RDEPEND on it in order to make sure it's available at install time. I think case (1) corresponds to DISTRO_FEATURES not including bluetooth. Case (3) corresponds to DISTRO_FEATURES having bluetooth and the MACHINE declaring that it is bluetooth-capable in some way (either by mentioning it directly in MACHINE_FEATURES or by mentioning a bus like pci or cf which could accept a bluetooth card). The difficulty seems to be that, for case (2), there is currently no way for a DISTRO to say that it isn't interested in bluetooth for bootstrap purposes even though the hardware might be capable of it. That might be a legitimate point of view if all the hardware that it runs on also supports an easier bootstrap method (e.g. wifi). If you change the patch to just look at DISTRO_FEATURES then it will essentially be a no-op since the distros which are having this problem must already be enabling bluetooth in DISTRO_FEATURES. All that said, though, I think there is a fairly strong case for just saying that each distro should provide its own task-bootstrap equivalent (if it cares about bootstrapping). It seems a bit silly to try to have a single one-size-fits-all recipe with a zillion little switches that make it behave differently in a multitude of ways. p. ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
On 02/09/2011 08:22 AM, Phil Blundell wrote:
On Wed, 2011-02-09 at 08:01 -0700, Tom Rini wrote:
So... wouldn't making the patch be DISTRO_FEATURES rather than
MACHINE_FEATURES be what people want?
I think that's still not quite right. As far as I can tell there are
three interesting scenarios that need to be distinguished:
1. DISTRO doesn't want bluetooth at all: bluez shouldn't be built,
nothing should depend on it, and bluetooth should be disabled in all
packages where it's an option. If nothing is using bluez then clearly
it isn't going to be wanted in the bootstrap images.
2. DISTRO does want bluetooth as an option in the feeds but it isn't
needed for bootstrapping (on distros where that's a meaningful concept).
Bluez should be built, packages where it's an option should depend on
it, but task-base/task-bootstrap should not make any special effort to
haul bluez into the installation images.
3. DISTRO wants bluetooth and it is required for bootstrapping. In this
case, evidently something in task-base/task-bootstrap needs to RDEPEND
on it in order to make sure it's available at install time.
I think case (1) corresponds to DISTRO_FEATURES not including bluetooth.
Case (3) corresponds to DISTRO_FEATURES having bluetooth and the MACHINE
declaring that it is bluetooth-capable in some way (either by mentioning
it directly in MACHINE_FEATURES or by mentioning a bus like pci or cf
which could accept a bluetooth card).
Right, and same for "wifi" (which is a much smaller set of stuff that
gets pulled in).
The difficulty seems to be that, for case (2), there is currently no way
for a DISTRO to say that it isn't interested in bluetooth for bootstrap
purposes even though the hardware might be capable of it. That might be
a legitimate point of view if all the hardware that it runs on also
supports an easier bootstrap method (e.g. wifi).
I think in the cases where it's being pulled into the image, doing
$distro-bootstrap-image.bb which just adds the logic that says "remove
... for $machine" and spits out the N different bootstrap possible
images is fine. But the problem, if I read it right is:
Lots of things are being built and then task-base-{bluetooth,wifi}
exist, but aren't installed.
If you change the patch to just look at DISTRO_FEATURES then it will
essentially be a no-op since the distros which are having this problem
must already be enabling bluetooth in DISTRO_FEATURES.
I warned you I have my stupid hat on, but jlime-2010.1.conf doesn't list
bluetooth or wifi.
All that said, though, I think there is a fairly strong case for just
saying that each distro should provide its own task-bootstrap equivalent
(if it cares about bootstrapping). It seems a bit silly to try to have
a single one-size-fits-all recipe with a zillion little switches that
make it behave differently in a multitude of ways.
I don't know. Switching hats, we've never used task-base/etc since it's
always pulled in more stuff than we cared for and seemed like a PITA to
take things out. But it's also long been a wishlist item to give it
another go. But it's a good and honest question, does task-base really
work today, as the various distros wish that it would, for anyone other
than Angstrom? If not, that'd be a pretty good case for abstracting
things a little and saying if you want to use images X/Y/Z, $distro
needs to provide $something that's installed in the images and it must
do
--
Tom Rini
Mentor Graphics Corporation
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
