Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework
On Fri, May 1, 2015 at 12:47 PM, Khem Raj wrote: > ping. Can this now be merged ? Yes ;-) -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework
ping. Can this now be merged ? On Wed, Apr 29, 2015 at 10:54 AM, Khem Raj wrote: > > On Apr 29, 2015 10:37 AM, "Carlos Rafael Giani" > wrote: >> >> The latest one (V8) seems good to me. I was initially skeptical about the >> heavy chromium.inc refactoring, but these days we don't have multiple >> chromium versions in meta-browser, so it is okay. >> The shared object versioning bandaid wasn't done by me, I modified other >> parts, but I agree with the patch. The way it is done now is cleaner. >> Have you come across a case where there were codec package conflicts? >> > > Not yet but this makes it future proof. Since I know there are packages with > same .so >> >> >> Am 2015-04-27 um 23:40 schrieb Otavio Salvador: >>> >>> On Mon, Apr 27, 2015 at 6:37 PM, Khem Raj wrote: > > On Apr 27, 2015, at 1:33 PM, Andre McCurdy wrote: > > Looks like some regressions may have crept back relative previous > versions of the patch? > > - dubious indent in do_install() > - .pak files being installed as executables > - dev-so INSANE_SKIP shouldn't be requied > Thanks for bringing it up. I will send a followup to fix it incrementally. >>> >>> Please wait for Carlos comments and send a new pathc revision. This is >>> not yet merged so fixes are still possible. >>> >> >> -- >> ___ >> Openembedded-devel mailing list >> Openembedded-devel@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework
On Apr 29, 2015 10:37 AM, "Carlos Rafael Giani" wrote: > > The latest one (V8) seems good to me. I was initially skeptical about the heavy chromium.inc refactoring, but these days we don't have multiple chromium versions in meta-browser, so it is okay. > The shared object versioning bandaid wasn't done by me, I modified other parts, but I agree with the patch. The way it is done now is cleaner. > Have you come across a case where there were codec package conflicts? > Not yet but this makes it future proof. Since I know there are packages with same .so > > > Am 2015-04-27 um 23:40 schrieb Otavio Salvador: >> >> On Mon, Apr 27, 2015 at 6:37 PM, Khem Raj wrote: On Apr 27, 2015, at 1:33 PM, Andre McCurdy wrote: Looks like some regressions may have crept back relative previous versions of the patch? - dubious indent in do_install() - .pak files being installed as executables - dev-so INSANE_SKIP shouldn't be requied >>> Thanks for bringing it up. I will send a followup to fix it incrementally. >> >> Please wait for Carlos comments and send a new pathc revision. This is >> not yet merged so fixes are still possible. >> > > -- > ___ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework
The latest one (V8) seems good to me. I was initially skeptical about the heavy chromium.inc refactoring, but these days we don't have multiple chromium versions in meta-browser, so it is okay. The shared object versioning bandaid wasn't done by me, I modified other parts, but I agree with the patch. The way it is done now is cleaner. Have you come across a case where there were codec package conflicts? Am 2015-04-27 um 23:40 schrieb Otavio Salvador: On Mon, Apr 27, 2015 at 6:37 PM, Khem Raj wrote: On Apr 27, 2015, at 1:33 PM, Andre McCurdy wrote: Looks like some regressions may have crept back relative previous versions of the patch? - dubious indent in do_install() - .pak files being installed as executables - dev-so INSANE_SKIP shouldn't be requied Thanks for bringing it up. I will send a followup to fix it incrementally. Please wait for Carlos comments and send a new pathc revision. This is not yet merged so fixes are still possible. -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework
> On Apr 27, 2015, at 2:40 PM, Otavio Salvador wrote: > >> Thanks for bringing it up. I will send a followup to fix it incrementally. > > Please wait for Carlos comments and send a new pathc revision. This is > not yet merged so fixes are still possible. sent a V6 -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework
On Mon, Apr 27, 2015 at 6:37 PM, Khem Raj wrote: > >> On Apr 27, 2015, at 1:33 PM, Andre McCurdy wrote: >> >> Looks like some regressions may have crept back relative previous >> versions of the patch? >> >> - dubious indent in do_install() >> - .pak files being installed as executables >> - dev-so INSANE_SKIP shouldn't be requied >> > > Thanks for bringing it up. I will send a followup to fix it incrementally. Please wait for Carlos comments and send a new pathc revision. This is not yet merged so fixes are still possible. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework
> On Apr 27, 2015, at 1:33 PM, Andre McCurdy wrote:
>
> Looks like some regressions may have crept back relative previous
> versions of the patch?
>
> - dubious indent in do_install()
> - .pak files being installed as executables
> - dev-so INSANE_SKIP shouldn't be requied
>
Thanks for bringing it up. I will send a followup to fix it incrementally.
>
> On Mon, Apr 27, 2015 at 9:44 AM, Khem Raj wrote:
>> CEF is a framework to embed chromium based browsers into other
>> applications
>>
>> Change-Id: Ieabae43042101331f67cf6e673391f6fe320561f
>> Signed-off-by: pnandyala
>> Signed-off-by: knagabhirava
>> Signed-off-by: Zoltan Kuscsik
>> Signed-off-by: Khem Raj
>> ---
>> .../cef3/01_get_svn_version_from_LASTCHANGE.patch | 25 ++
>> recipes-browser/chromium/cef3_280796.bb| 50
>> recipes-browser/chromium/chromium.inc | 251
>> +++--
>> recipes-browser/chromium/chromium_40.0.2214.91.bb | 163 +
>> 4 files changed, 320 insertions(+), 169 deletions(-)
>> create mode 100644
>> recipes-browser/chromium/cef3/01_get_svn_version_from_LASTCHANGE.patch
>> create mode 100644 recipes-browser/chromium/cef3_280796.bb
>>
>> diff --git
>> a/recipes-browser/chromium/cef3/01_get_svn_version_from_LASTCHANGE.patch
>> b/recipes-browser/chromium/cef3/01_get_svn_version_from_LASTCHANGE.patch
>> new file mode 100644
>> index 000..61f88b4
>> --- /dev/null
>> +++ b/recipes-browser/chromium/cef3/01_get_svn_version_from_LASTCHANGE.patch
>> @@ -0,0 +1,25 @@
>> +diff --git a/cef/tools/make_version_header.py
>> b/cef/tools/make_version_header.py
>> +index 84d49f5..395c2cf 100644
>> +--- a/cef/tools/make_version_header.py
>> b/cef/tools/make_version_header.py
>> +@@ -64,6 +64,8 @@ def write_svn_header(header, chrome_version, cef_version,
>> cpp_header_dir):
>> + revision = svn.get_revision()
>> + elif git.is_checkout('.'):
>> + revision = git.get_svn_revision()
>> ++elif os.path.isfile("../build/util/LASTCHANGE"):
>> ++ revision =
>> open("../build/util/LASTCHANGE").read().split("=")[1].strip()
>> + else:
>> + raise Exception('Not a valid checkout')
>> +
>> +diff --git a/cef/tools/revision.py b/cef/tools/revision.py
>> +index 1d94602..eb89e3b 100644
>> +--- a/cef/tools/revision.py
>> b/cef/tools/revision.py
>> +@@ -16,6 +16,8 @@ if os.path.exists(os.path.join('.', '.svn')):
>> + sys.stdout.write(svn.get_revision())
>> + elif os.path.exists(os.path.join('.', '.git')):
>> + sys.stdout.write(git.get_svn_revision())
>> ++elif os.path.isfile("../build/util/LASTCHANGE"):
>> ++ revision = open("../build/util/LASTCHANGE").read().split("=")[1].strip()
>> + else:
>> + raise Exception('Not a valid checkout')
>> diff --git a/recipes-browser/chromium/cef3_280796.bb
>> b/recipes-browser/chromium/cef3_280796.bb
>> new file mode 100644
>> index 000..9ca5810
>> --- /dev/null
>> +++ b/recipes-browser/chromium/cef3_280796.bb
>> @@ -0,0 +1,50 @@
>> +DESCRIPTION = "Chromium Embedded Framework"
>> +
>> +include chromium.inc
>> +
>> +RDEPENDS_${PN} += "pango cairo fontconfig pciutils pulseaudio freetype
>> fontconfig-utils"
>> +
>> +SRCREV_tools = "99bcb0e676eb396bcf8e1af3903aa4b578a0"
>> +SRCREV_cef = "bbad53dfca9f98dddcb31a590410fece0a4f0234"
>> +SRCREV_egl = "a5b81b7617ba6757802b9b5f8c950034d5f961ec"
>> +SRCREV_FORMAT = "cef_egl_tools"
>> +
>> +SRC_URI =
>> "http://people.linaro.org/~zoltan.kuscsik/chromium-browser/chromium_rev_${PV}.tar.xz
>> \
>> +
>> git://github.com/kuscsik/chromiumembedded.git;protocol=https;destsuffix=src/cef;branch=aura;name=cef
>> \
>> +
>> git://github.com/kuscsik/ozone-egl.git;protocol=https;destsuffix=src/ui/ozone/platform/egl;branch=master;name=egl
>> \
>> +
>> git://chromium.googlesource.com/chromium/tools/depot_tools.git;protocol=https;destsuffix=depot_tools;branch=master;name=tools
>> \
>> + file://01_get_svn_version_from_LASTCHANGE.patch \
>> + "
>> +SRC_URI[md5sum] = "9efbb50283b731042e62b9bd5e312b2f"
>> +SRC_URI[sha256sum] =
>> "f608e97dadf6ea4d885b24fd876896d46840fa39bf743ea2025075aee9fb348d"
>> +
>> +S = "${WORKDIR}/chromium_rev_${PV}"
>> +
>> +do_fetch[vardeps] += "SRCREV_FORMAT SRCREV_cef SRCREV_egl SRCREV_tools"
>> +
>> +GYP_ARCH_DEFINES_armv7a = " target_arch=arm arm_float_abi=hard"
>> +GYP_ARCH_DEFINES_i586 = " target_arch=ia32"
>> +
>> +export GYP_GENERATORS="ninja"
>> +export BUILD_TARGET_ARCH="${TARGET_ARCH}"
>> +export GYP_DEFINES="${GYP_ARCH_DEFINES}
>> release_extra_cflags='-Wno-error=unused-local-typedefs' sysroot=''"
>> +
>> +do_configure_append() {
>> + export PATH=${WORKDIR}/depot_tools:"$PATH"
>> + # End of LD Workaround
>> + #---
>> + # Configure cef
>> + #
>> + cd cef
>> + ./cef_create_projects.sh -I ${BUILD_TARGET_ARCH}_ozone.gypi --depth
>> ../
>> + cd -
>> +}
>> +
>> +# Workaround to disable qa_configure
>> +do_q
Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework
Looks like some regressions may have crept back relative previous
versions of the patch?
- dubious indent in do_install()
- .pak files being installed as executables
- dev-so INSANE_SKIP shouldn't be requied
On Mon, Apr 27, 2015 at 9:44 AM, Khem Raj wrote:
> CEF is a framework to embed chromium based browsers into other
> applications
>
> Change-Id: Ieabae43042101331f67cf6e673391f6fe320561f
> Signed-off-by: pnandyala
> Signed-off-by: knagabhirava
> Signed-off-by: Zoltan Kuscsik
> Signed-off-by: Khem Raj
> ---
> .../cef3/01_get_svn_version_from_LASTCHANGE.patch | 25 ++
> recipes-browser/chromium/cef3_280796.bb| 50
> recipes-browser/chromium/chromium.inc | 251
> +++--
> recipes-browser/chromium/chromium_40.0.2214.91.bb | 163 +
> 4 files changed, 320 insertions(+), 169 deletions(-)
> create mode 100644
> recipes-browser/chromium/cef3/01_get_svn_version_from_LASTCHANGE.patch
> create mode 100644 recipes-browser/chromium/cef3_280796.bb
>
> diff --git
> a/recipes-browser/chromium/cef3/01_get_svn_version_from_LASTCHANGE.patch
> b/recipes-browser/chromium/cef3/01_get_svn_version_from_LASTCHANGE.patch
> new file mode 100644
> index 000..61f88b4
> --- /dev/null
> +++ b/recipes-browser/chromium/cef3/01_get_svn_version_from_LASTCHANGE.patch
> @@ -0,0 +1,25 @@
> +diff --git a/cef/tools/make_version_header.py
> b/cef/tools/make_version_header.py
> +index 84d49f5..395c2cf 100644
> +--- a/cef/tools/make_version_header.py
> b/cef/tools/make_version_header.py
> +@@ -64,6 +64,8 @@ def write_svn_header(header, chrome_version, cef_version,
> cpp_header_dir):
> + revision = svn.get_revision()
> + elif git.is_checkout('.'):
> + revision = git.get_svn_revision()
> ++elif os.path.isfile("../build/util/LASTCHANGE"):
> ++ revision =
> open("../build/util/LASTCHANGE").read().split("=")[1].strip()
> + else:
> + raise Exception('Not a valid checkout')
> +
> +diff --git a/cef/tools/revision.py b/cef/tools/revision.py
> +index 1d94602..eb89e3b 100644
> +--- a/cef/tools/revision.py
> b/cef/tools/revision.py
> +@@ -16,6 +16,8 @@ if os.path.exists(os.path.join('.', '.svn')):
> + sys.stdout.write(svn.get_revision())
> + elif os.path.exists(os.path.join('.', '.git')):
> + sys.stdout.write(git.get_svn_revision())
> ++elif os.path.isfile("../build/util/LASTCHANGE"):
> ++ revision = open("../build/util/LASTCHANGE").read().split("=")[1].strip()
> + else:
> + raise Exception('Not a valid checkout')
> diff --git a/recipes-browser/chromium/cef3_280796.bb
> b/recipes-browser/chromium/cef3_280796.bb
> new file mode 100644
> index 000..9ca5810
> --- /dev/null
> +++ b/recipes-browser/chromium/cef3_280796.bb
> @@ -0,0 +1,50 @@
> +DESCRIPTION = "Chromium Embedded Framework"
> +
> +include chromium.inc
> +
> +RDEPENDS_${PN} += "pango cairo fontconfig pciutils pulseaudio freetype
> fontconfig-utils"
> +
> +SRCREV_tools = "99bcb0e676eb396bcf8e1af3903aa4b578a0"
> +SRCREV_cef = "bbad53dfca9f98dddcb31a590410fece0a4f0234"
> +SRCREV_egl = "a5b81b7617ba6757802b9b5f8c950034d5f961ec"
> +SRCREV_FORMAT = "cef_egl_tools"
> +
> +SRC_URI =
> "http://people.linaro.org/~zoltan.kuscsik/chromium-browser/chromium_rev_${PV}.tar.xz
> \
> +
> git://github.com/kuscsik/chromiumembedded.git;protocol=https;destsuffix=src/cef;branch=aura;name=cef
> \
> +
> git://github.com/kuscsik/ozone-egl.git;protocol=https;destsuffix=src/ui/ozone/platform/egl;branch=master;name=egl
> \
> +
> git://chromium.googlesource.com/chromium/tools/depot_tools.git;protocol=https;destsuffix=depot_tools;branch=master;name=tools
> \
> + file://01_get_svn_version_from_LASTCHANGE.patch \
> + "
> +SRC_URI[md5sum] = "9efbb50283b731042e62b9bd5e312b2f"
> +SRC_URI[sha256sum] =
> "f608e97dadf6ea4d885b24fd876896d46840fa39bf743ea2025075aee9fb348d"
> +
> +S = "${WORKDIR}/chromium_rev_${PV}"
> +
> +do_fetch[vardeps] += "SRCREV_FORMAT SRCREV_cef SRCREV_egl SRCREV_tools"
> +
> +GYP_ARCH_DEFINES_armv7a = " target_arch=arm arm_float_abi=hard"
> +GYP_ARCH_DEFINES_i586 = " target_arch=ia32"
> +
> +export GYP_GENERATORS="ninja"
> +export BUILD_TARGET_ARCH="${TARGET_ARCH}"
> +export GYP_DEFINES="${GYP_ARCH_DEFINES}
> release_extra_cflags='-Wno-error=unused-local-typedefs' sysroot=''"
> +
> +do_configure_append() {
> + export PATH=${WORKDIR}/depot_tools:"$PATH"
> + # End of LD Workaround
> + #---
> + # Configure cef
> + #
> + cd cef
> + ./cef_create_projects.sh -I ${BUILD_TARGET_ARCH}_ozone.gypi --depth
> ../
> + cd -
> +}
> +
> +# Workaround to disable qa_configure
> +do_qa_configure() {
> + echo "do_qa_configure"
> +}
> +
> +do_compile() {
> + ninja -C out/${CHROMIUM_BUILD_TYPE} cefsimple
> +}
> diff --git a/recipes-browser/chromium/chromium.inc
> b/recipes-browser/chromium/chromium.inc
> index ad976f9..96d16fa 1006
Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework
> On Apr 27, 2015, at 10:18 AM, Otavio Salvador wrote: > > On Mon, Apr 27, 2015 at 2:12 PM, Khem Raj wrote: >> >>> On Apr 27, 2015, at 9:57 AM, Otavio Salvador >>> wrote: >>> >>> - proper patch headers >> >> can you point to patch header guidelines for meta-browser ? > > Same as OE in general[1]. > OK then it should reflect in README as well. Thats what I was alluding to. > 1. http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines > > -- > Otavio Salvador O.S. Systems > http://www.ossystems.com.brhttp://code.ossystems.com.br > Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 > -- > ___ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework
On Mon, Apr 27, 2015 at 2:12 PM, Khem Raj wrote: > >> On Apr 27, 2015, at 9:57 AM, Otavio Salvador wrote: >> >> - proper patch headers > > can you point to patch header guidelines for meta-browser ? Same as OE in general[1]. 1. http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework
> On Apr 27, 2015, at 9:57 AM, Otavio Salvador wrote: > > - proper patch headers can you point to patch header guidelines for meta-browser ? -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework
On Mon, Apr 27, 2015 at 1:44 PM, Khem Raj wrote: > CEF is a framework to embed chromium based browsers into other > applications > > Change-Id: Ieabae43042101331f67cf6e673391f6fe320561f > Signed-off-by: pnandyala > Signed-off-by: knagabhirava > Signed-off-by: Zoltan Kuscsik > Signed-off-by: Khem Raj This patch is way closer to what I consider ready for merging. For merging I would like: - Carlos feedback - he is the one who did most of this work and so should be consulted about his thoughts on this - proper patch headers -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
[oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework
CEF is a framework to embed chromium based browsers into other
applications
Change-Id: Ieabae43042101331f67cf6e673391f6fe320561f
Signed-off-by: pnandyala
Signed-off-by: knagabhirava
Signed-off-by: Zoltan Kuscsik
Signed-off-by: Khem Raj
---
.../cef3/01_get_svn_version_from_LASTCHANGE.patch | 25 ++
recipes-browser/chromium/cef3_280796.bb| 50
recipes-browser/chromium/chromium.inc | 251 +++--
recipes-browser/chromium/chromium_40.0.2214.91.bb | 163 +
4 files changed, 320 insertions(+), 169 deletions(-)
create mode 100644
recipes-browser/chromium/cef3/01_get_svn_version_from_LASTCHANGE.patch
create mode 100644 recipes-browser/chromium/cef3_280796.bb
diff --git
a/recipes-browser/chromium/cef3/01_get_svn_version_from_LASTCHANGE.patch
b/recipes-browser/chromium/cef3/01_get_svn_version_from_LASTCHANGE.patch
new file mode 100644
index 000..61f88b4
--- /dev/null
+++ b/recipes-browser/chromium/cef3/01_get_svn_version_from_LASTCHANGE.patch
@@ -0,0 +1,25 @@
+diff --git a/cef/tools/make_version_header.py
b/cef/tools/make_version_header.py
+index 84d49f5..395c2cf 100644
+--- a/cef/tools/make_version_header.py
b/cef/tools/make_version_header.py
+@@ -64,6 +64,8 @@ def write_svn_header(header, chrome_version, cef_version,
cpp_header_dir):
+ revision = svn.get_revision()
+ elif git.is_checkout('.'):
+ revision = git.get_svn_revision()
++elif os.path.isfile("../build/util/LASTCHANGE"):
++ revision = open("../build/util/LASTCHANGE").read().split("=")[1].strip()
+ else:
+ raise Exception('Not a valid checkout')
+
+diff --git a/cef/tools/revision.py b/cef/tools/revision.py
+index 1d94602..eb89e3b 100644
+--- a/cef/tools/revision.py
b/cef/tools/revision.py
+@@ -16,6 +16,8 @@ if os.path.exists(os.path.join('.', '.svn')):
+ sys.stdout.write(svn.get_revision())
+ elif os.path.exists(os.path.join('.', '.git')):
+ sys.stdout.write(git.get_svn_revision())
++elif os.path.isfile("../build/util/LASTCHANGE"):
++ revision = open("../build/util/LASTCHANGE").read().split("=")[1].strip()
+ else:
+ raise Exception('Not a valid checkout')
diff --git a/recipes-browser/chromium/cef3_280796.bb
b/recipes-browser/chromium/cef3_280796.bb
new file mode 100644
index 000..9ca5810
--- /dev/null
+++ b/recipes-browser/chromium/cef3_280796.bb
@@ -0,0 +1,50 @@
+DESCRIPTION = "Chromium Embedded Framework"
+
+include chromium.inc
+
+RDEPENDS_${PN} += "pango cairo fontconfig pciutils pulseaudio freetype
fontconfig-utils"
+
+SRCREV_tools = "99bcb0e676eb396bcf8e1af3903aa4b578a0"
+SRCREV_cef = "bbad53dfca9f98dddcb31a590410fece0a4f0234"
+SRCREV_egl = "a5b81b7617ba6757802b9b5f8c950034d5f961ec"
+SRCREV_FORMAT = "cef_egl_tools"
+
+SRC_URI =
"http://people.linaro.org/~zoltan.kuscsik/chromium-browser/chromium_rev_${PV}.tar.xz
\
+
git://github.com/kuscsik/chromiumembedded.git;protocol=https;destsuffix=src/cef;branch=aura;name=cef
\
+
git://github.com/kuscsik/ozone-egl.git;protocol=https;destsuffix=src/ui/ozone/platform/egl;branch=master;name=egl
\
+
git://chromium.googlesource.com/chromium/tools/depot_tools.git;protocol=https;destsuffix=depot_tools;branch=master;name=tools
\
+ file://01_get_svn_version_from_LASTCHANGE.patch \
+ "
+SRC_URI[md5sum] = "9efbb50283b731042e62b9bd5e312b2f"
+SRC_URI[sha256sum] =
"f608e97dadf6ea4d885b24fd876896d46840fa39bf743ea2025075aee9fb348d"
+
+S = "${WORKDIR}/chromium_rev_${PV}"
+
+do_fetch[vardeps] += "SRCREV_FORMAT SRCREV_cef SRCREV_egl SRCREV_tools"
+
+GYP_ARCH_DEFINES_armv7a = " target_arch=arm arm_float_abi=hard"
+GYP_ARCH_DEFINES_i586 = " target_arch=ia32"
+
+export GYP_GENERATORS="ninja"
+export BUILD_TARGET_ARCH="${TARGET_ARCH}"
+export GYP_DEFINES="${GYP_ARCH_DEFINES}
release_extra_cflags='-Wno-error=unused-local-typedefs' sysroot=''"
+
+do_configure_append() {
+ export PATH=${WORKDIR}/depot_tools:"$PATH"
+ # End of LD Workaround
+ #---
+ # Configure cef
+ #
+ cd cef
+ ./cef_create_projects.sh -I ${BUILD_TARGET_ARCH}_ozone.gypi --depth ../
+ cd -
+}
+
+# Workaround to disable qa_configure
+do_qa_configure() {
+ echo "do_qa_configure"
+}
+
+do_compile() {
+ ninja -C out/${CHROMIUM_BUILD_TYPE} cefsimple
+}
diff --git a/recipes-browser/chromium/chromium.inc
b/recipes-browser/chromium/chromium.inc
index ad976f9..96d16fa 100644
--- a/recipes-browser/chromium/chromium.inc
+++ b/recipes-browser/chromium/chromium.inc
@@ -1,114 +1,14 @@
-# Recipe files have to perform the following tasks after including this file:
-# 1) Add patches to SRC_URI. Version specific patches should be contained in a
-#"chromium-XX" subdirectory, where XX is the major version. There are also
-#patches that are shared amongst versions but may one day no longer be
-#needed (like unistd2.patch). These do not belong in such a subdirectory,
-#but still ne
