Re: [Openerp-connector-community] Jobs are not assign to worker
Hello,
Finally I have found solution.
The problem was that in my addons-path, root addons folder wasn't first.
When I have changed the order everything is fine. That's my init.d line:
start-stop-daemon --start --quiet --pidfile /var/run/${NAME}.pid --chuid
${USER} --background --make-pidfile --exec ${DAEMON} --
--config=${CONFIG} --logfile=${LOGFILE} --debug --database=AMG24
--addons-path
/usr/lib/pymodules/python2.7/openerp/addons,/usr/lib/pymodules/python2.7/openerp/addons/openerp-connector,/usr/lib/pymodules/python2.7/openerp/addons/openerp-connector-ecommerce,/usr/lib/pymodules/python2.7/openerp/addons/openerp-connector-magento,/usr/lib/pymodules/python2.7/openerp/addons/e-commerce-addons,/usr/lib/pymodules/python2.7/openerp/addons/openerp-product-attributes,/usr/lib/pymodules/python2.7/openerp/addons/sale-wkfl
It caused several other errors:
- static content have been downloaded with random 404 state
- debug mode have given blank page
Problem SOLVED. Hope it helps.
Kind regards
W dniu 2014-04-23 14:26, Adam Langowski / IDEA07 Studio Kreatywne pisze:
W dniu 2014-04-22 10:04, Guewen Baconnier pisze:
On 04/18/2014 08:20 AM, Adam Langowski / IDEA07 Studio Kreatywne wrote:
Hello,
I try to install one more time magento connector on new installation of openERP
and everything was fine till openERP server was restarted. From that time all
jobs are pending. Any ideas?
Kind Regard
Adam
W dniu 2014-04-16 12:52, Guewen Baconnier pisze:
On 04/16/2014 12:49 PM, Petar Najman wrote:
Hi Adam,
We've experienced the same issue and came to conclusion that connector does
not work well with multiple databases.
Once we removed other databases everything started working just fine.
I hope this helps.
Anyhow, can someone please point us in the right direction because after
looking at the code I don't think it suppose to work like this.
Kind Regards,
Petar
On Wed, Apr 16, 2014 at 12:33 PM, Adam Langowski / IDEA07 Studio Kreatywne
adam.langow...@idea07.pl wrote:
Hello,
I'm after installation. Everything was done according to Installation
Guidehttp://openerp-magento-connector.com/guides/installation_guide.html
Problem is that my jobs are still Pending and not assign to worker. I've
readhttp://openerp-magento-connector.com/guides/monitor_resolve_jobs.html
I've checked my worker and Last Alive Check is always actual.
In jobs Execute only after is not set up
Schedules Actions are active.
OpenERP in not running in multiprocess.
So what could be wrong?
Thanks for your help.
Best Regards
Adam Langowski
--
Mailing list:https://launchpad.net/~openerp-connector-community
Post to :openerp-connector-community@lists.launchpad.net
Unsubscribe :https://launchpad.net/~openerp-connector-community
More help :https://help.launchpad.net/ListHelp
Hi,
If OpenERP is started with databases specified in the `dbname` (or
--database) option, the crons (standard) and the jobs won't run on the
other databases than the specified.
So the first thing you'd want to check is if this option is set (empty
means all databases).
Hi all,
I just created 3 databases with the Magento Connector, started the
server with the option --workers=0 not to use the multiprocessing mode
and the jobs are correcly executed on the 3 databases. I cannot
reproduce what you observe on my end, so if one of you could analyze
what happens and create a proper bug report (or even a merge proposal),
I would be thankful for that.
Best,
--
IDEA07 Studio kreatywne
Z powaz.aniem / Best regards / Mit freundlichen Grüßen
*Adam Langowski*
lead software engineer
mail: adam.langow...@idea07.pl mailto:adam.langow...@idea07.pl
IDEA07 http://www.idea07.pl
find us
Facebook https://www.facebook.com/Idea07StudioKreatywne?ref=hl
Tres'c' tej wiadomos'ci jest poufna i prawnie chroniona. Odbiorca;
moz.e byc' jedynie jej adresat z wy?a;czeniem doste;pu osób trzecich.
Jez.eli nie jestes' adresatem niniejszej wiadomos'ci, jej
rozpowszechnianie, kopiowanie, rozprowadzanie lub inne dzia?anie o
podobnym charakterze jest prawnie zabronione i moz.e byc' karalne.
Jez.eli otrzyma?es' te; wiadomos'c' przez pomy?ke; wys'lij do nas
e-mail zwrotny i usun' te; wiadomos'c' ze swojego komputera. Dzie;kujemy.
The information in this email is confidential and may be legally
privileged. It is intended solely for the addressee. If you are not
the intended recipient, any disclosure, copying, distribution or any
action taken or omitted to be taken in reliance on it, is prohibited
and may be unlawful. If you have received it in error please notify us
immediately by a reply email and then delete this e-mail from your
system. Thank you.
Der Inhalt dieser E-Mail ist vertraulich und ausschließlich für den
bezeichneten Adressaten bestimmt. Wenn Sie nicht der vorgesehene
Adressat dieser E-Mail oder dessen Vertreter sein sollten, so beachten
Sie bitte, dass jede Form der Kenntnisnahme, Veröffentlichung,
Vervielfältigung oder Weitergabe des Inhalts
Re: [Openerp-community] Rationale for proposing the project openerp-nomenclature to join the OCA projects
Hi Erdem! Nice to hear you, feel free to put Information on the page. Next level is to prepare a blueprint to prepare a Contact profile guidelines Regards Il mercoledì 23 aprile 2014, Info SHS-AV i...@shs-av.com ha scritto: Hi Erdem, I prepared a web page to insert and gather informations about addresses. http://www.openerp.enterprises/wiki/OpenERP_Address You can insert or update data, in Wikimedia format. Username is *OpenERP* and password is *developer* You can find link to OpenERP Developer Community Teamhttps://launchpad.net/%7Eopenerp-community https://launchpad.net/~openerp-community Hope is useful for you. Antonio M. Vigliotti Il 22/04/2014 18:36, Erdem Uney ha scritto: Hi all, We would like to participate for the Turkish data and maybe some help on the Eastern European region. Please add me to group. Have you decided which data and how to keep it? Is there an agreed template? Cheers, Erdem 7Gates Interactive Technologies | Istanbul - Turkiye On Tue, Mar 25, 2014 at 5:39 PM, Lionel Sausin l...@numerigraphe.comjavascript:_e(%7B%7D,'cvml','l...@numerigraphe.com'); wrote: Project : https://launchpad.net/openerp-data Team : https://launchpad.net/~openerp-data-editors ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net javascript:_e(%7B%7D,'cvml','openerp-community@lists.launchpad.net'); Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- Franco Tampieri System Engineer _ abstract.it - +39 06 9294 6938 Registro Imprese di Napoli 788429 / Cap. Soc. 10.000 Euro I.V. Avvertenze Legali – D. Lgs. 196/03 Tutela dei dati personali. Le informazioni contenute in questo messaggio e in ogni eventuale allegato sono riservate e ne è vietata ogni forma di diffusione. Se avete ricevuto questa comunicazione per errore, Vi preghiamo di informare immediatamente il mittente del messaggio e di eliminare l'e-mail. ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] Rationale for proposing the project openerp-nomenclature to join the OCA projects
just update german information on the wiki we have two data we want to integrate to OpenERP: 1) city - zip code + geoinformation of the city is there a module for other country how to provide this data? 2) holidays is someone working on something simular? for hr module Greetings Markus On 23.04.2014 07:38, Info SHS-AV wrote: Hi Erdem, I prepared a web page to insert and gather informations about addresses. http://www.openerp.enterprises/wiki/OpenERP_Address You can insert or update data, in Wikimedia format. Username is *OpenERP* and password is *developer* You can find link to OpenERP Developer Community Team https://launchpad.net/%7Eopenerp-community https://launchpad.net/~openerp-community Hope is useful for you. Antonio M. Vigliotti Il 22/04/2014 18:36, Erdem Uney ha scritto: Hi all, We would like to participate for the Turkish data and maybe some help on the Eastern European region. Please add me to group. Have you decided which data and how to keep it? Is there an agreed template? Cheers, Erdem 7Gates Interactive Technologies | Istanbul - Turkiye On Tue, Mar 25, 2014 at 5:39 PM, Lionel Sausin l...@numerigraphe.com mailto:l...@numerigraphe.com wrote: Project : https://launchpad.net/openerp-data Team : https://launchpad.net/~openerp-data-editors https://launchpad.net/%7Eopenerp-data-editors ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- Dipl.-Comp.-Math. Markus Schneider Softwareentwickler initOS GmbH Co. KG An der Eisenbahn 1 21224 Rosengarten Mobil: +49 (0)172 2303699 Phone: +49 (0)4105 5615613 Fax: +49 (0)4105 5615610 Email: markus.schnei...@initos.com Web: http://www.initos.com Geschäftsführung: Dipl. Wirt.-Inf. Frederik Kramer Dipl.-Ing. (FH) Torsten Francke Haftende Gesellschafterin: initOS Verwaltungs GmbH Sitz der Gesellschaft: Rosengarten – Klecken Amtsgericht Tostedt, HRA 201840 USt-IdNr: DE 275698169 Steuer-Nr: 15/205/21402 ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] Duty roster module
Hi, Phui, It looks very good, and indeed it's a great addition to OCA repositories. I think best place for it is *lp:openerp-hr*. Doest itinclude automatic planning of the duty roster? It would be fantastic. Regards. 2014-04-23 13:56 GMT+02:00 Phui Hock phuih...@codekaki.com: Hi all, I have developed a duty roster module to allow shifts/schedule management. This is useful when used in conjunction with hr_holidays to calculate more accurately the number of leaves a staff can take, for example. A few screenshots are uploaded here: http://imgur.com/a/mo8jR#0 Code is hosted here: https://code.launchpad.net/~codekaki/cdkk+openerp-addons/hr_ext-7.0 I wonder if this is a candidate for inclusion into the community branch since there isn't anything like this yet. *Chang Phui-Hock* CODEKAKI SYSTEMS (R49045/14) - A web-dev company Skype: phuihock Website: http://www.codekaki.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
[Openerp-community] Duty roster module
Hi all, I have developed a duty roster module to allow shifts/schedule management. This is useful when used in conjunction with hr_holidays to calculate more accurately the number of leaves a staff can take, for example. A few screenshots are uploaded here: http://imgur.com/a/mo8jR#0 Code is hosted here: https://code.launchpad.net/~codekaki/cdkk+openerp-addons/hr_ext-7.0 I wonder if this is a candidate for inclusion into the community branch since there isn't anything like this yet. *Chang Phui-Hock* CODEKAKI SYSTEMS (R49045/14) - A web-dev company Skype: phuihock Website: http://www.codekaki.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] Duty roster module
Hi Pedro, It doesn't do automatic planning. I am not sure that should be done. This module is actually part of a larger project that I am working for my client in manufacturing industry, and thought it would be useful for someone else. It hasn't been thoroughly tested as a module, but should work as advertised. On Apr 23, 2014 8:18 PM, Pedro Manuel Baeza Romero pedro.ba...@gmail.com wrote: Hi, Phui, It looks very good, and indeed it's a great addition to OCA repositories. I think best place for it is *lp:openerp-hr*. Doest itinclude automatic planning of the duty roster? It would be fantastic. Regards. 2014-04-23 13:56 GMT+02:00 Phui Hock phuih...@codekaki.com: Hi all, I have developed a duty roster module to allow shifts/schedule management. This is useful when used in conjunction with hr_holidays to calculate more accurately the number of leaves a staff can take, for example. A few screenshots are uploaded here: http://imgur.com/a/mo8jR#0 Code is hosted here: https://code.launchpad.net/~codekaki/cdkk+openerp-addons/hr_ext-7.0 I wonder if this is a candidate for inclusion into the community branch since there isn't anything like this yet. *Chang Phui-Hock* CODEKAKI SYSTEMS (R49045/14) - A web-dev company Skype: phuihock Website: http://www.codekaki.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
[Openerp-community] mail reception: catchall address required?
Hello, Quick question : is it mandatory to have a mail server allowing for the configuration of a catch all email address in order to get correct mail exchange and record creation on some mail receptions ? I'm asking because all instances I've seen so far use that setting to get mails centralized in one IMAP account and then let OpenERP route them according to its internal mail aliases, but this is not always convenient as many mail hosting services do not allow catch all adresses... Are there mail server hosting companies allowing this apart from Google ? Thanks for your feedback on this -- Alexandre Fayolle Chef de Projet Tel : + 33 (0)4 79 26 57 94 Camptocamp France SAS Savoie Technolac, BP 352 73377 Le Bourget du Lac Cedex http://www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] mail reception: catchall address required?
Hi Alexandre, I've been struggling with that too. Maybe the plus addressing could be a good work around. Have a look at the answer of Olivier for more details : http://help.openerp.com/question/35894/how-to-trigger-an-email-on-project-issue-changes/ Houssine 2014-04-23 15:11 GMT+02:00 Alexandre Fayolle alexandre.fayo...@camptocamp.com: Hello, Quick question : is it mandatory to have a mail server allowing for the configuration of a catch all email address in order to get correct mail exchange and record creation on some mail receptions ? I'm asking because all instances I've seen so far use that setting to get mails centralized in one IMAP account and then let OpenERP route them according to its internal mail aliases, but this is not always convenient as many mail hosting services do not allow catch all adresses... Are there mail server hosting companies allowing this apart from Google ? Thanks for your feedback on this -- Alexandre Fayolle Chef de Projet Tel : + 33 (0)4 79 26 57 94 Camptocamp France SAS Savoie Technolac, BP 352 73377 Le Bourget du Lac Cedex http://www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] mail reception: catchall address required?
On 04/23/2014 03:11 PM, Alexandre Fayolle wrote: Quick question : is it mandatory to have a mail server allowing for the configuration of a catch all email address in order to get correct mail exchange and record creation on some mail receptions ? Hi Alexandre, no, I don't use catchall setups. Instead, I force a specific reply-to address per model using an override of message_get_reply_to() and configure fetchmail for these addresses for the roundtrip. Only thing is, I've been struggling for months with intermittent returns of the catch-all configuration but I managed to fix that just today: https://bugs.launchpad.net/ocb-addons/+bug/1311628 Cheers, Stefan. ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe into lp:ocb-addons/6.1
Actually I had completely goofed the branches (uploaded my ocb branch to openobject-addons and proposed to merge there, hence the changes related to ocb present in the old MP). Should be fixed now. Thanks for the heads up, Yannick. -- https://code.launchpad.net/~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe/+merge/216820 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-fix-1282584 into lp:openerp-rma
Review: Approve code review, no test -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-fix-1282584/+merge/207450 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe into lp:ocb-addons/6.1
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe into
lp:ocb-addons/6.1.
Requested reviews:
OpenERP Core Team (openerp)
Guewen Baconnier @ Camptocamp (gbaconnier-c2c): code review
Yannick Vaucher @ Camptocamp (yvaucher-c2c)
Related bugs:
Bug #1311004 in OpenERP Community Backports (Addons): missing database index
on account_move_line(date, id)
https://bugs.launchpad.net/ocb-addons/+bug/1311004
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe/+merge/216820
improve reading account_move_lines by using an index on date, id matching _order
port of
https://code.launchpad.net/~camptocamp/openobject-addons/6.1-fix_1311004_account_move_line_index-afe/+merge/216687
to OCB (6.1)
--
https://code.launchpad.net/~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe/+merge/216820
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons/6.1.
=== modified file 'account/account_move_line.py'
--- account/account_move_line.py 2012-09-06 14:35:17 +
+++ account/account_move_line.py 2014-04-23 06:23:18 +
@@ -567,6 +567,9 @@
cr.execute('SELECT indexname FROM pg_indexes WHERE indexname = \'account_move_line_journal_id_period_id_index\'')
if not cr.fetchone():
cr.execute('CREATE INDEX account_move_line_journal_id_period_id_index ON account_move_line (journal_id, period_id)')
+cr.execute('SELECT indexname FROM pg_indexes WHERE indexname = %s', ('account_move_line_date_id_index',))
+if not cr.fetchone():
+cr.execute('CREATE INDEX account_move_line_date_id_index ON account_move_line (date DESC, id desc)')
def _check_no_view(self, cr, uid, ids, context=None):
lines = self.browse(cr, uid, ids, context=context)
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe into lp:ocb-addons/6.1
Review: Approve code review LGTM -- https://code.launchpad.net/~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe/+merge/216820 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-fix-1282584 into lp:openerp-rma
The proposal to merge lp:~camptocamp/openerp-rma/7.0-fix-1282584 into lp:openerp-rma has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/openerp-rma/7.0-fix-1282584/+merge/207450 -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-fix-1282584/+merge/207450 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma-add-picking-buttons into lp:openerp-rma
Review: Approve code review, no tests LGTM. Thanks ! -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma-add-picking-buttons/+merge/208334 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma-add-picking-buttons into lp:openerp-rma
The proposal to merge lp:~camptocamp/openerp-rma/7.0-crm_claim_rma-add-picking-buttons into lp:openerp-rma has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma-add-picking-buttons/+merge/208334 -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma-add-picking-buttons/+merge/208334 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup into lp:openerp-rma
Just adding a small comment to say that Raphaël Valyi discovered a bug when doing a -u crm_claim_rma with that branch (it breaks on the duplicate constraint). We started digging to find a solution, but we didn't had time to implement it yet. -- https://code.launchpad.net/~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup/+merge/215970 Your team OpenERP RMA is requested to review the proposed merge of lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup into lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup into lp:openerp-rma
Review: Needs Fixing code review, no tests Hi, Thanks for improving the module. I may not have the time to read all carefully, just what I saw in a few minutes here: * L269 : For the method _get_default_warehouse, I prefer to get the WH through the user because take one from get_object_reference with stock0 will never work in a multi company. Taking the first WH of the user's company seems better to me. * L910-1010 : Removing all link and button to access the related partner's document is a bit sad don't you think ? Our customer love that. But you may have move that somewhere else and I missed it ? Regards, Joël -- https://code.launchpad.net/~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup/+merge/215970 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/rma-fix-lp1311509_rde into lp:openerp-rma
Review: Approve code review LGTM Regards. -- https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311509_rde/+merge/216824 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl
Pedro, I proposed this to core trunk: https://code.launchpad.net/~camptocamp/openobject-addons/trunk-refactor-po-merge-lep/+merge/216841 -- https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/rma-fix-lp1311520_rde into lp:openerp-rma
The proposal to merge lp:~camptocamp/openerp-rma/rma-fix-lp1311520_rde into lp:openerp-rma has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311520_rde/+merge/216839 -- https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311520_rde/+merge/216839 Your team OpenERP RMA is requested to review the proposed merge of lp:~camptocamp/openerp-rma/rma-fix-lp1311520_rde into lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep into lp:sale-wkfl
this depends on https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 -- https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756 Your team Sale Core Editors is requested to review the proposed merge of lp:~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep into lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/rma-fix-lp1311520_rde into lp:openerp-rma
Romain Deheele - Camptocamp has proposed merging
lp:~camptocamp/openerp-rma/rma-fix-lp1311520_rde into lp:openerp-rma.
Requested reviews:
OpenERP RMA (openerprma)
Related bugs:
Bug #1311520 in OpenERP RMA: In Product Return, link Invoice with a line
without product_id raises an error
https://bugs.launchpad.net/openerp-rma/+bug/1311520
For more details, see:
https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311520_rde/+merge/216839
Hello,
it fixes partially lp:~camptocamp/openerp-rma/rma-fix-lp1311520_rde
Invoice lines without product_id are possible.
We need to manage this case, for example it seems at least relevant to have the
possibility to generate a refund.
About actions new products return and new delivery, is there really a
functional need when there is no product_id on invoice line?
Regards,
Romain
--
https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311520_rde/+merge/216839
Your team OpenERP RMA is requested to review the proposed merge of
lp:~camptocamp/openerp-rma/rma-fix-lp1311520_rde into lp:openerp-rma.
=== modified file 'crm_claim_rma/crm_claim_rma.py'
--- crm_claim_rma/crm_claim_rma.py 2014-04-23 07:07:52 +
+++ crm_claim_rma/crm_claim_rma.py 2014-04-23 09:24:08 +
@@ -259,8 +259,10 @@
Compute and return the destination location ID to take
for a return. Always take 'Supplier' one when return type different
from company.
-prod_obj = self.pool.get('product.product')
-prod = prod_obj.browse(cr, uid, product_id, context=context)
+prod = False
+if product_id:
+prod_obj = self.pool.get('product.product')
+prod = prod_obj.browse(cr, uid, product_id, context=context)
wh_obj = self.pool.get('stock.warehouse')
wh = wh_obj.browse(cr, uid, warehouse_id, context=context)
location_dest_id = wh.lot_stock_id.id
@@ -456,14 +458,15 @@
invoice_lines = invoice_line_obj.browse(cr, uid, invoice_line_ids,
context=context)
for invoice_line in invoice_lines:
+product_id = invoice_line.product_id and invoice_line.product_id.id or False
location_dest_id = claim_line_obj.get_destination_location(
-cr, uid, invoice_line.product_id.id,
+cr, uid, product_id,
warehouse_id, context=context)
claim_lines.append({
'name': invoice_line.name,
'claim_origine': none,
'invoice_line_id': invoice_line.id,
-'product_id': invoice_line.product_id.id,
+'product_id': product_id,
'product_returned_quantity': invoice_line.quantity,
'unit_sale_price': invoice_line.price_unit,
'location_dest_id': location_dest_id,
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh into lp:account-budgeting
The proposal to merge lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh into lp:account-budgeting has been updated. Description changed to: The object in the store condition was the wrong one. I fixed it for the correct one + fixed the now-called function. For more details, see: https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849 -- https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849 Your team Account Core Editors is requested to review the proposed merge of lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh into lp:account-budgeting. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh into lp:account-budgeting
Matthieu Dietrich @ camptocamp has proposed merging
lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh into
lp:account-budgeting.
Commit message:
[FIX] fixed store condition on fields 'analytic_amount', 'analytic_real_amount'
and 'analytic_diff_amount' + fixed function called by the store condition
Requested reviews:
Leonardo Pistone - camptocamp (lpistone): code review
Account Core Editors (account-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849
The object in the store condition was the wrong one. I fixed it for the correct
one + fixed the now-called function.
--
https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849
Your team Account Core Editors is requested to review the proposed merge of
lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh into
lp:account-budgeting.
=== modified file 'budget/budget_line.py'
--- budget/budget_line.py 2013-12-19 09:04:42 +
+++ budget/budget_line.py 2014-04-23 10:09:10 +
@@ -120,14 +120,14 @@
# if the budget currency is already set
return context.get('currency_id', False)
-def _fetch_budget_line_from_aal(self, cr, uid, ids, name, context=None):
+def _fetch_budget_line_from_aal(self, cr, uid, ids, context=None):
return the list of budget line to which belong the analytic.account.line `ids´
result = set()
budget_line_obj = self.pool.get('budget.line')
for aal in self.browse(cr, uid, ids, context=context):
-line_ids = budget_line_obj.search(cr, uid, [('analytic_account_id', '=', aal.account_id)], context=context)
+line_ids = budget_line_obj.search(cr, uid, [('analytic_account_id', '=', aal.account_id.id], context=context)
result |= set(line_ids)
return list(result)
@@ -184,7 +184,7 @@
'date_stop',
'analytic_account_id',
'currency_id'], 10),
-'analytic.account.line': (_fetch_budget_line_from_aal,
+'account.analytic.line': (_fetch_budget_line_from_aal,
['amount',
'unit_amount',
'date'], 10),
@@ -202,7 +202,7 @@
'date_stop',
'analytic_account_id',
'currency_id'], 10),
-'analytic.account.line': (_fetch_budget_line_from_aal,
+'account.analytic.line': (_fetch_budget_line_from_aal,
['amount',
'unit_amount',
'date'], 10),
@@ -220,7 +220,7 @@
'date_stop',
'analytic_account_id',
'currency_id'], 10),
-'analytic.account.line': (_fetch_budget_line_from_aal,
+'account.analytic.line': (_fetch_budget_line_from_aal,
['amount',
'unit_amount',
'date'], 10),
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1210195] Re: [trunk/7.0][addons] access denied when a subsidiary company's user tries to create a reordering rule
Hello, Ravi's fix was integrated into 7.0. revno: 10007 [merge] revision-id: m...@openerp.com-20140423100324-6stypg5uapnl1s5f ** Changed in: openobject-addons Status: Fix Committed = Fix Released ** Changed in: openobject-addons Importance: Undecided = Low -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1210195 Title: [trunk/7.0][addons] access denied when a subsidiary company's user tries to create a reordering rule Status in OpenERP Community Backports (Addons): Fix Committed Status in OpenERP Community Backports (Addons) 7.0 series: Fix Committed Status in OpenERP Addons (modules): Fix Released Bug description: Hello, Steps to reproduce: - connect to runbot.openerp.com - set admin user with technical features multi companies - set configuration warehouse on Manage multiple locations and warehouses - create one user related to Birmingham shop, with warehouse manager role. - create one user related to Chicago shop, with warehouse manager role. Connect with one of these 2 users, Go to Warehouse / Configuration / Reordering rules try to create a reordering rule : oups, an access denied popup explains : Access Denied The requested operation cannot be completed due to security restrictions. Please contact your system administrator. (Document type: Warehouse, Operation: read) - It looks like OE giving directly one warehouse by default that some users can't read. Romain To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1210195/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/7.0-monitoring into lp:server-env-tools
I also noticed that only 20-25% of process log lines have the model field filled. Why is this? -- https://code.launchpad.net/~camptocamp/server-env-tools/7.0-monitoring/+merge/215138 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh into lp:account-budgeting
Leonardo,
thanks for the review. For your questions:
1. yes, that field needs to be stored. The initial commit mentions that a sum
of the lines is used in a groupby view, which is the default view for budget
lines, coming from a project.
2. I think the optimal solution would be to retrieve all the analytic accounts
and then do a search [('analytic_account_id', 'in', list of account ids)]; we
could even do it in SQL, with DISTINCT, to avoid duplicates and speed up a bit.
I'll see what I can do.
I wonder if that trigger would impact performance.
As the code stands, a trigger like that does a search for every analytic line
we write. If we write 1000 analytic lines, same analytic account, we get 1000
queries.
This raises a few questions:
1. Do we actually need to store this field?
2. If we do, maybe it would be faster to fetch the analytic accounts of the
lines in a set, and then using the one2many field budget_line_ids in analytic
account instead of a search.
Thanks!
--
https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849
Your team Account Core Editors is requested to review the proposed merge of
lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh into
lp:account-budgeting.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-lp-1210195-RDE into lp:ocb-addons
Competing fix was merged in upstream 7.0: https://code.launchpad.net/~openerp-dev/openobject-addons/7.0-opw-596679-rgo/+merge/186294. Setting to rejected. -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-lp-1210195-RDE/+merge/181227 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh into lp:account-budgeting
@Leonardo: here is a SQL version of the request. Tell me if that's okay for you. Regards, Matthieu Dietrich -- https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849 Your team Account Core Editors is requested to review the proposed merge of lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh into lp:account-budgeting. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1210195] Re: [trunk/7.0][addons] access denied when a subsidiary company's user tries to create a reordering rule
** No longer affects: ocb-addons/7.0 ** No longer affects: ocb-addons -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1210195 Title: [trunk/7.0][addons] access denied when a subsidiary company's user tries to create a reordering rule Status in OpenERP Addons (modules): Fix Released Bug description: Hello, Steps to reproduce: - connect to runbot.openerp.com - set admin user with technical features multi companies - set configuration warehouse on Manage multiple locations and warehouses - create one user related to Birmingham shop, with warehouse manager role. - create one user related to Chicago shop, with warehouse manager role. Connect with one of these 2 users, Go to Warehouse / Configuration / Reordering rules try to create a reordering rule : oups, an access denied popup explains : Access Denied The requested operation cannot be completed due to security restrictions. Please contact your system administrator. (Document type: Warehouse, Operation: read) - It looks like OE giving directly one warehouse by default that some users can't read. Romain To manage notifications about this bug go to: https://bugs.launchpad.net/openobject-addons/+bug/1210195/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh into lp:account-budgeting
Review: Needs Fixing code review, no test Your SQL request maybe works but it is not written in an efficient way (2 DISTINCT, 1 subquery). This should be written with EXISTS. And, each time you bypass the ORM to write raw SQL, $DEITY kills a kitten. $DEITY also maims a puppy if you don't ensure that your code is not blatantly any ir.rules. Did you check for this? -- https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849 Your team Account Core Editors is subscribed to branch lp:account-budgeting. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain into lp:ocb-addons
Stefan Rijnhart (Therp) has proposed merging
lp:~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain
into lp:ocb-addons.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1311628 in OpenERP Addons: Mail catchall domain parameter being reset
by changing any general setting
https://bugs.launchpad.net/openobject-addons/+bug/1311628
For more details, see:
https://code.launchpad.net/~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain/+merge/216872
Automatically derived from
https://code.launchpad.net/~therp-nl/openobject-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain
for https://code.launchpad.net/~openerp/openobject-addons/7.0. Below is a copy
of the original description.
Don't overwrite an empty value for mail.catchall.domain. Pass a detectable
default to get_param(). If this value returns, the key does not exist and we
suggest the default value. Otherwise, keep the empty value of the existing key.
--
https://code.launchpad.net/~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain/+merge/216872
Your team OpenERP Community Backports Team is requested to review the proposed
merge of
lp:~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain
into lp:ocb-addons.
=== modified file 'mail/res_config.py'
--- mail/res_config.py 2012-10-08 12:03:51 +
+++ mail/res_config.py 2014-04-23 12:31:25 +
@@ -33,14 +33,14 @@
}
def get_default_alias_domain(self, cr, uid, ids, context=None):
-alias_domain = self.pool.get(ir.config_parameter).get_param(cr, uid, mail.catchall.domain, context=context)
-if not alias_domain:
+alias_domain = self.pool.get(ir.config_parameter).get_param(cr, uid, mail.catchall.domain, default=None, context=context)
+if alias_domain is None:
domain = self.pool.get(ir.config_parameter).get_param(cr, uid, web.base.url, context=context)
try:
alias_domain = urlparse.urlsplit(domain).netloc.split(':')[0]
except Exception:
pass
-return {'alias_domain': alias_domain}
+return {'alias_domain': alias_domain or False}
def set_alias_domain(self, cr, uid, ids, context=None):
config_parameters = self.pool.get(ir.config_parameter)
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh into lp:account-budgeting
@Alexandre, Leonardo: I went back for a classical ORM approach. I don't think a store condition's function is called by another user than the SUPERUSER, but it's better to be safe. I'm still refining a YAML test as well to add to this MP. Regards, Matthieu -- https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849 Your team Account Core Editors is subscribed to branch lp:account-budgeting. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh into lp:account-budgeting
thanks Matthieu. I'm also not a fan of the SQL if I don't have a gun pointed at me. Hopefully with the test it will be easier to improve that. -- https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849 Your team Account Core Editors is subscribed to branch lp:account-budgeting. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1309105] Re: stock.picking.out group by in multi companies
Hello,
Thanks for the report and the patch, it was merged in 7.0
revno: 10010 [merge]
revision-id: m...@openerp.com-20140423132552-hpnr2skutqranvsj
** Changed in: openobject-addons
Status: New = Fix Released
** Changed in: openobject-addons
Importance: Undecided = Low
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1309105
Title:
stock.picking.out group by in multi companies
Status in OpenERP Community Backports (Addons):
Fix Committed
Status in OpenERP Community Backports (Addons) 7.0 series:
Fix Committed
Status in OpenERP Addons (modules):
Fix Released
Bug description:
In multi company context, when using the group by 'state' in Delivery
Orders I encountered the following error:
(Document type: Picking List, Operation: read)
Traceback (most recent call last):
File .../server/openerp/netsvc.py, line 296, in dispatch_rpc
result = ExportService.getService(service_name).dispatch(method, params)
File .../server/openerp/service/web_services.py, line 626, in dispatch
res = fn(db, uid, *params)
File .../server/openerp/osv/osv.py, line 190, in execute_kw
return self.execute(db, uid, obj, method, *args, **kw or {})
File .../server/openerp/osv/osv.py, line 132, in wrapper
return f(self, dbname, *args, **kwargs)
File .../server/openerp/osv/osv.py, line 199, in execute
res = self.execute_cr(cr, uid, obj, method, *args, **kw)
File .../server/openerp/osv/osv.py, line 187, in execute_cr
return getattr(object, method)(cr, uid, *args, **kw)
File .../server/openerp/osv/orm.py, line 2759, in read_group
data = self.read(cr, uid, data_ids, [groupby], context=context)
File .../addons/stock/stock.py, line 3128, in read
return self.pool.get('stock.picking').read(cr, uid, ids, fields=fields,
context=context, load=load)
File .../server/openerp/osv/orm.py, line 3680, in read
result = self._read_flat(cr, user, select, fields, context, load)
File .../server/openerp/osv/orm.py, line 3735, in _read_flat
self._check_record_rules_result_count(cr, user, sub_ids, result_ids,
'read', context=context)
File .../server/openerp/osv/orm.py, line 3939, in
_check_record_rules_result_count
(self._description, operation))
except_osv: (u'Access Denied', u'The requested operation cannot be completed
due to security restrictions. Please contact your system
administrator.\n\n(Document type: Picking List, Operation: read)')
After digging a bit, I found that orm method read_group calls
orm.py: 2640
self._apply_ir_rules(cr, uid, query, 'read', context=context)
In there, we get the get domain on stock.picking.out which will be
empty by default. So query will not have any ir_rule applied.
Then, in read_group again, there is the big query that will get the
counts. However it will also takes min(id).
The min id will be passed in read() to which will again be applied the
ir_rules. But this time it won't be None, it will read stock.picking
rule and not the unexistant stock.picking.out rule.
Thus it will fail if min id is a stock picking out from the other
company than the current user's company.
As a temporary patch I duplicated stock.stock_picking_rule for
stock.picking.in and stock.picking.out
I'll provide a patch to solve it on the read_group method in stock
module
To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1309105/+subscriptions
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1309105 into lp:ocb-addons
The proposal to merge lp:~camptocamp/ocb-addons/7.0-fix-1309105 into lp:ocb-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1309105/+merge/216681 -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1309105/+merge/216681 Your team OpenERP Community Backports Team is requested to review the proposed merge of lp:~camptocamp/ocb-addons/7.0-fix-1309105 into lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1309105 into lp:ocb-addons
Rejecting, as merged upstream http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/10010 -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1309105/+merge/216681 Your team OpenERP Community Backports Team is requested to review the proposed merge of lp:~camptocamp/ocb-addons/7.0-fix-1309105 into lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1311076] Re: multiple popup weird behavior
** Also affects: ocb-web Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Web). https://bugs.launchpad.net/bugs/1311076 Title: multiple popup weird behavior Status in OpenERP Community Backports (Web): New Status in OpenERP Web: New Bug description: Lets say in case of the multiple popup. in second wizard there is a problem in footer . E.G load translation menu . when you select language . and load it . As a result it will popup new wizard . in this new wizard it has a problem as there are 2 footers one for init state and second is done state . some how OR is there from init state in second popup. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-web/+bug/1311076/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1309105] Re: stock.picking.out group by in multi companies
** No longer affects: ocb-addons/7.0
** No longer affects: ocb-addons
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1309105
Title:
stock.picking.out group by in multi companies
Status in OpenERP Addons (modules):
Fix Released
Bug description:
In multi company context, when using the group by 'state' in Delivery
Orders I encountered the following error:
(Document type: Picking List, Operation: read)
Traceback (most recent call last):
File .../server/openerp/netsvc.py, line 296, in dispatch_rpc
result = ExportService.getService(service_name).dispatch(method, params)
File .../server/openerp/service/web_services.py, line 626, in dispatch
res = fn(db, uid, *params)
File .../server/openerp/osv/osv.py, line 190, in execute_kw
return self.execute(db, uid, obj, method, *args, **kw or {})
File .../server/openerp/osv/osv.py, line 132, in wrapper
return f(self, dbname, *args, **kwargs)
File .../server/openerp/osv/osv.py, line 199, in execute
res = self.execute_cr(cr, uid, obj, method, *args, **kw)
File .../server/openerp/osv/osv.py, line 187, in execute_cr
return getattr(object, method)(cr, uid, *args, **kw)
File .../server/openerp/osv/orm.py, line 2759, in read_group
data = self.read(cr, uid, data_ids, [groupby], context=context)
File .../addons/stock/stock.py, line 3128, in read
return self.pool.get('stock.picking').read(cr, uid, ids, fields=fields,
context=context, load=load)
File .../server/openerp/osv/orm.py, line 3680, in read
result = self._read_flat(cr, user, select, fields, context, load)
File .../server/openerp/osv/orm.py, line 3735, in _read_flat
self._check_record_rules_result_count(cr, user, sub_ids, result_ids,
'read', context=context)
File .../server/openerp/osv/orm.py, line 3939, in
_check_record_rules_result_count
(self._description, operation))
except_osv: (u'Access Denied', u'The requested operation cannot be completed
due to security restrictions. Please contact your system
administrator.\n\n(Document type: Picking List, Operation: read)')
After digging a bit, I found that orm method read_group calls
orm.py: 2640
self._apply_ir_rules(cr, uid, query, 'read', context=context)
In there, we get the get domain on stock.picking.out which will be
empty by default. So query will not have any ir_rule applied.
Then, in read_group again, there is the big query that will get the
counts. However it will also takes min(id).
The min id will be passed in read() to which will again be applied the
ir_rules. But this time it won't be None, it will read stock.picking
rule and not the unexistant stock.picking.out rule.
Thus it will fail if min id is a stock picking out from the other
company than the current user's company.
As a temporary patch I duplicated stock.stock_picking_rule for
stock.picking.in and stock.picking.out
I'll provide a patch to solve it on the read_group method in stock
module
To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1309105/+subscriptions
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain into lp:ocb-addons
Review: Approve test -- https://code.launchpad.net/~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain/+merge/216877 Your team OpenERP Community Backports Team is requested to review the proposed merge of lp:~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain into lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh into lp:account-budgeting
Hello, I added the YAML test, in order to verify that the amounts are updated after a new analytic line on the same analytic account was added. Regards, Matthieu -- https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849 Your team Account Core Editors is subscribed to branch lp:account-budgeting. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1311628] Re: Mail catchall domain parameter being reset by changing any general setting
** Branch linked: lp:~stefan-therp/ocb- addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain ** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/7.0 Importance: Undecided Status: New ** Changed in: ocb-addons/7.0 Status: New = Fix Committed ** Changed in: ocb-addons/7.0 Assignee: (unassigned) = Stefan Rijnhart (Therp) (stefan-therp) -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1311628 Title: Mail catchall domain parameter being reset by changing any general setting Status in OpenERP Community Backports (Addons): Fix Committed Status in OpenERP Community Backports (Addons) 7.0 series: Fix Committed Status in OpenERP Addons (modules): New Bug description: How to reproduce: Go back to Settings - Configuration - General settings. Erase Alias Domain, and Apply. Note that the website url is filled in in the catchall domain field, but for now we can mail from valid email addresses configured on the user accounts because system paramenter mail.catchall.domain is empty. Now, change any other setting or just reapply the same settings. Expected results: Because the mail catchall setting is not changed, I expect that emails are still being sent without using the catchall aliases. Actual results: Reapplying the settings overwrites mail.catchall.domain and mail is sent out from invalid email aliases. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1311628/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1309105 into lp:ocb-addons
That was fast :) -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1309105/+merge/216681 Your team OpenERP Community Backports Team is requested to review the proposed merge of lp:~camptocamp/ocb-addons/7.0-fix-1309105 into lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/fix-1308364-nbi into lp:ocb-addons
Review: Approve -- https://code.launchpad.net/~camptocamp/ocb-addons/fix-1308364-nbi/+merge/216023 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/fix-1308364-nbi into lp:ocb-addons
The proposal to merge lp:~camptocamp/ocb-addons/fix-1308364-nbi into lp:ocb-addons has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~camptocamp/ocb-addons/fix-1308364-nbi/+merge/216023 -- https://code.launchpad.net/~camptocamp/ocb-addons/fix-1308364-nbi/+merge/216023 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe into lp:ocb-addons
The proposal to merge lp:~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe into lp:ocb-addons has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe/+merge/216686 -- https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe/+merge/216686 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe into lp:ocb-addons/6.1
Review: Approve code review, no test Thanks Alexandre, looks good now. -- https://code.launchpad.net/~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe/+merge/216820 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1308364] Re: [7.0] [trunk] report_webkit precise mode does not take in account set_context
** Changed in: ocb-addons/7.0 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1308364 Title: [7.0] [trunk] report_webkit precise mode does not take in account set_context Status in OpenERP Community Backports (Addons): Fix Released Status in OpenERP Community Backports (Addons) 7.0 series: Fix Released Status in OpenERP Addons (modules): Fix Committed Bug description: When precise mode is used when using a webkit report the object used are not the one of the rml_parse class. So use of the set_context hook in so taken in account. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1308364/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain into lp:ocb-addons
Stefan Rijnhart (Therp) has proposed merging
lp:~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain
into lp:ocb-addons.
Requested reviews:
Lara (Therp) (lfreeke): test
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1311628 in OpenERP Community Backports (Addons): Mail catchall domain
parameter being reset by changing any general setting
https://bugs.launchpad.net/ocb-addons/+bug/1311628
For more details, see:
https://code.launchpad.net/~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain/+merge/216877
Automatically derived from
https://code.launchpad.net/~therp-nl/openobject-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain
for https://code.launchpad.net/~openerp/openobject-addons/7.0. Below is a copy
of the original description.
Don't overwrite an empty value for mail.catchall.domain. Pass a detectable
default to get_param(). If this value returns, the key does not exist and we
suggest the default value. Otherwise, keep the empty value of the existing key.
--
https://code.launchpad.net/~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain/+merge/216877
Your team OpenERP Community Backports Team is requested to review the proposed
merge of
lp:~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain
into lp:ocb-addons.
=== modified file 'mail/res_config.py'
--- mail/res_config.py 2012-10-08 12:03:51 +
+++ mail/res_config.py 2014-04-23 13:15:53 +
@@ -33,14 +33,14 @@
}
def get_default_alias_domain(self, cr, uid, ids, context=None):
-alias_domain = self.pool.get(ir.config_parameter).get_param(cr, uid, mail.catchall.domain, context=context)
-if not alias_domain:
+alias_domain = self.pool.get(ir.config_parameter).get_param(cr, uid, mail.catchall.domain, default=None, context=context)
+if alias_domain is None:
domain = self.pool.get(ir.config_parameter).get_param(cr, uid, web.base.url, context=context)
try:
alias_domain = urlparse.urlsplit(domain).netloc.split(':')[0]
except Exception:
pass
-return {'alias_domain': alias_domain}
+return {'alias_domain': alias_domain or False}
def set_alias_domain(self, cr, uid, ids, context=None):
config_parameters = self.pool.get(ir.config_parameter)
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1311004] Re: missing database index on account_move_line(date, id)
** Changed in: ocb-addons/7.0 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1311004 Title: missing database index on account_move_line(date, id) Status in OpenERP Community Backports (Addons): Fix Released Status in OpenERP Community Backports (Addons) 6.1 series: Fix Committed Status in OpenERP Community Backports (Addons) 7.0 series: Fix Released Status in OpenERP Addons (modules): New Bug description: I have seen huge performance improvements in production by adding an index on account_move_line(date, id) which corresponds to account_move_line default _order. It would be great to have this index created by default. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1311004/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh into lp:account-budgeting
Review: Approve code review, no test Thanks, you saved some kittens -- https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849 Your team Account Core Editors is subscribed to branch lp:account-budgeting. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0-form_destroy_buttons into lp:ocb-web
Ruchir Shukla(BizzAppDev) has proposed merging
lp:~therp-nl/ocb-web/7.0-form_destroy_buttons into lp:ocb-web.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1311076 in OpenERP Community Backports (Web): multiple popup weird
behavior
https://bugs.launchpad.net/ocb-web/+bug/1311076
For more details, see:
https://code.launchpad.net/~therp-nl/ocb-web/7.0-form_destroy_buttons/+merge/216898
--
https://code.launchpad.net/~therp-nl/ocb-web/7.0-form_destroy_buttons/+merge/216898
Your team OpenERP Community Backports Team is requested to review the proposed
merge of lp:~therp-nl/ocb-web/7.0-form_destroy_buttons into lp:ocb-web.
=== modified file 'addons/web/static/src/js/view_form.js'
--- addons/web/static/src/js/view_form.js 2014-04-18 09:20:33 +
+++ addons/web/static/src/js/view_form.js 2014-04-23 14:35:10 +
@@ -147,6 +147,9 @@
this.$el.off('.formBlur');
}
this._super();
+if (this.$buttons) {
+this.$buttons.remove();
+}
},
load_form: function(data) {
var self = this;
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/rma-fix-lp1311509_rde into lp:openerp-rma
Just add a test to check invoice refund action -- https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311509_rde/+merge/216824 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~agilebg/openerp-product-attributes/adding_product_supplier_info_7 into lp:openerp-product-attributes
Alex Comba - Agile BG has proposed merging
lp:~agilebg/openerp-product-attributes/adding_product_supplier_info_7 into
lp:openerp-product-attributes.
Commit message:
[ADD] module product_supplier_info
Requested reviews:
Product Core Editors (product-core-editors)
For more details, see:
https://code.launchpad.net/~agilebg/openerp-product-attributes/adding_product_supplier_info_7/+merge/216911
I added and cleaned up the module product_supplier_info extracted from
lp:~openerp-community/openobject-addons/elico-7.0 using
https://launchpad.net/bazaar-extractor
Please also see the related MP:
https://code.launchpad.net/~agilebg/openobject-addons/removing_product_supplier_info_from_elico-7.0/+merge/216907
--
https://code.launchpad.net/~agilebg/openerp-product-attributes/adding_product_supplier_info_7/+merge/216911
Your team Product Core Editors is requested to review the proposed merge of
lp:~agilebg/openerp-product-attributes/adding_product_supplier_info_7 into
lp:openerp-product-attributes.
=== added directory 'product_supplier_info'
=== added file 'product_supplier_info/__init__.py'
--- product_supplier_info/__init__.py 1970-01-01 00:00:00 +
+++ product_supplier_info/__init__.py 2014-04-23 15:17:26 +
@@ -0,0 +1,23 @@
+# -*- coding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#Copyright (c) 2010-2013 Elico Corp. All Rights Reserved.
+#Author: Yannick Gouin yannick.go...@elico-corp.com
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+from . import product
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added file 'product_supplier_info/__openerp__.py'
--- product_supplier_info/__openerp__.py 1970-01-01 00:00:00 +
+++ product_supplier_info/__openerp__.py 2014-04-23 15:17:26 +
@@ -0,0 +1,58 @@
+# -*- coding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#Copyright (c) 2010-2013 Elico Corp. All Rights Reserved.
+#Author: LIN Yu lin...@elico-corp.com
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': 'Product Supplier Info',
+'version': '1.1',
+'category': 'Product',
+'summary': 'Product Supplier Info',
+'description':
+Product Supplier Info
+==
+This module categorizes each product item by supplier.
+It allows for users to be able to view a compiled list
+of products supplied by the supplier.
+
+Users can also directly add new products to the supplier's list.
+
+Contributors
+
+
+* Alex Comba alex.co...@agilebg.com
+,
+'author': 'Elico Corp',
+'website': 'http://www.elico-corp.com',
+'license': 'AGPL-3',
+'depends': [
+'product', 'stock',
+],
+'data': [
+'product_view.xml',
+],
+'test': [],
+'demo': [],
+'installable': True,
+'auto_install': False,
+'application': False,
+}
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added file 'product_supplier_info/product.py'
--- product_supplier_info/product.py 1970-01-01 00:00:00 +
+++ product_supplier_info/product.py 2014-04-23 15:17:26 +
@@ -0,0 +1,66 @@
+# -*- coding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#Copyright (c) 2010-2013 Elico Corp. All Rights Reserved.
+#Author: Yannick
Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0-form_destroy_buttons into lp:ocb-web
Review: Needs Fixing Ruchir, thanks for taking this dangling branch of Holger and propose it. I assume you have tested it thoroughly. To qualify for a merge in OCB, you need to prepare a branch that proposes the same change into upstream openerp-web. Setting to needs-fixing to indicate that this still needs to be done. -- https://code.launchpad.net/~therp-nl/ocb-web/7.0-form_destroy_buttons/+merge/216898 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/rma-fix-lp1311509_rde into lp:openerp-rma
Review: Approve code review, no test Ok LGTM In view all commands are array of 3 elements: http://bazaar.launchpad.net/~openerp/openerp-web/7.0/view/head:/addons/web/static/src/js/view_form.js#L3446 -- https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311509_rde/+merge/216824 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/ocb-7.0-fix_1204920-afe into lp:ocb-server
Review: Approve -- https://code.launchpad.net/~camptocamp/ocb-server/ocb-7.0-fix_1204920-afe/+merge/208390 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/ocb-7.0-fix_1204920-afe into lp:ocb-server
I see the upstream branch is green on runbot, and Holger's old comment has been honoured. Thanks! -- https://code.launchpad.net/~camptocamp/ocb-server/ocb-7.0-fix_1204920-afe/+merge/208390 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1180773] Re: [7.0] hr_timesheet_sheet - attendances constraint can be messed up by removing an attendance between 2 others
** Changed in: openobject-addons Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1180773 Title: [7.0] hr_timesheet_sheet - attendances constraint can be messed up by removing an attendance between 2 others Status in OpenERP Community Backports (Addons): Fix Released Status in OpenERP Community Backports (Addons) 7.0 series: Fix Released Status in OpenERP Addons (modules): Fix Released Bug description: Tested on runbot (Build 11071) server (4975) addons (9132) web (3922) With track attendances for all employees Let's say I enter the following attendances: sign in at 06:00 sign out at 12:00 sign in at 13:00 sign out at 16:00 Now I realize the meal taken with the client at noon can be counted in my hours. So I remove the sign out at 12:00 Now I'm stuck ! And my timesheet is wrong I cannot edit any attendance. As the constraint will not allow me to do anything. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1180773/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain into lp:ocb-addons
Review: Approve code review LGTM. Regards. -- https://code.launchpad.net/~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain/+merge/216877 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/ocb-7.0-fix_1204920-afe into lp:ocb-server
The proposal to merge lp:~camptocamp/ocb-server/ocb-7.0-fix_1204920-afe into lp:ocb-server has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/ocb-server/ocb-7.0-fix_1204920-afe/+merge/208390 -- https://code.launchpad.net/~camptocamp/ocb-server/ocb-7.0-fix_1204920-afe/+merge/208390 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/7.0-fix_1281290-afe into lp:ocb-server
Review: Approve Approve as per http://en.wikipedia.org/wiki/Polish_z%C5%82oty. -- https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1281290-afe/+merge/215612 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix_1281290-afe into lp:ocb-addons
Review: Approve -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix_1281290-afe/+merge/215614 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1204920] Re: [trunk] UnboundLocalError: local variable 'partner' referenced before assignment
** Changed in: ocb-server/7.0
Status: Fix Committed = Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Server).
https://bugs.launchpad.net/bugs/1204920
Title:
[trunk] UnboundLocalError: local variable 'partner' referenced before
assignment
Status in OpenERP Community Backports (Server):
Fix Released
Status in OpenERP Community Backports (Server) 7.0 series:
Fix Released
Status in OpenERP Server:
Confirmed
Bug description:
UnboundLocalError: local variable 'partner' referenced before assignment
openobject-server/openerp/addons/base/res/res_partner.py(680)address_get()
- default = result.get('default', partner.id)
actual server version
the variable partner is only set, if the preceding for loop is entered
To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-server/+bug/1204920/+subscriptions
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix_1281290-afe into lp:ocb-addons
The proposal to merge lp:~camptocamp/ocb-addons/7.0-fix_1281290-afe into lp:ocb-addons has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix_1281290-afe/+merge/215614 -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix_1281290-afe/+merge/215614 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/7.0-fix_1281290-afe into lp:ocb-server
The proposal to merge lp:~camptocamp/ocb-server/7.0-fix_1281290-afe into lp:ocb-server has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1281290-afe/+merge/215612 -- https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1281290-afe/+merge/215612 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1281290] Re: Wrong currency code - Poland
** Changed in: ocb-server/7.0 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1281290 Title: Wrong currency code - Poland Status in OpenERP Community Backports (Addons): Fix Committed Status in OpenERP Community Backports (Addons) 7.0 series: Fix Committed Status in OpenERP Community Backports (Server): Fix Released Status in OpenERP Community Backports (Server) 7.0 series: Fix Released Status in OpenERP Addons (modules): Fix Committed Status in OpenERP Server: Fix Committed Bug description: PLN - there is correct code of polish currency from year 1995 PLZ - is very old code. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1281290/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1281290] Re: Wrong currency code - Poland
** Changed in: ocb-addons/7.0 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1281290 Title: Wrong currency code - Poland Status in OpenERP Community Backports (Addons): Fix Released Status in OpenERP Community Backports (Addons) 7.0 series: Fix Released Status in OpenERP Community Backports (Server): Fix Released Status in OpenERP Community Backports (Server) 7.0 series: Fix Released Status in OpenERP Addons (modules): Fix Committed Status in OpenERP Server: Fix Committed Bug description: PLN - there is correct code of polish currency from year 1995 PLZ - is very old code. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1281290/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain into lp:ocb-addons
Review: Approve code review, no test Thanks a lot ! -- https://code.launchpad.net/~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain/+merge/216877 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
