Re: [Openerp-community] Licenses guidelines for OCA modules
Avoid the # box, I find it very irking to have that many heavy characters like that. Besides: E265 block comment should start with '# ' (single space after the first hash). How about: # -*- coding: utf-8 -*- # # License, author and contributors information in: # __openerp__.py file at the root folder of this repository. # Le 2015-01-05 07:53, Alejandro Santana a écrit : I put authorship, contributors and copyright info only in __openerp__.py. On other .py files I just use: # -*- coding: utf-8 -*- #License, author and contributors information in: # #__openerp__.py file at the root folder of this module.# Just my 2 cents. -- *Alejandro Santana* alejandrosant...@anubia.es · · · · · · · · · · · · · · · · · · · · · · · · · · · · · ANUBÍA, soluciones en la nube, S.L. Plaza Fernando Conde Montero Ríos, 9 36201, Vigo (Pontevedra) www.anubia.es [image: anubía_logo_2014_i_o_140x140.png][image: odoo_logo_odoo_ready_140x140.png] http://www.anubia.es/ 2015-01-05 13:38 GMT+01:00 Pedro Manuel Baeza Romero pedro.ba...@gmail.com : I see perfect to reduce the overhead of the headers, because it's a nonsense, so I would say option b, but a recurring conflicting issue is about the copyright: this part doesn't reflect at all the reality of the code because: - People copy/paste from Odoo code and let Odoo copyright, which is not correct. - Author put its copyright, but contributors (that can exceed the LOC contributed from the author), doesn't remember to put its name in it. - BTW, it's very tedious to maintain this section for each file. Why don't we just simply remove it? Copyright can be deduced from Git history. I know that FSF recommends to put it, but it's that, only a recommendation, not a must for AGPL. Regards. 2015-01-05 12:09 GMT+01:00 Yannick Vaucher yannick.vauc...@camptocamp.com : Most developers dislike redundancy, thus, all are tempted to reduce the size of source code by reducing or completly removing redundant license from source files. [1] Moreover, when writing a module you often have py files with only few lines, thus the header takes a lot of place. I think it is time to write down what we can and cannot do about AGPL license. Actual common use is to attach the full header at start of each source file. This is what is recommended by http://www.gnu.org/licenses/agpl-3.0.html To be said I'm completely against removing completely the header I think a minimal copyright must be present in each source file to be read by the one who opens the file. To be minimalist, from what I read there thought, we could also accept minimal header with license like this # Copyright 2015 author # notice where to find full licence (with full license in __openerp__.py for exemple) Exemple here [2] Our options: a. We keep full header on each source file. And accept only this one. b. We define a minimal header template like this as an altenative (mostly taken from David Beal's proposal): # -*- coding: utf-8 -*- # Author: author name # Copyright 2015 company or author # License AGPL version 3 or later # See license in __openerp__.py or http://www.gnu.org/licenses/agpl-3.0.txt [1] More talks about it in: https://github.com/OCA/product-attribute/pull/34 [2] An exemple of minimal license: https://github.com/OCA/carrier-delivery/pull/35/files Cheers, Yannick Vaucher Business Solutions Software Developer Camptocamp SA PSE A, CH-1015 Lausanne Phone: +41 21 619 10 30 Office: +41 21 619 10 10 http://www.camptocamp.com/ ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] Class or class_obj
I agree. In Object Oriented Programming, an object is an instance of a class, not the class itself. Since these are relational models, _model makes more sense to me. I also like _pool as it is clear that it comes from self.pool (in v7). There's also _registry or _reg. Anyway, _obj doesn't make a lot of sense to me, but if it's our convention I won't make a fuss. Until it is, though, I won't be changing my naming convention and won't consider it in my reviews. +1 for creating a convention and posting it on http://odoo-community.org/page/how-to Le 2014-12-02 07:10, Leonardo LeartS Donelli a écrit : Sorry, I thought I mentioned it: I'm not for using `_obj` at all! Personally I'm for the `_model` suffix. It's the most clear and explicit, it's often used by Odoo too so it doesn't clash with their code, and is correct by PEP8 standards. It's only 2 letters more than _obj! ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
[Openerp-community] Updates to Travis and maintainer-quality-tools
Hello community, I am writing for two reasons. One is to inform you that there has been a rather drastic change to what Travis tests in code quality. Second is a proposal for a more sensible approach to changes to automatic tests. Firstly, there are new checks done by pylint [1]: (all these can be seen with pylint2 --help-msg msg-id[,msg-id]) * W0104 pointless-statement: Used when a statement doesn't have (or at least seems to) any effect. * W0105 pointless-string-statement: Used when a string is used as a statement (which of course has no effect). * W0109 duplicate-key: Used when a dictionary expression binds the same key multiple times. * W0403 relative-import: Used when an import relative to the package directory is detected. * W0404 reimported: Used when a module is reimported multiple times. * W0621 redefined-outer-name: Used when a variable's name hide a name defined in the outer scope. * W0622 redefined-builtin: Used when a variable or function override a built-in. This adds on to the current tests: * E0101 return-in-init: Used when the special class method __init__ has an explicit return value. * E1124 redundant-keyword-arg: Used when a function call would result in assigning multiple values to a function parameter, one value from a positional argument and one from a keyword argument. * E1306 too-few-format-args: Used when a format string that uses unnamed conversion specifiers is given too few arguments * I0013 file-ignored: Used to inform that the file will not be checked * W0101 unreachable: Used when there is some code behind a return or raise statement, which will never be accessed. * W0102 dangerous-default-value: Used when a mutable value as list or dictionary is detected in a default value for an argument. * W assignment-from-none: Used when an assignment is done on a function call but the inferred function returns nothing but None. And Odoo specific tests (called odoo-lint): * EO001 print statement used: Used when there is a call to print The rules for flake8 are: * max-line-length = 79 * ignore unused imports in __init__.py I don't think anyone has gone out and documented this yet, and this is just a quick glance at the confs on my part. These rules should be put somewhere, I suggest the wiki of oca/maintainer-quality-tools. Secondly, the approach to changing these checks needs to be revised. Here is my proposal: We created an organization called oca-travis[2] with this org, pro-active fixes to repos can be done without affecting ongoing projects on oca before merging the new changes to the rules. 1. Before adding new rules, make sure a majority of projects are green (see the controlboard https://github.com/OCA/maintainer-quality-tools/pull/48). If they aren't, an effort should be done to get these tests to work with the current rules. 2. Make sure the community is informed about the new rules. I am talking an email not an obscure PR or Issue that only the most hardcore reviewers will see. 3. Make a PR 4. Accept PR with 3 people, do not merge yet. 5. Give a deadline before the new changes take effect, so that repos can be ready 6. The ones proposing a new rule, _must_ participate in fixing the errors _pro-actively_(ie. code sprint), a script to fork all repos in the org oca-travis and test them using a the MQT from PRs should not be very complicated to write. 7. Close to the deadline, audit the repos on oca-travis and see if the deadline should be extended. 8. Remind the community 9. Merge PR on MQT and pylint fixes from oca-travis 10. Update the wiki to document these new rules. At this point when the community complain, point to the emails and show that procedure was followed. Is this sensible? [1] https://github.com/OCA/maintainer-quality-tools/pull/127 [1] https://github.com/orgs/oca-travis signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] Updates to Travis and maintainer-quality-tools
Edit: Proposal has been added to the wiki page https://github.com/OCA/maintainer-quality-tools/wiki Feedback is appreciated. Le 2014-11-13 11:42, Sandy Carter a écrit : Hello community, I am writing for two reasons. One is to inform you that there has been a rather drastic change to what Travis tests in code quality. Second is a proposal for a more sensible approach to changes to automatic tests. Firstly, there are new checks done by pylint [1]: (all these can be seen with pylint2 --help-msg msg-id[,msg-id]) * W0104 pointless-statement: Used when a statement doesn't have (or at least seems to) any effect. * W0105 pointless-string-statement: Used when a string is used as a statement (which of course has no effect). * W0109 duplicate-key: Used when a dictionary expression binds the same key multiple times. * W0403 relative-import: Used when an import relative to the package directory is detected. * W0404 reimported: Used when a module is reimported multiple times. * W0621 redefined-outer-name: Used when a variable's name hide a name defined in the outer scope. * W0622 redefined-builtin: Used when a variable or function override a built-in. This adds on to the current tests: * E0101 return-in-init: Used when the special class method __init__ has an explicit return value. * E1124 redundant-keyword-arg: Used when a function call would result in assigning multiple values to a function parameter, one value from a positional argument and one from a keyword argument. * E1306 too-few-format-args: Used when a format string that uses unnamed conversion specifiers is given too few arguments * I0013 file-ignored: Used to inform that the file will not be checked * W0101 unreachable: Used when there is some code behind a return or raise statement, which will never be accessed. * W0102 dangerous-default-value: Used when a mutable value as list or dictionary is detected in a default value for an argument. * W assignment-from-none: Used when an assignment is done on a function call but the inferred function returns nothing but None. And Odoo specific tests (called odoo-lint): * EO001 print statement used: Used when there is a call to print The rules for flake8 are: * max-line-length = 79 * ignore unused imports in __init__.py I don't think anyone has gone out and documented this yet, and this is just a quick glance at the confs on my part. These rules should be put somewhere, I suggest the wiki of oca/maintainer-quality-tools. Secondly, the approach to changing these checks needs to be revised. Here is my proposal: We created an organization called oca-travis[2] with this org, pro-active fixes to repos can be done without affecting ongoing projects on oca before merging the new changes to the rules. 1. Before adding new rules, make sure a majority of projects are green (see the controlboard https://github.com/OCA/maintainer-quality-tools/pull/48). If they aren't, an effort should be done to get these tests to work with the current rules. 2. Make sure the community is informed about the new rules. I am talking an email not an obscure PR or Issue that only the most hardcore reviewers will see. 3. Make a PR 4. Accept PR with 3 people, do not merge yet. 5. Give a deadline before the new changes take effect, so that repos can be ready 6. The ones proposing a new rule, _must_ participate in fixing the errors _pro-actively_(ie. code sprint), a script to fork all repos in the org oca-travis and test them using a the MQT from PRs should not be very complicated to write. 7. Close to the deadline, audit the repos on oca-travis and see if the deadline should be extended. 8. Remind the community 9. Merge PR on MQT and pylint fixes from oca-travis 10. Update the wiki to document these new rules. At this point when the community complain, point to the emails and show that procedure was followed. Is this sensible? [1] https://github.com/OCA/maintainer-quality-tools/pull/127 [1] https://github.com/orgs/oca-travis ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
[Openerp-community] Proposal to add W0402 to Travis Style checking
Following my proposed procedure, I am informing the community that we intend to add a new style restriction [1]. W0402 deprecated-module:Used a module marked as deprecated is imported. Modules marked as deprecated: pdb,pudb,ipdb The reason behind this is that these are developement modules used to pause code in the middle of execution in order to debug. They are not intended for production but can be forgotten in the code and commited. To catch these is necessary since it halt code execution and this is not desired in production. The implication of this is that any code with any of these modules will fail on travis and be rejected by the reviewer. We await your feedback. If there are no objections, this new rule will be added to the entirety of OCA repos and any modules using them will fail the project as a whole and as a result, potentially block all pull requests until these modules are fixed. [1] https://github.com/OCA/maintainer-quality-tools/pull/113 Le 2014-11-13 11:42, Sandy Carter a écrit : Hello community, I am writing for two reasons. One is to inform you that there has been a rather drastic change to what Travis tests in code quality. Second is a proposal for a more sensible approach to changes to automatic tests. Firstly, there are new checks done by pylint [1]: (all these can be seen with pylint2 --help-msg msg-id[,msg-id]) * W0104 pointless-statement: Used when a statement doesn't have (or at least seems to) any effect. * W0105 pointless-string-statement: Used when a string is used as a statement (which of course has no effect). * W0109 duplicate-key: Used when a dictionary expression binds the same key multiple times. * W0403 relative-import: Used when an import relative to the package directory is detected. * W0404 reimported: Used when a module is reimported multiple times. * W0621 redefined-outer-name: Used when a variable's name hide a name defined in the outer scope. * W0622 redefined-builtin: Used when a variable or function override a built-in. This adds on to the current tests: * E0101 return-in-init: Used when the special class method __init__ has an explicit return value. * E1124 redundant-keyword-arg: Used when a function call would result in assigning multiple values to a function parameter, one value from a positional argument and one from a keyword argument. * E1306 too-few-format-args: Used when a format string that uses unnamed conversion specifiers is given too few arguments * I0013 file-ignored: Used to inform that the file will not be checked * W0101 unreachable: Used when there is some code behind a return or raise statement, which will never be accessed. * W0102 dangerous-default-value: Used when a mutable value as list or dictionary is detected in a default value for an argument. * W assignment-from-none: Used when an assignment is done on a function call but the inferred function returns nothing but None. And Odoo specific tests (called odoo-lint): * EO001 print statement used: Used when there is a call to print The rules for flake8 are: * max-line-length = 79 * ignore unused imports in __init__.py I don't think anyone has gone out and documented this yet, and this is just a quick glance at the confs on my part. These rules should be put somewhere, I suggest the wiki of oca/maintainer-quality-tools. Secondly, the approach to changing these checks needs to be revised. Here is my proposal: We created an organization called oca-travis[2] with this org, pro-active fixes to repos can be done without affecting ongoing projects on oca before merging the new changes to the rules. 1. Before adding new rules, make sure a majority of projects are green (see the controlboard https://github.com/OCA/maintainer-quality-tools/pull/48). If they aren't, an effort should be done to get these tests to work with the current rules. 2. Make sure the community is informed about the new rules. I am talking an email not an obscure PR or Issue that only the most hardcore reviewers will see. 3. Make a PR 4. Accept PR with 3 people, do not merge yet. 5. Give a deadline before the new changes take effect, so that repos can be ready 6. The ones proposing a new rule, _must_ participate in fixing the errors _pro-actively_(ie. code sprint), a script to fork all repos in the org oca-travis and test them using a the MQT from PRs should not be very complicated to write. 7. Close to the deadline, audit the repos on oca-travis and see if the deadline should be extended. 8. Remind the community 9. Merge PR on MQT and pylint fixes from oca-travis 10. Update the wiki to document these new rules. At this point when the community complain, point to the emails and show that procedure was followed. Is this sensible? [1] https://github.com/OCA/maintainer-quality-tools/pull/127 [1] https://github.com/orgs/oca-travis ___ Mailing list
Re: [Openerp-community] Proposal to add W0402 to Travis Style checking
I think the PR could be expanded to add/remove deprecated modules from the .travis file. The reason for this is that for certain branches openerp.osv.osv is acceptable and on the newer ones, they have become deprecated. There may be truth that the call to set_trace should be the one blocked. Please raise your objection on the merge proposal. Le 2014-11-13 12:24, Georges Racinet a écrit : On 11/13/2014 06:21 PM, Georges Racinet wrote: Hi Sandy, On 11/13/2014 06:13 PM, Sandy Carter wrote: Following my proposed procedure, I am informing the community that we intend to add a new style restriction [1]. W0402 deprecated-module:Used a module marked as deprecated is imported. Modules marked as deprecated: pdb,pudb,ipdb The reason behind this is that these are developement modules used to pause code in the middle of execution in order to debug. They are not intended for production but can be forgotten in the code and commited. To catch these is necessary since it halt code execution and this is not desired in production. The implication of this is that any code with any of these modules will fail on travis and be rejected by the reviewer. do you forbid pdb.set_trace() or the import of pdb and friends as a whole ? If that's the latter, I'd be firmly against it, since it also forbids very useful stuff, such as insertion of (optional, of course) pdb post_mortem calls. Of course if there's a way to bypass it with a # noqa comment or equivalent, this objection does not stand. Forgot to conclude with what is obviously needed : thank you and other people working on improving the quality ! This is incredibly positive. Regards, ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] Updates to Travis and maintainer-quality-tools
IMHO I like more use a .md file into same project. (not wiki) Wiki is in .md file format. It is better for this highlevel explanation to be in the wiki, IMHO You can add a new feature in PR and add new doc in same PR. md file is more portable. *For your fork *For you use in other git tool. Example: bitbucket, gitlab (In same project) The wiki is a github repo that you can clone with https://github.com/OCA/maintainer-quality-tools.wiki.git Contents are: Home.md signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] Suggestion for OCA conventions
Le 2014-10-22 04:09, Leonardo Pistone a écrit : I think we should wipe the document, and start entering the conventions that are already accepted, that is those that we already check with flake8 and pylint. +1 On the topic of one-file-per-class, I understand the reasons, but I vote -1 because it seems too restricting to me, and I see many good quality python projects not doing so. Still, I am not fighting on that. I consider it a minor point. I would just like to clarify that I am not asking for one-file-per-class, but one-file-per-model. Helper classes should be where it is most logical to put them. What makes the case of Odoo different from some other python projects is that in 90% of our cases we deal with ORM models and not purely Object Oriented classes. Usual workflow consists of altering one or multiple models. In my opinion, having them separate improves readability and makes maintenance easier. Some are suggesting we do the one-file-per-model as a Nice to have. Have no problem with that, but I'd rather call it a Strong recommendation. ;) Take for example any of the huge python files in the core, like account.py. Imagine it going through our code review. The first pass would be automatic: we would get rid of unused variables, long lines and so on. We could ask to split the classes in smaller files. That is great but it is just the start. Then we would get to the real code review, where humans say things like: - what are __compute(), res, res2, ids, ids2? What does that mean? Can you refactor? - why a class with 43 methods? maybe we need a service class, or a mixin? - the docstring says that context is a context, and we know that. Instead, describe what the method if it is not clear from the name. - this duplicates code from class XY. can we make it more orthogonal? - I just do not understand at all what this method is about. can you clarify / refactor / document? And so on. The same of course goes for tests: it is a great and necessary start that the machine tells us the coverage, but then our review will say, for example this test does not reflect the use case in the manifest, can you explain?. +1 to this, I think we could reformulate this to fit it into the guidelines document to, at least, explain the process and what we reviewers should look for. signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] Suggestion for OCA conventions
Hi, My issue with leaving it to subjective criticism is: Firstly, if you're new and learning the ropes to contribution to OCA and you do your homework, you're going to do two things to make sure your module gets integrated. First you'll check existing modules and emulate what they do and second you'll read the guidelines. Like I mentioned at the beginning, there are many cases of X models in files named like 'product.py', and if you look at the guidelines[1], it is still bare in many parts. We see this today, a new dev will do her work, prepare her module using these guidelines. When he finally does a pull request, we come down on him with these subjective reviews, that we are used to, but to the dev, these seem completely arbitrary. The result is often that the new dev will redo her module multiple times with no more guidelines than the review of a select few contributors who have had the time to review her code. Another possible outcome, is that these PRs get stuck in limbo where the dev might have moved on to another project. A second problem with subjective criticism is when a disagreement is met or a dev making a PR is unwilling to change his code and chooses to argue every point. Without the points in the review page, a subjective review has very little weight, you can't just point at the page and say: These are the standards we do our review by, this is what everyone who contributes agrees to for the sake of uniform coding style. Instead we find ourselves saying: This is better because it is, This is what is done in most modules, This is not yet on the page. These two situations happen quite often. I have multiple less experienced Odoo developers come to me frustrated because their PRs are being stalled for what seems to them to be arbitrary reasons. The first thing they ask is usually What does she mean by X? This seems unreasonable. I often reply with That kind of sucks but I agree with his review. the second thing they ask is Where can I find all these guidelines so I can avoid being stalled on getting my code merged? And for that, I would love to be able to refer to the guidelines page[1]. At the present, I can't really... What the consensus I seem to get out of this is: Often it is better to separate the models (especially in xml), but there are some acceptable exceptions: * Small changes to models * One to many relationships (single column add to related model) * At some point, a small change becomes to big and the file must be split. * All changes are very closely related to a same feature * Wizards * Connectors (I'm adding this one) No one seemed to object to naming the Class, .py file and xml files according to the model (or largest model in the case of filenames). Is this something we can agree on? [1] http://odoo-community.org/page/website.how-to Le 2014-10-20 05:39, Leonardo Pistone a écrit : Hi all, I understand the convenience of finding classes easily, and the reasons behind this are sound. Still, I do not sopport such a rule on splitting files. Still, I think we can and should work to improve subjective quality and clarity of code. Example: after the machine checked lint, I think we can (and should) gradually move to comments like - this method / this file is long, can you split it? - I don't understand what this is for, can you comment or refactor? - why do we need that? (comment or refactor) - (and one day, gradually...) could you decouple this logic from the database schema to a pure class? TL;DR I oppose a rule on file length and such, but I favor subjective criticism to get the code as clear as possible. Thanks to all for the involvement! On 10/19/2014 10:46 PM, Graeme Gellatly wrote: But for me this comes down to personal preference, not sure it needs to be a convention. ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
[Openerp-community] Suggestion for OCA conventions
Hi, I would like propose adding the following to the Module section in http://odoo-community.org/page/website.how-to Each XML and python script should be separated and named by model. example: _name = 'sale.order' # goes in a file named sale_order.py and the class name should be SaleOrder _inherit = 'sale.order.line' # goes in a file named sale_order_line.py and the class name should be SaleOrderLine !-- Goes in a file named res_partner_data.xml -- !-- Or goes in a file named res_partner_demo.xml -- record name=example_partner model=res.partner.../record !-- Goes in a file named res_company_view.xml -- record id=res_company_form model=ir.ui.view field name=modelres.company/field ... /record !-- Goes in a file named purchase_order_workflow.xml -- record id=purchase_order_workflow model=ir.ui.view field name=osvpurchase.order/field ... /record !-- Goes in a file named payment_order_report.xml -- report id=payment_order_report model=payment.order ... / signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] Use of new odoo API when porting OCA addons
It's been done already: https://github.com/nbessi/odoo_new_api_guideline Le 2014-08-12 16:45, David Arnold - El Alemán a écrit : +1 for test coverage 1. I anyone willing to write (in his limited time) a tutorial to be understodd by everyone? 2. We could maka a general call to test cases as kind of a season topic, probably... 3. Accordingly we should implement proper monitoring (!!!) coveralls.io , etc. 4. Once we have this, we have a garant for stability 5. We also have an important marketing argument! Test case coverage core and oca is a nightmare :) I personally am struggeling with the first hurdel (lack of know-how) signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] Use of new odoo API when porting OCA addons
Le 2014-08-12 05:21, Alexandre Fayolle a écrit : IMO it is more important to improve test coverage than to port to the new API. Absolutely, increasing coverage is the best way to avoid regressions when reimplementing, such as coverting from one API to another. signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-canada/7.0-missing-payroll-access into lp:openerp-canada
Review: Resubmit Please move this MP to https://github.com/OCA/l10n-canada More info at https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub -- https://code.launchpad.net/~openerp-community/openerp-canada/7.0-missing-payroll-access/+merge/226187 Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-canada/7.0-missing-payroll-access. ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/openerp-sage-50/7.0-exportsage50 into lp:openerp-sage-50
Review: Resubmit This PR has been moved to https://github.com/OCA/connector-sage-50/pull/7 Please continue further development there. -- https://code.launchpad.net/~savoirfairelinux-openerp/openerp-sage-50/7.0-exportsage50/+merge/191893 Your team OpenERP Community Reviewer/Maintainer is requested to review the proposed merge of lp:~savoirfairelinux-openerp/openerp-sage-50/7.0-exportsage50 into lp:openerp-sage-50. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into lp:knowledge-addons/7.0
The proposal to merge lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into lp:knowledge-addons/7.0 has been updated. Status: Approved = Rejected For more details, see: https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960 -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960 Your team OpenERP Community Reviewer/Maintainer is requested to review the proposed merge of lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into lp:knowledge-addons/7.0
Review: Resubmit This MP have been moved to MP to https://github.com/OCA/knowledge/pull/5 -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960 Your team OpenERP Community Reviewer/Maintainer is requested to review the proposed merge of lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis into lp:knowledge-addons/7.0
Review: Resubmit This MP have been moved to MP to https://github.com/OCA/knowledge/pull/6 -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis/+merge/212258 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis into lp:knowledge-addons/7.0
The proposal to merge lp:~savoirfairelinux-openerp/knowledge-addons/cmis into lp:knowledge-addons/7.0 has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis/+merge/212258 -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis/+merge/212258 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into lp:knowledge-addons/7.0
Review: Resubmit This MP have been moved to MP to https://github.com/OCA/knowledge/pull/7 -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260 Your team OpenERP Community Reviewer/Maintainer is requested to review the proposed merge of lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into lp:knowledge-addons/7.0
The proposal to merge lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into lp:knowledge-addons/7.0 has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260 -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260 Your team OpenERP Community Reviewer/Maintainer is requested to review the proposed merge of lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_write into lp:knowledge-addons/7.0
The proposal to merge lp:~savoirfairelinux-openerp/knowledge-addons/cmis_write into lp:knowledge-addons/7.0 has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_write/+merge/213940 -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_write/+merge/213940 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_modules into lp:partner-contact-management
This is for cases where one partner (Mike Fletcher President of Agrolait) can be part of another company (Mike Fletcher VP of AsusTEK) in a different function. The module helps track these functions. -- https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_modules/+merge/217775 Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname into lp:openerp-hr
Ported to https://github.com/OCA/hr/pull/3 -- https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname/+merge/204065 Your team HR Core Editors is requested to review the proposed merge of lp:~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname into lp:openerp-hr. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname into lp:openerp-hr
The proposal to merge lp:~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname into lp:openerp-hr has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname/+merge/204065 -- https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname/+merge/204065 Your team HR Core Editors is requested to review the proposed merge of lp:~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname into lp:openerp-hr. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into lp:knowledge-addons/7.0
Review: Approve -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960 Your team OpenERP Community Reviewer/Maintainer is requested to review the proposed merge of lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into lp:knowledge-addons/7.0
The proposal to merge lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into lp:knowledge-addons/7.0 has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960 -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960 Your team OpenERP Community Reviewer/Maintainer is requested to review the proposed merge of lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname into lp:openerp-hr
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname into
lp:openerp-hr.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname/+merge/204065
Add hr_employee_firstname module; it adds the firstname field on employee; name
is considered like the last name
--
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname/+merge/204065
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed merge of lp:~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname
into lp:openerp-hr.
=== added directory 'hr_employee_firstname'
=== added file 'hr_employee_firstname/__init__.py'
--- hr_employee_firstname/__init__.py 1970-01-01 00:00:00 +
+++ hr_employee_firstname/__init__.py 2014-03-04 16:23:46 +
@@ -0,0 +1,23 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2010 - 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import hr
=== added file 'hr_employee_firstname/__openerp__.py'
--- hr_employee_firstname/__openerp__.py 1970-01-01 00:00:00 +
+++ hr_employee_firstname/__openerp__.py 2014-03-04 16:23:46 +
@@ -0,0 +1,54 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2010 - 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': 'Employee First Name, Last Name',
+'version': '0.1',
+'author': 'Savoir-faire Linux',
+'maintainer': 'Savoir-faire Linux',
+'website': 'http://www.savoirfairelinux.com',
+'license': 'AGPL-3',
+'category': 'Human Resources',
+'summary': 'Adds First Name to Employee',
+'description':
+Employee First Name, Last Name
+==
+
+This module allows you to add firstname and lastname in employee form,
+and concatenate both in name field.
+
+Contributors
+
+* El Hadji Dem (elhadji@savoirfairelinux.com)
+* Sandy Carter (sandy.car...@savoirfairelinux.com)
+,
+'depends': [
+'hr',
+],
+'external_dependencies': {},
+'data': [
+'hr_view.xml',
+],
+'demo': [],
+'test': [],
+'installable': True,
+}
=== added file 'hr_employee_firstname/hr.py'
--- hr_employee_firstname/hr.py 1970-01-01 00:00:00 +
+++ hr_employee_firstname/hr.py 2014-03-04 16:23:46 +
@@ -0,0 +1,50 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2010 - 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public
Re: [Openerp-community] OCA: transition from Launchpad to Github
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 2014-06-26 10:50, Guewen Baconnier a écrit : 4. Sandy added this great stuff to the project. Thank you :) 5. Set modules to uninstallable with: ack installable --py -l | xargs sed s/[\|']installable[\|']: True/'installable': False/ -i Just a point: In OCA/canada, I have been renaming the folders of uninstallable modules to modulename_unported with _unported at the end to help travis not test these modules. This may be too hackish, but it was the most straightforward solution I have considered. -BEGIN PGP SIGNATURE- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTrHLwAAoJEKYZqB2wZ/VqVJEH/R88X74ySoFdw9rkWuF5UShr ukWu0rmJk7iNZPu/oskLq6lgTqRZCGZGS5EFZtqsB8AvIycJ6YtYOXui9xkhagtZ v3Hn8bR0SH058gQxIMPsET7uB+LUkrSKjqOhsdzlJA+62RMBM8yovGZtNREhrUza mx59W7NYJLndwd7QCFfJ/C1ftdfpK0s7ECUYCQJV2K0qoSCMKQ4jP+DFLtvphorW qqzKYLuQOdGDOCcczvgh0mDd+sZ3g9AOVV6MnXSHaLKVct8u0YmrN8I3B04B5CrE 42I9J1+rOi7x7q1Og9h07ghd45bBD07UGTrw0V+GkXCli4eOKyV14BpRE7S26cw= =mQIk -END PGP SIGNATURE- ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_write into lp:knowledge-addons/7.0
Diff comments:
=== added directory 'cmis_write'
=== added file 'cmis_write/__init__.py'
--- cmis_write/__init__.py1970-01-01 00:00:00 +
+++ cmis_write/__init__.py2014-05-29 22:13:35 +
@@ -0,0 +1,26 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import ir_attachment
+from . import metadata
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added file 'cmis_write/__openerp__.py'
--- cmis_write/__openerp__.py 1970-01-01 00:00:00 +
+++ cmis_write/__openerp__.py 2014-05-29 22:13:35 +
@@ -0,0 +1,88 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': 'CMIS Write',
+'version': '0.1',
+'category': 'Knowledge Management',
+'summary': 'Create Document in DMS from OpenERP',
+'description':
+Add Documents from OpenERP
+==
+
+This module allows you to store OpenERP document in the DMS repository.
This is badly formulated and has grammatical errors.
+
+Configuration
+=
+
+* Create a new CMIS backend with the host, login and password.
+* Configure the path in the repository where documents will be dropped.
+ By default, it uses the home directory of the user.
+
+Usage
+=
+
+* On one OpenERP record, click Add document.
+* Upload your documents
+* Uploaded documents will be enqueued for storage in the DMS
+
+Add Metadata
+
+
+To manage a custom aspect using CMIS (and all the other supported ways)
+you have to:
+
+* Define a new custom model configuring Alfresco. To do this I suggest you
+http://wiki.alfresco.com/wiki/Step-By-Step:_Creating_A_Custom_Model.
remove the period at the end of your links, it sends the wrong url
+
+* Add the custom aspect to the document you upload or create in Alfresco.
+Using CMIS I suggest you:
+http://docs.alfresco.com/4.1/index.jsp?topic=%2Fcom.alfresco.enterprise.doc%2Fconcepts%2Fopencmis-ext-adding.html.
remove the period at the end of your links, it sends the wrong url
+
+* Set the custom property in the way you probably know using CMIS.
You may want to reformulate this.
+
+Contributors
+
+* El Hadji Dem (elhadji@savoirfairelinux.com)
+,
+'author': 'Savoir-faire Linux',
+'website': 'www.savoirfairelinux.com',
+'license': 'AGPL-3',
+'depends': [
+'document',
+'cmis',
+],
+'data': [
+'metadata_view.xml',
+'security/ir.model.access.csv',
+],
+'js': [
+'static/src/js/document.js'
+],
+'qweb': [],
+'test': [],
+'demo': [],
+'installable': True,
+'auto_install': False,
+}
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added directory 'cmis_write/i18n'
=== added file 'cmis_write/i18n/cmis_write.pot'
--- cmis_write/i18n/cmis_write.pot1970-01-01 00:00:00 +
+++ cmis_write/i18n/cmis_write.pot2014-05-29 22:13:35 +
@@ -0,0 +1,89 @@
Re: [Openerp-community] OCA: transition from Launchpad to Github
It's a little incontinent, but the setting to skip tests if the .travis.yml file is missing is off by default. To enable this setting, if you have admin rights to the repos, Log into https://travis-ci.org using your github credentials. Go to https://travis-ci.org/profile/OCA and click on the wrench of a repo Enable the Build only if .travis.yml is present option As for the documentation, I started from http://docs.travis-ci.com/user/languages/python/ and built from there. For postgis which is system package, install it using apt-get in pre-isntall: http://docs.travis-ci.com/user/installing-dependencies/ geojson, being a python package, can be installed in the install section with pip -- Sandy - Mail original - De: Nicolas Bessi nicolas.be...@camptocamp.com À: Joël Grand-Guillaume joel.grandguilla...@camptocamp.com Cc: openerp-community@lists.launchpad.net, Guewen Baconnier guewen.baconn...@camptocamp.com Envoyé: Mercredi 25 Juin 2014 14:25:06 Objet: Re: [Openerp-community] OCA: transition from Launchpad to Github Hello Sandy, What would you think about changing travis setup for OCA repoitories during transition period in order not to be run if travis.yml is missing. This will prevent failed build mail to be sent. I would also really appreciate if you can give us again pointer to your travis setup documentation. I want to add required dependencies to be able to run test on geospatial-addons that have special requierment like postgis and geojson. Thanks for the job Regards Nicolas 2014-06-25 20:00 GMT+02:00 Joël Grand-Guillaume joel.grandguilla...@camptocamp.com : Hi Daniel, We though about using the LP synchro against github to periodically pull github branches. No need of special script here, so legacy deployments should be fine. Regards, Joël On Wed, Jun 25, 2014 at 4:48 PM, Daniel Reis dgr...@sapo.pt wrote: Can you 'git push' back to the bzr remote? Yes, git-remote-bzr supports that. Note that we shouldn't need that here. Stéphane Bidoul proposed a migration strategy on this thread, on 21/06/2014, based on git-bzr-ng. For short you: * Use git bzr clone from Launchpad, and then git bzr import to fetch other branches (6.1, 7.0, ...) * Afterwards you can both git push to git/github remotes and git bzr push to LP. The main advantage of his solution was that it makes easy to keep LP in sync with the changes made on GitHub. Even if we do all maintenance on GitHub, some people would like to be able to keep using LP for legacy deployments, and it's important for them to have a way to sync GitHub commit to the LP repos. But from your answer, probably git-remote-bz can also achieve that. DR __ _ Mailing list: https://launchpad.net/~ openerp-community Post to : openerp-community@lists. launchpad.net Unsubscribe : https://launchpad.net/~ openerp-community More help : https://help.launchpad.net/ ListHelp -- camp to camp INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS Joël Grand-Guillaume Division Manager Business Solutions +41 21 61 9 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- Nicolas Bessi Senior ERP consultant Business Solution technical manager Camptocamp SA PSE A CH-1015 Lausanne http://openerp.camptocamp.com Direct: +41 21 619 10 26 Office: +41 21 619 10 10 ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] OCA: transition from Launchpad to Github
On the topic of Runbot. Here at SLF, I have managed to deploy it for our own uses. I am sure many of you have read it already but for those who didn't here's the result of my experiment[1]. Since then, I have made an addon to runbot which gives more customisability to what runbot runs, mainly to work with our internal installation script which uses the buildout recipe. The addon, non-intrusively adds the ability to run pre-run scripts, custom server locations and additional parametters to runbot jobs. I also plan on making another module for integration with gitlab instead of github, again for internal projects. The problem I am facing is that I currently have 4 open Pull Requests[2] for odoo-extra (where runbot code is hosted) which are quite vital to testing OCA modules and it doesn't look like they are getting any attention they deserve. Adding to that, I would love to contribute my runbot_custom module, but there is currently nowhere to host it. The latter problem can be easily resolved by pointing out a repo to put it in or the creation of a runbot-addons repo. Should we fork odoo-extra and add modules to the fork, or should we wait until the fixes get integrated? [1] http://bwrsandman.wordpress.com/2014/06/16/using-odoos-runbot-to-test-oca-addons/ [2] https://github.com/odoo/odoo-extra/pulls/bwrsandman -- Sandy - Mail original - De: Moises Lopez moylop...@vauxoo.com À: Laurent Mignon laurent.mig...@acsone.eu Cc: openerp-community openerp-community@lists.launchpad.net Envoyé: Lundi 23 Juin 2014 09:32:03 Objet: Re: [Openerp-community] OCA: transition from Launchpad to Github Hello, +1 with full migration to github... with scripts. In github you will have new runbot available with PR for test it. In github you will have just one tool of version control. And you can make some script to migrate base branches and merge proposal branches. Note, in old runbot refactory by vauxoo we check the MP here: http://bazaar.launchpad.net/~vauxoo/openerp-tools/runbot7_vauxoo_stable/view/head:/openerp-runbot/openerprunbot/core.py#L715 We can use same concept to migrate MP to github. *Bugs and blueprint to issue. Translation Olivier told us: 7. Translations [Planned Q3 2014] The v8 release is too soon to allow setting up a new translation process on top of GitHub, especially as there is almost nothing built-in. Translators will still continue to work on LP at least until v8 is released. We will set up a replay system to update the translation templates `addons/i18n/*.pot` on LP with the latest terms from master/v8.0 in GitHub. And in the other direction, we will replay the PO updates on `addons/i18n/*.po` from LP to GitHub. After the release of v8 we will set up a new translation process, probably built on top of Transifex. *TODO script. We can help with dev of this script in python if you like it. El jun 23, 2014 8:07 AM, Mignon, Laurent laurent.mig...@acsone.eu escribió: HI, I am also in favor of an earlier migration to github. We are a community, and as such I would like to avoid introducing processes and tools that would be specific OCA. The greater part of us probably have enough experience to continue with both systems and even if IMHO it will introduce a lot of unnecessary complexity. However, if we want to remain / become an attractive and open community that can only be done if we use the tools of the community based on non-specific process to OCA. How to explain to a new contributor that he must know launchpad to contribute to OCA modules in 7.0 and Github for 8.0? Are our employers willing to bear the cost of training launchpad and github? Not to mention the specific processes introduced by OCA to support this duality ... If OCA remains on launchpad while Odoo is on github, I feel we may see a large number of OCA modules migrated to Github outside the control of OCA because people simply find it easier to have everything on Github and will want to avoid further invest in launchpad. One last point, I am one of those who blames Odoo not always follow community practices whether in terms of formatting code (pep8) or in the packaging of addons (python eggs). At the transition from launchpad to github, I'd avoid that OCA introduce its own processes and tools to support both systems simultaneously. I think if we do not choose now to migrate everything to Github, it will never be possible. My 2 cents, lmi On Mon, Jun 23, 2014 at 1:43 PM, Info SHS-AV i...@shs-av.com wrote: Il 23/06/2014 12:58, Lorenzo Battistini ha scritto: On 06/23/2014 11:16 AM, Joël Grand-Guillaume wrote: Hi, First thank you for your feedback. About the LP - Github migration. The main arguments in favor of keeping v 6.1 and 7.0 on LP and mirror on Github is that we do have lot's of reviews in progress. It'll be difficult to maintain reviews on LP if the master is Github. +1 We could follow
Re: [Openerp-community] OCA: transition from Launchpad to Github
Hi David, I thought about adding pep8 checking. Though it is possible, the design of runbot does not exactly make this easy, and since we already have travis doing this, I have not made it a priority. In the official runbot code, there is some commented out coverage code, so they have obviously planned to use it. The rundown of runbot's limitations: runbot will run functions with the name `job_##_test_name`, currently it only has: * job_10_test_base * job_20_test_all * job_30_run Adding pep8 would be something like adding `job_05_test_pep8` but there are two problems: * Firsly, job_10_test_base is the job which will do the setup of your work tree (git checkout, etc). Optimally, a better design would have had that be in a separate job on its own like `job_00_checkout` As it is, you can't run pep8 before the actual Odoo tests. * Secondly, runbot error checking is really just an Odoo log parser, it is designed to find Odoo Errors, to have it look for and display the pep8 errors in the log view web page would require some significant refactoring of the code and considering there has been very little activity for my few relatively minor fixes, I hold no hope to have that integrated any time soon. -- Sandy - Mail original - De: David Arnold - El Alemán da...@elaleman.co À: Joël Grand-Guillaume joel.grandguilla...@camptocamp.com Cc: Sandy Carter sandy.car...@savoirfairelinux.com, openerp-community openerp-community@lists.launchpad.net Envoyé: Lundi 23 Juin 2014 16:06:10 Objet: Re: [Openerp-community] OCA: transition from Launchpad to Github @ Sandy, we already love your travis-pep8 combo and we are actively using it (bacause style matters :) ). However of Runbot killerfeature of a running DB, I wanted to ask, if you probably could include pep8 on the diff on the runbot. AFAIK you proposed something on odoo, and I don't recall if they got your idea (about the diffs) properly. However, the community could be free to choose including a pep8 style check on every future diff. I'm really looking forward to get all this state of the art stuff working upon the github transition. :D 2014-06-23 13:43 GMT-05:00 Joël Grand-Guillaume joel.grandguilla...@camptocamp.com : Hi Sandy, This is very interesting indeed ! What I can suggest is: * You're part of the team that maintain the maintainers tools. I suggest that you use this repository to share your work with a pull request : https://github.com/OCA/maintainers-tools (the OCA repo to help the community maintainers team) * For the suggestion about forking odoo-extra, I will try to make the pull request reviewed instead of forking them. If in the hurry, fork it for now. * Concerning this work of building a community runbot, I added you to our odoo instance as a member of the community maintainer project. You now have a task assigned (if ok for you, so I let you take this responsibility). If you agree, please feel free to take note in the tasks, adding description and changing his status. Thanks a million for this ! Regards, Joël On Mon, Jun 23, 2014 at 6:21 PM, Sandy Carter sandy.car...@savoirfairelinux.com wrote: On the topic of Runbot. Here at SLF, I have managed to deploy it for our own uses. I am sure many of you have read it already but for those who didn't here's the result of my experiment[1]. Since then, I have made an addon to runbot which gives more customisability to what runbot runs, mainly to work with our internal installation script which uses the buildout recipe. The addon, non-intrusively adds the ability to run pre-run scripts, custom server locations and additional parametters to runbot jobs. I also plan on making another module for integration with gitlab instead of github, again for internal projects. The problem I am facing is that I currently have 4 open Pull Requests[2] for odoo-extra (where runbot code is hosted) which are quite vital to testing OCA modules and it doesn't look like they are getting any attention they deserve. Adding to that, I would love to contribute my runbot_custom module, but there is currently nowhere to host it. The latter problem can be easily resolved by pointing out a repo to put it in or the creation of a runbot-addons repo. Should we fork odoo-extra and add modules to the fork, or should we wait until the fixes get integrated? [1] http://bwrsandman.wordpress.com/2014/06/16/using-odoos-runbot-to-test-oca-addons/ [2] https://github.com/odoo/odoo-extra/pulls/bwrsandman -- Sandy - Mail original - De: Moises Lopez moylop...@vauxoo.com À: Laurent Mignon laurent.mig...@acsone.eu Cc: openerp-community openerp-community@lists.launchpad.net Envoyé: Lundi 23 Juin 2014 09:32:03 Objet: Re: [Openerp-community] OCA: transition from Launchpad to Github Hello, +1 with full migration to github... with scripts. In github you will have new runbot available with PR for test
Re: [Openerp-community] OCA: transition from Launchpad to Github
I do not have the rights to add repos to OCA, but runbot-addons has a nice ring to it ;) -- Sandy - Mail original - De: Joël Grand-Guillaume joel.grandguilla...@camptocamp.com À: Sandy Carter sandy.car...@savoirfairelinux.com Cc: Moises Lopez moylop...@vauxoo.com, openerp-community openerp-community@lists.launchpad.net Envoyé: Lundi 23 Juin 2014 18:31:41 Objet: Re: [Openerp-community] OCA: transition from Launchpad to Github Hi Sandy, You're right. I think the way out is to create a new project/repository called runbot (any other suggestions ?) under the responsibility of the Maintainer team. This way you can push the needed community addon repo. What do you think ? For me, it makes sense and I agree we don't want both non-odoo modules and odoo modules under the same repository. Thank you for accepting this role. Let me know if anything you need is missing. Joël On Tue, Jun 24, 2014 at 12:12 AM, Sandy Carter sandy.car...@savoirfairelinux.com wrote: Hi Joël, Thank you for adding me to the maintainers repo. There is an issue, though. That repo is not a community addon repo. This makes me uneasy about mixing a module with non-module scripts. I would rather there be a repo for addons to runbot as there are repos for hr, accounting, etc. I am, also unsure if including the repo in addons path would cause problems with odoo at launch. Forking can wait. It would, however be nice to have these fixes officially reviewed to avoid code conflicts in the future. I wouldn't mind the task you want to give me. If it's just setting it up, it is ridiculously easy, though in need to documentation. -- Sandy - Mail original - De: Joël Grand-Guillaume joel.grandguilla...@camptocamp.com À: Sandy Carter sandy.car...@savoirfairelinux.com Cc: Moises Lopez moylop...@vauxoo.com , openerp-community openerp-community@lists.launchpad.net Envoyé: Lundi 23 Juin 2014 14:43:11 Objet: Re: [Openerp-community] OCA: transition from Launchpad to Github Hi Sandy, This is very interesting indeed ! What I can suggest is: * You're part of the team that maintain the maintainers tools. I suggest that you use this repository to share your work with a pull request : https://github.com/OCA/maintainers-tools (the OCA repo to help the community maintainers team) * For the suggestion about forking odoo-extra, I will try to make the pull request reviewed instead of forking them. If in the hurry, fork it for now. * Concerning this work of building a community runbot, I added you to our odoo instance as a member of the community maintainer project. You now have a task assigned (if ok for you, so I let you take this responsibility). If you agree, please feel free to take note in the tasks, adding description and changing his status. Thanks a million for this ! Regards, Joël On Mon, Jun 23, 2014 at 6:21 PM, Sandy Carter sandy.car...@savoirfairelinux.com wrote: On the topic of Runbot. Here at SLF, I have managed to deploy it for our own uses. I am sure many of you have read it already but for those who didn't here's the result of my experiment[1]. Since then, I have made an addon to runbot which gives more customisability to what runbot runs, mainly to work with our internal installation script which uses the buildout recipe. The addon, non-intrusively adds the ability to run pre-run scripts, custom server locations and additional parametters to runbot jobs. I also plan on making another module for integration with gitlab instead of github, again for internal projects. The problem I am facing is that I currently have 4 open Pull Requests[2] for odoo-extra (where runbot code is hosted) which are quite vital to testing OCA modules and it doesn't look like they are getting any attention they deserve. Adding to that, I would love to contribute my runbot_custom module, but there is currently nowhere to host it. The latter problem can be easily resolved by pointing out a repo to put it in or the creation of a runbot-addons repo. Should we fork odoo-extra and add modules to the fork, or should we wait until the fixes get integrated? [1] http://bwrsandman.wordpress.com/2014/06/16/using-odoos-runbot-to-test-oca-addons/ [2] https://github.com/odoo/odoo-extra/pulls/bwrsandman -- Sandy - Mail original - De: Moises Lopez moylop...@vauxoo.com À: Laurent Mignon laurent.mig...@acsone.eu Cc: openerp-community openerp-community@lists.launchpad.net Envoyé: Lundi 23 Juin 2014 09:32:03 Objet: Re: [Openerp-community] OCA: transition from Launchpad to Github Hello, +1 with full migration to github... with scripts. In github you will have new runbot available with PR for test it. In github you will have just one tool of version control. And you can make some script to migrate base branches and merge proposal branches. Note, in old runbot refactory by vauxoo we check the MP here: http
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into lp:knowledge-addons/7.0
Thank you for your review, Guewen, I learned a few things.
Diff comments:
=== added directory 'cmis_read'
=== added file 'cmis_read/__init__.py'
--- cmis_read/__init__.py 1970-01-01 00:00:00 +
+++ cmis_read/__init__.py 2014-06-12 19:57:17 +
@@ -0,0 +1,25 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import wizard
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added file 'cmis_read/__openerp__.py'
--- cmis_read/__openerp__.py 1970-01-01 00:00:00 +
+++ cmis_read/__openerp__.py 2014-06-12 19:57:17 +
@@ -0,0 +1,74 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': 'CMIS Read',
+'version': '0.1',
+'category': 'Knowledge Management',
+'summary': 'Store Document File in a Remote CMIS Server',
+'description':
+This module allows you to use the CMIS backend to search in the DMS
repository
+and attach documents to OpenERP records.
+
+Configuration
+=
+
+Create a new CMIS backend with the host, login and password.
+
+Usage
+=
+
+* On one OpenERP record, click Add from DMS.
+* Type your query and then click on Search.
+* Filter your results if necessary
+* Select the documents you want to attach
+* Selected documents will be enqueued for importing
+
+Contributors
+
+* El Hadji Dem (elhadji@savoirfairelinux.com)
+,
+'author': 'Savoir-faire Linux',
+'website': 'www.savoirfairelinux.com',
+'license': 'AGPL-3',
+'depends': [
+'document',
+'cmis'
+],
+'data': [
+'security/ir.model.access.csv',
+'wizard/document_wizard_view.xml',
+],
+'js': [
+'static/src/js/document.js'
+],
+'qweb': [
+'static/src/xml/document.xml'
+],
+'test': [],
+'demo': [
+],
+'installable': True,
+'auto_install': False,
+}
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added directory 'cmis_read/i18n'
=== added file 'cmis_read/i18n/cmis_read.pot'
--- cmis_read/i18n/cmis_read.pot 1970-01-01 00:00:00 +
+++ cmis_read/i18n/cmis_read.pot 2014-06-12 19:57:17 +
@@ -0,0 +1,119 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#* cmis_read
+#
+msgid
+msgstr
+Project-Id-Version: OpenERP Server 7.0\n
+Report-Msgid-Bugs-To: \n
+POT-Creation-Date: 2014-03-21 14:55+\n
+PO-Revision-Date: 2014-03-21 10:55-0500\n
+Last-Translator: EL Hadji DEM elhadji@savoirfairelinux.com\n
+Language-Team: \n
+MIME-Version: 1.0\n
+Content-Type: text/plain; charset=UTF-8\n
+Content-Transfer-Encoding: 8bit\n
+Plural-Forms: \n
+X-Generator: Poedit 1.5.4\n
+
+#. module: cmis_read
+#: field:ir.attachment.dms,file_id:0
+msgid File ID
+msgstr
+
+#. module: cmis_read
+#: field:ir.attachment.dms.wizard,attachment_ids:0
+msgid Attachments
+msgstr
+
+#. module:
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis into lp:knowledge-addons/7.0
Looking a lot better, still issues about the comments preceding functions which
would be more useful as docstrings.
Diff comments:
=== added directory 'cmis'
=== added file 'cmis/__init__.py'
--- cmis/__init__.py 1970-01-01 00:00:00 +
+++ cmis/__init__.py 2014-06-12 19:47:23 +
@@ -0,0 +1,26 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import cmis_model
+from . import backend
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added file 'cmis/__openerp__.py'
--- cmis/__openerp__.py 1970-01-01 00:00:00 +
+++ cmis/__openerp__.py 2014-06-12 19:47:23 +
@@ -0,0 +1,62 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': 'CMIS',
+'version': '0.1',
+'category': 'Connector',
+'summary': 'Cmis Connector',
+'description':
+Cmis Connector
+==
+
+This module is the base for OpenERP modules implementing different
integration scenario with a CMIS server.
+It allows you to configure a CMIS backend in OpenERP.
+
+Configuration
+=
+
+Create a new CMIS backend with the host, login and password.
+
+Contributors
+
+* El Hadji Dem (elhadji@savoirfairelinux.com)
+,
+'author': 'Savoir-faire Linux',
+'website': 'www.savoirfairelinux.com',
+'license': 'AGPL-3',
+'depends': [
+'connector',
+],
+'data': [
+'cmis_model_view.xml',
+'cmis_menu.xml',
+],
+'js': [],
+'qweb': [],
+'test': [],
+'demo': [],
+'installable': True,
+'auto_install': False,
+}
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added file 'cmis/backend.py'
--- cmis/backend.py 1970-01-01 00:00:00 +
+++ cmis/backend.py 2014-06-12 19:47:23 +
@@ -0,0 +1,32 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+import openerp.addons.connector.backend as backend
+
+
+cmis =
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into lp:knowledge-addons/7.0
Review: Approve Looking better -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into lp:knowledge-addons/7.0
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into
lp:knowledge-addons/7.0.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260
Add cmis_read; It allows to use the CMIS backend to search in the DMS repository
and attach documents to OpenERP records.
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed merge of lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into
lp:knowledge-addons/7.0.
=== added directory 'cmis_read'
=== added file 'cmis_read/__init__.py'
--- cmis_read/__init__.py 1970-01-01 00:00:00 +
+++ cmis_read/__init__.py 2014-06-12 19:57:17 +
@@ -0,0 +1,25 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import wizard
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added file 'cmis_read/__openerp__.py'
--- cmis_read/__openerp__.py 1970-01-01 00:00:00 +
+++ cmis_read/__openerp__.py 2014-06-12 19:57:17 +
@@ -0,0 +1,74 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': 'CMIS Read',
+'version': '0.1',
+'category': 'Knowledge Management',
+'summary': 'Store Document File in a Remote CMIS Server',
+'description':
+This module allows you to use the CMIS backend to search in the DMS repository
+and attach documents to OpenERP records.
+
+Configuration
+=
+
+Create a new CMIS backend with the host, login and password.
+
+Usage
+=
+
+* On one OpenERP record, click Add from DMS.
+* Type your query and then click on Search.
+* Filter your results if necessary
+* Select the documents you want to attach
+* Selected documents will be enqueued for importing
+
+Contributors
+
+* El Hadji Dem (elhadji@savoirfairelinux.com)
+,
+'author': 'Savoir-faire Linux',
+'website': 'www.savoirfairelinux.com',
+'license': 'AGPL-3',
+'depends': [
+'document',
+'cmis'
+],
+'data': [
+'security/ir.model.access.csv',
+'wizard/document_wizard_view.xml',
+],
+'js': [
+'static/src/js/document.js'
+],
+'qweb': [
+'static/src/xml/document.xml'
+],
+'test': [],
+'demo': [
+],
+'installable': True,
+'auto_install': False,
+}
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added directory 'cmis_read/i18n'
=== added file 'cmis_read/i18n/cmis_read.pot'
--- cmis_read/i18n/cmis_read.pot 1970-01-01 00:00:00 +
+++ cmis_read/i18n/cmis_read.pot 2014-06-12 19:57:17 +
@@ -0,0 +1,119 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+# * cmis_read
+#
+msgid
+msgstr
+Project-Id-Version: OpenERP Server 7.0\n
+Report-Msgid-Bugs-To: \n
+POT-Creation-Date: 2014-03-21 14:55+\n
+PO-Revision-Date: 2014-03-21 10:55-0500\n
Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-canada/7.0-missing-payroll-access into lp:openerp-canada
Review: Needs Fixing Diff comments: === modified file 'l10n_ca_hr_payroll/__openerp__.py' --- l10n_ca_hr_payroll/__openerp__.py 2013-02-27 20:02:47 + +++ l10n_ca_hr_payroll/__openerp__.py 2014-06-11 15:00:16 + @@ -38,6 +38,7 @@ 'l10n_ca_toponyms', ], 'data': [ +'security/ir.model.access.csv', 'l10n_ca_hr_payroll_view.xml', 'l10n_ca_hr_payroll_data.xml', ], === added directory 'l10n_ca_hr_payroll/security' === added file 'l10n_ca_hr_payroll/security/ir.model.access.csv' --- l10n_ca_hr_payroll/security/ir.model.access.csv 1970-01-01 00:00:00 + +++ l10n_ca_hr_payroll/security/ir.model.access.csv 2014-06-11 15:00:16 + @@ -0,0 +1,7 @@ +id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink +access_hr_payroll_tax_table,access_hr_payroll_tax_table,model_hr_payroll_tax_table,,1,1,1,1 group_id:id column is empty in every one of these lines. You actually have to put in a group here. +access_hr_payroll_tax_table_federal_line,access_hr_payroll_tax_table_federal_line,model_hr_payroll_tax_table_federal_line,,1,1,1,1 +access_hr_payroll_tax_table_ei_line,access_hr_payroll_tax_table_ei_line,model_hr_payroll_tax_table_ei_line,,1,1,1,1 +access_hr_payroll_tax_table_qc_line,access_hr_payroll_tax_table_qc_line,model_hr_payroll_tax_table_qc_line,,1,1,1,1 +access_hr_payroll_tax_table_rqap_line,access_hr_payroll_tax_table_rqap_line,model_hr_payroll_tax_table_rqap_line,,1,1,1,1 +access_hr_payroll_tax_table_csst_line,access_hr_payroll_tax_table_csst_line,model_hr_payroll_tax_table_csst_line,,1,1,1,1 \ No newline at end of file -- https://code.launchpad.net/~openerp-community/openerp-canada/7.0-missing-payroll-access/+merge/222815 Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-canada/7.0-missing-payroll-access. ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] git: branch names
Slashes in git branch names can cause problems with some helper tools as it messes up the .git/refs/ directory. The username and feature/fix/i18n part seems redundant to me, these belong in commit messages and PR descriptions. The issue tracker number can be put in the commit message: i.e. Fixes #24. The advantage of this when the PR is merged, github should automatically close #24. version-number-short-description should be good enough IMHO. Le mardi 10 juin 2014 à 14:49 +0200, Alexandre Fayolle a écrit : Hello, I've noticed that git offers hierarchic branch names, and I think this could be a useful tool for the management of branches and PR. https://github.com/odoo-dev/odoo/branches seems to be using a flat namespace similar to what was used in Launchpad, but I feel that this could be vastly improved. Are there any github old timers who could point us to the state of the art best practices here? I've seen http://stackoverflow.com/questions/273695/git-branch-naming-best-practices and I like the username/feature/issue-tracker-number/short-description scheme. Maybe a version number for the target branch should be added somewhere. Opinions? signature.asc Description: This is a digitally signed message part ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] Recomendations from OCA
You can find the runbot source at on odoo-extra[1]. Documentation is supposed to come, but I am sure you can ask around there. [1] https://github.com/odoo/odoo-extra -- Sandy - Mail original - De: Ovnicraft ovnicr...@gmail.com À: openerp-community@lists.launchpad.net Envoyé: Mardi 10 Juin 2014 15:05:19 Objet: [Openerp-community] Recomendations from OCA Hi to all ! i want to know what recommendations comes from community to test. I know about runbot but checking the site is not possible (please tell me if i am wrong) register our repos[1]. So i found some works around travis in openerp-travel. My question comes here because i dont want to mount runbot instance and want to reuse any existent services. Waiting for your help ! Regards ! [1] https://github.com/odoo-ecuador/ -- Cristian Salamea on about.me Cristian Salamea about.me/ovnicraft ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
[Openerp-community] OCA 8.0 Travis Update: it works!
An update: I have commited a project to github: lp:openerp-travel to play around with travis-ci.org and coverall.io A .travis.yml[1], a .coveragerc[2] file and a README.md[3] with travis and coveralls badge have been added to the project. This should serve as a template (or an example) for the other OCA projects. You can view it here on my branch[4]. Pull requests have a useful check mark or x mark depending on if the tests passed or failed[5]. PR which pass[6] tests have a message visible to commiters from travis saying All is well — The Travis CI build passed · Details next to the automatic merge button. Details is a link to the travis build for that particular PR[7]. Coveralls.io also posts whether the tests coverage increased, decreased or stayed the same along with a link to the details of changed coverage[8]. PR which fail[9][10] tests have a message visible to commiters from travis saying Failed — The Travis CI build failed · Details Merge with caution! next to the automatic merge button. Details is a link to the travis build details[11][12]. Additionally, each commit on the repo, as well as each successful PR is tested by travis-ci.org[13] which the publishes a test coverage report to coverage.io[14] which has a very thorough level of detail[15]. About the .travis.yml implementation. I ran into a few issues which are important to point out. * The travis test relies on the setup.py script of odoo to be used by the command pip in a virtualenv: pip install https://github.com/odoo/odoo/archive/master.zip This script is currently broken, as, firstly, it fails to install the contents of addons and, secondly, in the virtualenv, it will install odoo in two places, which causes problems since the latter is missing import_xml.rng: - env/openerp - env/lib/python2.7/site-packages/openerp A temporary solution was to use the branch proposed in a PR[16] which attempts to solve the first problem instead of the official odoo branch. * I dropped testing on python 2.6 as it seems odoo 8.0 uses dictionary generators which were introduced to 2.7. I haven't tested with pypy and 3.4 yet, but I highly doubt they have been made compatible since last time I tried[17]. I have however added them in comments in case they become compatible in the future. * Some repos contain modules which depend on other modules in other OCA modules. I have therefore added lines in the install section which branches or clones these dependencies to /tmp so to have them but not test them, * openerp-server is run twice. The first time during the before_script to install without testing and the second time in script to test. The reason for this is to skip testing dependencies and only test modules in the repo. * I abandonned the idea of running flake against the changes using `git diff -W | flake --diff` as discovering the revision numbers didn't always work and caused more problems than it solves. The flake is therefore run on the entirety of the repo. I assumes the base branch is fully pep8-compliant (as it should be). What this means is that adding travis testing to an OCA repo requires the whole repo be fixed to pass pep8 tests. The flake specifications are line lengths of max 120 and ignore F401 (imported but not used) in __init__.py files only: * flake8 . --max-line-length=120 --filename=__init__.py --ignore=F401 * flake8 . --max-line-length=120 --exclude=__init__.py * Coverage report will ignore the following path patterns: /usr/* /tmp/* */bin/* */lib/* */odoo/* */openerp/* */tests/* *__init__.py * Coverage report will ignore line containing the following patterns: * # pragma: no cover * if context is None: Your feedback is highly encoraged and appreciated. -- Sandy Sorry for the wall of links. This is just very exciting as a reviewer. [1] https://github.com/bwrsandman/openerp-travel/blob/master/.travis.yml [2] https://github.com/bwrsandman/openerp-travel/blob/master/.coveragerc [3] https://raw.githubusercontent.com/bwrsandman/openerp-travel/master/README.md [4] https://github.com/bwrsandman/openerp-travel [5] https://github.com/bwrsandman/openerp-travel/pulls [6] https://github.com/bwrsandman/openerp-travel/pull/4 [7] https://travis-ci.org/bwrsandman/openerp-travel/builds/25836924 [8] https://coveralls.io/builds/797335 [9] https://github.com/bwrsandman/openerp-travel/pull/3 [10] https://github.com/bwrsandman/openerp-travel/pull/2 [11] https://travis-ci.org/bwrsandman/openerp-travel/builds/25836879#L1390 [12] https://travis-ci.org/bwrsandman/openerp-travel/builds/25836901 [13] https://travis-ci.org/bwrsandman/openerp-travel/builds [14] https://coveralls.io/r/bwrsandman/openerp-travel [15] https://coveralls.io/files/204859233 [16] https://github.com/odoo/odoo/pull/81 [17] http://bwrsandman.wordpress.com/2014/04/25/running-openerp-8-0-trunk-with-pypy-and-psycopg2cffi/ signature.asc Description: This is a digitally signed message part
[Openerp-community] OCA 8.0 Suggestion: use travis-ci.org for testing addons
Hello Community.
I have a proposal for submit before we start porting our projects to
8.0.
I suggest we add travis.yml to the root of each addon repository.
That way, we can use the free service of travis-ci.org to do initial
testing of each MP and each commit.
This will greatly reduce the amount of redundant manual testing reviews
have to do (e.g. Fix pep8, the MP fails tests) and gives an output of
these MPs being run on a machine which doesn't actually cost us any
ressource. Looking at the output, we could easily see the warnings in a
log without having to clone and run the tests myself -- a process which
is quite time consuming.
I have included my proposal travis config file template. This is a rough
first draft, it is very possible that it needs tweaking.
It tests on python2.6, python2.7 (possibility to add 3.4 and pypy when
they become supported) with odoo and with ocb.
- It will first test pep8 compliance.
- Use a max line length of 120
- Ignore error F401 (imported but unused) in __init__.py files.
- It then runs odoo in test mode for each of the modules in the
repository.
- There is also a coverage report being run which shows what portion
of the code is covered by tests (a .coveragerc file is also provided).
This would require pypi versions of both odoo and ocb. An alternative
would be to install these with --allow-external, but I suspect this
would require a lot more initial setup.
--
# Config file .travis.yml
language: python
python:
- 2.7
- 2.6
env:
- ODOO=odoo
- ODOO=ocb
# command to install dependencies
install: pip install ${ODOO} coveralls flake8
before_script: createdb test
# command to run tests, e.g. python setup.py test
script:
- git diff -W HEAD^ HEAD | flake8 --diff --max-line-length=120
--filename=__init__.py --ignore=F401
- git diff -W HEAD^ HEAD | flake8 --diff --max-line-length=120
--exclude=__init__.py
- python -m coverage run odoo-server -d test --test-enable
--log-level=test --stop-after-init --init=$(python -c import os;
print(','.join(filter(lambda x: os.path.isdir(x) and not
x.startswith('.'), os.listdir('.')
after_success:
coveralls
# Config file .coveragerc
[report]
omit =
*__init__.py
odoo/*
/usr/*
# Regexes for lines to exclude from consideration
exclude_lines =
# Have to re-enable the standard pragma
pragma: no cover
# Don't complain about null context checking
if context is None:
signature.asc
Description: This is a digitally signed message part
___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into lp:knowledge-addons/7.0
Review: Needs Fixing For better usability and security, your sanitize function should wrap the query function, the same way OE does, so that there is no way to call the query the wrong way. Something along the lines of safe_query( SELECT cmis:name, cmis:createdBy, cmis:objectId, cmis:contentStreamLength FROM cmis:document WHERE cmis:name LIKE '%%%s%%', filename) def safe_query(query, *args): args = map(sanitize_input, args) return repo.query(query % args) Make sure to make the these functions general purpose, not specific to this particular instance as it seems now (function name sanitize_input_filename_field sounds specific to filename, when it can be used on any query). Finally, _make sure to put these functions in your topmost dependency (cmis) so any depending module can use it reliably. -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis into lp:knowledge-addons/7.0
Review: Needs Information l.225,259 can you please explain what you do here. It seems you attempt to write to a directory to test if you have write permission, surely there are safer ways of doing this. In you unittest, can you test more of your functions, I know there is a challenge of not having a cmis server running to the tests, but even testing for a raised exception is better than just testing the model. -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis/+merge/212258 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into lp:knowledge-addons/7.0
Review: Needs Fixing l.469,502: Queries are still not fully sanitized, any quotes or percent sizes in the input will result in unexpected behaviour. This is a security risk and a major bug potential. I highly recommend you to add a function to sanitize input in the cmis module for queries and follow the documentation from http://wiki.alfresco.com/wiki/CMIS_Query_Language#Literals Basic escaping: \\ represents \ \' represents ' In addition to basic escaping, in LIKE expressions \% represents % \_ represents _ -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/nag_refactor into lp:lp-community-utils
@Stefan, yes that would work, we could even be backwards compatible and have a symlink openerp_nag - openerp_nag.py -- https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/nag_refactor/+merge/214445 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/purchase-wkfl/purchase_profit_forecast-missing-security-access into lp:purchase-wkfl
Review: Needs Fixing code review, no test
l.288 looks like you forgot to put anything in for group_id:id
purchase_profit_forecast/__openerp__.py:
Manifest license key is missing
Deprecated Manifest key ('active')
Deprecated Manifest key ('certificate')
Flake8:
report/analytic.py:3:1: E302 expected 2 blank lines, found 1
report/analytic.py:10:80: E501 line too long (80 79 characters)
report/purchase.py:4:1: E302 expected 2 blank lines, found 1
report/purchase.py:38:5: E303 too many blank lines (2)
report/purchase.py:41:9: F841 local variable 'result_context' is assigned to
but never used
report/purchase.py:54:1: W391 blank line at end of file
Copyright dates are wrong
No .pot file
No unittests
--
https://code.launchpad.net/~savoirfairelinux-openerp/purchase-wkfl/purchase_profit_forecast-missing-security-access/+merge/218509
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/purchase-wkfl/pallet-delivery-missing-security-access into lp:purchase-wkfl
Review: Needs Fixing code review, pep8
l.112,464,2878 You can remove these empty files
Flake8
delivery_editable_dates/__openerp__.py:22:1: O603 Manifest license key is
missing
delivery_editable_dates/__openerp__.py:28:5: O600 Warning unknown Manifest key
('caterogy')
delivery_editable_dates/__openerp__.py:38:5: O600 Warning unknown Manifest key
('active')
landed_cost_per_pallet/__openerp__.py:25:1: O603 Manifest license key is
missing
landed_cost_per_pallet/__openerp__.py:51:5: O600 Warning unknown Manifest key
('active')
landed_cost_per_pallet/purchase.py:25:1: E302 expected 2 blank lines, found 1
landed_cost_per_pallet/purchase.py:117:55: E231 missing whitespace after ','
landed_cost_per_pallet/purchase.py:117:81: E231 missing whitespace after ','
pallet_delivery/__openerp__.py:25:1: O603 Manifest license key is missing
pallet_delivery/__openerp__.py:34:33: W291 trailing whitespace
pallet_delivery/__openerp__.py:57:5: O600 Warning unknown Manifest key
('active')
pallet_delivery/stock.py:26:1: E302 expected 2 blank lines, found 1
pallet_delivery/stock.py:70:23: W601 .has_key() is deprecated, use 'in'
pallet_delivery/stock.py:96:9: F841 local variable 'pallet_ids' is assigned to
but never used
pallet_delivery/stock.py:122:25: E126 continuation line over-indented for
hanging indent
pallet_delivery/stock.py:185:1: W293 blank line contains whitespace
pallet_delivery/stock.py:210:32: W601 .has_key() is deprecated, use 'in'
pallet_delivery/stock.py:213:39: W601 .has_key() is deprecated, use 'in'
pallet_delivery/stock.py:228:28: W601 .has_key() is deprecated, use 'in'
pallet_delivery/stock.py:236:21: E126 continuation line over-indented for
hanging indent
pallet_delivery/stock.py:246:25: E126 continuation line over-indented for
hanging indent
pallet_delivery/stock.py:271:13: E123 closing bracket does not match
indentation of opening bracket's line
purchase_lot_tracking/__openerp__.py:25:1: O603 Manifest license key is
missing
purchase_lot_tracking/__openerp__.py:38:48: W291 trailing whitespace
purchase_lot_tracking/__openerp__.py:51:5: O600 Warning unknown Manifest key
('active')
purchase_lot_tracking/account.py:23:1: F401 'dp' imported but unused
purchase_lot_tracking/account.py:25:1: E302 expected 2 blank lines, found 1
purchase_lot_tracking/account.py:48:21: E265 block comment should start with '#
'
purchase_lot_tracking/account.py:23:1: F401 'dp' imported but unused
purchase_lot_tracking/account.py:25:1: E302 expected 2 blank lines, found 1
purchase_lot_tracking/account.py:48:21: E265 block comment should start with '#
'
purchase_lot_tracking/product.py:24:1: E302 expected 2 blank lines, found 1
purchase_lot_tracking/product.py:35:1: E302 expected 2 blank lines, found 1
purchase_lot_tracking/purchase.py:25:1: E302 expected 2 blank lines, found 1
purchase_lot_tracking/purchase.py:51:65: W291 trailing whitespace
purchase_lot_tracking/purchase.py:52:49: E128 continuation line under-indented
for visual indent
purchase_lot_tracking/purchase.py:53:49: E128 continuation line under-indented
for visual indent
purchase_lot_tracking/purchase.py:54:49: E128 continuation line under-indented
for visual indent
purchase_lot_tracking/purchase.py:55:75: E202 whitespace before '}'
purchase_lot_tracking/purchase.py:65:45: E127 continuation line over-indented
for visual indent
purchase_lot_tracking/purchase.py:68:1: W293 blank line contains whitespace
purchase_lot_tracking/purchase.py:69:1: W293 blank line contains whitespace
purchase_lot_tracking/purchase.py:70:5: E303 too many blank lines (2)
purchase_lot_tracking/purchase.py:81:1: W293 blank line contains whitespace
purchase_lot_tracking/purchase.py:85:29: E222 multiple spaces after operator
purchase_lot_tracking/purchase.py:106:1: W293 blank line contains whitespace
purchase_lot_tracking/purchase.py:110:5: E303 too many blank lines (2)
purchase_lot_tracking/purchase.py:119:93: W291 trailing whitespace
purchase_lot_tracking/purchase.py:122:21: E126 continuation line over-indented
for hanging indent
purchase_lot_tracking/purchase.py:124:24: W291 trailing whitespace
purchase_lot_tracking/purchase.py:133:25: E126 continuation line over-indented
for hanging indent
purchase_lot_tracking/purchase.py:145:9: F841 local variable 'pick_id' is
assigned to but never used
purchase_lot_tracking/purchase.py:151:17: E126 continuation line over-indented
for hanging indent
purchase_lot_tracking/purchase.py:151:39: E231 missing whitespace after ','
purchase_lot_tracking/purchase.py:157:1: W293 blank line contains whitespace
purchase_lot_tracking/purchase.py:160:1: W293 blank line contains whitespace
purchase_lot_tracking/purchase.py:175:64: W291 trailing whitespace
purchase_lot_tracking/purchase.py:177:32: E201 whitespace after '{'
purchase_lot_tracking/purchase.py:177:54: E203 whitespace before ':'
purchase_lot_tracking/purchase.py:177:67: E202 whitespace before '}'
purchase_lot_tracking/purchase.py:188:25: W291 trailing whitespace
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis into lp:knowledge-addons/7.0
Review: Needs Fixing Flake8: cmis/connector.py:23:1: F401 'fields' imported but unused cmis/connector.py:23:1: F401 'orm' imported but unused l.270 you still need to escape literals http://wiki.alfresco.com/wiki/CMIS_Query_Language#Literals http://pic.dhe.ibm.com/infocenter/p8docs/v5r0m0/index.jsp?topic=%2Fcom.ibm.installingp8cmis.doc%2Fcmidv022.htm -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis/+merge/212258 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_write into lp:knowledge-addons/7.0
Review: Needs Fixing l.416 Missing context propagation Spelling: You wrote OpenErp a few times. This should be OpenERP. The description is oddly formulated, you may want it proofread. Flake8: cmis_write/__openerp__.py:58:26: W291 trailing whitespace cmis_write/ir_attachment.py:125:5: E265 block comment should start with '# ' -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_write/+merge/213940 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_write into lp:knowledge-addons/7.0
Still no unittests -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_write/+merge/213940 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into lp:knowledge-addons/7.0
Review: Needs Fixing l.471 Still severe bug and injection potential Try: filename = sql%' OR '1' = '1' OR '%injection CMIS must provide a code escape function, otherwise use OpenERP's. It is important that you don't do this manually. https://en.wikipedia.org/wiki/Sql_injection There are also no unittests. The previous example would be a good thing to test. -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis into lp:knowledge-addons/7.0
Review: Needs Fixing except_osv is depricated, please use except_orm l.213 missing context propagation l.276 POSSIBLE SQL INJECTION with filenames which contain quotes, please use appropriate code escapes from the library (don't write your own) No Unittests Flake8: cmis/cmis_model.py:25:1: F401 'job' imported but unused cmis/cmis_model.py:27:1: F401 'connector' imported but unused cmis/cmis_model.py:28:1: F401 'ConnectorSession' imported but unused cmis/cmis_model.py:29:1: F401 'base64' imported but unused cmis/cmis_model.py:71:9: E265 block comment should start with '# ' cmis/cmis_model.py:84:13: F841 local variable 'someDoc' is assigned to but never used cmis/cmis_model.py:92:9: F841 local variable 'ir_attach_dms_obj' is assigned to but never used cmis/cmis_model.py:96:9: E265 block comment should start with '# ' cmis/cmis_model.py:97:9: E265 block comment should start with '# ' cmis/cmis_model.py:120:17: F841 local variable 'res' is assigned to but never used cmis/connector.py:23:1: F401 'fields' imported but unused cmis/connector.py:23:1: F401 'orm' imported but unused -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis/+merge/212258 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_write into lp:knowledge-addons/7.0
Review: Needs Fixing This MP should have a prerequisite branch: lp:~savoirfairelinux-openerp/knowledge-addons/cmis l.301 missing context propagation No unittests Flake8 cmis_write/ir_attachment.py:73:45: W291 trailing whitespace cmis_write/ir_attachment.py:74:53: W291 trailing whitespace cmis_write/ir_attachment.py:75:43: W291 trailing whitespace cmis_write/ir_attachment.py:76:41: W291 trailing whitespace cmis_write/ir_attachment.py:77:51: W291 trailing whitespace cmis_write/ir_attachment.py:89:5: E265 block comment should start with '# ' cmis_write/metadata.py:23:1: F401 'osv' imported but unused -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_write/+merge/213940 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis into lp:knowledge-addons/7.0
Review: Needs Fixing Missing security model for cmis.backend -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis/+merge/212258 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into lp:knowledge-addons/7.0
Review: Needs Fixing l.377 osv.TransientModel should be orm.TransientModel l.504 POSSIBLE SQL INJECTION: (with quotes in a filename) please use the library's code escapes, don't write your own Flake8: cmis_read/wizard/document_wizard.py:102:9: F841 local variable 'file_name' is assigned to but never used cmis_read/wizard/document_wizard.py:115:5: E265 block comment should start with '# ' cmis_read/wizard/document_wizard.py:120:6: E111 indentation is not a multiple of four cmis_read/wizard/document_wizard.py:120:6: E113 unexpected indentation cmis_read/wizard/document_wizard.py:148:5: E265 block comment should start with '# ' -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into lp:knowledge-addons/7.0
Review: Needs Fixing openerp.modules.loading: The transient model ir.attachment.dms (ir.attachment.dms) should not have explicit access rules! -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into lp:knowledge-addons/7.0
Injection is still possible. It is an entry point for malicious queries or accidental breaks. -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] [Openerp-community-reviewer] New reviewer
+1 we can always use active contributors as reviewers! -- Sandy - Original Message - From: Stefan Rijnhart ste...@therp.nl To: openerp-community-revie...@lists.launchpad.net, openerp-community@lists.launchpad.net Sent: Thursday, May 1, 2014 5:17:58 AM Subject: Re: [Openerp-community-reviewer] New reviewer +1 for this very active contributor. On 05/01/2014 10:15 AM, Nicolas Bessi wrote: Dear community, I would like to propose Leonardo Pistone as member of community reviewer. He his an active contributor and reviewer of OpenERP community for quite a time now and would be a perfect fit for the team. https://launchpad.net/~lpistone https://launchpad.net/%7Elpistone https://code.launchpad.net/~lpistone/+activereviews https://code.launchpad.net/%7Elpistone/+activereviews -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-revie...@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] New reviewer
+1 we can always use active contributors as reviewers! -- Sandy - Original Message - From: Stefan Rijnhart ste...@therp.nl To: openerp-community-reviewer@lists.launchpad.net, openerp-commun...@lists.launchpad.net Sent: Thursday, May 1, 2014 5:17:58 AM Subject: Re: [Openerp-community-reviewer] New reviewer +1 for this very active contributor. On 05/01/2014 10:15 AM, Nicolas Bessi wrote: Dear community, I would like to propose Leonardo Pistone as member of community reviewer. He his an active contributor and reviewer of OpenERP community for quite a time now and would be a perfect fit for the team. https://launchpad.net/~lpistone https://launchpad.net/%7Elpistone https://code.launchpad.net/~lpistone/+activereviews https://code.launchpad.net/%7Elpistone/+activereviews -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into lp:ocb-server
Sorry. I didn't explain very well. I have MPs for OCB, 7.0 and trunk for this bug. OE trunk doesn't have both MP (server and web) because it too much, therefore web doesn't have an MP. As for server, commits up to r5297 ([FIX] Fixed instance of ValidateError not being translated) have been proposed. -- https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736 Your team OpenERP Community Reviewer/Maintainer is requested to review the proposed merge of lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm into lp:partner-contact-management
Review: Needs Fixing pep8
crm_firstname/__openerp__.py:22:1: O603 Manifest license key is missing
crm_firstname/__openerp__.py:35:19: E231 missing whitespace after ','
crm_firstname/__openerp__.py:37:11: E126 continuation line over-indented for
hanging indent
crm_firstname/__openerp__.py:39:11: E123 closing bracket does not match
indentation of opening bracket's line
crm_firstname/__openerp__.py:41:2: O600 Warning unknown Manifest key ('active')
-- deprecated
crm_firstname/crm.py:5:30: W291 trailing whitespace
crm_firstname/crm.py:35:30: E127 continuation line over-indented for visual
indent
crm_firstname/crm.py:41:1: W293 blank line contains whitespace
crm_firstname/crm.py:43:17: E126 continuation line over-indented for hanging
indent
crm_firstname/crm.py:48:77: W291 trailing whitespace
crm_firstname/crm.py:49:17: E123 closing bracket does not match indentation of
opening bracket's line
crm_firstname/crm.py:58:9: E265 block comment should start with '# '
crm_firstname/crm.py:58:11: W291 trailing whitespace
crm_firstname/crm.py:67:80: E231 missing whitespace after ','
crm_firstname/crm.py:70:1: W293 blank line contains whitespace
crm_firstname/crm.py:77:17: E126 continuation line over-indented for hanging
indent
crm_firstname/crm.py:91:26: E231 missing whitespace after ':'
crm_firstname/crm.py:113:17: E265 block comment should start with '#
--
https://code.launchpad.net/~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm/+merge/213673
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into lp:ocb-server
It would make the tests fail, but this problem is widespread in OE. For example test_20_message_post (openerp.addons.mail.tests.test_mail_features.test_mail) fails when a translator changes the value. It just doesn't fail in en_US because the values haven't changed. The same is not true for other locales. A solution to this would be to use _() in the assert. I am not sure if that's possible in yml. If we're talking about changing en_US why not revert my last commit and translate ValidateError as Validate Error? -- https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736 Your team OpenERP Community Backports is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into lp:ocb-server
I have already made some MPs for upstream, but the code is pretty different. -- https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736 Your team OpenERP Community Reviewer/Maintainer is requested to review the proposed merge of lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-canada/7.0-l10n_ca_account_check_writing into lp:openerp-canada
Review: Approve LGTM, thanks The future module is worth looking at for future.str_as_unicode https://pypi.python.org/pypi/future/0.3.1 -- https://code.launchpad.net/~openerp-community/openerp-canada/7.0-l10n_ca_account_check_writing/+merge/216708 Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-canada/7.0-l10n_ca_account_check_writing. ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into lp:ocb-server
Review: Needs Information @Stefan they give a satisfactory message when translated (no update to .po needed) I don't want to change too much from the original code, but if you feel it's really needed, I can replace them with your suggestions. -- https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-web/translate_warnings_1297525 into lp:ocb-web
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/ocb-web/translate_warnings_1297525 into lp:ocb-web.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-web/translate_warnings_1297525/+merge/212739
Allows the title of warning boxes such as except_orm to be translated.
Prerequisite for displaying translated values:
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736
--
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-web/translate_warnings_1297525/+merge/212739
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed merge of
lp:~savoirfairelinux-openerp/ocb-web/translate_warnings_1297525 into lp:ocb-web.
=== modified file 'addons/web/session.py'
--- addons/web/session.py 2013-05-14 10:37:36 +
+++ addons/web/session.py 2014-03-25 22:25:56 +
@@ -8,6 +8,7 @@
import xmlrpclib
import openerp
+from openerp.tools.translate import _
_logger = logging.getLogger(__name__)
@@ -84,17 +85,17 @@
self.jsonp_requests = {} # FIXME use a LRU
def send(self, service_name, method, *args):
-code_string = uwarning -- %s\n\n%s
+code_string = _(uwarning -- %s\n\n%s)
try:
return openerp.netsvc.dispatch_rpc(service_name, method, args)
except openerp.osv.osv.except_osv, e:
raise xmlrpclib.Fault(code_string % (e.name, e.value), '')
except openerp.exceptions.Warning, e:
-raise xmlrpclib.Fault(code_string % (Warning, e), '')
+raise xmlrpclib.Fault(code_string % (_(Warning), e), '')
except openerp.exceptions.AccessError, e:
-raise xmlrpclib.Fault(code_string % (AccessError, e), '')
+raise xmlrpclib.Fault(code_string % (_(AccessError), e), '')
except openerp.exceptions.AccessDenied, e:
-raise xmlrpclib.Fault('AccessDenied', openerp.tools.ustr(e))
+raise xmlrpclib.Fault(_('AccessDenied'), openerp.tools.ustr(e))
except openerp.exceptions.DeferredException, e:
formatted_info = .join(traceback.format_exception(*e.traceback))
raise xmlrpclib.Fault(openerp.tools.ustr(e), formatted_info)
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into lp:ocb-server
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into
lp:ocb-server.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736
When searching a frame for context, the _() looks for self.localcontext but
misses self.context.
The integration of this patch allows for web warnings (such as except_orm) to
be translated by _()
--
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed merge of
lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into
lp:ocb-server.
=== modified file 'openerp/osv/orm.py'
--- openerp/osv/orm.py 2014-03-05 15:18:15 +
+++ openerp/osv/orm.py 2014-04-06 00:20:15 +
@@ -1554,7 +1554,7 @@
)
self._invalids.update(fields)
if error_msgs:
-raise except_orm('ValidateError', '\n'.join(error_msgs))
+raise except_orm(_('ValidateError'), '\n'.join(error_msgs))
else:
self._invalids.clear()
=== modified file 'openerp/service/wsgi_server.py'
--- openerp/service/wsgi_server.py 2013-11-25 10:38:42 +
+++ openerp/service/wsgi_server.py 2014-04-06 00:20:15 +
@@ -44,6 +44,7 @@
import openerp
import openerp.modules
import openerp.tools.config as config
+from openerp.tools.translate import _
import websrv_lib
_logger = logging.getLogger(__name__)
@@ -138,17 +139,18 @@
return response
def xmlrpc_handle_exception_legacy(e):
+code_string = u%s -- %s\n\n%s
if isinstance(e, openerp.osv.osv.except_osv):
-fault = xmlrpclib.Fault('warning -- ' + e.name + '\n\n' + e.value, '')
+fault = xmlrpclib.Fault(code_string % (_(warning), e.name, e.value), '')
response = xmlrpclib.dumps(fault, allow_none=False, encoding=None)
elif isinstance(e, openerp.exceptions.Warning):
-fault = xmlrpclib.Fault('warning -- Warning\n\n' + str(e), '')
+fault = xmlrpclib.Fault(code_string % (_(warning), _(Warning), e), '')
response = xmlrpclib.dumps(fault, allow_none=False, encoding=None)
elif isinstance(e, openerp.exceptions.AccessError):
-fault = xmlrpclib.Fault('warning -- AccessError\n\n' + str(e), '')
+fault = xmlrpclib.Fault(code_string % (_(warning), _(AccessError), e), '')
response = xmlrpclib.dumps(fault, allow_none=False, encoding=None)
elif isinstance(e, openerp.exceptions.AccessDenied):
-fault = xmlrpclib.Fault('AccessDenied', str(e))
+fault = xmlrpclib.Fault(_('AccessDenied'), str(e))
response = xmlrpclib.dumps(fault, allow_none=False, encoding=None)
elif isinstance(e, openerp.exceptions.DeferredException):
info = e.traceback
=== modified file 'openerp/tools/translate.py'
--- openerp/tools/translate.py 2014-03-17 08:06:23 +
+++ openerp/tools/translate.py 2014-04-06 00:20:15 +
@@ -196,7 +196,7 @@
lang = ctx.get('lang')
s = frame.f_locals.get('self', {})
if not lang:
-c = getattr(s, 'localcontext', None)
+c = getattr(s, 'localcontext', None) or getattr(s, 'context', None)
if c:
lang = c.get('lang')
if not lang:
@@ -856,7 +856,7 @@
path_list = [root_path,] + apaths
# Also scan these non-addon paths
-for bin_path in ['osv', 'report' ]:
+for bin_path in ['osv', 'report', 'tools', 'service' ]:
path_list.append(os.path.join(config.config['root_path'], bin_path))
_logger.debug(Scanning modules at paths: , path_list)
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_modules into lp:partner-contact-management
Review: Abstain -- https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_modules/+merge/217775 Your team Partner and Contact Core Editors is requested to review the proposed merge of lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_modules into lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_write into lp:knowledge-addons/7.0
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/knowledge-addons/cmis_write into
lp:knowledge-addons/7.0.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_write/+merge/213940
Add cmis_write: It allows to create docs from OE in DMS
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_write/+merge/213940
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed merge of lp:~savoirfairelinux-openerp/knowledge-addons/cmis_write into
lp:knowledge-addons/7.0.
=== added directory 'cmis_write'
=== added file 'cmis_write/__init__.py'
--- cmis_write/__init__.py 1970-01-01 00:00:00 +
+++ cmis_write/__init__.py 2014-04-16 21:57:38 +
@@ -0,0 +1,26 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import ir_attachment
+from . import metadata
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added file 'cmis_write/__openerp__.py'
--- cmis_write/__openerp__.py 1970-01-01 00:00:00 +
+++ cmis_write/__openerp__.py 2014-04-16 21:57:38 +
@@ -0,0 +1,71 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': 'CMIS Write',
+'version': '0.1',
+'category': 'Knowledge Management',
+'summary': 'Create Document in DMS from OpenErp',
+'description':
+Add Documents from OpenErp
+==
+
+This module allows you to store OpenERP document in the DMS repository.
+
+Configuration
+=
+
+* Create a new CMIS backend with the host, login and password.
+* Configure the path in the repository where documents will be dropped.
+ By default, it uses the home directory of the user.
+
+Usage
+=
+
+* On one OpenERP record, click Add document.
+* Upload your documents
+* Uploaded documents will be enqueued for storage in the DMS
+
+Contributors
+
+* El Hadji Dem (elhadji@savoirfairelinux.com)
+,
+'author': 'Savoir-faire Linux',
+'website': 'www.savoirfairelinux.com',
+'license': 'AGPL-3',
+'depends': [
+'document',
+'cmis',
+],
+'data': [
+'metadata_view.xml',
+'security/ir.model.access.csv',
+],
+'js': [],
+'qweb': [],
+'test': [],
+'demo': [],
+'installable': True,
+'auto_install': False,
+}
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added directory 'cmis_write/i18n'
=== added file 'cmis_write/i18n/cmis_write.pot'
--- cmis_write/i18n/cmis_write.pot 1970-01-01 00:00:00 +
+++ cmis_write/i18n/cmis_write.pot 2014-04-16 21:57:38 +
@@ -0,0 +1,89 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+# * cmis_write
+#
+msgid
+msgstr
+Project-Id-Version: OpenERP Server 7.0\n
+Report-Msgid-Bugs-To: \n
+POT-Creation-Date: 2014-03-21 14:59+\n
+PO-Revision-Date: 2014-03-21 10:59-0500\n
+Last-Translator: EL Hadji DEM elhadji@savoirfairelinux.com\n
+Language-Team: \n
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into lp:ocb-server
Done. Please make sure this doesn't have funny side effects and translates properly. -- https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into lp:ocb-server
The tests fail anyway in any other language, especially in yml tests Should I fix that assert too. -- https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into lp:ocb-server
Basically, if I change the labels, I would change the message in the tests. Ideally, an assertRaises should be used there, but I have no idea if yml tests support that. -- https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/lp-community-utils/nag-nameerror-1312682 into lp:lp-community-utils
Review: Approve -- https://code.launchpad.net/~camptocamp/lp-community-utils/nag-nameerror-1312682/+merge/217216 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact into lp:partner-contact-management
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact
into lp:partner-contact-management.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact/+merge/203979
- Added base_contact module.This module has been migrated from OP6.1 to OP7.0
and a merge is proposed at 2013-10-22.
Details of MP:
https://code.launchpad.net/~openerp-dev/openobject-addons/7.0-base-contact-xal/+merge/192129
--
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact/+merge/203979
Your team Partner and Contact Core Editors is requested to review the proposed
merge of
lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact
into lp:partner-contact-management.
=== added directory 'base_contact'
=== added file 'base_contact/__init__.py'
--- base_contact/__init__.py 1970-01-01 00:00:00 +
+++ base_contact/__init__.py 2014-03-21 15:26:56 +
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#Copyright (C) 2013-TODAY OpenERP SA (http://www.openerp.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import base_contact
=== added file 'base_contact/__openerp__.py'
--- base_contact/__openerp__.py 1970-01-01 00:00:00 +
+++ base_contact/__openerp__.py 2014-03-21 15:26:56 +
@@ -0,0 +1,56 @@
+# -*- coding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Business Applications
+#Copyright (C) 2013-TODAY OpenERP S.A. (http://openerp.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': 'Contacts Management',
+'version': '1.0',
+'author': 'OpenERP SA',
+'website': 'http://www.openerp.com',
+'category': 'Customer Relationship Management',
+'complexity': expert,
+'description':
+This module allows you to manage your contacts
+==
+
+It lets you define groups of contacts sharing some common information, like:
+* Birthdate
+* Nationality
+* Native Language
+,
+'depends': [
+'base',
+'process',
+'contacts'
+],
+'external_dependencies': {},
+'data': [
+'base_contact_view.xml',
+],
+'demo': [
+'base_contact_demo.xml',
+],
+'test': [],
+'installable': True,
+'auto_install': False,
+'images': [],
+}
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added file 'base_contact/base_contact.py'
--- base_contact/base_contact.py 1970-01-01 00:00:00 +
+++ base_contact/base_contact.py 2014-03-21 15:26:56 +
@@ -0,0 +1,186 @@
+# -*- coding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#Copyright (C) 2013-TODAY OpenERP SA (http://www.openerp.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into lp:knowledge-addons/7.0
Review: Abstain @Holger, took your comments into consideration Taking myself out of the Reviewer list since I have contributed. -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into lp:knowledge-addons/7.0
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into
lp:knowledge-addons/7.0.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960
Added document_multiple_records module: It allows to manage a document with a
multiple records.
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed merge of
lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into
lp:knowledge-addons/7.0.
=== added directory 'document_multiple_records'
=== added file 'document_multiple_records/__init__.py'
--- document_multiple_records/__init__.py 1970-01-01 00:00:00 +
+++ document_multiple_records/__init__.py 2014-04-16 20:25:39 +
@@ -0,0 +1,26 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+###
+
+from . import document
+from . import wizard
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added file 'document_multiple_records/__openerp__.py'
--- document_multiple_records/__openerp__.py 1970-01-01 00:00:00 +
+++ document_multiple_records/__openerp__.py 2014-04-16 20:25:39 +
@@ -0,0 +1,60 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': 'Document Management System for Multiple Records',
+'version': '0.1',
+'category': 'Knowledge Management',
+'summary': 'Document Management System for Multiple Records',
+'description':
+Document Management System for Multiple Records
+==
+
+Contributors
+
+* El Hadji Dem (elhadji@savoirfairelinux.com)
+,
+'author': 'Savoir-faire Linux',
+'website': 'www.savoirfairelinux.com',
+'license': 'AGPL-3',
+'depends': [
+'document',
+],
+'data': [
+'document_view.xml',
+'security/ir.model.access.csv',
+'wizard/document_wizard_view.xml',
+],
+'js': [
+'static/src/js/document.js'
+],
+'qweb': [
+'static/src/xml/document.xml'
+],
+'test': [],
+'demo': [
+],
+'installable': True,
+'auto_install': False,
+}
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added file 'document_multiple_records/document.py'
--- document_multiple_records/document.py 1970-01-01 00:00:00 +
+++ document_multiple_records/document.py 2014-04-16 20:25:39 +
@@ -0,0 +1,92 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software
Re: [Openerp-community] Python 2.x - Updates until 2020
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thank you for communicating this. Py2 is being kept on life support, but all the new features are in Py3. We should all be thinking about forward compatibility to 3. I recommend checking out By Your Bootstraps: Porting Your Application to Python3 from PyCon last week: http://pyvideo.org/video/2626/by-your-bootstraps-porting-your-application-to-p Just some food for talk. - -- Sandy Le 2014-04-14 15:07, Markus Schneider a écrit : Hi everyone, i don't know what is the discussion on migrating OpenERP to Python 3 but there is a update of the Support on Python 2.x http://hg.python.org/peps/rev/76d43e52d978 So Python 2.8 will never come and Python 2.7 have 6 years left. Just share the information. Regards Markus -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTTDsKAAoJEKYZqB2wZ/VqCGMIAJxAZmwtZx006Q1OP5y9iL0p TB7Dw/+EHbuhQ7lmK3lyTMthwq14FaVrY3twKSq22WbiFt2oytxVAtEuopYm+DEF 7gJvJrip8ovZxeI1YWYao9jiuOsiUvqfELSwztUkRoS88dhmYtNZcrJe7hN02XSu 8fNF/v0650W/RVkQMTgr5eliRUyQ/pG38pX5SFlsQbeJRaCgafnlmmFWww9XllH5 oy/pQlCuj9a761zcKV8i8yE1oEdNk7OVF2LBrbPcqzhZ9caqUO6kg5h5H7u6LVZ2 oZ4EYu/PWgphekAMo3oy69cy/07qQomZ49A18FVRsa+xdbcJyfbdp/oSiLQbTuo= =88bp -END PGP SIGNATURE- ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Blueprint first-review-script] First review script
Blueprint changed by Sandy Carter (http://www.savoirfairelinux.com): Whiteboard changed: Gather information about an OpenERP addon MP * Has this MP been reviewed before by an automated script? - * Does it contain message identifying as automated? - * Has there been a new commit since last automated message? + * Does it contain message identifying as automated? + * Has there been a new commit since last automated message? * Does it merge cleanly? * Is this a new module? - * Add of a directory and an __openerp__.py file - * AGPL-3 license check - * Does it include tests? - * Does it include demo data? - * Does it include security files? - * Does the module version have 2 digits (1.0) - * Has the .pot file been generated - * Run flake8 on the entire module - * Check for deprecated code - * Check for TODO and FIXME comments - * Check for debugging breakpoints (ipdb, pdb, set_trace()) - * Test install the module on its own, run tests - * Does it follow all OpenERP conventions + * Add of a directory and an __openerp__.py file + * AGPL-3 license check + * Does it include tests? + * Run a profiler on tests + * cProfile + * line_profiler + * Does it include demo data? + * Does it include security files? + * Does the module version have 2 digits (1.0) + * Has the .pot file been generated + * Run flake8 on the entire module + * Check for deprecated code + * Check for TODO and FIXME comments + * Check for debugging breakpoints (ipdb, pdb, set_trace()) + * Test install the module on its own, run tests + * Does it follow all OpenERP conventions * Is this a modification of an existing module - * Which modules are involved? - * What kind of changes are made? - * Code behaviour - * Model changes - * Has the version been bumped? - * Any migration scripts included? - * View changes - * Tests - * New tests - * Added tests - * Removed tests - * Demo data - * Data - * Translation - * TODO, FIXME comments - * Added comments - * Removed comments - * Check for debugging breakpoints (ipdb, pdb, set_trace()) - * Evaluate if changes create a net improvement - * Run flake8 before and after merge - * Check for deprecated code before and after merge - * Run tests before and after - * Are they fixed? - * Are they broken? - * Are they unchanged? - * Which tests results have changed? Are they new/removed? - * Check conventions before and after merge + * Which modules are involved? + * What kind of changes are made? + * Code behaviour + * Model changes + * Has the version been bumped? + * Any migration scripts included? + * View changes + * Tests + * New tests + * Added tests + * Removed tests + * Profile tests + * Demo data + * Data + * Translation + * TODO, FIXME comments + * Added comments + * Removed comments + * Check for debugging breakpoints (ipdb, pdb, set_trace()) + * Evaluate if changes create a net improvement + * Run flake8 before and after merge + * Check for deprecated code before and after merge + * Run tests before and after + * Are they fixed? + * Are they broken? + * Are they unchanged? + * Which tests results have changed? Are they new/removed? + * Check conventions before and after merge * Is this a mixture of both? - * Separate code of new and modified + * Separate code of new and modified * Is this a removal? * Provide link to http://pad.openerp.com/p/community-review - * Identify points of concern from the pad + * Identify points of concern from the pad * Vote on MP (or don't) -- First review script https://blueprints.launchpad.net/lp-community-utils/+spec/first-review-script -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_maiden_name into lp:partner-contact-management
Review: Needs Fixing @Yannick, Thank you for pointing that out. Indeed, maiden name might be a charged, non-gender neutral name for the field and should be changed. -- https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_maiden_name/+merge/204023 Your team Partner and Contact Core Editors is requested to review the proposed merge of lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_maiden_name into lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge into lp:sale-wkfl
Review: Approve l.120 is CamelCase the standard now? -- https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/214719 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge into lp:sale-wkfl
@Yannick Good to know, thank you. -- https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/214719 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/nag_refactor into lp:lp-community-utils
Sandy Carter (http://www.savoirfairelinux.com) has proposed merging
lp:~savoirfairelinux-openerp/lp-community-utils/nag_refactor into
lp:lp-community-utils.
Requested reviews:
OpenERP Community Reviewer/Maintainer (openerp-community-reviewer)
Guewen Baconnier @ Camptocamp (gbaconnier-c2c): code review
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/nag_refactor/+merge/214445
Moved functions used in openerp-nag to lp.py so they may be used by other
scripts.
As of now, openerp-nag cannot be imported by other scripts due to the dash in
its name and the fact it does not end in .py
No code was changed with the exception of the addition of the launchpad_login
function which replicates old behaviour.
I have not done any of the cleanup of my old proposal as they can be done later.
Please review this with high priority as any future changed to openerp-nag
means I have to rebase this commit.
--
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/nag_refactor/+merge/214445
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed merge of lp:~savoirfairelinux-openerp/lp-community-utils/nag_refactor
into lp:lp-community-utils.
=== added file 'lp.py'
--- lp.py 1970-01-01 00:00:00 +
+++ lp.py 2014-04-06 16:40:59 +
@@ -0,0 +1,252 @@
+# Copyright 2012 Canonical Ltd.
+# Written by:
+# Zygmunt Krynicki zygmunt.kryni...@canonical.com
+# Hacked for the OpenERP Community Reviewers version by:
+# Guewen Baconnier guewen.baconn...@camptocamp.com
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 3,
+# as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see http://www.gnu.org/licenses/.
+
+
+from __future__ import unicode_literals, print_function
+
+import collections
+import datetime
+import logging
+
+try:
+from progressbar import ProgressBar, Bar, Percentage, ETA
+except ImportError:
+ProgressBar = None
+
+from launchpadlib.launchpad import Launchpad
+
+
+# Nag:
+# Indication that we want to nag the 'person'...
+# ...with the specified 'action'
+# ...about a particular 'subject'
+Nag = collections.namedtuple(
+Nag, person action subject sort_class sort_priority sort_age project_name votes)
+
+SORT_CLASS_BUG, SORT_CLASS_MERGE = range(2)
+
+
+def show_lp_object(obj):
+print(obj)
+print(attributes:, obj.lp_attributes)
+for attr in obj.lp_attributes:
+print(attribute[%s]: %s % (attr, getattr(obj, attr)))
+print(entries:, obj.lp_entries)
+for entry in obj.lp_entries:
+print(entry[%s]: %s % (entry, getattr(obj, entry)))
+print(collections:, obj.lp_collections)
+print(operations:, obj.lp_operations)
+print(- * 80)
+
+
+class DefaultPolicy:
+
+mps_need_commit_message = False
+
+max_review_age = 0
+
+max_bug_new_age = 7
+
+# minimal number of reviewers before merging
+min_approve = 2
+
+# can't be merged before n days
+days_before_merge = 5
+
+# can be merged before days_before_merge if at least n approvals
+approvals_to_bypass = 3
+
+
+class UTC(datetime.tzinfo):
+
+def dst(self, foo):
+return datetime.timedelta(0, 0)
+
+def utcoffset(self, foo):
+return datetime.timedelta(0, 0)
+
+
+UTC = UTC()
+
+
+class Votes(object):
+ Holds votes of a proposal
+
+__states__ = {
+'Approve': 'approve',
+'Needs Fixing': 'needs_fixing',
+'Needs Information': 'needs_information',
+'Abstain': 'abstain',
+'Disapprove': 'disapprove',
+'Resubmit': 'resubmit',
+'Pending': 'pending',
+}
+
+__signs__ = {
+'approve': '+',
+'needs_fixing': '!',
+'needs_information': '?',
+'abstain': '~',
+'disapprove': '-',
+'resubmit': 'R',
+'pending': '*',
+}
+
+__ignore_for_approval__ = ['abstain', 'pending']
+
+def __init__(self, votes):
+self._votes = collections.Counter(
+self.__states__[vote.comment.vote if vote.comment else 'Pending']
+for vote in votes
+) # no comment is a pending review, usually the team
+
+def __getattr__(self, name):
+if name in self._votes:
+return self._votes[name]
+elif name in self.__states__.values():
+return 0
+else:
+raise AttributeError
+
+def __str__(self):
+signs = ['%d%s' % (count, self.__signs__[state]) for
+ state, count in self._votes.iteritems()]
+return ', '.join(signs)
+
+def
[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/nag_refactor into lp:lp-community-utils
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/lp-community-utils/nag_refactor into
lp:lp-community-utils.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/nag_refactor/+merge/214445
Moved functions used in openerp-nag to lp.py so they may be used by other
scripts.
As of now, openerp-nag cannot be imported by other scripts due to the dash in
its name and the fact it does not end in .py
No code was changed with the exception of the addition of the launchpad_login
function which replicates old behaviour.
I have not done any of the cleanup of my old proposal as they can be done later.
Please review this with high priority as any future changed to openerp-nag
means I have to rebase this commit.
--
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/nag_refactor/+merge/214445
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed merge of lp:~savoirfairelinux-openerp/lp-community-utils/nag_refactor
into lp:lp-community-utils.
=== added file 'lp.py'
--- lp.py 1970-01-01 00:00:00 +
+++ lp.py 2014-04-06 16:40:59 +
@@ -0,0 +1,252 @@
+# Copyright 2012 Canonical Ltd.
+# Written by:
+# Zygmunt Krynicki zygmunt.kryni...@canonical.com
+# Hacked for the OpenERP Community Reviewers version by:
+# Guewen Baconnier guewen.baconn...@camptocamp.com
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 3,
+# as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see http://www.gnu.org/licenses/.
+
+
+from __future__ import unicode_literals, print_function
+
+import collections
+import datetime
+import logging
+
+try:
+from progressbar import ProgressBar, Bar, Percentage, ETA
+except ImportError:
+ProgressBar = None
+
+from launchpadlib.launchpad import Launchpad
+
+
+# Nag:
+# Indication that we want to nag the 'person'...
+# ...with the specified 'action'
+# ...about a particular 'subject'
+Nag = collections.namedtuple(
+Nag, person action subject sort_class sort_priority sort_age project_name votes)
+
+SORT_CLASS_BUG, SORT_CLASS_MERGE = range(2)
+
+
+def show_lp_object(obj):
+print(obj)
+print(attributes:, obj.lp_attributes)
+for attr in obj.lp_attributes:
+print(attribute[%s]: %s % (attr, getattr(obj, attr)))
+print(entries:, obj.lp_entries)
+for entry in obj.lp_entries:
+print(entry[%s]: %s % (entry, getattr(obj, entry)))
+print(collections:, obj.lp_collections)
+print(operations:, obj.lp_operations)
+print(- * 80)
+
+
+class DefaultPolicy:
+
+mps_need_commit_message = False
+
+max_review_age = 0
+
+max_bug_new_age = 7
+
+# minimal number of reviewers before merging
+min_approve = 2
+
+# can't be merged before n days
+days_before_merge = 5
+
+# can be merged before days_before_merge if at least n approvals
+approvals_to_bypass = 3
+
+
+class UTC(datetime.tzinfo):
+
+def dst(self, foo):
+return datetime.timedelta(0, 0)
+
+def utcoffset(self, foo):
+return datetime.timedelta(0, 0)
+
+
+UTC = UTC()
+
+
+class Votes(object):
+ Holds votes of a proposal
+
+__states__ = {
+'Approve': 'approve',
+'Needs Fixing': 'needs_fixing',
+'Needs Information': 'needs_information',
+'Abstain': 'abstain',
+'Disapprove': 'disapprove',
+'Resubmit': 'resubmit',
+'Pending': 'pending',
+}
+
+__signs__ = {
+'approve': '+',
+'needs_fixing': '!',
+'needs_information': '?',
+'abstain': '~',
+'disapprove': '-',
+'resubmit': 'R',
+'pending': '*',
+}
+
+__ignore_for_approval__ = ['abstain', 'pending']
+
+def __init__(self, votes):
+self._votes = collections.Counter(
+self.__states__[vote.comment.vote if vote.comment else 'Pending']
+for vote in votes
+) # no comment is a pending review, usually the team
+
+def __getattr__(self, name):
+if name in self._votes:
+return self._votes[name]
+elif name in self.__states__.values():
+return 0
+else:
+raise AttributeError
+
+def __str__(self):
+signs = ['%d%s' % (count, self.__signs__[state]) for
+ state, count in self._votes.iteritems()]
+return ', '.join(signs)
+
+def total(self, for_approval=False):
+if for_approval:
+return sum(count for state, count in self._votes.iteritems()
+ if
[Openerp-community-reviewer] [Blueprint first-review-script] First review script
Blueprint changed by Sandy Carter (http://www.savoirfairelinux.com): Whiteboard set to: Gather information about an OpenERP addon MP * Has this MP been reviewed before by an automated script? * Does it contain message identifying as automated? * Has there been a new commit since last automated message? * Does it merge cleanly? * Is this a new module? * Add of a directory and an __openerp__.py file * Does it include tests? * Does it include demo data? * Has the .pot file been generated * Run flake8 on the entire module * Check for deprecated code * Test install the module on its own, run tests * Does it follow all OpenERP conventions * Is this a modification of an existing module * Which modules are involved? * What kind of changes are made? * Code behaviour * Model changes * Has the version been bumped * Any migration scripts included? * View changes * Tests * New tests * Added tests * Removed tests * Demo data * Data * Translation * Evaluate if changes create a net improvement * Run flake8 before and after merge * Check for deprecated code before and after merge * Run tests before and after * Are they fixed? * Are they broken? * Are they unchanged? * Which tests results have changed? Are they new/removed? * Check conventions before and after merge * Is this a mixture of both? * Separate code of new and modified * Is this a removal? * Provide link to http://pad.openerp.com/p/community-review * Identify points of concern from the pad * Vote on MP (or don't) -- First review script https://blueprints.launchpad.net/lp-community-utils/+spec/first-review-script -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Blueprint first-review-script] First review script
Blueprint changed by Sandy Carter (http://www.savoirfairelinux.com): Whiteboard changed: Gather information about an OpenERP addon MP * Has this MP been reviewed before by an automated script? * Does it contain message identifying as automated? * Has there been a new commit since last automated message? * Does it merge cleanly? * Is this a new module? * Add of a directory and an __openerp__.py file + * AGPL-3 license check * Does it include tests? * Does it include demo data? + * Does it include security files? + * Does the module version have 2 digits (1.0) * Has the .pot file been generated * Run flake8 on the entire module * Check for deprecated code + * Check for TODO and FIXME comments + * Check for debugging breakpoints (ipdb, pdb, set_trace()) * Test install the module on its own, run tests * Does it follow all OpenERP conventions * Is this a modification of an existing module * Which modules are involved? * What kind of changes are made? * Code behaviour * Model changes - * Has the version been bumped + * Has the version been bumped? * Any migration scripts included? * View changes * Tests * New tests * Added tests * Removed tests * Demo data * Data * Translation + * TODO, FIXME comments + * Added comments + * Removed comments + * Check for debugging breakpoints (ipdb, pdb, set_trace()) * Evaluate if changes create a net improvement * Run flake8 before and after merge * Check for deprecated code before and after merge * Run tests before and after * Are they fixed? * Are they broken? * Are they unchanged? * Which tests results have changed? Are they new/removed? * Check conventions before and after merge * Is this a mixture of both? * Separate code of new and modified * Is this a removal? * Provide link to http://pad.openerp.com/p/community-review * Identify points of concern from the pad * Vote on MP (or don't) -- First review script https://blueprints.launchpad.net/lp-community-utils/+spec/first-review-script -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into lp:ocb-server
Two commits have been added: r5296 from OpenERP's support r5297 from our team for a case I missed of error message translation -- https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_member_observer into lp:partner-contact-management
The proposal to merge lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_member_observer into lp:partner-contact-management has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_member_observer/+merge/204041 -- https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_member_observer/+merge/204041 Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/branch_pep8 into lp:lp-community-utils
@Guewen, thank you for the link, I was wondering if such a tool existed. -- https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/branch_pep8/+merge/205260 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/server-env-tools/7.0-auth_from_http_basic into lp:server-env-tools
Review: Approve -- https://code.launchpad.net/~therp-nl/server-env-tools/7.0-auth_from_http_basic/+merge/202316 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-project_fix_doc_count-lp1251773-vauxoo+afe into lp:ocb-addons
@yanina-aular thank you for fixing that, please backport that commit here -- https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-project_fix_doc_count-lp1251773-vauxoo+afe/+merge/209010 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into lp:ocb-server
Sandy Carter (http://www.savoirfairelinux.com) has proposed merging
lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into
lp:ocb-server.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1297525 in OpenERP Web: Title of except_orm Warning is untranslatable
https://bugs.launchpad.net/openerp-web/+bug/1297525
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736
When searching a frame for context, the _() looks for self.localcontext but
misses self.context.
The integration of this patch allows for web warnings (such as except_orm) to
be translated by _()
--
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736
Your team OpenERP Community Backports Team is requested to review the proposed
merge of
lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into
lp:ocb-server.
=== modified file 'openerp/tools/translate.py'
--- openerp/tools/translate.py 2014-03-17 08:06:23 +
+++ openerp/tools/translate.py 2014-03-25 22:24:41 +
@@ -196,7 +196,7 @@
lang = ctx.get('lang')
s = frame.f_locals.get('self', {})
if not lang:
-c = getattr(s, 'localcontext', None)
+c = getattr(s, 'localcontext', None) or getattr(s, 'context', None)
if c:
lang = c.get('lang')
if not lang:
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
[Openerp-community] recipe with bzr pull --overwrite
Hi, I have a feature request of sorts for anybox.recipe.openerp: Often times, when developping, we will change branches of certain repos as our projects progress. This happens, for example after a merge. What happens in cases like that is that the buildout will either not take in all the commits from the new branch or will fail with the following error: UpdateError: Command '['bzr', 'pull', '-d', 'bzr/addons']' returned non-zero exit status I beleive this can avoided entirely if the --overwrite flag is used. The pull call happens in vcs/bzr.py L293: update_check_call(['bzr', 'pull', '-d', self.target_dir], env=SUBPROCESS_ENV) It would be helpful to either have the option to set the --overwrite flag, or to have it one by default. What do you think? -- Sandy Carter Consultant en logiciel libre Développeur OpenERP Savoir-faire Linux Inc. 514-276-5468 poste 142 http://www.savoirfairelinux.com sandy.car...@savoirfairelinux.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/openerp-hr/department_sequence_concatination_NoneType into lp:openerp-hr
Sandy Carter (http://www.savoirfairelinux.com) has proposed merging
lp:~savoirfairelinux-openerp/openerp-hr/department_sequence_concatination_NoneType
into lp:openerp-hr.
Requested reviews:
HR Core Editors (hr-core-editors)
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/department_sequence_concatination_NoneType/+merge/212436
Fix a name_search bug and add a test to prevent future regressions:
openerp.addons.hr_department_sequence.hr_department in name_search
TypeError: can only concatenate list (not NoneType) to list
--
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/department_sequence_concatination_NoneType/+merge/212436
Your team HR Core Editors is requested to review the proposed merge of
lp:~savoirfairelinux-openerp/openerp-hr/department_sequence_concatination_NoneType
into lp:openerp-hr.
=== modified file 'hr_department_sequence/hr_department.py'
--- hr_department_sequence/hr_department.py 2013-12-04 13:35:42 +
+++ hr_department_sequence/hr_department.py 2014-03-24 14:52:50 +
@@ -52,6 +52,8 @@
for record in self.browse(cr, uid, ids, context=context or {})]
def name_search(self, cr, uid, name='', args=None, operator='ilike', context=None, limit=100):
+if args is None:
+args = []
ids = self.search(cr, uid, ['|', ('code', 'ilike', name), ('name', 'ilike', name)] + args,
limit=limit, context=context)
return self.name_get(cr, uid, ids, context=context)
=== added directory 'hr_department_sequence/tests'
=== added file 'hr_department_sequence/tests/__init__.py'
--- hr_department_sequence/tests/__init__.py 1970-01-01 00:00:00 +
+++ hr_department_sequence/tests/__init__.py 2014-03-24 14:52:50 +
@@ -0,0 +1,29 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2010 - 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import (
+test_hr_department,
+)
+
+checks = [
+test_hr_department,
+]
=== added file 'hr_department_sequence/tests/test_hr_department.py'
--- hr_department_sequence/tests/test_hr_department.py 1970-01-01 00:00:00 +
+++ hr_department_sequence/tests/test_hr_department.py 2014-03-24 14:52:50 +
@@ -0,0 +1,62 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2010 - 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from openerp.tests.common import TransactionCase
+
+
+class test_department(TransactionCase):
+
+def setUp(self):
+super(test_department, self).setUp()
+# Clean up registries
+self.registry('ir.model').clear_caches()
+self.registry('ir.model.data').clear_caches()
+# Get registries
+self.user_model = self.registry(res.users)
+self.department_model = self.registry(hr.department)
+# Get context
+self.context = self.user_model.context_get(self.cr, self.uid)
+self.vals = {
+'name': 'test',
+'code': 'TEST',
+'sequence': 1,
+}
+
+def test_create_department(self):
+cr, uid, context = self.cr, self.uid, self.context
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact into lp:partner-contact-management
For one, I do not use OCB, so there would be no point for me to propose a merge into it if I want to use it. ;) Second, I made a mistake in my comment when saying OCB, I meant OpenObject-Addons. You are absolutely right about the authorship, I will fix that. Thanks for pointing that out with a solution. -- https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact/+merge/203979 Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact into lp:partner-contact-management
@Guewen I reconstructed the history to the best of my abilities. -- https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact/+merge/203979 Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_member_observer into lp:partner-contact-management
Community, any update on this? -- https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_member_observer/+merge/204041 Your team Partner and Contact Core Editors is requested to review the proposed merge of lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_member_observer into lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_res_bank_account into lp:partner-contact-management
Community, any update on this? -- https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_res_bank_account/+merge/204047 Your team Partner and Contact Core Editors is requested to review the proposed merge of lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_res_bank_account into lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_modules into lp:partner-contact-management
Review: Approve -- https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_modules/+merge/204016 Your team Partner and Contact Core Editors is requested to review the proposed merge of lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_modules into lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/lp-community-utils/nag-user-specific-info into lp:lp-community-utils
Review: Needs Fixing code review, pep8
Looks, good, just a few pep8 issues:
openerp-nag:72:9: E126 continuation line over-indented for hanging indent
MY_READY: My MPs ready to land,
^
openerp-nag:73:9: E126 continuation line over-indented for hanging indent
MY_PENDING: My MPs needing some love,
^
openerp-nag:74:9: E126 continuation line over-indented for hanging indent
REVIEWED_READY: Ready to land, please Merge us!,
^
openerp-nag:75:9: E126 continuation line over-indented for hanging indent
REVIEWED_UPDATED: To check, updated since last need fixing vote,
^
openerp-nag:76:9: E126 continuation line over-indented for hanging indent
REVIEWED_PENDING: Nothing to do I've already reviewed those,
^
openerp-nag:77:9: E126 continuation line over-indented for hanging indent
NOT_REVIEWED: I didn't reviewed those ones,
^
openerp-nag:80:1: E302 expected 2 blank lines, found 1
def show_lp_object(obj):
^
^
openerp-nag:390:5: E303 too many blank lines (2)
if args.triage:
^
openerp-nag:415:5: E303 too many blank lines (2)
print('Votes legend:')
--
https://code.launchpad.net/~camptocamp/lp-community-utils/nag-user-specific-info/+merge/209665
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:lp-community-utils.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
