subject:"Re\: \[Openerp\-community\] What should I do with improvement proposals\?"

Re: [Openerp-community] What should I do with improvement proposals?

2014-03-06 Thread Sandy Carter

Like, you most of my proposals to lp:~openerp are not reviewed and have
not been despite months passing by and multiple emails.

I absolutely say propose it to 7.0, trunk and OCB.

The most feedback I get is from OCB reviews, which get dealt with or
fixed and in turn increase the quality of my proposal to all three repos.

It gets more eyes on your patch, better reviews and the hope is if it
accepted into ocb and doesn't cause any problems, ~openerp will also
take it.

Just remember to link the same launchpad bug in the ocb MP and propose a
patch to openerp as well.

Le 2014-03-06 12:20, Lionel Sausin a écrit :

Dear community,
Like many, I made a few merge proposals for the official trunk, for
improvements that were never merged.
I'm not blaming anyone but I'd really like to share these improvements,
because :
1/ I worked hard and they are mostly ready to be merged
and 2/ I could do with some help maintaining them
Still I'm unsure where to push some of my changes.

One example :
https://code.launchpad.net/~numerigraphe/openobject-addons/trunk-sale-order-dates/+merge/175249

I did my home work and gathered all the community patches and pieces of
advice I could, and made a clean patch.
It does not change the database layout but it does add or change (minor)
features.

Should I propose it for OCB-addons?
On the other hand I could probably refactor it into a module that I can
propose into the project "sale-wkfl". But that would certainly be a lot
of copy/paste from the original module - would it still have a chance to
be accepted?
Or should I simply resubmit my MP to the main trunk and pray (or pay?)
for someone to review it?

Again, I'm not blaming, just looking for guidance.

Lionel.

___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help : https://help.launchpad.net/ListHelp

Re: [Openerp-community] What should I do with improvement proposals?

2014-03-06 Thread Sylvain LE GAL

HI,

In your exemple, there is a lot of modifications. 2 for bugs, 1 for
blueprint, etc...

Maybe if you propose one merge proposal for just one thing, your code will
be reviewed and merge faster. (specially for bugfix)

Otherwise, if you want to propose a lot of modifications, it's better to
propose an extra-addons in one of there repositories :
https://doc.openerp.com/contribute/05_developing_modules/#community-addons

My 2 cents.

regards.

*Sylvain LE GAL*

* Service informatiqueGroupement Régional Alimentaire de Proximité*
3 Grande rue des feuillants 69001 Lyon
*Bureau : *(+33) 09.72.32.33.17
*Astreinte :* (+33) 06.81.85.61.43
*Site Web** : *www.grap.coop
* Twitter : *@legalsylvain* *


2014-03-06 18:57 GMT+01:00 Sandy Carter :

> Like, you most of my proposals to lp:~openerp are not reviewed and have
> not been despite months passing by and multiple emails.
>
> I absolutely say propose it to 7.0, trunk and OCB.
>
> The most feedback I get is from OCB reviews, which get dealt with or fixed
> and in turn increase the quality of my proposal to all three repos.
>
> It gets more eyes on your patch, better reviews and the hope is if it
> accepted into ocb and doesn't cause any problems, ~openerp will also take
> it.
>
> Just remember to link the same launchpad bug in the ocb MP and propose a
> patch to openerp as well.
>
> Le 2014-03-06 12:20, Lionel Sausin a écrit :
>
>  Dear community,
>> Like many, I made a few merge proposals for the official trunk, for
>> improvements that were never merged.
>> I'm not blaming anyone but I'd really like to share these improvements,
>> because :
>> 1/ I worked hard and they are mostly ready to be merged
>> and 2/ I could do with some help maintaining them
>> Still I'm unsure where to push some of my changes.
>>
>> One example :
>> https://code.launchpad.net/~numerigraphe/openobject-
>> addons/trunk-sale-order-dates/+merge/175249
>>
>> I did my home work and gathered all the community patches and pieces of
>> advice I could, and made a clean patch.
>> It does not change the database layout but it does add or change (minor)
>> features.
>>
>> Should I propose it for OCB-addons?
>> On the other hand I could probably refactor it into a module that I can
>> propose into the project "sale-wkfl". But that would certainly be a lot
>> of copy/paste from the original module - would it still have a chance to
>> be accepted?
>> Or should I simply resubmit my MP to the main trunk and pray (or pay?)
>> for someone to review it?
>>
>> Again, I'm not blaming, just looking for guidance.
>>
>> Lionel.
>>
>> ___
>> Mailing list: https://launchpad.net/~openerp-community
>> Post to : openerp-community@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~openerp-community
>> More help   : https://help.launchpad.net/ListHelp
>>
>
> ___
> Mailing list: https://launchpad.net/~openerp-community
> Post to : openerp-community@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~openerp-community
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community] What should I do with improvement proposals?

2014-03-06 Thread Olivier Dony


On 03/06/2014 06:20 PM, Lionel Sausin wrote:

One example :
https://code.launchpad.net/~numerigraphe/openobject-addons/trunk-sale-order-dates/+merge/175249
I did my home work and gathered all the community patches and pieces of
advice I could, and made a clean patch.


I remember reviewing it at the initial submission, I wonder why we missed it 
during the pre-7.0 merges, perhaps it was still in WIP status at that time?


I've merged it in a test branch and cleaned up a few things. For example 
_get_date_planned() was introduced by Akretion[1] after you started working on 
your patch[2], and it is now part of the API. It was also improved to deal with 
TZ issues when converting date -> datetime. Apart from this I simplified a few 
lines, spellchecked and removed things that are optional in trunk now, and 
removed the double relativedelta/timedelta use as in your initial MP.


Have a look at 
lp:~openerp-dev/openobject-addons/trunk-order-dates-numerigraphe, if it's green 
on runbot and you agree with my changes[3], then I'll merge it.


[1] rev 6077 
http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/f...@tinyerp.com-20111220174007-gr3uqxntw8w13g2f#sale/sale.py

[2] rev 5922
[3] 
http://bazaar.launchpad.net/~openerp-dev/openobject-addons/trunk-order-dates-numerigraphe/revision/9193




It does not change the database layout but it does add or change (minor)
features.

Should I propose it for OCB-addons?
On the other hand I could probably refactor it into a module that I can
propose into the project "sale-wkfl". But that would certainly be a lot
of copy/paste from the original module - would it still have a chance to
be accepted?
Or should I simply resubmit my MP to the main trunk and pray (or pay?)
for someone to review it?

Again, I'm not blaming, just looking for guidance.


You did everything right from my point of view, it's just our perpetual 
understaffing in terms of people able to perform the final review/merge MPs on 
official branches, and perhaps unlucky timing.
I'm really sorry about that! Thanks for your incredible patience and positive 
energy!


___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community] What should I do with improvement proposals?

2014-03-06 Thread Ferdinand Gassauer

On 2014-03-06 21:57, Sandy Carter wrote:

most of the improvements (merge proposals) suffer from "not invented
here" - following Antony's arguments , which I can partly understand.
OpenERP seems to only accept patches for bugs and mostly no (often very
necessary) enhancements.
And what users perceive as bugs (whatever does not allow to accomplish
their work) are classified as missing or nice to have features.

BTW I agree, not many "bugs" left, nevertheless 1000 modules needed to
accomplish work.

Like, you most of my proposals to lp:~openerp are not reviewed and
have not been despite months passing by and multiple emails.

I absolutely say propose it to 7.0, trunk and OCB.

The most feedback I get is from OCB reviews, which get dealt with or
fixed and in turn increase the quality of my proposal to all three repos.

It gets more eyes on your patch, better reviews and the hope is if it
accepted into ocb and doesn't cause any problems, ~openerp will also
take it.

Just remember to link the same launchpad bug in the ocb MP and propose
a patch to openerp as well.

Le 2014-03-06 12:20, Lionel Sausin a écrit :

One example :
https://code.launchpad.net/~numerigraphe/openobject-addons/trunk-sale-order-dates/+merge/175249

I did my home work and gathered all the community patches and pieces of
advice I could, and made a clean patch.
It does not change the database layout but it does add or change (minor)
features.

Again, I'm not blaming, just looking for guidance.

Lionel.

--
Ferdinand

Re: [Openerp-community] What should I do with improvement proposals?

2014-03-07 Thread Lionel Sausin, de la part de l'équipe informatique Numérigraphe

Dear Olivier,
Thanks for your care, the changes you made are fine by me. They're red
on runbot at the moment but it seems to be a simple reference problem in
the test.
If you merge them into the trunk, I'm confident I can port it all back
to OCB v7.

Now, you're not proposing everyone with a stalled MP to email you
personally, are you :) ?

Lionel.

Le 06/03/2014 21:45, Olivier Dony a écrit :

On 03/06/2014 06:20 PM, Lionel Sausin wrote:

One example :
https://code.launchpad.net/~numerigraphe/openobject-addons/trunk-sale-order-dates/+merge/175249

I did my home work and gathered all the community patches and pieces of
advice I could, and made a clean patch.

I remember reviewing it at the initial submission, I wonder why we
missed it during the pre-7.0 merges, perhaps it was still in WIP
status at that time?

I've merged it in a test branch and cleaned up a few things. For
example _get_date_planned() was introduced by Akretion[1] after you
started working on your patch[2], and it is now part of the API. It
was also improved to deal with TZ issues when converting date ->
datetime. Apart from this I simplified a few lines, spellchecked and
removed things that are optional in trunk now, and removed the double
relativedelta/timedelta use as in your initial MP.

Have a look at
lp:~openerp-dev/openobject-addons/trunk-order-dates-numerigraphe, if
it's green on runbot and you agree with my changes[3], then I'll merge
it.

[1] rev 6077
http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/f...@tinyerp.com-20111220174007-gr3uqxntw8w13g2f#sale/sale.py

[2] rev 5922
[3]
http://bazaar.launchpad.net/~openerp-dev/openobject-addons/trunk-order-dates-numerigraphe/revision/9193

Re: [Openerp-community] What should I do with improvement proposals?

2014-03-07 Thread Lionel Sausin

Yes it's a synthetic work indeed. I simply merged conflicting efforts 
(merge proposals, extra addons, custom modules...) that were made 
before. So in the end, it belongs in the trunk otherwise it's just one 
more competing effort...


But next time it's OK for me to make a module for OCA projects for the 
current version, and when everyone agrees, I can turn that into a MP for 
the next version.

Would everyone be happy with that?

Lionel.


Le 06/03/2014 21:35, Sylvain LE GAL a écrit :

HI,

In your exemple, there is a lot of modifications. 2 for bugs, 1 for 
blueprint, etc...


Maybe if you propose one merge proposal for just one thing, your code 
will be reviewed and merge faster. (specially for bugfix)


Otherwise, if you want to propose a lot of modifications, it's better 
to propose an extra-addons in one of there repositories :

https://doc.openerp.com/contribute/05_developing_modules/#community-addons



___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community] What should I do with improvement proposals?

Re: [Openerp-community] What should I do with improvement proposals?

Re: [Openerp-community] What should I do with improvement proposals?

Re: [Openerp-community] What should I do with improvement proposals?

Re: [Openerp-community] What should I do with improvement proposals?

Re: [Openerp-community] What should I do with improvement proposals?

6 matches

Site Navigation

Mail list logo

Footer information