[Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/account_credit_control_portal_portal_lp1248906 into lp:account-financial-tools

2014-04-03 Thread Acsone 
The proposal to merge 
lp:~acsone-openerp/account-financial-tools/account_credit_control_portal_portal_lp1248906
 into lp:account-financial-tools has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~acsone-openerp/account-financial-tools/account_credit_control_portal_portal_lp1248906/+merge/194315
-- 
https://code.launchpad.net/~acsone-openerp/account-financial-tools/account_credit_control_portal_portal_lp1248906/+merge/194315
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~dreis-pt/project-service/7.0-project_issue_reassign-dr into lp:project-service

2014-04-03 Thread Daniel Reis 
It's ready to be reviewed.
A new feature was added, to generate a notification when the Issue's 
responsibility changes.
-- 
https://code.launchpad.net/~dreis-pt/project-service/7.0-project_issue_reassign-dr/+merge/195275
Your team Project Core Editors is requested to review the proposed merge of 
lp:~dreis-pt/project-service/7.0-project_issue_reassign-dr into 
lp:project-service.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~dreis-pt/project-service/7.0-project_issue_reassign-dr into lp:project-service

2014-04-03 Thread Daniel Reis 
Daniel Reis has proposed merging 
lp:~dreis-pt/project-service/7.0-project_issue_reassign-dr into 
lp:project-service.

Requested reviews:
  Project Core Editors (project-core-editors)

For more details, see:
https://code.launchpad.net/~dreis-pt/project-service/7.0-project_issue_reassign-dr/+merge/195275

Module to improve Issue reassignment to other Projects or Users.
-- 
https://code.launchpad.net/~dreis-pt/project-service/7.0-project_issue_reassign-dr/+merge/195275
Your team Project Core Editors is requested to review the proposed merge of 
lp:~dreis-pt/project-service/7.0-project_issue_reassign-dr into 
lp:project-service.
=== added directory 'project_issue_reassign'
=== added file 'project_issue_reassign/__init__.py'
--- project_issue_reassign/__init__.py	1970-01-01 00:00:00 +
+++ project_issue_reassign/__init__.py	2014-04-02 11:39:40 +
@@ -0,0 +1,3 @@
+# -*- coding: utf-8 -*-
+import project
+import wizard

=== added file 'project_issue_reassign/__openerp__.py'
--- project_issue_reassign/__openerp__.py	1970-01-01 00:00:00 +
+++ project_issue_reassign/__openerp__.py	2014-04-02 11:39:40 +
@@ -0,0 +1,54 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Copyright (C) 2013 Daniel Reis
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+{
+'name': 'Reassign Project Issues',
+'summary': 'Reassign Issues to other Responsibles and Projects',
+'version': '1.1',
+"category": "Project Management",
+'description': """\
+The Responsible (``user_id``) field is made read only, and can instead be
+changed through a wizard, accessible only to Project Users.
+
+Regular users (Employee group) will be able to see who is handling the request,
+but won't be able to change it.
+
+Project Users can click on the "=> Reassign" link, in front of the current
+responsible, to open a dialog where they can select the new responsible and/or
+new Project/Service Team it should be assigned to.
+
+Mass reassignments can also be made, through the context menu action on the
+Issues list view.
+
+Also adds notifications to followers when issue is reassigned / responsible
+is changed.
+""",
+'author': 'Daniel Reis',
+'website': '',
+'depends': [
+'project_issue',
+],
+'data': [
+'project_issue_data.xml',
+'wizard/project_issue_reassign_view.xml',
+'project_issue_view.xml',
+],
+'installable': True,
+}
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added directory 'project_issue_reassign/i18n'
=== added file 'project_issue_reassign/i18n/project_issue_reassign.pot'
--- project_issue_reassign/i18n/project_issue_reassign.pot	1970-01-01 00:00:00 +
+++ project_issue_reassign/i18n/project_issue_reassign.pot	2014-04-02 11:39:40 +
@@ -0,0 +1,82 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* project_issue_reassign
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2014-04-02 10:56+\n"
+"PO-Revision-Date: 2014-04-02 10:56+\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: project_issue_reassign
+#: view:project.issue.reassign:0
+msgid "or"
+msgstr ""
+
+#. module: project_issue_reassign
+#: code:addons/project_issue_reassign/wizard/project_issue_reassign.py:42
+#, python-format
+msgid "No active Issues found."
+msgstr ""
+
+#. module: project_issue_reassign
+#: model:ir.model,name:project_issue_reassign.model_project_issue
+msgid "Project Issue"
+msgstr ""
+
+#. module: project_issue_reassign
+#: model:ir.model,name:project_issue_reassign.model_project_issue_reassign
+msgid "Issue Reassign"
+msgstr ""
+
+#. module: project_issue_reassign
+#: view:project.issue.reassign:0
+msgid "_Reassign"
+msgstr ""
+
+#. module: project_issue_reassign
+#: model:ir.actions.act_window,name:project_issue_reassign.issue_reassign_wizard_action
+msgid "Reassign Issues"
+msgstr ""
+
+#. module: project_issue_reassign
+#: model:ir.actions.act_window,name:project_issue_reassign.action_project_issue_rea

[Openerp-community-reviewer] [Merge] lp:~sylvain-legal/web-addons/7.0-web_easy_switch_company into lp:web-addons

2014-04-03 Thread noreply 
The proposal to merge lp:~sylvain-legal/web-addons/7.0-web_easy_switch_company 
into lp:web-addons has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~sylvain-legal/web-addons/7.0-web_easy_switch_company/+merge/210289
-- 
https://code.launchpad.net/~sylvain-legal/web-addons/7.0-web_easy_switch_company/+merge/210289
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr into lp:web-addons

2014-04-03 Thread Pedro Manuel Baeza 
Review: Approve code review and test

Hi, Guewen, thanks for the catch. I have tested your bug conditions and now it 
works as intended. Do you think it's possible to make a test for this condition 
to avoid future regressions?

Another ask I made from my JS ignorance. Do you think it's possible to change 
module behaviour to only load translate dialog for the field you have clicked? 
This way, all is going to be more intuitive (the initial intention of OpenERP 
SA when they change the behaviour), and avoid scrolling problems detected on 
first MP when you have a lot of translatable fields on the current model.

Regards.
-- 
https://code.launchpad.net/~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr/+merge/213783
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~dreis-pt/project-service/7.0-project_issue_reassign-dr into lp:project-service

2014-04-03 Thread Pedro Manuel Baeza 
The proposal to merge 
lp:~dreis-pt/project-service/7.0-project_issue_reassign-dr into 
lp:project-service has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~dreis-pt/project-service/7.0-project_issue_reassign-dr/+merge/195275
-- 
https://code.launchpad.net/~dreis-pt/project-service/7.0-project_issue_reassign-dr/+merge/195275
Your team Project Core Editors is requested to review the proposed merge of 
lp:~dreis-pt/project-service/7.0-project_issue_reassign-dr into 
lp:project-service.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7 into lp:account-invoicing

2014-04-03 Thread Pedro Manuel Baeza 
Review: Needs Fixing code review

Hi, Alex, thank you very much for the contribution. Some remarks:

- l.137: Please close string before \ to avoid that spaces on translations (you 
will have to export again translations):

help="International Commercial Terms are a series of predefined " \
"commercial terms used in international transactions."

- l.135,382,392: Is it necessary to put such a complicated xpath? This makes 
more difficult to migrate code to future versions. If there is only one 
'date_due' field, you can put directly . If there is 
more than one, at least you can put relative xpath to make it more portable: 
http://legacy.python.org/dev/peps/pep-0008/#indentation). This is my 
suggestion:

def _prepare_invoice_group(
self, cr, uid, picking, partner,
invoice, context=None):
invoice_vals = ...

- Don't you think that it's convenient to copy incoterm (if any) from sale 
order to picking?

Very good detail including a test.

Regards.
-- 
https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-product_price_history-index-1301847 into lp:margin-analysis

2014-04-03 Thread Yannick Vaucher @ Camptocamp 
Review: Approve code review, no test

Good catch

LGTM
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_price_history-index-1301847/+merge/214001
Your team Margin Analysis Core Editors is subscribed to branch 
lp:margin-analysis.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_line_watcher into lp:sale-financial

2014-04-03 Thread Yannick Vaucher @ Camptocamp 
Thanks Pedro I wasn't aware of web_context_tunnel. This is indeed the right 
time to use it.

It would make this module obsolete.

Back to WIP
-- 
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_line_watcher/+merge/214058
Your team Sale Core Editors is subscribed to branch lp:sale-financial.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_floor_price into lp:sale-financial

2014-04-03 Thread Yannick Vaucher @ Camptocamp 
The proposal to merge lp:~camptocamp/sale-financial/7.0-port-sale_floor_price 
into lp:sale-financial has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_floor_price/+merge/214059
-- 
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_floor_price/+merge/214059
Your team Sale Core Editors is subscribed to branch lp:sale-financial.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries

2014-04-03 Thread Romain Deheele - Camptocamp 
ok for CapWords convention, thanks Stefan.
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-product_price_history-index-1301847 into lp:margin-analysis

2014-04-03 Thread Pedro Manuel Baeza 
Review: Approve code review

Ah, OK, the intention is to compose a full index of the four fields. I get it.

Regards.
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_price_history-index-1301847/+merge/214001
Your team Margin Analysis Core Editors is subscribed to branch 
lp:margin-analysis.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-product_price_history-index-1301847 into lp:margin-analysis

2014-04-03 Thread Guewen Baconnier @ Camptocamp 
No, we can't do composed indexes with select=True

-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_price_history-index-1301847/+merge/214001
Your team Margin Analysis Core Editors is subscribed to branch 
lp:margin-analysis.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-product_price_history-index-1301847 into lp:margin-analysis

2014-04-03 Thread Pedro Manuel Baeza 
Review: Needs Information code review

Can't this be done with select=1 attribute?

Regards.
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_price_history-index-1301847/+merge/214001
Your team Margin Analysis Core Editors is subscribed to branch 
lp:margin-analysis.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_floor_price into lp:sale-financial

2014-04-03 Thread Pedro Manuel Baeza 
Review: Needs Fixing

See comments on the other MP that can affect this one. Please also mark this MP 
as dependent of the other. I set it as Needs fixing to take this into account.

Thanks. Regards.
-- 
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_floor_price/+merge/214059
Your team Sale Core Editors is subscribed to branch lp:sale-financial.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_markup into lp:sale-financial

2014-04-03 Thread Yannick Vaucher @ Camptocamp 
The proposal to merge lp:~camptocamp/sale-financial/7.0-port-sale_markup into 
lp:sale-financial has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_markup/+merge/214061
-- 
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_markup/+merge/214061
Your team Sale Core Editors is requested to review the proposed merge of 
lp:~camptocamp/sale-financial/7.0-port-sale_markup into lp:sale-financial.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_line_watcher into lp:sale-financial

2014-04-03 Thread Pedro Manuel Baeza 
Review: Needs Fixing code review

Hi, Yannick, several things:

- Instead of replacing a field, it's better to put position="attributes" and 
only overwrite attribute on_change, so that you don't replace another 
attributes of the field.

- I think it's better to use module web_context_tunnel to avoid changes on the 
signature of the method that provokes incompatibilities between modules.

Regards.
-- 
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_line_watcher/+merge/214058
Your team Sale Core Editors is subscribed to branch lp:sale-financial.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_line_watcher into lp:sale-financial

2014-04-03 Thread Yannick Vaucher @ Camptocamp 
Yannick Vaucher @ Camptocamp has proposed merging 
lp:~camptocamp/sale-financial/7.0-port-sale_line_watcher into lp:sale-financial.

Requested reviews:
  Sale Core Editors (sale-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_line_watcher/+merge/214058

Portage of module sale_line_watcher to v7
-- 
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_line_watcher/+merge/214058
Your team Sale Core Editors is requested to review the proposed merge of 
lp:~camptocamp/sale-financial/7.0-port-sale_line_watcher into lp:sale-financial.
=== modified file 'sale_line_watcher/__openerp__.py'
--- sale_line_watcher/__openerp__.py	2013-11-14 08:16:22 +
+++ sale_line_watcher/__openerp__.py	2014-04-03 15:31:56 +
@@ -23,11 +23,15 @@
  'author' : 'Camptocamp',
  'maintainer': 'Camptocamp',
  'category': 'Hidden',
- 'complexity': "normal",  # easy, normal, expert
+ 'complexity': "normal",
  'depends' : ['base', 'sale'],
- 'description': """Add new base onchange methods on sale_order class
-
- onchange_price_unit and onchange_discount both accept the following arguments:
+ 'description': """
+Sale order line watcher
+===
+
+Add new base onchange methods on sale_order class
+
+onchange_price_unit and onchange_discount both accept the following arguments:
  (self, cr, uid, ids, price_unit, product_id, discount, product_uom, pricelist, **kwargs)
 """,
  'website': 'http://www.camptocamp.com',
@@ -35,7 +39,7 @@
  'update_xml': ['sale_view.xml'],
  'demo_xml': [],
  'tests': [],
- 'installable': False,
+ 'installable': True,
  'auto_install': False,
  'license': 'AGPL-3',
  'application': True}

=== modified file 'sale_line_watcher/sale_view.xml'
--- sale_line_watcher/sale_view.xml	2012-05-29 07:06:32 +
+++ sale_line_watcher/sale_view.xml	2014-04-03 15:31:56 +
@@ -3,7 +3,6 @@
   
 
   sales_line_watcher.view.form2
-  form
   sale.order.line
   
   
@@ -17,7 +16,6 @@
 
 
   sales_line_watcher.view.form3
-  form
   sale.order.line
   
   
@@ -32,7 +30,6 @@
   sales_line_watcher.form.floorprice
   sale.order
   
-  form
   
 
   sales_line_watcher.form.floorprice
   sale.order
   
-  form
   
 
   
 
   

=== modified file 'sale_line_watcher/sale_watcher.py'
--- sale_line_watcher/sale_watcher.py	2012-05-29 07:06:32 +
+++ sale_line_watcher/sale_watcher.py	2014-04-03 15:31:56 +
@@ -25,20 +25,20 @@
 _inherit = 'sale.order.line'
 
 def onchange_price_unit(self, cr, uid, ids,
-price_unit, product_id, discount, product_uom, pricelist,
-**kwargs):
-'''
+price_unit, product_id, discount, product_uom,
+pricelist, **kwargs):
+"""
 Place holder function for onchange unit price
-'''
+"""
 res = {}
 return res
 
 def onchange_discount(self, cr, uid, ids,
-  price_unit, product_id, discount, product_uom, pricelist,
-  **kwargs):
-'''
+  price_unit, product_id, discount, product_uom,
+  pricelist, **kwargs):
+"""
 Place holder function for onchange discount
-'''
+"""
 res = {}
 return res
 

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_markup into lp:sale-financial

2014-04-03 Thread Yannick Vaucher @ Camptocamp 
Yannick Vaucher @ Camptocamp has proposed merging 
lp:~camptocamp/sale-financial/7.0-port-sale_markup into lp:sale-financial.

Requested reviews:
  Sale Core Editors (sale-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_markup/+merge/214061

Portage of module sale_markup


Requires following module portages

https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_line_watcher/+merge/214058
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_floor_price/+merge/214059
-- 
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_markup/+merge/214061
Your team Sale Core Editors is requested to review the proposed merge of 
lp:~camptocamp/sale-financial/7.0-port-sale_markup into lp:sale-financial.
=== modified file 'sale_markup/__openerp__.py'
--- sale_markup/__openerp__.py	2013-11-14 08:16:22 +
+++ sale_markup/__openerp__.py	2014-04-03 15:35:21 +
@@ -23,19 +23,24 @@
  'author' : 'Camptocamp',
  'maintainer': 'Camptocamp',
  'category': 'version',
- 'complexity': "normal",  # easy, normal, expert
- 'depends' : ['base',
-  'product_get_cost_field',
-  'mrp',
-  'sale',
-  'sale_floor_price'],
- 'description': """display the product and sale markup in the appropriate views""",
+ 'complexity': "normal",
+ 'depends' : [
+ 'base',
+ 'product_get_cost_field',
+ 'mrp',
+ 'sale',
+ 'sale_floor_price'],
+ 'description': """
+Markup rate on product and sales
+
+
+Display the product and sale markup in the appropriate views
+""",
  'website': 'http://www.camptocamp.com/',
- 'init_xml': [],
- 'update_xml': ['sale_view.xml', 'product_view.xml'],
- 'demo_xml': [],
- 'tests': [],
- 'installable': False,
+ 'data': ['sale_view.xml',
+  'product_view.xml'],
+ 'test': [],
+ 'installable': True,
  'auto_install': False,
  'license': 'AGPL-3',
  'application': True}

=== added file 'sale_markup/i18n/fr.po'
--- sale_markup/i18n/fr.po	1970-01-01 00:00:00 +
+++ sale_markup/i18n/fr.po	2014-04-03 15:35:21 +
@@ -0,0 +1,76 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* sale_markup
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2014-04-03 14:11+\n"
+"PO-Revision-Date: 2014-04-03 16:32+0100\n"
+"Last-Translator: Yannick Vaucher \n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: \n"
+
+#. module: sale_markup
+#: field:product.product,cost_price:0
+msgid "Cost Price"
+msgstr "Coût de revient"
+
+#. module: sale_markup
+#: field:sale.order.line,cost_price:0
+msgid "Historical Cost Price"
+msgstr "Coût de revient historique"
+
+#. module: sale_markup
+#: field:product.product,commercial_margin:0
+#: field:sale.order.line,commercial_margin:0
+msgid "Margin"
+msgstr "Marge"
+
+#. module: sale_markup
+#: help:product.product,commercial_margin:0
+msgid "Margin is [ sale_price - cost_price ] (not based on historical values)"
+msgstr "La marge est calculée ainsi [ prix_vente - prix_achat ] (n'est pas basé sur l'historique des valeurs)"
+
+#. module: sale_markup
+#: help:sale.order.line,commercial_margin:0
+msgid "Margin is [ sale_price - cost_price ], changing it will update the discount"
+msgstr "La marge est calculée ainsi [ prix_vente - prix_achat ], changer la marge adapte la remise."
+
+#. module: sale_markup
+#: help:sale.order.line,markup_rate:0
+msgid "Markup is [ margin / sale_price ], changing it will update the discount"
+msgstr "Le taux de marque est calculé ainsi [ marge / prix_vente ], changer le taux de marque adapte la remise."
+
+#. module: sale_markup
+#: view:sale.order:0
+#: field:sale.order,markup_rate:0
+#: field:sale.order.line,markup_rate:0
+#: field:product.product,markup_rate:0
+msgid "Markup"
+msgstr "Taux de marque"
+
+#. module: sale_markup
+#: help:product.product,markup_rate:0
+msgid "Markup is [ margin / sale_price ] (not based on historical values)"
+msgstr "Le taux de marque est [ marge / prix_vente ] (n'est pas basé sur l'historique des valeurs)"
+
+#. module: sale_markup
+#: help:product.product,cost_price:0
+msgid "The cost price is the standard price unless you install the product_cost_incl_bom module."
+msgstr "Le coût de revient est le prix standard à moins que le module product_cost_incl_bom ne soit installé."
+
+#. module: sale_markup
+#: help:sale.order.line,cost_price:0
+msgid "The cost price of the product at the time of the creation of the sale order"
+msgstr "Le coût de revient du produit au moment de la création de la commande client."
+
+#. module: sale_markup
+#: view:sale.order:0
+msgid "product_id_change(parent.pricelist_id,product_id,product_uom_qty,product_uom,product_uos_qty,product_uos,name,parent.partner_id,False,True,parent.date_order,product_packaging,

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_floor_price into lp:sale-financial

2014-04-03 Thread Yannick Vaucher @ Camptocamp 
Yannick Vaucher @ Camptocamp has proposed merging 
lp:~camptocamp/sale-financial/7.0-port-sale_floor_price into lp:sale-financial.

Requested reviews:
  Sale Core Editors (sale-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_floor_price/+merge/214059

Portage of sale_floor_price


Requires sale_line_watcher ported in

https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_line_watcher/+merge/214058
-- 
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_floor_price/+merge/214059
Your team Sale Core Editors is requested to review the proposed merge of 
lp:~camptocamp/sale-financial/7.0-port-sale_floor_price into lp:sale-financial.
=== modified file 'sale_floor_price/__init__.py'
--- sale_floor_price/__init__.py	2012-05-29 07:06:32 +
+++ sale_floor_price/__init__.py	2014-04-03 15:33:01 +
@@ -1,27 +1,25 @@
 # -*- coding: utf-8 -*-
 ##
 #
-#Copyright (c) 2011 Camptocamp SA (http://www.camptocamp.com)
-#All Right Reserved
-#
-#Author : Joel Grand-Guillaume (Camptocamp)
+#Author: Joël Grand-Guillaume
+#Copyright 2012 Camptocamp SA
 #
 #This program is free software: you can redistribute it and/or modify
-#it under the terms of the GNU General Public License as published by
-#the Free Software Foundation, either version 3 of the License, or
-#(at your option) any later version.
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
 #
 #This program is distributed in the hope that it will be useful,
 #but WITHOUT ANY WARRANTY; without even the implied warranty of
 #MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#GNU General Public License for more details.
+#GNU Affero General Public License for more details.
 #
 #You should have received a copy of the GNU Affero General Public License
 #along with this program.  If not, see .
 #
 ##
 
-import product
-import floor_sale
+from . import product
+from . import floor_sale
 
 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== modified file 'sale_floor_price/__openerp__.py'
--- sale_floor_price/__openerp__.py	2013-11-14 08:16:22 +
+++ sale_floor_price/__openerp__.py	2014-04-03 15:33:01 +
@@ -23,16 +23,18 @@
  'author' : 'Camptocamp',
  'maintainer': 'Camptocamp',
  'category': 'Tool',
- 'complexity': "normal",  # easy, normal, expert
+ 'complexity': "normal",
  'depends' : ['stock','product','sale', 'sale_line_watcher'],
- 'description': """Set a minimal price on product and raise a warning if sale price is too low""",
+ 'description': """
+Floor price on product
+==
+
+Set a minimal price on product and raise a warning if sale price is too low
+""",
  'website': 'http://www.camptocamp.com',
- 'init_xml': [],
- 'update_xml': ['product_view.xml'],
- 'demo_xml': [],
- 'tests': [],
- 'installable': False,
+ 'data': ['product_view.xml'],
+ 'test': [],
+ 'installable': True,
  'auto_install': False,
  'license': 'AGPL-3',
  'application': True}
-

=== modified file 'sale_floor_price/floor_sale.py'
--- sale_floor_price/floor_sale.py	2012-06-06 13:14:12 +
+++ sale_floor_price/floor_sale.py	2014-04-03 15:33:01 +
@@ -1,20 +1,18 @@
 # -*- coding: utf-8 -*-
 ##
 #
-#Copyright (c) 2011 Camptocamp SA (http://www.camptocamp.com)
-#All Right Reserved
-#
-#Author : Joel Grand-Guillaume (Camptocamp)
+#Author: Joël Grand-Guillaume
+#Copyright 2012 Camptocamp SA
 #
 #This program is free software: you can redistribute it and/or modify
-#it under the terms of the GNU General Public License as published by
-#the Free Software Foundation, either version 3 of the License, or
-#(at your option) any later version.
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
 #
 #This program is distributed in the hope that it will be useful,
 #but WITHOUT ANY WARRANTY; without even the implied warranty of
 #MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#GNU General Public License for more details.
+#GNU Affero General Public License for more details.
 #
 #You should have received a copy of the GNU Affero General Public License
 #along with this program.  If not, see .
@@ -24,12 +22,14 @@
 from osv.orm import Model
 from tools.translate import _
 
+
 class SaleOrderLine(Model):
 _inherit = 'sale.order.line'
 
 def _reach_floor_

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries

2014-04-03 Thread Leonardo Pistone - camptocamp 
Stefan, what I mean is that I prefer CamelCase too, but I abstain here because 
SA uses underscores all over the place.
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries

2014-04-03 Thread Stefan Rijnhart (Therp) 
Sure, but the mapping from class 'CarrierFile' (instead of 'carrier_file') to 
model 'carrier.file' is still equally obvious.
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries

2014-04-03 Thread Leonardo Pistone - camptocamp 
I abstain on Stefan's remark.

I would love to see python conventions like that one to be used. The habit to 
have in OpenERP the class name with underscores is perhaps because normally 
that makes the class name correspond to the table name (in fact, the table name 
is _name with dots changed to underscores).
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries

2014-04-03 Thread Yannick Vaucher @ Camptocamp 
+1 for Stefan comment
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/add_aged_partner_ledger-nbi into lp:account-financial-report

2014-04-03 Thread Christelle De Coninck (Acsone) 
Hi Nicolas, 

I'm working as a business analyst for Acsone and Stéphane Bidoul asked me to 
make a functional test regarding the new "Aged Partner Balance" report . 

I noticed that the amounts are classified in the different columns (<30, <60, 
etc.) based on the clearance Date. By default, this clearance date is the end 
of the fiscal year (31/12/2014 in this case). 

I tried to change this date but it is forbidden and I obtained the following 
error message: 

ValidateError

Error occurred while validating the field(s) until_date: Clearance date must be 
the very last date of the last period or later.

In my opinion, it is interesting to let the user choose the clearance date he 
wants for his report. Furthermore, I think that current date is again more 
interesting as it permits to have a good representation of the actual 
situation. 

An improvement to this report could thus be that the current date is used as 
default date and the user have the possibility to change it. 

What do you think? 

Thanks in advance for your answer


-- 
https://code.launchpad.net/~camptocamp/account-financial-report/add_aged_partner_ledger-nbi/+merge/211040
Your team Account Report Core Editors is subscribed to branch 
lp:account-financial-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-report/purchase_report_carriage_return_vre into lp:purchase-report

2014-04-03 Thread Vincent Renaville@camptocamp 
Vincent Renaville@camptocamp has proposed merging 
lp:~camptocamp/purchase-report/purchase_report_carriage_return_vre into 
lp:purchase-report.

Requested reviews:
  Purchase Core Editors (purchase-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/purchase-report/purchase_report_carriage_return_vre/+merge/214030

This add the possibility to add carriage return in the name of the product 
description.

-- 
https://code.launchpad.net/~camptocamp/purchase-report/purchase_report_carriage_return_vre/+merge/214030
Your team Purchase Core Editors is requested to review the proposed merge of 
lp:~camptocamp/purchase-report/purchase_report_carriage_return_vre into 
lp:purchase-report.
=== modified file 'purchase_order_webkit/report/purchase_order.mako'
--- purchase_order_webkit/report/purchase_order.mako	2014-01-22 10:39:22 +
+++ purchase_order_webkit/report/purchase_order.mako	2014-04-03 13:32:26 +
@@ -179,27 +179,34 @@
 }
 td.main_col1 {
 text-align:left;
+vertical-align:top;
 }
 .main_col2 {
 width: 10%;
+vertical-align:top;
 }
 .main_col3 {
 width: 10%;
 text-align:center;
+vertical-align:top;
 }
 .main_col6 {
 width: 10%;
+vertical-align:top;
 }
 .main_col4 {
 	width: 10%;
 	text-align:right;
+vertical-align:top;
 }
 .main_col5 {
 width: 7%;
 text-align:left;
+vertical-align:top;
 }
 .main_col7 {
 width: 13%;
+vertical-align:top;
 }
 
 
@@ -297,12 +304,12 @@
   
 
   
-${line.name}
+${line.name and line.name.replace('\n','') or '' | n}
 ${ ', '.join([ tax.name or '' for tax in line.taxes_id ])}
 ${formatLang(line.date_planned, date=True)}
 ${line.product_qty}
 ${line.product_uom.name}
-${formatLang(line.price_unit, digits=get_digits(dp='Purchase Price'))}
+${formatLang(line.price_unit, digits=get_digits(dp='Purchase Price'))}
 ${formatLang(line.price_subtotal, digits=get_digits(dp='Purchase Price'))} ${purch.pricelist_id.currency_id.symbol}
   
  

=== modified file 'purchase_order_webkit/report/request_quotation.mako'
--- purchase_order_webkit/report/request_quotation.mako	2014-01-10 14:52:43 +
+++ purchase_order_webkit/report/request_quotation.mako	2014-04-03 13:32:26 +
@@ -179,27 +179,34 @@
 }
 td.main_col1 {
 text-align:left;
+vertical-align:top;
 }
 .main_col2 {
 width: 10%;
+vertical-align:top;
 }
 .main_col3 {
 width: 10%;
 text-align:center;
+vertical-align:top;
 }
 .main_col6 {
 width: 10%;
+vertical-align:top;
 }
 .main_col4 {
 width: 10%;
 text-align:right;
+vertical-align:top;
 }
 .main_col5 {
 width: 7%;
 text-align:left;
+vertical-align:top;
 }
 .main_col7 {
 width: 13%;
+vertical-align:top;
 }
 
 
@@ -263,9 +270,9 @@
 
 	  
 	
-${_("Description")}
-${_("Expected Date")}
-${_("Qty")}
+${_("Description")}
+${_("Expected Date")}
+${_("Qty")}
   
 
   
@@ -279,9 +286,9 @@
   
 		%for line in purch.order_line :
 		
-		${line.name}
-		${formatLang(line.date_planned, date=True)}
-		${line.product_qty} ${line.product_uom and line.product_uom.name or ''}
+		${line.name and line.name.replace('\n','') or '' | n}
+		${formatLang(line.date_planned, date=True)}
+		${line.product_qty} ${line.product_uom and line.product_uom.name or ''}
 
 %endfor
  

=== modified file 'purchase_order_webkit_with_notes/report/purchase_order.mako'
--- purchase_order_webkit_with_notes/report/purchase_order.mako	2014-01-22 10:39:22 +
+++ purchase_order_webkit_with_notes/report/purchase_order.mako	2014-04-03 13:32:26 +
@@ -179,27 +179,34 @@
 }
 td.main_col1 {
 text-align:left;
+vertical-align:top;
 }
 .main_col2 {
 width: 10%;
+vertical-align:top;
 }
 .main_col3 {
 width: 10%;
 text-align:center;
+vertical-align:top;
 }
 .main_col6 {
 width: 10%;
+vertical-align:top;
 }
 .main_col4 {
 	width: 10%;
 	text-align:right;
+vertical-align:top;
 }
 .main_col5 {
 width: 7%;
 text-align:left;
+vertical-align:top;
 }
 .main_col7 {
 width: 13%;
+vertical-align:top;
 }
 
 
@@ -300,12 +307,12 @@
   
 
   
-${line.name}
+${line.name and line.name.replace('\n','') or '' | n}
 ${ ', '.join([ tax.name or '' for tax in line.taxes_id ])}

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries

2014-04-03 Thread Stefan Rijnhart (Therp) 
Review: Needs Information

Maybe take the occasion to switch the affected code to the Python convention 
for CapCase class names, which prevents this problem? 
http://legacy.python.org/dev/peps/pep-0008/#class-names

-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries

2014-04-03 Thread Pedro Manuel Baeza 
Review: Approve code review

A frequent problem if you put a common python class name...

Thanks for the patch.

Regards.
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-product_price_history-index-1301847 into lp:margin-analysis

2014-04-03 Thread Guewen Baconnier @ Camptocamp 
Guewen Baconnier @ Camptocamp has proposed merging 
lp:~camptocamp/margin-analysis/7.0-product_price_history-index-1301847 into 
lp:margin-analysis.

Commit message:
Add index on the columns that are used in the SELECT everytime a price is 
fetched

Requested reviews:
  Margin Analysis Core Editors (margin-analysis-core-editors)
Related bugs:
  Bug #1301847 in Financial controlling and costing: "Index could be added on 
product_price_history"
  https://bugs.launchpad.net/margin-analysis/+bug/1301847

For more details, see:
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_price_history-index-1301847/+merge/214001

fix lp:1301847

Details on the bug report.
That also removes a TODO!
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_price_history-index-1301847/+merge/214001
Your team Margin Analysis Core Editors is requested to review the proposed 
merge of lp:~camptocamp/margin-analysis/7.0-product_price_history-index-1301847 
into lp:margin-analysis.
=== modified file 'product_price_history/product_price_history.py'
--- product_price_history/product_price_history.py	2014-02-04 10:46:08 +
+++ product_price_history/product_price_history.py	2014-04-03 11:22:08 +
@@ -33,10 +33,21 @@
 
 
 class product_price_history(orm.Model):
-# TODO : Create good index for select
 _name = 'product.price.history'
 _order = 'datetime, company_id asc'
 
+def _auto_init(self, cr, context=None):
+res = super(product_price_history, self)._auto_init(cr,
+context=context)
+cr.execute("SELECT indexname "
+   "FROM pg_indexes "
+   "WHERE indexname = 'product_price_history_all_index'")
+if not cr.fetchone():
+cr.execute("CREATE INDEX product_price_history_all_index "
+   "ON product_price_history "
+   "(product_id, company_id, name, datetime)")
+return res
+
 _columns = {
 'name': fields.char('Field name', size=32, required=True),
 'company_id': fields.many2one('res.company', 'Company',

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7 into lp:account-invoicing

2014-04-03 Thread Alex Comba - Agile BG 
Alex Comba - Agile BG has proposed merging 
lp:~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7 into 
lp:account-invoicing.

Commit message:
[ADD] module stock_invoice_picking_incoterm

Requested reviews:
  Account Core Editors (account-core-editors)

For more details, see:
https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987

I added the module named 'stock_invoice_picking_incoterm'.

It adds the field incoterm to invoice and picking. In this way the user can 
specify the incoterm directly on these documents, with no need to refer to the 
incoterm of the order (which could even be missing). The module extends 
'stock_invoice_picking' so that the invoices created from pickings will have 
the same incoterm set in the picking.
-- 
https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987
Your team Account Core Editors is requested to review the proposed merge of 
lp:~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7 into 
lp:account-invoicing.
=== added directory 'stock_invoice_picking_incoterm'
=== added file 'stock_invoice_picking_incoterm/__init__.py'
--- stock_invoice_picking_incoterm/__init__.py	1970-01-01 00:00:00 +
+++ stock_invoice_picking_incoterm/__init__.py	2014-04-03 09:46:52 +
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Copyright (C) 2014 Agile Business Group sagl
+#	 ()
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as published
+#by the Free Software Foundation, either version 3 of the License, or
+#(at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+from . import account_invoice
+from . import stock

=== added file 'stock_invoice_picking_incoterm/__openerp__.py'
--- stock_invoice_picking_incoterm/__openerp__.py	1970-01-01 00:00:00 +
+++ stock_invoice_picking_incoterm/__openerp__.py	2014-04-03 09:46:52 +
@@ -0,0 +1,48 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Copyright (C) 2014 Agile Business Group sagl
+#()
+#@author Alex Comba 
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as published
+#by the Free Software Foundation, either version 3 of the License, or
+#(at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+{
+'name': "Stock Invoice Picking Incoterm",
+'version': '0.1',
+'category': 'Warehouse Management',
+'description': """
+This module adds the field incoterm to invoice and picking. In this way the
+user can specify the incoterm directly on these documents, with no need to
+refer to the incoterm of the order (which could even be missing).
+The module extends 'stock_invoice_picking' so that the invoices created
+from pickings will have the same incoterm set in the picking.
+""",
+'author': 'Agile Business Group',
+'website': 'http://www.agilebg.com',
+'license': 'AGPL-3',
+'depends': [
+'stock_invoice_picking',
+],
+'data': [
+'account_invoice_view.xml',
+'stock_view.xml',
+],
+'test': [
+'test/invoice_picking_incoterm.yml',
+],
+'active': False,
+'installable': True
+}

=== added file 'stock_invoice_picking_incoterm/account_invoice.py'
--- stock_invoice_picking_incoterm/account_invoice.py	1970-01-01 00:00:00 +
+++ stock_invoice_picking_incoterm/account_invoice.py	2014-04-03 09:46:52 +
@@ -0,0 +1,35 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Copyright (C) 2014 Agile Business Group sagl
+#()
+#
+#This program is free software: you can redistribut

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/6.1-fix-1182111-lep into lp:ocb-addons/6.1

2014-04-03 Thread Stefan Rijnhart (Therp) 
Review: Approve

Thanks, lgtm.
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/6.1-fix-1182111-lep/+merge/213979
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 1182111] Re: [trunk/7.0] multicompany: error message when creating a stock.move

2014-04-03 Thread Martin Trigaux (OpenERP) 
** Changed in: openobject-addons
   Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1182111

Title:
  [trunk/7.0] multicompany: error message when creating a stock.move

Status in OpenERP Community Backports (Addons):
  Fix Released
Status in OpenERP Community Backports (Addons) 7.0 series:
  Fix Released
Status in OpenERP Addons (modules):
  Fix Released

Bug description:
  Steps to reproduce:

  * log on a 7.0 instance on runbot as admin
  * create a new user with login "test_warehouse" belonging to a child company 
of "you company", make him warehouse manager, let him access only that company 
(don't forget to change his password)
  * log out, log on as test_warehouse
  * go the Warehouse > internal pickings and click on create
  * add a new item 

  What I get:

  * an unexpected error message box, which I can remove (by clicking
  "OK") but which is *very* annoying when it shows up 50x each day

  See screenshot.

  This error is caused by trying to get the name of a stock location on
  which the user has no access.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1182111/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries

2014-04-03 Thread Leonardo Pistone - camptocamp 
Review: Approve

thanks
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/6.1-fix-1182111-lep into lp:ocb-addons/6.1

2014-04-03 Thread Leonardo Pistone - camptocamp 
Leonardo Pistone - camptocamp has proposed merging 
lp:~camptocamp/ocb-addons/6.1-fix-1182111-lep into lp:ocb-addons/6.1.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1182111 in OpenERP Community Backports (Addons): "[trunk/7.0] 
multicompany: error message when creating a stock.move"
  https://bugs.launchpad.net/ocb-addons/+bug/1182111

For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/6.1-fix-1182111-lep/+merge/213979
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/6.1-fix-1182111-lep/+merge/213979
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~camptocamp/ocb-addons/6.1-fix-1182111-lep into lp:ocb-addons/6.1.
=== modified file 'stock/__openerp__.py'
--- stock/__openerp__.py	2012-01-31 13:36:57 +
+++ stock/__openerp__.py	2014-04-03 09:02:09 +
@@ -86,6 +86,7 @@
 'test/opening_stock.yml',
 'test/shipment.yml',
 'test/stock_report.yml',
+'test/multicompany.yml',
 ],
 'installable': True,
 'application': True,

=== modified file 'stock/stock.py'
--- stock/stock.py	2013-09-10 15:12:35 +
+++ stock/stock.py	2014-04-03 09:02:09 +
@@ -26,6 +26,7 @@
 from itertools import groupby
 
 from osv import fields, osv
+from osv.orm import except_orm
 from tools.translate import _
 import netsvc
 import tools
@@ -1651,7 +1652,14 @@
 elif picking_type == 'out':
 location_xml_id = 'stock_location_customers'
 if location_xml_id:
-location_model, location_id = mod_obj.get_object_reference(cr, uid, 'stock', location_xml_id)
+try:
+location = mod_obj.get_object(cr, uid, 'stock', location_xml_id)
+# can I read?
+__ = location.name
+location_id = location.id
+except (except_orm, ValueError):
+# likely the user does not have read access on the location
+location_id = False
 return location_id
 
 def _default_location_source(self, cr, uid, context=None):
@@ -1680,7 +1688,15 @@
 elif picking_type == 'out':
 location_xml_id = 'stock_location_stock'
 if location_xml_id:
-location_model, location_id = mod_obj.get_object_reference(cr, uid, 'stock', location_xml_id)
+try:
+location = mod_obj.get_object(cr, uid, 'stock', location_xml_id)
+# can I read?
+__ = location.name
+location_id = location.id
+except (except_orm, ValueError):
+# likely the user does not have read access on the location
+location_id = False
+
 return location_id
 
 _defaults = {

=== modified file 'stock/stock_demo.xml'
--- stock/stock_demo.xml	2011-12-21 11:38:22 +
+++ stock/stock_demo.xml	2014-04-03 09:02:09 +
@@ -264,5 +264,14 @@
 
  
 
+
+  multicomp
+  multicomp
+  multicomp
+  
+  
+  
+
+
 
 

=== added file 'stock/test/multicompany.yml'
--- stock/test/multicompany.yml	1970-01-01 00:00:00 +
+++ stock/test/multicompany.yml	2014-04-03 09:02:09 +
@@ -0,0 +1,50 @@
+-
+  Set the current user as multicompany user
+-
+  !context
+uid: 'stock.multicompany_user'
+
+-
+  check no error on getting default stock.move values in multicompany setting
+-
+  !python {model: stock.move}: |
+location_obj = self.pool.get('stock.location')
+fields = ['location_id', 'location_dest_id']
+for picking_type in ('in', 'internal', 'out'):
+context['picking_type'] = picking_type
+defaults = self.default_get(cr, uid, ['location_id', 'location_dest_id'], context)
+log('type: %s got defaults: %s', picking_type, defaults)
+for field in fields:
+if defaults.get(field):
+try:
+location_obj.check_access_rule(cr, uid, [defaults[field]], 'read', context)
+except Exception, exc:
+assert False, "unreadable location %s: %s" % (field, exc)
+-
+  check default location readability for stock_fill_inventory in multicompany setting
+-
+  !python {model: stock.fill.inventory}: |
+location_obj = self.pool.get('stock.location')
+defaults = self.default_get(cr, uid, ['location_id'], context)
+log('got defaults: %s', defaults)
+if defaults.get('location_id'):
+try:
+location_obj.check_access_rule(cr, uid, [defaults['location_id']], 'read', context)
+except Exception, exc:
+assert False, "unreadable source location: %s" % exc
+
+-
+  check default locations for warehouse in multicompany setting
+-
+  !python {model: stock.warehouse}: |
+location_obj = self.pool.get('stock.location')
+fields = ['lot_input_id

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde into lp:carriers-deliveries/6.1

2014-04-03 Thread Leonardo Pistone - camptocamp 
Review: Approve code review

thanks!
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde/+merge/213883
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp