Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries
Review: Approve code review A frequent problem if you put a common python class name... Thanks for the patch. Regards. -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_line_watcher into lp:sale-financial
Review: Needs Fixing code review Hi, Yannick, several things: - Instead of replacing a field, it's better to put position="attributes" and only overwrite attribute on_change, so that you don't replace another attributes of the field. - I think it's better to use module web_context_tunnel to avoid changes on the signature of the method that provokes incompatibilities between modules. Regards. -- https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_line_watcher/+merge/214058 Your team Sale Core Editors is subscribed to branch lp:sale-financial. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_floor_price into lp:sale-financial
Review: Needs Fixing See comments on the other MP that can affect this one. Please also mark this MP as dependent of the other. I set it as Needs fixing to take this into account. Thanks. Regards. -- https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_floor_price/+merge/214059 Your team Sale Core Editors is subscribed to branch lp:sale-financial. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-product_price_history-index-1301847 into lp:margin-analysis
Review: Needs Information code review Can't this be done with select=1 attribute? Regards. -- https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_price_history-index-1301847/+merge/214001 Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-product_price_history-index-1301847 into lp:margin-analysis
Review: Approve code review Ah, OK, the intention is to compose a full index of the four fields. I get it. Regards. -- https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_price_history-index-1301847/+merge/214001 Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7 into lp:account-invoicing
Review: Needs Fixing code review Hi, Alex, thank you very much for the contribution. Some remarks: - l.137: Please close string before \ to avoid that spaces on translations (you will have to export again translations): help="International Commercial Terms are a series of predefined " \ "commercial terms used in international transactions." - l.135,382,392: Is it necessary to put such a complicated xpath? This makes more difficult to migrate code to future versions. If there is only one 'date_due' field, you can put directly . If there is more than one, at least you can put relative xpath to make it more portable: http://legacy.python.org/dev/peps/pep-0008/#indentation). This is my suggestion: def _prepare_invoice_group( self, cr, uid, picking, partner, invoice, context=None): invoice_vals = ... - Don't you think that it's convenient to copy incoterm (if any) from sale order to picking? Very good detail including a test. Regards. -- https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~dreis-pt/project-service/7.0-project_issue_reassign-dr into lp:project-service
The proposal to merge lp:~dreis-pt/project-service/7.0-project_issue_reassign-dr into lp:project-service has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~dreis-pt/project-service/7.0-project_issue_reassign-dr/+merge/195275 -- https://code.launchpad.net/~dreis-pt/project-service/7.0-project_issue_reassign-dr/+merge/195275 Your team Project Core Editors is requested to review the proposed merge of lp:~dreis-pt/project-service/7.0-project_issue_reassign-dr into lp:project-service. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr into lp:web-addons
Review: Approve code review and test Hi, Guewen, thanks for the catch. I have tested your bug conditions and now it works as intended. Do you think it's possible to make a test for this condition to avoid future regressions? Another ask I made from my JS ignorance. Do you think it's possible to change module behaviour to only load translate dialog for the field you have clicked? This way, all is going to be more intuitive (the initial intention of OpenERP SA when they change the behaviour), and avoid scrolling problems detected on first MP when you have a lot of translatable fields on the current model. Regards. -- https://code.launchpad.net/~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr/+merge/213783 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_line_watcher into lp:sale-financial
Review: Needs Information Hi, Yannick, thanks for the changes. Do you it's worth while to keep this module instead of dropping it and implementing corresponding on_change when needed on dependant modules? One of the advantages of web_context_tunnel is that the context dictionary passed on each on_change is aggregated to previous ones, so there will not be possible incompatibilities (except a reuse of a key name with different meaning). Regards. -- https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_line_watcher/+merge/214058 Your team Sale Core Editors is subscribed to branch lp:sale-financial. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-tests-backport into lp:ocb-addons
I think it's better to mark this as Rejected, because this MP is not actually merged. It's not the same policy as with bugs, that you put Fix released in both cases. Regards. -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-tests-backport/+merge/214234 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-revert-sale-properties-1291903-ls into lp:ocb-addons
Review: Approve code review Thanks for the work you are doing, Lionel. Regards. -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-revert-sale-properties-1291903-ls/+merge/214435 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1294887] Re: [6.1/7.0/trunk] Translation exported is not complete
** Changed in: ocb-server Status: New => Invalid -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Server). https://bugs.launchpad.net/bugs/1294887 Title: [6.1/7.0/trunk] Translation exported is not complete Status in OpenERP Community Backports (Server): Invalid Status in OpenERP Server: Invalid Bug description: This has been detected from bug lp:933496, where a missing translation has triggered an investigation about that. In purchase module, you have this menu definition: Exporting pot file, I get: #. module: purchase #: model:ir.actions.act_window,name:purchase.action_purchase_line_product_tree #: model:ir.actions.act_window,name:purchase.open_board_purchase #: model:ir.ui.menu,name:purchase.menu_board_purchase #: model:ir.ui.menu,name:purchase.menu_purchase_config #: view:res.partner:0 msgid "Purchases" msgstr "" But it must be another one comment that is missing: #: model:ir.ui.menu,name:base.menu_purchase_root Maybe the problem is because XML ID module is 'base' instead 'purchase', but if I export 'base' module, this comment isn't exported also. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-server/+bug/1294887/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1303918] [NEW] [6.1/7.0/trunk] Menu translations doesn't work after module installation because they have ID referenced as "base.xxx"
Public bug reported: As seen on bug #1294887, some menus doesn't appear translated because their definitions on XML have an ID with reference to the base module, so that translation export tool include them on base translation file, not on each module. In this serie of consequences, only loading base module loads these translations, but on the base loading, translations are not loaded because the elements don't exist. The only way to handle this is to install module (for example purchase), and then update base module again. An easy solution to this is to rename these IDs to another ones, and it's very interesting that this lands on trunk before the v8 debuts, because this change is not easy to be done on an stable branch. This is the complete list of menus with this problem that I have detected: account: · base.menu_action_currency_form association: · base.menu_association · base.menu_event_config · base.menu_report_association base_action_rule: · base.menu_base_action_rule_admin base_calendar: · base.menu_calendar_configuration crm: · base.menu_sales · base.menu_import_crm · base.menu_sale_config · base.menu_base_partner · base.menu_crm_config_lead · base.menu_crm_config_opportunity · base.menu_sale_config_sales · base.next_id_64 crm_claim: · base.menu_project_report · base.menu_aftersale crm_helpdesk: · base.menu_project_report · base.menu_base_partner · base.menu_aftersale event: · base.menu_event_main · base.menu_marketing_config_root · base.menu_report_association hr: · base.menu_crm_case_job_req_main hr_recruitment: · base.menu_crm_case_job_req_main idea: · base.menu_tools · base.menu_lunch_survey_root marketing: · base.marketing_menu marketing_campaign: · base.menu_report_marketing membership: · base.menu_association · base.menu_marketing_config_association · base.menu_report_association mrp: · base.menu_mrp_root · base.menu_mrp_config multicompany: · base.menu_action_inventory_form plugin_outlook: · base.menu_base_config_plugins plugin_thunderbird: · base.menu_base_config_plugins product: · base.menu_sale_config_sales · base.menu_product product_margin: · base.next_id_73 project: · base.menu_main_pm · base.menu_definitions · base.menu_project_config_project · base.menu_project_report · base.menu_definitions · base.menu_project_config project_long_term: · "base.menu_project_long_term purchase: · base.menu_purchase_root · base.menu_procurement_management_supplier_name · base.next_id_73 sale: · base.menu_base_partner · base.menu_product · base.menu_invoiced · base.next_id_64 · base.menu_base_partner · base.menu_base_config · base.menu_sale_config subscription: · base.menu_tools · base.menu_lunch_survey_root survey: · base.menu_tools · base.menu_lunch_reporting · base.next_id_10 I know that there are some modules that redefine menus because you wanted in the past reduce the coupling between modules, but these are the only solutions I see: 1. Set again some dependencies. Not desirable. 2. Create glue modules with the shared menus that are installed as dependencies of the others. Not the best, but it works. 3. Put that menus definitions on base, and add an active field on menus that allows to hide some menus. On modules that need this menu, you would define the menu again with active flag set to True, and translations will be already correct. 4. A variation of the last one, as all these cases are shared root menus, is that on web client, if there is a root menu that doesn't have any children, you can hide it. Less elegant. 5. At last, develop a method, as commented on the other bug report, to handle translation with foreign modules IDs. The costliest (on development and processing time), but the best to avoid any problem. Let me know if you want me to help you on the MP. Regards. ** Affects: ocb-server Importance: Undecided Status: New ** Summary changed: - [6.1/7.0/trunk] Menu translations doesn't work after installation module installation because they have ID referenced as "base.xxx" + [6.1/7.0/trunk] Menu translations doesn't work after module installation because they have ID referenced as "base.xxx" -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Server). https://bugs.launchpad.net/bugs/1303918 Title: [6.1/7.0/trunk] Menu translations doesn't work after module installation because they have ID referenced as "base.xxx" Status in OpenERP Community Backports (Server): New Bug description: As seen on bug #1294887, some menus doesn't appear translated because their definitions on XML have an ID with reference to the base module, so that translation export tool include them on base translation file, not on each module. In this serie of consequences, only loading base module loads these translations, but on the base loading, translations are not loaded because the elements don't exist. The only way to handle this is to
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr into lp:margin-analysis
Review: Approve code review OK, thanks for the investigation. Regards. -- https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr/+merge/211354 Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-web/7.0-opw-605931-msh into lp:ocb-web
Review: Approve code review LGTM. Regards. -- https://code.launchpad.net/~numerigraphe-team/ocb-web/7.0-opw-605931-msh/+merge/214482 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7 into lp:account-invoicing
Review: Needs Fixing code review Hi, Alex, Thank you for the changes you have made, and the explanation about the sale to invoice procedure. One more thing before the approval: please check again multi-line texts. They are still bad constructed and split wiht a lot of spaces on translations. If you see my example, you can see that I have put " terminating each line. This is the thing that prevents to copy spaces in the string. I have put one space though to keep separation between words. Regards. -- https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_line_watcher into lp:sale-financial
Why don't you check super method existence?: parent = super(children, self) if hasattr(parent, 'method') and callable(getattr(parent, 'method')): parent.method(cr, uid, ... This seems a little tricky, but it removes the needed of the glue module. What do you think? Regards. -- https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_line_watcher/+merge/214058 Your team Sale Core Editors is subscribed to branch lp:sale-financial. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt
Hi, Jordi, thanks for the changes. There are still self.pool.get() references that you can replace by self.pool[], but this is not a blocking issue. What about my last question about the conveniency of the current flow? Regards. -- https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055/+merge/212286 Your team Department Core Editors is subscribed to branch lp:department-mgmt. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7 into lp:account-invoicing
Review: Approve code review Thanks again. Regards. -- https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix into lp:account-financial-tools
Pedro Manuel Baeza has proposed merging lp:~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix into lp:account-financial-tools. Commit message: [IMP] account_renumber: Spaces instead tabs on XML. [FIX] account_renumber: Group restriction for the menu removed. Requested reviews: Account Core Editors (account-core-editors) For more details, see: https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832 [IMP] account_renumber: Spaces instead tabs on XML. [FIX] account_renumber: Group restriction for the menu removed. This restriction to "Configuration" users doesn't make sense, because one accountant can renumber journal entries without belonging to this group. -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832 Your team Account Core Editors is requested to review the proposed merge of lp:~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix into lp:account-financial-tools. === modified file 'account_renumber/wizard/wizard_renumber_view.xml' --- account_renumber/wizard/wizard_renumber_view.xml 2013-09-28 15:40:31 + +++ account_renumber/wizard/wizard_renumber_view.xml 2014-04-08 20:06:45 + @@ -1,48 +1,51 @@ - - - - account_renumber.form - wizard.renumber - - - - This wizard will help you renumber entries in one or more journals. - Posted moves from those journals will be sorted by date and then assigned - sequential numbers using their journal sequence. - - - - - - - - - - - - - - - - o - - - - - - - - Renumber journal entries - wizard.renumber - form - form - - new - - - - + + + +account_renumber.form +wizard.renumber + + + +This wizard will help you renumber entries in one or more journals. +Posted moves from those journals will be sorted by date and then assigned +sequential numbers using their journal sequence. + + + + + + + + + + + + + + + + +o + + + + + + + +Renumber journal entries +wizard.renumber +form +form + +new + + + + -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_line_watcher into lp:sale-financial
Review: Abstain I think on contrary, but let others give their opinion. Regards. -- https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_line_watcher/+merge/214058 Your team Sale Core Editors is subscribed to branch lp:sale-financial. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~onnis-roberto/web-addons/web-addons into lp:web-addons
Review: Approve code review Hi, Roberto, Thanks for bringing the 6.1 patch to 7.0: https://code.launchpad.net/~onnis-roberto/web-addons/6.1/+merge/207662 Regards. -- https://code.launchpad.net/~onnis-roberto/web-addons/web-addons/+merge/214906 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7 into lp:account-invoicing
Thanks for the info, Alex, Also FYI, if you feel that any other change needs a revision, you can click on "Resubmit proposal" to reset reviews. Regards. -- https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~grupoesoc/server-env-tools/7.0-fix-1302547 into lp:server-env-tools
Review: Approve code review LGTM. Thanks. -- https://code.launchpad.net/~grupoesoc/server-env-tools/7.0-fix-1302547/+merge/214890 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/7.0-fix_1305653-afe into lp:ocb-server
Review: Approve code review LGTM. Regards. -- https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1305653-afe/+merge/215121 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/ocb-web/7.0-web_calendar-fix-1306136 into lp:ocb-web
Pedro Manuel Baeza has proposed merging
lp:~pedro.baeza/ocb-web/7.0-web_calendar-fix-1306136 into lp:ocb-web.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1306136 in OpenERP Community Backports (Web): "[7.0] web_calendar: Error
while removing a task from calendar view on week or day layout"
https://bugs.launchpad.net/ocb-web/+bug/1306136
For more details, see:
https://code.launchpad.net/~pedro.baeza/ocb-web/7.0-web_calendar-fix-1306136/+merge/215256
[FIX] web_calendar: Error when deleting an element from calendar view.
It solves lp:1306136. See bug report for details.
--
https://code.launchpad.net/~pedro.baeza/ocb-web/7.0-web_calendar-fix-1306136/+merge/215256
Your team OpenERP Community Backports Team is requested to review the proposed
merge of lp:~pedro.baeza/ocb-web/7.0-web_calendar-fix-1306136 into lp:ocb-web.
=== modified file 'addons/web_calendar/static/src/js/calendar.js'
--- addons/web_calendar/static/src/js/calendar.js 2014-02-14 11:42:58 +
+++ addons/web_calendar/static/src/js/calendar.js 2014-04-10 17:03:19 +
@@ -533,7 +533,7 @@
var self = this;
var index = this.dataset.get_id_index(event_id);
if (index !== null) {
-this.dataset.unlink(this.dataset.ids[index]);
+this.dataset.unlink([this.dataset.ids[index]]);
}
},
});
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1306136] [NEW] [7.0] web_calendar: Error while removing a task from calendar view on week or day layout
Public bug reported: If you try to remove an element from the calendar view on day or week layout (the trash icon that appears when you click on an element), it appears some errors. For example, this one comes from deleting a task in this view: NotImplementedError: Iteration is not allowed on browse_record(project.task, x) This is because the parameter ids passed to unlink method is a single id, not a list of ids. This becomes from web_calendar addon itself, and it's general for any calendar view (sale orders, manufacturing orders, etc). It's easily repaired changing 'delete_event' to pass a list of one ID instead the ID itself. Please see attached branch. ** Affects: ocb-web Importance: Undecided Status: New ** Affects: ocb-web/7.0 Importance: Undecided Status: New ** Affects: openerp-web Importance: Undecided Status: New ** Also affects: ocb-web Importance: Undecided Status: New ** Also affects: ocb-web/7.0 Importance: Undecided Status: New ** Branch linked: lp:~pedro.baeza/ocb-web/7.0-web_calendar-fix-1306136 ** Branch linked: lp:~pedro.baeza/openerp-web/7.0-web_calendar- fix-1306136 -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Web). https://bugs.launchpad.net/bugs/1306136 Title: [7.0] web_calendar: Error while removing a task from calendar view on week or day layout Status in OpenERP Community Backports (Web): New Status in OpenERP Community Backports (Web) 7.0 series: New Status in OpenERP Web: New Bug description: If you try to remove an element from the calendar view on day or week layout (the trash icon that appears when you click on an element), it appears some errors. For example, this one comes from deleting a task in this view: NotImplementedError: Iteration is not allowed on browse_record(project.task, x) This is because the parameter ids passed to unlink method is a single id, not a list of ids. This becomes from web_calendar addon itself, and it's general for any calendar view (sale orders, manufacturing orders, etc). It's easily repaired changing 'delete_event' to pass a list of one ID instead the ID itself. Please see attached branch. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-web/+bug/1306136/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/ocb-7.0-fix_1204920-afe into lp:ocb-server
Review: Approve code review Thanks for the changes. Regards. -- https://code.launchpad.net/~camptocamp/ocb-server/ocb-7.0-fix_1204920-afe/+merge/208390 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix_1281290-afe into lp:ocb-addons
Review: Approve code review -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix_1281290-afe/+merge/215614 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/7.0-fix_1281290-afe into lp:ocb-server
Review: Approve code review -- https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1281290-afe/+merge/215612 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix into lp:account-financial-tools
The proposal to merge lp:~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix into lp:account-financial-tools has been updated. Commit Message changed to: [IMP] account_renumber: Spaces instead tabs on XML. [IMP] account_renumber: PEP8 [IMP] account_renumber: Restrict to account managers. [FIX] account_renumber: Fix translations. For more details, see: https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832 -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix into lp:account-financial-tools
The proposal to merge lp:~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix into lp:account-financial-tools has been updated. Description changed to: Group restriction changed to account managers. Restriction to "Configuration" users doesn't make sense, because an accountant can renumber journal entries without belonging to this group. Code changed accordingly to allow this operation. I have already rename some variables to follow conventions, PEP8 and re-export translation with some changes of translation strings themselves. For more details, see: https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832 -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix into lp:account-financial-tools
Hi, Stefan, I have restricted the menu to account managers, and change code to write new sequence number as admin. That's the original reason why account renumber was restricted to configuration users. I have taken also all the code and refactorise to PEP8, community conventions and so on. I hope diff is not too large. Regards. -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/sale-wkfl/sale-wkfl-sale-multi-journal into lp:sale-wkfl
Review: Needs Information Don't you think a more suitable name is sale_journal_shop? Regards. -- https://code.launchpad.net/~akretion-team/sale-wkfl/sale-wkfl-sale-multi-journal/+merge/215440 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/fix-1308364-nbi into lp:ocb-addons
Review: Approve code review LGTM Regards. -- https://code.launchpad.net/~camptocamp/ocb-addons/fix-1308364-nbi/+merge/216023 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-product_get_cost_field-standard_price-1308584 into lp:margin-analysis
Review: Approve code review LGTM. I avoid always I can to make a "replace" operation, making invisible the field instead. Regards. -- https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_get_cost_field-standard_price-1308584/+merge/216124 Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/web-addons/web_easy_switch_company-userform-fix-sbi into lp:web-addons
Review: Approve code review Thanks for the fix! Regards. -- https://code.launchpad.net/~acsone-openerp/web-addons/web_easy_switch_company-userform-fix-sbi/+merge/216170 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/report-print-send/7.0-default-bool-required-lp1308614-ls into lp:report-print-send
Review: Approve code review LGTM. It doesn't make sense to mark a boolean as required. Regards. -- https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-default-bool-required-lp1308614-ls/+merge/216354 Your team Report Printing and Sending Core Editors is subscribed to branch lp:report-print-send. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/report-print-send/7.0-user-browse-lp1116672-ls into lp:report-print-send
Review: Needs Fixing code review Hi, Lionel, you can use this better form: user = self.pool['res.users]).browse(cr, uid, uid, context=context) Regards. -- https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-user-browse-lp1116672-ls/+merge/216356 Your team Report Printing and Sending Core Editors is subscribed to branch lp:report-print-send. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/report-print-send/7.0-user-browse-lp1116672-ls into lp:report-print-send
What is exactly been deprecated? - About self.pool[], here it's a good explanation why it's better: http://hypered.io/blog/2013-12-30-self-pool-get/ - About (cr, uid, uid... instead of (cr, uid, [uid], the explanation is simple: ORM methods allow lists or single ids, and in this case, you save to access to 0 index of the returned one-element list. Regards. -- https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-user-browse-lp1116672-ls/+merge/216356 Your team Report Printing and Sending Core Editors is subscribed to branch lp:report-print-send. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/report-print-send/7.0-user-browse-lp1116672-ls into lp:report-print-send
Review: Approve code review Uhm, I'm not aware about that deprecation, but it can be. I always avoid single ID on read, write, and so on overrides, but I see no problem with browse method. Do you know anyone that overrides this method? In summary, I have no hard feeling about any form, so please let it as you want. I find this discussion very instructive :) Regards. -- https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-user-browse-lp1116672-ls/+merge/216356 Your team Report Printing and Sending Core Editors is subscribed to branch lp:report-print-send. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-server/6.1-lp933496 into lp:ocb-server/6.1
I proceed with the merge making the change that Lionel has proposed (change to orm.TransientModel). In the unlikely case that OpenERP merge the patch in the upstream, we will have a conflict, but it's very easy to resolve. Regards. -- https://code.launchpad.net/~therp-nl/ocb-server/6.1-lp933496/+merge/193011 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-server/7.0-po-targets-933496-vmt into lp:ocb-server
I proceed with the merge because Holger's comment, refered to me, has been answered. Regards. -- https://code.launchpad.net/~numerigraphe-team/ocb-server/7.0-po-targets-933496-vmt/+merge/209895 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 933496] Re: Mismatching PO comments cause translation issues: translations present in PO not visible in GUI
** Changed in: ocb-server/6.1 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is a bug assignee. https://bugs.launchpad.net/bugs/933496 Title: Mismatching PO comments cause translation issues: translations present in PO not visible in GUI Status in OpenERP Community Backports (Server): Fix Committed Status in OpenERP Community Backports (Server) 6.1 series: Fix Released Status in OpenERP Community Backports (Server) 7.0 series: Fix Committed Status in OpenERP Server: Fix Committed Bug description: In v6.0, it seems that many translations are not show in the gui anymore because the corresponding comments has been removed from the .po file. As stated by Olivier: "The problem is that PO templates entries are not only shared between series, but their comments are shared as well, regardless of the destination series." So Launchpad removes the comments needed for v6.0 when they disappear from the trunk. For example, revno 4983 contains: @@ -10132,14 +10038,13 @@ #: report:account.invoice:0 #: view:account.invoice:0 #: view:account.invoice.refund:0 -#: selection:account.invoice.refund,filter_refund:0 #: view:account.invoice.report:0 #: model:ir.actions.act_window,name:account.action_account_invoice_refund msgid "Refund" msgstr "Créer un avoir" That makes the string "Refund" untranslatable in the selection on the refund wizard. If you export the PO file from a running instance of OpenERP, it will be generated correctly however. Lionel. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-server/+bug/933496/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-analytic/account_analytic_required-test_suite-sbi into lp:account-analytic
Review: Approve code review Thanks for the work, Stéphane. Regards. -- https://code.launchpad.net/~acsone-openerp/account-analytic/account_analytic_required-test_suite-sbi/+merge/216451 Your team Account Core Editors is subscribed to branch lp:account-analytic. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 933496] Re: Mismatching PO comments cause translation issues: translations present in PO not visible in GUI
** Changed in: ocb-server/7.0 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is a bug assignee. https://bugs.launchpad.net/bugs/933496 Title: Mismatching PO comments cause translation issues: translations present in PO not visible in GUI Status in OpenERP Community Backports (Server): Fix Released Status in OpenERP Community Backports (Server) 6.1 series: Fix Released Status in OpenERP Community Backports (Server) 7.0 series: Fix Released Status in OpenERP Server: Fix Committed Bug description: In v6.0, it seems that many translations are not show in the gui anymore because the corresponding comments has been removed from the .po file. As stated by Olivier: "The problem is that PO templates entries are not only shared between series, but their comments are shared as well, regardless of the destination series." So Launchpad removes the comments needed for v6.0 when they disappear from the trunk. For example, revno 4983 contains: @@ -10132,14 +10038,13 @@ #: report:account.invoice:0 #: view:account.invoice:0 #: view:account.invoice.refund:0 -#: selection:account.invoice.refund,filter_refund:0 #: view:account.invoice.report:0 #: model:ir.actions.act_window,name:account.action_account_invoice_refund msgid "Refund" msgstr "Créer un avoir" That makes the string "Refund" untranslatable in the selection on the refund wizard. If you export the PO file from a running instance of OpenERP, it will be generated correctly however. Lionel. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-server/+bug/933496/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic
I proceed with the merge, because Omar needs fixing comment is already repaired. Regards. -- https://code.launchpad.net/~initos.com/account-analytic/7.0/+merge/195362 Your team Account Core Editors is subscribed to branch lp:account-analytic. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-analytic/7.0-hr_expense_analytic_plans into lp:account-analytic
Pedro Manuel Baeza has proposed merging
lp:~pedro.baeza/account-analytic/7.0-hr_expense_analytic_plans into
lp:account-analytic.
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
https://code.launchpad.net/~pedro.baeza/account-analytic/7.0-hr_expense_analytic_plans/+merge/216469
[ADD] hr_expense_analytic_plans: With this module, you will be able to link
analytic distributions to expenses.
--
https://code.launchpad.net/~pedro.baeza/account-analytic/7.0-hr_expense_analytic_plans/+merge/216469
Your team Account Core Editors is requested to review the proposed merge of
lp:~pedro.baeza/account-analytic/7.0-hr_expense_analytic_plans into
lp:account-analytic.
=== added directory 'hr_expense_analytic_plans'
=== added file 'hr_expense_analytic_plans/__init__.py'
--- hr_expense_analytic_plans/__init__.py 1970-01-01 00:00:00 +
+++ hr_expense_analytic_plans/__init__.py 2014-04-18 16:50:31 +
@@ -0,0 +1,21 @@
+# -*- coding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see <http://www.gnu.org/licenses/>.
+#
+##
+
+from . import model
=== added file 'hr_expense_analytic_plans/__openerp__.py'
--- hr_expense_analytic_plans/__openerp__.py 1970-01-01 00:00:00 +
+++ hr_expense_analytic_plans/__openerp__.py 2014-04-18 16:50:31 +
@@ -0,0 +1,43 @@
+# -*- coding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#Copyright (c) 2014 Serv. Tecnol. Avanzados (http://www.serviciosbaeza.com)
+# Pedro Manuel Baeza
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see <http://www.gnu.org/licenses/>.
+#
+##
+
+{
+'name': 'HR expenses analytic distribution',
+'version': '1.0',
+'category': 'Human Resources',
+'description': """
+The base module to manage analytic distribution on HR expenses
+==
+
+Using this module, you will be able to link analytic distributions to expenses.
+""",
+'author': 'Serv. Tecnolog. Avanzados - Pedro M. Baeza',
+'website' : 'http://www.serviciosbaeza.com',
+'depends': [
+'hr_expense',
+'account_analytic_plans',
+],
+'data': [
+'view/hr_expense_analytic_plans_view.xml'
+],
+'installable': True,
+}
=== added directory 'hr_expense_analytic_plans/i18n'
=== added file 'hr_expense_analytic_plans/i18n/es.po'
--- hr_expense_analytic_plans/i18n/es.po 1970-01-01 00:00:00 +
+++ hr_expense_analytic_plans/i18n/es.po 2014-04-18 16:50:31 +
@@ -0,0 +1,36 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+# * hr_expense_analytic_plans
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2014-04-04 18:17+\n"
+"PO-Revision-Date: 2014-04-04 20:18+0100\n"
+"Last-Translator: Pedro Manuel Baeza \n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n&q
Re: [Openerp-community-reviewer] [Merge] lp:~invitu/account-financial-report/8.0-account_financial_report_webkit into lp:account-financial-report
Review: Needs Information Hi, thanks for the MP. Changes done are still compatible with v7? Regards. -- https://code.launchpad.net/~invitu/account-financial-report/8.0-account_financial_report_webkit/+merge/216529 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh into lp:ocb-web
Review: Approve code review LGTM. Regards. -- https://code.launchpad.net/~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh/+merge/216664 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe into lp:ocb-addons
Review: Approve code review LGTM. Regards. -- https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe/+merge/216686 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1254631] Re: No bank account on invoice when invoicing a contact
** Branch linked: lp:~pedro.baeza/ocb-addons/fix-lp_1254631 ** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/7.0 Importance: Undecided Status: New ** Changed in: ocb-addons/7.0 Status: New => Fix Committed ** Changed in: openobject-addons Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1254631 Title: No bank account on invoice when invoicing a contact Status in OpenERP Community Backports (Addons): Fix Committed Status in OpenERP Community Backports (Addons) 7.0 series: Fix Committed Status in OpenERP Addons (modules): Fix Committed Bug description: Steps to reproduce: 1 Create a partner with a bank account. Create a contact on that partner. Note that you cannot add a bank account to the contact directly, because the bank accounts are supposed to be configured on the commercial/parent partner. 2 Create an invoice for the contact Expected results: == When selecting the contact, I expect the parent partner's bank account to be filled in on the invoice's 'Other Info' tab. Actual results: The bank account is not added to the invoice. Moreover, when trying to select the bank account manually, the domain on partner_id prevents this. No bank account can be selected even if the contact's commercial partner has a bank account configured. Analysis and proposed solution: = When invoicing a contact, the onchange method considers the bank accounts of the contact, not of the commercial partner. This should be easy to fix in 7.0 in the onchange method. However, this is seems meaningless to me if no choice can be made in the case of multiple accounts anyway, due to the problem with the domain. The bank domain cannot be properly fixed under the stable policy as it depends on having the commercial_partner_id field available in the invoice form. In trunk, applying this field in the domain should fix the problem. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1254631/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/ocb-addons/fix-lp_1254631 into lp:ocb-addons
Pedro Manuel Baeza has proposed merging
lp:~pedro.baeza/ocb-addons/fix-lp_1254631 into lp:ocb-addons.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1254631 in OpenERP Community Backports (Addons): "No bank account on
invoice when invoicing a contact"
https://bugs.launchpad.net/ocb-addons/+bug/1254631
For more details, see:
https://code.launchpad.net/~pedro.baeza/ocb-addons/fix-lp_1254631/+merge/216728
Fix for the bug #1254631. Details on the bug report.
--
https://code.launchpad.net/~pedro.baeza/ocb-addons/fix-lp_1254631/+merge/216728
Your team OpenERP Community Backports Team is requested to review the proposed
merge of lp:~pedro.baeza/ocb-addons/fix-lp_1254631 into lp:ocb-addons.
=== modified file 'account/account_invoice.py'
--- account/account_invoice.py 2014-03-24 09:12:54 +
+++ account/account_invoice.py 2014-04-22 13:40:24 +
@@ -519,8 +519,8 @@
acc_id = p.property_account_payable.id
partner_payment_term = p.property_supplier_payment_term and p.property_supplier_payment_term.id or False
fiscal_position = p.property_account_position and p.property_account_position.id or False
-if p.bank_ids:
-bank_id = p.bank_ids[0].id
+if p.commercial_partner_id.bank_ids:
+bank_id = p.commercial_partner_id.bank_ids[0].id
result = {'value': {
'account_id': acc_id,
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl
Review: Needs Information Hi, Leonardo, very good workaround, but I think it deserves to propose this change to 7.0/trunk official branches instead of a module, so that we don't have to update module with each change/fix made in the replaced part. It doesn't imply changes in DB layout, so it can be merged in stable 7.0, but at least if we get this on trunk, it's a good win. Regards. -- https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~vauxoo/web-addons/7.0-web_hideleftmenu into lp:web-addons
Review: Needs Fixing code review Hi, Oscar, thanks for the MP. Could you please clean MP with only the module web_hideleftmenu? Regards. -- https://code.launchpad.net/~vauxoo/web-addons/7.0-web_hideleftmenu/+merge/216796 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~vauxoo/web-addons/7.0-web_hideleftmenu into lp:web-addons
Well, although the MP is wrong, I see the module very interesting, so why don't you propose here? Regards. -- https://code.launchpad.net/~vauxoo/web-addons/7.0-web_hideleftmenu/+merge/216796 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe into lp:ocb-addons/6.1
Review: Approve code review LGTM -- https://code.launchpad.net/~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe/+merge/216820 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/rma-fix-lp1311509_rde into lp:openerp-rma
Review: Approve code review LGTM Regards. -- https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311509_rde/+merge/216824 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain into lp:ocb-addons
Review: Approve code review LGTM Thanks. -- https://code.launchpad.net/~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain/+merge/216872 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain into lp:ocb-addons
Review: Approve code review LGTM. Regards. -- https://code.launchpad.net/~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain/+merge/216877 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl
Pedro Manuel Baeza has proposed merging
lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl.
Requested reviews:
Purchase Core Editors (purchase-core-editors)
For more details, see:
https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030
[ADD] purchase_discount: Module that I ported some time ago to v7 and included
in vauxoo-addons. I think this module deserves to be in OCA repositories to
have a "standard" way for this common need.
--
https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030
Your team Purchase Core Editors is requested to review the proposed merge of
lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl.
=== added directory 'purchase_discount'
=== added file 'purchase_discount/__init__.py'
--- purchase_discount/__init__.py 1970-01-01 00:00:00 +
+++ purchase_discount/__init__.py 2014-04-24 11:42:17 +
@@ -0,0 +1,22 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#Copyright (C) 2004-2009 Tiny SPRL (<http://tiny.be>).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see <http://www.gnu.org/licenses/>.
+#
+##
+from . import purchase_discount
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added file 'purchase_discount/__openerp__.py'
--- purchase_discount/__openerp__.py 1970-01-01 00:00:00 +
+++ purchase_discount/__openerp__.py 2014-04-24 11:42:17 +
@@ -0,0 +1,45 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#Copyright (C) 2004-2009 Tiny SPRL (<http://tiny.be>).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see <http://www.gnu.org/licenses/>.
+#
+##
+{
+"name": "Purchase order lines with discounts",
+"author": "Tiny, Acysos S.L.",
+"description": """
+It allows to define a discount per line in the purchase orders. This
+discount can be also negative, interpreting it as an increment.
+""",
+"version": "1.0",
+"contributors": [
+'Pedro M. Baeza',
+],
+"category": "Generic Modules/Sales & Purchases",
+"depends": [
+"stock",
+"purchase",
+],
+"demo": [],
+"data": [
+"purchase_discount_view.xml",
+"report/purchase_discount_report.xml",
+],
+"active": False,
+"installable": True
+}
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added directory 'purchase_discount/i18n'
=== added file 'purchase_discount/i18n/es.po'
--- purchase_discount/i18n/es.po 1970-01-01 00:00:00 +
+++ purchase_discount/i18n/es.po 2014-04-24 11:42:17 +
@@ -0,0 +1,43 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+# * purchase_discount
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 5.0.11\n"
+"Report-Msgid-Bugs-To: supp...@openerp.com\n"
+"POT-Creation-Date: 2013-11-07 01:07+\n"
+"PO-Revision-Date: 2013-11-08 17:57+\n"
+"Last-Translator: hbto [Vauxoo] http://www.vauxoo.com "
+"\n"
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls into lp:account-financial-report
Review: Approve code review LGTM. Regards. -- https://code.launchpad.net/~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls/+merge/217063 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/department-mgmt/add-dep-on-project-task-jge into lp:department-mgmt
Review: Needs Fixing code review Hi, Joël, The MP you have done seems good, but I see a little problem: this modification can give the user a false impression that the department is selected by task, and when they try to change it, they get frustrated, because it's readonly. I advice to change field label to 'Project department' to avoid this confussion. Regards. -- https://code.launchpad.net/~camptocamp/department-mgmt/add-dep-on-project-task-jge/+merge/217068 Your team Department Core Editors is subscribed to branch lp:department-mgmt. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls into lp:account-financial-report/6.1
Review: Approve code review Also OK. Thanks. -- https://code.launchpad.net/~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls/+merge/217070 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl
Review: Needs Fixing code review Hi, Alex, some remarks: - Contributors are put on 'contributors' key in manifest file as a list, not in description. - I prefer to add purchase as dependency that changes the place where the menu is displayed, because this query is not useful if you don't use purchase module. Regards. -- https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/ocb-web/7.0-web_calendar-fix-1306136 into lp:ocb-web
Hi, Holger, there are a lot of write, unlink and so on overrides that doesn't comply with ids argument as integer/long, so I prefer to fix this in this way that add the check on a lot of places. This discussion also happens in another place with Lionel for the browse method and he told me that v8 is going to deprecate all single ID calls. Regards. -- https://code.launchpad.net/~pedro.baeza/ocb-web/7.0-web_calendar-fix-1306136/+merge/215256 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~factorlibre/carriers-deliveries/carriers-deliveries-es-translation into lp:carriers-deliveries
Review: Needs Fixing code review Thanks for the contribution. Some remarks: - Please don't put any empty string, like the one with msgid "delivery.carrier.file", because that means "translation to an empty string", not "no translation", and this will be problematic when browsing models. Translate with the same string, or I usually reinterpret this model description. In this example, it could be "Archivo de transportista". - In Spanish, capitalization of middle words that are not personal nouns, cities, authorities and so on are not allowed, so please remove it. Example: "Generar Ficheros Transportista" would be "Generar ficheros transportista". - One personal preference is to not remove prepositions that complete the sentence, but this is optional. In the same example, I would put "Generar ficheros del transportista". - The word "picking" is not translated in all places. Please translate it as "albarán". Regards. -- https://code.launchpad.net/~factorlibre/carriers-deliveries/carriers-deliveries-es-translation/+merge/217395 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr into lp:web-addons
Review: Approve I proceed with the merge because the MP has 2 approvals and it has passed a month. Regards. -- https://code.launchpad.net/~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr/+merge/213783 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr into lp:web-addons
The proposal to merge lp:~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr into lp:web-addons has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr/+merge/213783 -- https://code.launchpad.net/~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr/+merge/213783 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-manufacturing/70-add-mrp-repair-extension into lp:openerp-manufacturing
Review: Needs Fixing code review Hi, Alexis, Please explain on manifest description the modifications that this module makes. Regards. -- https://code.launchpad.net/~akretion-team/openerp-manufacturing/70-add-mrp-repair-extension/+merge/211696 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:openerp-manufacturing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1253701] Re: [trunk/7.0/6.1/6.0] Incorrect multi-company rule for BOMs
** Changed in: ocb-addons/7.0
Status: Fix Committed => Fix Released
** Changed in: ocb-addons/6.1
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1253701
Title:
[trunk/7.0/6.1/6.0] Incorrect multi-company rule for BOMs
Status in OpenERP Community Backports (Addons):
Fix Released
Status in OpenERP Community Backports (Addons) 6.1 series:
Fix Released
Status in OpenERP Community Backports (Addons) 7.0 series:
Fix Released
Status in OpenERP Addons (modules):
Won't Fix
Bug description:
Products multi-company rule is:
['|','|',('company_id.child_ids','child_of',[user.company_id.id]),('company_id','child_of',[user.company_id.id]),('company_id','=',False)]
that allows to assign a product to a parent company and let its
children companies to see this product.
However, multi-company rule for BOMs is:
['|',('company_id','child_of',[user.company_id.id]),('company_id','=',False)]
that only allows down to top permissions, which is incoherent and
doesn't meet real requirements for a lot of companies.
I propose then to change this rule to the same as the one for product.
Thank you.
Regards.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1253701/+subscriptions
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1122155] Re: [7.0][email_template] Rendering of pdfs not readable when using Send Mail actions on SO or Invoice
** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/7.0 Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1122155 Title: [7.0][email_template] Rendering of pdfs not readable when using Send Mail actions on SO or Invoice Status in OpenERP Community Backports (Addons): New Status in OpenERP Community Backports (Addons) 7.0 series: New Status in OpenERP Addons (modules): Fix Committed Bug description: Used SaaS database for testing environnement on Monday 11/02/2013 16.30 GMT+1 (for you to know addons revisions) 1. Need to install email_template, sales, account_accountant 2. Need to head to Settings > Technical > Email > Templates 3. Open both following forms: - Sales Order - Send by Email - Invoice - Send by Email and press the 'Add context action' button on top right of form view 4. Head out to SO or Invoice and in the read-only form view select More > Send Email (Sales Order or Invoice) Be sure that you can access the email test you have sent. Try to open the email's pdf attachement and you will receive a message saying it is corrupted. I did not expect this error and wanted to read my pdf Sale order or Invoice. Also another related issue is that I did the Step 3 (pressing adding contect action button) with user preferences in French and then when switching to English the More action button on Sales Order or Invoice remaining in French (was not translated into English). Thought about eventually reporting this as another issue. Should I? To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1122155/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/ocb-addons/7.0-lp1122155 into lp:ocb-addons
Pedro Manuel Baeza has proposed merging
lp:~pedro.baeza/ocb-addons/7.0-lp1122155 into lp:ocb-addons.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1122155 in OpenERP Community Backports (Addons): "[7.0][email_template]
Rendering of pdfs not readable when using Send Mail actions on SO or Invoice"
https://bugs.launchpad.net/ocb-addons/+bug/1122155
For more details, see:
https://code.launchpad.net/~pedro.baeza/ocb-addons/7.0-lp1122155/+merge/217629
[FIX] email_template: problem of corrupted pdf when sending email from
email-template.
More info on the bug report.
--
https://code.launchpad.net/~pedro.baeza/ocb-addons/7.0-lp1122155/+merge/217629
Your team OpenERP Community Backports Team is requested to review the proposed
merge of lp:~pedro.baeza/ocb-addons/7.0-lp1122155 into lp:ocb-addons.
=== modified file 'email_template/email_template.py'
--- email_template/email_template.py 2014-04-15 16:29:11 +
+++ email_template/email_template.py 2014-04-29 15:04:40 +
@@ -341,7 +341,8 @@
service = netsvc.LocalService(report_service)
(result, format) = service.create(cr, uid, [res_id], {'model': template.model}, ctx)
# TODO in trunk, change return format to binary to match message_post expected format
-result = base64.b64encode(result)
+if not ctx['default_composition_mode'] == 'mass_mail':
+result = base64.b64encode(result)
if not report_name:
report_name = report_service
ext = "." + format
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~hbrunn/lp-community-utils/lp1222720 into lp:lp-community-utils
Review: Approve code review and test Tested on an MP and works as expected (although in MP tested, there was a text conflict that I have to solve manually, but that doesn't interfere with this patch). Regards. -- https://code.launchpad.net/~hbrunn/lp-community-utils/lp1222720/+merge/210982 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt
Hi, Jordi, Yeah, I think it's the best way. Thanks for the efforts. Regards. -- https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055/+merge/212286 Your team Department Core Editors is subscribed to branch lp:department-mgmt. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-fix-agreement-trigger-nbi into lp:purchase-wkfl
Review: Approve code review LGTM. Thanks -- https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-fix-agreement-trigger-nbi/+merge/217746 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoice-report/account-invoice-webkit-line-description-vre into lp:account-invoice-report
Review: Approve code review Very needed change. Thanks. Regards. -- https://code.launchpad.net/~camptocamp/account-invoice-report/account-invoice-webkit-line-description-vre/+merge/217929 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/6.1-lp1315367-task_work_timesheet_lines_False into lp:ocb-addons/6.1
Review: Approve code review LGTM (that parenthesis order...) -- https://code.launchpad.net/~therp-nl/ocb-addons/6.1-lp1315367-task_work_timesheet_lines_False/+merge/218060 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~alhashash/ocb-addons/7.0-alhashash-bug1179705 into lp:ocb-addons
Review: Approve code review LGTM. Thanks. -- https://code.launchpad.net/~alhashash/ocb-addons/7.0-alhashash-bug1179705/+merge/217681 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1179705] Re: [trunk/7.0][stock] Valuation move lines do not include UoM
I have added again series in OCB project, because a patch has been proposed for 7.0. Regards. ** Also affects: ocb-addons/6.1 Importance: Undecided Status: New ** Also affects: ocb-addons/7.0 Importance: Undecided Status: New ** Changed in: ocb-addons/7.0 Status: New => Fix Committed -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1179705 Title: [trunk/7.0][stock] Valuation move lines do not include UoM Status in OpenERP Community Backports (Addons): Fix Committed Status in OpenERP Community Backports (Addons) 6.1 series: New Status in OpenERP Community Backports (Addons) 7.0 series: Fix Committed Status in OpenERP Addons (modules): Confirmed Bug description: Create a reception or delivery of a stockable product and process it. Either check the account lines of the valuation entry in the database or open Journal Items > Stock Journal and modify the tree view through the developer mode to show the product_id, product_uom_id, and quantity fields. While the quantity field has the stock move quantity in move UoM, the product_uom_id is always NULL! Without unit of measure, the quantity value is meaningless. Having these fields in journal items is very useful for reporting. The problem cause is that method _create_account_move_line() of stock.move does not add the product_uom_id to the created lines. Regards, Mohammad Alhashash To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1179705/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0-lp1315367-task_work_timesheet_lines_False into lp:ocb-addons
Review: Approve code review LGTM. Regards. -- https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1315367-task_work_timesheet_lines_False/+merge/218059 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix into lp:account-financial-tools
I have merge last changes of the repository to solve conflicts. Regards. -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/sale-wkfl/70-add-sale_order_revision into lp:sale-wkfl
Review: Needs Information code review and test Hi, Raphaël, thanks for the contribution. It works like intended, and it's very useful. I think it can be even more useful if cancelled orders with a revision are hidden by default from quotations screens, don't you think? Regards. -- https://code.launchpad.net/~akretion-team/sale-wkfl/70-add-sale_order_revision/+merge/202735 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix into lp:account-financial-tools
Hi, Yannick, I have done the requested changes. Regards. -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt
Review: Approve code review Hi, Jordi, Thank you very much for the changes and the patience. Regards. -- https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055/+merge/212286 Your team Department Core Editors is subscribed to branch lp:department-mgmt. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl
Review: Approve code review Hi, Alex, Thanks for the changes. Indeed, in contributors section of the documentation, there's still a reference to add it at the end of the description. Initial intention was to get a dedicated section under the key 'contributors' of the manifest file to be displayed on module list, but this is something still not possible, so that way is for now the valid one. Regards. -- https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456 into lp:hr-timesheet
Review: Approve code review LGTM. Regards. -- https://code.launchpad.net/~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456/+merge/218364 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl
Review: Abstain I abstain for the moment until I can review the MP. -- https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~lmi/ocb-addons/7.0-opw-596916-rgo into lp:ocb-addons
Review: Approve code review Thanks for the MP. Regards. -- https://code.launchpad.net/~lmi/ocb-addons/7.0-opw-596916-rgo/+merge/218476 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons
Review: Approve code review and test Please change description to fit in correct english to: - This addon provides a widget to allow many2one fields in a tree view to open the linked resource: but I have tried and it works correctly, so I'm not going to block MP. Have you considered to have another module that completely replace default many2one widget with this functionality to avoid to reprogram all views? Regards. -- https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/217655 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/department-mgmt/add-dep-on-project-task-jge into lp:department-mgmt
Review: Approve code review Thanks for the changes! Regards. -- https://code.launchpad.net/~camptocamp/department-mgmt/add-dep-on-project-task-jge/+merge/217068 Your team Department Core Editors is subscribed to branch lp:department-mgmt. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/department-mgmt/analytic_department_vre into lp:department-mgmt
Review: Needs Fixing code review
Hi, thanks for the MP.
Some little community conventions:
- l.9: Use "employee_obj = self.pool['hr.employee']" instead of "employee_obj =
self.pool.get('hr.employee')"
- And please comply with PEP8 (79 cols max, spaces after commas, etc).
Regards.
--
https://code.launchpad.net/~camptocamp/department-mgmt/analytic_department_vre/+merge/218976
Your team Department Core Editors is subscribed to branch lp:department-mgmt.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings into lp:hr-timesheet
Review: Needs Fixing code review Hi, Lorenzo, Please use correct indentation in if sentence for PEP8 compliance (higher than nested block). Functionally speaking, it seems good, but maybe you can do: if (float_end_time - float_start_time) < 0.001: and simplify the condition. Regards. -- https://code.launchpad.net/~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings/+merge/206493 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/sale-wkfl/sale-wkfl-sale-multi-journal into lp:sale-wkfl
Review: Needs Fixing code review Hi, David, in that case, please put a journal_id field on sale.order, that is filled by default with journal_id selected on shop, but that can be changed and passed to invoice. On v8, when shops dissapear, you have to only remove sale.shop part. Regards. -- https://code.launchpad.net/~akretion-team/sale-wkfl/sale-wkfl-sale-multi-journal/+merge/215440 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~alhashash/ocb-addons/7.0-bug-1317455-check-show-amount-in-words into lp:ocb-addons
Review: Approve code review Thanks for the fix and for the detailed explanation of the bug. Regards. -- https://code.launchpad.net/~alhashash/ocb-addons/7.0-bug-1317455-check-show-amount-in-words/+merge/218930 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/sale-wkfl/sale-wkfl-sale-multi-journal into lp:sale-wkfl
Yeah, and that plans are compatible with the proposal, because you can have a basic module with only journal at sale order level, and an additional one with the dependency to new shop module with this feature. Regards. -- https://code.launchpad.net/~akretion-team/sale-wkfl/sale-wkfl-sale-multi-journal/+merge/215440 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced into lp:account-financial-tools
Hi, Yannick, Thanks for taking the time to review such a huge change that I have made on the module. I know that there's still a lot to do to comply with all the conventions, but this is a beginning motivated by some requirements not met in it. I have fixed things you have point about missing contexts. About tax_template to tax_templ it was to favour PEP8 80 cols restriction, because with that long names was very difficult to fit lines. I think it's still enough readable and I win 3 chars less. I removed required=True from fill to avoid a strange situation that happens when removing a chart template (a strange user case, but I faced it in one case): if you put this field as required, and you run the wizard, a row is created on the temporary table form the transient model. This table is not clean up until next vacuum. Meanwhile, if you try to remove the chart template that has been selected on the wizard, due to ondelete="cascade" attribute, chart_template_id is emptied on temporary table, but required constraint throws an error, avoiding you to remove this chart template. That's why I have moved required condition to view. Regards. -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced/+merge/212074 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced into lp:account-financial-tools
s/required=True from fill/required=True from wizard -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced/+merge/212074 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl
Hi, Lorenzo, thanks for your review. I have corrected flake8 output. But about negative restriction in the percentage amount, I don't think it's a good idea, because you can apply a surcharge of whatever percentage you want: for example, -100% to double original price, -200% to triple it, and so on. Regards. -- https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030 Your team Purchase Core Editors is requested to review the proposed merge of lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl
You're right. I don't know how can I overpassed that! I have corrected. Thanks. Regards. -- https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030 Your team Purchase Core Editors is requested to review the proposed merge of lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
