Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
Review: Needs Fixing code review
Hello Romain and Alexandre,
diff comments + some PEP8 remarks
product_procurement_type/product.py:27:1: E302 expected 2 blank lines, found 1
product_procurement_type/product.py:34:1: E302 expected 2 blank lines, found 1
product_procurement_type/product.py:99:13: E123 closing bracket does not match
indentation of opening bracket's line
product_procurement_type/product.py:42:80: E501 line too long (95 79
characters)
product_procurement_type_dropshipping/product.py:28:1: E302 expected 2 blank
lines, found 0
product_procurement_type_dropshipping/product.py:33:1: E302 expected 2 blank
lines, found 1
product_procurement_type_dropshipping/product.py:52:5: E303 too many blank
lines (2)
product_procurement_type_dropshipping/product.py:111:17: E123 closing bracket
does not match indentation of opening bracket's line
product_procurement_type_dropshipping/product.py:115:1: W391 blank line at end
of file
product_procurement_type_dropshipping/product.py:25:80: E501 line too long (90
79 characters)
product_procurement_type_dropshipping/product.py:46:80: E501 line too long (116
79 characters)
product_procurement_type_dropshipping/product.py:64:80: E501 line too long (80
79 characters)
Diff comments:
=== added directory 'product_procurement_type'
=== added file 'product_procurement_type/__init__.py'
--- product_procurement_type/__init__.py 1970-01-01 00:00:00 +
+++ product_procurement_type/__init__.py 2014-06-10 15:36:28 +
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import product
=== added file 'product_procurement_type/__openerp__.py'
--- product_procurement_type/__openerp__.py 1970-01-01 00:00:00 +
+++ product_procurement_type/__openerp__.py 2014-06-10 15:36:28 +
@@ -0,0 +1,52 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+name: Product Procurement Types,
+version: 0.1,
+author: Camptocamp,
+license: AGPL-3,
+category: Sales,
+description:
+
+Add a procurement type selection on products.
+Let create products as :
+ - On stock, buy
+ - On stock, produce
+ - On order, buy
+ - On order, produce
+
+Choose On stock, buy changes automatically
+procurement method as make to stock and supply method as buy.
+Choose On demand, produce changes automatically
+procurement method as make to order and supply method as produce.
+
+,
+website: http://camptocamp.com;,
+depends: ['sale',
+'procurement',
+'mrp'],
+data: ['product_view.xml'],
+demo: [],
+test: ['test/test_onchange_procurement_type.yml'],
+active: False,
+installable: True,
+}
=== added file 'product_procurement_type/product.py'
--- product_procurement_type/product.py 1970-01-01 00:00:00 +
+++ product_procurement_type/product.py 2014-06-10 15:36:28 +
@@ -0,0 +1,139 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Romain Deheele
+#Copyright 2014
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
After several various changes, I think it's time to review it again. Thanks, Romain -- https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/222111 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
I've fixed Lorenzo's remarks, and moved the migration script to an init method as the migration script may not be executed on initial installation -- https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/222111 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl.
Requested reviews:
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c): code review + no
tests
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c): code review, test
Lorenzo Battistini - Agile BG (elbati)
Stefan Rijnhart (Therp) (stefan-therp)
Leonardo Pistone - camptocamp (lpistone): code review
Yannick Vaucher @ Camptocamp (yvaucher-c2c): code review, no tests
For more details, see:
https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/222111
Here are two new addons who brings a simple field to manage several combinations
for two procurements fields : procure_method supply_method :
First addon adds:
- Normal: MTS + buy
- Bill of Materials: MTO + produce
Second addon depends of sale_dropshipping addon and adds:
- Dropshipping: MTO + buy
I'm not sure if it's the right community branch to propose it, if you think
about a better
place, let me know.
--
https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/222111
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
=== added directory 'product_procurement_type'
=== added file 'product_procurement_type/__init__.py'
--- product_procurement_type/__init__.py 1970-01-01 00:00:00 +
+++ product_procurement_type/__init__.py 2014-06-04 22:49:14 +
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import product
=== added file 'product_procurement_type/__openerp__.py'
--- product_procurement_type/__openerp__.py 1970-01-01 00:00:00 +
+++ product_procurement_type/__openerp__.py 2014-06-04 22:49:14 +
@@ -0,0 +1,50 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+name: Product Procurement Types,
+version: 0.1,
+author: Camptocamp,
+license: AGPL-3,
+category: Sales,
+description:
+
+Add a procurement type selection on products.
+Let create products as :
+ - Standard
+ - Bill of Materials
+
+Choose Standard changes automatically
+procurement method as make to stock and supply method as buy.
+Choose Bill of Materials changes automatically
+procurement method as make to order and supply method as produce.
+
+,
+website: http://camptocamp.com;,
+depends: ['sale',
+'procurement',
+'mrp'],
+data: ['product_view.xml'],
+demo: [],
+test: ['test/test_onchange_procurement_type.yml'],
+active: False,
+installable: True,
+}
=== added file 'product_procurement_type/product.py'
--- product_procurement_type/product.py 1970-01-01 00:00:00 +
+++ product_procurement_type/product.py 2014-06-04 22:49:14 +
@@ -0,0 +1,139 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
Review: Needs Information Hello Alexandre, line 223: if vals['type'] == 'service', should we run _compute_procurement_vals anyway? lines 585 and 597: as 'product_procurement_type_dropshipping' depends on 'product_procurement_type', why do the write and create methods call the '_compute_procurement_vals' method, already called by 'product_procurement_type'? Thanks! -- https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/209018 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
The proposal to merge lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638 -- https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
Review: Resubmit test I found an issue (possibly a framework bug) which prevents the new attribute from being imported from a CSV file. -- https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
Review: Approve code review, test I updated the MP with a workaround described in http://bazaar.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/revision/43 -- https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/209018 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl.
Requested reviews:
Yannick Vaucher @ Camptocamp (yvaucher-c2c): code review, no tests
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c): test
Stefan Rijnhart (Therp) (stefan-therp)
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c): code review, no tests
Leonardo Pistone - camptocamp (lpistone): code review
For more details, see:
https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/209018
Hello,
Here are two new addons who brings a simple field to manage several combinations
for two procurements fields : procure_method supply_method :
First addon adds:
- Normal: MTS + buy
- Bill of Materials: MTO + produce
Second addon depends of sale_dropshipping addon and adds:
- Dropshipping: MTO + buy
I'm not sure if it's the right community branch to propose it, if you think
about a better
place, let me know.
Regards,
Romain
--
https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/209018
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
=== added directory 'product_procurement_type'
=== added file 'product_procurement_type/__init__.py'
--- product_procurement_type/__init__.py 1970-01-01 00:00:00 +
+++ product_procurement_type/__init__.py 2014-03-03 09:26:41 +
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import product
=== added file 'product_procurement_type/__openerp__.py'
--- product_procurement_type/__openerp__.py 1970-01-01 00:00:00 +
+++ product_procurement_type/__openerp__.py 2014-03-03 09:26:41 +
@@ -0,0 +1,50 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+name: Product Procurement Types,
+version: 0.1,
+author: Camptocamp,
+license: AGPL-3,
+category: Sales,
+description:
+
+Add a procurement type selection on products.
+Let create products as :
+ - Standard
+ - Bill of Materials
+
+Choose Standard changes automatically
+procurement method as make to stock and supply method as buy.
+Choose Bill of Materials changes automatically
+procurement method as make to order and supply method as produce.
+
+,
+website: http://camptocamp.com;,
+depends: ['sale',
+'procurement',
+'mrp'],
+data: ['product_view.xml'],
+demo: [],
+test: ['test/test_onchange_procurement_type.yml'],
+active: False,
+installable: True,
+}
=== added directory 'product_procurement_type/migrations'
=== added directory 'product_procurement_type/migrations/7.0.0.1'
=== added file 'product_procurement_type/migrations/7.0.0.1/post-migration.py'
--- product_procurement_type/migrations/7.0.0.1/post-migration.py 1970-01-01 00:00:00 +
+++ product_procurement_type/migrations/7.0.0.1/post-migration.py 2014-03-03 09:26:41 +
@@ -0,0 +1,38 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Alexandre Fayolle
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
I don't see a problem having these modules here. About the code: there is a migration script, and I think its purpose is to update existing products upon installation of the module. However, I don't think the script is run at module installation time. Are you sure that this is the case? Yes it is run at installation time, I checked for this. Otherwise, you will need to put it in the model's _auto_init() method. It will run every time the module is upgraded (or installed) but that should not hurt. What you can do is check if column 'procurement_type' exists, call super() and run the migration queries only if the column did not exist when you checked. This indicates the installation of the module. Not sure what the cleanest way is. Do you have an opinion about the cleanness of either options, and what we should aim for in OCA modules? -- https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
Review: Approve Great, that means that we have the pre- and post-installation scripts that I always wanted after all! Much better solution than the _auto_init one. -- https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
Review: Needs Information I don't see a problem having these modules here. About the code: there is a migration script, and I think its purpose is to update existing products upon installation of the module. However, I don't think the script is run at module installation time. Are you sure that this is the case? Otherwise, you will need to put it in the model's _auto_init() method. It will run every time the module is upgraded (or installed) but that should not hurt. What you can do is check if column 'procurement_type' exists, call super() and run the migration queries only if the column did not exist when you checked. This indicates the installation of the module. -- https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
need to set the value of the attribute from current product configuration when the module is installed. setting status to Work in progress until this is resolved dons -- https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
Romain Deheele - Camptocamp has proposed merging
lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl.
Requested reviews:
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)
Yannick Vaucher @ Camptocamp (yvaucher-c2c): code review, no tests
For more details, see:
https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638
Hello,
Here are two new addons who brings a simple field to manage several combinations
for two procurements fields : procure_method supply_method :
First addon adds:
- Normal: MTS + buy
- Bill of Materials: MTO + produce
Second addon depends of sale_dropshipping addon and adds:
- Dropshipping: MTO + buy
I'm not sure if it's the right community branch to propose it, if you think
about a better
place, let me know.
Regards,
Romain
--
https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
=== added directory 'product_procurement_type'
=== added file 'product_procurement_type/__init__.py'
--- product_procurement_type/__init__.py 1970-01-01 00:00:00 +
+++ product_procurement_type/__init__.py 2014-02-26 08:58:02 +
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import product
=== added file 'product_procurement_type/__openerp__.py'
--- product_procurement_type/__openerp__.py 1970-01-01 00:00:00 +
+++ product_procurement_type/__openerp__.py 2014-02-26 08:58:02 +
@@ -0,0 +1,50 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+name: Product Procurement Types,
+version: 0.1,
+author: Camptocamp,
+license: AGPL-3,
+category: Sales,
+description:
+
+Add a procurement type selection on products.
+Let create products as :
+ - Standard
+ - Bill of Materials
+
+Choose Standard changes automatically
+procurement method as make to stock and supply method as buy.
+Choose Bill of Materials changes automatically
+procurement method as make to order and supply method as produce.
+
+,
+website: http://camptocamp.com;,
+depends: ['sale',
+'procurement',
+'mrp'],
+data: ['product_view.xml'],
+demo: [],
+test: ['test/test_onchange_procurement_type.yml'],
+active: False,
+installable: True,
+}
=== added directory 'product_procurement_type/migrations'
=== added directory 'product_procurement_type/migrations/7.0.0.1'
=== added file 'product_procurement_type/migrations/7.0.0.1/post-migration.py'
--- product_procurement_type/migrations/7.0.0.1/post-migration.py 1970-01-01 00:00:00 +
+++ product_procurement_type/migrations/7.0.0.1/post-migration.py 2014-02-26 08:58:02 +
@@ -0,0 +1,38 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Alexandre Fayolle
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your
[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
The proposal to merge lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638 -- https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
Review: Needs Fixing need to set the value of the attribute from current product configuration when the module is installed. setting status to Work in progress until this is resolved -- https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
Review: Needs Information LGTM for the code However, I don't think we have a proper branch to extend procurement. Shall we create one? Since this is mainly affecting sales, I think this branch is correct. However I'm not sure this is not too customer specific to get in OCA. What do other think? -- https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
Review: Approve code review, no tests LGTM for the code However, I don't think we have a proper branch to extend procurement. Shall we create one? -- https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
Romain Deheele - Camptocamp has proposed merging
lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl.
Requested reviews:
Sale Core Editors (sale-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638
Hello,
Here are two new addons who brings a simple field to manage several combinations
for two procurements fields : procure_method supply_method :
First addon adds:
- Normal: MTS + buy
- Bill of Materials: MTO + produce
Second addon depends of sale_dropshipping addon and adds:
- Dropshipping: MTO + buy
I'm not sure if it's the right community branch to propose it, if you think
about a better
place, let me know.
Regards,
Romain
--
https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638
Your team Sale Core Editors is requested to review the proposed merge of
lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl.
=== added directory 'product_procurement_type'
=== added file 'product_procurement_type/__init__.py'
--- product_procurement_type/__init__.py 1970-01-01 00:00:00 +
+++ product_procurement_type/__init__.py 2014-02-21 12:48:26 +
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import product
=== added file 'product_procurement_type/__openerp__.py'
--- product_procurement_type/__openerp__.py 1970-01-01 00:00:00 +
+++ product_procurement_type/__openerp__.py 2014-02-21 12:48:26 +
@@ -0,0 +1,50 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+name: Product Procurement Types,
+version: 1.0,
+author: Camptocamp,
+license: AGPL-3,
+category: Sales,
+description:
+
+Add a procurement type selection on products.
+Let create products as :
+ - Standard
+ - Bill of Materials
+
+Choose Standard changes automatically
+procurement method as make to stock and supply method as buy.
+Choose Bill of Materials changes automatically
+procurement method as make to order and supply method as produce.
+
+,
+website: http://camptocamp.com;,
+depends: ['sale',
+'procurement',
+'mrp'],
+data: ['product_view.xml'],
+demo: [],
+test: ['test/test_onchange_procurement_type.yml'],
+active: False,
+installable: True,
+}
=== added file 'product_procurement_type/product.py'
--- product_procurement_type/product.py 1970-01-01 00:00:00 +
+++ product_procurement_type/product.py 2014-02-21 12:48:26 +
@@ -0,0 +1,95 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR
