Re: [openflowplugin-dev] ODL BORON Message deserialization failed

[Michal Polkoráb]

Hi João,

looks like you are using virtual switch that uses Nicira match entries. Please 
check if you have openflowplugin nicira extensions feature installed. This 
should probbaly fix the issues. If not, then a missing deserializer needs to be 
implemented in extensions module.

Regards,
Michal

From: Andrej Leitner 
Sent: 24 October 2016 13:45
To: João Paulo Sá da Silva; openflowplugin-dev@lists.opendaylight.org; 
openflowjava-...@lists.opendaylight.org
Subject: Re: [openflowjava-dev] ODL BORON Message deserialization failed

fwd also to ofjava

From: João Paulo Sá da Silva 
Sent: Monday, October 24, 2016 12:50 PM
To: openflowplugin-dev@lists.opendaylight.org
Subject: [openflowplugin-dev] ODL BORON Message deserialization failed

Dear all,

After upgrading to boron I keep getting this messages, this problem did not 
appear in ODL Be:

2016-10-24 11:46:21,927 | WARN  | entLoopGroup-5-4 | OFDecoder  
  | 173 - org.opendaylight.openflowjava.openflow-protocol-impl - 
0.8.0.Boron | Message deserialization failed
java.lang.IllegalStateException: Deserializer for key: msgVersion: 4 
objectClass: 
org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.oxm.rev150225.match.entries.grouping.MatchEntry
 msgType: 1 oxm_field: 105 experimenterID: null was not found - please verify 
that all needed deserializers ale loaded correctly
()
2016-10-24 11:46:34,509 | WARN  | entLoopGroup-5-5 | OFDecoder  
  | 173 - org.opendaylight.openflowjava.openflow-protocol-impl - 
0.8.0.Boron | Message deserialization failed
java.lang.IllegalStateException: Deserializer for key: msgVersion: 4 
objectClass: 
org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.oxm.rev150225.match.entries.grouping.MatchEntry
 msgType: 1 oxm_field: 31 experimenterID: null was not found - please verify 
that all needed deserializers ale loaded correctly

And no Node Information appears on the web interface.

I'm using ODL Boron Release date September 21, 2016.

Do you know why this is happening?

Thank you,
João Silva
___
openflowplugin-dev mailing list
openflowplugin-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
AndrejLeitner
Software Developer

Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia
R&D centrum / Janka Kráľa 9 /  974 01 Banská Bystrica / Slovakia
 / andrej.leit...@pantheon.tech
reception: +421 2 206 65 114 / www.pantheon.sk

[logo]


___
openflowjava-dev mailing list
openflowjava-...@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/openflowjava-dev
MichalPolkoráb
Software Engineer

Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia
R&D centrum / Janka Kráľa 9 /  974 01 Banská Bystrica / Slovakia
+421 918 378 907 / michal.polko...@pantheon.tech
reception: +421 2 206 65 114 / www.pantheon.sk

[logo]


___
openflowplugin-dev mailing list
openflowplugin-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev

Re: [openflowplugin-dev] Adding TCP Flag Action and Match Support In Openflowjava

[Michal Polkoráb]

Hi Anil,


given the circumstances (change blocks netvirt + it is actually missing 
implementation of openflow extension), I believe we don't need the waiver. I 
will review the change.


Michal


From: Anil Vishnoi 
Sent: 29 July 2016 09:35
To: Michal Polkoráb
Cc: Alfasi, Shlomi; bharath...@hcl.com; 
openflowplugin-dev@lists.opendaylight.org; A H; Sam Hague; Venkatrangan G - 
ERS, HCL Tech
Subject: Re: [openflowplugin-dev] Adding TCP Flag Action and Match Support In 
Openflowjava

Hi Michal,

Can we take a waiver for these changes, because this is required by the netvirt 
project feature. Also there is no project that is consuming it, so there is no 
impact on the downstream projects as well.

Thanks
Anil

On Fri, Jul 29, 2016 at 12:15 AM, Michal Polkoráb 
mailto:michal.polko...@pantheon.tech>> wrote:

​Anil,


we have already passed M5 for offset 1 projects 
(https://wiki.opendaylight.org/view/Simultaneous_Release:Boron_Release_Plan#Schedule).


Michal


From: Anil Vishnoi mailto:vishnoia...@gmail.com>>
Sent: 29 July 2016 09:07

To: Michal Polkoráb
Cc: Alfasi, Shlomi; bharath...@hcl.com<mailto:bharath...@hcl.com>; 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>;
 A H
Subject: Re: [openflowplugin-dev] Adding TCP Flag Action and Match Support In 
Openflowjava

Hi Michal,

Can you please review the openflowjava patch, so that we can merge 
openflowplugin patch before M5.

Thanks
Anil

On Wed, Jul 27, 2016 at 4:53 AM, Anil Vishnoi 
mailto:vishnoia...@gmail.com>> wrote:
Hi Michal,

I implemented this extension and pushed the patch to both openflowjava and 
openflowplugin project. Following are the patches

https://git.opendaylight.org/gerrit/#/q/topic:onf-ext-109-tcp-flags

We need to first merge the openflowjava patch and then openflowplugin, so till 
openflowjava plugin is not merge, openflowplugin verify will fail.

I tested this experimenter match with OVS switch and it was working fine (flow 
installation as well as statistic collection).

Please review the patch, once you are done with review, we need to sync up to 
merge the patches.

Thanks
Anil

On Wed, Jul 27, 2016 at 4:25 AM, Anil Vishnoi 
mailto:vishnoia...@gmail.com>> wrote:
Hi Michal,

Here is the TCP_FLAGS extension document. I will send you the remaining 
sometime tomorrow.

Thanks
Anil

On Wed, Jul 27, 2016 at 4:17 AM, Michal Polkoráb 
mailto:michal.polko...@pantheon.tech>> wrote:

Hi Anil,


I can't access the link you sent me (can't even register there) and I haven't 
found any info relevant enough on this topic. Could you please attach the 
document in this mailing thread (possibly a document with all extensions) ?


Michal


From: Anil Vishnoi mailto:vishnoia...@gmail.com>>
Sent: 26 July 2016 21:25
To: Michal Polkoráb
Cc: Alfasi, Shlomi; bharath...@hcl.com<mailto:bharath...@hcl.com>; 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>;
 A H
Subject: Re: [openflowplugin-dev] Adding TCP Flag Action and Match Support In 
Openflowjava

Hi Michal,

There are two version of tcp_flags that is present (1) Nicira Extension (2) 
OpenFlow Approved Extension

1st should be implemented as you mention above, but (2) should be part of the 
openflow java models (as an experimenter match). Following is the link of 
approved extension document

https://rs.opennetworking.org/wiki/download/attachments/89292834/openflow-switch-extension-ext109.pdf?version=2&modificationDate=1416877745000&api=v2

I believe OVS 2.5 supports (2), but older version of OVS support (1).

I am working on (2) and will push the patch for your review by EOD.

On Tue, Jul 26, 2016 at 6:39 AM, Michal Polkoráb 
mailto:michal.polko...@pantheon.tech>> wrote:
Hello,

from comments in openflowjava change: "We have followed Open Vswitch 1.5 
specification document" - Openflowjava follows Openflow 1.3.5 specification. 
There is no such mention of tcp flag action in OF 1.3.5 specification, so these 
changes should be located in separate module, which would register these 
(de)serializers into openflowjava.

Such module would be probably appreciated by more developers, as there is / was 
more changes of such type (as OVS has its own specification). Merging 
openflowjava change would cause confusion in the future.

Regards,
Michal

From: Alfasi, Shlomi mailto:shlomi.alf...@hpe.com>>
Sent: 26 July 2016 14:20
To: bharath...@hcl.com<mailto:bharath...@hcl.com>; 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>
Cc: Michal Polkoráb; A H
Subject: Adding TCP Flag Action and Match Support In Openflowjava

Hi All,

The following patches were developed on top of stable/Beryllium and wasn't 
merged yet.
Are they g

Re: [openflowplugin-dev] Adding TCP Flag Action and Match Support In Openflowjava

[Michal Polkoráb]

​Anil,


we have already passed M5 for offset 1 projects 
(https://wiki.opendaylight.org/view/Simultaneous_Release:Boron_Release_Plan#Schedule).


Michal


From: Anil Vishnoi 
Sent: 29 July 2016 09:07
To: Michal Polkoráb
Cc: Alfasi, Shlomi; bharath...@hcl.com; 
openflowplugin-dev@lists.opendaylight.org; A H
Subject: Re: [openflowplugin-dev] Adding TCP Flag Action and Match Support In 
Openflowjava

Hi Michal,

Can you please review the openflowjava patch, so that we can merge 
openflowplugin patch before M5.

Thanks
Anil

On Wed, Jul 27, 2016 at 4:53 AM, Anil Vishnoi 
mailto:vishnoia...@gmail.com>> wrote:
Hi Michal,

I implemented this extension and pushed the patch to both openflowjava and 
openflowplugin project. Following are the patches

https://git.opendaylight.org/gerrit/#/q/topic:onf-ext-109-tcp-flags

We need to first merge the openflowjava patch and then openflowplugin, so till 
openflowjava plugin is not merge, openflowplugin verify will fail.

I tested this experimenter match with OVS switch and it was working fine (flow 
installation as well as statistic collection).

Please review the patch, once you are done with review, we need to sync up to 
merge the patches.

Thanks
Anil

On Wed, Jul 27, 2016 at 4:25 AM, Anil Vishnoi 
mailto:vishnoia...@gmail.com>> wrote:
Hi Michal,

Here is the TCP_FLAGS extension document. I will send you the remaining 
sometime tomorrow.

Thanks
Anil

On Wed, Jul 27, 2016 at 4:17 AM, Michal Polkoráb 
mailto:michal.polko...@pantheon.tech>> wrote:

Hi Anil,


I can't access the link you sent me (can't even register there) and I haven't 
found any info relevant enough on this topic. Could you please attach the 
document in this mailing thread (possibly a document with all extensions) ?


Michal


From: Anil Vishnoi mailto:vishnoia...@gmail.com>>
Sent: 26 July 2016 21:25
To: Michal Polkoráb
Cc: Alfasi, Shlomi; bharath...@hcl.com<mailto:bharath...@hcl.com>; 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>;
 A H
Subject: Re: [openflowplugin-dev] Adding TCP Flag Action and Match Support In 
Openflowjava

Hi Michal,

There are two version of tcp_flags that is present (1) Nicira Extension (2) 
OpenFlow Approved Extension

1st should be implemented as you mention above, but (2) should be part of the 
openflow java models (as an experimenter match). Following is the link of 
approved extension document

https://rs.opennetworking.org/wiki/download/attachments/89292834/openflow-switch-extension-ext109.pdf?version=2&modificationDate=1416877745000&api=v2

I believe OVS 2.5 supports (2), but older version of OVS support (1).

I am working on (2) and will push the patch for your review by EOD.

On Tue, Jul 26, 2016 at 6:39 AM, Michal Polkoráb 
mailto:michal.polko...@pantheon.tech>> wrote:
Hello,

from comments in openflowjava change: "We have followed Open Vswitch 1.5 
specification document" - Openflowjava follows Openflow 1.3.5 specification. 
There is no such mention of tcp flag action in OF 1.3.5 specification, so these 
changes should be located in separate module, which would register these 
(de)serializers into openflowjava.

Such module would be probably appreciated by more developers, as there is / was 
more changes of such type (as OVS has its own specification). Merging 
openflowjava change would cause confusion in the future.

Regards,
Michal

From: Alfasi, Shlomi mailto:shlomi.alf...@hpe.com>>
Sent: 26 July 2016 14:20
To: bharath...@hcl.com<mailto:bharath...@hcl.com>; 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>
Cc: Michal Polkoráb; A H
Subject: Adding TCP Flag Action and Match Support In Openflowjava

Hi All,

The following patches were developed on top of stable/Beryllium and wasn't 
merged yet.
Are they going to be merged to Boron also?
I need them in order to implement stateless security group in the netvirt 
project.

[1] https://git.opendaylight.org/gerrit/#/c/42389/
[2] https://git.opendaylight.org/gerrit/42388

Shlomi

-Original Message-
From: Gerrit Code Review 
[mailto:ger...@opendaylight.org<mailto:ger...@opendaylight.org>]
Sent: Tuesday, July 26, 2016 8:32 AM
Cc: Michal Polkorab 
mailto:michal.polko...@pantheon.sk>>; Alfasi, 
Shlomi mailto:shlomi.alf...@hpe.com>>; A H 
mailto:an...@huawei.com>>; jenkins-releng 
mailto:jenkins-rel...@opendaylight.org>>
Subject: Change in openflowjava[stable/beryllium]:  Adding TCP Flag Action 
and Match Support In Openflowjava

From Bharathi M mailto:bharath...@hcl.com>>:

Bharathi M has posted comments on this change.

Change subject:  Adding TCP Flag Action and Match Support In Openflowjava 
..


Patch Set 4:

> do you have

Re: [openflowplugin-dev] Adding TCP Flag Action and Match Support In Openflowjava

[Michal Polkoráb]

Hi Anil,


I can't access the link you sent me (can't even register there) and I haven't 
found any info relevant enough on this topic. Could you please attach the 
document in this mailing thread (possibly a document with all extensions) ?


Michal


From: Anil Vishnoi 
Sent: 26 July 2016 21:25
To: Michal Polkoráb
Cc: Alfasi, Shlomi; bharath...@hcl.com; 
openflowplugin-dev@lists.opendaylight.org; A H
Subject: Re: [openflowplugin-dev] Adding TCP Flag Action and Match Support In 
Openflowjava

Hi Michal,

There are two version of tcp_flags that is present (1) Nicira Extension (2) 
OpenFlow Approved Extension

1st should be implemented as you mention above, but (2) should be part of the 
openflow java models (as an experimenter match). Following is the link of 
approved extension document

https://rs.opennetworking.org/wiki/download/attachments/89292834/openflow-switch-extension-ext109.pdf?version=2&modificationDate=1416877745000&api=v2

I believe OVS 2.5 supports (2), but older version of OVS support (1).

I am working on (2) and will push the patch for your review by EOD.

On Tue, Jul 26, 2016 at 6:39 AM, Michal Polkoráb 
mailto:michal.polko...@pantheon.tech>> wrote:
Hello,

from comments in openflowjava change: "We have followed Open Vswitch 1.5 
specification document" - Openflowjava follows Openflow 1.3.5 specification. 
There is no such mention of tcp flag action in OF 1.3.5 specification, so these 
changes should be located in separate module, which would register these 
(de)serializers into openflowjava.

Such module would be probably appreciated by more developers, as there is / was 
more changes of such type (as OVS has its own specification). Merging 
openflowjava change would cause confusion in the future.

Regards,
Michal

From: Alfasi, Shlomi mailto:shlomi.alf...@hpe.com>>
Sent: 26 July 2016 14:20
To: bharath...@hcl.com<mailto:bharath...@hcl.com>; 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>
Cc: Michal Polkoráb; A H
Subject: Adding TCP Flag Action and Match Support In Openflowjava

Hi All,

The following patches were developed on top of stable/Beryllium and wasn't 
merged yet.
Are they going to be merged to Boron also?
I need them in order to implement stateless security group in the netvirt 
project.

[1] https://git.opendaylight.org/gerrit/#/c/42389/
[2] https://git.opendaylight.org/gerrit/42388

Shlomi

-Original Message-
From: Gerrit Code Review 
[mailto:ger...@opendaylight.org<mailto:ger...@opendaylight.org>]
Sent: Tuesday, July 26, 2016 8:32 AM
Cc: Michal Polkorab 
mailto:michal.polko...@pantheon.sk>>; Alfasi, 
Shlomi mailto:shlomi.alf...@hpe.com>>; A H 
mailto:an...@huawei.com>>; jenkins-releng 
mailto:jenkins-rel...@opendaylight.org>>
Subject: Change in openflowjava[stable/beryllium]:  Adding TCP Flag Action 
and Match Support In Openflowjava

>From Bharathi M mailto:bharath...@hcl.com>>:

Bharathi M has posted comments on this change.

Change subject:  Adding TCP Flag Action and Match Support In Openflowjava 
..


Patch Set 4:

> do you have any reference document for this change ?

 > We have followed Open Vswitch 1.5 specification document and the below two 
 > git files as additional reference,
   i) https://git.opendaylight.org/gerrit/#/c/8986/
   ii) https://git.opendaylight.org/gerrit/#/c/9004/
   If any changes missing kindly let us know we will add it.

--
To view, visit https://git.opendaylight.org/gerrit/42388
To unsubscribe, visit https://git.opendaylight.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88a8b7adab8efa9fa3bdd37365a6e0aae96772c1
Gerrit-PatchSet: 4
Gerrit-Project: openflowjava
Gerrit-Branch: stable/beryllium
Gerrit-Owner: Bharathi M mailto:bharath...@hcl.com>>
Gerrit-Reviewer: A H mailto:an...@huawei.com>>
Gerrit-Reviewer: Bharathi M mailto:bharath...@hcl.com>>
Gerrit-Reviewer: Michal Polkorab 
mailto:michal.polko...@pantheon.sk>>
Gerrit-Reviewer: Shlomi Alfasi 
mailto:shlomi.alf...@hpe.com>>
Gerrit-Reviewer: jenkins-releng 
mailto:jenkins-rel...@opendaylight.org>>
Gerrit-HasComments: No
MichalPolkoráb
Software Engineer

Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia
R&D centrum / Janka Krála 9 /  974 01 Banská Bystrica / Slovakia
+421 918 378 907 / michal.polko...@pantheon.tech
reception: +421 2 206 65 114 / 
www.pantheon.sk<http://www.pantheon.sk>

[logo]


___
openflowplugin-dev mailing list
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>
https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev



--
Thanks
Anil
MichalPolkoráb
Software Engineer

Sídlo / Mlynské Nivy 56 / 821 05 Br

Re: [openflowplugin-dev] Adding TCP Flag Action and Match Support In Openflowjava

[Michal Polkoráb]

Hello,

from comments in openflowjava change: "We have followed Open Vswitch 1.5 
specification document" - Openflowjava follows Openflow 1.3.5 specification. 
There is no such mention of tcp flag action in OF 1.3.5 specification, so these 
changes should be located in separate module, which would register these 
(de)serializers into openflowjava.

Such module would be probably appreciated by more developers, as there is / was 
more changes of such type (as OVS has its own specification). Merging 
openflowjava change would cause confusion in the future.

Regards,
Michal

From: Alfasi, Shlomi 
Sent: 26 July 2016 14:20
To: bharath...@hcl.com; openflowplugin-dev@lists.opendaylight.org
Cc: Michal Polkoráb; A H
Subject: Adding TCP Flag Action and Match Support In Openflowjava

Hi All,

The following patches were developed on top of stable/Beryllium and wasn't 
merged yet.
Are they going to be merged to Boron also?
I need them in order to implement stateless security group in the netvirt 
project.

[1] https://git.opendaylight.org/gerrit/#/c/42389/
[2] https://git.opendaylight.org/gerrit/42388

Shlomi

-Original Message-
From: Gerrit Code Review [mailto:ger...@opendaylight.org]
Sent: Tuesday, July 26, 2016 8:32 AM
Cc: Michal Polkorab ; Alfasi, Shlomi 
; A H ; jenkins-releng 

Subject: Change in openflowjava[stable/beryllium]:  Adding TCP Flag Action 
and Match Support In Openflowjava

From Bharathi M :

Bharathi M has posted comments on this change.

Change subject:  Adding TCP Flag Action and Match Support In Openflowjava 
..


Patch Set 4:

> do you have any reference document for this change ?

 > We have followed Open Vswitch 1.5 specification document and the below two 
 > git files as additional reference,
   i) https://git.opendaylight.org/gerrit/#/c/8986/
   ii) https://git.opendaylight.org/gerrit/#/c/9004/
   If any changes missing kindly let us know we will add it.

--
To view, visit https://git.opendaylight.org/gerrit/42388
To unsubscribe, visit https://git.opendaylight.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88a8b7adab8efa9fa3bdd37365a6e0aae96772c1
Gerrit-PatchSet: 4
Gerrit-Project: openflowjava
Gerrit-Branch: stable/beryllium
Gerrit-Owner: Bharathi M 
Gerrit-Reviewer: A H 
Gerrit-Reviewer: Bharathi M 
Gerrit-Reviewer: Michal Polkorab 
Gerrit-Reviewer: Shlomi Alfasi 
Gerrit-Reviewer: jenkins-releng 
Gerrit-HasComments: No
MichalPolkoráb
Software Engineer

Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia
R&D centrum / Janka Kráľa 9 /  974 01 Banská Bystrica / Slovakia
+421 918 378 907 / michal.polko...@pantheon.tech
reception: +421 2 206 65 114 / www.pantheon.sk

[logo]


___
openflowplugin-dev mailing list
openflowplugin-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev

Re: [openflowplugin-dev] [controller-dev] New OF message - Serialization and Deserialization Factories

[Michal Polkoráb]

Hi Icaro,


*-config modules are created for dependency injection (config-subsystem). In 
config module you usually define your module dependencies and provided service 
instances in config file. If your implementation is placed in some already 
defined module, you don't need to create new *-config module. Otherwise, in 
order to be able to get all needed dependencies (e.g. brokers, openflowjava, 
openflowplugin provider...) & connect with other components you need to create 
also the *-config module.


Michal


From: Icaro Camelo 
Sent: 11 May 2016 16:32
To: Michal Polkoráb
Cc: Rajasekaran, Monica; controller-...@lists.opendaylight.org; 
openflowplugin-dev@lists.opendaylight.org
Subject: Re: [controller-dev] New OF message - Serialization and 
Deserialization Factories

Hi Michal,

I've implemented the Serializer/Deserializer, its respectives codecs and the 
CodecRegistration, but I'm confused with the wiring.
I'm looking at the "openflowplugin-extension-nicira-config" module, but I'm not 
sure I need it.
Am I missing something else?

On Mon, May 9, 2016 at 6:56 AM, Michal Polkoráb 
mailto:michal.polko...@pantheon.tech>> wrote:

Hi Icaro,


please keep following the second link. If you experience any problems, share 
them or even update the wiki if you solve them.


Michal


From: Icaro Camelo mailto:icam...@inocybe.ca>>
Sent: 06 May 2016 22:28
To: Rajasekaran, Monica
Cc: Michal Polkoráb; 
controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>;
 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>

Subject: Re: [controller-dev] New OF message - Serialization and 
Deserialization Factories

Michal,

Could you please tell me which wiki page (#1 or #2) is the most accurate to the 
Beryllium version?
I'm following the link #2 and I'm getting Java type errors, since you told me 
that the augmentation type has changed since Lithium.

1. 
https://wiki.opendaylight.org/view/Openflow_Protocol_Library:Openflow_Protocol_Library's_extensibility:Basic_Principle_%26_Example
2. 
https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:Architecture:Extensibility:Action

On Fri, May 6, 2016 at 12:14 PM, Rajasekaran, Monica 
mailto:monica.rajaseka...@us.fujitsu.com>> 
wrote:
Hi Michal,

Got it, I will do that. How does OFJava pick up my module that is defined 
separately ? Do I just import this module and corresponding augment into the 
newly created message factories under serialization & deserialization ?

Thanks

From: Michal Polkoráb 
[mailto:michal.polko...@pantheon.tech<mailto:michal.polko...@pantheon.tech>]
Sent: Friday, May 06, 2016 2:53 AM
To: Rajasekaran, Monica 
mailto:monica.rajaseka...@us.fujitsu.com>>
Cc: 
controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>;
 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>;
 Icaro Camelo mailto:icam...@inocybe.ca>>

Subject: Re: [controller-dev] New OF message - Serialization and 
Deserialization Factories


Hi Monica,



you should create your own module just like Icaro in his example. Openflowjava 
provides only structures (model) defined in openflow (v1.0 & v1.3) 
specification - specific types should be defined in separate modules.



Michal

____
From: Rajasekaran, Monica 
mailto:monica.rajaseka...@us.fujitsu.com>>
Sent: 06 May 2016 04:01
To: Michal Polkoráb
Cc: 
controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>;
 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>;
 Icaro Camelo
Subject: RE: [controller-dev] New OF message - Serialization and 
Deserialization Factories

Hi Michal,

Thanks for your reply. Okay, so in order to do the translation between MD-SAL 
and OFJava, I should add my own augment to “openflow-augments.yang” ? Or should 
I create a separate module for my message as done by Icaro ? I’m a newbie to 
ODL development, so please excuse me if the questions seem basic.

Thanks,
Monica

From: Icaro Camelo [mailto:icam...@inocybe.ca]
Sent: Wednesday, May 04, 2016 2:46 PM
To: Michal Polkoráb 
mailto:michal.polko...@pantheon.tech>>
Cc: Rajasekaran, Monica 
mailto:monica.rajaseka...@us.fujitsu.com>>; 
controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>;
 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>
Subject: Re: [controller-dev] New OF message - Serialization and 
Deserialization Factories

I have followed the aforementioned link and I'm getting an error about not 
finding the augmented target using the same yang file content:

Here's my yang: http://pastebin.com/yhFtbBQw

[ERROR] Failed to execute go

Re: [openflowplugin-dev] [controller-dev] New OF message - Serialization and Deserialization Factories

[Michal Polkoráb]

Hi Icaro,


please keep following the second link. If you experience any problems, share 
them or even update the wiki if you solve them.


Michal


From: Icaro Camelo 
Sent: 06 May 2016 22:28
To: Rajasekaran, Monica
Cc: Michal Polkoráb; controller-...@lists.opendaylight.org; 
openflowplugin-dev@lists.opendaylight.org
Subject: Re: [controller-dev] New OF message - Serialization and 
Deserialization Factories

Michal,

Could you please tell me which wiki page (#1 or #2) is the most accurate to the 
Beryllium version?
I'm following the link #2 and I'm getting Java type errors, since you told me 
that the augmentation type has changed since Lithium.

1. 
https://wiki.opendaylight.org/view/Openflow_Protocol_Library:Openflow_Protocol_Library's_extensibility:Basic_Principle_%26_Example
2. 
https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:Architecture:Extensibility:Action

On Fri, May 6, 2016 at 12:14 PM, Rajasekaran, Monica 
mailto:monica.rajaseka...@us.fujitsu.com>> 
wrote:
Hi Michal,

Got it, I will do that. How does OFJava pick up my module that is defined 
separately ? Do I just import this module and corresponding augment into the 
newly created message factories under serialization & deserialization ?

Thanks

From: Michal Polkoráb 
[mailto:michal.polko...@pantheon.tech<mailto:michal.polko...@pantheon.tech>]
Sent: Friday, May 06, 2016 2:53 AM
To: Rajasekaran, Monica 
mailto:monica.rajaseka...@us.fujitsu.com>>
Cc: 
controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>;
 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>;
 Icaro Camelo mailto:icam...@inocybe.ca>>

Subject: Re: [controller-dev] New OF message - Serialization and 
Deserialization Factories


Hi Monica,



you should create your own module just like Icaro in his example. Openflowjava 
provides only structures (model) defined in openflow (v1.0 & v1.3) 
specification - specific types should be defined in separate modules.



Michal


From: Rajasekaran, Monica 
mailto:monica.rajaseka...@us.fujitsu.com>>
Sent: 06 May 2016 04:01
To: Michal Polkoráb
Cc: 
controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>;
 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>;
 Icaro Camelo
Subject: RE: [controller-dev] New OF message - Serialization and 
Deserialization Factories

Hi Michal,

Thanks for your reply. Okay, so in order to do the translation between MD-SAL 
and OFJava, I should add my own augment to “openflow-augments.yang” ? Or should 
I create a separate module for my message as done by Icaro ? I’m a newbie to 
ODL development, so please excuse me if the questions seem basic.

Thanks,
Monica

From: Icaro Camelo [mailto:icam...@inocybe.ca]
Sent: Wednesday, May 04, 2016 2:46 PM
To: Michal Polkoráb 
mailto:michal.polko...@pantheon.tech>>
Cc: Rajasekaran, Monica 
mailto:monica.rajaseka...@us.fujitsu.com>>; 
controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>;
 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>
Subject: Re: [controller-dev] New OF message - Serialization and 
Deserialization Factories

I have followed the aforementioned link and I'm getting an error about not 
finding the augmented target using the same yang file content:

Here's my yang: http://pastebin.com/yhFtbBQw

[ERROR] Failed to execute goal 
org.opendaylight.yangtools:yang-maven-plugin:1.0.0-SNAPSHOT:generate-sources 
(binding) on project of-extension-noviflow-api: yang-to-sources: Unable to 
parse yang files from 
/Users/icarocamelo/Development/inocybe/noviflow-plugin/of-extension-noviflow/of-extension-noviflow-api/src/main/yang:
 Augment target 
'Absolute{path=[(urn:opendaylight:openflow:common:action?revision=2015-02-03)actions-container,
 (urn:opendaylight:openflow:common:action?revision=2015-02-03)action]}' not 
found [at META-INF/yang/of-extension-noviflow.yang:15:4]

Could you please give some insight?

On Wed, May 4, 2016 at 4:17 AM, Michal Polkoráb 
mailto:michal.polko...@pantheon.tech>> wrote:

​Hi Monica,



the steps you have already done ensure only the translation between low level 
model (OFJava) and wire protocol. You also need to ensure translation between 
semantic high level model (MD-SAL) and protocol oriented low level model 
(OFJava)​. Please see this wiki page: 
https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:Architecture:Extensibility
 for more information & also check *-extension-* modules in openflowplugin. The 
combination of openflowplugin code and wiki page should be enough for you to be 
able to finish your implementation.



Michal



____
From: Rajasekaran, Monica 
mailto:monica

Re: [openflowplugin-dev] [controller-dev] New OF message - Serialization and Deserialization Factories

[Michal Polkoráb]

Hi Monica,


you should create your own module just like Icaro in his example. Openflowjava 
provides only structures (model) defined in openflow (v1.0 & v1.3) 
specification - specific types should be defined in separate modules.


Michal


From: Rajasekaran, Monica 
Sent: 06 May 2016 04:01
To: Michal Polkoráb
Cc: controller-...@lists.opendaylight.org; 
openflowplugin-dev@lists.opendaylight.org; Icaro Camelo
Subject: RE: [controller-dev] New OF message - Serialization and 
Deserialization Factories

Hi Michal,

Thanks for your reply. Okay, so in order to do the translation between MD-SAL 
and OFJava, I should add my own augment to “openflow-augments.yang” ? Or should 
I create a separate module for my message as done by Icaro ? I’m a newbie to 
ODL development, so please excuse me if the questions seem basic.

Thanks,
Monica

From: Icaro Camelo [mailto:icam...@inocybe.ca]
Sent: Wednesday, May 04, 2016 2:46 PM
To: Michal Polkoráb 
Cc: Rajasekaran, Monica ; 
controller-...@lists.opendaylight.org; openflowplugin-dev@lists.opendaylight.org
Subject: Re: [controller-dev] New OF message - Serialization and 
Deserialization Factories

I have followed the aforementioned link and I'm getting an error about not 
finding the augmented target using the same yang file content:

Here's my yang: http://pastebin.com/yhFtbBQw

[ERROR] Failed to execute goal 
org.opendaylight.yangtools:yang-maven-plugin:1.0.0-SNAPSHOT:generate-sources 
(binding) on project of-extension-noviflow-api: yang-to-sources: Unable to 
parse yang files from 
/Users/icarocamelo/Development/inocybe/noviflow-plugin/of-extension-noviflow/of-extension-noviflow-api/src/main/yang:
 Augment target 
'Absolute{path=[(urn:opendaylight:openflow:common:action?revision=2015-02-03)actions-container,
 (urn:opendaylight:openflow:common:action?revision=2015-02-03)action]}' not 
found [at META-INF/yang/of-extension-noviflow.yang:15:4]

Could you please give some insight?

On Wed, May 4, 2016 at 4:17 AM, Michal Polkoráb 
mailto:michal.polko...@pantheon.tech>> wrote:

​Hi Monica,



the steps you have already done ensure only the translation between low level 
model (OFJava) and wire protocol. You also need to ensure translation between 
semantic high level model (MD-SAL) and protocol oriented low level model 
(OFJava)​. Please see this wiki page: 
https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:Architecture:Extensibility
 for more information & also check *-extension-* modules in openflowplugin. The 
combination of openflowplugin code and wiki page should be enough for you to be 
able to finish your implementation.



Michal




From: Rajasekaran, Monica 
mailto:monica.rajaseka...@us.fujitsu.com>>
Sent: 03 May 2016 17:13
To: Michal Polkoráb; 
controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>;
 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>
Subject: RE: [controller-dev] New OF message - Serialization and 
Deserialization Factories

Hi Michal,

Thank you. Once I built that up, I added my new OF message’s details to 
openflow-protocol.yang which generated corresponding java files to generate my 
packet. And, I created message factories to handle the new message. Is this all 
in order to have a custom OF message up and running ?

Note- The message itself has no special functionality. I am just doing this to 
understand message flow in the controller in order to develop further.

Thanks

From: Michal Polkoráb 
[mailto:michal.polko...@pantheon.tech<mailto:michal.polko...@pantheon.tech>]
Sent: Tuesday, May 03, 2016 2:27 AM
To: Rajasekaran, Monica 
mailto:monica.rajaseka...@us.fujitsu.com>>; 
controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>;
 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>
Subject: Re: [controller-dev] New OF message - Serialization and 
Deserialization Factories


Hello Monica,



in order to create corresponding message factories you need to clone 
openflowjava (e.g. git clone 
ssh://{username}@git.opendaylight.org:29418/openflowjava<http://username...@git.opendaylight.org:29418/openflowjava>)
 and build it. Then you can replace your 
openflow-protocol-impl-0.7.1-Beryllium-SR1.jar with the new one.



Regards,

Michal Polkorab


From: Rajasekaran, Monica 
mailto:monica.rajaseka...@us.fujitsu.com>>
Sent: 29 April 2016 17:35
To: 
controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>;
 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>
Subject: [controller-dev] New OF message - Serialization and Deserialization 
Factories

Hi,

As a part of trying to add a new OF message, I added the required definition to 
openflow-proto

Re: [openflowplugin-dev] [controller-dev] New OF message - Serialization and Deserialization Factories

[Michal Polkoráb]

Hello Icaro,


It looks like you are augmenting incorrect target. Which Opendaylight version / 
release are you using ? Since Lithium, in order to augment actions, your action 
extension has to augment following target:  
"/ofaction:action-container/ofaction:action-choice" (instead of 
"/ofaction:actions-container/ofaction:action") with a "case" construct. Please 
see the openflow-augments.yang [1] for example.


Regards,

Michal


[1] 
https://git.opendaylight.org/gerrit/gitweb?p=openflowjava.git;a=blob;f=openflow-protocol-api/src/main/yang/openflow-augments.yang;h=e5be7e566af13870df05e8cc85463a8c88135528;hb=HEAD)



From: Icaro Camelo 
Sent: 04 May 2016 21:46
To: Michal Polkoráb
Cc: Rajasekaran, Monica; controller-...@lists.opendaylight.org; 
openflowplugin-dev@lists.opendaylight.org
Subject: Re: [controller-dev] New OF message - Serialization and 
Deserialization Factories

I have followed the aforementioned link and I'm getting an error about not 
finding the augmented target using the same yang file content:

Here's my yang: http://pastebin.com/yhFtbBQw

[ERROR] Failed to execute goal 
org.opendaylight.yangtools:yang-maven-plugin:1.0.0-SNAPSHOT:generate-sources 
(binding) on project of-extension-noviflow-api: yang-to-sources: Unable to 
parse yang files from 
/Users/icarocamelo/Development/inocybe/noviflow-plugin/of-extension-noviflow/of-extension-noviflow-api/src/main/yang:
 Augment target 
'Absolute{path=[(urn:opendaylight:openflow:common:action?revision=2015-02-03)actions-container,
 (urn:opendaylight:openflow:common:action?revision=2015-02-03)action]}' not 
found [at META-INF/yang/of-extension-noviflow.yang:15:4]

Could you please give some insight?

On Wed, May 4, 2016 at 4:17 AM, Michal Polkoráb 
mailto:michal.polko...@pantheon.tech>> wrote:

​Hi Monica,


the steps you have already done ensure only the translation between low level 
model (OFJava) and wire protocol. You also need to ensure translation between 
semantic high level model (MD-SAL) and protocol oriented low level model 
(OFJava)​. Please see this wiki page: 
https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:Architecture:Extensibility
 for more information & also check *-extension-* modules in openflowplugin. The 
combination of openflowplugin code and wiki page should be enough for you to be 
able to finish your implementation.


Michal



From: Rajasekaran, Monica 
mailto:monica.rajaseka...@us.fujitsu.com>>
Sent: 03 May 2016 17:13
To: Michal Polkoráb; 
controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>;
 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>
Subject: RE: [controller-dev] New OF message - Serialization and 
Deserialization Factories

Hi Michal,

Thank you. Once I built that up, I added my new OF message’s details to 
openflow-protocol.yang which generated corresponding java files to generate my 
packet. And, I created message factories to handle the new message. Is this all 
in order to have a custom OF message up and running ?

Note- The message itself has no special functionality. I am just doing this to 
understand message flow in the controller in order to develop further.

Thanks

From: Michal Polkoráb 
[mailto:michal.polko...@pantheon.tech<mailto:michal.polko...@pantheon.tech>]
Sent: Tuesday, May 03, 2016 2:27 AM
To: Rajasekaran, Monica 
mailto:monica.rajaseka...@us.fujitsu.com>>; 
controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>;
 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>
Subject: Re: [controller-dev] New OF message - Serialization and 
Deserialization Factories


Hello Monica,



in order to create corresponding message factories you need to clone 
openflowjava (e.g. git clone 
ssh://{username}@git.opendaylight.org:29418/openflowjava<http://username...@git.opendaylight.org:29418/openflowjava>)
 and build it. Then you can replace your 
openflow-protocol-impl-0.7.1-Beryllium-SR1.jar with the new one.



Regards,

Michal Polkorab


From: Rajasekaran, Monica 
mailto:monica.rajaseka...@us.fujitsu.com>>
Sent: 29 April 2016 17:35
To: 
controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>;
 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>
Subject: [controller-dev] New OF message - Serialization and Deserialization 
Factories

Hi,

As a part of trying to add a new OF message, I added the required definition to 
openflow-protocol.yang (which will in turn create the packet builder files).

As far as I can understand, the next step looks like I should create 
corresponding message factories for serialization and deserialization.

But, I am not able to fi

Re: [openflowplugin-dev] [controller-dev] New OF message - Serialization and Deserialization Factories

[Michal Polkoráb]

?Hi Monica,


the steps you have already done ensure only the translation between low level 
model (OFJava) and wire protocol. You also need to ensure translation between 
semantic high level model (MD-SAL) and protocol oriented low level model 
(OFJava)?. Please see this wiki page: 
https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:Architecture:Extensibility
 for more information & also check *-extension-* modules in openflowplugin. The 
combination of openflowplugin code and wiki page should be enough for you to be 
able to finish your implementation.


Michal



From: Rajasekaran, Monica 
Sent: 03 May 2016 17:13
To: Michal Polkoráb; controller-...@lists.opendaylight.org; 
openflowplugin-dev@lists.opendaylight.org
Subject: RE: [controller-dev] New OF message - Serialization and 
Deserialization Factories

Hi Michal,

Thank you. Once I built that up, I added my new OF message's details to 
openflow-protocol.yang which generated corresponding java files to generate my 
packet. And, I created message factories to handle the new message. Is this all 
in order to have a custom OF message up and running ?

Note- The message itself has no special functionality. I am just doing this to 
understand message flow in the controller in order to develop further.

Thanks

From: Michal Polkoráb [mailto:michal.polko...@pantheon.tech]
Sent: Tuesday, May 03, 2016 2:27 AM
To: Rajasekaran, Monica ; 
controller-...@lists.opendaylight.org; openflowplugin-dev@lists.opendaylight.org
Subject: Re: [controller-dev] New OF message - Serialization and 
Deserialization Factories


Hello Monica,



in order to create corresponding message factories you need to clone 
openflowjava (e.g. git clone 
ssh://{username}@git.opendaylight.org:29418/openflowjava) and build it. Then 
you can replace your openflow-protocol-impl-0.7.1-Beryllium-SR1.jar with the 
new one.



Regards,

Michal Polkorab


From: Rajasekaran, Monica 
mailto:monica.rajaseka...@us.fujitsu.com>>
Sent: 29 April 2016 17:35
To: 
controller-...@lists.opendaylight.org<mailto:controller-...@lists.opendaylight.org>;
 
openflowplugin-dev@lists.opendaylight.org<mailto:openflowplugin-dev@lists.opendaylight.org>
Subject: [controller-dev] New OF message - Serialization and Deserialization 
Factories

Hi,

As a part of trying to add a new OF message, I added the required definition to 
openflow-protocol.yang (which will in turn create the packet builder files).

As far as I can understand, the next step looks like I should create 
corresponding message factories for serialization and deserialization.

But, I am not able to find the correct way to do it. On Github, the java files 
are present at 
"openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/".

I have Beryllium SR1 and that looks different. The path I have is: 
"/OPENDAYLIGHT/distribution-karaf-0.4.1-Beryllium-SR1/system/org/opendaylight/openflowjava/openflow-protocol-impl/0.7.1-Beryllium-SR1/openflow-protocol-impl-0.7.1-Beryllium-SR1.jar"

Inside the jar file, there are a bunch of .class files. I do not see the java 
files here. Also, I do not see them present anywhere else. Any help on this?

Thanks

MichalPolkoráb
Software Engineer

Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia
R&D centrum / Janka Krála 9 /  974 01 Banská Bystrica / Slovakia
+421 918 378 907 / 
michal.polko...@pantheon.tech<mailto:michal.polko...@pantheon.tech>
reception: +421 2 206 65 114 / www.pantheon.sk<http://www.pantheon.sk>

[logo]


MichalPolkoráb
Software Engineer

Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia
R&D centrum / Janka Krála 9 /  974 01 Banská Bystrica / Slovakia
+421 918 378 907 / michal.polko...@pantheon.tech
reception: +421 2 206 65 114 / www.pantheon.sk

[logo]


___
openflowplugin-dev mailing list
openflowplugin-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev

Re: [openflowplugin-dev] [controller-dev] New OF message - Serialization and Deserialization Factories

[Michal Polkoráb]

Hello Monica,


in order to create corresponding message factories you need to clone 
openflowjava (e.g. git clone 
ssh://{username}@git.opendaylight.org:29418/openflowjava) and build it. Then 
you can replace your openflow-protocol-impl-0.7.1-Beryllium-SR1.jar with the 
new one.


Regards,

Michal Polkorab


From: Rajasekaran, Monica 
Sent: 29 April 2016 17:35
To: controller-...@lists.opendaylight.org; 
openflowplugin-dev@lists.opendaylight.org
Subject: [controller-dev] New OF message - Serialization and Deserialization 
Factories

Hi,

As a part of trying to add a new OF message, I added the required definition to 
openflow-protocol.yang (which will in turn create the packet builder files).

As far as I can understand, the next step looks like I should create 
corresponding message factories for serialization and deserialization.

But, I am not able to find the correct way to do it. On Github, the java files 
are present at 
"openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/serialization/factories/".

I have Beryllium SR1 and that looks different. The path I have is: 
"/OPENDAYLIGHT/distribution-karaf-0.4.1-Beryllium-SR1/system/org/opendaylight/openflowjava/openflow-protocol-impl/0.7.1-Beryllium-SR1/openflow-protocol-impl-0.7.1-Beryllium-SR1.jar"

Inside the jar file, there are a bunch of .class files. I do not see the java 
files here. Also, I do not see them present anywhere else. Any help on this?

Thanks

MichalPolkoráb
Software Engineer

Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia
R&D centrum / Janka Krála 9 /  974 01 Banská Bystrica / Slovakia
+421 918 378 907 / michal.polko...@pantheon.tech
reception: +421 2 206 65 114 / www.pantheon.sk

[logo]


___
openflowplugin-dev mailing list
openflowplugin-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev

Re: [openflowplugin-dev] [openflowjava-dev] Regression detected

[Michal Polkoráb]

Robot tests (robot setups) should know which switch they are using. CPqD 
switches should be used only when testing groups - as far as I know.

Unfortunately, I won't do the change as it is out of my scope.


Michal


From: Abhijit Kumbhare 
Sent: 05 February 2016 15:36
To: Michal Polkoráb
Cc: Luis Gomez; openflowjava-dev; openflowplugin-dev
Subject: Re: [openflowjava-dev] Regression detected

For the first solution:

1. introduce timeout / sleep in testcases with CPqD switches,

How do you know if we are connecting to a CPqD switch and not any other kind of 
switch? It will be important to be able to keep working with CPqD switch as it 
would be good to be able to work with multiple switches.

So will you do the timeout change Michal?


On Fri, Feb 5, 2016 at 5:43 AM, Michal Polkoráb 
mailto:michal.polko...@pantheon.sk>> wrote:

Hello,


the change that causes the problems is this one: 
https://git.opendaylight.org/gerrit/#/c/33906/. It fixes Bug 4614 
(https://bugs.opendaylight.org/show_bug.cgi?id=4614).

We have tested the change with both OVS and CPqD switches and both passed. The 
XID (see the change) wasn't used because CPqD switch didn't fully behave 
according to the specification (didn't reply with correct XID) - and as it 
turns out, it still doesn't. The first connection usually replies with random 
generated XID in features-reply, after we close the connection (approx. 30 
seconds), the device connects successfully. So our options are:

?1. introduce timeout / sleep in testcases with CPqD switches,

2. replace CPqD switches with OVS switches (since OVS 2.3 - groups are 
supported).


Regards,

Michal Polkorab



From: Abhijit Kumbhare mailto:abhijitk...@gmail.com>>
Sent: 05 February 2016 01:24
To: Luis Gomez
Cc: openflowjava-dev; openflowplugin-dev
Subject: Re: [openflowjava-dev] Regression detected

Thanks Luis. May be better to wait for Michal Polkorab to comment.

On Thu, Feb 4, 2016 at 4:08 PM, Luis Gomez 
mailto:ece...@gmail.com>> wrote:
Hi OFP devs,

It looks like this patch:

https://git.opendaylight.org/gerrit/#/c/33652/

broke CPqD switch support in both plugins:

https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-flow-services-only-beryllium/

https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-flow-services-lithium-redesign-only-beryllium/

BR/Luis



___
openflowjava-dev mailing list
openflowjava-...@lists.opendaylight.org<mailto:openflowjava-...@lists.opendaylight.org>
https://lists.opendaylight.org/mailman/listinfo/openflowjava-dev


MichalPolkoráb
Software Engineer

Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia
R&D centrum / Janka Krála 9 /  974 01 Banská Bystrica / Slovakia
+421 918 378 907 / 
michal.polko...@pantheon.sk<mailto:michal.polko...@pantheon.sk>
reception: +421 2 206 65 114 / www.pantheon.sk<http://www.pantheon.sk>

[logo]



MichalPolkoráb
Software Engineer

Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia
R&D centrum / Janka Krála 9 /  974 01 Banská Bystrica / Slovakia
+421 918 378 907 / michal.polko...@pantheon.sk
reception: +421 2 206 65 114 / www.pantheon.sk

[logo]


___
openflowplugin-dev mailing list
openflowplugin-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev

Re: [openflowplugin-dev] [openflowjava-dev] Regression detected

[Michal Polkoráb]

Hello,


the change that causes the problems is this one: 
https://git.opendaylight.org/gerrit/#/c/33906/. It fixes Bug 4614 
(https://bugs.opendaylight.org/show_bug.cgi?id=4614).

We have tested the change with both OVS and CPqD switches and both passed. The 
XID (see the change) wasn't used because CPqD switch didn't fully behave 
according to the specification (didn't reply with correct XID) - and as it 
turns out, it still doesn't. The first connection usually replies with random 
generated XID in features-reply, after we close the connection (approx. 30 
seconds), the device connects successfully. So our options are:

?1. introduce timeout / sleep in testcases with CPqD switches,

2. replace CPqD switches with OVS switches (since OVS 2.3 - groups are 
supported).


Regards,

Michal Polkorab



From: Abhijit Kumbhare 
Sent: 05 February 2016 01:24
To: Luis Gomez
Cc: openflowjava-dev; openflowplugin-dev
Subject: Re: [openflowjava-dev] Regression detected

Thanks Luis. May be better to wait for Michal Polkorab to comment.

On Thu, Feb 4, 2016 at 4:08 PM, Luis Gomez 
mailto:ece...@gmail.com>> wrote:
Hi OFP devs,

It looks like this patch:

https://git.opendaylight.org/gerrit/#/c/33652/

broke CPqD switch support in both plugins:

https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-flow-services-only-beryllium/

https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-flow-services-lithium-redesign-only-beryllium/

BR/Luis



___
openflowjava-dev mailing list
openflowjava-...@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/openflowjava-dev


MichalPolkoráb
Software Engineer

Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia
R&D centrum / Janka Krála 9 /  974 01 Banská Bystrica / Slovakia
+421 918 378 907 / michal.polko...@pantheon.sk
reception: +421 2 206 65 114 / www.pantheon.sk

[logo]


___
openflowplugin-dev mailing list
openflowplugin-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev