Re: [9] Review request: 8178015: Clarify requirement for app modules to export/open packages to javafx modules

2017-04-17 Thread Mandy Chung 

> On Apr 17, 2017, at 5:00 PM, Kevin Rushforth  
> wrote:
> 
> Please review the following javadoc change:
> 
> https://bugs.openjdk.java.net/browse/JDK-8178015
> http://cr.openjdk.java.net/~kcr/8178015/webrev.00/
> 

+ * Applications in a Module
:
+ * {@link Module#isOpen(String,Module) open} the containing package to the
+ * {@code javafx.graphics} module.

to “at least” javafx.graphics module.

Otherwise looks good.
Mandy

HEADS-UP: Bump the minimum buildnum for the boot JDK used by FX 9 (and FX 10) to build 165

2017-04-17 Thread Kevin Rushforth 
The last module system refresh that went into build 165 moved the Module 
and Layer class from java.lang.reflect to java.lang. This is both a 
source and binary incompatible change, and since we want to reference 
Module in our javadocs (at least) it's time to bump the minimum build 
number to 165.


Absent any concerns regarding this, I would like to push the change some 
time on Wednesday or Thursday of this week. This means that all JavaFX 
developers should download the latest EA build of JDK 9, which is jdk-9+165.


Let me know if you have questions or concerns.

Thanks.

-- Kevin

[9] Review request: 8178015: Clarify requirement for app modules to export/open packages to javafx modules

2017-04-17 Thread Kevin Rushforth 

Please review the following javadoc change:

https://bugs.openjdk.java.net/browse/JDK-8178015
http://cr.openjdk.java.net/~kcr/8178015/webrev.00/

This restores the links to the Module class that had to be removed 
during the transition period for the move of Module and Layer from 
java.lang.reflect to java.lang, and makes the requirements for running 
an application in a named module more clear. I also fixed a couple 
related typos in the modified paragraphs.


-- Kevin

Re: [8u121] Review request for JDK-8177077: Constructing multiple Image objects using animated GIFs concurrently can fail with AIOOBE

2017-04-17 Thread Kevin Rushforth 
One correction: All code reviews need to be done for JDK 10. This 
applies to the fix for 8178837 as well. Please resubmit the webrevs 
against FX 10-dev.


Separately, once the fix is done, and if the fix is safe enough and 
important enough, we might consider it for a backport to JDK 9u (which 
isn't open yet, but we hope will be soon), and 8u for a future update 
release of JDK 9.x and 8uNN.


-- Kevin


Markus KARG wrote:

https://bugs.openjdk.java.net/browse/JDK-8177077

 


Please review the patch attached to JDK-8177077

 


I simply wrapped invocations to Timeline.play() and Timeline.stop() by
Platform.runLater, so it should be thread safe now.

[8u121] Review request for JDK-8177077: Constructing multiple Image objects using animated GIFs concurrently can fail with AIOOBE

2017-04-17 Thread Markus KARG 
https://bugs.openjdk.java.net/browse/JDK-8177077

 

Please review the patch attached to JDK-8177077

 

I simply wrapped invocations to Timeline.play() and Timeline.stop() by
Platform.runLater, so it should be thread safe now.

[10] Review request for 8176729: com.sun.webkit.dom.NodeImpl#SelfDisposer is not called

2017-04-17 Thread Murali Billa 
 

 

Hi Kevin, Arun, Guru


Please review the fix for ­ JDK-8176729.


JIRA: https://bugs.openjdk.java.net/browse/JDK-8176729

 

Webrev: http://cr.openjdk.java.net/~mbilla/8176729/webrev.00/

 


Thanks,

Murali