[11] Review request : JDK-8194913 : Focus traversal is broken if a Pane is added to a ToolBar
Hi, Request you to review following fix : Issue : https://bugs.openjdk.java.net/browse/JDK-8194913 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8194913/webrev.0/ Regards, Ajit
RFR : JDK-8154039 : Memory leak when selecting a tab which is not contained in TabPane::getTabs()
Hi Kevin & Ajit, Please review this fix, Webrev: http://cr.openjdk.java.net/~arapte/fx/8154039/webrev.00/ Issue: https://bugs.openjdk.java.net/browse/JDK-8154039 Regards, Ambarish
Re: [10] Review request: 8195075: Old app window is not reactivatable
No need. -- Kevin Alexey Semenyuk wrote: Hi Kevin, My bad, I didn't look carefully at "Fix Version" in the JIRA record. Yes, the subject of the email is misleading. Should I resend it with the proper subject? - Alexey On 1/17/2018 6:30 PM, Kevin Rushforth wrote: I see that this bug was (correctly) targeted for 11 and not for 10. I guess the subject line is wrong? -- Kevin Alexey Semenyuk wrote: Victor, Please review my changes for fixing the issue: "JDK-8195075: Old app window is not reactivatable" JIRA: https://bugs.openjdk.java.net/browse/JDK-8195075 Webrev: http://cr.openjdk.java.net/~asemenyuk/8195075/webrev.00/ - Alexey
Re: Instructions for working on OpenJFX
Hi Kevin, Can you answer the questions I had in a previous mail please (question 4 is mostly answered)? http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-January/021232.html Thanks, Nir
Re: Instructions for working on OpenJFX
I'm still a little behind on my email, but here are some quick answers. #1 - The NetBeans instructions are still mostly correct except that with FX 9 or later you can't compile or run code from within the IDE any more (and there isn't yet a release of NetBeans 9). Not sure about the other IDEs, but I suspect they are somewhat out of date. #2. You should be able to build just the FX bits (outside your IDE) using: gradle sdk -or- gradle javadoc depending on what you want to do (or you can build both targets). If you have a build of JDK 9 or later with FX bits in it, then you can use the build/run.args script to run with the just-built FX bits without rebuilding the JDK. java @build/run.args ... #3. I don't know since I don't use Eclipse; maybe someone on the list who uses Eclipse can answer. It might have to do with the level of JDK 9 support in Eclipse #4 - previously answered -- Kevin Nir Lisker wrote: Hello, I have OpenJFX and OpenJDK built. I have also set up TortoiseHg and am working with Eclipse. I have several questions: 1. Are the instructions at https://wiki.openjdk.java.net/display/OpenJFX/Using+an+IDE still valid from JDK 8? There are old TODOs there. If not, can I get a quick update? 2. After importing the projects to Eclipse and working on the source, what steps need to be taken when the changes are to: a. only the docs? b. Java code? c. Prism code? Do I need to rebuild the JDK with JavaFX, rebuild only JavaFX, only compile etc? What tests do I need to run (e.g., I doubt I need to run regression tests when changing JavaDocs)? 3. Eclipse uses EJC (which I never had trouble with). Can this cause trouble? 4. After creating a local changeset and assuming there is already a JIRA issue for it and the fix approach was discussed, can I just push it and it will enter a review queue? Do I need to ask someone specifically for a review on the changeset ( https://wiki.openjdk.java.net/display/OpenJFX/Code+Ownership is old...)? Thanks, Nir
Re: [10, 11] Review request: 8193910: Version number in cssref.html and introduction_to_fxml.html is wrong
Here is an updated webrev for jfx-dev (11) which avoids the hard-coded version number embedded in those two .html files: http://cr.openjdk.java.net/~kcr/8193910/webrev.01/ -- Kevin Kevin Rushforth wrote: Hi Phil, Please review the following simple fix to the FX version number in our two standalone html doc pages: JBS: https://bugs.openjdk.java.net/browse/JDK-8193910 Webrev for 11: http://cr.openjdk.java.net/~kcr/8193910/webrev/ Webrev for 10: http://cr.openjdk.java.net/~kcr/8193910/10/webrev/ Thanks. -- Kevin
[11] Review request for 8191446: [Linux] Build and deliver the libav media stubs for openjfx build
Hi Kevin, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8191446 Added support for building libav stubs. Thanks, Alexander
