Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-11 Thread Johan Vos
Hi Pankaj,

What gcc version did you use to build on Ubuntu 18.04? Default, I think gcc
7.3 is used in 18.04 and that has the issue with wait() in
modules/fxpackager/src/main/native/library/common/PosixPlatform.cpp
(which was later replaced with
wait(&status);
)

This is blocking me to build 8u-dev on Ubuntu 18.04.
On Ubuntu 16.04, there are no issues and it works fine there.

- Johan

On Wed, Oct 10, 2018 at 5:10 PM Pankaj Bansal 
wrote:

> Hi Kevin,
>
> Thanks for review and the information provided.
>
> I have updated the webrev for the proposed change from RTLD_GLOBAL to
> RTLD_LOCAL in launcher.c. Along with the this change, the new patch also
> includes the backport of two more fixes mentioned below. So now we have
> backported total of 20 bugs.
>
> 19. JDK-8171985: Fx applet fails to get loaded on Ubuntu with jre9-b150
> 20. JDK-8171928: Build fails on Oracle Linux 7 with unused parameter
> warning
>
> I have tested it on all three platforms (Windows 10, Linux (Ubuntu 18.4
> LTS, Ubuntu 16.04 LTS) and and Mac) and no new test failures are found. I
> have tested the "HelloWebView" and "Ensemble" and I don't see any issue. I
> did some sanity testing on OL 7.5 as well and things look good to me.
>
> Webrev:
> http://cr.openjdk.java.net/~pbansal/gtk3_JFX_backport/webrev.01/
>
> Regards,
> Pankaj
>
>
> -Original Message-
> From: Kevin Rushforth
> Sent: Thursday, October 4, 2018 7:41 AM
> To: Pankaj Bansal; openjfx-dev@openjdk.java.net
> Subject: Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for
> GTK 3 on Linux
>
> I debugged this offline earlier today, and it looks related to a collision
> in the glib library. As I mentioned offline, a possible solution is to
> remove RTLD_GLOBAL from the dlopen of the libglassgtk{2,3}.so library. I
> was able to do a full build / test on both GTK 2 and GTK 3 including media
> and webkit with that modification.
>
> Overall, this is looking quite good.
>
> One more thing: the patch adds several new tests, so you will need to run
> at least the new tests on all three platforms (a quick check on Mac shows a
> couple failures).
>
> I also see a couple differences between jfx-dev and 8u-dev in the native
> code that should be looked into to make sure there wasn't a missed fix on
> the backport (the Hi-DPI diffs are expected, but I see a couple others).
>
> -- Kevin
>
>
> On 10/3/2018 10:16 AM, Kevin Rushforth wrote:
> > My initial testing shows a couple problems which will need to be
> > resolved:
> >
> > 1) I get many GTK warnings relating to Pango when running HelloWebView
> > 2) Running any program that uses media crashes
> >
> > This is on Ubuntu 16.04 LTS using the default GTK 2 mode.
> >
> > -- Kevin
> >
> >
> > On 10/3/2018 3:26 AM, Pankaj Bansal wrote:
> >>
> >> Hi All,
> >>
> >> Please review the patch for 8u-dev backport for JDK-8087516
> >> . It adds
> >> conditional support for gtk3.
> >>
> >> Along with the enhancement, following bug fixes have also been
> >> included in the backport webrev
> >>
> >> 1.https://bugs.openjdk.java.net/browse/JDK-8159892: [GTK3] invalid
> >> rendering of FX app stage in case of scaling
> >>
> >> 2.https://bugs.openjdk.java.net/browse/JDK-8163496: Rework Glass GTK
> >> to correct gtk3 structure sizes
> >>
> >> 3.https://bugs.openjdk.java.net/browse/JDK-8145837: Remove deprecated
> >> GTK2 calls in JavaFX
> >>
> >> 4.https://bugs.openjdk.java.net/browse/JDK-8165562: Upgrade to newer
> >> version of SWT for build/test
> >>
> >> 5.https://bugs.openjdk.java.net/browse/JDK-8171330: Issues with
> >> transparent stage and GTK
> >>
> >> 6.https://bugs.openjdk.java.net/browse/JDK-8171976: Linux: JavaFX
> >> window not painted with background when using GTK 3
> >>
> >> 7.https://bugs.openjdk.java.net/browse/JDK-8166414: Scene returns
> >> incorrect coordinates
> >>
> >> 8.https://bugs.openjdk.java.net/browse/JDK-8166147: Ubuntu 16.04:
> >> expandable content goes outside of the alert dialog
> >>
> >> 9.https://bugs.openjdk.java.net/browse/JDK-8152421: After initing the
> >> modality of a non-primary stage to MODAL, closing that stage causes
> >> the primary stage to become non-resizable
> >>
> >> 10.https://bugs.openjdk.java.net/browse/JDK-8090249: [Linux]
> >> Restoring owner stage after minimize does not restore position of
> >> child stage
> >>
> >> 11.https://bugs.openjdk.java.net/browse/JDK-8173901: Linux: Position
> >> of Stage is not restored after exiting full screen
> >>
> >> 12.https://bugs.openjdk.java.net/browse/JDK-8175204: Linux: Dialog
> >> windows come up 1-pixel wide
> >>
> >> 13.https://bugs.openjdk.java.net/browse/JDK-8175205: Linux: Stage
> >> initially in full-screen mode not shown when exiting full-screen
> >>
> >> 14.https://bugs.openjdk.java.net/browse/JDK-8175822: Pulldown
> >> position regression and not painting correctly tooltips regression
> >>
> >> 15.https://bugs.openjdk.java.net/browse/JDK-8176844: Menus not always
> >> selected properly w

RE: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-11 Thread Pankaj Bansal
Hi Johan,

 

Thanks for the review.

 

I used same gcc 7.3 and I was getting the compilation error in fxpackager. I 
used to build by making these changes locally on 18.04.

 

I discussed this with Kevin about backporting 
https://bugs.openjdk.java.net/browse/JDK-8189689. This fixes the issue you are 
facing. But I have been told that we have some Hudson machines where we get the 
successful build on gcc 7.3 without these changes. So this issue may not be 
specific to gcc version and we decided not to backport this. Let me talk to 
Kevin and I will get back to you.

 

Regards,

Pankaj

 

From: Johan Vos [mailto:johan@gluonhq.com] 
Sent: Thursday, October 11, 2018 4:05 PM
To: Pankaj Bansal
Cc: Kevin Rushforth; openjfx-dev@openjdk.java.net
Subject: Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 
on Linux

 

Hi Pankaj,

 

What gcc version did you use to build on Ubuntu 18.04? Default, I think gcc 7.3 
is used in 18.04 and that has the issue with wait() in
modules/fxpackager/src/main/native/library/common/PosixPlatform.cpp

(which was later replaced with

wait(&status);

)

 

This is blocking me to build 8u-dev on Ubuntu 18.04. 

On Ubuntu 16.04, there are no issues and it works fine there.

 

- Johan

 

On Wed, Oct 10, 2018 at 5:10 PM Pankaj Bansal mailto:pankaj.b.ban...@oracle.com"pankaj.b.ban...@oracle.com> wrote:

Hi Kevin,

Thanks for review and the information provided.

I have updated the webrev for the proposed change from RTLD_GLOBAL to 
RTLD_LOCAL in launcher.c. Along with the this change, the new patch also 
includes the backport of two more fixes mentioned below. So now we have 
backported total of 20 bugs. 

19. JDK-8171985: Fx applet fails to get loaded on Ubuntu with jre9-b150
20. JDK-8171928: Build fails on Oracle Linux 7 with unused parameter warning

I have tested it on all three platforms (Windows 10, Linux (Ubuntu 18.4 LTS, 
Ubuntu 16.04 LTS) and and Mac) and no new test failures are found. I have 
tested the "HelloWebView" and "Ensemble" and I don't see any issue. I did some 
sanity testing on OL 7.5 as well and things look good to me.

Webrev:
http://cr.openjdk.java.net/~pbansal/gtk3_JFX_backport/webrev.01/

Regards,
Pankaj


-Original Message-
From: Kevin Rushforth 
Sent: Thursday, October 4, 2018 7:41 AM
To: Pankaj Bansal; HYPERLINK 
"mailto:openjfx-dev@openjdk.java.net"openjfx-dev@openjdk.java.net
Subject: Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 
on Linux

I debugged this offline earlier today, and it looks related to a collision in 
the glib library. As I mentioned offline, a possible solution is to remove 
RTLD_GLOBAL from the dlopen of the libglassgtk{2,3}.so library. I was able to 
do a full build / test on both GTK 2 and GTK 3 including media and webkit with 
that modification.

Overall, this is looking quite good.

One more thing: the patch adds several new tests, so you will need to run at 
least the new tests on all three platforms (a quick check on Mac shows a couple 
failures).

I also see a couple differences between jfx-dev and 8u-dev in the native code 
that should be looked into to make sure there wasn't a missed fix on the 
backport (the Hi-DPI diffs are expected, but I see a couple others).

-- Kevin


On 10/3/2018 10:16 AM, Kevin Rushforth wrote:
> My initial testing shows a couple problems which will need to be
> resolved:
>
> 1) I get many GTK warnings relating to Pango when running HelloWebView
> 2) Running any program that uses media crashes
>
> This is on Ubuntu 16.04 LTS using the default GTK 2 mode.
>
> -- Kevin
>
>
> On 10/3/2018 3:26 AM, Pankaj Bansal wrote:
>>
>> Hi All,
>>
>> Please review the patch for 8u-dev backport for JDK-8087516 
>> . It adds 
>> conditional support for gtk3.
>>
>> Along with the enhancement, following bug fixes have also been 
>> included in the backport webrev
>>
>> 1.https://bugs.openjdk.java.net/browse/JDK-8159892: [GTK3] invalid 
>> rendering of FX app stage in case of scaling
>>
>> 2.https://bugs.openjdk.java.net/browse/JDK-8163496: Rework Glass GTK 
>> to correct gtk3 structure sizes
>>
>> 3.https://bugs.openjdk.java.net/browse/JDK-8145837: Remove deprecated
>> GTK2 calls in JavaFX
>>
>> 4.https://bugs.openjdk.java.net/browse/JDK-8165562: Upgrade to newer 
>> version of SWT for build/test
>>
>> 5.https://bugs.openjdk.java.net/browse/JDK-8171330: Issues with 
>> transparent stage and GTK
>>
>> 6.https://bugs.openjdk.java.net/browse/JDK-8171976: Linux: JavaFX 
>> window not painted with background when using GTK 3
>>
>> 7.https://bugs.openjdk.java.net/browse/JDK-8166414: Scene returns 
>> incorrect coordinates
>>
>> 8.https://bugs.openjdk.java.net/browse/JDK-8166147: Ubuntu 16.04: 
>> expandable content goes outside of the alert dialog
>>
>> 9.https://bugs.openjdk.java.net/browse/JDK-8152421: After initing the 
>> modality of a non-primary stage to MODAL, closing that stage causes 
>> the primary stage to 

Re: Compiling using javac

2018-10-11 Thread Graham Norris
** Reply to message from Abhinay Agarwal  on Wed, 10
Oct 2018 09:49:06 +

Abhinay,

I've found I actually had two problems.

The later one was while trying to get the sample to compile: --module-path will
not tolerate a trailing "\" on the path. It doesn't reject it, it just makes it
not work.

My original problem turned out to be the fact that --module-path in a parm file
requires "/", not "\", even on Windows. Again, not rejected, just doesn't work.

Thanks for your help.

Graham.

> Hi Graham,
> 
> The error "module not found: javafx.controls" can be caused when env variable
> 'PATH_TO_FX' is targeting the 'JavaFX SDK' instead of 'JavaFX SDK/lib' 
> directory
> 
> The following works for me on a Windows machine:
> 
> > set JAVA_HOME="C:\Program Files\Java\jdk-11"
> > set PATH_TO_FX="C:\Program Files\Java\javafx-sdk-11\lib"
> > %JAVA_HOME%\bin\javac --module-path %PATH_TO_FX% 
> > --add-modules=javafx.controls HelloFX.java
> > %JAVA_HOME%\bin\java --module-path %PATH_TO_FX% 
> > --add-modules=javafx.controls HelloFX
> 
> -- Abhinay
> 
> 
> On Oct 10 2018, at 2:59 pm, Graham Norris  wrote:
> 
> ** Reply to message from Abhinay Agarwal  on Tue, 9
> Oct 2018 16:30:18 +
> 
> No stack trace from either type of failure, just error messages. I've tried
> compiling that example program, with the following result:
> 
> D:\pbmdev>dir HelloFX.java&set PATH_TO_FX&dir %PATH_TO_FX%javafx.*&javac
> --module-path %PATH_TO_FX% --add-modules=javafx.controls HelloFX
> Volume in drive D is DataVolume
> Volume Serial Number is 64B0-54F9
> 
> Directory of D:\pbmdev
> 
> 10/10/2018 10:19 642 HelloFX.java
> 1 File(s) 642 bytes
> 0 Dir(s) 80,740,716,544 bytes free
> PATH_TO_FX="c:\Program Files\Java\JDK-11.028\lib\"
> Volume in drive C is System
> Volume Serial Number is 5EC2-1518
> 
> Directory of c:\Program Files\Java\JDK-11.028\lib
> 
> 13/09/2018 15:57 749,886 javafx.base.jar
> 13/09/2018 15:57 2,511,103 javafx.controls.jar
> 13/09/2018 15:57 127,394 javafx.fxml.jar
> 13/09/2018 15:57 4,292,697 javafx.graphics.jar
> 13/09/2018 15:57 270,594 javafx.media.jar
> 13/09/2018 15:57 71 javafx.properties
> 13/09/2018 15:57 119,848 javafx.swing.jar
> 13/09/2018 15:57 712,651 javafx.web.jar
> 8 File(s) 8,784,244 bytes
> 0 Dir(s) 41,713,242,112 bytes free
> error: no source files
> 
> D:\pbmdev>
> 
> Hi Graham,
> 
> Its really difficult to help without checking out the failing command first.
> 
> Could you reply back with the "javac" command you are trying to execute, 
> along with the stacktrace?
> 
> -- Abhinay
> 
> From: openjfx-dev  on behalf of Graham 
> Norris 
> Sent: Tuesday, October 9, 2018 9:39 PM
> To: openjfx-dev@openjdk.java.net
> Subject: Re: Compiling using javac
> 
> ** Reply to message from Michael Paus  on Tue, 9 Oct 2018 
> 15:47:29
> +0200
> 
> Thank you, I'd already found this, but it isn't exactly "documentation." Also,
> it is for Linux (Windows doesn't have export,) but I have put the path 
> directly
> on the --module-path option, which should be equivalent for this.
> 
> Crucially, it does not work: I get "error: module not found: javafx.controls"
> I'm not entirely sure why I'd use javafx.controls as my application does not
> use that, but not finding javafx.controls seems to be unrelated to lack of 
> use,
> which is also borne out by the fact that the compile fails immediately rather
> than churning out dozens of errors as it tries to compile things.
> 
> Graham.
> 
> The documentation you are looking for can be found here:
> https://openjfx.io/openjfx-docs/
> 
> Am 09.10.18 um 15:32 schrieb Graham Norris:
> I have an existing Java application which uses JavaFX. It is currently 
> compiled
> (on Windows) and working using Oracle's Java 10 JDK. I am now trying to get it
> to compile using OpenJDK 11 and OpenJFX 11, and failing miserably!
> 
> I use the JDK's command line tools to compile the application and haven't
> managed to find anything which shows how to make the combination of an 
> existing
> application, OpenJDK 11 and OpenJFX 11 compile. Basically, I can't get javac 
> to
> find and use either OpenJFX's jmods or jars.
> 
> I feel there should be somewhere I could read instructions on how to use
> OpenJFX with OpenJDK 11's javac, but if there is, I just can't find it!
> 
> Any help appreciated.
> 
> Graham.


Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-11 Thread Kevin Rushforth
We use gcc 7.3 (and Oracle Linux 6 / 7) for our Hudson builds of FX 8 
and don't see this problem. Pankaj asked about backporting the fix for 
that JDK-8203884, but I suggested it wasn't needed, since it is 
unrelated to this change.


It sounds like we should backport JDK-8203884, though I prefer it as a 
separate fix not tied to the GTK 3 work.


-- Kevin


On 10/11/2018 3:35 AM, Johan Vos wrote:

Hi Pankaj,

What gcc version did you use to build on Ubuntu 18.04? Default, I 
think gcc 7.3 is used in 18.04 and that has the issue with wait() in

modules/fxpackager/src/main/native/library/common/PosixPlatform.cpp
(which was later replaced with
wait(&status);
)

This is blocking me to build 8u-dev on Ubuntu 18.04.
On Ubuntu 16.04, there are no issues and it works fine there.

- Johan

On Wed, Oct 10, 2018 at 5:10 PM Pankaj Bansal 
mailto:pankaj.b.ban...@oracle.com>> wrote:


Hi Kevin,

Thanks for review and the information provided.

I have updated the webrev for the proposed change from RTLD_GLOBAL
to RTLD_LOCAL in launcher.c. Along with the this change, the new
patch also includes the backport of two more fixes mentioned
below. So now we have backported total of 20 bugs.

19. JDK-8171985: Fx applet fails to get loaded on Ubuntu with
jre9-b150
20. JDK-8171928: Build fails on Oracle Linux 7 with unused
parameter warning

I have tested it on all three platforms (Windows 10, Linux (Ubuntu
18.4 LTS, Ubuntu 16.04 LTS) and and Mac) and no new test failures
are found. I have tested the "HelloWebView" and "Ensemble" and I
don't see any issue. I did some sanity testing on OL 7.5 as well
and things look good to me.

Webrev:
http://cr.openjdk.java.net/~pbansal/gtk3_JFX_backport/webrev.01/


Regards,
Pankaj


-Original Message-
From: Kevin Rushforth
Sent: Thursday, October 4, 2018 7:41 AM
To: Pankaj Bansal; openjfx-dev@openjdk.java.net

Subject: Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional
support for GTK 3 on Linux

I debugged this offline earlier today, and it looks related to a
collision in the glib library. As I mentioned offline, a possible
solution is to remove RTLD_GLOBAL from the dlopen of the
libglassgtk{2,3}.so library. I was able to do a full build / test
on both GTK 2 and GTK 3 including media and webkit with that
modification.

Overall, this is looking quite good.

One more thing: the patch adds several new tests, so you will need
to run at least the new tests on all three platforms (a quick
check on Mac shows a couple failures).

I also see a couple differences between jfx-dev and 8u-dev in the
native code that should be looked into to make sure there wasn't a
missed fix on the backport (the Hi-DPI diffs are expected, but I
see a couple others).

-- Kevin


On 10/3/2018 10:16 AM, Kevin Rushforth wrote:
> My initial testing shows a couple problems which will need to be
> resolved:
>
> 1) I get many GTK warnings relating to Pango when running
HelloWebView
> 2) Running any program that uses media crashes
>
> This is on Ubuntu 16.04 LTS using the default GTK 2 mode.
>
> -- Kevin
>
>
> On 10/3/2018 3:26 AM, Pankaj Bansal wrote:
>>
>> Hi All,
>>
>> Please review the patch for 8u-dev backport for JDK-8087516
>> . It adds
>> conditional support for gtk3.
>>
>> Along with the enhancement, following bug fixes have also been
>> included in the backport webrev
>>
>> 1.https://bugs.openjdk.java.net/browse/JDK-8159892: [GTK3] invalid
>> rendering of FX app stage in case of scaling
>>
>> 2.https://bugs.openjdk.java.net/browse/JDK-8163496: Rework
Glass GTK
>> to correct gtk3 structure sizes
>>
>> 3.https://bugs.openjdk.java.net/browse/JDK-8145837: Remove
deprecated
>> GTK2 calls in JavaFX
>>
>> 4.https://bugs.openjdk.java.net/browse/JDK-8165562: Upgrade to
newer
>> version of SWT for build/test
>>
>> 5.https://bugs.openjdk.java.net/browse/JDK-8171330: Issues with
>> transparent stage and GTK
>>
>> 6.https://bugs.openjdk.java.net/browse/JDK-8171976: Linux: JavaFX
>> window not painted with background when using GTK 3
>>
>> 7.https://bugs.openjdk.java.net/browse/JDK-8166414: Scene returns
>> incorrect coordinates
>>
>> 8.https://bugs.openjdk.java.net/browse/JDK-8166147: Ubuntu 16.04:
>> expandable content goes outside of the alert dialog
>>
>> 9.https://bugs.openjdk.java.net/browse/JDK-8152421: After
initing the
>> modality of a non-primary stage to MODAL, closing that stage
causes
>> the primary stage to become non-resizable
>>
>> 10.https://bugs.openjdk.java.ne

Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-11 Thread Kevin Rushforth

I used the wrong bug ID below. Here is the right one:

8189689: JavaFX build fails with gcc 6 [1]

Pankaj will send a backport request for this tomorrow. We should get 
this one in ASAP since 8u-dev is unable to compile on Ubuntu 18.04 today.


-- Kevin

[1] https://bugs.openjdk.java.net/browse/JDK-8189689


On 10/11/2018 8:28 AM, Kevin Rushforth wrote:
We use gcc 7.3 (and Oracle Linux 6 / 7) for our Hudson builds of FX 8 
and don't see this problem. Pankaj asked about backporting the fix for 
that JDK-8203884, but I suggested it wasn't needed, since it is 
unrelated to this change.


It sounds like we should backport JDK-8203884, though I prefer it as a 
separate fix not tied to the GTK 3 work.


-- Kevin


On 10/11/2018 3:35 AM, Johan Vos wrote:

Hi Pankaj,

What gcc version did you use to build on Ubuntu 18.04? Default, I 
think gcc 7.3 is used in 18.04 and that has the issue with wait() in

modules/fxpackager/src/main/native/library/common/PosixPlatform.cpp
(which was later replaced with
wait(&status);
)

This is blocking me to build 8u-dev on Ubuntu 18.04.
On Ubuntu 16.04, there are no issues and it works fine there.

- Johan

On Wed, Oct 10, 2018 at 5:10 PM Pankaj Bansal 
mailto:pankaj.b.ban...@oracle.com>> wrote:


    Hi Kevin,

    Thanks for review and the information provided.

    I have updated the webrev for the proposed change from RTLD_GLOBAL
    to RTLD_LOCAL in launcher.c. Along with the this change, the new
    patch also includes the backport of two more fixes mentioned
    below. So now we have backported total of 20 bugs.

    19. JDK-8171985: Fx applet fails to get loaded on Ubuntu with
    jre9-b150
    20. JDK-8171928: Build fails on Oracle Linux 7 with unused
    parameter warning

    I have tested it on all three platforms (Windows 10, Linux (Ubuntu
    18.4 LTS, Ubuntu 16.04 LTS) and and Mac) and no new test failures
    are found. I have tested the "HelloWebView" and "Ensemble" and I
    don't see any issue. I did some sanity testing on OL 7.5 as well
    and things look good to me.

    Webrev:
http://cr.openjdk.java.net/~pbansal/gtk3_JFX_backport/webrev.01/


    Regards,
    Pankaj


    -Original Message-
    From: Kevin Rushforth
    Sent: Thursday, October 4, 2018 7:41 AM
    To: Pankaj Bansal; openjfx-dev@openjdk.java.net
    
    Subject: Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional
    support for GTK 3 on Linux

    I debugged this offline earlier today, and it looks related to a
    collision in the glib library. As I mentioned offline, a possible
    solution is to remove RTLD_GLOBAL from the dlopen of the
    libglassgtk{2,3}.so library. I was able to do a full build / test
    on both GTK 2 and GTK 3 including media and webkit with that
    modification.

    Overall, this is looking quite good.

    One more thing: the patch adds several new tests, so you will need
    to run at least the new tests on all three platforms (a quick
    check on Mac shows a couple failures).

    I also see a couple differences between jfx-dev and 8u-dev in the
    native code that should be looked into to make sure there wasn't a
    missed fix on the backport (the Hi-DPI diffs are expected, but I
    see a couple others).

    -- Kevin


    On 10/3/2018 10:16 AM, Kevin Rushforth wrote:
    > My initial testing shows a couple problems which will need to be
    > resolved:
    >
    > 1) I get many GTK warnings relating to Pango when running
    HelloWebView
    > 2) Running any program that uses media crashes
    >
    > This is on Ubuntu 16.04 LTS using the default GTK 2 mode.
    >
    > -- Kevin
    >
    >
    > On 10/3/2018 3:26 AM, Pankaj Bansal wrote:
    >>
    >> Hi All,
    >>
    >> Please review the patch for 8u-dev backport for JDK-8087516
    >> . It adds
    >> conditional support for gtk3.
    >>
    >> Along with the enhancement, following bug fixes have also been
    >> included in the backport webrev
    >>
    >> 1.https://bugs.openjdk.java.net/browse/JDK-8159892: [GTK3] 
invalid

    >> rendering of FX app stage in case of scaling
    >>
    >> 2.https://bugs.openjdk.java.net/browse/JDK-8163496: Rework
    Glass GTK
    >> to correct gtk3 structure sizes
    >>
    >> 3.https://bugs.openjdk.java.net/browse/JDK-8145837: Remove
    deprecated
    >> GTK2 calls in JavaFX
    >>
    >> 4.https://bugs.openjdk.java.net/browse/JDK-8165562: Upgrade to
    newer
    >> version of SWT for build/test
    >>
    >> 5.https://bugs.openjdk.java.net/browse/JDK-8171330: Issues with
    >> transparent stage and GTK
    >>
    >> 6.https://bugs.openjdk.java.net/browse/JDK-8171976: Linux: JavaFX
    >> window not painted with background when using GTK 3
    >>
    >> 7.https://bugs.openjdk.java.net/browse/JDK-8166414: Scene returns
    >> incorrect coordinates
    >>
    >> 8.https://bugs.openjdk.java.net/bro

Window opening glitch on ubuntu 18.04

2018-10-11 Thread Thiago Milczarek Sayão


I have migrated our development environment from java-10 javafx to
java-11 and openjfx-11.

One thing I have noticed is that windows opens on the top left corner
of the screen and than moves to a center location. The weird thing is
that we can see the window moving. It appears to be a glitch.

This also happened on java-10 with the bundled javafx when setting it
to use gtk-3 instead of gtk-2.

So it appears to be a gtk-3 bug/glitch.

We use x.org (not wayland).





Re: Window opening glitch on ubuntu 18.04

2018-10-11 Thread Kevin Rushforth
Someone reported a similar issue with a differrent Linux distro (Manjaro 
17.1.12) also related to GTK 3:


https://github.com/javafxports/openjdk-jfx/issues/217

I'll file a JBS bug for this. In the mean time, you can add a comment to 
the above GitHub issue if you like.


-- Kevin


On 10/11/2018 10:03 AM, Thiago Milczarek Sayão wrote:

I have migrated our development environment from java-10 javafx to
java-11 and openjfx-11.

One thing I have noticed is that windows opens on the top left corner
of the screen and than moves to a center location. The weird thing is
that we can see the window moving. It appears to be a glitch.

This also happened on java-10 with the bundled javafx when setting it
to use gtk-3 instead of gtk-2.

So it appears to be a gtk-3 bug/glitch.

We use x.org (not wayland).







Re: Window opening glitch on ubuntu 18.04

2018-10-11 Thread Kevin Rushforth

https://bugs.openjdk.java.net/browse/JDK-8212060


On 10/11/2018 10:10 AM, Kevin Rushforth wrote:
Someone reported a similar issue with a differrent Linux distro 
(Manjaro 17.1.12) also related to GTK 3:


https://github.com/javafxports/openjdk-jfx/issues/217

I'll file a JBS bug for this. In the mean time, you can add a comment 
to the above GitHub issue if you like.


-- Kevin


On 10/11/2018 10:03 AM, Thiago Milczarek Sayão wrote:

I have migrated our development environment from java-10 javafx to
java-11 and openjfx-11.

One thing I have noticed is that windows opens on the top left corner
of the screen and than moves to a center location. The weird thing is
that we can see the window moving. It appears to be a glitch.

This also happened on java-10 with the bundled javafx when setting it
to use gtk-3 instead of gtk-2.

So it appears to be a gtk-3 bug/glitch.

We use x.org (not wayland).









Re: Window opening glitch on ubuntu 18.04

2018-10-11 Thread Kevin Rushforth

And this was reported even earlier at:

https://github.com/javafxports/openjdk-jfx/issues/129

also with Ubuntu 18.04. I have added a pointer to both in the JBS bug.

-- Kevin


On 10/11/2018 10:16 AM, Kevin Rushforth wrote:

https://bugs.openjdk.java.net/browse/JDK-8212060


On 10/11/2018 10:10 AM, Kevin Rushforth wrote:
Someone reported a similar issue with a differrent Linux distro 
(Manjaro 17.1.12) also related to GTK 3:


https://github.com/javafxports/openjdk-jfx/issues/217

I'll file a JBS bug for this. In the mean time, you can add a comment 
to the above GitHub issue if you like.


-- Kevin


On 10/11/2018 10:03 AM, Thiago Milczarek Sayão wrote:

I have migrated our development environment from java-10 javafx to
java-11 and openjfx-11.

One thing I have noticed is that windows opens on the top left corner
of the screen and than moves to a center location. The weird thing is
that we can see the window moving. It appears to be a glitch.

This also happened on java-10 with the bundled javafx when setting it
to use gtk-3 instead of gtk-2.

So it appears to be a gtk-3 bug/glitch.

We use x.org (not wayland).











Re: Window opening glitch on ubuntu 18.04

2018-10-11 Thread Sverre Moe
Den tor. 11. okt. 2018 kl. 19:17 skrev Kevin Rushforth <
kevin.rushfo...@oracle.com>:

> https://bugs.openjdk.java.net/browse/JDK-8212060
>
>
I have not noticed this on OpenSUSE Leap 15. The window pop up right in the
center of my screen in an instant.
NVIDIA graphics with NVIDIA proprietary drivers.

Running my modular test application on Java 11 and JavaFX 11.
https://github.com/DJViking/FxMovies.git

/Sverre


Re: Window opening glitch on ubuntu 18.04

2018-10-11 Thread Sverre Moe
Den tor. 11. okt. 2018 kl. 19:32 skrev Sverre Moe :

> Den tor. 11. okt. 2018 kl. 19:17 skrev Kevin Rushforth <
> kevin.rushfo...@oracle.com>:
>
>> https://bugs.openjdk.java.net/browse/JDK-8212060
>>
>>
> I have not noticed this on OpenSUSE Leap 15. The window pop up right in
> the center of my screen in an instant.
> NVIDIA graphics with NVIDIA proprietary drivers.
>
> Running my modular test application on Java 11 and JavaFX 11.
> https://github.com/DJViking/FxMovies.git
>
> /Sverre
>
>
I did however noticed for a split second that a dialog I opened was in the
upper left corner. It was hardly noticeable.

/Sverre


[RFR][8u-dev] : JDK-8189689 : JavaFX build fails with gcc 6

2018-10-11 Thread Pankaj Bansal
Hi Kevin, 

 

Please review the backport fix for HYPERLINK 
"https://bugs.openjdk.java.net/browse/JDK-8189689"JDK-8189689.

Webrev: http://cr.openjdk.java.net/~pbansal/8189689/webrev.00/

 

 

Thanks,

Pankaj

 


Re: [RFR][8u-dev] : JDK-8189689 : JavaFX build fails with gcc 6

2018-10-11 Thread Kevin Rushforth

Looks good.

+1

I'll push it tomorrow morning my time.

-- Kevin


On 10/11/2018 12:53 PM, Pankaj Bansal wrote:


Hi Kevin,

Please review the backport fix for JDK-8189689 
.


Webrev: http://cr.openjdk.java.net/~pbansal/8189689/webrev.00/ 



Thanks,

Pankaj