openjfx contribution documentation

[Cirujano Cuesta, Diego]

Hi all!

We are surprised about the documentation of JavaFX. We could not make a test in 
openjfx running in the IDE:

We followed the following the instructions: 
https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX

Here we used the following Ubuntu packages:

sudo apt install ksh libasound2-dev libgl1-mesa-dev libgstreamer1.0-dev 
libgstreamer-plugins-base1.0-dev libjpeg-dev libpng-dev libx11-dev 
libxml2-dev libxslt1-dev libxt-dev libxxf86vm-dev pkg-config 
x11proto-core-dev x11proto-xf86vidmode-dev libavcodec-dev mercurial 
libgtk2.0-dev libgtk-3-dev libxtst-dev libudev-dev libavformat-dev

(1)We used libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev instead of 
versions 0.1 as specified in the documentation. We also achieve to build 
openjfx in Ubuntu 18.04 LTS(without webview). Could we update the documentation 
to Ubuntu 18.04?

$ bash ./gradlew

Builds correctly.

Following https://wiki.openjdk.java.net/display/OpenJFX/Committing+the+Code :
$ bash ./gradlew clean sdk apps test -x :web:test

also works.

But when we try to develop in Intellij, it does not work properly. We followed 
the following steps:

https://wiki.openjdk.java.net/display/OpenJFX/Using+an+IDE#UsinganIDE-UsingIntelliJIDEA

(2)And we cannot build in the IDE. Dependency problems. We achieved to make it 
works somehow but it does not make sense to have the .idea in the repo if it 
does not work/help. It is confusing.

Could we update the documentation as I mention in (1) -I would do it but I do 
not have the rights/pull request to do it-, the gradle commands(make use of the 
gradle wrapper), the .idea configuration(2).

I think documentation is very important and must be up-to-date. This is the way 
to get contributions. We wanted to create 2 pull request but we spent the 
available time analyzing why the tests were not working.

I would like to create a VM with the javafx development setup(It will be around 
9GB). I think it will help to contribute to JavaFX. What do you think?

Thank you very much!

Diego

Gradle plugin dependency problem

[Lennart Börjeson]

Is this the right place to ask questions on the gradle plugin 
(org.openjfx.javafxplugin) ?

I'm trying to migrate to Java 11 and openjfx. I have a gradle setup with 
multiple projects, which seems to be problematic.

Base: Mostly non-GUI, code but still some references to javafx
GUI: The javafx GUI, depends on Base
Release: Release artefact packaging, depends on both Base and GUI.

The basic problem seems to be I can't use the org.openjfx.javafxplugin in a 
project which another projects depends on, since the plugin apparently injects 
the javafx library artefacts *after" the configuration phase.


The relevant section of my build.gradle in the Base project is:


---BEGIN--

plugins {
  id 'java'
  id 'maven'
  id 'application'
  id 'wrapper'
  id 'eclipse'
  id "me.champeau.gradle.jmh" version '0.4.6'
  id 'org.openjfx.javafxplugin' version '0.0.5'
}

javafx {
modules = [ 'javafx.controls' ]
}

--END-


If I remove the javafx section, the gradle can execute, but my project won't 
build. :-(

(I can't resolve this by moving all javafx usage to the GUI project, since the 
Release project (release artefact packaging) would still depend on GUI.)


Cf. error below:





$ ./gradlew build

> Configure project :
allProjects: Base: project.version=1.6.10-SNAPSHOT
allProjects: GUI: project.version=1.6.10-SNAPSHOT
allProjects: Release: project.version=1.6.10-SNAPSHOT

> Configure project :Base
test: configure

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':Base'.
> Cannot change dependencies of configuration ':Base:compile' after it has been 
> included in dependency resolution.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1s

JavaFX Media module crashes jdeps

[Scott Palmer]

I use a Gradle script to run jdeps to get a module list for jlink.

This command line (excuse the long paths into the Gradle cache):

jdeps --print-module-deps --module-path 
C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-fxml\11.0.1\2ef70dd2fee84fa4f18c9cbdcabe91e93e8b08ea\javafx-fxml-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-web\11.0.1\4912c3f5184d1bea0f8d25af976aab1a521081ac\javafx-web-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-controls\11.0.1\c4a7cbfbb28713a29883f7c1c3433b841239f8e7\javafx-controls-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-controls\11.0.1\61cf91bf3494d0616216f49c9e1d183d170adf0a\javafx-controls-11.0.1.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-swing\11.0.1\c02350b12b940cb6ed14f1755e056c6e557f8b48\javafx-swing-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-media\11.0.1\d261eabc16e8037e403785dcd822b9d42079dc42\javafx-media-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-media\11.0.1\fd095047b7d06f6c7b16afe8cf9dffccab5d4494\javafx-media-11.0.1.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-graphics\11.0.1\8ec761df8ab0df38ea43f4e7a3018a2991f786f6\javafx-graphics-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-graphics\11.0.1\e062cb01783effc6413abbd94d1838f6b0add209\javafx-graphics-11.0.1.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-base\11.0.1\24f4f0f3a4c3e1ea536e463781fe799e3a7ac857\javafx-base-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-base\11.0.1\f1354a284f4151d20358e776f6ff68ee35bbb96d\javafx-base-11.0.1.jar
 C:\path\to\my\Application.jar

Causes this exception:
Exception in thread "main" java.lang.NullPointerException
at 
jdk.jdeps/com.sun.tools.jdeps.ModuleGraphBuilder.requiresTransitive(ModuleGraphBuilder.java:124)
at 
jdk.jdeps/com.sun.tools.jdeps.ModuleGraphBuilder.buildGraph(ModuleGraphBuilder.java:110)
at 
jdk.jdeps/com.sun.tools.jdeps.ModuleGraphBuilder.reduced(ModuleGraphBuilder.java:65)
at 
jdk.jdeps/com.sun.tools.jdeps.ModuleExportsAnalyzer.modules(ModuleExportsAnalyzer.java:124)
at 
jdk.jdeps/com.sun.tools.jdeps.ModuleExportsAnalyzer.run(ModuleExportsAnalyzer.java:97)
at 
jdk.jdeps/com.sun.tools.jdeps.JdepsTask$ListModuleDeps.run(JdepsTask.java:1023)
at jdk.jdeps/com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:560)
at jdk.jdeps/com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:519)
at jdk.jdeps/com.sun.tools.jdeps.Main.main(Main.java:49)

Without the JavaFX modules listed the output works fine.

So I started to narrow it down and found that javafx-media-11.0.1-win.jar seems 
to cause the exception

If I make a Java runtime that includes the same JavaFX modules (with media) and 
use --system instead of --module-path it also works fine.

Got any ideas what might be going on?

Thanks,

Scott

Re: JavaFX Media module crashes jdeps

[Kevin Rushforth]

I guess you are running into:

https://bugs.openjdk.java.net/browse/JDK-8211887

-- Kevin

On 12/3/2018 9:21 AM, Scott Palmer wrote:

I use a Gradle script to run jdeps to get a module list for jlink.

This command line (excuse the long paths into the Gradle cache):

jdeps --print-module-deps --module-path 
C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-fxml\11.0.1\2ef70dd2fee84fa4f18c9cbdcabe91e93e8b08ea\javafx-fxml-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-web\11.0.1\4912c3f5184d1bea0f8d25af976aab1a521081ac\javafx-web-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-controls\11.0.1\c4a7cbfbb28713a29883f7c1c3433b841239f8e7\javafx-controls-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-controls\11.0.1\61cf91bf3494d0616216f49c9e1d183d170adf0a\javafx-controls-11.0.1.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-swing\11.0.1\c02350b12b940cb6ed14f1755e056c6e557f8b48\javafx-swing-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-media\11.0.1\d261eabc16e8037e403785dcd822b9d42079dc42\javafx-media-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-media\11.0.1\fd095047b7d06f6c7b16afe8cf9dffccab5d4494\javafx-media-11.0.1.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-graphics\11.0.1\8ec761df8ab0df38ea43f4e7a3018a2991f786f6\javafx-graphics-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-graphics\11.0.1\e062cb01783effc6413abbd94d1838f6b0add209\javafx-graphics-11.0.1.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-base\11.0.1\24f4f0f3a4c3e1ea536e463781fe799e3a7ac857\javafx-base-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-base\11.0.1\f1354a284f4151d20358e776f6ff68ee35bbb96d\javafx-base-11.0.1.jar
 C:\path\to\my\Application.jar

Causes this exception:
Exception in thread "main" java.lang.NullPointerException
 at 
jdk.jdeps/com.sun.tools.jdeps.ModuleGraphBuilder.requiresTransitive(ModuleGraphBuilder.java:124)
 at 
jdk.jdeps/com.sun.tools.jdeps.ModuleGraphBuilder.buildGraph(ModuleGraphBuilder.java:110)
 at 
jdk.jdeps/com.sun.tools.jdeps.ModuleGraphBuilder.reduced(ModuleGraphBuilder.java:65)
 at 
jdk.jdeps/com.sun.tools.jdeps.ModuleExportsAnalyzer.modules(ModuleExportsAnalyzer.java:124)
 at 
jdk.jdeps/com.sun.tools.jdeps.ModuleExportsAnalyzer.run(ModuleExportsAnalyzer.java:97)
 at 
jdk.jdeps/com.sun.tools.jdeps.JdepsTask$ListModuleDeps.run(JdepsTask.java:1023)
 at jdk.jdeps/com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:560)
 at jdk.jdeps/com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:519)
 at jdk.jdeps/com.sun.tools.jdeps.Main.main(Main.java:49)

Without the JavaFX modules listed the output works fine.

So I started to narrow it down and found that javafx-media-11.0.1-win.jar seems 
to cause the exception

If I make a Java runtime that includes the same JavaFX modules (with media) and 
use --system instead of --module-path it also works fine.

Got any ideas what might be going on?

Thanks,

Scott

Re: JavaFX Media module crashes jdeps

[Kevin Rushforth]

I should add that fixing the following bug in JavaFX should avoid the 
problem:


https://bugs.openjdk.java.net/browse/JDK-8211900

It's on my list to fix for openjfx12.

-- Kevin


On 12/3/2018 9:27 AM, Kevin Rushforth wrote:

I guess you are running into:

https://bugs.openjdk.java.net/browse/JDK-8211887

-- Kevin

On 12/3/2018 9:21 AM, Scott Palmer wrote:

I use a Gradle script to run jdeps to get a module list for jlink.

This command line (excuse the long paths into the Gradle cache):

jdeps --print-module-deps --module-path 
C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-fxml\11.0.1\2ef70dd2fee84fa4f18c9cbdcabe91e93e8b08ea\javafx-fxml-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-web\11.0.1\4912c3f5184d1bea0f8d25af976aab1a521081ac\javafx-web-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-controls\11.0.1\c4a7cbfbb28713a29883f7c1c3433b841239f8e7\javafx-controls-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-controls\11.0.1\61cf91bf3494d0616216f49c9e1d183d170adf0a\javafx-controls-11.0.1.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-swing\11.0.1\c02350b12b940cb6ed14f1755e056c6e557f8b48\javafx-swing-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-media\11.0.1\d261eabc16e8037e403785dcd822b9d42079dc42\javafx-media-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-media\11.0.1\fd095047b7d06f6c7b16afe8cf9dffccab5d4494\javafx-media-11.0.1.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-graphics\11.0.1\8ec761df8ab0df38ea43f4e7a3018a2991f786f6\javafx-graphics-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-graphics\11.0.1\e062cb01783effc6413abbd94d1838f6b0add209\javafx-graphics-11.0.1.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-base\11.0.1\24f4f0f3a4c3e1ea536e463781fe799e3a7ac857\javafx-base-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-base\11.0.1\f1354a284f4151d20358e776f6ff68ee35bbb96d\javafx-base-11.0.1.jar 
C:\path\to\my\Application.jar


Causes this exception:
Exception in thread "main" java.lang.NullPointerException
 at 
jdk.jdeps/com.sun.tools.jdeps.ModuleGraphBuilder.requiresTransitive(ModuleGraphBuilder.java:124)
 at 
jdk.jdeps/com.sun.tools.jdeps.ModuleGraphBuilder.buildGraph(ModuleGraphBuilder.java:110)
 at 
jdk.jdeps/com.sun.tools.jdeps.ModuleGraphBuilder.reduced(ModuleGraphBuilder.java:65)
 at 
jdk.jdeps/com.sun.tools.jdeps.ModuleExportsAnalyzer.modules(ModuleExportsAnalyzer.java:124)
 at 
jdk.jdeps/com.sun.tools.jdeps.ModuleExportsAnalyzer.run(ModuleExportsAnalyzer.java:97)
 at 
jdk.jdeps/com.sun.tools.jdeps.JdepsTask$ListModuleDeps.run(JdepsTask.java:1023)
 at 
jdk.jdeps/com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:560)
 at 
jdk.jdeps/com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:519)

 at jdk.jdeps/com.sun.tools.jdeps.Main.main(Main.java:49)

Without the JavaFX modules listed the output works fine.

So I started to narrow it down and found that 
javafx-media-11.0.1-win.jar seems to cause the exception


If I make a Java runtime that includes the same JavaFX modules (with 
media) and use --system instead of --module-path it also works fine.


Got any ideas what might be going on?

Thanks,

Scott

[12] RFR : JDK-8214035 : Unable to render cmyk jpeg image

[Ambarish Rapte]

Hi,

 

Please take a look at this bug fix,

Webrev: http://cr.openjdk.java.net/~arapte/fx/8214035/webrev.00/

JBS: https://bugs.openjdk.java.net/browse/JDK-8214035 

 

Regards,

Ambarish

Re: JavaFX Media module crashes jdeps

[Scott Palmer]

Thanks, that does seem to be the issue.

Is this the sort of thing that might be back-ported to a 11.0.2 release?
I'm trying to automate as much of my build as possible and special casing
stuff to work around issues like this makes things a bit messy.  It's just
one of several little things that is making moving beyond JDK 8 a rather
tedious affair.  Almost there though...

Cheers,
Scott


On Mon, Dec 3, 2018 at 12:45 PM Kevin Rushforth 
wrote:

> I should add that fixing the following bug in JavaFX should avoid the
> problem:
>
> https://bugs.openjdk.java.net/browse/JDK-8211900
>
> It's on my list to fix for openjfx12.
>
> -- Kevin
>
>
> On 12/3/2018 9:27 AM, Kevin Rushforth wrote:
> > I guess you are running into:
> >
> > https://bugs.openjdk.java.net/browse/JDK-8211887
> >
> > -- Kevin
> >
> > On 12/3/2018 9:21 AM, Scott Palmer wrote:
> >> I use a Gradle script to run jdeps to get a module list for jlink.
> >>
> >> This command line (excuse the long paths into the Gradle cache):
> >>
> >> jdeps --print-module-deps --module-path
> >>
> C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-fxml\11.0.1\2ef70dd2fee84fa4f18c9cbdcabe91e93e8b08ea\javafx-fxml-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-web\11.0.1\4912c3f5184d1bea0f8d25af976aab1a521081ac\javafx-web-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-controls\11.0.1\c4a7cbfbb28713a29883f7c1c3433b841239f8e7\javafx-controls-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-controls\11.0.1\61cf91bf3494d0616216f49c9e1d183d170adf0a\javafx-controls-11.0.1.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-swing\11.0.1\c02350b12b940cb6ed14f1755e056c6e557f8b48\javafx-swing-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-media\11.0.1\d261eabc16e8037e403785dcd822b9d42079dc42\javafx-media-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-media\11.0.1\fd095047b7d06f6c7b16afe8cf9dffccab5d4494\javafx-media-11.0.1.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-graphics\11.0.1\8ec761df8ab0df38ea43f4e7a3018a2991f786f6\javafx-graphics-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-graphics\11.0.1\e062cb01783effc6413abbd94d1838f6b0add209\javafx-graphics-11.0.1.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-base\11.0.1\24f4f0f3a4c3e1ea536e463781fe799e3a7ac857\javafx-base-11.0.1-win.jar;C:\Users\spalmer\.gradle\caches\modules-2\files-2.1\org.openjfx\javafx-base\11.0.1\f1354a284f4151d20358e776f6ff68ee35bbb96d\javafx-base-11.0.1.jar
>
> >> C:\path\to\my\Application.jar
> >>
> >> Causes this exception:
> >> Exception in thread "main" java.lang.NullPointerException
> >>  at
> >>
> jdk.jdeps/com.sun.tools.jdeps.ModuleGraphBuilder.requiresTransitive(ModuleGraphBuilder.java:124)
> >>  at
> >>
> jdk.jdeps/com.sun.tools.jdeps.ModuleGraphBuilder.buildGraph(ModuleGraphBuilder.java:110)
> >>  at
> >>
> jdk.jdeps/com.sun.tools.jdeps.ModuleGraphBuilder.reduced(ModuleGraphBuilder.java:65)
> >>  at
> >>
> jdk.jdeps/com.sun.tools.jdeps.ModuleExportsAnalyzer.modules(ModuleExportsAnalyzer.java:124)
> >>  at
> >>
> jdk.jdeps/com.sun.tools.jdeps.ModuleExportsAnalyzer.run(ModuleExportsAnalyzer.java:97)
> >>  at
> >>
> jdk.jdeps/com.sun.tools.jdeps.JdepsTask$ListModuleDeps.run(JdepsTask.java:1023)
> >>  at
> >> jdk.jdeps/com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:560)
> >>  at
> >> jdk.jdeps/com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:519)
> >>  at jdk.jdeps/com.sun.tools.jdeps.Main.main(Main.java:49)
> >>
> >> Without the JavaFX modules listed the output works fine.
> >>
> >> So I started to narrow it down and found that
> >> javafx-media-11.0.1-win.jar seems to cause the exception
> >>
> >> If I make a Java runtime that includes the same JavaFX modules (with
> >> media) and use --system instead of --module-path it also works fine.
> >>
> >> Got any ideas what might be going on?
> >>
> >> Thanks,
> >>
> >> Scott
> >>
> >
> >
>
>
>

JavaFX fails to build with multiple different issues

[Ty Young]

So here is an odd one: JavaFX is now longer building on Arch Linux even 
on a previous source directory that did compile just fine. I'm guessing 
that something was updated and isn't compatible with JavaFX's build 
scripts but I'm not entirely sure what exactly it is.



(Note: just to make sure the files didn't magically become corrupt or 
something I redownloaded from the Github mirror. Same issue.)



First error is this:


~/openjdk-jfx-develop/buildSrc/src/main/groovy/com/sun/javafx/gradle/NativeCompileTask.groovy: 
118: The variable [files] is declared final but is reassigned

. At [118:21]  @ line 118, column 21.
   files += file;


which is easy enough to fix by simply removing final from line 105. Even 
though this was clearly an issue(why use final on local variables? I've 
never understood why people do it...), I'm not entirely sure why it's 
throwing an error now. Is it because Groovy is a scripting language and 
the build scripts never used to follow that logic path?



Next issue is this:


> Could not get unknown property 'moduleEmptyPublicationJarLinux' for 
task set of type org.gradle.api.internal.tasks.DefaultTaskContainer



which I'm not sure on how to resolve. Thinking that it may be related to 
my custom built JDK I tried swapping it out for an older one that I know 
worked before and yet it fails all the same.

Re: JavaFX fails to build with multiple different issues

[Michael Ennen]

The first one is definitely a bug and I would consider opening a PR to
remove
the final modifier on https://github.com/javafxports/openjdk-jfx.

The second one is a gradle error - what gradle command-line invocation
are you using?

On Mon, Dec 3, 2018 at 4:58 PM Ty Young  wrote:

> So here is an odd one: JavaFX is now longer building on Arch Linux even
> on a previous source directory that did compile just fine. I'm guessing
> that something was updated and isn't compatible with JavaFX's build
> scripts but I'm not entirely sure what exactly it is.
>
>
> (Note: just to make sure the files didn't magically become corrupt or
> something I redownloaded from the Github mirror. Same issue.)
>
>
> First error is this:
>
>
> ~/openjdk-jfx-develop/buildSrc/src/main/groovy/com/sun/javafx/gradle/NativeCompileTask.groovy:
>
> 118: The variable [files] is declared final but is reassigned
> . At [118:21]  @ line 118, column 21.
> files += file;
>
>
> which is easy enough to fix by simply removing final from line 105. Even
> though this was clearly an issue(why use final on local variables? I've
> never understood why people do it...), I'm not entirely sure why it's
> throwing an error now. Is it because Groovy is a scripting language and
> the build scripts never used to follow that logic path?
>
>
> Next issue is this:
>
>
>  > Could not get unknown property 'moduleEmptyPublicationJarLinux' for
> task set of type org.gradle.api.internal.tasks.DefaultTaskContainer
>
>
> which I'm not sure on how to resolve. Thinking that it may be related to
> my custom built JDK I tried swapping it out for an older one that I know
> worked before and yet it fails all the same.
>
>

-- 
Michael Ennen

Re: JavaFX fails to build with multiple different issues

[Ty Young]

On 12/3/18 6:52 PM, Michael Ennen wrote:
The first one is definitely a bug and I would consider opening a PR to 
remove

the final modifier on https://github.com/javafxports/openjdk-jfx.



Done.  This is the 
first time I've ever done a PR request so if there is anything wrong 
besides not signing away my left kidney with my own blood then let me 
know(/joke). I don't think it has any negative impact seeing as how the 
code requires the instance to be mutable anyway unless this really is a 
different code path from before(why would it be?) but I can't exactly 
check either way until I can compile and it's wrong either way.






The second one is a gradle error - what gradle command-line invocation
are you using?



"gradle build" though just doing "gradle" or even "gradle clean" results 
in the same fail. All tasks are borked would be my guess.





On Mon, Dec 3, 2018 at 4:58 PM Ty Young > wrote:


So here is an odd one: JavaFX is now longer building on Arch Linux
even
on a previous source directory that did compile just fine. I'm
guessing
that something was updated and isn't compatible with JavaFX's build
scripts but I'm not entirely sure what exactly it is.


(Note: just to make sure the files didn't magically become corrupt or
something I redownloaded from the Github mirror. Same issue.)


First error is this:



~/openjdk-jfx-develop/buildSrc/src/main/groovy/com/sun/javafx/gradle/NativeCompileTask.groovy:

118: The variable [files] is declared final but is reassigned
. At [118:21]  @ line 118, column 21.
    files += file;


which is easy enough to fix by simply removing final from line
105. Even
though this was clearly an issue(why use final on local variables?
I've
never understood why people do it...), I'm not entirely sure why it's
throwing an error now. Is it because Groovy is a scripting
language and
the build scripts never used to follow that logic path?


Next issue is this:


 > Could not get unknown property 'moduleEmptyPublicationJarLinux'
for
task set of type org.gradle.api.internal.tasks.DefaultTaskContainer


which I'm not sure on how to resolve. Thinking that it may be
related to
my custom built JDK I tried swapping it out for an older one that
I know
worked before and yet it fails all the same.



--
Michael Ennen