Re: RFR: 8231372: Correctly terminate secondary event loop in JFXPanel.setScene()
On Thu, 17 Oct 2019 15:28:31 GMT, Kevin Rushforth wrote: > On Thu, 17 Oct 2019 15:28:30 GMT, mruzicka > wrote: > >> On Thu, 17 Oct 2019 15:28:28 GMT, mruzicka >> wrote: >> >>> Secondary event loop introduced as a means of synchronization with the >>> JavaFX Application thread in [1] never terminates as the >>> SecondaryLoop.exit() call is not reached because the thread is blocked in >>> the SecondaryLoop.enter() call. >>> This patch fixes the problem by submitting the UI work (including the call >>> to the SecondaryLoop.exit() method) before entering the secondary loop. >>> >>> [1] >>> https://github.com/openjdk/jfx/commit/7cf2dfa0b3c5bfd0f1a2de36d46b62f7e9e256c4 >>> >>> >>> >>> Commits: >>> - 9483ccde: 8231372: Correctly terminate secondary event loop in >>> JFXPanel.setScene() >>> >>> Changes: https://git.openjdk.java.net/jfx/pull/16/files >>> Webrev: https://webrevs.openjdk.java.net/jfx/16/webrev.00 >>> Issue: https://bugs.openjdk.java.net/browse/JDK-8231372 >>> Stats: 6 lines in 1 file changed: 1 ins; 2 del; 3 mod >>> Patch: https://git.openjdk.java.net/jfx/pull/16.diff >>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/16/head:pull/16 >> >> @kevinrushforth I believe you should be able to move forward with the review >> of this PR now as I've filed a bug report for the problem and signed the OCA >> as required. (As I did not know I needed to have my github account >> associated with the OCA, I did not include it in my details. I've asked >> Dalibor Topic from the Java SE PM team to help me have that fixed or get in >> touch with you to confirm my signing of the OCA.) > > @mruzicka once Dalibor connects your OCA with your GitHub account, this > review will be able to proceed. Do you have a test program that shows the bug? Also, can you take a look at whether you could turn the test case into an automated test? PR: https://git.openjdk.java.net/jfx/pull/16
Re: Request for permission to backport fixes to jfx-11
> JDK-8193502 Johan can comment on whether he wants to backport it. As noted below, someone reported a regression associated with it when using gtk2, but we don't have a bug filed or a test case. > It might have been solved in the fix for JDK-8179073. Not sure what you mean since JDK-8179073 is still an open bug and thus is not a solved issue (although it might be worth re-testing after the fix for JDK-8179073). -- Kevin On 10/21/2019 1:08 PM, Sverre Moe wrote: Could JavaFX 11 also get backported the fix related for JDK-8193502? It might have been solved in the fix for JDK-8179073. I noticed this regression right after JDK 9 build 161. Recently also JavaFX 8 got this regression after update 181. It seems this was fixed in JavaFX 13. I asked on GitHub in #222 a while back if this could be backported. Considering that repository is now closed, I will repeat it here. Kevin Rushforth wrote: > That's a good question for @johanvos -- it seems this might be a good candidate for backport, although there is one report of a possible regression caused by this fix when using GTK 2 as reported in #475 /Sverre [1] https://bugs.openjdk.java.net/browse/JDK-8193502 [2] https://bugs.openjdk.java.net/browse/JDK-8179073 [3] https://github.com/javafxports/openjdk-jfx/pull/456 [4] https://github.com/javafxports/openjdk-jfx/issues/222 man. 21. okt. 2019 kl. 14:39 skrev Kevin Rushforth mailto:kevin.rushfo...@oracle.com>>: +1 -- Kevin On 10/21/2019 3:16 AM, Johan Vos wrote: > Hi Kevin, > > I request permission to backport the following issues to the jfx-11 > repository. All patches apply clean or with minor changes (e.g. > build.properties must keep jfx.release.major.version to 11) > > Thanks, > > - Johan > > https://bugs.openjdk.java.net/browse/JDK-8221302 : Upgrade to gcc 8.2 on > Linux > https://bugs.openjdk.java.net/browse/JDK-8221299 : Upgrade to Visual Studio > 2017 version 15.9.6 > https://bugs.openjdk.java.net/browse/JDK-8221300 : Upgrade to Xcode 10.1 > https://bugs.openjdk.java.net/browse/JDK-8214716 : Record the versions of > tools used to build FX in the repo > https://bugs.openjdk.java.net/browse/JDK-8222788 : javafx.web build fails > on XCode 10.2 > https://bugs.openjdk.java.net/browse/JDK-8225203 : Update SQLite to version > 3.28.0 > https://bugs.openjdk.java.net/browse/JDK-8219362 : Update to 608.1 version > of WebKit > https://bugs.openjdk.java.net/browse/JDK-8227079 : Cherry pick GTK WebKit > 2.24.3 changes > https://bugs.openjdk.java.net/browse/JDK-8230361 : [web] Cookies are not > enabled in WebKit v608.1 > https://bugs.openjdk.java.net/browse/JDK-8229328 : [windows] > PlatformFileHandle type should be JGObject rather than void * > https://bugs.openjdk.java.net/browse/JDK-8227431 : [Windows] Fix assertion > failure on X86 32-bit when enabling CLOOP based JavaScript interpreter > https://bugs.openjdk.java.net/browse/JDK-8222912 : Websocket client doesn't > work in WebView > https://bugs.openjdk.java.net/browse/JDK-8226537 : Multi-level > Stage::initOwner can crash gnome-shell or X.org server > https://bugs.openjdk.java.net/browse/JDK-8212060 : [GTK3] Stage sometimes > shown at top-left before moving to correct position > https://bugs.openjdk.java.net/browse/JDK-8211302 : DragAndDrop no longer > works with GTK3 > https://bugs.openjdk.java.net/browse/JDK-8213510 : MediaPlayer does not > play some mp3 with artwork stream in mjpeg > https://bugs.openjdk.java.net/browse/JDK-8207942: Add new protected > VirtualFlow methods for subclassing
Re: Request for permission to backport fixes to jfx-11
Could JavaFX 11 also get backported the fix related for JDK-8193502? It might have been solved in the fix for JDK-8179073. I noticed this regression right after JDK 9 build 161. Recently also JavaFX 8 got this regression after update 181. It seems this was fixed in JavaFX 13. I asked on GitHub in #222 a while back if this could be backported. Considering that repository is now closed, I will repeat it here. Kevin Rushforth wrote: > That's a good question for @johanvos -- it seems this might be a good candidate for backport, although there is one report of a possible regression caused by this fix when using GTK 2 as reported in #475 /Sverre [1] https://bugs.openjdk.java.net/browse/JDK-8193502 [2] https://bugs.openjdk.java.net/browse/JDK-8179073 [3] https://github.com/javafxports/openjdk-jfx/pull/456 [4] https://github.com/javafxports/openjdk-jfx/issues/222 man. 21. okt. 2019 kl. 14:39 skrev Kevin Rushforth < kevin.rushfo...@oracle.com>: > +1 > > -- Kevin > > On 10/21/2019 3:16 AM, Johan Vos wrote: > > Hi Kevin, > > > > I request permission to backport the following issues to the jfx-11 > > repository. All patches apply clean or with minor changes (e.g. > > build.properties must keep jfx.release.major.version to 11) > > > > Thanks, > > > > - Johan > > > > https://bugs.openjdk.java.net/browse/JDK-8221302 : Upgrade to gcc 8.2 on > > Linux > > https://bugs.openjdk.java.net/browse/JDK-8221299 : Upgrade to Visual > Studio > > 2017 version 15.9.6 > > https://bugs.openjdk.java.net/browse/JDK-8221300 : Upgrade to Xcode 10.1 > > https://bugs.openjdk.java.net/browse/JDK-8214716 : Record the versions > of > > tools used to build FX in the repo > > https://bugs.openjdk.java.net/browse/JDK-8222788 : javafx.web build > fails > > on XCode 10.2 > > https://bugs.openjdk.java.net/browse/JDK-8225203 : Update SQLite to > version > > 3.28.0 > > https://bugs.openjdk.java.net/browse/JDK-8219362 : Update to 608.1 > version > > of WebKit > > https://bugs.openjdk.java.net/browse/JDK-8227079 : Cherry pick GTK > WebKit > > 2.24.3 changes > > https://bugs.openjdk.java.net/browse/JDK-8230361 : [web] Cookies are not > > enabled in WebKit v608.1 > > https://bugs.openjdk.java.net/browse/JDK-8229328 : [windows] > > PlatformFileHandle type should be JGObject rather than void * > > https://bugs.openjdk.java.net/browse/JDK-8227431 : [Windows] Fix > assertion > > failure on X86 32-bit when enabling CLOOP based JavaScript interpreter > > https://bugs.openjdk.java.net/browse/JDK-8222912 : Websocket client > doesn't > > work in WebView > > https://bugs.openjdk.java.net/browse/JDK-8226537 : Multi-level > > Stage::initOwner can crash gnome-shell or X.org server > > https://bugs.openjdk.java.net/browse/JDK-8212060 : [GTK3] Stage > sometimes > > shown at top-left before moving to correct position > > https://bugs.openjdk.java.net/browse/JDK-8211302 : DragAndDrop no longer > > works with GTK3 > > https://bugs.openjdk.java.net/browse/JDK-8213510 : MediaPlayer does not > > play some mp3 with artwork stream in mjpeg > > https://bugs.openjdk.java.net/browse/JDK-8207942: Add new protected > > VirtualFlow methods for subclassing > >
Re: [Approved] RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing
On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar wrote: > 8232158: [macOS] Fallback to command line tools if xcode is missing > > > > Commits: > - 063d2f38: JDK-8232158: [macOS] Fallback to command line tools if xcode is > missing > > Changes: https://git.openjdk.java.net/jfx/pull/13/files > Webrev: https://webrevs.openjdk.java.net/jfx/13/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8232158 > Stats: 33 lines in 1 file changed: 15 ins; 1 del; 17 mod > Patch: https://git.openjdk.java.net/jfx/pull/13.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/13/head:pull/13 Looks good. This one is simple enough I don't think it needs a second review, although @johanvos might want to review it. Approved by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/13
Re: [Rev 01] RFR: 8232687: No static JNI loader for libprism-sw
On Mon, 21 Oct 2019 11:10:32 GMT, Johan Vos wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - f34a99a3: In order to leverage this on Mac, we need to add -DSTATIC_BUILD > to the cc flags > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/19/files > - new: https://git.openjdk.java.net/jfx/pull/19/files/6f31ee6b..f34a99a3 > > Webrevs: > - full: https://webrevs.openjdk.java.net/jfx/19/webrev.01 > - incr: https://webrevs.openjdk.java.net/jfx/19/webrev.00-01 > > Issue: https://bugs.openjdk.java.net/browse/JDK-8232687 > Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/jfx/pull/19.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/19/head:pull/19 buildSrc/mac.gradle line 173: > 172: MAC.prism.ccFlags = ["-O3", "-DINLINE=inline", "-c", IS_STATIC_BUILD? > "-DSTATIC_BUILD" : "", ccBaseFlags].flatten() > 173: MAC.prism.linker = linker > 174: MAC.prism.linkFlags = linkFlagsAlt Minor: normally we would put a space before the `?` although we are a bit more lax in the gradle files. Up to you whether you want to fix it. PR: https://git.openjdk.java.net/jfx/pull/19
Re: [Approved] RFR: 8232687: No static JNI loader for libprism-sw
On Mon, 21 Oct 2019 10:03:24 GMT, Johan Vos wrote: > This PR adds a JNI_OnLoad_prism_sw call to the static lib libprism_sw.a. > This approach is similar to the addition of e.g. JNI_OnLoad_prism_es2 that > has been done as part of https://bugs.openjdk.java.net/browse/JDK-8223760 > > Unless -PSTATIC_BUILD is provided when building, this patch has no impact. > > > > Commits: > - 6f31ee6b: Add JNI_OnLoad_prism_sw call to make prism-sw work with static > libs > > Changes: https://git.openjdk.java.net/jfx/pull/19/files > Webrev: https://webrevs.openjdk.java.net/jfx/19/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8232687 > Stats: 16 lines in 1 file changed: 16 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/jfx/pull/19.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/19/head:pull/19 Looks good. One minor formatting comment. Approved. This one is simple enough I don't think it needs a second review. Approved by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/19
Re: [Integrated] RFR: 8232522: FX: Update copyright year in docs, readme files to 2020
Changeset: a09a0fa5 Author:Kevin Rushforth Date: 2019-10-21 16:45:26 + URL: https://git.openjdk.java.net/jfx/commit/a09a0fa5 8232522: FX: Update copyright year in docs, readme files to 2020 Reviewed-by: arapte ! build.properties ! modules/javafx.fxml/src/main/docs/javafx/fxml/doc-files/introduction_to_fxml.html ! modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html
Re: [Approved] RFR: 8232522: FX: Update copyright year in docs, readme files to 2020
On Sat, 19 Oct 2019 15:04:27 GMT, Kevin Rushforth wrote: > As indicated in the JBS bug, this makes the needed change for releasing in > 2020. > > > > Commits: > - 85c03ad9: 8232522: FX: Update copyright year in docs, readme files to 2020 > > Changes: https://git.openjdk.java.net/jfx/pull/18/files > Webrev: https://webrevs.openjdk.java.net/jfx/18/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8232522 > Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod > Patch: https://git.openjdk.java.net/jfx/pull/18.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/18/head:pull/18 lgtm Approved by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/18
Re: duplicate symbols in static libraries
Actually, I did a quick check and there is more than just Pisces in the native prism_sw library, so removing Pisces isn't sufficient to remove prism_sw. -- Kevin On 10/21/2019 5:54 AM, Kevin Rushforth wrote: This approach seems fine to me. Worth noting is that prism-sw will be removed as part of the Pisces removal by JDK-8196079 [1], which is targeted for 14. If your proposed change helps in the mean time, then I see no problem with getting it in. -- Kevin [1] https://bugs.openjdk.java.net/browse/JDK-8196079 On 10/21/2019 4:26 AM, Johan Vos wrote: Hi, When creating static libraries for the native parts of JavaFX, I ran into an issue with symbols exposed in more than 1 library: checkAndClearException() is declared and used in both libjavafx_font.a and in libprism_sw.a I have a simple fix for this that adds a prefix to the symbol in the prism-sw code: https://github.com/johanvos/jfx/commit/9180a73b51f60b0c6fe6e89184c4cba88fcf1696 However, I'm not sure this is the generally agreed approach. Are there opinions/guidelines for this? - Johan
Re: RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating
On Mon, 21 Oct 2019 10:19:06 GMT, Robert Lichtenberger wrote: > On Mon, 21 Oct 2019 10:19:05 GMT, Kevin Rushforth wrote: > >> On Mon, 21 Oct 2019 10:19:04 GMT, Robert Lichtenberger >> wrote: >> >>> By using the collection itself as synchronization lock we achieve behaviour >>> that matches java.util.Collections classes. >>> >>> I've create test cases that fail with the current way of synchronizing on a >>> separate object. >>> >>> I've removed unused constructors. >>> >>> >>> >>> Commits: >>> - 7e80839f: 8232524: SynchronizedObservableMap cannot be be protected for >>> copying/iterating >>> - 8ecf3545: JDK-8232524 fixed. >>> >>> Changes: https://git.openjdk.java.net/jfx/pull/17/files >>> Webrev: https://webrevs.openjdk.java.net/jfx/17/webrev.00 >>> Issue: https://bugs.openjdk.java.net/browse/JDK-8232524 >>> Stats: 120 lines in 2 files changed: 95 ins; 17 del; 8 mod >>> Patch: https://git.openjdk.java.net/jfx/pull/17.diff >>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/17/head:pull/17 >> >> You have many whitespace errors in your patch that will need to be fixed >> before `git jcheck` will pass. When you fix them, you can just push a new >> commit. >> >> As an aside, you have uncovered a bug in the Skara PR bot where the >> server-side jcheck fails to complete if there are more than 50 errors. See >> [SKARA-135](https://bugs.openjdk.java.net/browse/SKARA-135). > >> You have many whitespace errors in your patch that will need to be fixed >> before `git jcheck` will pass. When you fix them, you can just push a new >> commit. > > I'm trying to setup skara tools so that I can check changes before committing > in the future. > >> >> As an aside, you have uncovered a bug in the Skara PR bot where the >> server-side jcheck fails to complete if there are more than 50 errors. See >> [SKARA-135](https://bugs.openjdk.java.net/browse/SKARA-135). > > OMG, hope I didn't break things ;-) I think I have corrected the whitespace errors (I can see "All checks have passed"), is there anything else I can / should do for this pull request? PR: https://git.openjdk.java.net/jfx/pull/17
Re: duplicate symbols in static libraries
This approach seems fine to me. Worth noting is that prism-sw will be removed as part of the Pisces removal by JDK-8196079 [1], which is targeted for 14. If your proposed change helps in the mean time, then I see no problem with getting it in. -- Kevin [1] https://bugs.openjdk.java.net/browse/JDK-8196079 On 10/21/2019 4:26 AM, Johan Vos wrote: Hi, When creating static libraries for the native parts of JavaFX, I ran into an issue with symbols exposed in more than 1 library: checkAndClearException() is declared and used in both libjavafx_font.a and in libprism_sw.a I have a simple fix for this that adds a prefix to the symbol in the prism-sw code: https://github.com/johanvos/jfx/commit/9180a73b51f60b0c6fe6e89184c4cba88fcf1696 However, I'm not sure this is the generally agreed approach. Are there opinions/guidelines for this? - Johan
Re: Request for permission to backport fixes to jfx-11
+1 -- Kevin On 10/21/2019 3:16 AM, Johan Vos wrote: Hi Kevin, I request permission to backport the following issues to the jfx-11 repository. All patches apply clean or with minor changes (e.g. build.properties must keep jfx.release.major.version to 11) Thanks, - Johan https://bugs.openjdk.java.net/browse/JDK-8221302 : Upgrade to gcc 8.2 on Linux https://bugs.openjdk.java.net/browse/JDK-8221299 : Upgrade to Visual Studio 2017 version 15.9.6 https://bugs.openjdk.java.net/browse/JDK-8221300 : Upgrade to Xcode 10.1 https://bugs.openjdk.java.net/browse/JDK-8214716 : Record the versions of tools used to build FX in the repo https://bugs.openjdk.java.net/browse/JDK-8222788 : javafx.web build fails on XCode 10.2 https://bugs.openjdk.java.net/browse/JDK-8225203 : Update SQLite to version 3.28.0 https://bugs.openjdk.java.net/browse/JDK-8219362 : Update to 608.1 version of WebKit https://bugs.openjdk.java.net/browse/JDK-8227079 : Cherry pick GTK WebKit 2.24.3 changes https://bugs.openjdk.java.net/browse/JDK-8230361 : [web] Cookies are not enabled in WebKit v608.1 https://bugs.openjdk.java.net/browse/JDK-8229328 : [windows] PlatformFileHandle type should be JGObject rather than void * https://bugs.openjdk.java.net/browse/JDK-8227431 : [Windows] Fix assertion failure on X86 32-bit when enabling CLOOP based JavaScript interpreter https://bugs.openjdk.java.net/browse/JDK-8222912 : Websocket client doesn't work in WebView https://bugs.openjdk.java.net/browse/JDK-8226537 : Multi-level Stage::initOwner can crash gnome-shell or X.org server https://bugs.openjdk.java.net/browse/JDK-8212060 : [GTK3] Stage sometimes shown at top-left before moving to correct position https://bugs.openjdk.java.net/browse/JDK-8211302 : DragAndDrop no longer works with GTK3 https://bugs.openjdk.java.net/browse/JDK-8213510 : MediaPlayer does not play some mp3 with artwork stream in mjpeg https://bugs.openjdk.java.net/browse/JDK-8207942: Add new protected VirtualFlow methods for subclassing
duplicate symbols in static libraries
Hi, When creating static libraries for the native parts of JavaFX, I ran into an issue with symbols exposed in more than 1 library: checkAndClearException() is declared and used in both libjavafx_font.a and in libprism_sw.a I have a simple fix for this that adds a prefix to the symbol in the prism-sw code: https://github.com/johanvos/jfx/commit/9180a73b51f60b0c6fe6e89184c4cba88fcf1696 However, I'm not sure this is the generally agreed approach. Are there opinions/guidelines for this? - Johan
Re: [Rev 01] RFR: 8232687: No static JNI loader for libprism-sw
The pull request has been updated with additional changes. Added commits: - f34a99a3: In order to leverage this on Mac, we need to add -DSTATIC_BUILD to the cc flags Changes: - all: https://git.openjdk.java.net/jfx/pull/19/files - new: https://git.openjdk.java.net/jfx/pull/19/files/6f31ee6b..f34a99a3 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/19/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/19/webrev.00-01 Issue: https://bugs.openjdk.java.net/browse/JDK-8232687 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/19.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/19/head:pull/19 PR: https://git.openjdk.java.net/jfx/pull/19
Re: RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating
On Mon, 21 Oct 2019 10:19:05 GMT, Kevin Rushforth wrote: > On Mon, 21 Oct 2019 10:19:04 GMT, Robert Lichtenberger > wrote: > >> By using the collection itself as synchronization lock we achieve behaviour >> that matches java.util.Collections classes. >> >> I've create test cases that fail with the current way of synchronizing on a >> separate object. >> >> I've removed unused constructors. >> >> >> >> Commits: >> - 7e80839f: 8232524: SynchronizedObservableMap cannot be be protected for >> copying/iterating >> - 8ecf3545: JDK-8232524 fixed. >> >> Changes: https://git.openjdk.java.net/jfx/pull/17/files >> Webrev: https://webrevs.openjdk.java.net/jfx/17/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JDK-8232524 >> Stats: 120 lines in 2 files changed: 95 ins; 17 del; 8 mod >> Patch: https://git.openjdk.java.net/jfx/pull/17.diff >> Fetch: git fetch https://git.openjdk.java.net/jfx pull/17/head:pull/17 > > You have many whitespace errors in your patch that will need to be fixed > before `git jcheck` will pass. When you fix them, you can just push a new > commit. > > As an aside, you have uncovered a bug in the Skara PR bot where the > server-side jcheck fails to complete if there are more than 50 errors. See > [SKARA-135](https://bugs.openjdk.java.net/browse/SKARA-135). > You have many whitespace errors in your patch that will need to be fixed > before `git jcheck` will pass. When you fix them, you can just push a new > commit. I'm trying to setup skara tools so that I can check changes before committing in the future. > > As an aside, you have uncovered a bug in the Skara PR bot where the > server-side jcheck fails to complete if there are more than 50 errors. See > [SKARA-135](https://bugs.openjdk.java.net/browse/SKARA-135). OMG, hope I didn't break things ;-) PR: https://git.openjdk.java.net/jfx/pull/17
Re: RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating
On Mon, 21 Oct 2019 10:19:04 GMT, Robert Lichtenberger wrote: > By using the collection itself as synchronization lock we achieve behaviour > that matches java.util.Collections classes. > > I've create test cases that fail with the current way of synchronizing on a > separate object. > > I've removed unused constructors. > > > > Commits: > - 7e80839f: 8232524: SynchronizedObservableMap cannot be be protected for > copying/iterating > - 8ecf3545: JDK-8232524 fixed. > > Changes: https://git.openjdk.java.net/jfx/pull/17/files > Webrev: https://webrevs.openjdk.java.net/jfx/17/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8232524 > Stats: 120 lines in 2 files changed: 95 ins; 17 del; 8 mod > Patch: https://git.openjdk.java.net/jfx/pull/17.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/17/head:pull/17 You have many whitespace errors in your patch that will need to be fixed before `git jcheck` will pass. When you fix them, you can just push a new commit. As an aside, you have uncovered a bug in the Skara PR bot where the server-side jcheck fails to complete if there are more than 50 errors. See [SKARA-135](https://bugs.openjdk.java.net/browse/SKARA-135). PR: https://git.openjdk.java.net/jfx/pull/17
RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating
By using the collection itself as synchronization lock we achieve behaviour that matches java.util.Collections classes. I've create test cases that fail with the current way of synchronizing on a separate object. I've removed unused constructors. Commits: - 7e80839f: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating - 8ecf3545: JDK-8232524 fixed. Changes: https://git.openjdk.java.net/jfx/pull/17/files Webrev: https://webrevs.openjdk.java.net/jfx/17/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8232524 Stats: 120 lines in 2 files changed: 95 ins; 17 del; 8 mod Patch: https://git.openjdk.java.net/jfx/pull/17.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/17/head:pull/17 PR: https://git.openjdk.java.net/jfx/pull/17
Request for permission to backport fixes to jfx-11
Hi Kevin, I request permission to backport the following issues to the jfx-11 repository. All patches apply clean or with minor changes (e.g. build.properties must keep jfx.release.major.version to 11) Thanks, - Johan https://bugs.openjdk.java.net/browse/JDK-8221302 : Upgrade to gcc 8.2 on Linux https://bugs.openjdk.java.net/browse/JDK-8221299 : Upgrade to Visual Studio 2017 version 15.9.6 https://bugs.openjdk.java.net/browse/JDK-8221300 : Upgrade to Xcode 10.1 https://bugs.openjdk.java.net/browse/JDK-8214716 : Record the versions of tools used to build FX in the repo https://bugs.openjdk.java.net/browse/JDK-8222788 : javafx.web build fails on XCode 10.2 https://bugs.openjdk.java.net/browse/JDK-8225203 : Update SQLite to version 3.28.0 https://bugs.openjdk.java.net/browse/JDK-8219362 : Update to 608.1 version of WebKit https://bugs.openjdk.java.net/browse/JDK-8227079 : Cherry pick GTK WebKit 2.24.3 changes https://bugs.openjdk.java.net/browse/JDK-8230361 : [web] Cookies are not enabled in WebKit v608.1 https://bugs.openjdk.java.net/browse/JDK-8229328 : [windows] PlatformFileHandle type should be JGObject rather than void * https://bugs.openjdk.java.net/browse/JDK-8227431 : [Windows] Fix assertion failure on X86 32-bit when enabling CLOOP based JavaScript interpreter https://bugs.openjdk.java.net/browse/JDK-8222912 : Websocket client doesn't work in WebView https://bugs.openjdk.java.net/browse/JDK-8226537 : Multi-level Stage::initOwner can crash gnome-shell or X.org server https://bugs.openjdk.java.net/browse/JDK-8212060 : [GTK3] Stage sometimes shown at top-left before moving to correct position https://bugs.openjdk.java.net/browse/JDK-8211302 : DragAndDrop no longer works with GTK3 https://bugs.openjdk.java.net/browse/JDK-8213510 : MediaPlayer does not play some mp3 with artwork stream in mjpeg https://bugs.openjdk.java.net/browse/JDK-8207942: Add new protected VirtualFlow methods for subclassing
RFR: 8232687: No static JNI loader for libprism-sw
This PR adds a JNI_OnLoad_prism_sw call to the static lib libprism_sw.a. This approach is similar to the addition of e.g. JNI_OnLoad_prism_es2 that has been done as part of https://bugs.openjdk.java.net/browse/JDK-8223760 Unless -PSTATIC_BUILD is provided when building, this patch has no impact. Commits: - 6f31ee6b: Add JNI_OnLoad_prism_sw call to make prism-sw work with static libs Changes: https://git.openjdk.java.net/jfx/pull/19/files Webrev: https://webrevs.openjdk.java.net/jfx/19/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8232687 Stats: 16 lines in 1 file changed: 16 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/19.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/19/head:pull/19 PR: https://git.openjdk.java.net/jfx/pull/19
