Re: RFR: 8251353: Many javafx scenegraph classes have implicit no-arg constructors [v2]
> Added missing explicit no-arg constructors to classes in package > javafx.scene, javafx.css and javafx.stage. Bhawesh Choudhary has updated the pull request incrementally with one additional commit since the last revision: Marked few class constructor as deprecated as per review - Changes: - all: https://git.openjdk.java.net/jfx/pull/283/files - new: https://git.openjdk.java.net/jfx/pull/283/files/25c7b37c..16d8b9ad Webrevs: - full: https://webrevs.openjdk.java.net/jfx/283/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/283/webrev.00-01 Stats: 6 lines in 2 files changed: 2 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jfx/pull/283.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/283/head:pull/283 PR: https://git.openjdk.java.net/jfx/pull/283
RFR: 8252060: gstreamer fails to build with gcc 10
Fixed by defining GST_API as GST_EXPORT for gcc compiler as per Kevin proposed solution. On Windows we do not need to define GST_API, since we using .def file to export symbols. - Commit messages: - 8252060: gstreamer fails to build with gcc 10 Changes: https://git.openjdk.java.net/jfx/pull/287/files Webrev: https://webrevs.openjdk.java.net/jfx/287/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8252060 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/287.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/287/head:pull/287 PR: https://git.openjdk.java.net/jfx/pull/287
Integrated: 8252107: Media pipeline initialization can crash if audio or video bin state change fails
On Thu, 20 Aug 2020 23:32:24 GMT, Alexander Matveev wrote: > https://bugs.openjdk.java.net/browse/JDK-8252107 > > - Fixed by checking return value of audio/video bin state change and stopping > pipeline initialization if error occurred. This pull request has now been integrated. Changeset: c3fb3210 Author:Alexander Matveev URL: https://git.openjdk.java.net/jfx/commit/c3fb3210 Stats: 27 lines in 1 file changed: 0 ins; 24 del; 3 mod 8252107: Media pipeline initialization can crash if audio or video bin state change fails Reviewed-by: kcr, arapte - PR: https://git.openjdk.java.net/jfx/pull/285
Re: RFR: 8252107: Media pipeline initialization can crash if audio or video bin state change fails
On Thu, 20 Aug 2020 23:32:24 GMT, Alexander Matveev wrote: > https://bugs.openjdk.java.net/browse/JDK-8252107 > > - Fixed by checking return value of audio/video bin state change and stopping > pipeline initialization if error occurred. Built and tested on Linux. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/285
Re: Blurry render of SwingNode
It's now in the JDK project in JBS:
https://bugs.openjdk.java.net/browse/JDK-8252255
I was able to reproduce it with the test program you sent.
-- Kevin
On 8/22/2020 12:28 PM, Kevin Rushforth wrote:
Actually, someone already did file a bug report a couple days ago (I
see it in our internal incident tracker). Once it is transferred to
the JDK project, I'll add the standalone test program from this email
thread to the bug report, which should help in narrowing it down.
Thanks.
-- Kevin
On 8/22/2020 11:40 AM, Michael Paus wrote:
Hi,
this is not a bug reporting list. Please file your bug report here
https://bugs.java.com/bugdatabase/ instead.
Best regards
Michael
Am 22.08.20 um 19:57 schrieb Thangalin:
Ahoy list,
Running OpenJDK 14.0.1 on Windows 7, adding a SwingNode to a SplitPane
causes the contents of the SwingNode to appear blurry. There's a full
write-up with screen-shots at:
https://stackoverflow.com/q/63444771/59087
Here's an SSCCE that demonstrates the problem:
import javafx.application.Application;
import javafx.embed.swing.SwingNode;
import javafx.scene.Scene;
import javafx.scene.control.SplitPane;
import javafx.scene.layout.StackPane;
import javafx.scene.layout.VBox;
import javafx.stage.Stage;
import javax.swing.*;
import java.awt.*;
import static javafx.application.Platform.runLater;
import static javax.swing.SwingUtilities.invokeLater;
public class FlyingSourceTest extends Application {
public static void main( String[] args ) {
Application.launch( args );
}
@Override
public void start( Stage stage ) {
invokeLater( () -> {
stage.setTitle( "SSCCE" );
final var size = 120f;
final var font = new javafx.scene.text.Font( "Arial", size );
final var bgStyle = "-fx-background-color: white";
// FX label, StackPane
final var fxLabelTop = new javafx.scene.text.Text( "FX/FX" );
fxLabelTop.setFont( font );
final var fxStackPaneTop = new StackPane( fxLabelTop );
// FX label, StackPane
final var fxLabelSplit = new javafx.scene.text.Text( "FX
LABEL" );
fxLabelSplit.setFont( font );
final var fxLabelPane = new StackPane();
fxLabelPane.getChildren().addAll( fxLabelSplit );
fxLabelPane.setStyle( bgStyle );
// Swing label, StackPane
final var swingLabel = new JLabel( "SW LABEL" );
swingLabel.setBackground( Color.WHITE );
swingLabel.setOpaque( true );
swingLabel.setFont( swingLabel.getFont().deriveFont(
Font.PLAIN, size ) );
final var swingLabelNode = new SwingNode();
swingLabelNode.setContent( swingLabel );
final var swingLabelPane = new StackPane( swingLabelNode );
swingLabelPane.setStyle( bgStyle );
final var fxSplitPane = new SplitPane(
fxLabelPane, swingLabelPane );
fxSplitPane.setPrefSize( 1280, 300 );
final var root = new VBox();
root.getChildren().addAll( fxStackPaneTop, fxSplitPane );
root.setStyle( bgStyle );
runLater( () -> {
final var scene = new Scene( root );
stage.setScene( scene );
stage.show();
} );
} );
}
}
Closely compare the "L" from "SW LABEL" to the "L" from "FX LABEL".
You'll see that the "SW LABEL" ell has what looks like stronger
antialiasing applied.
Changing the Graphics2D rendering hints on the JLabel has no effect.
Changing the JLabel's AffineTransform to shift by 0.5px worsens the
blurriness. Moving the SwingNode out of the SplitPane renders crisply,
as expected. The font colours and background do not affect the
outcome, but are there to make consistent output, which makes
comparing easier.
This problem affects neither X11 (Linux) nor OSX, only Windows.
Been trying to fix this for several days without success.
Any ideas why embedding a SwingNode within a SplitPane causes a blurry
effect? And how can the problem be resolved?
Thank you!
Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v6]
> fillPath() and fillRect() functions in > [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) > use Image::drawPattern() for applying patterns as fill. But drawPattern() > doesn't use patternTransform argument as > ImagePattern doesn't have the same attribute. So, the final image won't be > transformed. Arun Joseph has updated the pull request incrementally with two additional commits since the last revision: - Update copyright year - Minor refactoring - Changes: - all: https://git.openjdk.java.net/jfx/pull/190/files - new: https://git.openjdk.java.net/jfx/pull/190/files/d808d27a..4241c502 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/190/webrev.05 - incr: https://webrevs.openjdk.java.net/jfx/190/webrev.04-05 Stats: 5 lines in 3 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jfx/pull/190.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/190/head:pull/190 PR: https://git.openjdk.java.net/jfx/pull/190
