Re: Enhancements for JavaFX 18
On 04/08/2021 19:05, Ty Young wrote: * A late "showing" property for when the application has been shown to the user and all first viewing UI components have had their sizes calculated and are being displayed, if it doesn't exist already and I'm completely blind. Do you mean a property that is true if the current node is visible, attached to a scene which is attached to a window which is currently showing? This can be achieved with a small util that takes a Node and returns an ObservableValue. I can dig up the code, I use this all the time to automatically unbind bindings when UI parts become invisible. --John
Re: Enhancements for JavaFX 18
Perhaps: Fluent bindings for ObservableValue https://github.com/openjdk/jfx/pull/434 It was received well I think, and there was some interest from Nir Lisker to work on a proposal. --John On 30/07/2021 14:56, Kevin Rushforth wrote: Now that JavaFX 17 is in RDP2, we can turn more attention to bug fixes and enhancement requests for JavaFX 18. It's the summer, so there may be delays as some people are out at various times (including me), but I would like to get some of the outstanding enhancement requests moving over the next few weeks. Specifically, I'd like to see the following proceed: * Transparent backgrounds in WebView JBS: https://bugs.openjdk.java.net/browse/JDK-8090547 PR: https://github.com/openjdk/jfx/pull/563 * Add DirectionalLight JBS: https://bugs.openjdk.java.net/browse/JDK-8234921 PR: https://github.com/openjdk/jfx/pull/548 * CSS pseudoclasses :focus-visible and :focus-within https://bugs.openjdk.java.net/browse/JDK-8268225 PR: https://github.com/openjdk/jfx/pull/475 * Improve property system to facilitate correct usage (minus the binary incompatible API change) JBS: https://bugs.openjdk.java.net/browse/JDK-8268642 PR: https://github.com/openjdk/jfx/pull/590 (Draft) And maybe the following: * Add CSS themes as a first-class concept (need a consensus on how to proceed) * Undecorated interactive stage style (still in early discussion, but the concept looks interesting and useful) There are probably others I'm forgetting. Each of the above should be discussed in their own thread on openjfx-dev rather than a reply to this thread. -- Kevin
Re: Enhancements for JavaFX 18
+1. It is something I intend to get to for 18. -phil. On 8/4/21 1:10 PM, Kirill Grouchnikov wrote: May I humbly suggest fixing font rendering color fringe issues on macOS On Wed, Aug 4, 2021 at 3:54 PM Sebastian Stenzel < sebastian.sten...@gmail.com> wrote: +1 for a proper system tray api Am 04.08.2021 um 16:47 schrieb Scott Palmer : +1 to that. I would also like to see some progress with system tray support and microphone & webcam access. Scott On Aug 4, 2021, at 7:07 AM, Jeanette Winzenburg < faste...@swingempire.de> wrote: my suggestion would be the longstanding commit-edit-on-focus-lost - solved by an enhancement to the editing api on virtualized controls -- Jeanette Zitat von Kevin Rushforth : Now that JavaFX 17 is in RDP2, we can turn more attention to bug fixes and enhancement requests for JavaFX 18. It's the summer, so there may be delays as some people are out at various times (including me), but I would like to get some of the outstanding enhancement requests moving over the next few weeks. Specifically, I'd like to see the following proceed: * Transparent backgrounds in WebView JBS: https://bugs.openjdk.java.net/browse/JDK-8090547 PR: https://github.com/openjdk/jfx/pull/563 * Add DirectionalLight JBS: https://bugs.openjdk.java.net/browse/JDK-8234921 PR: https://github.com/openjdk/jfx/pull/548 * CSS pseudoclasses :focus-visible and :focus-within https://bugs.openjdk.java.net/browse/JDK-8268225 PR: https://github.com/openjdk/jfx/pull/475 * Improve property system to facilitate correct usage (minus the binary incompatible API change) JBS: https://bugs.openjdk.java.net/browse/JDK-8268642 PR: https://github.com/openjdk/jfx/pull/590 (Draft) And maybe the following: * Add CSS themes as a first-class concept (need a consensus on how to proceed) * Undecorated interactive stage style (still in early discussion, but the concept looks interesting and useful) There are probably others I'm forgetting. Each of the above should be discussed in their own thread on openjfx-dev rather than a reply to this thread. -- Kevin
Re: Enhancements for JavaFX 18
May I humbly suggest fixing font rendering color fringe issues on macOS On Wed, Aug 4, 2021 at 3:54 PM Sebastian Stenzel < sebastian.sten...@gmail.com> wrote: > +1 for a proper system tray api > > > Am 04.08.2021 um 16:47 schrieb Scott Palmer : > > > > +1 to that. > > > > I would also like to see some progress with system tray support and > microphone & webcam access. > > > > Scott > > > >> On Aug 4, 2021, at 7:07 AM, Jeanette Winzenburg < > faste...@swingempire.de> wrote: > >> > >> > >> my suggestion would be the longstanding commit-edit-on-focus-lost - > solved by an enhancement to the editing api on virtualized controls > >> > >> -- Jeanette > >> > >> Zitat von Kevin Rushforth : > >> > >>> Now that JavaFX 17 is in RDP2, we can turn more attention to bug fixes > and enhancement requests for JavaFX 18. It's the summer, so there may be > delays as some people are out at various times (including me), but I would > like to get some of the outstanding enhancement requests moving over the > next few weeks. > >>> > >>> Specifically, I'd like to see the following proceed: > >>> > >>> * Transparent backgrounds in WebView > >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8090547 > >>> PR: https://github.com/openjdk/jfx/pull/563 > >>> > >>> * Add DirectionalLight > >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8234921 > >>> PR: https://github.com/openjdk/jfx/pull/548 > >>> > >>> * CSS pseudoclasses :focus-visible and :focus-within > >>> https://bugs.openjdk.java.net/browse/JDK-8268225 > >>> PR: https://github.com/openjdk/jfx/pull/475 > >>> > >>> * Improve property system to facilitate correct usage (minus the > binary incompatible API change) > >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8268642 > >>> PR: https://github.com/openjdk/jfx/pull/590 (Draft) > >>> > >>> And maybe the following: > >>> > >>> * Add CSS themes as a first-class concept (need a consensus on how to > proceed) > >>> > >>> * Undecorated interactive stage style (still in early discussion, but > the concept looks interesting and useful) > >>> > >>> There are probably others I'm forgetting. > >>> > >>> Each of the above should be discussed in their own thread on > openjfx-dev rather than a reply to this thread. > >>> > >>> -- Kevin > >> > >> > >> > > >
Withdrawn: 8269429: Linux: Only the last APPLICATION_MODAL window behaves correctly
On Mon, 28 Jun 2021 16:56:44 GMT, Thiago Milczarek Sayao wrote: > The PR approach is to set `gtk_window_set_keep_above` to true on > APPLICATION_MODAL windows, so they will not stay behind non APPLICATION_MODAL > windows. > > This is passed on WindowStage.java:198 as a mask. > > The weird thing is that `_enterModal()` is never called. This seems the right > function to be called for `APPLICATION_MODAL`, as `_enterModalWithWindow` > fits for `WINDOW_MODAL`. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jfx/pull/551
Re: RFR: 8269429: Linux: Only the last APPLICATION_MODAL window behaves correctly [v3]
On Sat, 10 Jul 2021 16:06:18 GMT, Thiago Milczarek Sayao wrote: >> The PR approach is to set `gtk_window_set_keep_above` to true on >> APPLICATION_MODAL windows, so they will not stay behind non >> APPLICATION_MODAL windows. >> >> This is passed on WindowStage.java:198 as a mask. >> >> The weird thing is that `_enterModal()` is never called. This seems the >> right function to be called for `APPLICATION_MODAL`, as >> `_enterModalWithWindow` fits for `WINDOW_MODAL`. > > Thiago Milczarek Sayao has updated the pull request incrementally with one > additional commit since the last revision: > > Remove unneeded test for modal This is also fixed by #581. - PR: https://git.openjdk.java.net/jfx/pull/551
Re: Enhancements for JavaFX 18
You want a list of bugs that could be fixed? Today's your lucky day! * Resizing a JavaFX window under Linux (still) causes graphical glitches, needing -Dprism.forceUploadingPainter=true or, IIRC, software rendering to "fix". * Resizing ALSO causes graphical glitching on the bottom and right sides on both Windows AND Linux. * Resizing an app with a TableView in view results in the TableView's integrated scrollbars flickering in and out of existence when there is plenty of space left. The less UI content there is, the less this is likely to happen - but it absolutely does happen with *just* a TableView as the root node, you gotta play with it. * Resizing the application from the left causes UI jitter. * JavaFX in general seems to have trouble keeping up with user resizing. Rapidly resizing an application with a DividerPane(TreeView left, content right) results in inconsistent positioning than if it was done slowly, in the very least. * Alt tabbing with a UI component being selected(Slider thumb, scrollbar) results in that component's color being stuck in whatever color is the CSS selected state. * You can middle and right click drag a slider thumb and scroll bars, which does not trigger a CSS state change, which is not consistent with MenuBar items. * JavaFX does not seem to calculate the size of a GridPane or TilePane with elements correctly. This results in content in ScrollPanes that is clearly larger in height than the viewport but ScrollPane does not show its scrollbars - only mouse wheel works without forcing the scrollbars to always show or transition state bugs when putting a GridPane/TilePane inside a TitlePane(or maybe it's TilePane -> TitlePane -> TilePane that's the issue? No clue.) * XY Chart data that is off screen (-1, -1) has lines drawn to them despite being... off screen. Bug or feature? * Setting the Y axis side to Side.RIGHT causes a white space with custom CSS: https://imgur.com/a/4P1Oj1Q. Might be missing some. A few features, while I'm here: * API property to force a TableView's height to be the exact amount needed to display its headers and all its rows. * API to disable TableView's scrollbars completely. * A late "showing" property for when the application has been shown to the user and all first viewing UI components have had their sizes calculated and are being displayed, if it doesn't exist already and I'm completely blind. On 7/30/21 7:56 AM, Kevin Rushforth wrote: Now that JavaFX 17 is in RDP2, we can turn more attention to bug fixes and enhancement requests for JavaFX 18. It's the summer, so there may be delays as some people are out at various times (including me), but I would like to get some of the outstanding enhancement requests moving over the next few weeks. Specifically, I'd like to see the following proceed: * Transparent backgrounds in WebView JBS: https://bugs.openjdk.java.net/browse/JDK-8090547 PR: https://github.com/openjdk/jfx/pull/563 * Add DirectionalLight JBS: https://bugs.openjdk.java.net/browse/JDK-8234921 PR: https://github.com/openjdk/jfx/pull/548 * CSS pseudoclasses :focus-visible and :focus-within https://bugs.openjdk.java.net/browse/JDK-8268225 PR: https://github.com/openjdk/jfx/pull/475 * Improve property system to facilitate correct usage (minus the binary incompatible API change) JBS: https://bugs.openjdk.java.net/browse/JDK-8268642 PR: https://github.com/openjdk/jfx/pull/590 (Draft) And maybe the following: * Add CSS themes as a first-class concept (need a consensus on how to proceed) * Undecorated interactive stage style (still in early discussion, but the concept looks interesting and useful) There are probably others I'm forgetting. Each of the above should be discussed in their own thread on openjfx-dev rather than a reply to this thread. -- Kevin
Re: Enhancements for JavaFX 18
+1 for a proper system tray api > Am 04.08.2021 um 16:47 schrieb Scott Palmer : > > +1 to that. > > I would also like to see some progress with system tray support and > microphone & webcam access. > > Scott > >> On Aug 4, 2021, at 7:07 AM, Jeanette Winzenburg >> wrote: >> >> >> my suggestion would be the longstanding commit-edit-on-focus-lost - solved >> by an enhancement to the editing api on virtualized controls >> >> -- Jeanette >> >> Zitat von Kevin Rushforth : >> >>> Now that JavaFX 17 is in RDP2, we can turn more attention to bug fixes and >>> enhancement requests for JavaFX 18. It's the summer, so there may be delays >>> as some people are out at various times (including me), but I would like to >>> get some of the outstanding enhancement requests moving over the next few >>> weeks. >>> >>> Specifically, I'd like to see the following proceed: >>> >>> * Transparent backgrounds in WebView >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8090547 >>> PR: https://github.com/openjdk/jfx/pull/563 >>> >>> * Add DirectionalLight >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8234921 >>> PR: https://github.com/openjdk/jfx/pull/548 >>> >>> * CSS pseudoclasses :focus-visible and :focus-within >>> https://bugs.openjdk.java.net/browse/JDK-8268225 >>> PR: https://github.com/openjdk/jfx/pull/475 >>> >>> * Improve property system to facilitate correct usage (minus the binary >>> incompatible API change) >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8268642 >>> PR: https://github.com/openjdk/jfx/pull/590 (Draft) >>> >>> And maybe the following: >>> >>> * Add CSS themes as a first-class concept (need a consensus on how to >>> proceed) >>> >>> * Undecorated interactive stage style (still in early discussion, but the >>> concept looks interesting and useful) >>> >>> There are probably others I'm forgetting. >>> >>> Each of the above should be discussed in their own thread on openjfx-dev >>> rather than a reply to this thread. >>> >>> -- Kevin >> >> >> >
Re: Enhancements for JavaFX 18
+1 to that. I would also like to see some progress with system tray support and microphone & webcam access. Scott > On Aug 4, 2021, at 7:07 AM, Jeanette Winzenburg > wrote: > > > my suggestion would be the longstanding commit-edit-on-focus-lost - solved by > an enhancement to the editing api on virtualized controls > > -- Jeanette > > Zitat von Kevin Rushforth : > >> Now that JavaFX 17 is in RDP2, we can turn more attention to bug fixes and >> enhancement requests for JavaFX 18. It's the summer, so there may be delays >> as some people are out at various times (including me), but I would like to >> get some of the outstanding enhancement requests moving over the next few >> weeks. >> >> Specifically, I'd like to see the following proceed: >> >> * Transparent backgrounds in WebView >> JBS: https://bugs.openjdk.java.net/browse/JDK-8090547 >> PR: https://github.com/openjdk/jfx/pull/563 >> >> * Add DirectionalLight >> JBS: https://bugs.openjdk.java.net/browse/JDK-8234921 >> PR: https://github.com/openjdk/jfx/pull/548 >> >> * CSS pseudoclasses :focus-visible and :focus-within >> https://bugs.openjdk.java.net/browse/JDK-8268225 >> PR: https://github.com/openjdk/jfx/pull/475 >> >> * Improve property system to facilitate correct usage (minus the binary >> incompatible API change) >> JBS: https://bugs.openjdk.java.net/browse/JDK-8268642 >> PR: https://github.com/openjdk/jfx/pull/590 (Draft) >> >> And maybe the following: >> >> * Add CSS themes as a first-class concept (need a consensus on how to >> proceed) >> >> * Undecorated interactive stage style (still in early discussion, but the >> concept looks interesting and useful) >> >> There are probably others I'm forgetting. >> >> Each of the above should be discussed in their own thread on openjfx-dev >> rather than a reply to this thread. >> >> -- Kevin > > >
Re: Enhancements for JavaFX 18
+1 Tom Eugelink schrieb am Mi. 4. Aug. 2021 um 16:31: > +1 > > On 2021-08-04 11:58, Jeanette Winzenburg wrote: > > > > my suggestion would be the longstanding commit-edit-on-focus-lost - > solved by an enhancement to the editing api on virtualized controls > > > > -- Jeanette > > > > Zitat von Kevin Rushforth : > > > >> Now that JavaFX 17 is in RDP2, we can turn more attention to bug fixes > and enhancement requests for JavaFX 18. It's the summer, so there may be > delays as some people are out at various times (including me), but I would > like to get some of the outstanding enhancement requests moving over the > next few weeks. > >> > >> Specifically, I'd like to see the following proceed: > >> > >> * Transparent backgrounds in WebView > >> JBS: https://bugs.openjdk.java.net/browse/JDK-8090547 > >> PR: https://github.com/openjdk/jfx/pull/563 > >> > >> * Add DirectionalLight > >> JBS: https://bugs.openjdk.java.net/browse/JDK-8234921 > >> PR: https://github.com/openjdk/jfx/pull/548 > >> > >> * CSS pseudoclasses :focus-visible and :focus-within > >> https://bugs.openjdk.java.net/browse/JDK-8268225 > >> PR: https://github.com/openjdk/jfx/pull/475 > >> > >> * Improve property system to facilitate correct usage (minus the binary > incompatible API change) > >> JBS: https://bugs.openjdk.java.net/browse/JDK-8268642 > >> PR: https://github.com/openjdk/jfx/pull/590 (Draft) > >> > >> And maybe the following: > >> > >> * Add CSS themes as a first-class concept (need a consensus on how to > proceed) > >> > >> * Undecorated interactive stage style (still in early discussion, but > the concept looks interesting and useful) > >> > >> There are probably others I'm forgetting. > >> > >> Each of the above should be discussed in their own thread on > openjfx-dev rather than a reply to this thread. > >> > >> -- Kevin > > > > > > > > -- Dirk Lemmermann Software & Consulting Zurich, Switzerland +41-(0)79-800-23-20 http://www.dlsc.com mailto:dlemmerm...@gmail.com
Re: Enhancements for JavaFX 18
+1 On 2021-08-04 11:58, Jeanette Winzenburg wrote: my suggestion would be the longstanding commit-edit-on-focus-lost - solved by an enhancement to the editing api on virtualized controls -- Jeanette Zitat von Kevin Rushforth : Now that JavaFX 17 is in RDP2, we can turn more attention to bug fixes and enhancement requests for JavaFX 18. It's the summer, so there may be delays as some people are out at various times (including me), but I would like to get some of the outstanding enhancement requests moving over the next few weeks. Specifically, I'd like to see the following proceed: * Transparent backgrounds in WebView JBS: https://bugs.openjdk.java.net/browse/JDK-8090547 PR: https://github.com/openjdk/jfx/pull/563 * Add DirectionalLight JBS: https://bugs.openjdk.java.net/browse/JDK-8234921 PR: https://github.com/openjdk/jfx/pull/548 * CSS pseudoclasses :focus-visible and :focus-within https://bugs.openjdk.java.net/browse/JDK-8268225 PR: https://github.com/openjdk/jfx/pull/475 * Improve property system to facilitate correct usage (minus the binary incompatible API change) JBS: https://bugs.openjdk.java.net/browse/JDK-8268642 PR: https://github.com/openjdk/jfx/pull/590 (Draft) And maybe the following: * Add CSS themes as a first-class concept (need a consensus on how to proceed) * Undecorated interactive stage style (still in early discussion, but the concept looks interesting and useful) There are probably others I'm forgetting. Each of the above should be discussed in their own thread on openjfx-dev rather than a reply to this thread. -- Kevin
Re: RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v8]
> As noted in the corresponding JBS issue, `Axis` does not properly compute its > preferred height when `autoRanging` is turned off. The simplest fix seems to > be changing `CategoryAxis` so that `tickLabelRotation` is set to 90 degrees > if there is not enough room for the category labels to layout horizontally. > This fixes the fact that the axis labels are truncated and also ensures that > the chart does not leave unused space from the layout calculations. > `CategoryAxis` is already setting the `categorySpacing` property when > `autoRanging` is off, so this seems to be an appropriate fix. Jonathan Vusich has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision: - Merge branch 'master' into jonathan/fix-chart-axis-labels - Updated per review comments - Add tests for vertical axis as well - Improve layout calculations for rotated text - Remove unused import - Unrotate labels if there is enough space for them - Added copyright header - Added fix and test - Changes: - all: https://git.openjdk.java.net/jfx/pull/342/files - new: https://git.openjdk.java.net/jfx/pull/342/files/9d2c8ac9..cc73f8dc Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=342&range=07 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=342&range=06-07 Stats: 442103 lines in 7940 files changed: 245930 ins; 125567 del; 70606 mod Patch: https://git.openjdk.java.net/jfx/pull/342.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/342/head:pull/342 PR: https://git.openjdk.java.net/jfx/pull/342
Re: Enhancements for JavaFX 18
my suggestion would be the longstanding commit-edit-on-focus-lost - solved by an enhancement to the editing api on virtualized controls -- Jeanette Zitat von Kevin Rushforth : Now that JavaFX 17 is in RDP2, we can turn more attention to bug fixes and enhancement requests for JavaFX 18. It's the summer, so there may be delays as some people are out at various times (including me), but I would like to get some of the outstanding enhancement requests moving over the next few weeks. Specifically, I'd like to see the following proceed: * Transparent backgrounds in WebView JBS: https://bugs.openjdk.java.net/browse/JDK-8090547 PR: https://github.com/openjdk/jfx/pull/563 * Add DirectionalLight JBS: https://bugs.openjdk.java.net/browse/JDK-8234921 PR: https://github.com/openjdk/jfx/pull/548 * CSS pseudoclasses :focus-visible and :focus-within https://bugs.openjdk.java.net/browse/JDK-8268225 PR: https://github.com/openjdk/jfx/pull/475 * Improve property system to facilitate correct usage (minus the binary incompatible API change) JBS: https://bugs.openjdk.java.net/browse/JDK-8268642 PR: https://github.com/openjdk/jfx/pull/590 (Draft) And maybe the following: * Add CSS themes as a first-class concept (need a consensus on how to proceed) * Undecorated interactive stage style (still in early discussion, but the concept looks interesting and useful) There are probably others I'm forgetting. Each of the above should be discussed in their own thread on openjfx-dev rather than a reply to this thread. -- Kevin
