Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v5]
> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as > expected by more accurately mapping from a Mac key code to a Java key code > based on the user’s active keyboard layout (the existing code assumes a US > QWERTY layout). The new code first identifies a set of Mac keys which can > produce different characters based on the user’s keyboard layout. A Mac key > code outside that area is processed exactly as before. For a key inside the > layout-sensitive area the code calls UCKeyTranslate to translate the key to > an unshifted ASCII character based on the active keyboard and uses that to > determine the Java key code. > > When performing the reverse mapping for the Robot the code first uses the old > QWERTY mapping to find a candidate key. If it lies in the layout-sensitive > area the code then scans the entire area calling UCKeyTranslate until it > finds a match. If the key lies outside the layout-sensitive area it’s > processed exactly as before. > > There are multiple duplicates of these bugs logged against Mac applications > built with JavaFX. > > https://bugs.openjdk.java.net/browse/JDK-8090257 Mac: Inconsistent KeyEvents > with alternative keyboard layouts > https://bugs.openjdk.java.net/browse/JDK-8088120 [Accelerator, Mac] CMD + Z > accelerator is not working with French keyboard > https://bugs.openjdk.java.net/browse/JDK-8087915 Mac: accelerator doesn't > take into account azerty keyboard layout > https://bugs.openjdk.java.net/browse/JDK-8150709 Mac OSX and German Keyboard > Layout (Y/Z) Martin Fox has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'master' into macshortcut - Fixed whitespace error. - A small number of keyboard layouts require the Option key to reach critical letters like 'Q'. Added a third probe (after Command and Shift+Command) to look for letters that require Option. The keyboards in question are Azeri, Turkmen, and the Sami layouts. - The code now queries both the shifted and unshifted characters for a key favoring digits and letters over everything else. This ensures we catch the digits on the French layout without interfering with Dvorak. - Mac - generate KeyCodes that match user's active keyboard layout. - Changes: - all: https://git.openjdk.java.net/jfx/pull/425/files - new: https://git.openjdk.java.net/jfx/pull/425/files/fb449d93..1037be20 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=425=04 - incr: https://webrevs.openjdk.java.net/?repo=jfx=425=03-04 Stats: 463524 lines in 8239 files changed: 260160 ins; 130671 del; 72693 mod Patch: https://git.openjdk.java.net/jfx/pull/425.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/425/head:pull/425 PR: https://git.openjdk.java.net/jfx/pull/425
Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v5]
> This PR updates the `CONTRIBUTING.md` guide to address the following: > > 1. Clarify the process for adding new features / API changes, specifically > that they must be discussed on the mailing list as the first step. > 2. Add a link to the mailing list in the section regarding contributing bug > fixes. > 3. Remove the text about cross-linking the PR and JBS issue, and add a note > that the Skara tooling takes care of this > 4. Remove the section about manually resolving the JBS issue, and add a note > that the Skara bot automatically does this when the PR is integrated. > 5. Suggest the use of the "/reviewers 2" and "/csr" commands when appropriate > 6. Update the note regarding which JDK(s) to use. Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision: Minor updates to address pending review comments that I did last year, but forgot to push - Changes: - all: https://git.openjdk.java.net/jfx/pull/303/files - new: https://git.openjdk.java.net/jfx/pull/303/files/1c41e9c6..47f51a3c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=303=04 - incr: https://webrevs.openjdk.java.net/?repo=jfx=303=03-04 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jfx/pull/303.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/303/head:pull/303 PR: https://git.openjdk.java.net/jfx/pull/303
Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v3]
On Fri, 18 Sep 2020 18:57:16 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a link to the mailing list in the section regarding contributing bug >> fixes. >> 3. Remove the text about cross-linking the PR and JBS issue, and add a note >> that the Skara tooling takes care of this >> 4. Remove the section about manually resolving the JBS issue, and add a note >> that the Skara bot automatically does this when the PR is integrated. >> 5. Suggest the use of the "/reviewers 2" and "/csr" commands when appropriate >> 6. Update the note regarding which JDK(s) to use. > > Kevin Rushforth has updated the pull request incrementally with one > additional commit since the last revision: > > Address review coments This has been dormant for a long time, so I just merged the latest master. I also discovered a couple additional changes I had in a "working" branch that I will push to address a couple minor comments. I still need to get back to this to address the comments from @nlisker about the flow, so that might take a bit more time, but I would like to get this moving to at least fix the fact that several things are wrong or misleading in the current doc. - PR: https://git.openjdk.java.net/jfx/pull/303
Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v4]
> This PR updates the `CONTRIBUTING.md` guide to address the following: > > 1. Clarify the process for adding new features / API changes, specifically > that they must be discussed on the mailing list as the first step. > 2. Add a link to the mailing list in the section regarding contributing bug > fixes. > 3. Remove the text about cross-linking the PR and JBS issue, and add a note > that the Skara tooling takes care of this > 4. Remove the section about manually resolving the JBS issue, and add a note > that the Skara bot automatically does this when the PR is integrated. > 5. Suggest the use of the "/reviewers 2" and "/csr" commands when appropriate > 6. Update the note regarding which JDK(s) to use. Kevin Rushforth has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Merge branch 'master' into 8231601-contributing - Address review coments - Fixed URL to WEBKIT-MEDIA-STUBS.md - Address review comments - Address review comments + additional fixes - 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes - Changes: - all: https://git.openjdk.java.net/jfx/pull/303/files - new: https://git.openjdk.java.net/jfx/pull/303/files/9ee77cf7..1c41e9c6 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=303=03 - incr: https://webrevs.openjdk.java.net/?repo=jfx=303=02-03 Stats: 762084 lines in 11231 files changed: 387748 ins; 267778 del; 106558 mod Patch: https://git.openjdk.java.net/jfx/pull/303.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/303/head:pull/303 PR: https://git.openjdk.java.net/jfx/pull/303
Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]
On Thu, 16 Dec 2021 21:08:49 GMT, Martin Fox wrote: > I can't build this branch anymore, something related to compiling > CCTaskGroovy. I think I need to merge or rebase to the latest version of > master. Which is preferred, merge or rebase? Merge, please. - PR: https://git.openjdk.java.net/jfx/pull/425
Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]
On Thu, 25 Mar 2021 17:41:40 GMT, Martin Fox wrote: >> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY layout). The new code first identifies a set of Mac keys which can >> produce different characters based on the user’s keyboard layout. A Mac key >> code outside that area is processed exactly as before. For a key inside the >> layout-sensitive area the code calls UCKeyTranslate to translate the key to >> an unshifted ASCII character based on the active keyboard and uses that to >> determine the Java key code. >> >> When performing the reverse mapping for the Robot the code first uses the >> old QWERTY mapping to find a candidate key. If it lies in the >> layout-sensitive area the code then scans the entire area calling >> UCKeyTranslate until it finds a match. If the key lies outside the >> layout-sensitive area it’s processed exactly as before. >> >> There are multiple duplicates of these bugs logged against Mac applications >> built with JavaFX. >> >> https://bugs.openjdk.java.net/browse/JDK-8090257 Mac: Inconsistent KeyEvents >> with alternative keyboard layouts >> https://bugs.openjdk.java.net/browse/JDK-8088120 [Accelerator, Mac] CMD + Z >> accelerator is not working with French keyboard >> https://bugs.openjdk.java.net/browse/JDK-8087915 Mac: accelerator doesn't >> take into account azerty keyboard layout >> https://bugs.openjdk.java.net/browse/JDK-8150709 Mac OSX and German Keyboard >> Layout (Y/Z) > > Martin Fox has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed whitespace error. I can't build this branch anymore, something related to compiling CCTaskGroovy. I think I need to merge or rebase to the latest version of master. Which is preferred, merge or rebase? - PR: https://git.openjdk.java.net/jfx/pull/425
Re: RFR: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout [v2]
> The algorithm in `KeyCharacterCombination.match` relies on the call > `Toolkit.getKeyCodeForChar` which is difficult to implement correctly. It > defies the way most keyboard API’s work and no platform has got it right yet. > In particular the Mac and Linux implementations have to resort to a > brute-force approach which monitors keystrokes to learn the relationship > between keys and characters. > > This PR introduces an alternative mechanism which directly asks the platform > whether a given key can generate a specific character. It also allows the > platform to attach identifying key information to each KeyEvent to make it > easier to answer the question (much, much easier). > > This is mostly dumb plumbing. On the front-end there’s a new call > `View.notifyKeyEx` that takes an additional platform-specific `hardwareCode` > parameter. It also returns a boolean indicating whether the event was > consumed or not so I can fix JDK-8087863. If you want to follow the path > visit the files in this order: > > View.java > GlassViewEventHandler.java > TKSceneListener.java > Scene.java > > The `KeyEvent` class has been expanded with an additional `hardwareCode` > member that can only be accessed internally. See KeyEvent.java and > KeyEventHelper.java. > > On the back-end `KeyCharacterCombination.match` calls a new routine > `Toolkit.getKeyCanGenerateCharacter` which unpacks the `KeyEvent` information > and sends it on to the Application. The default implementation falls back to > the old `getKeyCodeForChar` call but platform specific Applications can send > it on to the native glass code. > > KeyCharacterCombination.java > Toolkit.java > QuantumToolkit.java > Application.java > GtkApplication.java > > The glass code can use the `hardwareCode` to answer the question directly. It > also has enough information to fall back on the old `getKeyCodeForChar` logic > while also enabling the keypad (a common complaint is that Ctrl+’+’ only > works on the main keyboard and not the keypad, see JDK-8090275). > > This PR improves the situation for key events generated by keystrokes. > Manually constructed key events won’t work any better or worse than they > already do. Based on the bug database I don't think this is an issue. Martin Fox has updated the pull request incrementally with one additional commit since the last revision: Added manual test for KeyCharacterCombination matching - Changes: - all: https://git.openjdk.java.net/jfx/pull/694/files - new: https://git.openjdk.java.net/jfx/pull/694/files/9c5dcbcb..7cb6c5bc Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=694=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx=694=00-01 Stats: 160 lines in 1 file changed: 160 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/694.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/694/head:pull/694 PR: https://git.openjdk.java.net/jfx/pull/694
Integrated: 8278905 JavaFX: EnumConverter has a typo in the toString method
On Thu, 16 Dec 2021 14:29:21 GMT, Florian Kirmaier wrote: > Fixing typo in EnumConverter This pull request has now been integrated. Changeset: 4c5bf44e Author:Florian Kirmaier Committer: Kevin Rushforth URL: https://git.openjdk.java.net/jfx/commit/4c5bf44e86dadf19bfd2acab65bb9caf46d3edbc Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8278905: JavaFX: EnumConverter has a typo in the toString method Reviewed-by: kcr - PR: https://git.openjdk.java.net/jfx/pull/697
Scene builder crash in IntelliJ 2021.3 and JDK 17.0.1
As title. Using IntelliJ 2021.3 and JDK 17.0.1 with JavaFX 17.0.1. As soon as I open an .fxml it ask me to install scene builder, I installed it and now Intellij crashes as soon as I open an fxml. Any idea? Thanks Davide
Re: RFR: 8278905 JavaFX: EnumConverter has a typo in the toString method
On Thu, 16 Dec 2021 14:29:21 GMT, Florian Kirmaier wrote: > Fixing typo in EnumConverter Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/697
RFR: 8278905 JavaFX: EnumConverter has a typo in the toString method
Fixing typo in EnumConverter - Commit messages: - 8278905 Changes: https://git.openjdk.java.net/jfx/pull/697/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=697=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278905 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/697.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/697/head:pull/697 PR: https://git.openjdk.java.net/jfx/pull/697
Integrated: 8278134: Move static utility methods to infrastructure (EditAndScrollTest)
On Thu, 9 Dec 2021 12:43:54 GMT, Jeanette Winzenburg wrote: > Extracted static test utility methods from EditAndScrollTest into new > VirtualizedControlTestUtils, added rudimentary tests for the methods. This pull request has now been integrated. Changeset: 002d4f57 Author:Jeanette Winzenburg URL: https://git.openjdk.java.net/jfx/commit/002d4f5734b00c598f97a529c924e26c0451de9c Stats: 348 lines in 3 files changed: 290 ins; 57 del; 1 mod 8278134: Move static utility methods to infrastructure (EditAndScrollTest) Reviewed-by: aghaisas - PR: https://git.openjdk.java.net/jfx/pull/690
Re: RFR: 8278860: Streamline properties for Monocle
On Wed, 15 Dec 2021 20:39:54 GMT, Johan Vos wrote: > Base decisions in prism for embedded cases on the same glass.platform > property that is also used in glass. > This PR replaces the property `embedded` with the property `glass.platform` . > > There is only 1 place where the property `embedded` was read, which is in the > PlatformUtil.java. > > There are only 2 places where the value of that property is used, and in both > cases the only check is to detect whether or not that property has a value of > "monocle". Looks good. If you want to add the missing space I'll reapprove. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/696
Integrated: 8278260: JavaFX shared libraries not stripped on Linux or macOS
On Wed, 15 Dec 2021 00:25:08 GMT, Kevin Rushforth wrote: > Build change to strip the non-global symbols from native shared libraries on > Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative` > build. > > Here is a before / after size comparison. All sizes in KBytes: > > ### Linux > > | Native Library | Current | Stripped | > | --- | - | | > | libavplugin-54.so | 52 | 48 | > | libavplugin-56.so | 52 | 48 | > | libavplugin-57.so | 52 | 48 | > | libavplugin-ffmpeg-56.so | 52 | 48 | > | libavplugin-ffmpeg-57.so | 52 | 48 | > | libavplugin-ffmpeg-58.so | 52 | 48 | > | libdecora_sse.so | 76 | 72 | > | libfxplugins.so | 56 | 52 | > | libglass.so | 16 | 12 | > | libglassgtk2.so | 932 | 324 | > | libglassgtk3.so | 932 | 324 | > | libgstreamer-lite.so | 2,280 | 2,100 | > | libjavafx_font.so | 20 | 16 | > | libjavafx_font_freetype.so | 28 | 28 | > | libjavafx_font_pango.so | 28 | 24 | > | libjavafx_iio.so | 148 | 140 | > | libjfxmedia.so | 2,048 | 516 | > | libjfxwebkit.so | 106,696 | 88,428 | > | libprism_common.so | 8 | 8 | > | libprism_es2.so | 64 | 64 | > | libprism_sw.so | 68 | 64 | > > ### macOS > > | Native Library | Current | Stripped | > | --- | - | | > | libdecora_sse.dylib | 88 | 88 | > | libfxplugins.dylib | 88 | 84 | > | libglass.dylib | 360 | 324 | > | libglib-lite.dylib | 1,192 | 1,148 | > | libgstreamer-lite.dylib | 1,708 | 1584 | > | libjavafx_font.dylib | 64 | 64 | > | libjavafx_iio.dylib | 308 | 300 | > | libjfxmedia.dylib | 212 | 200 | > | libjfxmedia_avf.dylib | 100 | 88 | > | libjfxwebkit.dylib | 85,896 | 71,636 | > | libprism_common.dylib | 20 | 20 | > | libprism_es2.dylib | 64 | 64 | > | libprism_sw.dylib | 88 | 88 | This pull request has now been integrated. Changeset: 1ebf7a24 Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx/commit/1ebf7a24144b198e62b9b343821fdb155b9d703e Stats: 68 lines in 3 files changed: 65 ins; 0 del; 3 mod 8278260: JavaFX shared libraries not stripped on Linux or macOS Reviewed-by: jvos, aghaisas - PR: https://git.openjdk.java.net/jfx/pull/695
Re: RFR: 8278134: Move static utility methods to infrastructure (EditAndScrollTest) [v2]
On Thu, 16 Dec 2021 12:54:27 GMT, Jeanette Winzenburg wrote: >> Extracted static test utility methods from EditAndScrollTest into new >> VirtualizedControlTestUtils, added rudimentary tests for the methods. > > Jeanette Winzenburg has updated the pull request incrementally with one > additional commit since the last revision: > > fixed c error in doc Marked as reviewed by aghaisas (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/690
Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS [v2]
On Wed, 15 Dec 2021 22:57:26 GMT, Kevin Rushforth wrote: >> Build change to strip the non-global symbols from native shared libraries on >> Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative` >> build. >> >> Here is a before / after size comparison. All sizes in KBytes: >> >> ### Linux >> >> | Native Library | Current | Stripped | >> | --- | - | | >> | libavplugin-54.so | 52 | 48 | >> | libavplugin-56.so | 52 | 48 | >> | libavplugin-57.so | 52 | 48 | >> | libavplugin-ffmpeg-56.so | 52 | 48 | >> | libavplugin-ffmpeg-57.so | 52 | 48 | >> | libavplugin-ffmpeg-58.so | 52 | 48 | >> | libdecora_sse.so | 76 | 72 | >> | libfxplugins.so | 56 | 52 | >> | libglass.so | 16 | 12 | >> | libglassgtk2.so | 932 | 324 | >> | libglassgtk3.so | 932 | 324 | >> | libgstreamer-lite.so | 2,280 | 2,100 | >> | libjavafx_font.so | 20 | 16 | >> | libjavafx_font_freetype.so | 28 | 28 | >> | libjavafx_font_pango.so | 28 | 24 | >> | libjavafx_iio.so | 148 | 140 | >> | libjfxmedia.so | 2,048 | 516 | >> | libjfxwebkit.so | 106,696 | 88,428 | >> | libprism_common.so | 8 | 8 | >> | libprism_es2.so | 64 | 64 | >> | libprism_sw.so | 68 | 64 | >> >> ### macOS >> >> | Native Library | Current | Stripped | >> | --- | - | | >> | libdecora_sse.dylib | 88 | 88 | >> | libfxplugins.dylib | 88 | 84 | >> | libglass.dylib | 360 | 324 | >> | libglib-lite.dylib | 1,192 | 1,148 | >> | libgstreamer-lite.dylib | 1,708 | 1584 | >> | libjavafx_font.dylib | 64 | 64 | >> | libjavafx_iio.dylib | 308 | 300 | >> | libjfxmedia.dylib | 212 | 200 | >> | libjfxmedia_avf.dylib | 100 | 88 | >> | libjfxwebkit.dylib | 85,896 | 71,636 | >> | libprism_common.dylib | 20 | 20 | >> | libprism_es2.dylib | 64 | 64 | >> | libprism_sw.dylib | 88 | 88 | > > Kevin Rushforth has updated the pull request incrementally with one > additional commit since the last revision: > > Only strip binaries when doing a production build (`-PCONF=Release`) Marked as reviewed by aghaisas (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/695
Re: RFR: 8278134: Move static utility methods to infrastructure (EditAndScrollTest) [v2]
> Extracted static test utility methods from EditAndScrollTest into new > VirtualizedControlTestUtils, added rudimentary tests for the methods. Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision: fixed c error in doc - Changes: - all: https://git.openjdk.java.net/jfx/pull/690/files - new: https://git.openjdk.java.net/jfx/pull/690/files/c2642bbe..1f2a9815 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=690=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx=690=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/690.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/690/head:pull/690 PR: https://git.openjdk.java.net/jfx/pull/690
Re: RFR: 8278134: Move static utility methods to infrastructure (EditAndScrollTest) [v2]
On Thu, 16 Dec 2021 11:00:39 GMT, Ajit Ghaisas wrote: >> Jeanette Winzenburg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed c error in doc > > modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/VirtualizedControlTestUtils.java > line 86: > >> 84: >> 85: /** >> 86: * Returns a vertical ScrollBar of the control. > > I found this typo. I know, you just moved it from one file to another.. but, > it would be good to fix in this PR :) > Typo : This should be - "Returns a horizontal..." actually, it was me who introduced it - in the previous PR Thanks for spotting! - PR: https://git.openjdk.java.net/jfx/pull/690
Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS [v2]
On Wed, 15 Dec 2021 22:57:26 GMT, Kevin Rushforth wrote: >> Build change to strip the non-global symbols from native shared libraries on >> Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative` >> build. >> >> Here is a before / after size comparison. All sizes in KBytes: >> >> ### Linux >> >> | Native Library | Current | Stripped | >> | --- | - | | >> | libavplugin-54.so | 52 | 48 | >> | libavplugin-56.so | 52 | 48 | >> | libavplugin-57.so | 52 | 48 | >> | libavplugin-ffmpeg-56.so | 52 | 48 | >> | libavplugin-ffmpeg-57.so | 52 | 48 | >> | libavplugin-ffmpeg-58.so | 52 | 48 | >> | libdecora_sse.so | 76 | 72 | >> | libfxplugins.so | 56 | 52 | >> | libglass.so | 16 | 12 | >> | libglassgtk2.so | 932 | 324 | >> | libglassgtk3.so | 932 | 324 | >> | libgstreamer-lite.so | 2,280 | 2,100 | >> | libjavafx_font.so | 20 | 16 | >> | libjavafx_font_freetype.so | 28 | 28 | >> | libjavafx_font_pango.so | 28 | 24 | >> | libjavafx_iio.so | 148 | 140 | >> | libjfxmedia.so | 2,048 | 516 | >> | libjfxwebkit.so | 106,696 | 88,428 | >> | libprism_common.so | 8 | 8 | >> | libprism_es2.so | 64 | 64 | >> | libprism_sw.so | 68 | 64 | >> >> ### macOS >> >> | Native Library | Current | Stripped | >> | --- | - | | >> | libdecora_sse.dylib | 88 | 88 | >> | libfxplugins.dylib | 88 | 84 | >> | libglass.dylib | 360 | 324 | >> | libglib-lite.dylib | 1,192 | 1,148 | >> | libgstreamer-lite.dylib | 1,708 | 1584 | >> | libjavafx_font.dylib | 64 | 64 | >> | libjavafx_iio.dylib | 308 | 300 | >> | libjfxmedia.dylib | 212 | 200 | >> | libjfxmedia_avf.dylib | 100 | 88 | >> | libjfxwebkit.dylib | 85,896 | 71,636 | >> | libprism_common.dylib | 20 | 20 | >> | libprism_es2.dylib | 64 | 64 | >> | libprism_sw.dylib | 88 | 88 | > > Kevin Rushforth has updated the pull request incrementally with one > additional commit since the last revision: > > Only strip binaries when doing a production build (`-PCONF=Release`) Tested on Linux and Mac - Marked as reviewed by jvos (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/695
Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS [v2]
On Thu, 16 Dec 2021 01:33:31 GMT, Michael Strauß wrote: > Here are my results when building with `-PCONF=Release` on macOS 11.6.1: My guess is that the differences are due to either your macOS version or the Xcode you used to build, and that your "current" numbers would also be different from mine. FWIW, mine were generated on macOS 10.15.7 using Xcode 12.4. - PR: https://git.openjdk.java.net/jfx/pull/695
Re: RFR: 8278134: Move static utility methods to infrastructure (EditAndScrollTest)
On Thu, 9 Dec 2021 12:43:54 GMT, Jeanette Winzenburg wrote: > Extracted static test utility methods from EditAndScrollTest into new > VirtualizedControlTestUtils, added rudimentary tests for the methods. This looks good except for a typo which is not introduced by you! modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/VirtualizedControlTestUtils.java line 86: > 84: > 85: /** > 86: * Returns a vertical ScrollBar of the control. I found this typo. I know, you just moved it from one file to another.. but, it would be good to fix in this PR :) Typo : This should be - "Returns a horizontal..." - PR: https://git.openjdk.java.net/jfx/pull/690
