Re: [Rev 03] RFR: 8202296: Monocle MouseInput doesn't send keyboard modifiers in events.
On Tue, 12 May 2020 12:03:36 GMT, Tom Schindl wrote: >> Looks good to me. I verified that the new test fails without your fix and >> passes with your fix. >> >> In case anyone else is looking at this and wants to run the test, it isn't >> enabled by default, so you need to run it >> like this: >> gradle -PUNSTABLE_TEST=true -PFULL_TEST=true -PUSE_ROBOT=true \ >> :systemTests:test --tests test.robot.com.sun.glass.ui.monocle.RobotTest > > @kevinrushforth is there anything left todo or did you simply forget to merge > it? @tomsontom Yes, there is something you need to do. As the author of the patch, you need to `/integrate` it after which I'll `/sponsor` it. - PR: https://git.openjdk.java.net/jfx/pull/170
Re: [Rev 03] RFR: 8202296: Monocle MouseInput doesn't send keyboard modifiers in events.
On Tue, 28 Apr 2020 22:36:47 GMT, Kevin Rushforth wrote: >> Tom Schindl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8202296: Monocle MouseInput doesn't send keyboard modifiers in events. >> >> Fix whitespace errors > > Looks good to me. I verified that the new test fails without your fix and > passes with your fix. > > In case anyone else is looking at this and wants to run the test, it isn't > enabled by default, so you need to run it > like this: > gradle -PUNSTABLE_TEST=true -PFULL_TEST=true -PUSE_ROBOT=true \ > :systemTests:test --tests test.robot.com.sun.glass.ui.monocle.RobotTest @kevinrushforth is there anything left todo or did you simply forget to merge it? - PR: https://git.openjdk.java.net/jfx/pull/170
Re: [Rev 03] RFR: 8202296: Monocle MouseInput doesn't send keyboard modifiers in events.
On Wed, 15 Apr 2020 08:28:22 GMT, Tom Schindl wrote: >> Extract keystate and add to the existing modifier mask, to support eg >> multi-select >> >> https://bugs.openjdk.java.net/browse/JDK-8202296 > > Tom Schindl has updated the pull request incrementally with one additional > commit since the last revision: > > 8202296: Monocle MouseInput doesn't send keyboard modifiers in events. > > Fix whitespace errors Looks good to me. I verified that the new test fails without your fix and passes with your fix. In case anyone else is looking at this and wants to run the test, it isn't enabled by default, so you need to run it like this: gradle -PUNSTABLE_TEST=true -PFULL_TEST=true -PUSE_ROBOT=true \ :systemTests:test --tests test.robot.com.sun.glass.ui.monocle.RobotTest - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/170
Re: [Rev 03] RFR: 8202296: Monocle MouseInput doesn't send keyboard modifiers in events.
> Extract keystate and add to the existing modifier mask, to support eg > multi-select > > https://bugs.openjdk.java.net/browse/JDK-8202296 Tom Schindl has updated the pull request incrementally with one additional commit since the last revision: 8202296: Monocle MouseInput doesn't send keyboard modifiers in events. Fix whitespace errors - Changes: - all: https://git.openjdk.java.net/jfx/pull/170/files - new: https://git.openjdk.java.net/jfx/pull/170/files/64a802ca..8fe96a90 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/170/webrev.03 - incr: https://webrevs.openjdk.java.net/jfx/170/webrev.02-03 Stats: 11 lines in 1 file changed: 0 ins; 0 del; 11 mod Patch: https://git.openjdk.java.net/jfx/pull/170.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/170/head:pull/170 PR: https://git.openjdk.java.net/jfx/pull/170
