Re: Local test failure of LocalDateTimeStringConverterTest.testChronologyConsistency

2021-04-20 Thread Jeanette Winzenburg



added a comment to Ajit's issue, thanks :)

Zitat von Kevin Rushforth :

Looks like you've discovered another Locale-sensitive test, similar  
to the one Ajit is working on now:


https://bugs.openjdk.java.net/browse/JDK-8264952

We could either file a new bug or expand JDK-8264952 to include this  
one. I'd probably recommend the latter, since it is in the same  
general area (a controls unit test that is failing because of a date  
/ time format issue).


-- Kevin


On 4/20/2021 4:39 AM, Jeanette Winzenburg wrote:


the top of the failure trace:

org.junit.ComparisonFailure: expected:<...y, January 12, 60  
Sh[ō]wa, 12:34:56 PM> but was:<...y, January 12, 60 Sh[o]wa,  
12:34:56 PM>

at org.junit.Assert.assertEquals(Assert.java:123)
at org.junit.Assert.assertEquals(Assert.java:145)
at  
test.javafx.util.converter.LocalDateTimeStringConverterTest.testChronologyConsistency(LocalDateTimeStringConverterTest.java:160)


looks like some problem with assumptions of Locale-dependent state  
(my default is German, obviously :). They are always a bit whacky,  
but am surprised to see it in gradle (which disturbs the final  
tests before every push now) - should I file a test bug? Or is  
there something to change locally?


-- Jeanette







Re: Local test failure of LocalDateTimeStringConverterTest.testChronologyConsistency

2021-04-20 Thread Kevin Rushforth
Looks like you've discovered another Locale-sensitive test, similar to 
the one Ajit is working on now:


https://bugs.openjdk.java.net/browse/JDK-8264952

We could either file a new bug or expand JDK-8264952 to include this 
one. I'd probably recommend the latter, since it is in the same general 
area (a controls unit test that is failing because of a date / time 
format issue).


-- Kevin


On 4/20/2021 4:39 AM, Jeanette Winzenburg wrote:


the top of the failure trace:

org.junit.ComparisonFailure: expected:<...y, January 12, 60 Sh[ō]wa, 
12:34:56 PM> but was:<...y, January 12, 60 Sh[o]wa, 12:34:56 PM>

at org.junit.Assert.assertEquals(Assert.java:123)
at org.junit.Assert.assertEquals(Assert.java:145)
at 
test.javafx.util.converter.LocalDateTimeStringConverterTest.testChronologyConsistency(LocalDateTimeStringConverterTest.java:160)


looks like some problem with assumptions of Locale-dependent state (my 
default is German, obviously :). They are always a bit whacky, but am 
surprised to see it in gradle (which disturbs the final tests before 
every push now) - should I file a test bug? Or is there something to 
change locally?


-- Jeanette





Local test failure of LocalDateTimeStringConverterTest.testChronologyConsistency

2021-04-20 Thread Jeanette Winzenburg



the top of the failure trace:

org.junit.ComparisonFailure: expected:<...y, January 12, 60 Sh[ō]wa,  
12:34:56 PM> but was:<...y, January 12, 60 Sh[o]wa, 12:34:56 PM>

at org.junit.Assert.assertEquals(Assert.java:123)
at org.junit.Assert.assertEquals(Assert.java:145)
	at  
test.javafx.util.converter.LocalDateTimeStringConverterTest.testChronologyConsistency(LocalDateTimeStringConverterTest.java:160)


looks like some problem with assumptions of Locale-dependent state (my  
default is German, obviously :). They are always a bit whacky, but am  
surprised to see it in gradle (which disturbs the final tests before  
every push now) - should I file a test bug? Or is there something to  
change locally?


-- Jeanette