Re: [jfx15] RFR: 8250799: NumberStringConverter and its subclasses are missing documentation for all their constructors [v3]
On Fri, 7 Aug 2020 13:33:22 GMT, Kevin Rushforth wrote: >> True, but I just looked at >> [Border](https://openjfx.io/javadoc/14/javafx.graphics/javafx/scene/layout/Border.html) >> which states immutability, so I did the same. I don't mind changing it. > > I don't mind either way. I don't think it's bad to stating this explicitly here. - PR: https://git.openjdk.java.net/jfx/pull/277
Re: [jfx15] RFR: 8250799: NumberStringConverter and its subclasses are missing documentation for all their constructors [v3]
On Mon, 10 Aug 2020 12:45:07 GMT, Johan Vos wrote: >> I don't mind either way. > > I don't think it's bad to stating this explicitly here. Agreed. - PR: https://git.openjdk.java.net/jfx/pull/277
Re: [jfx15] RFR: 8250799: NumberStringConverter and its subclasses are missing documentation for all their constructors [v3]
On Fri, 7 Aug 2020 13:06:51 GMT, Nir Lisker wrote:
>> modules/javafx.base/src/main/java/javafx/util/converter/CurrencyStringConverter.java
>> line 35:
>>
>>> 34: /**
>>> 35: * A {@link StringConverter} implementation for {@link Number} values
>>> that represent currency. Instances of this
>>> class are immutable. 36: *
>>
>> Given that there are no setters or other mutator methods, the immutability
>> seems obvious. I don't see a problem with
>> stating it explicitly, though. It's up to you.
>
> True, but I just looked at
> [Border](https://openjfx.io/javadoc/14/javafx.graphics/javafx/scene/layout/Border.html)
> which states immutability, so I did the same. I don't mind changing it.
I don't mind either way.
-
PR: https://git.openjdk.java.net/jfx/pull/277
Re: [jfx15] RFR: 8250799: NumberStringConverter and its subclasses are missing documentation for all their constructors [v3]
On Fri, 7 Aug 2020 12:48:34 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Corrected NumberFormat constructor text
>
> modules/javafx.base/src/main/java/javafx/util/converter/CurrencyStringConverter.java
> line 35:
>
>> 34: /**
>> 35: * A {@link StringConverter} implementation for {@link Number} values
>> that represent currency. Instances of this
>> class are immutable. 36: *
>
> Given that there are no setters or other mutator methods, the immutability
> seems obvious. I don't see a problem with
> stating it explicitly, though. It's up to you.
True, but I just looked at
[Border](https://openjfx.io/javadoc/14/javafx.graphics/javafx/scene/layout/Border.html)
which states immutability, so I did the same. I don't mind changing it.
-
PR: https://git.openjdk.java.net/jfx/pull/277
Re: [jfx15] RFR: 8250799: NumberStringConverter and its subclasses are missing documentation for all their constructors [v3]
On Thu, 30 Jul 2020 16:42:00 GMT, Nir Lisker wrote:
>> This was missed the in Javadoc fixes for 15.
>>
>> Added documentation for all the constructors, did a bit of formatting, and
>> removed redundant comments.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Corrected NumberFormat constructor text
modules/javafx.base/src/main/java/javafx/util/converter/CurrencyStringConverter.java
line 35:
> 34: /**
> 35: * A {@link StringConverter} implementation for {@link Number} values
> that represent currency. Instances of this
> class are immutable. 36: *
Given that there are no setters or other mutator methods, the immutability
seems obvious. I don't see a problem with
stating it explicitly, though. It's up to you.
modules/javafx.base/src/main/java/javafx/util/converter/CurrencyStringConverter.java
line 52:
> 51: /**
> 52: * Constructs a {@code CurrencyStringConverter} with the given locale
> and the default format.
> 53: */
Can you also add the `@param locale` tag? This applies to all of the newly
documented constructors that have arguments.
-
PR: https://git.openjdk.java.net/jfx/pull/277
Re: [jfx15] RFR: 8250799: NumberStringConverter and its subclasses are missing documentation for all their constructors [v3]
> This was missed the in Javadoc fixes for 15. > > Added documentation for all the constructors, did a bit of formatting, and > removed redundant comments. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Corrected NumberFormat constructor text - Changes: - all: https://git.openjdk.java.net/jfx/pull/277/files - new: https://git.openjdk.java.net/jfx/pull/277/files/72c0b00d..8f19315b Webrevs: - full: https://webrevs.openjdk.java.net/jfx/277/webrev.02 - incr: https://webrevs.openjdk.java.net/jfx/277/webrev.01-02 Stats: 5 lines in 3 files changed: 0 ins; 2 del; 3 mod Patch: https://git.openjdk.java.net/jfx/pull/277.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/277/head:pull/277 PR: https://git.openjdk.java.net/jfx/pull/277
