Re: RFR: 8271091: Missing API docs in UI controls classes [v3]
On Mon, 25 Oct 2021 22:53:53 GMT, Kevin Rushforth wrote: >> Ajit Ghaisas has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix review comments > > modules/javafx.controls/src/main/java/javafx/scene/control/PopupControl.java > line 179: > >> 177: * HTML element. Note that, like the HTML style attribute, this >> 178: * variable contains style properties and values and not the >> 179: * selector portion of a style rule. > > It would be good to add a sentence here with the information (which was > formerly in the getter) that a value of `null` is converted to the empty > string. Added. > modules/javafx.controls/src/main/java/javafx/scene/control/TabPane.java line > 508: > >> 506: * The maximum height of the tabs in the TabPane. >> 507: * @return the maximum height of the tabs >> 508: */ > > In reverting this, you introduced a whitespace (indentation) change. Fixed. - PR: https://git.openjdk.java.net/jfx/pull/646
Re: RFR: 8271091: Missing API docs in UI controls classes [v3]
On Mon, 25 Oct 2021 17:47:38 GMT, Ajit Ghaisas wrote: >> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. >> Note : >> - The javadoc needs to be generated with the JDK 18 EA build. >> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under - >> [JDK-8271085](https://bugs.openjdk.java.net/browse/JDK-8271085) >> - There are still 20 javadoc warnings remaining in javafx.controls module >> and 3 warnings remaining in javafx.web module. The root cause is different >> and they will be addressed under >> [JDK-8270996](https://bugs.openjdk.java.net/browse/JDK-8270996) > > Ajit Ghaisas has updated the pull request incrementally with one additional > commit since the last revision: > > fix review comments Two minor comments. The rest looks great. modules/javafx.controls/src/main/java/javafx/scene/control/PopupControl.java line 179: > 177: * HTML element. Note that, like the HTML style attribute, this > 178: * variable contains style properties and values and not the > 179: * selector portion of a style rule. It would be good to add a sentence here with the information (which was formerly in the getter) that a value of `null` is converted to the empty string. modules/javafx.controls/src/main/java/javafx/scene/control/TabPane.java line 508: > 506: * The maximum height of the tabs in the TabPane. > 507: * @return the maximum height of the tabs > 508: */ In reverting this, you introduced a whitespace (indentation) change. - PR: https://git.openjdk.java.net/jfx/pull/646
Re: RFR: 8271091: Missing API docs in UI controls classes [v3]
> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. > Note : > - The javadoc needs to be generated with the JDK 18 EA build. > - 2 javadoc warnings in javafx.controls TabPane class will be fixed under - > [JDK-8271085](https://bugs.openjdk.java.net/browse/JDK-8271085) > - There are still 20 javadoc warnings remaining in javafx.controls module and > 3 warnings remaining in javafx.web module. The root cause is different and > they will be addressed under > [JDK-8270996](https://bugs.openjdk.java.net/browse/JDK-8270996) Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision: fix review comments - Changes: - all: https://git.openjdk.java.net/jfx/pull/646/files - new: https://git.openjdk.java.net/jfx/pull/646/files/38563835..7cc2de52 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=646=02 - incr: https://webrevs.openjdk.java.net/?repo=jfx=646=01-02 Stats: 124 lines in 8 files changed: 48 ins; 21 del; 55 mod Patch: https://git.openjdk.java.net/jfx/pull/646.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/646/head:pull/646 PR: https://git.openjdk.java.net/jfx/pull/646
