Integrated: 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined
On Fri, 21 Jun 2024 09:02:43 GMT, Ao Qi wrote: > This problem has been fixed > [upstream](https://github.com/WebKit/WebKit/pull/23282). This patch merges > the fix in advance. > > Error log: > > > /some_dir/jfx/modules/javafx.web/src/main/native/Source/WTF/wtf/StackPointer.cpp:140:2: > error: #error "Unsupported platform: need implementation of > currentStackPointer." > 140 | #error "Unsupported platform: need implementation of > currentStackPointer." > | ^ > make[2]: *** [Source/WTF/wtf/CMakeFiles/WTF.dir/build.make:1098: > Source/WTF/wtf/CMakeFiles/WTF.dir/StackPointer.cpp.o] Error 1 > make[2]: *** Waiting for unfinished jobs > make[1]: *** [CMakeFiles/Makefile2:360: > Source/WTF/wtf/CMakeFiles/WTF.dir/all] Error 2 This pull request has now been integrated. Changeset: ca04c87d Author:Ao Qi Committer: Kevin Rushforth URL: https://git.openjdk.org/jfx/commit/ca04c87d307c36591162af8cd6298ede17812834 Stats: 11 lines in 1 file changed: 11 ins; 0 del; 0 mod 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined Reviewed-by: kcr, hmeda - PR: https://git.openjdk.org/jfx/pull/1482
Re: RFR: 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined
On Fri, 21 Jun 2024 11:24:34 GMT, Kevin Rushforth wrote: >> This problem has been fixed >> [upstream](https://github.com/WebKit/WebKit/pull/23282). This patch merges >> the fix in advance. >> >> Error log: >> >> >> /some_dir/jfx/modules/javafx.web/src/main/native/Source/WTF/wtf/StackPointer.cpp:140:2: >> error: #error "Unsupported platform: need implementation of >> currentStackPointer." >> 140 | #error "Unsupported platform: need implementation of >> currentStackPointer." >> | ^ >> make[2]: *** [Source/WTF/wtf/CMakeFiles/WTF.dir/build.make:1098: >> Source/WTF/wtf/CMakeFiles/WTF.dir/StackPointer.cpp.o] Error 1 >> make[2]: *** Waiting for unfinished jobs >> make[1]: *** [CMakeFiles/Makefile2:360: >> Source/WTF/wtf/CMakeFiles/WTF.dir/all] Error 2 > > Reviewers: @jaybhaskar @kevinrushforth Thanks, @kevinrushforth and @HimaBinduMeda ! - PR Comment: https://git.openjdk.org/jfx/pull/1482#issuecomment-2193944610
RFR: 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined
This problem has been fixed [upstream](https://github.com/WebKit/WebKit/pull/23282). This patch merges the fix in advance. Error log: /some_dir/jfx/modules/javafx.web/src/main/native/Source/WTF/wtf/StackPointer.cpp:140:2: error: #error "Unsupported platform: need implementation of currentStackPointer." 140 | #error "Unsupported platform: need implementation of currentStackPointer." | ^ make[2]: *** [Source/WTF/wtf/CMakeFiles/WTF.dir/build.make:1098: Source/WTF/wtf/CMakeFiles/WTF.dir/StackPointer.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs make[1]: *** [CMakeFiles/Makefile2:360: Source/WTF/wtf/CMakeFiles/WTF.dir/all] Error 2 - Commit messages: - 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined Changes: https://git.openjdk.org/jfx/pull/1482/files Webrev: https://webrevs.openjdk.org/?repo=jfx=1482=00 Issue: https://bugs.openjdk.org/browse/JDK-8334713 Stats: 11 lines in 1 file changed: 11 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jfx/pull/1482.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1482/head:pull/1482 PR: https://git.openjdk.org/jfx/pull/1482
Integrated: 8325093: Update CONTRIBUTING.md for build jdk version
On Thu, 1 Feb 2024 06:36:51 GMT, Ao Qi wrote: > [JDK-8297068](https://bugs.openjdk.org/browse/JDK-8297068) updated boot JDK > to 19.0.1 from 18.0.2, and > [JDK-8321434](https://bugs.openjdk.org/browse/JDK-8321434) updated boot JDK > to 21.0.1. `CONTRIBUTING.md` should be updated correspondingly. This pull request has now been integrated. Changeset: 12816b57 Author:Ao Qi Committer: Kevin Rushforth URL: https://git.openjdk.org/jfx/commit/12816b57ffd1ffad57d008f7195666ad4e9400bb Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8325093: Update CONTRIBUTING.md for build jdk version Reviewed-by: kcr - PR: https://git.openjdk.org/jfx/pull/1357
Re: RFR: 8325093: Update CONTRIBUTING.md for build jdk version
On Fri, 2 Feb 2024 13:37:15 GMT, Kevin Rushforth wrote: >> [JDK-8297068](https://bugs.openjdk.org/browse/JDK-8297068) updated boot JDK >> to 19.0.1 from 18.0.2, and >> [JDK-8321434](https://bugs.openjdk.org/browse/JDK-8321434) updated boot JDK >> to 21.0.1. `CONTRIBUTING.md` should be updated correspondingly. > > Looks good. Thanks. @kevinrushforth, thanks for the review. - PR Comment: https://git.openjdk.org/jfx/pull/1357#issuecomment-1924017692
RFR: 8325093: Update CONTRIBUTING.md for build jdk version
[JDK-8297068](https://bugs.openjdk.org/browse/JDK-8297068) updated boot JDK to 19.0.1 from 18.0.2, and [JDK-8321434](https://bugs.openjdk.org/browse/JDK-8321434) updated boot JDK to 21.0.1. `CONTRIBUTING.md` should be updated correspondingly. - Commit messages: - 8325093: Update CONTRIBUTING.md for build jdk version Changes: https://git.openjdk.org/jfx/pull/1357/files Webrev: https://webrevs.openjdk.org/?repo=jfx=1357=00 Issue: https://bugs.openjdk.org/browse/JDK-8325093 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jfx/pull/1357.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1357/head:pull/1357 PR: https://git.openjdk.org/jfx/pull/1357
[jfx17u] Integrated: 8293214: Add support for Linux/LoongArch64
On Mon, 9 Jan 2023 13:28:51 GMT, Ao Qi wrote: > Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. This pull request has now been integrated. Changeset: 1b99a5b2 Author: Ao Qi Committer: Kevin Rushforth URL: https://git.openjdk.org/jfx17u/commit/1b99a5b26bcd194d98d97bd7078a6b7fb76d8d93 Stats: 26 lines in 4 files changed: 15 ins; 0 del; 11 mod 8293214: Add support for Linux/LoongArch64 Reviewed-by: jvos, kcr Backport-of: cef583eef41aff3db55542d5e90423eec5601f41 - PR: https://git.openjdk.org/jfx17u/pull/102
Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64
On Fri, 3 Feb 2023 08:44:53 GMT, Johan Vos wrote: >> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. > > I'm ok with this. > Apart from the functionality, this BP also makes it easier to backport future > changes in build.gradle (because it backports a structural change in the > 64-bit "detection") Thanks, @johanvos ! Let's wait for a while to see if @kevinrushforth has further comments. - PR: https://git.openjdk.org/jfx17u/pull/102
[jfx17u] Integrated: 8293375: add_definitions USE_SYSTEM_MALLOC when USE_SYSTEM_MALLOC is ON
On Mon, 9 Jan 2023 13:29:27 GMT, Ao Qi wrote: > Clean backport. Verified on (after #102): > - Linux/LoongArch64 (`USE_SYSTEM_MALLOC` is `on`, the platform triggering > this problem) > - Linux/x64 (`USE_SYSTEM_MALLOC` is `off`) > - Linux/aarch64 (`USE_SYSTEM_MALLOC` is `off`) This pull request has now been integrated. Changeset: 29f878fc Author:Ao Qi Committer: Johan Vos URL: https://git.openjdk.org/jfx17u/commit/29f878fcc9778798293a2d125a10593f1fe2d6dc Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod 8293375: add_definitions USE_SYSTEM_MALLOC when USE_SYSTEM_MALLOC is ON Reviewed-by: kcr, jvos Backport-of: 28f8fa9c20363ced9a94787ecfd45735b3e6b82e - PR: https://git.openjdk.org/jfx17u/pull/103
Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64
On Mon, 9 Jan 2023 13:28:51 GMT, Ao Qi wrote: > Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. RFC and RFR. Thanks. Should I take this PR out of Draft? - PR: https://git.openjdk.org/jfx17u/pull/102
Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64
On Mon, 9 Jan 2023 13:41:49 GMT, Kevin Rushforth wrote: >> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. > > Backports to `jfx17u` require prior approval. You will need to seek such > approval from one of the project leads before taking this PR out of Draft. > > If it is approved, the timing is such that it needs to wait for about two > weeks. It could possibly be slated for JavaFX 17.0.7 (the April CPU release), > since it is far too late to make any changes for 17.0.6. Thanks a lot for the quick advice, @kevinrushforth. I will further learn how to do the backports to `jfx17u`. Also, this backport is not in a hurry. Let's wait for the release of `17.0.6`. I don't want to bother with the new releasing version:) - PR: https://git.openjdk.org/jfx17u/pull/102
[jfx17u] RFR: 8293214: Add support for Linux/LoongArch64
Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. - Commit messages: - 8293214: Add support for Linux/LoongArch64 Changes: https://git.openjdk.org/jfx17u/pull/102/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u=102=00 Issue: https://bugs.openjdk.org/browse/JDK-8293214 Stats: 26 lines in 4 files changed: 15 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jfx17u/pull/102.diff Fetch: git fetch https://git.openjdk.org/jfx17u pull/102/head:pull/102 PR: https://git.openjdk.org/jfx17u/pull/102
Re: RFR: 8301604: Replace Collections.unmodifiableList with List.of
On Thu, 26 Jan 2023 05:30:56 GMT, Glavo wrote: > `List.of` is cleaner, and can slightly reduce the memory footprint for lists > of one or two elements. > > Because `List.of` can only store non-null elements, I have only replaced a > few usage. > > Can someone open an Issue on JBS for me? Filed: https://bugs.openjdk.org/browse/JDK-8301604. Please let me know if the issue is not reported correctly. - PR: https://git.openjdk.org/jfx/pull/1012
[jfx17u] RFR: 8293375: add_definitions USE_SYSTEM_MALLOC when USE_SYSTEM_MALLOC is ON
Clean backport. Verified on (after #102): - Linux/LoongArch64 (`USE_SYSTEM_MALLOC` is `on`, the platform triggering this problem) - Linux/x64 (`USE_SYSTEM_MALLOC` is `off`) - Linux/aarch64 (`USE_SYSTEM_MALLOC` is `off`) - Commit messages: - 8293375: add_definitions USE_SYSTEM_MALLOC when USE_SYSTEM_MALLOC is ON Changes: https://git.openjdk.org/jfx17u/pull/103/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u=103=00 Issue: https://bugs.openjdk.org/browse/JDK-8293375 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jfx17u/pull/103.diff Fetch: git fetch https://git.openjdk.org/jfx17u pull/103/head:pull/103 PR: https://git.openjdk.org/jfx17u/pull/103
Re: [jfx17u] RFR: 8293375: add_definitions USE_SYSTEM_MALLOC when USE_SYSTEM_MALLOC is ON
On Mon, 9 Jan 2023 13:29:27 GMT, Ao Qi wrote: > Clean backport. Verified on (after #102): > - Linux/LoongArch64 (`USE_SYSTEM_MALLOC` is `on`, the platform triggering > this problem) > - Linux/x64 (`USE_SYSTEM_MALLOC` is `off`) > - Linux/aarch64 (`USE_SYSTEM_MALLOC` is `off`) RFC and RFR. Thanks. - PR: https://git.openjdk.org/jfx17u/pull/103
Integrated: 8293214: Add support for Linux/LoongArch64
On Thu, 1 Sep 2022 12:19:23 GMT, Ao Qi wrote:
> LoongArch is a new RISC ISA. This issue proposes adding support for
> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
> is updated to OpenJFX, it is supposed to work.
>
> Testing:
> - [x] base, controls, fxml, graphics and web tests, {Release,Debug}, {with
> WebKit,without Webkit} on Linux/x64
> - [x] base, controls, fxml, graphics and web tests, {Release,Debug}, {with
> WebKit,without Webkit} on Linux/aarch64
> - [x] base, controls, fxml and graphics tests, {Release,Debug}, without
> WebKit on Linux/loongarch64
This pull request has now been integrated.
Changeset: cef583ee
Author:Ao Qi
Committer: Kevin Rushforth
URL:
https://git.openjdk.org/jfx/commit/cef583eef41aff3db55542d5e90423eec5601f41
Stats: 26 lines in 4 files changed: 15 ins; 0 del; 11 mod
8293214: Add support for Linux/LoongArch64
Reviewed-by: almatvee, jvos, kcr
-
PR: https://git.openjdk.org/jfx/pull/888
Re: RFR: 8293214: Add support for Linux/LoongArch64 [v4]
On Fri, 16 Sep 2022 14:09:39 GMT, Kevin Rushforth wrote: >> Ao Qi has updated the pull request incrementally with one additional commit >> since the last revision: >> >> disable msse2 by default, use IS_LOONGARCH64 and IS_AARCH64 > > The changes look good. I'm doing a final sanity test on our CI system, and > then I'll approve. @kevinrushforth, thanks! - PR: https://git.openjdk.org/jfx/pull/888
Re: RFR: 8293214: Add support for Linux/LoongArch64 [v4]
On Thu, 15 Sep 2022 13:31:54 GMT, Johan Vos wrote: >> Ao Qi has updated the pull request incrementally with one additional commit >> since the last revision: >> >> disable msse2 by default, use IS_LOONGARCH64 and IS_AARCH64 > > It looks good. I'll do a build and then hopefully I can approve (those > ifeq/ifneq changes often need more than a few pair of eyes) @johanvos, thanks for the review! - PR: https://git.openjdk.org/jfx/pull/888
Re: RFR: 8293214: Add support for Linux/LoongArch64 [v4]
On Thu, 15 Sep 2022 13:31:54 GMT, Johan Vos wrote: > It looks good. I'll do a build and then hopefully I can approve (those > ifeq/ifneq changes often need more than a few pair of eyes) Yes. We need to check it carefully:) I did some tests like: ifneq (,$(findstring $(ARCH), x64 x32 loongarch64)) CFLAGS += -msse2 endif and it did cause errors like: make: *** Waiting for unfinished jobs gcc: error: unrecognized command line option '-msse2' - PR: https://git.openjdk.org/jfx/pull/888
Re: RFR: 8293214: Add support for Linux/LoongArch64 [v3]
On Wed, 7 Sep 2022 12:02:37 GMT, Johan Vos wrote: >> Ao Qi has updated the pull request incrementally with one additional commit >> since the last revision: >> >> revert > > This PR looks safe to me. I don't see a scenario where this can cause > regression. I can't say if those changes are enough to build for LoongArch64 > though, but as long as there is no regression I am ok. > There are a few minor optimizations that I suggested -- in general, there are > more places in the build.gradle file where we could benefit from > optimizations but I don't recommend doing that as part of this PR. Hi @johanvos , I have updated the patch according to your suggestions. Would you like to review it? I think I need at least one more review, would someone help to review the patch? Thanks! - PR: https://git.openjdk.org/jfx/pull/888
Re: RFR: 8293214: Add support for Linux/LoongArch64 [v3]
On Wed, 7 Sep 2022 11:59:42 GMT, Johan Vos wrote:
>> Ao Qi has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> revert
>
> build.gradle line 313:
>
>> 311: } else if (IS_MAC && OS_ARCH != "x86_64" && OS_ARCH != "aarch64") {
>> 312: fail("Unknown and unsupported build architecture: $OS_ARCH")
>> 313: } else if (IS_LINUX && OS_ARCH != "i386" && OS_ARCH != "amd64" &&
>> OS_ARCH != "aarch64" && OS_ARCH != "loongarch64") {
>
> this could be simplified with
> `... && !IS_LOONGARCH64` which avoids the more error-prone duplicate
> "loongarch64" string.
> (the same applies to replacing the aarch64 check with !IS_AARCH64)
Done.
> modules/javafx.media/src/main/native/gstreamer/projects/linux/avplugin/Makefile
> line 36:
>
>> 34: -ffunction-sections -fdata-sections
>> 35:
>> 36: ifeq (,$(findstring $(ARCH), aarch64 loongarch64))
>
> This will work, but I wonder if we should revert the test: we now always
> assume that msse2 is supported, unless we are on an architecture which we
> know doesn't support it. It might be safer to only ask for msse2 support if
> we are really sure it is supported by the architecture (which currently means
> a check on x32 and x64)
Done.
-
PR: https://git.openjdk.org/jfx/pull/888
Re: RFR: 8293214: Add support for Linux/LoongArch64 [v4]
> LoongArch is a new RISC ISA. This issue proposes adding support for
> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
> is updated to OpenJFX, it is supposed to work.
>
> Testing:
> - [x] base, controls, fxml, graphics and web tests, {Release,Debug}, {with
> WebKit,without Webkit} on Linux/x64
> - [x] base, controls, fxml, graphics and web tests, {Release,Debug}, {with
> WebKit,without Webkit} on Linux/aarch64
> - [x] base, controls, fxml and graphics tests, {Release,Debug}, without
> WebKit on Linux/loongarch64
Ao Qi has updated the pull request incrementally with one additional commit
since the last revision:
disable msse2 by default, use IS_LOONGARCH64 and IS_AARCH64
-
Changes:
- all: https://git.openjdk.org/jfx/pull/888/files
- new: https://git.openjdk.org/jfx/pull/888/files/b225c59a..29e4b883
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx=888=03
- incr: https://webrevs.openjdk.org/?repo=jfx=888=02-03
Stats: 4 lines in 4 files changed: 0 ins; 0 del; 4 mod
Patch: https://git.openjdk.org/jfx/pull/888.diff
Fetch: git fetch https://git.openjdk.org/jfx pull/888/head:pull/888
PR: https://git.openjdk.org/jfx/pull/888
Re: RFR: 8293214: Add support for Linux/LoongArch64 [v3]
On Tue, 6 Sep 2022 23:00:22 GMT, Alexander Matveev wrote: >> Ao Qi has updated the pull request incrementally with one additional commit >> since the last revision: >> >> revert > > Media changes looks good. Thanks for the review, @sashamatveev. - PR: https://git.openjdk.org/jfx/pull/888
Re: RFR: 8293375: add_definitions USE_SYSTEM_MALLOC when USE_SYSTEM_MALLOC is ON
On Tue, 6 Sep 2022 01:19:07 GMT, Leslie Zhai wrote: > Hi, > > jfx web failed to build when `USE_SYSTEM_MALLOC` is `ON`: > > > jfx/modules/javafx.web/build/linux/Release/WTF/Headers/wtf/Platform.h:58, > jfx/modules/javafx.web/build/linux/Release/WTF/Headers/wtf/Assertions.h:28, > jfx/modules/javafx.web/src/main/native/Source/WebCore/platform/java/WebKitLogging.h:31, > jfx/modules/javafx.web/src/main/native/Source/WebCore/platform/java/WebKitLogging.cpp:28, > jfx/modules/javafx.web/build/linux/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-47.cpp:1: > jfx/modules/javafx.web/build/linux/Release/WTF/Headers/wtf/PlatformUse.h:351:10: > fatal error: bmalloc/BPlatform.h: No such file or directory > #include >^ > compilation terminated. > > > After commit `6f28d912024495278c4c35ab054bc2aab480b3e4`: > > > diff --git a/modules/javafx.web/src/main/native/Source/WTF/wtf/PlatformUse.h > b/modules/javafx.web/src/main/native/Source/WTF/wtf/PlatformUse.h > index 70c047813f..d30291697a 100644 > --- a/modules/javafx.web/src/main/native/Source/WTF/wtf/PlatformUse.h > +++ b/modules/javafx.web/src/main/native/Source/WTF/wtf/PlatformUse.h > > ... > > #if PLATFORM(IOS_FAMILY) > #define USE_SANDBOX_EXTENSIONS_FOR_CACHE_AND_TEMP_DIRECTORY_ACCESS 1 > #endif > + > +#if !defined(USE_LIBPAS_JIT_HEAP) && !USE(SYSTEM_MALLOC) > +#include > +#if BENABLE(LIBPAS) > +#if PLATFORM(MAC) && CPU(ARM64) > +#define USE_LIBPAS_JIT_HEAP 1 > +#endif > +#endif > +#endif > + > > > Please review my patch. > > Thanks, > Leslie Zhai Hi @xiangzhai , I suggest that you enable [the GitHub Actions of your repo](https://github.com/xiangzhai/jfx/actions) and trigger the tests. FYI, [8293338: Enable manually triggering the GitHub workflow](https://github.com/openjdk/jfx/pull/891). - PR: https://git.openjdk.org/jfx/pull/892
Re: RFR: 8293214: Add support for Linux/LoongArch64
On Thu, 1 Sep 2022 12:51:34 GMT, Kevin Rushforth wrote: > The easiest way is to push an empty commit to your branch. Thanks, @kevinrushforth . The GHA tests passed. Some additional test results were updated in the PR description. - PR: https://git.openjdk.org/jfx/pull/888
Re: RFR: 8293214: Add support for Linux/LoongArch64 [v3]
> LoongArch is a new RISC ISA. This issue proposes adding support for > Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but > the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit > is updated to OpenJFX, it is supposed to work. Ao Qi has updated the pull request incrementally with one additional commit since the last revision: revert - Changes: - all: https://git.openjdk.org/jfx/pull/888/files - new: https://git.openjdk.org/jfx/pull/888/files/c0bdfe96..b225c59a Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx=888=02 - incr: https://webrevs.openjdk.org/?repo=jfx=888=01-02 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jfx/pull/888.diff Fetch: git fetch https://git.openjdk.org/jfx pull/888/head:pull/888 PR: https://git.openjdk.org/jfx/pull/888
Re: RFR: 8293214: Add support for Linux/LoongArch64 [v2]
> LoongArch is a new RISC ISA. This issue proposes adding support for > Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but > the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit > is updated to OpenJFX, it is supposed to work. Ao Qi has updated the pull request incrementally with one additional commit since the last revision: trigger the GHA tests - Changes: - all: https://git.openjdk.org/jfx/pull/888/files - new: https://git.openjdk.org/jfx/pull/888/files/408f9156..c0bdfe96 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx=888=01 - incr: https://webrevs.openjdk.org/?repo=jfx=888=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jfx/pull/888.diff Fetch: git fetch https://git.openjdk.org/jfx pull/888/head:pull/888 PR: https://git.openjdk.org/jfx/pull/888
Re: RFR: 8293214: Add support for Linux/LoongArch64
On Thu, 1 Sep 2022 12:19:23 GMT, Ao Qi wrote: > LoongArch is a new RISC ISA. This issue proposes adding support for > Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but > the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit > is updated to OpenJFX, it is supposed to work. I just enable the GitHub Actions after I create the pr. How can I trigger the GHA tests? - PR: https://git.openjdk.org/jfx/pull/888
RFR: 8293214: Add support for Linux/LoongArch64
LoongArch is a new RISC ISA. This issue proposes adding support for Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit is updated to OpenJFX, it is supposed to work. - Commit messages: - 8293214: Add support for Linux/LoongArch64 Changes: https://git.openjdk.org/jfx/pull/888/files Webrev: https://webrevs.openjdk.org/?repo=jfx=888=00 Issue: https://bugs.openjdk.org/browse/JDK-8293214 Stats: 26 lines in 4 files changed: 15 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jfx/pull/888.diff Fetch: git fetch https://git.openjdk.org/jfx pull/888/head:pull/888 PR: https://git.openjdk.org/jfx/pull/888
