[jfx23u] Integrated: 8340208: Additional WebKit 619.1 fixes from WebKitGTK 2.44.4
On Tue, 24 Sep 2024 17:11:55 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: fa41f904 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx23u/commit/fa41f904fc9e0034d3af4d7b4b4cc5d7ddde3300 Stats: 596 lines in 103 files changed: 376 ins; 116 del; 104 mod 8340208: Additional WebKit 619.1 fixes from WebKitGTK 2.44.4 Backport-of: bc5adfa9b6f9180eb32930f61e59fdc46a83cb73 - PR: https://git.openjdk.org/jfx23u/pull/22
[jfx23u] RFR: 8340208: Additional WebKit 619.1 fixes from WebKitGTK 2.44.4
Clean Backport - Commit messages: - Backport bc5adfa9b6f9180eb32930f61e59fdc46a83cb73 Changes: https://git.openjdk.org/jfx23u/pull/22/files Webrev: https://webrevs.openjdk.org/?repo=jfx23u&pr=22&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340208 Stats: 596 lines in 103 files changed: 376 ins; 116 del; 104 mod Patch: https://git.openjdk.org/jfx23u/pull/22.diff Fetch: git fetch https://git.openjdk.org/jfx23u.git pull/22/head:pull/22 PR: https://git.openjdk.org/jfx23u/pull/22
Integrated: 8340208: Additional WebKit 619.1 fixes from WebKitGTK 2.44.4
On Mon, 16 Sep 2024 18:45:45 GMT, Hima Bindu Meda wrote: > Updated additional webkit-619.1 fixes from webkitgtk-2.44.4. Build is > successful on all platforms.No issues seen This pull request has now been integrated. Changeset: bc5adfa9 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx/commit/bc5adfa9b6f9180eb32930f61e59fdc46a83cb73 Stats: 596 lines in 103 files changed: 376 ins; 116 del; 104 mod 8340208: Additional WebKit 619.1 fixes from WebKitGTK 2.44.4 Reviewed-by: kcr, sykora - PR: https://git.openjdk.org/jfx/pull/1570
Re: RFR: 8340208: Additional WebKit 619.1 fixes from WebKitGTK 2.44.4 [v2]
On Wed, 18 Sep 2024 12:22:08 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update copyright > > modules/javafx.web/src/main/native/Source/WebKitLegacy/java/WebCoreSupport/HistoryItemClientJava.cpp > line 1: > >> 1: #include "HistoryItemClientJava.h" > > Where did this file come from? I don't see any changes related to > HistoryItemClient in the 2.44.4 release of WebKitGTK? > > Presuming we need this file, it will need a proper copyright header. This file has been added in order to adapt to the changes to the interface added as part of webkit commit def02cb5c4c24ed8a05e4e5075eb6ec95216ef80 in HistoryItem.h. Added the copyright header. > modules/javafx.web/src/main/native/Source/WebKitLegacy/java/WebCoreSupport/HistoryItemClientJava.h > line 1: > >> 1: #pragma once > > Presuming we need this file, it will need a proper copyright header. Updated the copyright - PR Review Comment: https://git.openjdk.org/jfx/pull/1570#discussion_r1767328674 PR Review Comment: https://git.openjdk.org/jfx/pull/1570#discussion_r1767329292
Re: RFR: 8340208: Additional WebKit 619.1 fixes from WebKitGTK 2.44.4 [v2]
> Updated additional webkit-619.1 fixes from webkitgtk-2.44.4. Build is > successful on all platforms.No issues seen Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Update copyright - Changes: - all: https://git.openjdk.org/jfx/pull/1570/files - new: https://git.openjdk.org/jfx/pull/1570/files/2170f347..b62cf532 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1570&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1570&range=00-01 Stats: 50 lines in 2 files changed: 50 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jfx/pull/1570.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1570/head:pull/1570 PR: https://git.openjdk.org/jfx/pull/1570
RFR: 8340208: Additional WebKit 619.1 fixes from WebKitGTK 2.44.4
Updated additional webkit-619.1 fixes from webkitgtk-2.44.4. Build is successful on all platforms.No issues seen - Commit messages: - WebKit 619.1 fixes from WebKitGTK 2.44.4 Changes: https://git.openjdk.org/jfx/pull/1570/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1570&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340208 Stats: 546 lines in 103 files changed: 326 ins; 116 del; 104 mod Patch: https://git.openjdk.org/jfx/pull/1570.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1570/head:pull/1570 PR: https://git.openjdk.org/jfx/pull/1570
Re: RFR: 8337481: File API: file.name contains path instead of name [v3]
On Fri, 30 Aug 2024 11:34:56 GMT, Oliver Schmidtmer wrote: >> FileSystemJava had no valid implementation for pathFileName since the >> function was renamed from pathGetFileName to pathFileName in the >> FileSystem.h from WebKit > > Oliver Schmidtmer has updated the pull request incrementally with one > additional commit since the last revision: > > Requested changes from review Changes look fine. Verified that full file path is shown without the fix . With the fix, only the file name is shown, as expected. - Marked as reviewed by hmeda (Committer). PR Review: https://git.openjdk.org/jfx/pull/1551#pullrequestreview-2273127246
[jfx23u] Integrated: 8338307: Additional WebKit 619.1 fixes from WebKitGTK 2.44.3
On Mon, 26 Aug 2024 07:11:30 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: 2e2af94a Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx23u/commit/2e2af94a19e771de13706ce7f458e355bc614545 Stats: 1276 lines in 181 files changed: 721 ins; 113 del; 442 mod 8338307: Additional WebKit 619.1 fixes from WebKitGTK 2.44.3 Backport-of: aa52f7efc370a4c55ff7a05a6903988871436d64 - PR: https://git.openjdk.org/jfx23u/pull/15
[jfx23u] RFR: 8338307: Additional WebKit 619.1 fixes from WebKitGTK 2.44.3
Clean Backport - Commit messages: - Backport aa52f7efc370a4c55ff7a05a6903988871436d64 Changes: https://git.openjdk.org/jfx23u/pull/15/files Webrev: https://webrevs.openjdk.org/?repo=jfx23u&pr=15&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338307 Stats: 1276 lines in 181 files changed: 721 ins; 113 del; 442 mod Patch: https://git.openjdk.org/jfx23u/pull/15.diff Fetch: git fetch https://git.openjdk.org/jfx23u.git pull/15/head:pull/15 PR: https://git.openjdk.org/jfx23u/pull/15
Integrated: 8338307 : Additional WebKit 619.1 fixes from WebKitGTK 2.44.3
On Wed, 21 Aug 2024 09:53:24 GMT, Hima Bindu Meda wrote: > Updated additonal fixes from webkit-2.44.3. Verified build on all platforms. > No issue seen. This pull request has now been integrated. Changeset: aa52f7ef Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx/commit/aa52f7efc370a4c55ff7a05a6903988871436d64 Stats: 1276 lines in 181 files changed: 721 ins; 113 del; 442 mod 8338307: Additional WebKit 619.1 fixes from WebKitGTK 2.44.3 Reviewed-by: kcr, sykora - PR: https://git.openjdk.org/jfx/pull/1541
RFR: 8338307 : Additional WebKit 619.1 fixes from WebKitGTK 2.44.3
Updated additonal fixes from webkit-2.44.3. Verified build on all platforms. No issue seen. - Commit messages: - correct spaces - Update changes related to webkit-2.44.3 Changes: https://git.openjdk.org/jfx/pull/1541/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1541&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338307 Stats: 1276 lines in 181 files changed: 721 ins; 113 del; 442 mod Patch: https://git.openjdk.org/jfx/pull/1541.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1541/head:pull/1541 PR: https://git.openjdk.org/jfx/pull/1541
[jfx23u] Integrated: 8338306: WebView Drag and Drop fails with WebKit 619.1
Clean Backport - Commit messages: - Backport 67ac9d7804cd8d572bcc3e06e2f640d8a744d3bb Changes: https://git.openjdk.org/jfx23u/pull/12/files Webrev: https://webrevs.openjdk.org/?repo=jfx23u&pr=12&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338306 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jfx23u/pull/12.diff Fetch: git fetch https://git.openjdk.org/jfx23u.git pull/12/head:pull/12 PR: https://git.openjdk.org/jfx23u/pull/12
[jfx23u] Integrated: 8338306: WebView Drag and Drop fails with WebKit 619.1
On Thu, 22 Aug 2024 12:35:07 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: 82110a38 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx23u/commit/82110a38b2895c607d6d33109c95fb5c8bd9bfec Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8338306: WebView Drag and Drop fails with WebKit 619.1 Backport-of: 67ac9d7804cd8d572bcc3e06e2f640d8a744d3bb - PR: https://git.openjdk.org/jfx23u/pull/12
Integrated: 8338306: WebView Drag and Drop fails with WebKit 619.1
On Mon, 19 Aug 2024 09:32:22 GMT, Hima Bindu Meda wrote: > This commit resolves drag and drop issue observed with Webkit-619.1. Verified > build on all platforms. No issue seen This pull request has now been integrated. Changeset: 67ac9d78 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx/commit/67ac9d7804cd8d572bcc3e06e2f640d8a744d3bb Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8338306: WebView Drag and Drop fails with WebKit 619.1 Reviewed-by: kcr, sykora - PR: https://git.openjdk.org/jfx/pull/1538
Re: RFR: 8338306: WebView Drag and Drop fails with WebKit 619.1 [v2]
On Mon, 19 Aug 2024 18:14:53 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove duplicate call > > modules/javafx.web/src/main/native/Source/WebKitLegacy/java/WebCoreSupport/WebPage.cpp > line 2254: > >> 2252: return 0; >> 2253: case com_sun_webkit_WebPage_DND_DST_ENTER: >> 2254: return >> dragOperationToDragCursor(std::get>(dc.dragEnteredOrUpdated(*localMainFrame, >> WTFMove(dragData; > > This is identical to the body of the two cases below. It might be clearer to > remove this return statement (line 2254) to avoid duplication. > > Speaking of which, I presume that it is intentional to call > `dragOperationToDragCursor` for all three of `DND_DST_ENTER`, `DND_DST_OVER`, > and `DND_DST_CHANGE`? Yes, removed the duplicate call. In webkit-617.1, there were calls to **dragEntered** and **dragUpdated** for DND calls as follows: ` case com_sun_webkit_WebPage_DND_DST_ENTER: return dragOperationToDragCursor(dc.dragEntered(WTFMove(dragData)));` `case com_sun_webkit_WebPage_DND_DST_OVER: case com_sun_webkit_WebPage_DND_DST_CHANGE: return dragOperationToDragCursor(dc.dragUpdated(WTFMove(dragData)));` In the current webkit-619.1 update, there has been refactoring and the apis **dragEntered** and **dragUpdated** have been removed and instead **dragEnteredOrUpdated** has been used. For our JAVA port adaptation, these changes have been missed and hence, the issue is observed. This fix addresses the issue. - PR Review Comment: https://git.openjdk.org/jfx/pull/1538#discussion_r1723371767
Re: RFR: 8338306: WebView Drag and Drop fails with WebKit 619.1 [v2]
> This commit resolves drag and drop issue observed with Webkit-619.1. Verified > build on all platforms. No issue seen Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Remove duplicate call - Changes: - all: https://git.openjdk.org/jfx/pull/1538/files - new: https://git.openjdk.org/jfx/pull/1538/files/4a127528..7ef15ec2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1538&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1538&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jfx/pull/1538.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1538/head:pull/1538 PR: https://git.openjdk.org/jfx/pull/1538
[jfx23u] Integrated: 8336941: Update libxslt to 1.1.42
On Mon, 19 Aug 2024 16:55:46 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: 48853242 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx23u/commit/48853242735bc08c909eb0cb0a68a08ec50f7109 Stats: 478 lines in 19 files changed: 111 ins; 316 del; 51 mod 8336941: Update libxslt to 1.1.42 Backport-of: dc8f607e4ce95e348bb812a1c942e4321c00f0f8 - PR: https://git.openjdk.org/jfx23u/pull/10
[jfx23u] Integrated: 8336941: Update libxslt to 1.1.42
Clean Backport - Commit messages: - Backport dc8f607e4ce95e348bb812a1c942e4321c00f0f8 Changes: https://git.openjdk.org/jfx23u/pull/10/files Webrev: https://webrevs.openjdk.org/?repo=jfx23u&pr=10&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336941 Stats: 478 lines in 19 files changed: 111 ins; 316 del; 51 mod Patch: https://git.openjdk.org/jfx23u/pull/10.diff Fetch: git fetch https://git.openjdk.org/jfx23u.git pull/10/head:pull/10 PR: https://git.openjdk.org/jfx23u/pull/10
RFR: 8338306: WebView Drag and Drop fails with WebKit 619.1
This commit resolves drag and drop issue observed with Webkit-619.1. Verified build on all platforms. No issue seen - Commit messages: - Resolve DragandDrop issue Changes: https://git.openjdk.org/jfx/pull/1538/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1538&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338306 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jfx/pull/1538.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1538/head:pull/1538 PR: https://git.openjdk.org/jfx/pull/1538
Integrated: 8336941 : Update libxslt to 1.1.42
On Fri, 2 Aug 2024 06:36:22 GMT, Hima Bindu Meda wrote: > Updated libxslt to v1.1.42. Verified build on all platforms. No issue seen This pull request has now been integrated. Changeset: dc8f607e Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx/commit/dc8f607e4ce95e348bb812a1c942e4321c00f0f8 Stats: 478 lines in 19 files changed: 111 ins; 316 del; 51 mod 8336941: Update libxslt to 1.1.42 Reviewed-by: kcr, jbhaskar - PR: https://git.openjdk.org/jfx/pull/1527
Re: RFR: 8336941 : Update libxslt to 1.1.42 [v2]
> Updated libxslt to v1.1.42. Verified build on all platforms. No issue seen Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Remove deprecated file - Changes: - all: https://git.openjdk.org/jfx/pull/1527/files - new: https://git.openjdk.org/jfx/pull/1527/files/92dd8395..650d1d20 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1527&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1527&range=00-01 Stats: 190 lines in 1 file changed: 0 ins; 190 del; 0 mod Patch: https://git.openjdk.org/jfx/pull/1527.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1527/head:pull/1527 PR: https://git.openjdk.org/jfx/pull/1527
RFR: 8336941 : Update libxslt to 1.1.42
Updated libxslt to v1.1.42. Verified build on all platforms. No issue seen - Commit messages: - Update libxslt to v1.1.42 Changes: https://git.openjdk.org/jfx/pull/1527/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1527&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336941 Stats: 288 lines in 18 files changed: 111 ins; 126 del; 51 mod Patch: https://git.openjdk.org/jfx/pull/1527.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1527/head:pull/1527 PR: https://git.openjdk.org/jfx/pull/1527
Re: RFR: 8336798: DRT test cssrounding.html test for linear layout fails with WebKit 619.1 [v5]
On Sun, 21 Jul 2024 07:03:11 GMT, Jay Bhaskar wrote: >> Issue: CSSRounding.html DRT Test fails due sub pixel layout. The fractional >> value adds up to 1px extra height. >> Solution: The Prefer height calculation should do flooring of fractional >> values. This is valid for Linear Layout which is a legacy support to most of >> the browsers. > > Jay Bhaskar has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Merge remote-tracking branch 'upstream/master' into 8336798 > - make test as JNUIT5 and apply review comments > - restore master file > - remove extra files checked in by mistake > - 8336798: DRT test cssrounding.html test for linear layout fails with > WebKit 619.1 > - 8335548: testCookieEnabled fails with WebKit 619.1 Verified that the test is now successful. Changes look fine - Marked as reviewed by hmeda (Committer). PR Review: https://git.openjdk.org/jfx/pull/1514#pullrequestreview-2190650467
Re: RFR: 8336798: DRT test cssrounding.html test for linear layout fails with WebKit 619.1
On Fri, 19 Jul 2024 06:53:16 GMT, Jay Bhaskar wrote: > Issue: CSSRounding.html DRT Test fails due sub pixel layout. The fractional > value adds up to 1px extra height. > Solution: The Prefer height calculation should do flooring of fractional > values. This is valid for Linear Layout which is a legacy support to most of > the browsers. As the changes in MiscellaneousTest.java and cookie.html are not related to this PR, these files should be removed from this PR. - PR Review: https://git.openjdk.org/jfx/pull/1514#pullrequestreview-2188243310
[jfx23u] Integrated: 8328994: Update WebKit to 619.1
On Fri, 19 Jul 2024 05:25:48 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: eec590a3 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx23u/commit/eec590a377e7f7b2f91d075008352cc53b2e1240 Stats: 349763 lines in 7157 files changed: 184133 ins; 107646 del; 57984 mod 8328994: Update WebKit to 619.1 Backport-of: 34bbf85362fae946c6306eb52a8478aa2ca3ef5f - PR: https://git.openjdk.org/jfx23u/pull/4
[jfx23u] RFR: 8328994: Update WebKit to 619.1
Clean Backport - Commit messages: - Backport 34bbf85362fae946c6306eb52a8478aa2ca3ef5f Changes: https://git.openjdk.org/jfx23u/pull/4/files Webrev: Webrev is not available because diff is too large Issue: https://bugs.openjdk.org/browse/JDK-8328994 Stats: 349763 lines in 7157 files changed: 184133 ins; 107646 del; 57984 mod Patch: https://git.openjdk.org/jfx23u/pull/4.diff Fetch: git fetch https://git.openjdk.org/jfx23u.git pull/4/head:pull/4 PR: https://git.openjdk.org/jfx23u/pull/4
Integrated: 8328994 : Update WebKit to 619.1
On Fri, 12 Jul 2024 08:29:34 GMT, Hima Bindu Meda wrote: > This PR updates Webkit to v619.1. > Build is verified in mac , windows and linux. Sanity testing looks fine. No > issues seen. This pull request has now been integrated. Changeset: 34bbf853 Author:Hima Bindu Meda URL: https://git.openjdk.org/jfx/commit/34bbf85362fae946c6306eb52a8478aa2ca3ef5f Stats: 349763 lines in 7157 files changed: 184133 ins; 107646 del; 57984 mod 8328994: Update WebKit to 619.1 Co-authored-by: Jay Bhaskar Reviewed-by: kcr, sykora - PR: https://git.openjdk.org/jfx/pull/1502
RFR: 8328994 : Update WebKit to 619.1
This PR updates Webkit to v619.1. Build is verified in mac , windows and linux. Sanity testing looks fine. No issues seen. - Commit messages: - whitespace correction - Update webkit to v619.1 Changes: https://git.openjdk.org/jfx/pull/1502/files Webrev: Webrev is not available because diff is too large Issue: https://bugs.openjdk.org/browse/JDK-8328994 Stats: 349763 lines in 7157 files changed: 184133 ins; 107646 del; 57984 mod Patch: https://git.openjdk.org/jfx/pull/1502.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1502/head:pull/1502 PR: https://git.openjdk.org/jfx/pull/1502
Re: RFR: 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined
On Fri, 21 Jun 2024 09:02:43 GMT, Ao Qi wrote: > This problem has been fixed > [upstream](https://github.com/WebKit/WebKit/pull/23282). This patch merges > the fix in advance. > > Error log: > > > /some_dir/jfx/modules/javafx.web/src/main/native/Source/WTF/wtf/StackPointer.cpp:140:2: > error: #error "Unsupported platform: need implementation of > currentStackPointer." > 140 | #error "Unsupported platform: need implementation of > currentStackPointer." > | ^ > make[2]: *** [Source/WTF/wtf/CMakeFiles/WTF.dir/build.make:1098: > Source/WTF/wtf/CMakeFiles/WTF.dir/StackPointer.cpp.o] Error 1 > make[2]: *** Waiting for unfinished jobs > make[1]: *** [CMakeFiles/Makefile2:360: > Source/WTF/wtf/CMakeFiles/WTF.dir/all] Error 2 Changes look fine. - Marked as reviewed by hmeda (Committer). PR Review: https://git.openjdk.org/jfx/pull/1482#pullrequestreview-2144209115
Re: RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update [v4]
On Fri, 21 Jun 2024 00:07:33 GMT, Jay Bhaskar wrote:
>> Issue: The Websocket Channel is broken
>> Solution: The socket Provider needs a web page pointer, since the web socket
>> channel source code is moved to WebkitLegacy in 617.1 for the web process
>> model, it is invalid for JavaFx Webkit.
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typos meesage to message
Changes look fine
tests/manual/web/WebSocketTestApp.java line 70:
> 68: loadButton.setOnAction(e -> {
> 69: URL url = this.getClass().getResource("websocket.html");
> 70: System.out.println(url);
Minor:Is it required to print url in the terminal?
-
Marked as reviewed by hmeda (Committer).
PR Review: https://git.openjdk.org/jfx/pull/1477#pullrequestreview-2132540876
PR Review Comment: https://git.openjdk.org/jfx/pull/1477#discussion_r1648894257
[jfx22u] Integrated: 8332539: Update libxml2 to 2.12.7
Clean Backport - Commit messages: - Backport dedcf1d236b5429dcf3c42f5fd1095b28d5da063 Changes: https://git.openjdk.org/jfx22u/pull/32/files Webrev: https://webrevs.openjdk.org/?repo=jfx22u&pr=32&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332539 Stats: 67 lines in 9 files changed: 26 ins; 9 del; 32 mod Patch: https://git.openjdk.org/jfx22u/pull/32.diff Fetch: git fetch https://git.openjdk.org/jfx22u.git pull/32/head:pull/32 PR: https://git.openjdk.org/jfx22u/pull/32
[jfx22u] Integrated: 8332539: Update libxml2 to 2.12.7
On Fri, 31 May 2024 05:22:11 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: f0c3e88a Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx22u/commit/f0c3e88a8b26522836bb731800fa5daa9e41b293 Stats: 67 lines in 9 files changed: 26 ins; 9 del; 32 mod 8332539: Update libxml2 to 2.12.7 Backport-of: dedcf1d236b5429dcf3c42f5fd1095b28d5da063 - PR: https://git.openjdk.org/jfx22u/pull/32
Integrated: 8332539: Update libxml2 to 2.12.7
On Fri, 24 May 2024 18:18:22 GMT, Hima Bindu Meda wrote: > Updated libxml to v2.12.7. Sanity testing looks fine. No issue seen This pull request has now been integrated. Changeset: dedcf1d2 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx/commit/dedcf1d236b5429dcf3c42f5fd1095b28d5da063 Stats: 67 lines in 9 files changed: 26 ins; 9 del; 32 mod 8332539: Update libxml2 to 2.12.7 Reviewed-by: kcr, sykora - PR: https://git.openjdk.org/jfx/pull/1464
RFR: 8332539: Update libxml2 to 2.12.7
Updated libxml to v2.12.7. Sanity testing looks fine. No issue seen - Commit messages: - configure libxml on windows - configure libxml on linux - update libxml to v2.12.7 Changes: https://git.openjdk.org/jfx/pull/1464/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1464&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332539 Stats: 67 lines in 9 files changed: 26 ins; 9 del; 32 mod Patch: https://git.openjdk.org/jfx/pull/1464.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1464/head:pull/1464 PR: https://git.openjdk.org/jfx/pull/1464
[jfx22u] Integrated: 8329011: Update SQLite to 3.45.3
On Tue, 21 May 2024 06:35:26 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: c0a15b7f Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx22u/commit/c0a15b7f9bde343c686a8ed545f8da16dcaf5d87 Stats: 26451 lines in 4 files changed: 17765 ins; 2993 del; 5693 mod 8329011: Update SQLite to 3.45.3 Backport-of: 581e3a70a45a550a97e391e06735f4837336ada8 - PR: https://git.openjdk.org/jfx22u/pull/31
[jfx22u] Integrated: 8331748: Update libxml2 to 2.12.6
On Tue, 21 May 2024 06:34:22 GMT, Hima Bindu Meda wrote: > Clean backport This pull request has now been integrated. Changeset: 8cdc502f Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx22u/commit/8cdc502f44b1046780913afe8d4157a521cb2f52 Stats: 24912 lines in 115 files changed: 8485 ins; 11207 del; 5220 mod 8331748: Update libxml2 to 2.12.6 Backport-of: 97b1402501983f121f75c24a510f466837fa2ecc - PR: https://git.openjdk.org/jfx22u/pull/30
[jfx22u] RFR: 8329011: Update SQLite to 3.45.3
Clean Backport - Commit messages: - Backport 581e3a70a45a550a97e391e06735f4837336ada8 Changes: https://git.openjdk.org/jfx22u/pull/31/files Webrev: https://webrevs.openjdk.org/?repo=jfx22u&pr=31&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329011 Stats: 26451 lines in 4 files changed: 17765 ins; 2993 del; 5693 mod Patch: https://git.openjdk.org/jfx22u/pull/31.diff Fetch: git fetch https://git.openjdk.org/jfx22u.git pull/31/head:pull/31 PR: https://git.openjdk.org/jfx22u/pull/31
[jfx22u] RFR: 8331748: Update libxml2 to 2.12.6
Clean backport - Commit messages: - Backport 97b1402501983f121f75c24a510f466837fa2ecc Changes: https://git.openjdk.org/jfx22u/pull/30/files Webrev: https://webrevs.openjdk.org/?repo=jfx22u&pr=30&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331748 Stats: 24912 lines in 115 files changed: 8485 ins; 11207 del; 5220 mod Patch: https://git.openjdk.org/jfx22u/pull/30.diff Fetch: git fetch https://git.openjdk.org/jfx22u.git pull/30/head:pull/30 PR: https://git.openjdk.org/jfx22u/pull/30
Integrated: 8331748: Update libxml2 to 2.12.6
On Tue, 14 May 2024 05:21:37 GMT, Hima Bindu Meda wrote: > Updated libxml to v2.12.6. Verified build and sanity testing on all > platforms. No issue seen This pull request has now been integrated. Changeset: 97b14025 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx/commit/97b1402501983f121f75c24a510f466837fa2ecc Stats: 24912 lines in 115 files changed: 8485 ins; 11207 del; 5220 mod 8331748: Update libxml2 to 2.12.6 Reviewed-by: kcr, sykora - PR: https://git.openjdk.org/jfx/pull/1453
Integrated: 8329011: Update SQLite to 3.45.3
On Tue, 14 May 2024 11:45:06 GMT, Hima Bindu Meda wrote: > Update SQLite to v3.45.3.Verified build on all platforms. Sanity testing > looks fine. This pull request has now been integrated. Changeset: 581e3a70 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx/commit/581e3a70a45a550a97e391e06735f4837336ada8 Stats: 26451 lines in 4 files changed: 17765 ins; 2993 del; 5693 mod 8329011: Update SQLite to 3.45.3 Reviewed-by: sykora, kcr - PR: https://git.openjdk.org/jfx/pull/1454
RFR: 8329011: Update SQLite to 3.45.3
Update SQLite to v3.45.3.Verified build on all platforms. Sanity testing looks fine. - Commit messages: - whitespace correction - Update sqlite to v3.45.3 Changes: https://git.openjdk.org/jfx/pull/1454/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1454&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329011 Stats: 26451 lines in 4 files changed: 17765 ins; 2993 del; 5693 mod Patch: https://git.openjdk.org/jfx/pull/1454.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1454/head:pull/1454 PR: https://git.openjdk.org/jfx/pull/1454
RFR: 8331748: Update libxml2 to 2.12.6
Updated libxml to v2.12.6. Verified build and sanity testing on all platforms. No issue seen - Commit messages: - whitespace correction - update md file - Configure libxml on windows - configure libxml on linux - add missing headers - Update libxml to v2.12.6 Changes: https://git.openjdk.org/jfx/pull/1453/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1453&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331748 Stats: 24912 lines in 115 files changed: 8485 ins; 11207 del; 5220 mod Patch: https://git.openjdk.org/jfx/pull/1453.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1453/head:pull/1453 PR: https://git.openjdk.org/jfx/pull/1453
Re: RFR: 8328752: Fix missing @Overrides in javafx.web
On Thu, 21 Mar 2024 23:48:40 GMT, Andy Goryachev wrote: > Fix missing @Overrides in **javafx.web**. > > This is still a trivial change since all the spots are identified by the IDE. Changes look good - Marked as reviewed by hmeda (Committer). PR Review: https://git.openjdk.org/jfx/pull/1424#pullrequestreview-1977554056
Re: RFR: 8328749: Remove unused imports in javafx.web [v2]
On Fri, 22 Mar 2024 16:11:52 GMT, Andy Goryachev wrote: >> Using Eclipse IDE to remove unused imports **javafx.web** module, and update >> the copyright year to 2024. Using wildcard for more than 10 static imports. >> >> >> -- >> >> This is a trivial change, 1 reviewer is probably enough. > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > removed swing file Verified Build and unit tests. No issue seen. Added few minor comments - Marked as reviewed by hmeda (Committer). PR Review: https://git.openjdk.org/jfx/pull/1421#pullrequestreview-1959499931
Re: RFR: 8328749: Remove unused imports in javafx.web [v2]
On Fri, 22 Mar 2024 16:11:52 GMT, Andy Goryachev wrote: >> Using Eclipse IDE to remove unused imports **javafx.web** module, and update >> the copyright year to 2024. Using wildcard for more than 10 static imports. >> >> >> -- >> >> This is a trivial change, 1 reviewer is probably enough. > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > removed swing file modules/javafx.web/src/main/native/Source/WebCore/bindings/java/dom3/java/com/sun/webkit/dom/DOMWindowImpl.java line 37: > 35: import org.w3c.dom.views.AbstractView; > 36: import org.w3c.dom.views.DocumentView; > 37: import com.sun.webkit.Disposer; Minor: Generally, imports are added in alphabetic order. modules/javafx.web/src/main/native/Source/WebCore/bindings/java/dom3/java/com/sun/webkit/dom/NodeImpl.java line 38: > 36: import org.w3c.dom.events.EventListener; > 37: import org.w3c.dom.events.EventTarget; > 38: import com.sun.webkit.Disposer; Minor: Generally, imports are added in alphabetic order. - PR Review Comment: https://git.openjdk.org/jfx/pull/1421#discussion_r1538678437 PR Review Comment: https://git.openjdk.org/jfx/pull/1421#discussion_r1538678727
[jfx22u] Integrated: 8324326: Update ICU4C to 74.2
On Tue, 19 Mar 2024 16:32:55 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: 32378354 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx22u/commit/323783541140bea2119e2e59d0bb2d8d1fb37c8a Stats: 10765 lines in 123 files changed: 3601 ins; 1545 del; 5619 mod 8324326: Update ICU4C to 74.2 Backport-of: ad3d44e27f8ffb90aad81497f0bba2b00f7a49aa - PR: https://git.openjdk.org/jfx22u/pull/20
[jfx22u] Integrated: 8324326: Update ICU4C to 74.2
Clean Backport - Commit messages: - Backport ad3d44e27f8ffb90aad81497f0bba2b00f7a49aa Changes: https://git.openjdk.org/jfx22u/pull/20/files Webrev: https://webrevs.openjdk.org/?repo=jfx22u&pr=20&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324326 Stats: 10765 lines in 123 files changed: 3601 ins; 1545 del; 5619 mod Patch: https://git.openjdk.org/jfx22u/pull/20.diff Fetch: git fetch https://git.openjdk.org/jfx22u.git pull/20/head:pull/20 PR: https://git.openjdk.org/jfx22u/pull/20
Integrated: 8324326: Update ICU4C to 74.2
On Tue, 12 Mar 2024 14:45:06 GMT, Hima Bindu Meda wrote: > Updated icu to v74.2. Sanity testing looks fine. Verified build on all > platforms This pull request has now been integrated. Changeset: ad3d44e2 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx/commit/ad3d44e27f8ffb90aad81497f0bba2b00f7a49aa Stats: 10765 lines in 123 files changed: 3601 ins; 1545 del; 5619 mod 8324326: Update ICU4C to 74.2 Reviewed-by: kcr, sykora - PR: https://git.openjdk.org/jfx/pull/1398
Re: RFR: 8324326: Update ICU4C to 74.2
On Tue, 12 Mar 2024 15:02:48 GMT, Kevin Rushforth wrote: >> modules/javafx.web/src/main/native/Source/ThirdParty/icu/CMakeLists.txt line >> 593: >> >>> 591: >>> 592: # Get just file name without extension >>> 593: set(ICU_DATA_FILE_NAME "icudt74l") >> >> Shouldn't this be 742? > > Never mind. I see now that's an `l` not a `1` after the `74. Sorry for the > noise. icu4c-74_2-data-bin-l contains the dat file named as icudt74l.dat. Hence, this is correct. - PR Review Comment: https://git.openjdk.org/jfx/pull/1398#discussion_r1521671716
RFR: 8324326: Update ICU4C to 74.2
Updated icu to v74.2. Sanity testing looks fine. Verified build on all platforms - Commit messages: - Revert file permissions similar to master - Tab correction - Resolve PR error - Tab Correction - Merge branch 'master' into icu-74 - updated LICENSE - white space corrections - Add missing header files - Update ICU to v74.2 Changes: https://git.openjdk.org/jfx/pull/1398/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1398&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324326 Stats: 10765 lines in 123 files changed: 3601 ins; 1545 del; 5619 mod Patch: https://git.openjdk.org/jfx/pull/1398.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1398/head:pull/1398 PR: https://git.openjdk.org/jfx/pull/1398
[jfx22u] Integrated: 8326989: Text selection issues on WebView after WebKit 617.1
On Thu, 7 Mar 2024 12:43:17 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: 419bad3a Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx22u/commit/419bad3a4053abe215329a5228789f2c876ab287 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8326989: Text selection issues on WebView after WebKit 617.1 Backport-of: 64af987576214fc5483520ce8131895be74a641d - PR: https://git.openjdk.org/jfx22u/pull/18
[jfx22u] RFR: 8326989: Text selection issues on WebView after WebKit 617.1
Clean Backport - Commit messages: - Backport 64af987576214fc5483520ce8131895be74a641d Changes: https://git.openjdk.org/jfx22u/pull/18/files Webrev: https://webrevs.openjdk.org/?repo=jfx22u&pr=18&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326989 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jfx22u/pull/18.diff Fetch: git fetch https://git.openjdk.org/jfx22u.git pull/18/head:pull/18 PR: https://git.openjdk.org/jfx22u/pull/18
Integrated: 8326989 : Text selection issues on WebView after WebKit 617.1
On Wed, 6 Mar 2024 14:51:40 GMT, Hima Bindu Meda wrote: > Text Selection issue is observed due to a pending layout call. This issue is > resolved by a call to the method "updateSelectionAppearanceNow". > Verified Sanity testing and unit test verification looks fine. No issue seen. > > Note: Unit test in order to validate the fix, is in progress. Due to the > robustness of the implementation to verify on all platforms, the test would > be added in a followon > bug-[JDK-8327478](https://bugs.openjdk.org/browse/JDK-8327478) This pull request has now been integrated. Changeset: 64af9875 Author:Hima Bindu Meda URL: https://git.openjdk.org/jfx/commit/64af987576214fc5483520ce8131895be74a641d Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8326989: Text selection issues on WebView after WebKit 617.1 Co-authored-by: Jay Bhaskar Reviewed-by: kcr, jpereda - PR: https://git.openjdk.org/jfx/pull/1391
RFR: 8326989 : Text selection issues on WebView after WebKit 617.1
Text Selection issue is observed due to a pending layout call. This issue is resolved by a call to the method "updateSelectionAppearanceNow". Verified Sanity testing and unit test verification looks fine. No issue seen. Note: Unit test in order to validate the fix, is in progress. Due to the robustness of the implementation to verify on all platforms, the test would be added in a followon bug-[JDK-8327478](https://bugs.openjdk.org/browse/JDK-8327478) - Commit messages: - Space correction - Resolve text selection issue Changes: https://git.openjdk.org/jfx/pull/1391/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1391&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326989 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jfx/pull/1391.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1391/head:pull/1391 PR: https://git.openjdk.org/jfx/pull/1391
Re: RFR: 8323880: Caret rendered at wrong position in case of a click event on RTL text
On Tue, 13 Feb 2024 16:57:37 GMT, Jay Bhaskar wrote: > Issue: The current implementation of complex text rendering paths on the Java > platform is experiencing side effects. > Solution: We need to align with WebKit 616.1 standards. The patch supports > two paths simple rendering path and complex rendering path based on text > rendering mode. Sanity testing is fine - Marked as reviewed by hmeda (Committer). PR Review: https://git.openjdk.org/jfx/pull/1364#pullrequestreview-1884305369
[jfx22u] Integrated: 8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5
On Mon, 12 Feb 2024 15:46:41 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: 82618d0e Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx22u/commit/82618d0e41806df238128b7199a09bf208ebb428 Stats: 1877 lines in 128 files changed: 1101 ins; 288 del; 488 mod 8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5 Backport-of: a7f6de8d13fd7a7e37ca80b28badcb24566153d8 - PR: https://git.openjdk.org/jfx22u/pull/11
[jfx22u] Integrated: 8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5
Clean Backport - Commit messages: - Backport a7f6de8d13fd7a7e37ca80b28badcb24566153d8 Changes: https://git.openjdk.org/jfx22u/pull/11/files Webrev: https://webrevs.openjdk.org/?repo=jfx22u&pr=11&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325258 Stats: 1877 lines in 128 files changed: 1101 ins; 288 del; 488 mod Patch: https://git.openjdk.org/jfx22u/pull/11.diff Fetch: git fetch https://git.openjdk.org/jfx22u.git pull/11/head:pull/11 PR: https://git.openjdk.org/jfx22u/pull/11
Integrated: 8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5
On Fri, 9 Feb 2024 17:05:53 GMT, Hima Bindu Meda wrote: > Ported changes related to webkit-2.42.5. Verified build on all platforms. > Sanity testing looks fine. This pull request has now been integrated. Changeset: a7f6de8d Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx/commit/a7f6de8d13fd7a7e37ca80b28badcb24566153d8 Stats: 1877 lines in 128 files changed: 1101 ins; 288 del; 488 mod 8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5 Reviewed-by: sykora, kcr - PR: https://git.openjdk.org/jfx/pull/1362
RFR: 8325258: Cherry-pick WebKit 617.1 stabilization fixes (2)
Cherry-picked changes related to webkit-2.42.5. Verified build on all platforms. Sanity testing looks fine. - Commit messages: - white space correction - commit 3d5373575695b293b8559155431d0079a6153aff from webkitglib/2.42 to resolve build error on 32 bit - cherry-pick 2.42.5 Changes: https://git.openjdk.org/jfx/pull/1362/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1362&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325258 Stats: 1877 lines in 128 files changed: 1101 ins; 288 del; 488 mod Patch: https://git.openjdk.org/jfx/pull/1362.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1362/head:pull/1362 PR: https://git.openjdk.org/jfx/pull/1362
[jfx22u] Integrated: 8324337: Cherry-pick WebKit 617.1 stabilization fixes
On Tue, 30 Jan 2024 11:56:35 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: a247278f Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx22u/commit/a247278f9818265e1d012981ea7a6fcc2748185a Stats: 1297 lines in 161 files changed: 752 ins; 111 del; 434 mod 8324337: Cherry-pick WebKit 617.1 stabilization fixes Backport-of: 52840a17dee6a92fb9b1f3ff1b314b0ae228b95f - PR: https://git.openjdk.org/jfx22u/pull/7
[jfx22u] RFR: 8324337: Cherry-pick WebKit 617.1 stabilization fixes
Clean Backport - Commit messages: - Backport 52840a17dee6a92fb9b1f3ff1b314b0ae228b95f Changes: https://git.openjdk.org/jfx22u/pull/7/files Webrev: https://webrevs.openjdk.org/?repo=jfx22u&pr=7&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324337 Stats: 1297 lines in 161 files changed: 752 ins; 111 del; 434 mod Patch: https://git.openjdk.org/jfx22u/pull/7.diff Fetch: git fetch https://git.openjdk.org/jfx22u.git pull/7/head:pull/7 PR: https://git.openjdk.org/jfx22u/pull/7
Integrated: JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes
On Thu, 25 Jan 2024 13:32:21 GMT, Hima Bindu Meda wrote: > Cherry-picked changes related to webkit-2.42.4.Verified build on all > platforms. Sanity testing looks fine. This pull request has now been integrated. Changeset: 52840a17 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx/commit/52840a17dee6a92fb9b1f3ff1b314b0ae228b95f Stats: 1297 lines in 161 files changed: 752 ins; 111 del; 434 mod 8324337: Cherry-pick WebKit 617.1 stabilization fixes Reviewed-by: kcr, sykora - PR: https://git.openjdk.org/jfx/pull/1350
Re: RFR: JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes [v3]
> Cherry-picked changes related to webkit-2.42.4.Verified build on all > platforms. Sanity testing looks fine. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: space corrections - Changes: - all: https://git.openjdk.org/jfx/pull/1350/files - new: https://git.openjdk.org/jfx/pull/1350/files/7417b819..229deb24 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1350&range=02 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1350&range=01-02 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jfx/pull/1350.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1350/head:pull/1350 PR: https://git.openjdk.org/jfx/pull/1350
Re: RFR: JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes [v2]
On Thu, 25 Jan 2024 15:46:24 GMT, Kevin Rushforth wrote:
>> Hima Bindu Meda has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor corrections as per review comments
>
> modules/javafx.web/src/main/native/Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp
> line 197:
>
>> 195: continue;
>> 196: placeholdersToRestore.append(&placeholder);
>> 197: }
>
> The added curly braces should be within `#if PLATFORM(JAVA)`.
>
> Minor: the indentation is off in a couple places.
>
> Minor: add a missing space after the `if` on line 191.
>
> Here is a suggestion:
>
>
> #if PLATFORM(JAVA)
> if (spannerAndPlaceholder.value.get() != nullptr)
> {
> #endif
> if (!placeholder.isDescendantOf(&container))
> continue;
> placeholdersToRestore.append(&placeholder);
> #if PLATFORM(JAVA)
> }
> #endif
done
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1350#discussion_r1467705618
Re: RFR: JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes [v2]
> Cherry-picked changes related to webkit-2.42.4.Verified build on all > platforms. Sanity testing looks fine. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Minor corrections as per review comments - Changes: - all: https://git.openjdk.org/jfx/pull/1350/files - new: https://git.openjdk.org/jfx/pull/1350/files/a5148855..7417b819 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1350&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1350&range=00-01 Stats: 5 lines in 1 file changed: 3 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jfx/pull/1350.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1350/head:pull/1350 PR: https://git.openjdk.org/jfx/pull/1350
RFR: JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes
Cherry-picked changes related to webkit-2.42.4.Verified build on all platforms. Sanity testing looks fine. - Commit messages: - Resolve compilation error - Cherrypick changes related to 2.42.4 Changes: https://git.openjdk.org/jfx/pull/1350/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1350&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324337 Stats: 1294 lines in 161 files changed: 750 ins; 111 del; 433 mod Patch: https://git.openjdk.org/jfx/pull/1350.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1350/head:pull/1350 PR: https://git.openjdk.org/jfx/pull/1350
[jfx22u] Integrated: 8318614: Update WebKit to 617.1
On Tue, 23 Jan 2024 14:26:35 GMT, Hima Bindu Meda wrote: > Clean Backport. This pull request has now been integrated. Changeset: 9336ba77 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx22u/commit/9336ba774e0e4ef06291b0785f3919a9932a0eca Stats: 289254 lines in 6439 files changed: 170206 ins; 83308 del; 35740 mod 8318614: Update WebKit to 617.1 Backport-of: ba79e081547b7f15697bfaaac42ec2de1971935a - PR: https://git.openjdk.org/jfx22u/pull/4
[jfx22u] RFR: 8318614: Update WebKit to 617.1
Clean Backport. - Commit messages: - Backport ba79e081547b7f15697bfaaac42ec2de1971935a Changes: https://git.openjdk.org/jfx22u/pull/4/files Webrev: https://webrevs.openjdk.org/?repo=jfx22u&pr=4&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318614 Stats: 289254 lines in 6439 files changed: 170206 ins; 83308 del; 35740 mod Patch: https://git.openjdk.org/jfx22u/pull/4.diff Fetch: git fetch https://git.openjdk.org/jfx22u.git pull/4/head:pull/4 PR: https://git.openjdk.org/jfx22u/pull/4
Re: RFR: 8323879: constructor Path(Path) which takes another Path object fail to draw on canvas html [v2]
On Fri, 19 Jan 2024 01:06:50 GMT, Jay Bhaskar wrote: >> Issue: constructor Path(Path) which takes another Path object fails to draw >> on canvas html. >> Solution: copy the old path while creating a new Path object from the >> existing Path that is already created with the same canvas rendering context. > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: > > remove unused variable and imports Verified the changes. Testing is green - Marked as reviewed by hmeda (Committer). PR Review: https://git.openjdk.org/jfx/pull/1339#pullrequestreview-1833275708
Integrated: 8318614: Update WebKit to 617.1
On Wed, 10 Jan 2024 17:53:46 GMT, Hima Bindu Meda wrote: > This PR updates webkit to v617.1. Verified build on Mac,Windows and linux. > Sanity testing looks fine. No issues observed in HelloWebView as well This pull request has now been integrated. Changeset: ba79e081 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx/commit/ba79e081547b7f15697bfaaac42ec2de1971935a Stats: 289254 lines in 6439 files changed: 170206 ins; 83308 del; 35740 mod 8318614: Update WebKit to 617.1 Co-authored-by: Jay Bhaskar Reviewed-by: sykora, kcr - PR: https://git.openjdk.org/jfx/pull/1328
RFR: 8318614: Update WebKit to 617.1
This PR updates webkit to v617.1. Verified build on Mac,Windows and linux. Sanity testing looks fine. No issues observed in HelloWebView as well - Commit messages: - Remove unwanted files - Update webkit to v617.1 Changes: https://git.openjdk.org/jfx/pull/1328/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1328&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318614 Stats: 289254 lines in 6439 files changed: 170206 ins; 83308 del; 35740 mod Patch: https://git.openjdk.org/jfx/pull/1328.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1328/head:pull/1328 PR: https://git.openjdk.org/jfx/pull/1328
Integrated: 8318388: Update libxslt to 1.1.39
On Wed, 29 Nov 2023 11:18:43 GMT, Hima Bindu Meda wrote: > Updated libxslt to v1.1.39. Verified build on all platforms.No issue seen. This pull request has now been integrated. Changeset: 09922d5c Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx/commit/09922d5c030aa4d82a477f2c1ca27de052f0543d Stats: 2658 lines in 49 files changed: 1069 ins; 1158 del; 431 mod 8318388: Update libxslt to 1.1.39 Reviewed-by: kcr, sykora - PR: https://git.openjdk.org/jfx/pull/1298
Re: RFR: 8318388: Update libxslt to 1.1.39 [v2]
> Updated libxslt to v1.1.39. Verified build on all platforms.No issue seen. Hima Bindu Meda has updated the pull request incrementally with two additional commits since the last revision: - update license for libxslt - update libxslt.md - Changes: - all: https://git.openjdk.org/jfx/pull/1298/files - new: https://git.openjdk.org/jfx/pull/1298/files/910c1dfb..c078b956 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1298&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1298&range=00-01 Stats: 90 lines in 1 file changed: 90 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jfx/pull/1298.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1298/head:pull/1298 PR: https://git.openjdk.org/jfx/pull/1298
RFR: 8318388: Update libxslt to 1.1.39
Updated libxslt to v1.1.39. Verified build on all platforms.No issue seen. - Commit messages: - white space corrections - update version info in libxslt.md - configure libxslt on linux - configure libxslt on windows - update libxslt to v1.1.39 Changes: https://git.openjdk.org/jfx/pull/1298/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1298&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318388 Stats: 2568 lines in 49 files changed: 979 ins; 1158 del; 431 mod Patch: https://git.openjdk.org/jfx/pull/1298.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1298/head:pull/1298 PR: https://git.openjdk.org/jfx/pull/1298
[jfx21u] Integrated: 8313321: Set minimum python version in WebKit cmake scripts
On Fri, 20 Oct 2023 12:40:58 GMT, Hima Bindu Meda wrote: > Set minimum python version for all platforms. This pull request has now been integrated. Changeset: 8c2c9ca4 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx21u/commit/8c2c9ca4ca6bb72e5fbe97d002757d267b7c0882 Stats: 18 lines in 1 file changed: 14 ins; 0 del; 4 mod 8313321: Set minimum python version in WebKit cmake scripts Backport-of: bb07bcf7eb60cb772e6d4f135893ff6915c5aa0d - PR: https://git.openjdk.org/jfx21u/pull/20
[jfx21u] Integrated: 8313321: Set minimum python version in WebKit cmake scripts
Set minimum python version for all platforms. - Commit messages: - Backport bb07bcf7eb60cb772e6d4f135893ff6915c5aa0d Changes: https://git.openjdk.org/jfx21u/pull/20/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=20&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313321 Stats: 18 lines in 1 file changed: 14 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jfx21u/pull/20.diff Fetch: git fetch https://git.openjdk.org/jfx21u.git pull/20/head:pull/20 PR: https://git.openjdk.org/jfx21u/pull/20
Integrated: 8313321 : Set minimum python version in WebKit cmake scripts
On Wed, 9 Aug 2023 07:31:57 GMT, Hima Bindu Meda wrote: > Minimum version of python ,to run webkit build , on linux is set to 3.6 and > for other platforms, minimum version of python is set to 3.8. > > Verified build on all platforms. No issue seen This pull request has now been integrated. Changeset: bb07bcf7 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx/commit/bb07bcf7eb60cb772e6d4f135893ff6915c5aa0d Stats: 18 lines in 1 file changed: 14 ins; 0 del; 4 mod 8313321: Set minimum python version in WebKit cmake scripts Reviewed-by: kcr, sykora - PR: https://git.openjdk.org/jfx/pull/1205
Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v3]
> Minimum version of python ,to run webkit build , on linux is set to 3.6 and > for other platforms, minimum version of python is set to 3.8. > > Verified build on all platforms. No issue seen Hima Bindu Meda has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into python_update - change minimum version for mac to 3.6 - Add check for python version for various platforms - Changes: - all: https://git.openjdk.org/jfx/pull/1205/files - new: https://git.openjdk.org/jfx/pull/1205/files/6b73ba2e..6e829316 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1205&range=02 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1205&range=01-02 Stats: 8102 lines in 161 files changed: 6201 ins; 1035 del; 866 mod Patch: https://git.openjdk.org/jfx/pull/1205.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1205/head:pull/1205 PR: https://git.openjdk.org/jfx/pull/1205
Re: RFR: 8314212: Crash when loading cnn.com in WebView [v2]
On Thu, 17 Aug 2023 13:50:06 GMT, Jay Bhaskar wrote: >> Issue: WCMediaPlayer does not support HTTP live streaming m3u8 format. >> Giving error com.sun.javafx.webkit.prism.WCMediaPlayerImpl onError WARNING: >> onError, errCode=0, msg=Unsupported protocol "data" >> >> Solution: Do not invoke the current media time operation in an error state. >> As the WCMediaPlayer might not be a valid object. > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: > > clean up according to review comments Changes look fine. Testing looks good. - Marked as reviewed by hmeda (Committer). PR Review: https://git.openjdk.org/jfx/pull/1212#pullrequestreview-1584408384
Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts
On Thu, 10 Aug 2023 23:00:11 GMT, Kevin Rushforth wrote: > I tested this on my MacBook Pro running macOS 13.3.1 and discovered that it > has python 3.7.x: > > ``` > Could NOT find Python3: Found unsuitable version "3.7.3", but required is > at least "3.8.0" (found /usr/bin/python3, found components: Interpreter) > ``` > > Since the motivation for checking the minimum was both to avoid python2, and > because there is a problem with python 3.7 on Windows, I wonder if it would > be better to only have Windows require 3.8 and have Mac join Linux in > allowing 3.6. Of course, I could upgrade my python, but I wonder if other > developers might run into it. Based on the observation, changed the minimum version to 3.6 for mac and linux , and 3.8 for Windows - PR Comment: https://git.openjdk.org/jfx/pull/1205#issuecomment-1677598701
Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v2]
> Minimum version of python ,to run webkit build , on linux is set to 3.6 and > for other platforms, minimum version of python is set to 3.8. > > Verified build on all platforms. No issue seen Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: change minimum version for mac to 3.6 - Changes: - all: https://git.openjdk.org/jfx/pull/1205/files - new: https://git.openjdk.org/jfx/pull/1205/files/c7277d22..6b73ba2e Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1205&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1205&range=00-01 Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jfx/pull/1205.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1205/head:pull/1205 PR: https://git.openjdk.org/jfx/pull/1205
RFR: 8313321 : Set minimum python version in WebKit cmake scripts
Minimum version of python ,to run webkit build , on linux is set to 3.6 and for other platforms, minimum version of python is set to 3.8. Verified build on all platforms. No issue seen - Commit messages: - Add check for python version for various platforms Changes: https://git.openjdk.org/jfx/pull/1205/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1205&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313321 Stats: 18 lines in 1 file changed: 14 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jfx/pull/1205.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1205/head:pull/1205 PR: https://git.openjdk.org/jfx/pull/1205
Re: RFR: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element [v3]
On Tue, 8 Aug 2023 17:39:18 GMT, Jay Bhaskar wrote: >> Issue : Enabling modern media controls on webkit 616.1 does not load button >> images on HTML5 Video Element >> Solution: Add resources and correct MediaControl Stylesheet > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: > > more clean up review2 Changes look fine. Internal testing looks fine. - Marked as reviewed by hmeda (Committer). PR Review: https://git.openjdk.org/jfx/pull/1201#pullrequestreview-1568859082
[jfx21u] Integrated: 8313711: Cherry-pick WebKit 616.1 stabilization fixes
Clean backport - Commit messages: - Backport af8950e7ebfa1f0705cc9ef5ab50ce25571c00d4 Changes: https://git.openjdk.org/jfx21u/pull/6/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=6&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313711 Stats: 637 lines in 88 files changed: 320 ins; 150 del; 167 mod Patch: https://git.openjdk.org/jfx21u/pull/6.diff Fetch: git fetch https://git.openjdk.org/jfx21u.git pull/6/head:pull/6 PR: https://git.openjdk.org/jfx21u/pull/6
[jfx21u] Integrated: 8313711: Cherry-pick WebKit 616.1 stabilization fixes
On Mon, 7 Aug 2023 14:23:50 GMT, Hima Bindu Meda wrote: > Clean backport This pull request has now been integrated. Changeset: bb6cbae9 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx21u/commit/bb6cbae996a529cd8d8bf30bf7b1c35fa920112e Stats: 637 lines in 88 files changed: 320 ins; 150 del; 167 mod 8313711: Cherry-pick WebKit 616.1 stabilization fixes Backport-of: af8950e7ebfa1f0705cc9ef5ab50ce25571c00d4 - PR: https://git.openjdk.org/jfx21u/pull/6
Integrated: 8313711: Cherry-pick WebKit 616.1 stabilization fixes
On Thu, 3 Aug 2023 17:54:48 GMT, Hima Bindu Meda wrote: > Cherry-picked commits from webkitgtk-2.40.5. > Verified build on windows, mac and linux. Sanity testing looks fine. No > issues seen This pull request has now been integrated. Changeset: af8950e7 Author:Hima Bindu Meda URL: https://git.openjdk.org/jfx/commit/af8950e7ebfa1f0705cc9ef5ab50ce25571c00d4 Stats: 637 lines in 88 files changed: 320 ins; 150 del; 167 mod 8313711: Cherry-pick WebKit 616.1 stabilization fixes Reviewed-by: kcr, sykora - PR: https://git.openjdk.org/jfx/pull/1196
Re: RFR: 8313711: Cherry-pick WebKit 616.1 stabilization fixes [v2]
On Fri, 4 Aug 2023 13:37:10 GMT, Kevin Rushforth wrote: >> modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3DuplicateTails.cpp >> line 89: >> >>> 87: >>> 88: if (canCopyBlock) >>> 89: candidates.add(block); >> >> The indentation looks off here. > > I'll reapprove if you choose to fix this. Indentation corrected - PR Review Comment: https://git.openjdk.org/jfx/pull/1196#discussion_r1285626830
Re: RFR: 8313711: Cherry-pick WebKit 616.1 stabilization fixes [v2]
> Cherry-picked commits from webkitgtk-2.40.5. > Verified build on windows, mac and linux. Sanity testing looks fine. No > issues seen Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Correct indentation - Changes: - all: https://git.openjdk.org/jfx/pull/1196/files - new: https://git.openjdk.org/jfx/pull/1196/files/f53e0dd7..036c9601 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1196&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1196&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jfx/pull/1196.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1196/head:pull/1196 PR: https://git.openjdk.org/jfx/pull/1196
RFR: 8313711: Cherry-pick webkitgtk-2.40.5 stabilzation fixes
Cherry-picked commits from webkitgtk-2.40.5. Verified build on windows, mac and linux. Sanity testing looks fine. No issues seen - Commit messages: - white space correction - cherry-pick webkit-2.40.5 Changes: https://git.openjdk.org/jfx/pull/1196/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1196&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313711 Stats: 636 lines in 88 files changed: 320 ins; 150 del; 166 mod Patch: https://git.openjdk.org/jfx/pull/1196.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1196/head:pull/1196 PR: https://git.openjdk.org/jfx/pull/1196
Re: RFR: 8313177: Web Workers timeout with Webkit 616.1 [v3]
On Tue, 1 Aug 2023 09:54:03 GMT, Jay Bhaskar wrote: >> Issue: Some web worker tests fail to finish. >> Root Cause: >> sharedTimerFiredInternal function from ThreadTimers class does not require >> an isMainThread check, The check was introduced during the initial webkit >> stabilization. > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: > > clean up according to review comments Marked as reviewed by hmeda (Committer). - PR Review: https://git.openjdk.org/jfx/pull/1191#pullrequestreview-1556846727
Re: RFR: 8313177: Web Workers timeout with Webkit 616.1 [v2]
On Mon, 31 Jul 2023 08:16:12 GMT, Jay Bhaskar wrote: >> Issue: Some web worker tests fail to finish. >> Root Cause: >> sharedTimerFiredInternal function from ThreadTimers class does not require >> an isMainThread check, The check was introduced during the initial webkit >> stabilization. > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: > > Add test case for worker timeout Verified the changes and internal testing looks fine. No issue observed. - Marked as reviewed by hmeda (Committer). PR Review: https://git.openjdk.org/jfx/pull/1191#pullrequestreview-1556374190
[jfx21u] Integrated: 8310681: Update WebKit to 616.1
On Fri, 28 Jul 2023 13:06:48 GMT, Hima Bindu Meda wrote: > Backport of webkit update to v616.1. Clean Backport This pull request has now been integrated. Changeset: 104e0584 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx21u/commit/104e0584b516536ad829a560e87f6eb71513a84f Stats: 381300 lines in 5888 files changed: 214309 ins; 124154 del; 42837 mod 8310681: Update WebKit to 616.1 Backport-of: 2dc699a8661fb23040c9f8e3905713229e615816 - PR: https://git.openjdk.org/jfx21u/pull/3
[jfx21u] RFR: 8310681: Update WebKit to 616.1
Backport of webkit update to v616.1. Clean Backport - Commit messages: - Backport 2dc699a8661fb23040c9f8e3905713229e615816 Changes: https://git.openjdk.org/jfx21u/pull/3/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=3&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310681 Stats: 381300 lines in 5888 files changed: 214309 ins; 124154 del; 42837 mod Patch: https://git.openjdk.org/jfx21u/pull/3.diff Fetch: git fetch https://git.openjdk.org/jfx21u.git pull/3/head:pull/3 PR: https://git.openjdk.org/jfx21u/pull/3
Integrated: JDK-8310681: Update WebKit to 616.1
On Thu, 20 Jul 2023 15:36:28 GMT, Hima Bindu Meda wrote: > Updated JavaFX Webkit to GTK WebKit 2.40 (616.1). > Verified the updated version build, sanity tests and stability. No issues > have been observed. This pull request has now been integrated. Changeset: 2dc699a8 Author:Hima Bindu Meda URL: https://git.openjdk.org/jfx/commit/2dc699a8661fb23040c9f8e3905713229e615816 Stats: 381300 lines in 5888 files changed: 214309 ins; 124154 del; 42837 mod 8310681: Update WebKit to 616.1 Reviewed-by: kcr, sykora - PR: https://git.openjdk.org/jfx/pull/1180
Re: RFR: JDK-8310681: Update WebKit to 616.1
On Mon, 24 Jul 2023 02:50:30 GMT, Jay Bhaskar wrote: > > Oh, I see that now. What led me to ask this question was that there is an > > alternative implementation in `#if PLATFORM(JAVA)`, which implies that we > > removed the call to `stripLeadingAndTrailingHTMLSpaces` and that it is > > still present in the upstream. > > Given that this code block now matches the upstream, the `if..else..endif` > > block should simply be replaced with: > > ``` > > return document().completeURL(linkAttribute); > > ``` > > > > > > > > > > > > > > > > > > > > > > > > removing the `#if PLATFORM(JAVA)` and the entire `#else` block (including > > the old call to `stripLeadingAndTrailingHTMLSpaces`). Otherwise it will be > > confusing and possibly lead to merge conflicts later. > > I agree with this. Is there a reason this can't be done in the current PR? Pushed the change. - PR Comment: https://git.openjdk.org/jfx/pull/1180#issuecomment-1647811198
Re: RFR: JDK-8310681: Update WebKit to 616.1 [v2]
> Updated JavaFX Webkit to GTK WebKit 2.40 (616.1). > Verified the updated version build, sanity tests and stability. No issues > have been observed. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Remove check for PLATFORM(JAVA) as the change corresponds to webkit upstream - Changes: - all: https://git.openjdk.org/jfx/pull/1180/files - new: https://git.openjdk.org/jfx/pull/1180/files/5039b04b..3362baa6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1180&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1180&range=00-01 Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod Patch: https://git.openjdk.org/jfx/pull/1180.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1180/head:pull/1180 PR: https://git.openjdk.org/jfx/pull/1180
Re: RFR: JDK-8310681: Update WebKit to 616.1
On Thu, 20 Jul 2023 15:36:28 GMT, Hima Bindu Meda wrote: > Updated JavaFX Webkit to GTK WebKit 2.40 (616.1). > Verified the updated version build, sanity tests and stability. No issues > have been observed. > You can include this in the next "cherry-pick" update, if you prefer. > You can include this in the next "cherry-pick" update, if you prefer. Noted. This change would be included as part of next Cherry-pick update - PR Comment: https://git.openjdk.org/jfx/pull/1180#issuecomment-1646044660
RFR: JDK-8310681: Update WebKit to 616.1
Updated JavaFX Webkit to GTK WebKit 2.40 (616.1). Verified the updated version build, sanity tests and stability. No issues have been observed. - Commit messages: - Update WebKit to 616.1 Changes: https://git.openjdk.org/jfx/pull/1180/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1180&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310681 Stats: 381311 lines in 5888 files changed: 214321 ins; 124162 del; 42828 mod Patch: https://git.openjdk.org/jfx/pull/1180.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1180/head:pull/1180 PR: https://git.openjdk.org/jfx/pull/1180
Re: RFR: 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows
On Fri, 26 May 2023 11:13:31 GMT, Joeri Sykora wrote: >> Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides >> the needed C++20 support for the next WebKit update. >> >> On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 >> 17.5.0 -- see [JDK-8303748](https://bugs.openjdk.org/browse/JDK-8303748). >> The solution for the failure is to compile 615.1 using the C++20 flag for >> Windows (we will use this flag on all platforms for the next WebKit update). >> The fix for that bug is necessarily included in this PR, since the two fixes >> as interdependent. > > I still get the same error when building with Windows SDK version > `10.0.22621` (was using `10.0.22000` before). This is our output of the lines > you pasted: > > > -- The C compiler identification is MSVC 19.35.32215.0 > -- The CXX compiler identification is MSVC 19.35.32215.0 > -- Check for working C compiler: > C:/PROGRA~2/MICROS~1/2022/17.5.0/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe > -- Check for working C compiler: > C:/PROGRA~2/MICROS~1/2022/17.5.0/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe > -- works > -- Detecting C compiler ABI info > -- Detecting C compiler ABI info - done > -- Detecting C compile features > -- Detecting C compile features - done > -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual > Studio/2022/17.5.0/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe > -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual > Studio/2022/17.5.0/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe -- works > -- Detecting CXX compiler ABI info > -- Detecting CXX compiler ABI info - done > -- Detecting CXX compile features > -- Detecting CXX compile features - done > -- The CMake build type is: Release > -- Found Perl: C:/cygwin64/bin/perl.exe (found suitable version "5.32.1", > minimum required is "5.10.0") > -- Found PerlModules: TRUE found components: English FindBin JSON::PP > -- Found Python: C:/cygwin64/bin/python3.8.exe (found version "3.8.10") found > components: Interpreter > -- Could NOT find Ruby (missing: RUBY_INCLUDE_DIR RUBY_LIBRARY > RUBY_CONFIG_INCLUDE_DIR) (found suitable version "2.6.4", minimum required is > "1.9") > -- Enabling ccache: Couldn't find ccache program. Not enabling it. > > > For reference, I'll paste the full error message below: > > > FAILED: > Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-66f79d8a-1.cpp.obj > > C:\PROGRA~2\MICROS~1\2022\175~1.0\VC\Tools\MSVC\1435~1.322\bin\Hostx64\x64\cl.exe > /nologo /TP -DBUILDING_JAVA__=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WebCore > -DDATA_DIR="share" -DHAVE_CONFIG_H=1 > -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DIMAGEIO=1 -DLIBXML_STATIC > -DLIBXSLT_STATIC -DMAX_DOM_TREE_DEPTH=2000 -DNOMINMAX -DPAS_BMALLOC=1 > -DSTATICALLY_LINKED_WITH_JavaScriptCore -DSTATICALLY_LINKED_WITH_PAL > -DSTATICALLY_LINKED_WITH_WTF -DUNICODE -DUSE_SYSTEM_MALLOC > -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DWINVER=0x601 > -D_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1 -D_CRT_SECURE_NO_WARNINGS > -D_HAS_EXCEPTIONS=0 -D_UNICODE -D_WINDOWS -D_WINSOCKAPI_=""... @tiainen Could you please try with python3.8.8 and share your observations? - PR Comment: https://git.openjdk.org/jfx/pull/1142#issuecomment-1566532255
Integrated: 8306329 : Update ICU4C to 73.1
On Mon, 15 May 2023 16:45:55 GMT, Hima Bindu Meda wrote: > Updated ICU to v73.1. Verified build and sanity. No issues seen. This pull request has now been integrated. Changeset: 2f5dcfd3 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx/commit/2f5dcfd3d06282a5552bf9db676541686600a9b9 Stats: 35622 lines in 738 files changed: 9131 ins; 2562 del; 23929 mod 8306329: Update ICU4C to 73.1 Reviewed-by: kcr, jvos - PR: https://git.openjdk.org/jfx/pull/1138
