Re: RFR: 8301302: Platform preferences API [v15]

2023-10-17 Thread Pedro Duque Vieira 
Yes please keep this open.

Having adequate Theme development support would be great and I think
wouldn't require much effort (right now custom theme support in JavaFX is
faulty IMO).
Looking forward to the StyleTheme API so you can define multiple
stylesheets as user agent stylesheets.

(sorry to be annoying about this but as a long time custom theme developer
I've been looking forward to this for ages)



> >> Please read [this document](
> https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for an
> introduction to the Platform Preferences API, and how it interacts with the
> proposed style theme and stage appearance features.
> >
> > Michael Strau? has updated the pull request incrementally with one
> additional commit since the last revision:
> >
> >   Handle key removals


Let's keep this open.


-- 
Pedro Duque Vieira - https://www.pixelduke.com

Re: RFR: 8301302: Platform preferences API [v15]

2023-10-16 Thread Michael Strauß 
On Fri, 8 Sep 2023 05:17:43 GMT, Michael Strauß  wrote:

>> Please read [this 
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) 
>> for an introduction to the Platform Preferences API, and how it interacts 
>> with the proposed style theme and stage appearance features.
>
> Michael Strauß has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Handle key removals

Let's keep this open.

-

PR Comment: https://git.openjdk.org/jfx/pull/1014#issuecomment-1765683765

Re: RFR: 8301302: Platform preferences API [v15]

2023-09-08 Thread Andy Goryachev 
On Fri, 8 Sep 2023 05:17:43 GMT, Michael Strauß  wrote:

>> Please read [this 
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) 
>> for an introduction to the Platform Preferences API, and how it interacts 
>> with the proposed style theme and stage appearance features.
>
> Michael Strauß has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Handle key removals

looking good 🕶

-

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1014#pullrequestreview-1618088381

Re: RFR: 8301302: Platform preferences API [v15]

2023-09-08 Thread Michael Strauß 
On Fri, 8 Sep 2023 14:36:11 GMT, Andy Goryachev  wrote:

>> Michael Strauß has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Handle key removals
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/application/preferences/ChangedValue.java
>  line 69:
> 
>> 67: }
>> 68: }
>> 69: 
> 
> I suspect the code that handles added keys should be added here somewhere.

See my comment 
[here](https://github.com/openjdk/jfx/pull/1014#discussion_r1320119628).

-

PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1320120993

Re: RFR: 8301302: Platform preferences API [v15]

2023-09-08 Thread Andy Goryachev 
On Fri, 8 Sep 2023 05:17:43 GMT, Michael Strauß  wrote:

>> Please read [this 
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) 
>> for an introduction to the Platform Preferences API, and how it interacts 
>> with the proposed style theme and stage appearance features.
>
> Michael Strauß has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Handle key removals

modules/javafx.graphics/src/main/java/com/sun/javafx/application/preferences/ChangedValue.java
 line 69:

> 67: }
> 68: }
> 69: 

I suspect the code that handles added keys should be added here somewhere.

-

PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1319956114

Re: RFR: 8301302: Platform preferences API [v15]

2023-09-07 Thread Michael Strauß 
> Please read [this 
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for 
> an introduction to the Platform Preferences API, and how it interacts with 
> the proposed style theme and stage appearance features.

Michael Strauß has updated the pull request incrementally with one additional 
commit since the last revision:

  Handle key removals

-

Changes:
  - all: https://git.openjdk.org/jfx/pull/1014/files
  - new: https://git.openjdk.org/jfx/pull/1014/files/aae55f99..cb817623

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1014&range=14
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1014&range=13-14

  Stats: 35 lines in 2 files changed: 32 ins; 3 del; 0 mod
  Patch: https://git.openjdk.org/jfx/pull/1014.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1014/head:pull/1014

PR: https://git.openjdk.org/jfx/pull/1014