Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v2]
On Tue, 5 Sep 2023 07:17:57 GMT, Johan Vos wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> change minimum version for mac to 3.6 > > I think that should be ok for now, and I don't want to make the PR more > complex as this is a good step, but I believe we need more strict checks: > * also check the maximum version for python > * check versions of perl,ruby > Unfortunately, building webkit is extremely brittle and requiring exact > versions is decreasing the chances on failures at build or runtime. @johanvos or @tiainen could one of you be the second reviewer? - PR Comment: https://git.openjdk.org/jfx/pull/1205#issuecomment-1766407029
Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v2]
On Mon, 14 Aug 2023 16:17:29 GMT, Hima Bindu Meda wrote: >> Minimum version of python ,to run webkit build , on linux is set to 3.6 and >> for other platforms, minimum version of python is set to 3.8. >> >> Verified build on all platforms. No issue seen > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > change minimum version for mac to 3.6 Just a note that I was unable to build WebKit on Windows using the latest Python version 3.9 that comes with and up-to-date Cygwin installation due to the following issue: * [Windows-style path is not recognized under cygwin](https://github.com/python/cpython/issues/90907) I also couldn't find an easy way to "pin" the version number to keep Cygwin from upgrading it, so I had to revert the version manually each time I ran the Cygwin update tool. See my message on the mailing list for details: * [Cygwin Python 3.9 breaks Windows WebKit build](https://mail.openjdk.org/pipermail/openjfx-dev/2023-January/037822.html) - PR Comment: https://git.openjdk.org/jfx/pull/1205#issuecomment-1706877360
Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v2]
On Mon, 14 Aug 2023 16:17:29 GMT, Hima Bindu Meda wrote: >> Minimum version of python ,to run webkit build , on linux is set to 3.6 and >> for other platforms, minimum version of python is set to 3.8. >> >> Verified build on all platforms. No issue seen > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > change minimum version for mac to 3.6 I think that should be ok for now, and I don't want to make the PR more complex as this is a good step, but I believe we need more strict checks: * also check the maximum version for python * check versions of perl,ruby Unfortunately, building webkit is extremely brittle and requiring exact versions is decreasing the chances on failures at build or runtime. - PR Comment: https://git.openjdk.org/jfx/pull/1205#issuecomment-1706072588
Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v2]
On Mon, 14 Aug 2023 16:17:29 GMT, Hima Bindu Meda wrote: >> Minimum version of python ,to run webkit build , on linux is set to 3.6 and >> for other platforms, minimum version of python is set to 3.8. >> >> Verified build on all platforms. No issue seen > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > change minimum version for mac to 3.6 Looks good. - Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1205#pullrequestreview-1578528640
Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v2]
> Minimum version of python ,to run webkit build , on linux is set to 3.6 and > for other platforms, minimum version of python is set to 3.8. > > Verified build on all platforms. No issue seen Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: change minimum version for mac to 3.6 - Changes: - all: https://git.openjdk.org/jfx/pull/1205/files - new: https://git.openjdk.org/jfx/pull/1205/files/c7277d22..6b73ba2e Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx=1205=01 - incr: https://webrevs.openjdk.org/?repo=jfx=1205=00-01 Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jfx/pull/1205.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1205/head:pull/1205 PR: https://git.openjdk.org/jfx/pull/1205
