Re: RFR: 8327471: RTLTextFlowCharacterIndexTest fails on Linux [v2]
On Thu, 14 Mar 2024 10:37:26 GMT, Karthik P K wrote: >> Because of the difference in the size of characters in default fonts in >> different OS, 2 tests were failing in `RTLTextFlowCharacterIndexTest`. >> >> Increased the scene width to accommodate all the characters as required for >> the test to validate HitInfo values in all the platforms. > > Karthik P K has updated the pull request incrementally with one additional > commit since the last revision: > > Review comments looks good - Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1399#pullrequestreview-1943358032
Re: RFR: 8327471: RTLTextFlowCharacterIndexTest fails on Linux [v2]
On Thu, 14 Mar 2024 10:37:26 GMT, Karthik P K wrote: >> Because of the difference in the size of characters in default fonts in >> different OS, 2 tests were failing in `RTLTextFlowCharacterIndexTest`. >> >> Increased the scene width to accommodate all the characters as required for >> the test to validate HitInfo values in all the platforms. > > Karthik P K has updated the pull request incrementally with one additional > commit since the last revision: > > Review comments I can confirm that the tests runs in all the platforms. Successfully ran the headful tests in our lab machines. - PR Comment: https://git.openjdk.org/jfx/pull/1399#issuecomment-2002956250
Re: RFR: 8327471: RTLTextFlowCharacterIndexTest fails on Linux [v2]
On Thu, 14 Mar 2024 10:37:26 GMT, Karthik P K wrote: >> Because of the difference in the size of characters in default fonts in >> different OS, 2 tests were failing in `RTLTextFlowCharacterIndexTest`. >> >> Increased the scene width to accommodate all the characters as required for >> the test to validate HitInfo values in all the platforms. > > Karthik P K has updated the pull request incrementally with one additional > commit since the last revision: > > Review comments Yes it was the build which failed. I'm facing some issue in running the tests on lab machine, I will update here once it is done. - PR Comment: https://git.openjdk.org/jfx/pull/1399#issuecomment-2001823915
Re: RFR: 8327471: RTLTextFlowCharacterIndexTest fails on Linux [v2]
On Thu, 14 Mar 2024 10:37:26 GMT, Karthik P K wrote: >> Because of the difference in the size of characters in default fonts in >> different OS, 2 tests were failing in `RTLTextFlowCharacterIndexTest`. >> >> Increased the scene width to accommodate all the characters as required for >> the test to validate HitInfo values in all the platforms. > > Karthik P K has updated the pull request incrementally with one additional > commit since the last revision: > > Review comments the changes look good. could we get the jenkins run passing ( I think the latest one failed - No 119)? - PR Comment: https://git.openjdk.org/jfx/pull/1399#issuecomment-1997667698
Re: RFR: 8327471: RTLTextFlowCharacterIndexTest fails on Linux [v2]
On Wed, 13 Mar 2024 16:30:27 GMT, Andy Goryachev wrote: >> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments > > tests/system/src/test/java/test/robot/javafx/scene/RTLTextFlowCharacterIndexTest.java > line 116: > >> 114: static volatile Scene scene; >> 115: >> 116: static final int WIDTH = 600; > > one suggestion: maybe we can reduce the font size from 48 to something > smaller. > that might also speed up the test as the cursor wouldn't have to traverse a > lot of pixels. watch out for change in line breaks though. Thanks for suggesting this @andy-goryachev-oracle. I have made the changes in the test. I reduced the font size little bit only to make sure that the multiline text are not displayed in a single line. - PR Review Comment: https://git.openjdk.org/jfx/pull/1399#discussion_r1524832327
Re: RFR: 8327471: RTLTextFlowCharacterIndexTest fails on Linux [v2]
> Because of the difference in the size of characters in default fonts in > different OS, 2 tests were failing in `RTLTextFlowCharacterIndexTest`. > > Increased the scene width to accommodate all the characters as required for > the test to validate HitInfo values in all the platforms. Karthik P K has updated the pull request incrementally with one additional commit since the last revision: Review comments - Changes: - all: https://git.openjdk.org/jfx/pull/1399/files - new: https://git.openjdk.org/jfx/pull/1399/files/cdf341fc..06c81170 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx=1399=01 - incr: https://webrevs.openjdk.org/?repo=jfx=1399=00-01 Stats: 19 lines in 1 file changed: 1 ins; 0 del; 18 mod Patch: https://git.openjdk.org/jfx/pull/1399.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1399/head:pull/1399 PR: https://git.openjdk.org/jfx/pull/1399
Re: RFR: 8327471: RTLTextFlowCharacterIndexTest fails on Linux
On Wed, 13 Mar 2024 05:17:40 GMT, Karthik P K wrote: > Because of the difference in the size of characters in default fonts in > different OS, 2 tests were failing in `RTLTextFlowCharacterIndexTest`. > > Increased the scene width to accommodate all the characters as required for > the test to validate HitInfo values in all the platforms. tests/system/src/test/java/test/robot/javafx/scene/RTLTextFlowCharacterIndexTest.java line 116: > 114: static volatile Scene scene; > 115: > 116: static final int WIDTH = 600; one suggestion: maybe we can reduce the font size from 48 to something smaller. that might also speed up the test as the cursor wouldn't have to traverse a lot of pixels. watch out for change in line breaks though. - PR Review Comment: https://git.openjdk.org/jfx/pull/1399#discussion_r1523581496
RFR: 8327471: RTLTextFlowCharacterIndexTest fails on Linux
Because of the difference in the size of characters in default fonts in different OS, 2 tests were failing in `RTLTextFlowCharacterIndexTest`. Increased the scene width to accommodate all the characters as required for the test to validate HitInfo values in all the platforms. - Commit messages: - RTL text test fix Changes: https://git.openjdk.org/jfx/pull/1399/files Webrev: https://webrevs.openjdk.org/?repo=jfx=1399=00 Issue: https://bugs.openjdk.org/browse/JDK-8327471 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jfx/pull/1399.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1399/head:pull/1399 PR: https://git.openjdk.org/jfx/pull/1399
