Re: RFR: JDK-8297412: Remove easy warnings in javafx.fxml, javafx.media, javafx.swing, javafx.swt and javafx.web [v4]
On Tue, 22 Nov 2022 18:52:32 GMT, John Hendrikx wrote:
>> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446:
>>
>>> 1444: @Override
>>> 1445: public void processEndElement() throws IOException {
>>> 1446: super.processEndElement();
>>
>> I don't see a warning for it, What setting warns about calling an empty
>> method?
>
> The `processEndElement` in the base class was an empty method that throws
> `IOException`. By making it `abstract` the warning is avoided, but this
> means the call to `super` here is no longer relevant (it wasn't relevant
> anyway as the base method was empty).
I think that we should refrain from making "structural" changes in this pass.
Let's keep the warning on and deal with these later.
-
PR: https://git.openjdk.org/jfx/pull/958
Re: RFR: JDK-8297412: Remove easy warnings in javafx.fxml, javafx.media, javafx.swing, javafx.swt and javafx.web [v4]
On Tue, 22 Nov 2022 19:06:47 GMT, John Hendrikx wrote: >> - Remove unsupported/unnecessary SuppressWarning annotations >> - Remove reduntant type specifications (use diamond operator) >> - Remove unused or duplicate imports >> - Remove unnecessary casts (type is already correct type or can be autoboxed) >> - Remove unnecessary semi-colons (at end of class definitions, or just >> repeated ones) >> - Remove redundant super interfaces (interface that is already inherited) >> - Remove unused type parameters >> - Remove declared checked exceptions that are never thrown >> - Add missing `@Override` annotations > > John Hendrikx has updated the pull request incrementally with one additional > commit since the last revision: > > Fix indent of 5 spaces to 4 spaces Given that some changes will require a bit more review, I'd like two reviewers. - PR: https://git.openjdk.org/jfx/pull/958
Re: RFR: JDK-8297412: Remove easy warnings in javafx.fxml, javafx.media, javafx.swing, javafx.swt and javafx.web [v4]
On Tue, 22 Nov 2022 18:35:36 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indent of 5 spaces to 4 spaces
>
> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446:
>
>> 1444: @Override
>> 1445: public void processEndElement() throws IOException {
>> 1446: super.processEndElement();
>
> this suggests a specific pattern, even though there is probably no
> development expected in this class.
> i'd keep it as is, and revert making the method abstract in the base class.
I agree. This sort of change goes beyond what I expect to see in a cleanup pass.
-
PR: https://git.openjdk.org/jfx/pull/958
Re: RFR: JDK-8297412: Remove easy warnings in javafx.fxml, javafx.media, javafx.swing, javafx.swt and javafx.web [v4]
> - Remove unsupported/unnecessary SuppressWarning annotations > - Remove reduntant type specifications (use diamond operator) > - Remove unused or duplicate imports > - Remove unnecessary casts (type is already correct type or can be autoboxed) > - Remove unnecessary semi-colons (at end of class definitions, or just > repeated ones) > - Remove redundant super interfaces (interface that is already inherited) > - Remove unused type parameters > - Remove declared checked exceptions that are never thrown > - Add missing `@Override` annotations John Hendrikx has updated the pull request incrementally with one additional commit since the last revision: Fix indent of 5 spaces to 4 spaces - Changes: - all: https://git.openjdk.org/jfx/pull/958/files - new: https://git.openjdk.org/jfx/pull/958/files/da0439c6..a5bbff82 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx=958=03 - incr: https://webrevs.openjdk.org/?repo=jfx=958=02-03 Stats: 11 lines in 1 file changed: 1 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jfx/pull/958.diff Fetch: git fetch https://git.openjdk.org/jfx pull/958/head:pull/958 PR: https://git.openjdk.org/jfx/pull/958
