On Tue, 22 Nov 2022 18:35:36 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix indent of 5 spaces to 4 spaces > > modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446: > >> 1444: @Override >> 1445: public void processEndElement() throws IOException { >> 1446: super.processEndElement(); > > this suggests a specific pattern, even though there is probably no > development expected in this class. > i'd keep it as is, and revert making the method abstract in the base class. I agree. This sort of change goes beyond what I expect to see in a cleanup pass. ------------- PR: https://git.openjdk.org/jfx/pull/958