Re: [External] : Re: [jfx21u] RFR: 8317842: Create release notes for JavaFX 21.0.1

2023-10-17 Thread Kevin Rushforth 

Thanks. To answer the one outstanding question from your earlier reply:

It would be a great future feature if we can somehow automatically 
remove the issues that are introduced in the same version.


Yes, it would. As of now, we don't have a robust way to do it,  but I'll 
give it some thought.


-- Kevin




On 10/17/2023 7:53 AM, Johan Vos wrote:

No, you are right.
All good, I approved.

- Johan

On Tue, Oct 17, 2023 at 4:50 PM Kevin Rushforth 
 wrote:


We need to exclude from the release notes any backport with a fix
version of 21.0.1 and an hgupdate-sync label. Those bugs were
fixed in 21 and are already in the release notes for 21.

Do you have an example where you think the JBS filter excluded
something it should not have?

-- Kevin


On 10/17/2023 7:43 AM, Johan Vos wrote:

Hi Kevin,

After a second look, I'm not sure about excluding the issues with
a hgupdate-sync label. From a previous mail, I understood that
those have to be removed in the release notes of jfx22, but from
the backports?

- Johan

On Tue, Oct 17, 2023 at 4:10 PM Kevin Rushforth 
wrote:

Release notes for JavaFX 21.0.1.

Notes to reviewers:

I used the following filter to pick the issues:

https://bugs.openjdk.org/issues/?filter=44663

The original filter, with the backport IDs, is here:

https://bugs.openjdk.org/issues/?filter=44662

As usual, I excluded test bugs, cleanup bugs, etc. I manually
excludes 4 additional bugs, one of which was a README change
(does not affect the product), and the other three were
introduced and fixed in the same release.

-

Commit messages:
 - 8317842: Create release notes for JavaFX 21.0.1

Changes: https://git.openjdk.org/jfx21u/pull/19/files
 Webrev:
https://webrevs.openjdk.org/?repo=jfx21u=19=00

  Issue: https://bugs.openjdk.org/browse/JDK-8317842
  Stats: 18 lines in 1 file changed: 18 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jfx21u/pull/19.diff
  Fetch: git fetch https://git.openjdk.org/jfx21u.git
pull/19/head:pull/19

PR: https://git.openjdk.org/jfx21u/pull/19

Re: [jfx21u] RFR: 8317842: Create release notes for JavaFX 21.0.1

2023-10-17 Thread Johan Vos 
No, you are right.
All good, I approved.

- Johan

On Tue, Oct 17, 2023 at 4:50 PM Kevin Rushforth 
wrote:

> We need to exclude from the release notes any backport with a fix version
> of 21.0.1 and an hgupdate-sync label. Those bugs were fixed in 21 and are
> already in the release notes for 21.
>
> Do you have an example where you think the JBS filter excluded something
> it should not have?
>
> -- Kevin
>
>
> On 10/17/2023 7:43 AM, Johan Vos wrote:
>
> Hi Kevin,
>
> After a second look, I'm not sure about excluding the issues with a
> hgupdate-sync label. From a previous mail, I understood that those have to
> be removed in the release notes of jfx22, but from the backports?
>
> - Johan
>
> On Tue, Oct 17, 2023 at 4:10 PM Kevin Rushforth  wrote:
>
>> Release notes for JavaFX 21.0.1.
>>
>> Notes to reviewers:
>>
>> I used the following filter to pick the issues:
>>
>> https://bugs.openjdk.org/issues/?filter=44663
>>
>> The original filter, with the backport IDs, is here:
>>
>> https://bugs.openjdk.org/issues/?filter=44662
>>
>> As usual, I excluded test bugs, cleanup bugs, etc. I manually excludes 4
>> additional bugs, one of which was a README change (does not affect the
>> product), and the other three were introduced and fixed in the same release.
>>
>> -
>>
>> Commit messages:
>>  - 8317842: Create release notes for JavaFX 21.0.1
>>
>> Changes: https://git.openjdk.org/jfx21u/pull/19/files
>>  Webrev: https://webrevs.openjdk.org/?repo=jfx21u=19=00
>>   Issue: https://bugs.openjdk.org/browse/JDK-8317842
>>   Stats: 18 lines in 1 file changed: 18 ins; 0 del; 0 mod
>>   Patch: https://git.openjdk.org/jfx21u/pull/19.diff
>>   Fetch: git fetch https://git.openjdk.org/jfx21u.git
>> pull/19/head:pull/19
>>
>> PR: https://git.openjdk.org/jfx21u/pull/19
>>
>
>

Re: [jfx21u] RFR: 8317842: Create release notes for JavaFX 21.0.1

2023-10-17 Thread Kevin Rushforth 
We need to exclude from the release notes any backport with a fix 
version of 21.0.1 and an hgupdate-sync label. Those bugs were fixed in 
21 and are already in the release notes for 21.


Do you have an example where you think the JBS filter excluded something 
it should not have?


-- Kevin


On 10/17/2023 7:43 AM, Johan Vos wrote:

Hi Kevin,

After a second look, I'm not sure about excluding the issues with a 
hgupdate-sync label. From a previous mail, I understood that those 
have to be removed in the release notes of jfx22, but from the backports?


- Johan

On Tue, Oct 17, 2023 at 4:10 PM Kevin Rushforth  wrote:

Release notes for JavaFX 21.0.1.

Notes to reviewers:

I used the following filter to pick the issues:

https://bugs.openjdk.org/issues/?filter=44663

The original filter, with the backport IDs, is here:

https://bugs.openjdk.org/issues/?filter=44662

As usual, I excluded test bugs, cleanup bugs, etc. I manually
excludes 4 additional bugs, one of which was a README change (does
not affect the product), and the other three were introduced and
fixed in the same release.

-

Commit messages:
 - 8317842: Create release notes for JavaFX 21.0.1

Changes: https://git.openjdk.org/jfx21u/pull/19/files
 Webrev: https://webrevs.openjdk.org/?repo=jfx21u=19=00

  Issue: https://bugs.openjdk.org/browse/JDK-8317842
  Stats: 18 lines in 1 file changed: 18 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jfx21u/pull/19.diff
  Fetch: git fetch https://git.openjdk.org/jfx21u.git
pull/19/head:pull/19

PR: https://git.openjdk.org/jfx21u/pull/19

Re: [jfx21u] RFR: 8317842: Create release notes for JavaFX 21.0.1

2023-10-17 Thread Johan Vos 
Hi Kevin,

After a second look, I'm not sure about excluding the issues with a
hgupdate-sync label. From a previous mail, I understood that those have to
be removed in the release notes of jfx22, but from the backports?

- Johan

On Tue, Oct 17, 2023 at 4:10 PM Kevin Rushforth  wrote:

> Release notes for JavaFX 21.0.1.
>
> Notes to reviewers:
>
> I used the following filter to pick the issues:
>
> https://bugs.openjdk.org/issues/?filter=44663
>
> The original filter, with the backport IDs, is here:
>
> https://bugs.openjdk.org/issues/?filter=44662
>
> As usual, I excluded test bugs, cleanup bugs, etc. I manually excludes 4
> additional bugs, one of which was a README change (does not affect the
> product), and the other three were introduced and fixed in the same release.
>
> -
>
> Commit messages:
>  - 8317842: Create release notes for JavaFX 21.0.1
>
> Changes: https://git.openjdk.org/jfx21u/pull/19/files
>  Webrev: https://webrevs.openjdk.org/?repo=jfx21u=19=00
>   Issue: https://bugs.openjdk.org/browse/JDK-8317842
>   Stats: 18 lines in 1 file changed: 18 ins; 0 del; 0 mod
>   Patch: https://git.openjdk.org/jfx21u/pull/19.diff
>   Fetch: git fetch https://git.openjdk.org/jfx21u.git pull/19/head:pull/19
>
> PR: https://git.openjdk.org/jfx21u/pull/19
>

Re: [jfx21u] RFR: 8317842: Create release notes for JavaFX 21.0.1

2023-10-17 Thread Johan Vos 
Looks good, I'm double checking and will approve.
It would be a great future feature if we can somehow automatically remove
the issues that are introduced in the same version.

- Johan

Op di 17 okt 2023 om 16:10 schreef Kevin Rushforth :

> Release notes for JavaFX 21.0.1.
>
> Notes to reviewers:
>
> I used the following filter to pick the issues:
>
> https://bugs.openjdk.org/issues/?filter=44663
>
> The original filter, with the backport IDs, is here:
>
> https://bugs.openjdk.org/issues/?filter=44662
>
> As usual, I excluded test bugs, cleanup bugs, etc. I manually excludes 4
> additional bugs, one of which was a README change (does not affect the
> product), and the other three were introduced and fixed in the same release.
>
> -
>
> Commit messages:
>  - 8317842: Create release notes for JavaFX 21.0.1
>
> Changes: https://git.openjdk.org/jfx21u/pull/19/files
>  Webrev: https://webrevs.openjdk.org/?repo=jfx21u=19=00
>   Issue: https://bugs.openjdk.org/browse/JDK-8317842
>   Stats: 18 lines in 1 file changed: 18 ins; 0 del; 0 mod
>   Patch: https://git.openjdk.org/jfx21u/pull/19.diff
>   Fetch: git fetch https://git.openjdk.org/jfx21u.git pull/19/head:pull/19
>
> PR: https://git.openjdk.org/jfx21u/pull/19
>

Re: [jfx21u] RFR: 8317842: Create release notes for JavaFX 21.0.1

2023-10-17 Thread Kevin Rushforth 
On Tue, 10 Oct 2023 23:24:05 GMT, Kevin Rushforth  wrote:

> Release notes for JavaFX 21.0.1.
> 
> Notes to reviewers:
> 
> I used the following filter to pick the issues:
> 
> https://bugs.openjdk.org/issues/?filter=44663
> 
> The original filter, with the backport IDs, is here:
> 
> https://bugs.openjdk.org/issues/?filter=44662
> 
> As usual, I excluded test bugs, cleanup bugs, etc. I manually excludes 4 
> additional bugs, one of which was a README change (does not affect the 
> product), and the other three were introduced and fixed in the same release.

Reviewers: @johanvos @abhinayagarwal

There are no security fixes this time, so this PR is ready for final review.

-

PR Comment: https://git.openjdk.org/jfx21u/pull/19#issuecomment-1756458351
PR Comment: https://git.openjdk.org/jfx21u/pull/19#issuecomment-1766462373