Re: [Openocd-development] [PATCH] ARM11 cleanup stale dependencies with generic arm code; added comments and whitespace fixes
On Mon, May 18, 2009 at 6:51 AM, Rick Altherr wrote: > > On May 17, 2009, at 2:40 PM, Michael Bruck wrote: > >> - remove stale interdepencies between arm11 and arm7_9_common >> - added comments >> - fixed some indentation >> >> >> Michael >> ___ >> Openocd-development mailing list >> Openocd-development@lists.berlios.de >> https://lists.berlios.de/mailman/listinfo/openocd-development > > > > Is there someone more familiar with the ARM11 code that can comment on this? > From my knowledge, ARM11 is an ARMv6 part and shouldn't have a dependency > on the ARMv4/5 code. Sadly, I don't know enough about OpenOCD's > implementation of the ARM target support to know if separating them is > correct. > The other ARM code is layered so that more advanced cores re-use the code of earlier cores. But that is a huge sparsely documented package that I didn't have time to dig into during the ARM11 port. That is why ARM11 is a clean room port that is not connected to the other ARM layers. The dependencies are there because I used a skeleton from another driver as starting point and never got around analyzing what this bit of code does. I only found it now after the doxygen docs highlighted some unexpected dependencies in the header files. Michael ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] ARM11 cleanup stale dependencies with generic arm code; added comments and whitespace fixes
Committed. I've updated the copyright notice so that it is clear that Michael Bruck is the first author(even if the copyright is held by someone else). Let me know if it needs updating. -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] ARM11 cleanup stale dependencies with generic arm code; added comments and whitespace fixes
On May 17, 2009, at 2:40 PM, Michael Bruck wrote: - remove stale interdepencies between arm11 and arm7_9_common - added comments - fixed some indentation Michael fixes>___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development Is there someone more familiar with the ARM11 code that can comment on this? From my knowledge, ARM11 is an ARMv6 part and shouldn't have a dependency on the ARMv4/5 code. Sadly, I don't know enough about OpenOCD's implementation of the ARM target support to know if separating them is correct. -- Rick Altherr kc8...@kc8apf.net "He said he hadn't had a byte in three days. I had a short, so I split it with him." -- Unsigned smime.p7s Description: S/MIME cryptographic signature ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] [PATCH] ARM11 cleanup stale dependencies with generic arm code; added comments and whitespace fixes
- remove stale interdepencies between arm11 and arm7_9_common - added comments - fixed some indentation Michael openocd-arm11-small-fixes Description: Binary data ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
