[tickets] [opensaf:tickets] #2419 smf: when fixing ticket #2145 a NBC problem was introduced
The maintenance attribute was definitely never used by AMF. I did the implementation. And SMF was setting it and unsetting it in the correct places. I won't argue with you if you want to do it in AMF, but I think SMF is really the right place to do it because it is much cleaner. --- ** [tickets:#2419] smf: when fixing ticket #2145 a NBC problem was introduced** **Status:** wontfix **Milestone:** 5.2.0 **Created:** Mon Apr 10, 2017 11:11 AM UTC by elunlen **Last Updated:** Sat Apr 22, 2017 09:56 AM UTC **Owner:** nobody Previous behavior: The behavior was to ignore a fail to activate a component unless any secondary fault happened. This means that it was for example possible to complete a campaign even if a component failed to start and fix this problem after committing. No action to resume the campaign was needed. After [#2145]: The campaign will always suspend in case of component fail and a resume must be requested for the campaign to continue. NBC: The behavior has changed in such a way that it must be seen as a NBC. The #2145 ticket corrects SMF behavior regarding AIS but is still NBC since the previous behavior is the legacy behavior in previous releases. Proposal 1; Fix if not needed to change setting in runtime e.g. during an upgrade Add a new configuration attribute to the SMF configuration class that makes it possible to select whether the behavior after #2145 shall be used or not. The default setting must be the previous behavior. The setting must have the following properties: - If the attribute does not exist (old model) legacy behavior - If the attribute value is not changed from defaultlegacy behavior - If the attribute value is or invalid legacy behavior - If the attribute value is a valid “ON” settingnew behavior - A request to change the attribute in runtime shall always be rejected Proposal 2; Fix if change has to be made during upgrade: Add a new configuration attribute to the SMF configuration class that makes it possible to select whether the behavior after #2145 shall be used or not. The default setting must be the previous behavior. The setting must have the following properties: - If the attribute does not exist (old model) legacy behavior - If the attribute value is not changed from defaultlegacy behavior - If the attribute value is or invalid legacy behavior - If the attribute value is a valid “ON” settingnew behavior - Attribute value must be possible to change in runtime in “idle” state (no campaign is executing) - Attribute value must be possible to change in runtime in campaign init state. Note that if changed here the new setting must be used in the rest of the campaign --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2419 smf: when fixing ticket #2145 a NBC problem was introduced
I'm not sure this is the right thing to do. If this problem is handled in AMF, now someone can turn off the behavior in the middle of a campaign. AMF doesn't know if a campaign is executing, and would just blindly enable/disable the auto repair which could be dangerous. I think Rafael's suggestion from 4/13 is the right thing to do. Then if someone wants to turn the behavior on or off, SMF can reject it in the middle of a campaign. --- ** [tickets:#2419] smf: when fixing ticket #2145 a NBC problem was introduced** **Status:** wontfix **Milestone:** 5.2.0 **Created:** Mon Apr 10, 2017 11:11 AM UTC by elunlen **Last Updated:** Fri Apr 21, 2017 08:40 AM UTC **Owner:** nobody Previous behavior: The behavior was to ignore a fail to activate a component unless any secondary fault happened. This means that it was for example possible to complete a campaign even if a component failed to start and fix this problem after committing. No action to resume the campaign was needed. After [#2145]: The campaign will always suspend in case of component fail and a resume must be requested for the campaign to continue. NBC: The behavior has changed in such a way that it must be seen as a NBC. The #2145 ticket corrects SMF behavior regarding AIS but is still NBC since the previous behavior is the legacy behavior in previous releases. Proposal 1; Fix if not needed to change setting in runtime e.g. during an upgrade Add a new configuration attribute to the SMF configuration class that makes it possible to select whether the behavior after #2145 shall be used or not. The default setting must be the previous behavior. The setting must have the following properties: - If the attribute does not exist (old model) legacy behavior - If the attribute value is not changed from defaultlegacy behavior - If the attribute value is or invalid legacy behavior - If the attribute value is a valid “ON” settingnew behavior - A request to change the attribute in runtime shall always be rejected Proposal 2; Fix if change has to be made during upgrade: Add a new configuration attribute to the SMF configuration class that makes it possible to select whether the behavior after #2145 shall be used or not. The default setting must be the previous behavior. The setting must have the following properties: - If the attribute does not exist (old model) legacy behavior - If the attribute value is not changed from defaultlegacy behavior - If the attribute value is or invalid legacy behavior - If the attribute value is a valid “ON” settingnew behavior - Attribute value must be possible to change in runtime in “idle” state (no campaign is executing) - Attribute value must be possible to change in runtime in campaign init state. Note that if changed here the new setting must be used in the rest of the campaign --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2419 smf: when fixing ticket #2145 a NBC problem was introduced
- **status**: unassigned --> wontfix - **Comment**: No configuration is needed in SMF. The NBC behaviour is trigged when AMF sends a state change notification with SA_AMF_MAINTENANCE_CAMPAIGN_DN set in additional info. This togeteher with not doing a repair on a failing unit is a NBC behaviour in AMF. A fix is done in AMF adding a new configuration that has to be set to activate the behaviour according to [#2144]. For more information about the AMF fix see [#2435] --- ** [tickets:#2419] smf: when fixing ticket #2145 a NBC problem was introduced** **Status:** wontfix **Milestone:** 5.2.0 **Created:** Mon Apr 10, 2017 11:11 AM UTC by elunlen **Last Updated:** Thu Apr 13, 2017 08:41 AM UTC **Owner:** nobody Previous behavior: The behavior was to ignore a fail to activate a component unless any secondary fault happened. This means that it was for example possible to complete a campaign even if a component failed to start and fix this problem after committing. No action to resume the campaign was needed. After [#2145]: The campaign will always suspend in case of component fail and a resume must be requested for the campaign to continue. NBC: The behavior has changed in such a way that it must be seen as a NBC. The #2145 ticket corrects SMF behavior regarding AIS but is still NBC since the previous behavior is the legacy behavior in previous releases. Proposal 1; Fix if not needed to change setting in runtime e.g. during an upgrade Add a new configuration attribute to the SMF configuration class that makes it possible to select whether the behavior after #2145 shall be used or not. The default setting must be the previous behavior. The setting must have the following properties: - If the attribute does not exist (old model) legacy behavior - If the attribute value is not changed from defaultlegacy behavior - If the attribute value is or invalid legacy behavior - If the attribute value is a valid “ON” settingnew behavior - A request to change the attribute in runtime shall always be rejected Proposal 2; Fix if change has to be made during upgrade: Add a new configuration attribute to the SMF configuration class that makes it possible to select whether the behavior after #2145 shall be used or not. The default setting must be the previous behavior. The setting must have the following properties: - If the attribute does not exist (old model) legacy behavior - If the attribute value is not changed from defaultlegacy behavior - If the attribute value is or invalid legacy behavior - If the attribute value is a valid “ON” settingnew behavior - Attribute value must be possible to change in runtime in “idle” state (no campaign is executing) - Attribute value must be possible to change in runtime in campaign init state. Note that if changed here the new setting must be used in the rest of the campaign --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2419 smf: when fixing ticket #2145 a NBC problem was introduced
Suggestion is to disable setting the maintenance campaign attribute on the AMF object by default. And optionally have a setting to enable setting this attribute. This would disable possible AMF NBC as well as the SMF NBC for #2144 and #2145 --- ** [tickets:#2419] smf: when fixing ticket #2145 a NBC problem was introduced** **Status:** unassigned **Milestone:** 5.2.0 **Created:** Mon Apr 10, 2017 11:11 AM UTC by elunlen **Last Updated:** Wed Apr 12, 2017 01:02 PM UTC **Owner:** nobody Previous behavior: The behavior was to ignore a fail to activate a component unless any secondary fault happened. This means that it was for example possible to complete a campaign even if a component failed to start and fix this problem after committing. No action to resume the campaign was needed. After [#2145]: The campaign will always suspend in case of component fail and a resume must be requested for the campaign to continue. NBC: The behavior has changed in such a way that it must be seen as a NBC. The #2145 ticket corrects SMF behavior regarding AIS but is still NBC since the previous behavior is the legacy behavior in previous releases. Proposal 1; Fix if not needed to change setting in runtime e.g. during an upgrade Add a new configuration attribute to the SMF configuration class that makes it possible to select whether the behavior after #2145 shall be used or not. The default setting must be the previous behavior. The setting must have the following properties: - If the attribute does not exist (old model) legacy behavior - If the attribute value is not changed from defaultlegacy behavior - If the attribute value is or invalid legacy behavior - If the attribute value is a valid “ON” settingnew behavior - A request to change the attribute in runtime shall always be rejected Proposal 2; Fix if change has to be made during upgrade: Add a new configuration attribute to the SMF configuration class that makes it possible to select whether the behavior after #2145 shall be used or not. The default setting must be the previous behavior. The setting must have the following properties: - If the attribute does not exist (old model) legacy behavior - If the attribute value is not changed from defaultlegacy behavior - If the attribute value is or invalid legacy behavior - If the attribute value is a valid “ON” settingnew behavior - Attribute value must be possible to change in runtime in “idle” state (no campaign is executing) - Attribute value must be possible to change in runtime in campaign init state. Note that if changed here the new setting must be used in the rest of the campaign --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2419 smf: when fixing ticket #2145 a NBC problem was introduced
- **Component**: unknown --> smf --- ** [tickets:#2419] smf: when fixing ticket #2145 a NBC problem was introduced** **Status:** unassigned **Milestone:** 5.2.0 **Created:** Mon Apr 10, 2017 11:11 AM UTC by elunlen **Last Updated:** Mon Apr 10, 2017 08:09 PM UTC **Owner:** nobody Previous behavior: The behavior was to ignore a fail to activate a component unless any secondary fault happened. This means that it was for example possible to complete a campaign even if a component failed to start and fix this problem after committing. No action to resume the campaign was needed. After [#2145]: The campaign will always suspend in case of component fail and a resume must be requested for the campaign to continue. NBC: The behavior has changed in such a way that it must be seen as a NBC. The #2145 ticket corrects SMF behavior regarding AIS but is still NBC since the previous behavior is the legacy behavior in previous releases. Proposal 1; Fix if not needed to change setting in runtime e.g. during an upgrade Add a new configuration attribute to the SMF configuration class that makes it possible to select whether the behavior after #2145 shall be used or not. The default setting must be the previous behavior. The setting must have the following properties: - If the attribute does not exist (old model) legacy behavior - If the attribute value is not changed from defaultlegacy behavior - If the attribute value is or invalid legacy behavior - If the attribute value is a valid “ON” settingnew behavior - A request to change the attribute in runtime shall always be rejected Proposal 2; Fix if change has to be made during upgrade: Add a new configuration attribute to the SMF configuration class that makes it possible to select whether the behavior after #2145 shall be used or not. The default setting must be the previous behavior. The setting must have the following properties: - If the attribute does not exist (old model) legacy behavior - If the attribute value is not changed from defaultlegacy behavior - If the attribute value is or invalid legacy behavior - If the attribute value is a valid “ON” settingnew behavior - Attribute value must be possible to change in runtime in “idle” state (no campaign is executing) - Attribute value must be possible to change in runtime in campaign init state. Note that if changed here the new setting must be used in the rest of the campaign --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2419 smf: when fixing ticket #2145 a NBC problem was introduced
> This means that it was for example possible to complete a campaign even if a > component failed to start and fix this problem after committing. No action to > resume the campaign was needed. Just playing devil's advocate here... If the admin was prepared to restart a component after the campaign was committed, why is it a big deal to do this during the campaign? SMF already supports the "suspended by error detected" state for other problems (e.g. node failing to come back after reboot for a rolling upgrade w/reboot campaign). So, it is already possible for the admin to restart a campaign before it has been committed. --- ** [tickets:#2419] smf: when fixing ticket #2145 a NBC problem was introduced** **Status:** unassigned **Milestone:** 5.2.0 **Created:** Mon Apr 10, 2017 11:11 AM UTC by elunlen **Last Updated:** Mon Apr 10, 2017 11:18 AM UTC **Owner:** nobody Previous behavior: The behavior was to ignore a fail to activate a component unless any secondary fault happened. This means that it was for example possible to complete a campaign even if a component failed to start and fix this problem after committing. No action to resume the campaign was needed. After [#2145]: The campaign will always suspend in case of component fail and a resume must be requested for the campaign to continue. NBC: The behavior has changed in such a way that it must be seen as a NBC. The #2145 ticket corrects SMF behavior regarding AIS but is still NBC since the previous behavior is the legacy behavior in previous releases. Proposal 1; Fix if not needed to change setting in runtime e.g. during an upgrade Add a new configuration attribute to the SMF configuration class that makes it possible to select whether the behavior after #2145 shall be used or not. The default setting must be the previous behavior. The setting must have the following properties: - If the attribute does not exist (old model) legacy behavior - If the attribute value is not changed from defaultlegacy behavior - If the attribute value is or invalid legacy behavior - If the attribute value is a valid “ON” settingnew behavior - A request to change the attribute in runtime shall always be rejected Proposal 2; Fix if change has to be made during upgrade: Add a new configuration attribute to the SMF configuration class that makes it possible to select whether the behavior after #2145 shall be used or not. The default setting must be the previous behavior. The setting must have the following properties: - If the attribute does not exist (old model) legacy behavior - If the attribute value is not changed from defaultlegacy behavior - If the attribute value is or invalid legacy behavior - If the attribute value is a valid “ON” settingnew behavior - Attribute value must be possible to change in runtime in “idle” state (no campaign is executing) - Attribute value must be possible to change in runtime in campaign init state. Note that if changed here the new setting must be used in the rest of the campaign --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2419 smf: when fixing ticket #2145 a NBC problem was introduced
Reference to earlier mail converstion about this: http://sourceforge.net/p/opensaf/mailman/message/35490515/ --- ** [tickets:#2419] smf: when fixing ticket #2145 a NBC problem was introduced** **Status:** unassigned **Milestone:** 5.2.0 **Created:** Mon Apr 10, 2017 11:11 AM UTC by elunlen **Last Updated:** Mon Apr 10, 2017 11:11 AM UTC **Owner:** nobody Previous behavior: The behavior was to ignore a fail to activate a component unless any secondary fault happened. This means that it was for example possible to complete a campaign even if a component failed to start and fix this problem after committing. No action to resume the campaign was needed. After [#2145]: The campaign will always suspend in case of component fail and a resume must be requested for the campaign to continue. NBC: The behavior has changed in such a way that it must be seen as a NBC. The #2145 ticket corrects SMF behavior regarding AIS but is still NBC since the previous behavior is the legacy behavior in previous releases. Proposal 1; Fix if not needed to change setting in runtime e.g. during an upgrade Add a new configuration attribute to the SMF configuration class that makes it possible to select whether the behavior after #2145 shall be used or not. The default setting must be the previous behavior. The setting must have the following properties: - If the attribute does not exist (old model) legacy behavior - If the attribute value is not changed from defaultlegacy behavior - If the attribute value is or invalid legacy behavior - If the attribute value is a valid “ON” settingnew behavior - A request to change the attribute in runtime shall always be rejected Proposal 2; Fix if change has to be made during upgrade: Add a new configuration attribute to the SMF configuration class that makes it possible to select whether the behavior after #2145 shall be used or not. The default setting must be the previous behavior. The setting must have the following properties: - If the attribute does not exist (old model) legacy behavior - If the attribute value is not changed from defaultlegacy behavior - If the attribute value is or invalid legacy behavior - If the attribute value is a valid “ON” settingnew behavior - Attribute value must be possible to change in runtime in “idle” state (no campaign is executing) - Attribute value must be possible to change in runtime in campaign init state. Note that if changed here the new setting must be used in the rest of the campaign --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2419 smf: when fixing ticket #2145 a NBC problem was introduced
--- ** [tickets:#2419] smf: when fixing ticket #2145 a NBC problem was introduced** **Status:** unassigned **Milestone:** 5.2.0 **Created:** Mon Apr 10, 2017 11:11 AM UTC by elunlen **Last Updated:** Mon Apr 10, 2017 11:11 AM UTC **Owner:** nobody Previous behavior: The behavior was to ignore a fail to activate a component unless any secondary fault happened. This means that it was for example possible to complete a campaign even if a component failed to start and fix this problem after committing. No action to resume the campaign was needed. After [#2145]: The campaign will always suspend in case of component fail and a resume must be requested for the campaign to continue. NBC: The behavior has changed in such a way that it must be seen as a NBC. The #2145 ticket corrects SMF behavior regarding AIS but is still NBC since the previous behavior is the legacy behavior in previous releases. Proposal 1; Fix if not needed to change setting in runtime e.g. during an upgrade Add a new configuration attribute to the SMF configuration class that makes it possible to select whether the behavior after #2145 shall be used or not. The default setting must be the previous behavior. The setting must have the following properties: - If the attribute does not exist (old model) legacy behavior - If the attribute value is not changed from defaultlegacy behavior - If the attribute value is or invalid legacy behavior - If the attribute value is a valid “ON” settingnew behavior - A request to change the attribute in runtime shall always be rejected Proposal 2; Fix if change has to be made during upgrade: Add a new configuration attribute to the SMF configuration class that makes it possible to select whether the behavior after #2145 shall be used or not. The default setting must be the previous behavior. The setting must have the following properties: - If the attribute does not exist (old model) legacy behavior - If the attribute value is not changed from defaultlegacy behavior - If the attribute value is or invalid legacy behavior - If the attribute value is a valid “ON” settingnew behavior - Attribute value must be possible to change in runtime in “idle” state (no campaign is executing) - Attribute value must be possible to change in runtime in campaign init state. Note that if changed here the new setting must be used in the rest of the campaign --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
