Re: [opensc-devel] patch quality standards?
On 03/24/2012 09:45 AM, Ludovic Rousseau wrote: > Most of your remarks were already in > https://www.opensc-project.org/opensc/wiki/DevelopmentPolicy#Movingmasterforward > I added what was missing. Thanks Thank you, I added the link to the CodeReview page. ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] patch quality standards?
Le 24 mars 2012 00:43, "Magosányi, Árpád" a écrit : > Looking at https://www.opensc-project.org/codereview/#/c/150/ , which is > a patch which is overwritten by a later patch in gerrit, I started to > wonder again about quality standards. And this: > http://lwn.net/Articles/328438/ > And there should be others. This is what I have gathered so far: > - whitespace problems marked red in gerrit are bad > - unchecked null pointers are bad > - with a warning cleanup patch state the warnings which had been cleaned up > - comment. the comment and the code should be in sync > - provide a (description of purpose? man page?) with a command-line program > and there is that fighter airplane book, but maybe it is too long > and I am a big fan of unit tests if someone else have to do them ;) > the same about programming contracts ;) > I'm in no position to draw the rules, so I am not creating a wiki page > out of this, but I suggest that someone do. > It would help the work of code reviewers. Most of your remarks were already in https://www.opensc-project.org/opensc/wiki/DevelopmentPolicy#Movingmasterforward I added what was missing. Thanks -- Dr. Ludovic Rousseau ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
[opensc-devel] patch quality standards?
Looking at https://www.opensc-project.org/codereview/#/c/150/ , which is a patch which is overwritten by a later patch in gerrit, I started to wonder again about quality standards. And this: http://lwn.net/Articles/328438/ And there should be others. This is what I have gathered so far: - whitespace problems marked red in gerrit are bad - unchecked null pointers are bad - with a warning cleanup patch state the warnings which had been cleaned up - comment. the comment and the code should be in sync - provide a (description of purpose? man page?) with a command-line program and there is that fighter airplane book, but maybe it is too long and I am a big fan of unit tests if someone else have to do them ;) the same about programming contracts ;) I'm in no position to draw the rules, so I am not creating a wiki page out of this, but I suggest that someone do. It would help the work of code reviewers. ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
