[osol-discuss] using webrev

[[EMAIL PROTECTED]]

Hi All,
I would like to make a webrev for my changes to mdb.  I tried webrev, 
but that complained.  Then I looked at the
documentation for webrev and then tried ws, but that also complained.  
Is there a way to do this with
source that I downloaded back in February?  Must I use svn?  Can I 
simply post the changed file(s)
and let someone else generate the webrev?  Or should I just forget 
webrev and post the changed file(s)?
Or do I really need to wade through all of the documentation (or lack 
thereof)? Or...?

thanks,
max

___
opensolaris-discuss mailing list
opensolaris-discuss@opensolaris.org

Re: [osol-discuss] using webrev

[Gavin Maltby]

Hi,

On 09/23/07 20:03, [EMAIL PROTECTED] wrote:

Hi All,
I would like to make a webrev for my changes to mdb.  I tried webrev, 
but that complained.  Then I looked at the
documentation for webrev and then tried ws, but that also complained.  
Is there a way to do this with
source that I downloaded back in February?  Must I use svn?  Can I 
simply post the changed file(s)
and let someone else generate the webrev?  Or should I just forget 
webrev and post the changed file(s)?
Or do I really need to wade through all of the documentation (or lack 
thereof)? Or...?


webrev is the format most Sun ON folks are familiar with, so it's
worth the effort.

Assuming you have this under a Mercurial workspace I'd suggest
pulling the SCM tools workspace from the project pages and using
the webrev in that.  Or see if a SUNWonbld package built from
that workspace is available.  With that installed and in your
PATH webrev simply figures out that this is an hg workspace
and just works if you have the workspace under wx control
(also in that package).  If not then you will need
to prepare a file listing modified files relative to
the top of the workspace (ie all starting with usr/)
and feed that into webrev as cat file | webrev -.

http://www.opensolaris.org/os/project/scm-migration/

I think I remember seeing a link to a SUNWonbld package for
download from those pages once.  If not then suggest to the
project they add one!  The onnv-scm workspace is linked
on the page above - pull it and then dmake instal
in usr/src/tools

Gavin


smime.p7s
Description: S/MIME Cryptographic Signature
___
opensolaris-discuss mailing list
opensolaris-discuss@opensolaris.org

Re: [osol-discuss] using webrev

[[EMAIL PROTECTED]]

Hi Gavin,
Gavin Maltby wrote:
> Hi,
>
> On 09/23/07 20:03, [EMAIL PROTECTED] wrote:
>> Hi All,
>> I would like to make a webrev for my changes to mdb.  I tried webrev, 
>> but that complained.  Then I looked at the
>> documentation for webrev and then tried ws, but that also 
>> complained.  Is there a way to do this with
>> source that I downloaded back in February?  Must I use svn?  Can I 
>> simply post the changed file(s)
>> and let someone else generate the webrev?  Or should I just forget 
>> webrev and post the changed file(s)?
>> Or do I really need to wade through all of the documentation (or lack 
>> thereof)? Or...?
>
> webrev is the format most Sun ON folks are familiar with, so it's
> worth the effort.
>
> Assuming you have this under a Mercurial workspace I'd suggest
> pulling the SCM tools workspace from the project pages and using
> the webrev in that.  Or see if a SUNWonbld package built from
> that workspace is available.  With that installed and in your
> PATH webrev simply figures out that this is an hg workspace
> and just works if you have the workspace under wx control
> (also in that package).  If not then you will need
> to prepare a file listing modified files relative to
> the top of the workspace (ie all starting with usr/)
> and feed that into webrev as cat file | webrev -.
>
> http://www.opensolaris.org/os/project/scm-migration/
>
> I think I remember seeing a link to a SUNWonbld package for
> download from those pages once.  If not then suggest to the
> project they add one!  The onnv-scm workspace is linked
> on the page above - pull it and then dmake instal
> in usr/src/tools
>
OK.  I have downloaded the latest source from Merurial.  I also 
downloaded the SCM workspace.
Then I tried dmake install in usr/src/tools, but the dmake fails with 
lots of complaints about mpy_compile
not found.  I tried using ws, simply running it in the onnv-gate 
directory on my machine,
but it says workspace not found.  So I figured I would use the pathname 
(/export/home/max/onnv-gate),
but this is not a workspace.  Then I tried wx with similar results.  So 
then I tried webrev, but this
says it is Unable to determine SCM type currently in use.  One of the 
commands referred to another command
called "workspace", but this is not on my machine.

At this rate, it will take me as long to get webrev to work as it took 
to make the changes/additions I want
the webrev for.   By the way, I have never seen a good environment for 
this.   Usually you have to sit
with someone who has done it before.  And when it changes, you have to 
learn it all over again.  And no,
I do not have suggestions to make it easier, but a 1 page cookbook for 
setting up a workspace
would be nice.   I just want a list of commands,
something like:

1. run blah to create a workspace
2. run foo to generate a fubar
3. run bar on fubar to generate crud
4. edit xxx and change your settings
5. run webrev

One other thing, the help message when you run wx with no arguments 
refers to: See  for usage tips,
which is pretty much worthless if you do not work for Sun.

I am also sending this to the tools-discuss list.  Maybe someone there 
has a 1 pager.  As it is, it looks like there
are probably several ways to do this, but you have to know the path to 
take in advance...

thanks
max

___
opensolaris-discuss mailing list
opensolaris-discuss@opensolaris.org

Re: [osol-discuss] using webrev

[Gavin Maltby]

On 09/24/07 13:37, [EMAIL PROTECTED] wrote:

[cut]



I am also sending this to the tools-discuss list.  Maybe someone there 
has a 1 pager.  As it is, it looks like there
are probably several ways to do this, but you have to know the path to 
take in advance...


Try http://dlc.sun.com/osol/scm/SUNWonbld/ - zillions there, but
SUNWonbld-latest.{i386,sparc}.tar.bz2 looks like it should be
what you want.  pkgadd this and it will install into the
usual SUNWonbld destinations (/opt/onbld) - so take care
of anything you have there at the moment.  Now add
/opt/onbld/bin and /opt/onbld/bin/$(uname -p) to your
path, and the webrev should work for you.  I believe
wx there is also hg aware - eg it can find all files
you have edited and create a wx active file.  You
should be able to wx init your workspace and have it find
all modified files, then wx webrev will do the business.

Gavin


smime.p7s
Description: S/MIME Cryptographic Signature
___
opensolaris-discuss mailing list
opensolaris-discuss@opensolaris.org

Re: [osol-discuss] using webrev

[[EMAIL PROTECTED]]

Gavin Maltby wrote:
> On 09/24/07 13:37, [EMAIL PROTECTED] wrote:
>
> [cut]
>
>>
>> I am also sending this to the tools-discuss list.  Maybe someone 
>> there has a 1 pager.  As it is, it looks like there
>> are probably several ways to do this, but you have to know the path 
>> to take in advance...
>
> Try http://dlc.sun.com/osol/scm/SUNWonbld/ - zillions there, but
> SUNWonbld-latest.{i386,sparc}.tar.bz2 looks like it should be
> what you want.  pkgadd this and it will install into the
> usual SUNWonbld destinations (/opt/onbld) - so take care
> of anything you have there at the moment.  Now add
> /opt/onbld/bin and /opt/onbld/bin/$(uname -p) to your
> path, and the webrev should work for you.  I believe
> wx there is also hg aware - eg it can find all files
> you have edited and create a wx active file.  You
> should be able to wx init your workspace and have it find
> all modified files, then wx webrev will do the business.
>

I tried running webrev.  This seems to work, except that it does not 
pick up any changes.
The resulting index.html file has no information about changes I made.   
I changed one file
(usr/src/cmd/mdb/common/mdb/mdb_rawfile.c), but the index.html file that 
webrev produces says 0 changes.
 
Here are the steps I take, along with output...

bash-3.00$ bldenv opensolaris.sh
Build type   is  non-DEBUG
RELEASE  is 
VERSION  is  onnv-gate
RELEASE_DATE is 

The top-level 'setup' target is available to build headers and tools.

Using /bin/bash as shell.
bash-3.00$ wx init
Error: wx does not support Mercurial repositories.
Please see http://opensolaris.org/os/community/tools/hg Aborting .
bash-3.00$ ws
Defaulting to Mercurial repository /export/home/max/onnv-gate

Workspace: /export/home/max/onnv-gate
Workspace Parent : 
ssh://[EMAIL PROTECTED]/hg/onnv/onnv-gate
Proto area ($ROOT)   : /export/home/max/onnv-gate/proto/root_i386
Root of source ($SRC): /export/home/max/onnv-gate/usr/src
Root of test source ($TSRC)  : /export/home/max/onnv-gate/usr/ontest
Prepended to PATH: /opt/onbld/bin
Current directory ($PWD) : /export/home/max/onnv-gate

bash-3.00$ webrev
   SCM detected: mercurial
 File list from: hg-active -p 
ssh://[EMAIL PROTECTED]/hg/onnv/onnv-gate ...Traceback (most 
recent call last):
  File "/opt/onbld/bin/hg-active", line 42, in ?
from onbld.Scm.WorkSpace import WorkSpace
  File "WorkSpace.py", line 68, in ?
ImportError: cannot import name context
 Done.
  Comments from: hg-active -p 
ssh://[EMAIL PROTECTED]/hg/onnv/onnv-gate ... Done.
  Workspace: /export/home/max/onnv-gate (at d3d745ca6aaf)
Compare against: ssh://[EMAIL PROTECTED]/hg/onnv/onnv-gate
  Output to: /export/home/max/onnv-gate/webrev
   Output Files:
 Generating PDF: Skipped: no output available
 index.html: Done.
bash-3.00$

Thanks much for your patience.

max


> Gavin

___
opensolaris-discuss mailing list
opensolaris-discuss@opensolaris.org

Re: [osol-discuss] using webrev

[[EMAIL PROTECTED]]

Gavin Maltby wrote:
> On 09/24/07 13:37, [EMAIL PROTECTED] wrote:
>
> [cut]
>
>>
>> I am also sending this to the tools-discuss list.  Maybe someone 
>> there has a 1 pager.  As it is, it looks like there
>> are probably several ways to do this, but you have to know the path 
>> to take in advance...
>
> Try http://dlc.sun.com/osol/scm/SUNWonbld/ - zillions there, but
> SUNWonbld-latest.{i386,sparc}.tar.bz2 looks like it should be
> what you want.  pkgadd this and it will install into the
> usual SUNWonbld destinations (/opt/onbld) - so take care
> of anything you have there at the moment.  Now add
> /opt/onbld/bin and /opt/onbld/bin/$(uname -p) to your
> path, and the webrev should work for you.  I believe
> wx there is also hg aware - eg it can find all files
> you have edited and create a wx active file.  You
> should be able to wx init your workspace and have it find
> all modified files, then wx webrev will do the business.
>
> Gavin
Ok.  "hg status" and "hg diff" pick up the changes just fine... What's 
with webrev?

thanks,
max

___
opensolaris-discuss mailing list
opensolaris-discuss@opensolaris.org

Re: [osol-discuss] using webrev

[Stephen Lau]

Gavin Maltby wrote:
> Hi,
> 
> On 09/23/07 20:03, [EMAIL PROTECTED] wrote:
>> Hi All,
>> I would like to make a webrev for my changes to mdb.  I tried webrev, 
>> but that complained.  Then I looked at the
>> documentation for webrev and then tried ws, but that also complained.  
>> Is there a way to do this with
>> source that I downloaded back in February?  Must I use svn?  Can I 
>> simply post the changed file(s)
>> and let someone else generate the webrev?  Or should I just forget 
>> webrev and post the changed file(s)?
>> Or do I really need to wade through all of the documentation (or lack 
>> thereof)? Or...?
> 
> webrev is the format most Sun ON folks are familiar with, so it's
> worth the effort.
> 
> Assuming you have this under a Mercurial workspace I'd suggest
> pulling the SCM tools workspace from the project pages and using
> the webrev in that.  Or see if a SUNWonbld package built from
> that workspace is available.  With that installed and in your
> PATH webrev simply figures out that this is an hg workspace
> and just works if you have the workspace under wx control
> (also in that package).  If not then you will need
> to prepare a file listing modified files relative to
> the top of the workspace (ie all starting with usr/)
> and feed that into webrev as cat file | webrev -.
> 
> http://www.opensolaris.org/os/project/scm-migration/
> 
> I think I remember seeing a link to a SUNWonbld package for
> download from those pages once.  If not then suggest to the
> project they add one!  The onnv-scm workspace is linked
> on the page above - pull it and then dmake instal
> in usr/src/tools

http://dlc.sun.com/osol/scm/SUNWonbld/

cheers,
steve
-- 
stephen lau // [EMAIL PROTECTED] | http://whacked.net
opensolaris // solaris kernel development
___
opensolaris-discuss mailing list
opensolaris-discuss@opensolaris.org

Re: [osol-discuss] using webrev

[Richard Lowe]

"[EMAIL PROTECTED]" <[EMAIL PROTECTED]> writes:

> Gavin Maltby wrote:
>> On 09/24/07 13:37, [EMAIL PROTECTED] wrote:
>>
>> [cut]
>>
>>>
>>> I am also sending this to the tools-discuss list.  Maybe someone 
>>> there has a 1 pager.  As it is, it looks like there
>>> are probably several ways to do this, but you have to know the path 
>>> to take in advance...
>>
>> Try http://dlc.sun.com/osol/scm/SUNWonbld/ - zillions there, but
>> SUNWonbld-latest.{i386,sparc}.tar.bz2 looks like it should be
>> what you want.  pkgadd this and it will install into the
>> usual SUNWonbld destinations (/opt/onbld) - so take care
>> of anything you have there at the moment.  Now add
>> /opt/onbld/bin and /opt/onbld/bin/$(uname -p) to your
>> path, and the webrev should work for you.  I believe
>> wx there is also hg aware - eg it can find all files
>> you have edited and create a wx active file.  You
>> should be able to wx init your workspace and have it find
>> all modified files, then wx webrev will do the business.
>>
>> Gavin
> Ok.  "hg status" and "hg diff" pick up the changes just fine... What's 
> with webrev?

Is this still a problem after your mail of this morning saying that an
updated version of Hg got it working?

If so, could you send me (off-list, if you want) some more detail
about what's going on.

-- Rich
___
opensolaris-discuss mailing list
opensolaris-discuss@opensolaris.org

Re: [osol-discuss] using webrev

[[EMAIL PROTECTED]]

Richard Lowe wrote:
> "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> writes:
>
>   
>> Gavin Maltby wrote:
>> 
>>> On 09/24/07 13:37, [EMAIL PROTECTED] wrote:
>>>
>>> [cut]
>>>
>>>   
 I am also sending this to the tools-discuss list.  Maybe someone 
 there has a 1 pager.  As it is, it looks like there
 are probably several ways to do this, but you have to know the path 
 to take in advance...
 
>>> Try http://dlc.sun.com/osol/scm/SUNWonbld/ - zillions there, but
>>> SUNWonbld-latest.{i386,sparc}.tar.bz2 looks like it should be
>>> what you want.  pkgadd this and it will install into the
>>> usual SUNWonbld destinations (/opt/onbld) - so take care
>>> of anything you have there at the moment.  Now add
>>> /opt/onbld/bin and /opt/onbld/bin/$(uname -p) to your
>>> path, and the webrev should work for you.  I believe
>>> wx there is also hg aware - eg it can find all files
>>> you have edited and create a wx active file.  You
>>> should be able to wx init your workspace and have it find
>>> all modified files, then wx webrev will do the business.
>>>
>>> Gavin
>>>   
>> Ok.  "hg status" and "hg diff" pick up the changes just fine... What's 
>> with webrev?
>> 
>
> Is this still a problem after your mail of this morning saying that an
> updated version of Hg got it working?
>
> If so, could you send me (off-list, if you want) some more detail
> about what's going on.
>
> -- Rich
>
>   
An upgraded hg fixed the problem.
thanks,
max


___
opensolaris-discuss mailing list
opensolaris-discuss@opensolaris.org