[opensource-dev] Where is MXP implementation ?
Where is MXP implementation ? hi everybody, RealXtend uses MXP but where exactly, i mean which part and where its used or implemented please let me know. if possible file name and function name thank you in advance !! ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Motto Goals (was: STORM-243 - simulator version notifications)
On 01/19/2011 09:20 AM, Stickman wrote: Is there a mission statement, a motto, a creed, or a list of goals somewhere? Fast, Easy and Fun, wasn't it? Or has that motto, too, already been antiquated? A list of long term goals (besides what is dictated by server side changes anyway) would interest me, too, though. Boroondas ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Daily Scrum Summary - Wednesday, January 19
Wedensday, January 19, 2011 General Notes
--
- MMOTD: Oz
Team Status
--
Merov Linden
--
*PAST*
- OH: SNOW triaging, need to move a bunch of SNOW records as a result
- SH-761: Texture Saving Does Not Work : worked with Bao on that. Need to
evaluate his patch.
- STORM-745 : KDU Perf : Got Windows data. Need to run that on Linux.
- STORM-748 : KDU_X86_INTRINSICS : Patched vcproj to build with this. In
progress.
*FUTURE*
- STORM-748 : Finish
- STORM-745 : Finish
*IMPEDIMENTS*
- none
Oz Linden
--
*PAST*
- Merge Monkey
- Caught up on what Team Chopper is doing (autobuild)
*FUTURE*
- Review patches in codereview
- Merge Monkey
*IMPEDIMENTS*
- moving large amounts of slush around :-(
Q Linden
--
*PAST*
- STORM-725
- STORM-864
- VWR-24426
- SOCIAL-452
- STORM-243
- Internal meetings
- Snowstorm weekly meeting
- 2.5 beta 1
*FUTURE*
- VWR-24426
- Dr's appt today
- triage
*IMPEDIMENTS*
- Not enough rope to tie esbee to her chair. :(
Esbee Linden
--
*PAST*
- Meetings, Email
- My last OH :(
- Jira ticket reviews and cleanup
*FUTURE*
- Review Snowstorm Team product backlog and bug log
- Tix which require feedback: STORM-28, -812, -226, -174
- Review developer build for the tix in the PO review queue:
STORM-2, -383, -484, -844, -834, -832, -715
https://jira.secondlife.com/secure/IssueNavigator.jspa?requestId=13662mode=hide
- Hopefully work on STORM-26 w/Q
- Review tickets assigned to me
*IMPEDIMENTS*
- None
Paul ProductEngine
--
*PAST*
- BUG STORM-547 (Name of blocked person is not presented in list if
person was blocked from Inspector)
- Fixed sent for review
- BUG STORM-613 ((i) button overlaps resident names in the Group chat
participant list )
- Resolved as cannot reproduce
- BUG STORM-665 (User is not able to view full name of Group's founder in
the Group Profile)
- Investigated and resolved as cannot reproduce
- BUG STORM-629 (Place Rating text is quoted and is not translated in
Polish localization)
- Investigated and assigned to Eli.
- BUG STORM-612 ('Didn't find..' text overlaps My inventory folder name
in Pick Texture window)
- Tried to reproduce. Tomorrow will try again.
*FUTURE*
- BUG STORM-612 ('Didn't find..' text overlaps My inventory folder name
in Pick Texture window)
*IMPEDIMENTS*
- none
Seth Productengine
--
*PAST*
- BUG (STORM-316) Debug: Inventory.Folders by Name/Sort by Date/Sort by
Name/System Folders to Top Do not apply and settings changes do not persist
after relogging.
- WIP. Investigating. Seems that the issue affects only Inventory SP
and does not reproduce on inventory floaters.
*FUTURE*
- BUG (STORM-316) Debug: Inventory.Folders by Name/Sort by Date/Sort by
Name/System Folders to Top Do not apply and settings changes do not persist
after relogging.
- BUG (STORM-843) Inventory incremental string search not working (search
starts over)
*IMPEDIMENTS*
- none
Vadim Productengine
--
*PAST*
- Bug STORM-373 ('Rename' is sometimes disabled in inventory item context
menu):
- Completed the fix and put it on review.
- Bug STORM-243 (Suppress version change message in the viewer):
- Fixed; put the fix on review.
- Bug STORM-547 (Name of blocked person is not presented in list if
person was blocked from Inspector):
- Helped Paul to fix it.
- Bug STORM-599 (Name tags radio buttons are not in focus after they were
clicked):
- Resolved as expected behavior.
- Bug STORM-465 (Missing Strings from strings.xml):
-
WIP.
*FUTURE*
- Complete fixing STORM-465.
- Other bugs.
*IMPEDIMENTS*
- Unclear what to do with STORM-174: the feature requires simulator work.
- No clear acceptance criteria for STORM-226 (Floating Text aligns
improperly).
-
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: make PREHASH variables char const* const
On Jan. 18, 2011, 5:58 p.m., Aleric Inglewood wrote: I love it! Thanks, this was stopped me from compiling the tests (since some commit not long ago I guess, because I could before). Just one remark. In one test _PREHASH_AgentID is set to AgentID (no doubt a place holder), while in the other you set it to 0 (now needed because it's a const). Perhaps a more symmetric approach is better? I'd opt for setting the other also to a random string, like Grumpity Productengine, or Aleric Inglewood now I think about it. Other options are All Your Base Are Belong To Us and Hi mom!. Got be SURE they aren't used though -- don't want any new 'Grumpity' embarrashments :p Because I don't know how to quote code in a comment, I'll answer in a 'review'. See below. - Boroondas --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review196 --- On Jan. 18, 2011, 7:29 a.m., Boroondas Gupte wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/ --- (Updated Jan. 18, 2011, 7:29 a.m.) Review request for Viewer. Summary --- For the reason for this change, see https://jira.secondlife.com/browse/VWR-24487 and https://jira.secondlife.com/browse/VWR-24522 What I did: In indra/llmessage/message_prehash.(h|cpp), I turned everything into constant pointers to constants by search/replace. Then I tried to compile and added const qualifiers in dependent code as needed to stop the compiler complaining. Note that comments in indra/llmessage/message_prehash.(h|cpp) say these files have been generated from the message template. If this generation wasn't a one-off thing, the generating code must be changed, too, so it won't override this change here when the generation happens the next time. This addresses bug VWR-24487. http://jira.secondlife.com/browse/VWR-24487 Diffs - doc/contributions.txt fc7e5dcf3059 indra/llmessage/message_prehash.h fc7e5dcf3059 indra/llmessage/message_prehash.cpp fc7e5dcf3059 indra/llprimitive/llprimitive.h fc7e5dcf3059 indra/llprimitive/llprimitive.cpp fc7e5dcf3059 indra/llprimitive/llvolumemessage.h fc7e5dcf3059 indra/llprimitive/llvolumemessage.cpp fc7e5dcf3059 indra/llui/tests/llurlentry_stub.cpp fc7e5dcf3059 indra/newview/tests/llremoteparcelrequest_test.cpp fc7e5dcf3059 Diff: http://codereview.secondlife.com/r/100/diff Testing --- Compiled (standalone, 64bit Linux) with and without LL_TESTS. Started the viewer, logged in, walked and flew around a bit. Everything seems to work. Thanks, Boroondas ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: make PREHASH variables char const* const
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review207 --- Just one remark. In one test _PREHASH_AgentID is set to AgentID (no doubt a place holder), while in the other you set it to 0 (now needed because it's a const). Perhaps a more symmetric approach is better? indra/llui/tests/llurlentry_stub.cpp http://codereview.secondlife.com/r/100/#comment152 This test already contained these placeholder strings, so I just left it at that, only adapting the types. indra/newview/tests/llremoteparcelrequest_test.cpp http://codereview.secondlife.com/r/100/#comment153 In this test here, however, I think the pointers actually ended up undefined in the original code, so setting them to NULL was the closest I possibility could think off. As building succeeded with this, I concluded that these pointers are passed around but never dereferenced during the test.[*] I feel setting nullpointers nicely signals that fact, though it should probably be augmented by a // never used during this test or // never dereferenced in this test comment to make that intent clear. I agree though, that we should try to handle this similarly in both tests, if possible. So I tried setting the pointers in indra/llui/tests/llurlentry_stub.cpp to NULL, too, which works nicely. However, I then realized that the tested code might have nullpointer guards around dereferencing code, so that if we pass nullpointers we are actually testing another scenario than when passing pointers to actual data and that this might be the reason why no null-pointer exceptions occur during the tests. Of course, we could now examine the tested code to see whether this is the case. However, it would be a bad idea to adapt the test code based on that examination, as the tested code might be changed later without this question being re-evaluated and the test rewritten accordingly. Is there another pointer value besides NULL (thus not usually tested for) that still fails reliably when tried to dereference? [*] Remember that tests are executed when building and are hopefully completely deterministic, so that any potential null-pointer-exception would have shown up. - Boroondas On Jan. 18, 2011, 7:29 a.m., Boroondas Gupte wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/ --- (Updated Jan. 18, 2011, 7:29 a.m.) Review request for Viewer. Summary --- For the reason for this change, see https://jira.secondlife.com/browse/VWR-24487 and https://jira.secondlife.com/browse/VWR-24522 What I did: In indra/llmessage/message_prehash.(h|cpp), I turned everything into constant pointers to constants by search/replace. Then I tried to compile and added const qualifiers in dependent code as needed to stop the compiler complaining. Note that comments in indra/llmessage/message_prehash.(h|cpp) say these files have been generated from the message template. If this generation wasn't a one-off thing, the generating code must be changed, too, so it won't override this change here when the generation happens the next time. This addresses bug VWR-24487. http://jira.secondlife.com/browse/VWR-24487 Diffs - doc/contributions.txt fc7e5dcf3059 indra/llmessage/message_prehash.h fc7e5dcf3059 indra/llmessage/message_prehash.cpp fc7e5dcf3059 indra/llprimitive/llprimitive.h fc7e5dcf3059 indra/llprimitive/llprimitive.cpp fc7e5dcf3059 indra/llprimitive/llvolumemessage.h fc7e5dcf3059 indra/llprimitive/llvolumemessage.cpp fc7e5dcf3059 indra/llui/tests/llurlentry_stub.cpp fc7e5dcf3059 indra/newview/tests/llremoteparcelrequest_test.cpp fc7e5dcf3059 Diff: http://codereview.secondlife.com/r/100/diff Testing --- Compiled (standalone, 64bit Linux) with and without LL_TESTS. Started the viewer, logged in, walked and flew around a bit. Everything seems to work. Thanks, Boroondas ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review208 --- Ship it! No missing string warnings while looking through the menu with this patch. - Seth On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/ --- (Updated Jan. 19, 2011, 8:30 a.m.) Review request for Viewer. Summary --- Made all keys localizable. This addresses bug STORM-465. http://jira.secondlife.com/browse/STORM-465 Diffs - indra/newview/skins/default/xui/en/strings.xml 38465c40c060 Diff: http://codereview.secondlife.com/r/108/diff Testing --- Tested on Linux. No keys produce the warning for me. Thanks, Vadim ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: make PREHASH variables char const* const
On Jan. 20, 2011, 3:54 a.m., Boroondas Gupte wrote: I agree though, that we should try to handle this similarly in both tests, if possible. So I tried setting the pointers in indra/llui/tests/llurlentry_stub.cpp to NULL, too, which works nicely. However, I then realized that the tested code might have nullpointer guards around dereferencing code, so that if we pass nullpointers we are actually testing another scenario than when passing pointers to actual data and that this might be the reason why no null-pointer exceptions occur during the tests. Of course, we could now examine the tested code to see whether this is the case. However, it would be a bad idea to adapt the test code based on that examination, as the tested code might be changed later without this question being re-evaluated and the test rewritten accordingly. Is there another pointer value besides NULL (thus not usually tested for) that still fails reliably when tried to dereference? [*] Remember that tests are executed when building and are hopefully completely deterministic, so that any potential null-pointer-exception would have shown up. Sure set them to (char const*)0x1; That is not false, and surely will crash if you try to access it (it's odd). I'd only do this once for a local test though. If it still runs fine, you can set them to NULL and add a comment that they're not used. - Aleric --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review207 --- On Jan. 18, 2011, 7:29 a.m., Boroondas Gupte wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/ --- (Updated Jan. 18, 2011, 7:29 a.m.) Review request for Viewer. Summary --- For the reason for this change, see https://jira.secondlife.com/browse/VWR-24487 and https://jira.secondlife.com/browse/VWR-24522 What I did: In indra/llmessage/message_prehash.(h|cpp), I turned everything into constant pointers to constants by search/replace. Then I tried to compile and added const qualifiers in dependent code as needed to stop the compiler complaining. Note that comments in indra/llmessage/message_prehash.(h|cpp) say these files have been generated from the message template. If this generation wasn't a one-off thing, the generating code must be changed, too, so it won't override this change here when the generation happens the next time. This addresses bug VWR-24487. http://jira.secondlife.com/browse/VWR-24487 Diffs - doc/contributions.txt fc7e5dcf3059 indra/llmessage/message_prehash.h fc7e5dcf3059 indra/llmessage/message_prehash.cpp fc7e5dcf3059 indra/llprimitive/llprimitive.h fc7e5dcf3059 indra/llprimitive/llprimitive.cpp fc7e5dcf3059 indra/llprimitive/llvolumemessage.h fc7e5dcf3059 indra/llprimitive/llvolumemessage.cpp fc7e5dcf3059 indra/llui/tests/llurlentry_stub.cpp fc7e5dcf3059 indra/newview/tests/llremoteparcelrequest_test.cpp fc7e5dcf3059 Diff: http://codereview.secondlife.com/r/100/diff Testing --- Compiled (standalone, 64bit Linux) with and without LL_TESTS. Started the viewer, logged in, walked and flew around a bit. Everything seems to work. Thanks, Boroondas ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: Help Needed to debug small problem with code for STORM-236.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/112/ --- Review request for Viewer. Summary --- This is actually a request for for help to debug what I have done so far to get this working. 1. In the current diff the button dose actualy hide and show according to if Voice is enabled or not. 2. i have two problems at this point. a. the space taken up by the speak button is not freed up b. when the speak button is shown after being hidden there is an error message saying no space avaiable (I think this is related to the fact that the space is not freed to begin with). This addresses bug STORM-236. http://jira.secondlife.com/browse/STORM-236 Diffs - doc/contributions.txt 40d0806e9800 indra/newview/llbottomtray.cpp 40d0806e9800 indra/newview/llspeakbutton.cpp 40d0806e9800 indra/newview/skins/default/xui/en/menu_bottomtray.xml 40d0806e9800 Diff: http://codereview.secondlife.com/r/112/diff Testing --- Thanks, Wolfpup ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Help Needed to debug small problem with code for STORM-236.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/112/#review210 --- Looks like you are only preventing the button from drawing and working, but not actually /removing/ it from the tray. Have you hunted down the code that is used to remove tray buttons when the tray is right-clicked on and an item is checked/unchecked? I would think that that is the functionality that needs to be copied onto the speak button. Maybe, as a different JIRA entry and review, you might consider what it would take to add the speak button to that tray context menu. Once the ability to remove and add the speak button via the context menu is working, it would then seem to me that this entry (STORM-236) would be trivial to implement, as all the core functionality will have been resolved already. Even if the new entry for the context menu wasn't accepted, the core functionality can still be done here. - Cron On Jan. 20, 2011, 9:29 a.m., Wolfpup Lowenhar wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/112/ --- (Updated Jan. 20, 2011, 9:29 a.m.) Review request for Viewer. Summary --- This is actually a request for for help to debug what I have done so far to get this working. 1. In the current diff the button dose actualy hide and show according to if Voice is enabled or not. 2. i have two problems at this point. a. the space taken up by the speak button is not freed up b. when the speak button is shown after being hidden there is an error message saying no space avaiable (I think this is related to the fact that the space is not freed to begin with). This addresses bug STORM-236. http://jira.secondlife.com/browse/STORM-236 Diffs - doc/contributions.txt 40d0806e9800 indra/newview/llbottomtray.cpp 40d0806e9800 indra/newview/llspeakbutton.cpp 40d0806e9800 indra/newview/skins/default/xui/en/menu_bottomtray.xml 40d0806e9800 Diff: http://codereview.secondlife.com/r/112/diff Testing --- Thanks, Wolfpup ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Help Needed to debug small problem with code for STORM-236.
On Jan. 20, 2011, 10:45 a.m., Cron Stardust wrote: Looks like you are only preventing the button from drawing and working, but not actually /removing/ it from the tray. Have you hunted down the code that is used to remove tray buttons when the tray is right-clicked on and an item is checked/unchecked? I would think that that is the functionality that needs to be copied onto the speak button. Maybe, as a different JIRA entry and review, you might consider what it would take to add the speak button to that tray context menu. Once the ability to remove and add the speak button via the context menu is working, it would then seem to me that this entry (STORM-236) would be trivial to implement, as all the core functionality will have been resolved already. Even if the new entry for the context menu wasn't accepted, the core functionality can still be done here. This Issue is for having the button hide(not be drawn) and free up the space that it normally take in the bottom tray. The problem I'm having is with the second part getting the space freed up right. Also the context menu is functional so there are no problems there. - Wolfpup --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/112/#review210 --- On Jan. 20, 2011, 9:29 a.m., Wolfpup Lowenhar wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/112/ --- (Updated Jan. 20, 2011, 9:29 a.m.) Review request for Viewer. Summary --- This is actually a request for for help to debug what I have done so far to get this working. 1. In the current diff the button dose actualy hide and show according to if Voice is enabled or not. 2. i have two problems at this point. a. the space taken up by the speak button is not freed up b. when the speak button is shown after being hidden there is an error message saying no space avaiable (I think this is related to the fact that the space is not freed to begin with). This addresses bug STORM-236. http://jira.secondlife.com/browse/STORM-236 Diffs - doc/contributions.txt 40d0806e9800 indra/newview/llbottomtray.cpp 40d0806e9800 indra/newview/llspeakbutton.cpp 40d0806e9800 indra/newview/skins/default/xui/en/menu_bottomtray.xml 40d0806e9800 Diff: http://codereview.secondlife.com/r/112/diff Testing --- Thanks, Wolfpup ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: ll_apr_warn_status: APR: No such file or directory
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/83/#review212 --- Ship it! - Oz On Jan. 14, 2011, 12:48 p.m., Aleric Inglewood wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/83/ --- (Updated Jan. 14, 2011, 12:48 p.m.) Review request for Viewer. Summary --- At start up one can get the following “warnings”: 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.logout_marker 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.llerror_marker 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.error_marker This is nonsense since it is perfectly ok when those files don’t exist. This addresses bug VWR-24317. http://jira.secondlife.com/browse/VWR-24317 Diffs - indra/newview/llappviewer.cpp b0bd26c5638a Diff: http://codereview.secondlife.com/r/83/diff Testing --- Thanks, Aleric ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: remove: Attempting to remove filename: /ramdisk/imprudence/cache/textures/*/*.texture
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/84/#review213 --- Ship it! - Oz On Jan. 16, 2011, 6:12 a.m., Aleric Inglewood wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/84/ --- (Updated Jan. 16, 2011, 6:12 a.m.) Review request for Viewer. Summary --- This turned out to be a simple matter of trying to remove non-existant files: A texture with a 'body size' of 0 doesn't have a texture body file. This addresses bug VWR-24317. http://jira.secondlife.com/browse/VWR-24317 Diffs - indra/newview/lltexturecache.cpp b0bd26c5638a Diff: http://codereview.secondlife.com/r/84/diff Testing --- Thanks, Aleric ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Where is MXP implementation ?
I'm not sure about RealXtend, but there is a MXP implementation in IdealistViewer. You should be able to see the code here: http://forge.opensimulator.org/gf/project/idealistviewer/scmsvn/?action=browsepath=%2Ftrunk%2FIdealistViewer%2FNetwork%2F On Thu, Jan 20, 2011 at 12:34 AM, Rustam Rakhimov rusyas...@gmail.comwrote: Where is MXP implementation ? hi everybody, RealXtend uses MXP but where exactly, i mean which part and where its used or implemented please let me know. if possible file name and function name thank you in advance !! ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Help Needed to debug small problem with code for STORM-236.
On Jan. 20, 2011, 10:45 a.m., Cron Stardust wrote: Looks like you are only preventing the button from drawing and working, but not actually /removing/ it from the tray. Have you hunted down the code that is used to remove tray buttons when the tray is right-clicked on and an item is checked/unchecked? I would think that that is the functionality that needs to be copied onto the speak button. Maybe, as a different JIRA entry and review, you might consider what it would take to add the speak button to that tray context menu. Once the ability to remove and add the speak button via the context menu is working, it would then seem to me that this entry (STORM-236) would be trivial to implement, as all the core functionality will have been resolved already. Even if the new entry for the context menu wasn't accepted, the core functionality can still be done here. Wolfpup Lowenhar wrote: This Issue is for having the button hide(not be drawn) and free up the space that it normally take in the bottom tray. The problem I'm having is with the second part getting the space freed up right. Also the context menu is functional so there are no problems there. As of 2.6.0.219259 the Speak button is not able to be removed from the tray using the context menu. However, the point I was trying to make was that the underlying functionality of what you are trying to accomplish here, that of removing a button and freeing up the space, is currently accomplished by the underlying functionality that the tray context menu taps into. Whether a simple (hah!) study of that code's functionality will give you what you need, or whether you do a complementary implementation of adding the (de)activation of the Speak button to the context menu, is up to you. I simply was pointing out that the underlying task is accomplished at another, potentially missed, location. If you have already studied and implemented the button (de)activation code that the tray context menu uses, then my suggestion is just noise. On the other hand, exploring what it would take to make the Speak button go away or come back via the context menu allows you to explore another code section that might result in two birds being killed with one stone: making the button removable for those who only use the keyboard or mouse toggle, and giving you the code to make the button go away when Voice isn't active. Hope that clears up the situation. To me the problem here isn't the tasks of make the button hide and then free up the space - it's about how to properly remove and re-add the button, similar to how the tray context menu works, just with a different trigger: the voice setting. - Cron --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/112/#review210 --- On Jan. 20, 2011, 9:29 a.m., Wolfpup Lowenhar wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/112/ --- (Updated Jan. 20, 2011, 9:29 a.m.) Review request for Viewer. Summary --- This is actually a request for for help to debug what I have done so far to get this working. 1. In the current diff the button dose actualy hide and show according to if Voice is enabled or not. 2. i have two problems at this point. a. the space taken up by the speak button is not freed up b. when the speak button is shown after being hidden there is an error message saying no space avaiable (I think this is related to the fact that the space is not freed to begin with). This addresses bug STORM-236. http://jira.secondlife.com/browse/STORM-236 Diffs - doc/contributions.txt 40d0806e9800 indra/newview/llbottomtray.cpp 40d0806e9800 indra/newview/llspeakbutton.cpp 40d0806e9800 indra/newview/skins/default/xui/en/menu_bottomtray.xml 40d0806e9800 Diff: http://codereview.secondlife.com/r/112/diff Testing --- Thanks, Wolfpup ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Help Needed to debug small problem with code for STORM-236.
On Jan. 20, 2011, 10:45 a.m., Cron Stardust wrote: Looks like you are only preventing the button from drawing and working, but not actually /removing/ it from the tray. Have you hunted down the code that is used to remove tray buttons when the tray is right-clicked on and an item is checked/unchecked? I would think that that is the functionality that needs to be copied onto the speak button. Maybe, as a different JIRA entry and review, you might consider what it would take to add the speak button to that tray context menu. Once the ability to remove and add the speak button via the context menu is working, it would then seem to me that this entry (STORM-236) would be trivial to implement, as all the core functionality will have been resolved already. Even if the new entry for the context menu wasn't accepted, the core functionality can still be done here. Wolfpup Lowenhar wrote: This Issue is for having the button hide(not be drawn) and free up the space that it normally take in the bottom tray. The problem I'm having is with the second part getting the space freed up right. Also the context menu is functional so there are no problems there. Cron Stardust wrote: As of 2.6.0.219259 the Speak button is not able to be removed from the tray using the context menu. However, the point I was trying to make was that the underlying functionality of what you are trying to accomplish here, that of removing a button and freeing up the space, is currently accomplished by the underlying functionality that the tray context menu taps into. Whether a simple (hah!) study of that code's functionality will give you what you need, or whether you do a complementary implementation of adding the (de)activation of the Speak button to the context menu, is up to you. I simply was pointing out that the underlying task is accomplished at another, potentially missed, location. If you have already studied and implemented the button (de)activation code that the tray context menu uses, then my suggestion is just noise. On the other hand, exploring what it would take to make the Speak button go away or come back via the context menu allows you to explore another code section that might result in two birds being killed with one stone: making the button removable for those who only use the keyboard or mouse toggle, and giving you the code to make the button go away when Voice isn't active. Hope that clears up the situation. To me the problem here isn't the tasks of make the button hide and then free up the space - it's about how to properly remove and re-add the button, similar to how the tray context menu works, just with a different trigger: the voice setting. Cron, I wonder if you have even looked at the diff as im working on adding all the functionality that you say is not present. Yes there is some thing im missing other wise I would not be receiving an error in my local repository. this work is only in my local repository at present as it is not yet ready to be posted for review but as Oz suggested i placed this here with the subject Help Needed as i believe im missing some thing important in the code and there for getting a error. This is ACTUALLY a request for ASSISTANCE from the open source community and not a review request. - Wolfpup --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/112/#review210 --- On Jan. 20, 2011, 9:29 a.m., Wolfpup Lowenhar wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/112/ --- (Updated Jan. 20, 2011, 9:29 a.m.) Review request for Viewer. Summary --- This is actually a request for for help to debug what I have done so far to get this working. 1. In the current diff the button dose actualy hide and show according to if Voice is enabled or not. 2. i have two problems at this point. a. the space taken up by the speak button is not freed up b. when the speak button is shown after being hidden there is an error message saying no space avaiable (I think this is related to the fact that the space is not freed to begin with). This addresses bug STORM-236. http://jira.secondlife.com/browse/STORM-236 Diffs - doc/contributions.txt 40d0806e9800 indra/newview/llbottomtray.cpp 40d0806e9800 indra/newview/llspeakbutton.cpp 40d0806e9800 indra/newview/skins/default/xui/en/menu_bottomtray.xml 40d0806e9800 Diff: http://codereview.secondlife.com/r/112/diff Testing --- Thanks, Wolfpup ___ Policies and
Re: [opensource-dev] Review Request: Help Needed to debug small problem with code for STORM-236.
On Jan. 20, 2011, 10:45 a.m., Cron Stardust wrote: Looks like you are only preventing the button from drawing and working, but not actually /removing/ it from the tray. Have you hunted down the code that is used to remove tray buttons when the tray is right-clicked on and an item is checked/unchecked? I would think that that is the functionality that needs to be copied onto the speak button. Maybe, as a different JIRA entry and review, you might consider what it would take to add the speak button to that tray context menu. Once the ability to remove and add the speak button via the context menu is working, it would then seem to me that this entry (STORM-236) would be trivial to implement, as all the core functionality will have been resolved already. Even if the new entry for the context menu wasn't accepted, the core functionality can still be done here. Wolfpup Lowenhar wrote: This Issue is for having the button hide(not be drawn) and free up the space that it normally take in the bottom tray. The problem I'm having is with the second part getting the space freed up right. Also the context menu is functional so there are no problems there. Cron Stardust wrote: As of 2.6.0.219259 the Speak button is not able to be removed from the tray using the context menu. However, the point I was trying to make was that the underlying functionality of what you are trying to accomplish here, that of removing a button and freeing up the space, is currently accomplished by the underlying functionality that the tray context menu taps into. Whether a simple (hah!) study of that code's functionality will give you what you need, or whether you do a complementary implementation of adding the (de)activation of the Speak button to the context menu, is up to you. I simply was pointing out that the underlying task is accomplished at another, potentially missed, location. If you have already studied and implemented the button (de)activation code that the tray context menu uses, then my suggestion is just noise. On the other hand, exploring what it would take to make the Speak button go away or come back via the context menu allows you to explore another code section that might result in two birds being killed with one stone: making the button removable for those who only use the keyboard or mouse toggle, and giving you the code to make the button go away when Voice isn't active. Hope that clears up the situation. To me the problem here isn't the tasks of make the button hide and then free up the space - it's about how to properly remove and re-add the button, similar to how the tray context menu works, just with a different trigger: the voice setting. Wolfpup Lowenhar wrote: Cron, I wonder if you have even looked at the diff as im working on adding all the functionality that you say is not present. Yes there is some thing im missing other wise I would not be receiving an error in my local repository. this work is only in my local repository at present as it is not yet ready to be posted for review but as Oz suggested i placed this here with the subject Help Needed as i believe im missing some thing important in the code and there for getting a error. This is ACTUALLY a request for ASSISTANCE from the open source community and not a review request. Wolfpup, I am trying to give assistance. Just like I assist my fellow CS students in the programming labs when I'm not familiar with the details of what they are implementing. Yes, I have looked over the diff. Yet since I have never gotten a build environment that worked for more than a day, I didn't have the time (back when I did have the time) to learn the ins and outs of the viewer codebase. Since then I've not had the time to do more than glance over other people's code. Hopefully I will learn enough from that to start working changes myself when I have time again. Since I don't have a build env, I can't help with straight debugging. However, I believe that my points and information may be valid and useful in helping direct your mind to a solution, even though I cannot supply one. Often when I have a coding problem, I'll even go so far as to explain it to an artist: their eyes may glaze over, but in their ignorance of how things work in programming sometimes makes them able to point out areas to explore or solutions that I never would have thought of. Such is what I'm trying to do here: provide you with a way around the barrier. Not by going straight through the barrier, as I don't have that solution, but by pointing out a possible doorway further down the wall. However, to keep up the simile, if you've already tried that door and found it locked, then let me know, and I'll either try to point out another door, or shut up waiting for another person to find a way through. - Cron
[opensource-dev] Review Request: STORM-236 Actual Code Review
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/113/ --- Review request for Viewer. Summary --- This allows the Speak Button to auto-hide for those that do not use Voice at all. This addresses bug STORM-236. http://jira.secondlife.com/browse/STORM-236 Diffs - doc/contributions.txt 9c7d543fd15d indra/newview/llbottomtray.h 9c7d543fd15d indra/newview/llbottomtray.cpp 9c7d543fd15d indra/newview/llspeakbutton.cpp 9c7d543fd15d indra/newview/skins/default/xui/en/menu_bottomtray.xml 9c7d543fd15d Diff: http://codereview.secondlife.com/r/113/diff Testing --- Built locally and did the following: 1 Verified that when Voice is toggled via the preference panel the Speak Button auto hid/showed. 2 Verified that drag and drop functionality of the Speak Button was not affected. 3 Went to a non-Voice area with Voice active and verified that button was still there but grayed out. Thanks, Wolfpup ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Daily Scrum Summary - Thursday, January 20, 2011
Thursday, January 20, 2011 General Notes
--
- MMOTD: Oz
- Please remember to put descriptions next to the jira number in your
report when possible.
Team Status
--
Merov Linden
--
*PAST*
- STORM-745 : KDU Perf : Got Linux data. The results are strange so I
decided to run on Mac again before posting.
- STORM-748 : KDU_X86_INTRINSICS : Discovered autobuild recent changes,
need to update kdu-autobuild to take them into account (TC build broken
right now). In progress.
- Bunch of LL meetings
*FUTURE*
- SH-761 : test and move to integration
- STORM-748 : Fix TC builds
- STORM-745 : Re-run Mac stats
*IMPEDIMENTS*
- none
Oz Linden
--
*PAST*
- Merge Monkey
- Office Hour
- Wiki updates to Snowstorm calendar meetings
*FUTURE*
- Merge Monkey
- Patch triage from codereview
*IMPEDIMENTS*
- moving large amounts of slush around :-(
Q Linden
--
*PAST*
- STORM-725
- STORM-864
- VWR-24426
- SOCIAL-452
- STORM-243
- Internal meetings
- Snowstorm weekly meeting
- 2.5 beta 1
*FUTURE*
- VWR-24426
- Dr's appt today
- triage
*IMPEDIMENTS*
- Not enough rope to tie esbee to her chair. :(
Esbee Linden
--
*PAST*
- Meetings, Email
- My last OH :(
- Jira ticket reviews and cleanup
*FUTURE*
- Review Snowstorm Team product backlog and bug log
- Tix which require feedback: STORM-28, -812, -226, -174
- Review developer build for the tix in the PO review queue:
STORM-2, -383, -484, -844, -834, -832, -715
https://jira.secondlife.com/secure/IssueNavigator.jspa?requestId=13662mode=hide
- Hopefully work on STORM-26 w/Q
- Review tickets assigned to me
*IMPEDIMENTS*
- None
Paul ProductEngine
--
*PAST*
- BUG STORM-665 (User is not able to view full name of Group's founder in
the Group Profile)
- Investigated and resolved as cannot reproduce
- BUG STORM-629 (Place Rating text is quoted and is not translated in
Polish localization)
- Investigated and assigned to Eli.
- BUG STORM-612 ('Didn't find..' text overlaps My inventory folder name
in Pick Texture window)
- Tried to reproduce. Tomorrow will try again.
- BUG STORM-680 (Avaline callers are added to the Recent list)
- Worked on this bug, but it'll take much more time to fix it without
debugger. For some reason voice is unavailable in debug mode (in
Linux). As
tomorrow I'll install Windows on my machine, in which voice is working in
debug mode, I'll fix it.
- BUG STORM-513 (Allow media to auto - play check-box is enable after
Media check-box was unchecked)
- WIP. 90%. Estimate ~ 1 hour.
*FUTURE*
- Install Windows 7 on my machine as second OS.
- BUG STORM-513 (Allow media to auto - play check-box is enable after
Media check-box was unchecked)
- BUG STORM-680 (Avaline callers are added to the Recent list)
*IMPEDIMENTS*
- none
Seth Productengine
--
*PAST*
- BUG (STORM-316) Debug: Inventory.Folders by Name/Sort by Date/Sort by
Name/System Folders to Top Do not apply and settings changes do not persist
after relogging.
- Resolved as Cannot Reproduce. Inventory sorting seems to work as
expected if inventory items could be sorted by date and folders
are always
sorted by name.
- Story (STORM-526) Log out failure during Login causes loss of pending
offers, including inventory
- Investigating.
*FUTURE*
- Story (STORM-526) Log out failure during Login causes loss of pending
offers, including inventory
*IMPEDIMENTS*
- none
Vadim Productengine
--
*PAST*
- Bug STORM-373 ('Rename' is sometimes disabled in inventory item context
menu):
- Submitted fix.
- Bug STORM-465 (Missing Strings from strings.xml):
-
Completed the fix and posted it for review.
- Bug STORM-348 (Edit this shape button button and lock icon are
shown after each body part name after resizing the floater):
- Fixed.
*FUTURE*
- Pick something from the bug queue.
*IMPEDIMENTS*
- Unclear what to do with STORM-174 (Checkbox needed to save inventory
scripts as Mono): the feature requires simulator work.
- Please write up an SVC issue and link to STORM-174
- No clear acceptance criteria for STORM-226 (Floating Text aligns
improperly).
- Q will close issue
- Need an answer from PO in STORM-610 (Changes to Environment Editor:
water color change is not saved).
- it’s a bug
Wolfpup Lowenhar
--
*PAST*
- Worked @ RL and in world.
- STORM-236 : Made Changes that were sugested @ the Snowstorm OH also
followed Oz's sugestion to use the RB system to get help with code.
*FUTURE*
- Work @ RL
Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/#review221 --- I fail to see how any of those changes massively prevents object duplication. I don't disagree with any of them but I don't see much value in any either. Sure, there are different ways to skin a cat and some are better. Still, these changes will likely make upcoming merges conflict annoyingly and make the life of the maintainers (i.e. mine and Oz) horrid. It reminded me of this post by another (more famous) Open Source maintainer: http://tirania.org/blog/archive/2010/Dec-31.html - Merov On Jan. 16, 2011, 5:53 a.m., Aleric Inglewood wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/ --- (Updated Jan. 16, 2011, 5:53 a.m.) Review request for Viewer. Summary --- Turns out that most of my SNOW-800 patch was included in Viewer 2 (albeit without crediting me). However, not everything was used and some more cleaning up was possible. After this patch, and when compiling with optimization, there are no duplicates left anymore that shouldn't be there in the first place: apart from the debug stream iostream guard variable, there are several static variables with the same name (r, r1, r2, etc) but that indeed actually different symbol objects. Then there are a few constant POD arrays that are duplicated a hand full of times because they are accessed with a variable index (so optimizing them away is not possible). I left them like that (although defining those as extern as well would have been more consistent and not slower; in fact it would be faster theoretically because those arrays could share the same cache page then). This addresses bug VWR-24312. http://jira.secondlife.com/browse/VWR-24312 Diffs - doc/contributions.txt 422f636c3343 indra/llcharacter/llanimationstates.cpp 422f636c3343 indra/llcommon/llavatarconstants.h 422f636c3343 indra/llcommon/lllslconstants.h 422f636c3343 indra/llcommon/llmetricperformancetester.h 422f636c3343 indra/llmath/llcamera.h 422f636c3343 indra/llmath/llcamera.cpp 422f636c3343 indra/newview/llviewerobject.cpp 422f636c3343 indra/newview/llvoavatar.cpp 422f636c3343 indra/newview/llvosky.h 422f636c3343 indra/newview/llvosky.cpp 422f636c3343 Diff: http://codereview.secondlife.com/r/81/diff Testing --- Compiled with optimization and then running readelf on the executable to find duplicated symbols. Thanks, Aleric ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/#review223 --- Ship it! Seems good. Glad to see a TODO being dealt with :) - Merov On Jan. 17, 2011, 5:24 a.m., Aleric Inglewood wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/ --- (Updated Jan. 17, 2011, 5:24 a.m.) Review request for Viewer. Summary --- See https://jira.secondlife.com/browse/VWR-24311 Basically, this fixes the TODO comment in install.py but with the difference that we really want to uninstall any old package with the same name, different md5 or not. This addresses bug VWR-24311. http://jira.secondlife.com/browse/VWR-24311 Diffs - doc/contributions.txt 422f636c3343 scripts/install.py 422f636c3343 Diff: http://codereview.secondlife.com/r/80/diff Testing --- Loads of testing on linux... Installing new packages now cleanly removes the old one first. Thanks, Aleric ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: VWR-24337: Possible crash on llassert_always(purge_list.size() = entries_to_purge)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/93/#review224 --- indra/newview/lltexturecache.cpp http://codereview.secondlife.com/r/93/#comment154 I get it but it's a bit unsettling to have the condition seemingly unrelated to the iterator. I'd rather have a while () construction here so it's more clear what the intent is. - Merov On Jan. 14, 2011, 1:09 p.m., Aleric Inglewood wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/93/ --- (Updated Jan. 14, 2011, 1:09 p.m.) Review request for Viewer. Summary --- Just fixed the logic, so entries_to_purge won't become negative anymore, and the rest. This addresses bug VWR-24337. http://jira.secondlife.com/browse/VWR-24337 Diffs - doc/contributions.txt b0bd26c5638a indra/newview/lltexturecache.cpp b0bd26c5638a Diff: http://codereview.secondlife.com/r/93/diff Testing --- Thanks, Aleric ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: VWR-24347 Reversion in Copy3rdPartyLibs.cmake -- cannot find msvc* files using VS 2005 Express
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/68/#review226 --- Ship it! Though we'll be moving to VS 2010, this patch will help some folks in the community. - Merov On Dec. 29, 2010, 3:42 p.m., Jonathan Yap wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/68/ --- (Updated Dec. 29, 2010, 3:42 p.m.) Review request for Viewer. Summary --- Environment: Windows, VS 2005 Express Back in the days of v2.1 I was able to supply the following option to develop.py, which would allow me to specify the location of msvcr80.dll msvcp80.dll Microsoft.VC80.CRT.manifest -DMSVC_REDIST_PATH:PATH=E:/some/path There was a similar code path for the debug files -DMSVC_DEBUG_REDIST_PATH=E:/some/path This files cannot be found by the Express compiler so without a way of telling the compiler where to find them they have to be dropped into the build tree manually. At some point Copy3rdPartyLibs.cmake was rewritten and this option was dropped. This addresses bug vwr-24347. http://jira.secondlife.com/browse/vwr-24347 Diffs - indra/cmake/Copy3rdPartyLibs.cmake 27dae7b01a81 Diff: http://codereview.secondlife.com/r/68/diff Testing --- I tried using -DMSVC_REDIST_PATH:PATH=E:/some/path with my VS 2005 Express compiler and obtained the desired result. I don't have the debug files to test -DMSVC_DEBUG_REDIST_PATH=E:/some/path Thanks, Jonathan ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: VWR-24520: Don't use pkg_check_modules( ... QUIET ) on CMake 2.8.2
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/97/#review227 --- Ship it! I'm advising the MM to merge in a test repo and do a full TC cycle on all platforms before merging though... - Merov On Jan. 17, 2011, 10:03 a.m., Boroondas Gupte wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/97/ --- (Updated Jan. 17, 2011, 10:03 a.m.) Review request for Viewer. Summary --- Only use QUIET in pkg_check_modules() on CMake =2.8.2 (where it's supported) rather than already on CMake =2.8. This addresses bug VWR-24520. http://jira.secondlife.com/browse/VWR-24520 Diffs - doc/contributions.txt 9e99b2c8fb28 indra/cmake/FindLLQtWebkit.cmake 9e99b2c8fb28 Diff: http://codereview.secondlife.com/r/97/diff Testing --- Configured (standalone) without a .pgk file for libllqtwebkit on Linux with CMake 2.8.1 and CMake 2.8.3. Output as expected. Not tested: * CMake 2.8.2 * system with a .pgk file for libllqtwebkit * non-standalone * Mac, Win Thanks, Boroondas ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: VWR-24519: Spawning of the 'spare' media plugin process makes debugging SLPlugin harder
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/96/#review228 --- Ship it! Useful! Ship it. - Merov On Jan. 17, 2011, 9:13 p.m., Aleric Inglewood wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/96/ --- (Updated Jan. 17, 2011, 9:13 p.m.) Review request for Viewer. Summary --- This patch stops early spawns of spare media plugin processes when the debug setting PluginAttachDebuggerToPlugins is set. The result should be that the terminal with gdb session that pops up when you open a media is the correct one that you intend to debug (instead of an idle one that does nothing; while the process that you want to debug was already spawned an arbitrary amount of time before). This addresses bug VWR-24519. http://jira.secondlife.com/browse/VWR-24519 Diffs - indra/newview/llviewermedia.cpp 422f636c3343 Diff: http://codereview.secondlife.com/r/96/diff Testing --- Thanks, Aleric ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
